AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
d46b8d2bab
skia2/experimental
History
robertphillips d46b8d2bab Revert of Fix SkTextBlob offset semantics. (patchset #2 id:20001 of https://codereview.chromium.org/605533002/) 
Reason for revert:
Breaking the Chrome builds with the error:

[14:54:14.317833] ../../skia/ext/pixel_ref_utils.cc:221:16: error: 'drawPosText' marked 'override' but does not override any member functions
[14:54:14.318022]   virtual void drawPosText(const SkDraw& draw,
[14:54:14.318082]                ^

Original issue's description:
> Fix SkTextBlob offset semantics.
>
> Implement proper x/y drawTextBlob() handling by plumbing a
> drawPosText() offset parameter (to act as an additional glyph pos
> translation) throughout the device layer.
>
> The new offset superceeds the existing constY, with a minor semantic
> tweak: whereas previous implementations were ignoring constY in 2D
> positioning mode (scalarsPerGlyph == 2), now the offset is always
> observed, in all positioning modes. We can do this because existing
> drawPosText() clients always pass constY == 0 for full positioning mode.
>
> R=reed@google.com, jvanverth@google.com, robertphillips@google.com
>
> Committed: https://skia.googlesource.com/skia/+/c13bc571d3e61a43b87eb97f0719abd304cafaf2

R=jvanverth@google.com, reed@google.com, bsalomon@google.com, fmalita@chromium.org
TBR=bsalomon@google.com, fmalita@chromium.org, jvanverth@google.com, reed@google.com
NOTREECHECKS=true
NOTRY=true

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/609223003
2014-09-29 04:48:52 -07:00
..
AndroidPathRenderer replace old SK_TRACE_EVENT macros with new TRACE_EVENT ones, and then remove them entirely! 2014-03-20 20:00:24 +00:00
benchtools bench rebase tool: add ability to specify a second CL for fluctuating data adjustment. 2014-07-08 14:36:56 -07:00
ChromeUtils Sanitizing source files in Housekeeper-Nightly 2013-12-11 07:02:06 +00:00
DrawingBoard remove SkFloatToScalar macro 2013-11-25 19:44:07 +00:00
expectations/skp add headers to experimental SKP expectations 2014-08-20 11:51:39 -07:00
FileReaderApp Sanitizing source files in Skia_Periodic_House_Keeping 2013-01-26 07:06:02 +00:00
Intersection Define NDEBUG instead of SK_DEBUG/SK_RELEASE. 2014-08-20 07:38:46 -07:00
iOSSampleApp share dm and command flags 2014-07-22 10:15:35 -07:00
iOSShell ios fixes 2014-07-11 12:14:51 -07:00
LightSymbolsUtil Use lowercase windows.h in includes to fix Windows cross compilation using mingw. 2013-12-03 15:23:37 +00:00
nanomsg Change SkPicture::draw to playback 2014-09-04 08:42:50 -07:00
Networking Sanitizing source files in Skia_Periodic_House_Keeping 2013-01-26 07:06:02 +00:00
PdfViewer Revert of Fix SkTextBlob offset semantics. (patchset #2 id:20001 of https://codereview.chromium.org/605533002/) 2014-09-29 04:48:52 -07:00
pixman Sanitizing source files in Skia_Periodic_House_Keeping 2012-10-17 02:01:13 +00:00
SimpleCocoaApp Revert "If the path is a rect, call drawRect to raster the geometry in SkCanvas::drawPath to get better performance." 2013-10-22 16:54:15 +00:00
SimpleiOSApp share dm and command flags 2014-07-22 10:15:35 -07:00
SkiaExamples Remove unused (by clients) SkUnitMapper 2014-05-22 12:27:41 +00:00
SkV8Example https://chromiumcodereview.appspot.com/331133004/ 2014-07-15 11:11:25 -04:00
StrokePathRenderer Remove more unnamed namespace usages. 2014-01-23 02:02:57 +00:00
webtry Reinitialize monit to changes take effect. 2014-09-26 06:10:00 -07:00
SkSetPoly3To3_A.cpp remove SK_SCALAR_IS_[FLOAT,FIXED] and assume floats 2013-12-17 16:44:46 +00:00
SkSetPoly3To3_D.cpp Sanitizing source files in Skia_Periodic_House_Keeping 2013-01-26 07:06:02 +00:00
SkSetPoly3To3.cpp Sanitizing source files in Skia_Periodic_House_Keeping 2013-01-26 07:06:02 +00:00