AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
d46b8d2bab
skia2/experimental/PdfViewer
History
robertphillips d46b8d2bab Revert of Fix SkTextBlob offset semantics. (patchset #2 id:20001 of https://codereview.chromium.org/605533002/) 
Reason for revert:
Breaking the Chrome builds with the error:

[14:54:14.317833] ../../skia/ext/pixel_ref_utils.cc:221:16: error: 'drawPosText' marked 'override' but does not override any member functions
[14:54:14.318022]   virtual void drawPosText(const SkDraw& draw,
[14:54:14.318082]                ^

Original issue's description:
> Fix SkTextBlob offset semantics.
>
> Implement proper x/y drawTextBlob() handling by plumbing a
> drawPosText() offset parameter (to act as an additional glyph pos
> translation) throughout the device layer.
>
> The new offset superceeds the existing constY, with a minor semantic
> tweak: whereas previous implementations were ignoring constY in 2D
> positioning mode (scalarsPerGlyph == 2), now the offset is always
> observed, in all positioning modes. We can do this because existing
> drawPosText() clients always pass constY == 0 for full positioning mode.
>
> R=reed@google.com, jvanverth@google.com, robertphillips@google.com
>
> Committed: https://skia.googlesource.com/skia/+/c13bc571d3e61a43b87eb97f0719abd304cafaf2

R=jvanverth@google.com, reed@google.com, bsalomon@google.com, fmalita@chromium.org
TBR=bsalomon@google.com, fmalita@chromium.org, jvanverth@google.com, reed@google.com
NOTREECHECKS=true
NOTRY=true

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/609223003
2014-09-29 04:48:52 -07:00
..
inc SkNonCopyable should be used with private inheritance. 2014-04-07 19:34:38 +00:00
pdfparser Remove SkPdfNativeDoc::tokenizerOfStream. 2013-12-03 16:15:31 +00:00
scripts Add a script for running pdfviewer and comparing to existing results. 2013-11-12 14:52:47 +00:00
src hide SkBitmap::setConfig 2014-06-09 19:52:07 -07:00
chop_transparency_main.cpp Cleanup: Rename SkOSPath functions. 2014-07-28 19:26:58 -07:00
pdf_viewer_main.cpp Revert "Revert "Move SkGpuDevice.h to src/gpu"" 2014-09-17 07:44:25 -07:00
SkNulCanvas.cpp pdfviewer: code cleanup - add licence on files, make replace __DEFINE__foo with foo_DEFINED to match skia project 2013-08-21 16:31:37 +00:00
SkNulCanvas.h Hide fields in SkImageInfo 2014-09-03 11:54:58 -07:00
SkPdfConfig.h mode code cleanup (100c / l, comments) 2013-10-10 20:58:22 +00:00
SkPdfFont.cpp Small tweaks to be able to build everything target: 2014-01-08 21:16:14 +00:00
SkPdfFont.h Small tweaks to be able to build everything target: 2014-01-08 21:16:14 +00:00
SkPdfGraphicsState.cpp Factory methods for heap-allocated SkPathEffect and SkXfermode objects. 2014-02-20 20:40:19 +00:00
SkPdfGraphicsState.h Move SkPdfContext into its own files. 2013-11-20 22:33:39 +00:00
SkPdfReporter.cpp Changes to SkTDStackNester. 2013-11-20 21:40:57 +00:00
SkPdfReporter.h Changes to SkTDStackNester. 2013-11-20 21:40:57 +00:00
SkPdfUtils.cpp pdfviewer: code cleanup - add licence on files, make replace __DEFINE__foo with foo_DEFINED to match skia project 2013-08-21 16:31:37 +00:00
SkPdfUtils.h pdfviewer: more code comments + concat the pdf matrix with the existing matrix in canvas, instead of reseting it. 2013-10-11 18:26:45 +00:00
SkTrackDevice.cpp pdfviewer: code cleanup - add licence on files, make replace __DEFINE__foo with foo_DEFINED to match skia project 2013-08-21 16:31:37 +00:00
SkTrackDevice.h Revert of Fix SkTextBlob offset semantics. (patchset #2 id:20001 of https://codereview.chromium.org/605533002/) 2014-09-29 04:48:52 -07:00
SkTracker.cpp pdfviewer: code cleanup - add licence on files, make replace __DEFINE__foo with foo_DEFINED to match skia project 2013-08-21 16:31:37 +00:00
SkTracker.h pdfviewr: include what you use (stdio) 2013-11-07 22:07:34 +00:00