Commit Graph

40774 Commits

Author SHA1 Message Date
recipe-roller
909a118fdf Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/4492c37a14be41e3a3bf53234c53671b6e649a8e [gclient] enable git protocol version 2 for windows (tikuta@chromium.org)
  https://crrev.com/57dd17b46eac63b29d10a7f081fd8175f8ba49c9 expose temporary_directory. (yyanagisawa@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I86da60c3caa168703baef8437d3aadfb007cc891
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/202998
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2019-03-22 09:52:40 +00:00
skia-autoroll
4dba3b116d Roll third_party/externals/swiftshader b55772e6e7dd..3f9c56c3cd54 (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/b55772e6e7dd..3f9c56c3cd54


git log b55772e6e7dd..3f9c56c3cd54 --date=short --no-merges --format='%ad %ae %s'
2019-03-22 bclayton@google.com .gitignore: .vscode/ipch directory


Created with:
  gclient setdep -r third_party/externals/swiftshader@3f9c56c3cd54

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=brianosman@google.com

Change-Id: Iba86c1063f3cb230c1f09acfc5d30bfedd4a6f17
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203001
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-03-22 09:10:40 +00:00
skia-autoroll
f4af3608b9 Roll third_party/externals/angle2 2219b18c984e..9e586a0f8a1c (1 commits)
2219b18c98..9e586a0f8a


git log 2219b18c984e..9e586a0f8a1c --date=short --no-merges --format='%ad %ae %s'
2019-03-21 jonahr@google.com Prevent vk shader generator from using anything but ANGLE's out.


Created with:
  gclient setdep -r third_party/externals/angle2@9e586a0f8a1c

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=brianosman@google.com

Change-Id: Ia00967be2100b2e53741737e9f76b7e7c176d6ce
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203000
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-03-22 06:14:40 +00:00
skia-recreate-skps
5d7090f2ea Update go_deps asset
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: Idfab800e4110152a78e14da3393617f1cfb7749d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/202990
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2019-03-22 05:54:30 +00:00
recipe-roller
a39bbdad93 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/65ace12763293189a7e3db9390bc859c2eb0d68e do not decrements countdown when that is 0 (tikuta@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I52a97f2be6a431dc5832e67cb78cb9d637af68ac
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/202903
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2019-03-22 04:42:39 +00:00
recipe-roller
b46b1d86af Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/33bd5822245c5b1ace318f3a5340a983889d07c7 Make git-nav-upstream include the current branch name (leszeks@chromium.org)
  https://crrev.com/793183d37d50f3545e897b270229dea8d247a4a6 Make `git map-branches` detect and report cycles (clemensh@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ic8cbb79ffad5e6a0f786c8bd94b5d01e3531c387
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/202901
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2019-03-22 01:52:19 +00:00
skia-autoroll
d0995493f8 Roll third_party/externals/swiftshader 80c796becc43..b55772e6e7dd (2 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/80c796becc43..b55772e6e7dd


git log 80c796becc43..b55772e6e7dd --date=short --no-merges --format='%ad %ae %s'
2019-03-21 capn@google.com Use Kokoro configs/scripts for SwiftShader under tests/kokoro/ directory
2019-03-21 chrisforbes@google.com Remove remaining UBO & constants junk from DrawData


Created with:
  gclient setdep -r third_party/externals/swiftshader@b55772e6e7dd

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=brianosman@google.com

Change-Id: I377927db52395b3fac569324b9075766372cb282
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/202731
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-03-21 22:39:19 +00:00
skia-autoroll
8a207eb99e Roll third_party/externals/swiftshader 4ecc9d4073ce..80c796becc43 (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/4ecc9d4073ce..80c796becc43


git log 4ecc9d4073ce..80c796becc43 --date=short --no-merges --format='%ad %ae %s'
2019-03-21 capn@google.com Rename Intermediate::emplace() to move()


Created with:
  gclient setdep -r third_party/externals/swiftshader@80c796becc43

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=brianosman@google.com

Change-Id: Ied4e95b5876f643f2b5184a62fddee6fa580f976
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/202730
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-03-21 21:55:59 +00:00
skia-autoroll
27cebefde0 Roll ../src b57a03014063..9aca4d1c479e (502 commits)
b57a030140..9aca4d1c47


Created with:
  gclient setdep -r ../src@9aca4d1c47

The AutoRoll server is located here: https://autoroll.skia.org/r/chromium-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Release-All-CommandBuffer;skia.primary:Test-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Debug-All-CommandBuffer
TBR=brianosman@google.com

Change-Id: I53a83918f63cf447301164d2b90435d1db4ffc2e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/202728
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-03-21 21:54:29 +00:00
Ben Wagner
cc8eb86c37 Make zoom in viewer exponential.
The previous linear zoom fits into about -2 to 2 in the new system. By
keeping the old linear values (instead of making the slider exponential)
the up and down keys can still be used to get away from and back to no
zoom. The new zoom allows for a much larger range of zoom, allowing more
issues to be seen.

Change-Id: I9ba8cf2c3c8d610a21a8c8598e0f5150eeb04ad8
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/202940
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2019-03-21 21:30:49 +00:00
Ravi Mistry
24341cdd9c Fix upload collisions in the AndroidOne SkottieTracing bot
Bug: skia:8884
Change-Id: I059be73709b9ee75cd6d84ccfc8ceacb16fab8f3
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/202900
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2019-03-21 21:21:49 +00:00
Chris Dalton
82eb9e75d1 Rename GrAAFillRRectOp to GrFillRectOp
Next up are changes to support non-aa and MSAA.

Bug: skia:
Change-Id: I944af201d92b1391f7937aabddf774e79fef8dc2
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/202920
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2019-03-21 21:19:29 +00:00
skia-autoroll
d41fd8e7fd Roll third_party/externals/angle2 232bfeae6b29..2219b18c984e (6 commits)
232bfeae6b..2219b18c98


git log 232bfeae6b29..2219b18c984e --date=short --no-merges --format='%ad %ae %s'
2019-03-21 tobine@google.com Vulkan:Optimize SecondaryCommandBuffers
2019-03-21 jmadill@chromium.org Force new displays on each Windows 7 end2end test.
2019-03-21 jmadill@chromium.org Work around line loop streaming bug.
2019-03-21 jonahr@google.com Fix locale being reset to default after ShCompileTest.DecimalSepLocale
2019-03-21 tobine@google.com Vulkan:Integrate SecondaryCommandBuffers
2019-03-21 jonahr@google.com run_code_generation.py should fail more gracefully on find out dir.


Created with:
  gclient setdep -r third_party/externals/angle2@2219b18c984e

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=brianosman@google.com

Change-Id: I9295625dd25824c63348ec8c1e29ab513e82a6e1
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/202727
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-03-21 21:13:49 +00:00
skia-autoroll
2fb5078029 Roll third_party/externals/swiftshader 603a1b53f72e..4ecc9d4073ce (2 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/603a1b53f72e..4ecc9d4073ce


git log 603a1b53f72e..4ecc9d4073ce --date=short --no-merges --format='%ad %ae %s'
2019-03-21 chrisforbes@google.com Ensure image strides are always suitable for the rasterizer
2019-03-21 sugoi@google.com vkCmdExecuteCommands implementation


Created with:
  gclient setdep -r third_party/externals/swiftshader@4ecc9d4073ce

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=brianosman@google.com

Change-Id: Iba7a912ec4eb77b61cd38e7446f9f32d88ebe30a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/202729
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-03-21 21:03:59 +00:00
Brian Salomon
5ad6fd3160 Put SkImageInfo on SkImage to avoid cost of reconstructing for queries.
Previously calling SkImage::alphaType(), for example, woult call
the virtual SkImage_Base::onImageInfo() which would construct
and return a temporary SkImageInfo. This often meant ref-ing a
SkColorSpace.


Change-Id: I54975a6b20dea5bc84739068df0c81c022a12067
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/202711
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Mike Reed <reed@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2019-03-21 20:07:34 +00:00
skia-autoroll
adc94d96bb Roll third_party/externals/swiftshader 7bc4f45a391f..603a1b53f72e (2 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/7bc4f45a391f..603a1b53f72e


git log 7bc4f45a391f..603a1b53f72e --date=short --no-merges --format='%ad %ae %s'
2019-03-21 chrisforbes@google.com Fix provoking vertex convention and remove configurability
2019-03-21 chrisforbes@google.com Synchronize at end of renderpass


Created with:
  gclient setdep -r third_party/externals/swiftshader@603a1b53f72e

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=brianosman@google.com

Change-Id: I2dfde20862c9c3ff4b2247928766b4f8f2efa89b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/202841
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-03-21 19:41:44 +00:00
Greg Daniel
655002b8b0 In viewer measure and show full frame times.
This updates viewer to show the full frametime including getting new buffers
and presenting buffers to the screen. This is more useful information than
simply the sum the flush and paint.

In a follow up CL we'll enable disabling vsync so we can truly measure how
long it takes us to draw.

Bug: skia:
Change-Id: Ibdbf16b37b44309fca6e771272ce38fd31a0e95c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/202708
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2019-03-21 19:30:06 +00:00
Mike Klein
19fb3971bc de-common some flags
Move flags used only in one place to that place,
and remove a couple unused flags.

Change-Id: I0504d9583d464377e84ab28ce378d6da1e99ac3e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/202802
Auto-Submit: Mike Klein <mtklein@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2019-03-21 18:55:34 +00:00
Jim Van Verth
9445f8e0b4 Revert "Fix blurry edges on large ovals."
This reverts commit c7aed036c3.

Reason for revert: Breaking low precision bots

Original change's description:
> Fix blurry edges on large ovals.
> 
> Changes the precision for the GrOvalOpFactory shaders to be float rather than half. In the
> low-precision case, it falls back to a path renderer for large ovals.
> 
> Bug: b/110380864, skia:8873
> Change-Id: I89e8dd067a2e0cab35b1bb515adaab4a2fb4f222
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/201615
> Commit-Queue: Jim Van Verth <jvanverth@google.com>
> Reviewed-by: Brian Salomon <bsalomon@google.com>

TBR=jvanverth@google.com,bsalomon@google.com

Change-Id: Iccfcfda139625ff7a2efdb39ccdbc05227840052
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: b/110380864, skia:8873
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/202717
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
2019-03-21 18:50:55 +00:00
Brian Osman
e1e988d6be Add maksing to SkSL byte code generator to please MSVC's RTC
Bug: skia:
Change-Id: I5d4b8ce195b57e5dd08602cfe21a0d461628c527
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/202712
Commit-Queue: Brian Osman <brianosman@google.com>
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Auto-Submit: Brian Osman <brianosman@google.com>
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2019-03-21 18:46:04 +00:00
Kevin Lubick
025949e0f7 [canvaskit] npm version 0.5.1
Fixes a build flag

Bug: skia:
Change-Id: I51f0fff18415fba5ea8396189aeab8a40f196c70
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/202713
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
2019-03-21 18:35:18 +00:00
Ethan Nicholas
a185562af3 fix Google3 roll
Bug: skia:
Change-Id: I26428e032ac79f0fa489516479c7ca279ae3afd0
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/202710
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Auto-Submit: Ethan Nicholas <ethannicholas@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2019-03-21 18:27:09 +00:00
Ben Wagner
15a8d57175 Add font scale and skew in x to viewer.
Also change the names of some fields to remove the now redundant 'Text'
specification to make things fit on lines.

Change-Id: I4503eebaea406e82a1332dade0b6aea7dddf281f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/202709
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2019-03-21 18:22:28 +00:00
Ben Wagner
3e685ea164 Always draw emoji with GPU.
Remove some illogical code which prevents large font size requests for
color fonts from working, and add a large mask fallback when drawing
with masks and there are no paths available.

Change-Id: I3e8c1dfc124cd315278b42cfcfebb39fc32212b8
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/202420
Commit-Queue: Ben Wagner <bungeman@google.com>
Reviewed-by: Herb Derby <herb@google.com>
2019-03-21 18:16:38 +00:00
Jim Van Verth
87966556a1 Check for null parameter to SkOffsetSimplePolygon
Bug: oss-fuzz:13550
Change-Id: I7ca06a44214290fe283b151f71d8f44a3ffbe225
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/202707
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Auto-Submit: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2019-03-21 17:53:29 +00:00
Ravi Mistry
b804856c60 Add new AndroidOne SkottieTracing bot
Bug: skia:8884
Change-Id: Iff6e8da803c0cf76d4d2888af12e97b7491b0993
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/201473
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2019-03-21 17:52:28 +00:00
Michael Ludwig
d9958f865c Use YUV effect in drawEdgeAAImageSet
Adds YUV planar image to the compositor_quads_image GM, confirmed
locally that it uses the effect instead of flattening the planes
into a single proxy (like before).

Bug: skia:
Change-Id: I0dea16bbaae34ae44cb1b51db9d2953231a6bf22
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/201619
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2019-03-21 17:43:28 +00:00
Mike Klein
5b3f343d25 DEFINE_int32 + DEFINE_uint32 -> DEFINE_int
There's really no big benefit to distinguishing these.

Change-Id: Ib329d32b1fc43e98ba40658cfea37261203ecdb9
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/202801
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2019-03-21 17:20:19 +00:00
Brian Osman
f9666f5467 Remove SkColorSpaceXformCanvas, and supporting code:
- SkColorSpaceXformer
- makeColorSpace on SkShader, SkColorFilter,
  SkImageFilter, SkDrawLooper, and SkLights
- DM support and some bot configs

Bug: skia:8773
Change-Id: I16ef8f487de6c35329b3b0474c1d66d7fa0a6220
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/202430
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Reed <reed@google.com>
2019-03-21 17:12:33 +00:00
Jim Van Verth
c7aed036c3 Fix blurry edges on large ovals.
Changes the precision for the GrOvalOpFactory shaders to be float rather than half. In the
low-precision case, it falls back to a path renderer for large ovals.

Bug: b/110380864, skia:8873
Change-Id: I89e8dd067a2e0cab35b1bb515adaab4a2fb4f222
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/201615
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2019-03-21 17:10:13 +00:00
Mike Klein
84836b799a moar static flags
Like any normal variable, flags can be made file-scoped static,
and like any normal variable, mostly they should be if they can.

This CL converts most flags to be static, if only so that the
ones that do cross files stand out more clearly, and so that
there's more examples of static flags through the codebase for
people to ape.

Change-Id: Ibb5ddd7aa09fce073d0996ac3ef0487b078b7d79
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/202800
Commit-Queue: Mike Klein <mtklein@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Auto-Submit: Mike Klein <mtklein@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2019-03-21 17:07:13 +00:00
Ravi Mistry
1b53106907 New perf-skottietrace recipe
The recipe runs DM on lottie files with tracing enabled.
DM will grab 25 samples evenly distributed across the timeline and the trace
will be outputted with Animation entry points.
The output of the trace is then parsed and written into perf.json for
perf.skia.org ingestion.

Example resultant perf.json:
https://isolateserver.appspot.com/browse?namespace=default-gzip&digest=31f605ad3c9047f2889893654d57344502794371&as=perf.json

Recipe would run on android devices.

Bug: skia:8884
Change-Id: I70715febf2bfbd7b1f8fcbd872cb4709638eabd7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/201472
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2019-03-21 16:46:03 +00:00
Mike Klein
b0b2c962f7 refactor for saner constness
Change-Id: I657ebb580c325f3cfdbf7dad7a0c1f0a118e3769
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/202725
Auto-Submit: Mike Klein <mtklein@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2019-03-21 16:34:33 +00:00
Mike Klein
894328d1e3 update SkShader appendStages() fallback plan
This version makes these shaders draw differently, shading in sRGB then
transforming to dst, rather than transforming all inputs to dst then
shading.

There aren't many shaders that fall into this path (perlin noise and
lighting shader only?), and I think the legacy, sRGB, and even esRGB
paths should draw the same, so it may be we can kind of just slip this
through?

Cq-Include-Trybots: luci.chromium.try:linux-blink-rel
Change-Id: I0860f9f43c5ed8962fb0fe9405c15e664232dde9
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/202724
Commit-Queue: Mike Klein <mtklein@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Auto-Submit: Mike Klein <mtklein@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2019-03-21 16:04:02 +00:00
Mike Klein
d6ab77a2e2 restore .clang-format
Cq-Include-Trybots: skia.primary:Housekeeper-PerCommit-CheckGeneratedFiles
Change-Id: I93f928c35b2369c9e496d4e887e8500970bea2ec
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/202359
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2019-03-21 15:52:32 +00:00
skia-autoroll
a02dd32dee Roll third_party/externals/swiftshader 9041bb7c0011..7bc4f45a391f (2 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/9041bb7c0011..7bc4f45a391f


git log 9041bb7c0011..7bc4f45a391f --date=short --no-merges --format='%ad %ae %s'
2019-03-21 sugoi@google.com sw::Surface removed
2019-03-21 sugoi@google.com sw::Surface references removed from sampling code


Created with:
  gclient setdep -r third_party/externals/swiftshader@7bc4f45a391f

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=brianosman@google.com

Change-Id: I9ce7eab2b4ee9bd0a83aad658754815973c9935a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/202722
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-03-21 15:51:32 +00:00
Ethan Nicholas
0e9401dafe Initial checkin of new SkSL interpreter.
Not quite feature complete yet, but at a point where it's worth checking
in.

Bug: skia:
Change-Id: I21141d30e8582a79e94450d84e56bacc067249e0
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/201685
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2019-03-21 15:41:10 +00:00
skia-autoroll
6463913201 Roll third_party/externals/swiftshader 290908500aed..9041bb7c0011 (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/290908500aed..9041bb7c0011


git log 290908500aed..9041bb7c0011 --date=short --no-merges --format='%ad %ae %s'
2019-03-21 sugoi@google.com Basic CommandBuffer::waitEvents implementation


Created with:
  gclient setdep -r third_party/externals/swiftshader@9041bb7c0011

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=brianosman@google.com

Change-Id: Ib18e0e37fec9b631fe67af87e0ac421bd8b8cb3e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/202720
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-03-21 15:10:00 +00:00
Ravi Mistry
6bb809a605 Remove auto adding CQ keywords for non-master branches
Bug: skia:
Change-Id: I03e5ceff326d38f96ce6fea699248b0232e39a63
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/202701
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2019-03-21 15:01:00 +00:00
skia-autoroll
c132b122b9 Roll third_party/externals/swiftshader aff2dd067015..290908500aed (2 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/aff2dd067015..290908500aed


git log aff2dd067015..290908500aed --date=short --no-merges --format='%ad %ae %s'
2019-03-21 capn@google.com Refactor variable type lookup
2019-03-21 swiftshader.regress@gmail.com Regres: Update test lists @ aff2dd06


Created with:
  gclient setdep -r third_party/externals/swiftshader@290908500aed

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=brianosman@google.com

Change-Id: Id89a18a392fed5408ce47f376a901c9a3c480333
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/202628
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-03-21 14:11:33 +00:00
Brian Salomon
c552eaf56a Avoid making new image snapshot in GPU->GPU SkSurface::draw()
Bug: chromium:943561
Change-Id: I4b5cd545fb31bbaaf7828a2a90a88a0bfb179c87
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/202400
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2019-03-21 13:49:39 +00:00
skia-autoroll
8c70393356 Roll skia/third_party/skcms 10ed3a8a5eec..99740cdf2835 (1 commits)
https://skia.googlesource.com/skcms.git/+log/10ed3a8a5eec..99740cdf2835

2019-03-21 mtklein@google.com bump linux to clang 8


The AutoRoll server is located here: https://autoroll.skia.org/r/skcms-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
TBR=brianosman@google.com

Change-Id: I407d7edd56b6bfcc64d3a3b13729ab47af740e17
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/202358
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-03-21 13:45:09 +00:00
Robert Phillips
2dd1b4743d Add support for Y410 (i.e., 1010102) to wacky_yuv_formats
This is probably the last wacky YUV format that is easy for us to support.

Change-Id: Id9a4ba595f4e9893e9bd91ac937e08bf1d8559ab
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/177621
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Jim Van Verth <jvanverth@google.com>
2019-03-21 13:34:39 +00:00
Kevin Lubick
27ba7032be Add GN args for GL/GLES interface
Bug: skia:
Change-Id: I8445a6f3641aa43e7b18832c7c228b66dd321f2d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/201616
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2019-03-21 12:57:27 +00:00
Tushar Khandelwal
3f7f6c1ccf Store LZW dictionary suffixes in larger chunks
To write out an LZW dictionary entry each byte
requires two table lookups, one of which must complete
before the next lookup can begin. This change makes it
possible to write up to eight bytes per pair of lookups.
Testing with image_decode_bench show performance
improvement by 20-25% on Elm and Kevin Chromebooks except
for small images with a gradient, which show a slowdown.
However, the patch will introduce some memory hungry code
which lasts only while decoding a frame. The change in
memory requirement is from 4096 bytes to 4096*8 bytes.

BUG=skia:8361
BUG=chromium:859454"

Signed-off-by: tushar khandelwal <tushar.khandelwal@arm.com>
Change-Id: Icf9e0adf215062ef796b5ff9e6347cace5f0af47
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/152580
Reviewed-by: Leon Scroggins <scroggo@google.com>
Commit-Queue: Leon Scroggins <scroggo@google.com>
2019-03-21 12:53:07 +00:00
skia-autoroll
a695da9305 Roll third_party/externals/angle2 f455f7565a7a..232bfeae6b29 (4 commits)
f455f7565a..232bfeae6b


git log f455f7565a7a..232bfeae6b29 --date=short --no-merges --format='%ad %ae %s'
2019-03-21 syoussefi@chromium.org Add perf test for texture upload gpu time
2019-03-21 syoussefi@chromium.org Vulkan: Add support for ETC1
2019-03-21 jie.a.chen@intel.com ParallelCompile: use the native extensions
2019-03-21 jiajia.qin@intel.com Fix that uniform can't be used as the index of buffer variable


Created with:
  gclient setdep -r third_party/externals/angle2@232bfeae6b29

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=brianosman@google.com

Change-Id: Id77d0cc3a52445617855ecb23bc04aa1a05e8ce8
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/202621
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-03-21 12:15:27 +00:00
Ben Wagner
8037b62312 Add more detail on configuring jobs.
Docs-Preview: https://skia.org/?cl=56020
Change-Id: I7d28d7921ab9c650498f4f8a06533f7e5df19a36
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/56020
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2019-03-21 10:54:17 +00:00
skia-recreate-skps
174a3f61fd Update go_deps asset
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I5086718696e6a083b4b32f9d86d3223773b2d20f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/202540
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2019-03-21 05:49:17 +00:00
skia-autoroll
2c4ceca62d Roll third_party/externals/angle2 a532570a09b8..f455f7565a7a (4 commits)
a532570a09..f455f7565a


git log a532570a09b8..f455f7565a7a --date=short --no-merges --format='%ad %ae %s'
2019-03-21 jmadill@chromium.org Reuse angle_end2end_test windows and displays.
2019-03-20 jmadill@chromium.org Fix incorrect glslang git hash.
2019-03-20 syoussefi@chromium.org Add perf test for fbo clear gpu time
2019-03-20 jmadill@chromium.org Introduce ConfigParameters test helper struct.


Created with:
  gclient setdep -r third_party/externals/angle2@f455f7565a7a

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=brianosman@google.com

Change-Id: If22f28266d8439e50ab5c96a72675ccfe54f1db5
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/202509
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-03-21 02:37:07 +00:00
skia-autoroll
e409441aee Roll third_party/externals/swiftshader c296806411fb..aff2dd067015 (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/c296806411fb..aff2dd067015


git log c296806411fb..aff2dd067015 --date=short --no-merges --format='%ad %ae %s'
2019-03-21 chrisforbes@google.com Add support for derivative instructions


Created with:
  gclient setdep -r third_party/externals/swiftshader@aff2dd067015

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=brianosman@google.com

Change-Id: I19a854430262e2675b88ff5a657216f900abb57d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/202506
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-03-21 01:16:21 +00:00