Commit Graph

12375 Commits

Author SHA1 Message Date
commit-bot@chromium.org
537326089e git cl dcommit# Enter a description of the change.
shadertext2 rebaselines

TBR=
NOTRY=True
NOTREECHECKS=True

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/305853002

git-svn-id: http://skia.googlecode.com/svn/trunk@14943 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-29 01:03:18 +00:00
commit-bot@chromium.org
dcba9931a3 Add sk_memcpy32 to Memcpy bench.
The bench predates the implementation in SkUtils, but now that we've got it of course we want to measure our actual implementation.

BUG=skia:
R=reed@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/302763006

git-svn-id: http://skia.googlecode.com/svn/trunk@14942 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-28 22:47:26 +00:00
commit-bot@chromium.org
793ddd994a Shut up windows build errors on new GM
BUG=skia:
R=mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/300973005

git-svn-id: http://skia.googlecode.com/svn/trunk@14941 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-28 22:42:31 +00:00
commit-bot@chromium.org
3c1594aacb make new blurrect GM and replace the dozens of existing ones
BUG=
NOTRY=True
R=reed@google.com, epoger@google.com

Author: humper@google.com

Review URL: https://codereview.chromium.org/306583007

git-svn-id: http://skia.googlecode.com/svn/trunk@14940 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-28 21:52:12 +00:00
commit-bot@chromium.org
e3c400f1bd Set the default discardable pool size for Android framework.
BUG=skia:2389
R=halcanary@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/303893002

git-svn-id: http://skia.googlecode.com/svn/trunk@14939 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-28 21:44:05 +00:00
commit-bot@chromium.org
81496fb216 Spin off just SkLazyFnPtr from 305513002.
The memory barrier in SkOnce is a perf regression for sk_mem{set,cpy} in
SkUtils on ARM.  We can do a lot better for function pointers.

BUG=skia:

Committed: http://code.google.com/p/skia/source/detail?r=14929

R=bungeman@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/305753002

git-svn-id: http://skia.googlecode.com/svn/trunk@14938 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-28 21:43:59 +00:00
commit-bot@chromium.org
940aa237bb rebaseline #5 for shadertext2
TBR=
NOTRY=True
NOTREECHECKS=True

Author: reed@google.com

Review URL: https://codereview.chromium.org/305603005

git-svn-id: http://skia.googlecode.com/svn/trunk@14937 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-28 21:32:25 +00:00
commit-bot@chromium.org
f263f34b20 yet more rebaselines for shadertext and mandrills
TBR=
NOTRY=True
NOTREECHECKS=True

Author: reed@google.com

Review URL: https://codereview.chromium.org/302953002

git-svn-id: http://skia.googlecode.com/svn/trunk@14936 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-28 21:14:31 +00:00
commit-bot@chromium.org
c950ee6a52 more rebaselines for shadertext2 and stroketext and a couple of mandrills
TBR=epoger
NOTRY=True
NOTREECHECKS=True

Author: reed@google.com

Review URL: https://codereview.chromium.org/303693013

git-svn-id: http://skia.googlecode.com/svn/trunk@14935 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-28 21:00:53 +00:00
commit-bot@chromium.org
86b0de4745 Revert "Remove SkThread.h from public API."
Too much depends on SkThread being in include/core in Chrome build.

This reverts commit b1aec17df6.

NOTREECHECKS=true
NOTRY=true
R=reed@google.com, mtklein@google.com
TBR=reed

BUG=skia:

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/303813003

git-svn-id: http://skia.googlecode.com/svn/trunk@14934 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-28 20:02:17 +00:00
commit-bot@chromium.org
05d1cc23ec Revert of Spin off just SkLazyFnPtr from 305513002. (https://codereview.chromium.org/305753002/)
Reason for revert:
depends on bad cl

Original issue's description:
> Spin off just SkLazyFnPtr from 305513002.
>
> The memory barrier in SkOnce is a perf regression for sk_mem{set,cpy} in
> SkUtils on ARM.  We can do a lot better for function pointers.
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=14929

R=bungeman@google.com, mtklein@chromium.org
TBR=bungeman@google.com, mtklein@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/300843012

git-svn-id: http://skia.googlecode.com/svn/trunk@14933 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-28 19:58:14 +00:00
commit-bot@chromium.org
6640ee3378 Revert of Fix SkAtomics_win.h typos. (https://codereview.chromium.org/293363017/)
Reason for revert:
depends on bad cl

Original issue's description:
> Fix SkAtomics_win.h typos.
>
> NOTRY=true
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=14930

R=mtklein@chromium.org
TBR=mtklein@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/304503011

git-svn-id: http://skia.googlecode.com/svn/trunk@14932 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-28 19:57:18 +00:00
commit-bot@chromium.org
a32260db15 add flag to disable changes to image scaling to avoid breaking every single
layout test on blink all at once.

BUG=
R=epoger@google.com
TBR=epoger
NOTRY=True
NOTREECHECKS=True

Author: humper@google.com

Review URL: https://codereview.chromium.org/298133008

git-svn-id: http://skia.googlecode.com/svn/trunk@14931 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-28 19:52:54 +00:00
commit-bot@chromium.org
5133fc1c06 Fix SkAtomics_win.h typos.
NOTRY=true

BUG=skia:
R=mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/293363017

git-svn-id: http://skia.googlecode.com/svn/trunk@14930 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-28 19:50:29 +00:00
commit-bot@chromium.org
3fdc7d6dd1 Spin off just SkLazyFnPtr from 305513002.
The memory barrier in SkOnce is a perf regression for sk_mem{set,cpy} in
SkUtils on ARM.  We can do a lot better for function pointers.

BUG=skia:
R=bungeman@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/305753002

git-svn-id: http://skia.googlecode.com/svn/trunk@14929 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-28 19:40:21 +00:00
senorblanco@chromium.org
29ac34ee52 Fix filter bounds computation for SkOffsetImageFilter.
SkOffsetImageFilter::onFilterBounds() was not recursing into its input
filter when computing bounds.

BUG=374556
R=junov@chromium.org

Review URL: https://codereview.chromium.org/304743003

git-svn-id: http://skia.googlecode.com/svn/trunk@14928 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-28 19:29:25 +00:00
commit-bot@chromium.org
77cb589a3d more rebaselines for shadertext
TBR=epoger
NOTRY=True

Author: reed@google.com

Review URL: https://codereview.chromium.org/302433017

git-svn-id: http://skia.googlecode.com/svn/trunk@14927 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-28 19:25:08 +00:00
commit-bot@chromium.org
b1aec17df6 Remove SkThread.h from public API.
BUG=skia:
R=reed@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/303463009

git-svn-id: http://skia.googlecode.com/svn/trunk@14926 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-28 19:24:54 +00:00
commit-bot@chromium.org
7e2b0f3b06 Add SkPurgeGlobalDiscardableMemoryPool, needed to replace SkImageRef
BUG=skia:2389
R=reed@google.com, scroggo@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/298423002

git-svn-id: http://skia.googlecode.com/svn/trunk@14925 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-28 18:51:03 +00:00
commit-bot@chromium.org
e9ba81f43a rebaseline shadertext2 shadertext3 and stroketext (sans 2)
NOTRY=True
TBR=epoger

Author: reed@google.com

Review URL: https://codereview.chromium.org/304763003

git-svn-id: http://skia.googlecode.com/svn/trunk@14924 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-28 18:49:15 +00:00
commit-bot@chromium.org
93d7bb6fc6 add a verbose flag to skdiff that shows the progress and status of
each comparison

BUG=
R=bungeman@google.com

Author: humper@google.com

Review URL: https://codereview.chromium.org/302443012

git-svn-id: http://skia.googlecode.com/svn/trunk@14923 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-28 18:26:00 +00:00
commit-bot@chromium.org
fa95b26b7a rename ignored tests
BUG=
R=epoger@google.com
TBR=epoger
NOTRY=true
NOTREECHECKS=True

Author: humper@google.com

Review URL: https://codereview.chromium.org/304533008

git-svn-id: http://skia.googlecode.com/svn/trunk@14922 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-28 18:05:42 +00:00
commit-bot@chromium.org
ea6cb91170 Add script to rebaseline benches from codereview trybot results
This script is designed to be used by the RecreateSKPs bot.  Eventually, the bot will:
1. Generate new SKPs
2. Upload the new SKPs to a subdirectory with an ID or generation number.
3. Change Skia to use the new SKPs:
    a. Create and upload a Skia CL which changes the "current SKP generation" file to point to the new SKPs
    b. Launch Perf trybots on that CL.
    c. Call this script every 5 minutes until it successfully creates new baselines for each of the launched Perf bots.
    d. Add the new baselines to the CL
    e. Upload a second patch set of the CL
    f. Check the CQ bit on the CL

BUG=skia:2225
R=epoger@google.com, halcanary@google.com, bensong@google.com

Author: borenet@google.com

Review URL: https://codereview.chromium.org/297893004

git-svn-id: http://skia.googlecode.com/svn/trunk@14921 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-28 17:30:10 +00:00
commit-bot@chromium.org
f449156bd0 Make image scaling have floating point scales. Third attempt to land this
due to some struggles with the CQ.  Original CL here:

https://codereview.chromium.org/298243003/

BUG=
R=bsalomon@google.com, epoger@google.com
TBR=bsalomon, epoger

Author: humper@google.com

Review URL: https://codereview.chromium.org/300113008

git-svn-id: http://skia.googlecode.com/svn/trunk@14920 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-28 17:30:02 +00:00
bsalomon@google.com
d4c5f2f1bf Followup GM rebaselines for non-GPU configs after removing tests from ignored-tests.txt
Review URL: https://codereview.chromium.org/303693012

git-svn-id: http://skia.googlecode.com/svn/trunk@14919 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-28 17:25:02 +00:00
bsalomon@google.com
025e6d53d7 Take care of a bunch of pending GPU rebaselines and remove tests from ignored-tests.txt
Review URL: https://codereview.chromium.org/300863006

git-svn-id: http://skia.googlecode.com/svn/trunk@14918 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-28 16:41:21 +00:00
commit-bot@chromium.org
924205aaf2 Revert of add colortable support to imagegenerator (https://codereview.chromium.org/304443003/)
Reason for revert:
failing tests

Original issue's description:
> add colortable support to imagegenerator
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=14916

R=halcanary@google.com, scroggo@google.com
TBR=halcanary@google.com, scroggo@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: reed@google.com

Review URL: https://codereview.chromium.org/300873007

git-svn-id: http://skia.googlecode.com/svn/trunk@14917 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-28 16:16:08 +00:00
commit-bot@chromium.org
b263985850 add colortable support to imagegenerator
BUG=skia:
R=halcanary@google.com, scroggo@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/304443003

git-svn-id: http://skia.googlecode.com/svn/trunk@14916 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-28 16:01:55 +00:00
bungeman@google.com
7c18351d1f Better handling of bitmaps in DirectWrite.
R=reed@google.com

Review URL: https://codereview.chromium.org/303773002

git-svn-id: http://skia.googlecode.com/svn/trunk@14915 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-28 15:40:26 +00:00
commit-bot@chromium.org
5889e30996 Include SkTypes to fix Android frameworks build
Since Android's defines are included in SkUserConfig (rather than
being defined in the build file), we need to include something that
includes SkUserConfig (transitively; meaning just about anything)
before we can use any build macros. Include SkTypes, "the correct
way to get access to the config system" so that
SK_BUILD_FOR_ANDROID is defined before querying it.

R=robertphillips@google.com, djsollen@google.com, mtklein@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/294393011

git-svn-id: http://skia.googlecode.com/svn/trunk@14914 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-28 15:02:37 +00:00
commit-bot@chromium.org
6be0ab3083 Add SKP_VERSION file to determine which SKPs to download
BUG=skia:2225
R=epoger@google.com, rmistry@google.com, bensong@google.com

Author: borenet@google.com

Review URL: https://codereview.chromium.org/299403009

git-svn-id: http://skia.googlecode.com/svn/trunk@14913 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-28 13:23:39 +00:00
skia.committer@gmail.com
8e7d37d8fe Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@14912 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-28 03:06:06 +00:00
commit-bot@chromium.org
6d3eaeabdd add replay entry point to SkPictureRecorder for Android
This CL adds an Android-only entry point to address the Java Picture(Picture) and serialize use cases. Note that (in its current form) it doesn't preserve the old API's handling of unbalanced saves/saveLayers (this CL always balances them).

R=reed@google.com, scroggo@google.com, djsollen@google.com, mtklein@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/252873005

git-svn-id: http://skia.googlecode.com/svn/trunk@14911 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-27 23:41:45 +00:00
commit-bot@chromium.org
293a4b367a Revert of PictureBenchmark JSON logging (https://codereview.chromium.org/286903025/)
Reason for revert:
Broke some Windows builds; see http://skbug.com/2609 ('certain Windows Build-* bots failing since r14905').

Before re-landing with a fix, please send to some of the trybots that failed the first time.

Original issue's description:
> Add JSON logging support to bench_pictures by adding a PictureResultsWriter class (in tools/PictureResultsWriter.h) to process logging information, using a very similar style as bench/ResultsWriter.h
>
> JSON format described in code, above PictureJSONResultsWriter class
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=14906

R=bensong@google.com, jcgregorio@google.com, kelvinly@google.com
TBR=bensong@google.com, jcgregorio@google.com, kelvinly@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2609

Author: epoger@google.com

Review URL: https://codereview.chromium.org/306483010

git-svn-id: http://skia.googlecode.com/svn/trunk@14910 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-27 21:51:38 +00:00
commit-bot@chromium.org
466f5f3e44 remove SkBitmap::asImageInfo
BUG=skia:
R=scroggo@google.com, halcanary@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/305483005

git-svn-id: http://skia.googlecode.com/svn/trunk@14909 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-27 21:30:37 +00:00
commit-bot@chromium.org
300c4293f5 add box image to resources; landing separately to avoid issues with
trybots for the code that uses this

BUG=
R=epoger@google.com
TBR=epoger
NOTRY=True

Author: humper@google.com

Review URL: https://codereview.chromium.org/303713002

git-svn-id: http://skia.googlecode.com/svn/trunk@14908 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-27 21:15:35 +00:00
epoger@google.com
f3b1eb4ea2 Manual SVN revert of https://code.google.com/p/skia/source/detail?r=14905
git-svn-id: http://skia.googlecode.com/svn/trunk@14907 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-27 21:12:42 +00:00
commit-bot@chromium.org
3089004cc8 Add JSON logging support to bench_pictures by adding a PictureResultsWriter class (in tools/PictureResultsWriter.h) to process logging information, using a very similar style as bench/ResultsWriter.h
JSON format described in code, above PictureJSONResultsWriter class

BUG=skia:
R=bensong@google.com, jcgregorio@google.com

Author: kelvinly@google.com

Review URL: https://codereview.chromium.org/286903025

git-svn-id: http://skia.googlecode.com/svn/trunk@14906 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-27 20:57:44 +00:00
commit-bot@chromium.org
44f41293ac floating point scale factors for images
New version of https://codereview.chromium.org/298243003/ made to deal with binary file being lost.

BUG=
TBR=bsalomon
NOTRY=true

Author: humper@google.com

Review URL: https://codereview.chromium.org/307553005

git-svn-id: http://skia.googlecode.com/svn/trunk@14905 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-27 20:54:04 +00:00
commit-bot@chromium.org
61a03b78d6 whitespace change to trigger new builds after buildbot fix
BUG=skia:2608
NOTREECHECKS=True
NOTRY=True
R=borenet@google.com
TBR=borenet

Author: epoger@google.com

Review URL: https://codereview.chromium.org/300223005

git-svn-id: http://skia.googlecode.com/svn/trunk@14904 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-27 20:10:48 +00:00
commit-bot@chromium.org
42dc813691 Revert of Revert of Add compressed texture capabilities for GPU devices
(https://codereview.chromium.org/307543002/)

Reason for revert:
Re-landing the original CL, because the revert didn't fix things.  See http://skbug.com/2608 ('RunDecodingTests failing on multiple platforms')

Original issue's description:
> Revert of Add compressed texture capabilities for GPU devices (https://codereview.chromium.org/292323003/)
>
> Reason for revert:
> RunDecodingTests failing on multiple platforms.  Please use trybots to validate and re-land.
>
> Original issue's description:
> > Add compressed texture capabilities for GPU devices
> >
> > BUG=skia:
> >
> > Committed: http://code.google.com/p/skia/source/detail?r=14880
> >
> > Committed: http://code.google.com/p/skia/source/detail?r=14901
>
> TBR=bsalomon@google.com,robertphillips@google.com,krajcevski@google.com
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=14902

R=bsalomon@google.com, robertphillips@google.com, krajcevski@google.com
TBR=bsalomon@google.com, krajcevski@google.com, robertphillips@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: epoger@google.com

Review URL: https://codereview.chromium.org/302553008

git-svn-id: http://skia.googlecode.com/svn/trunk@14903 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-27 19:26:59 +00:00
commit-bot@chromium.org
8bfcd72106 Revert of Add compressed texture capabilities for GPU devices (https://codereview.chromium.org/292323003/)
Reason for revert:
RunDecodingTests failing on multiple platforms.  Please use trybots to validate and re-land.

Original issue's description:
> Add compressed texture capabilities for GPU devices
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=14880
>
> Committed: http://code.google.com/p/skia/source/detail?r=14901

R=bsalomon@google.com, robertphillips@google.com, krajcevski@google.com
TBR=bsalomon@google.com, krajcevski@google.com, robertphillips@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: epoger@google.com

Review URL: https://codereview.chromium.org/307543002

git-svn-id: http://skia.googlecode.com/svn/trunk@14902 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-27 19:07:10 +00:00
commit-bot@chromium.org
420b2ff26c Add compressed texture capabilities for GPU devices
BUG=skia:

Committed: http://code.google.com/p/skia/source/detail?r=14880

R=bsalomon@google.com, robertphillips@google.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/292323003

git-svn-id: http://skia.googlecode.com/svn/trunk@14901 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-27 18:52:24 +00:00
commit-bot@chromium.org
fdf2c55fe1 Add another expectation for bug with perspective gpu
BUG=skia:2605
R=robertphillips@google.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/301593006

git-svn-id: http://skia.googlecode.com/svn/trunk@14900 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-27 17:31:25 +00:00
commit-bot@chromium.org
b859fe6530 Fixing windows warnings
BUG=skia:
R=bsalomon@google.com, epoger@google.com

Author: sugoi@chromium.org

Review URL: https://codereview.chromium.org/298093006

git-svn-id: http://skia.googlecode.com/svn/trunk@14899 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-27 17:03:25 +00:00
commit-bot@chromium.org
dd56a243ff Adds perf expectations for ANGLE bot.
BUG=skia:2576
NOTRY=true
R=borenet@google.com

Author: bensong@google.com

Review URL: https://codereview.chromium.org/303643002

git-svn-id: http://skia.googlecode.com/svn/trunk@14898 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-27 17:01:49 +00:00
commit-bot@chromium.org
60c8d24f84 Remove some unnecessary uses of SkOnce.
- gm/imagefiltersgraph.cpp can just use a global registrar
  - SkScaledImageCache always accesses its global under a lock

BUG=skia:
R=bungeman@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/297273006

git-svn-id: http://skia.googlecode.com/svn/trunk@14897 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-27 16:28:43 +00:00
commit-bot@chromium.org
64f6d15451 Use SkAtomics_sync on Android
Every doc I've found about using Android's atomics says, "stop".

"* A handful of basic atomic operations.  The appropriate pthread
 * functions should be used instead of these whenever possible."

"... we recommend stopping from using these functions entirely. Very fortunately, GCC provides handy intrinsics functions that work with very reasonable performance and always provide a full barrier."

As far as I can tell, there's no code generation change here: both the __sync atomics and the android_ atomics use full memory barriers.  (And now with this all unified, it'll be easier to get the real wins by switching everything to __atomic atomics, which are like __sync atomics but allow control over memory barriers.)

BUG=skia:
R=bungeman@google.com, djsollen@google.com, mtklein@google.com, reed@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/305593002

git-svn-id: http://skia.googlecode.com/svn/trunk@14896 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-27 15:55:35 +00:00
commit-bot@chromium.org
e8765c4654 rebaseline simpleblurroundrect
BUG=
TBR=bsalomon

Author: humper@google.com

Review URL: https://codereview.chromium.org/300833002

git-svn-id: http://skia.googlecode.com/svn/trunk@14895 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-27 15:28:03 +00:00
commit-bot@chromium.org
abf4189f34 Drop support for non-atomic non-mutex platforms.
(Clients can still provide these themselves if they really want.)

BUG=skia:
R=reed@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/295373005

git-svn-id: http://skia.googlecode.com/svn/trunk@14894 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-27 15:16:37 +00:00