jvanverth
9154dd4552
Rebaseline GMs for https://codereview.chromium.org/687283002/
...
BUG=skia:2935
Review URL: https://codereview.chromium.org/684833003
2014-10-31 07:16:54 -07:00
sugoi
8b602ddd59
Objects should be unrefed instead of deleted
...
When an error occurs reading a flattenable object, it should be unrefed instead of deleted because, in the case of SkXferMode, for example, we'd actually be deleting a cached object kept in a static array.
BUG=428789
Review URL: https://codereview.chromium.org/695633003
2014-10-31 07:16:16 -07:00
stephana
0b5fc9774f
Quick and dirty test to call the C interface from GO.
...
BUG=skia:
Review URL: https://codereview.chromium.org/670303005
2014-10-31 07:11:19 -07:00
tfarina
38406c82b9
Cleanup: Go with SkDebugf instead of GrPrintf.
...
Since GrPrintf is just defined to SkDebugf, we can go with the later
directly.
BUG=None
TEST=None
R=bsalomon@google.com
Review URL: https://codereview.chromium.org/695663003
2014-10-31 07:11:12 -07:00
skia.buildbots
8955b0e524
Update SKP version
...
Automatic commit by the RecreateSKPs bot.
TBR=
Review URL: https://codereview.chromium.org/689833006
2014-10-31 07:06:08 -07:00
tfarina
58f467c210
Cleanup: Remove GR_ARRAY_COUNT macro.
...
It is defined to SK_ARRAY_COUNT, and there are no uses of it.
Lets just use the SK_ variant.
BUG=None
TEST=None
R=bsalomon@google.com
Review URL: https://codereview.chromium.org/691133003
2014-10-31 07:06:01 -07:00
djsollen
0130c30d0a
Add support for clang to the android build scripts
...
Review URL: https://codereview.chromium.org/692953002
2014-10-31 07:00:59 -07:00
djsollen
2550a7ed09
Remove adb from Skia repository
...
Review URL: https://codereview.chromium.org/696463003
2014-10-31 07:00:54 -07:00
egdaniel
ed3af6648f
Use Color Processor for color bitmap text draws on gpu.
...
This change is here since previously color bitmap text was rendered using a
geometry processor in the coverage stage. The problem with this is that we
cannot correctly do xfer modes with this method. So I now make color bitmap text
draw using a color stage in the same was as a draw bitmap call.
One issue that arrises from this fix is that we end up adding this final color
processor after any previous color processors. Thus if we have a custom blend
implemented as a color processor it will be before this text one and we won't
blend correctly. This issue will get fixed once an xfer processor is fully
implemented. I have hacked a test locally to show that if we can add the text
color processor to the begining of the color stages we do blend correctly in all
cases (so the xfer processor will be a fix).
BUG=skia:
Review URL: https://codereview.chromium.org/689923004
2014-10-31 06:55:45 -07:00
reed
bd1605905b
begin clean up for scalar is double option
...
BUG=skia:
Review URL: https://codereview.chromium.org/694693002
2014-10-31 06:55:41 -07:00
mtklein
2100c5ed7a
Turn SkTaskGroups back on.
...
Revert "Disable SkTaskGroup in SkMultiPictureDraw temporarily."
Revert "Revert harder, removing SkTaskGroup.cpp from core temporarily."
NOTREECHECKS=true
BUG=skia:
Review URL: https://codereview.chromium.org/687263007
2014-10-31 06:38:25 -07:00
robertphillips
d8aa7b74c8
Upgrade GPUOptimize
...
This will be a bit hairy to review.
The FillBounds and CollectLayers code has diverged significantly resulting in the rendering path seeing different bounds than the hoisting path. This CL merges the FillBounds changes into CollectLayers. A follow on CL will, hopefully, find a way to layer CollectLayers on top of FillBounds.
The only code in CollectLayers that is different from FillBounds is bracketed by "LAYER HOISTING" comments.
NOTREECHECKS=true
Review URL: https://codereview.chromium.org/685263004
2014-10-30 16:45:02 -07:00
sugoi
9bde31e95d
Trying to be consistent when members are allowed to be NULL
...
Got a few crashes running the fuzzer locally, all related to handling NULL members/parameters in an inconsistent way.
BUG=skia:
Review URL: https://codereview.chromium.org/675013003
2014-10-30 14:05:15 -07:00
djsollen
e228ba3e5c
Update the Android NDK to r10c
...
Review URL: https://codereview.chromium.org/689943002
2014-10-30 13:27:26 -07:00
borenet
2000c3de5b
Blind GM rebaseline for Galaxy S4
...
BUG=skia:3032
Review URL: https://codereview.chromium.org/694573002
2014-10-30 13:27:20 -07:00
djsollen
058f01eb68
Cleanup conversion that the new NDK compiler tries to over optimize.
...
This allows us to upgrade to NDK r10c as the dftext gm no longer fails
when compiled with -O2.
Review URL: https://codereview.chromium.org/690053002
2014-10-30 11:54:43 -07:00
robertphillips
0882fdcc15
Add return value on GrRecordReplaceDraw
...
This assists debugging layer hoisting errors (e.g., when a layer is hoisted but not actually used in subsequent rendering).
Review URL: https://codereview.chromium.org/694533004
2014-10-30 11:54:31 -07:00
robertphillips
189fc98e08
Fix member variable naming
...
This renaming was missed in (MultiPictureDraw is taskgroup aware - https://codereview.chromium.org/684923002 )
TBR=reed@google.com
Review URL: https://codereview.chromium.org/654293005
2014-10-30 11:49:37 -07:00
bungeman
967937c282
Combine nameFontStyleProc and FindByNameStyle.
...
These two functions do the same thing, combine them.
Review URL: https://codereview.chromium.org/688133003
2014-10-30 11:49:27 -07:00
scroggo
43d5debc84
Add skimage expectations for GalaxyS4.
...
Fixes build.
Review URL: https://codereview.chromium.org/692913003
2014-10-30 11:44:27 -07:00
junov
a41d3c33bc
Make RTree handle the case where the playback canvas has empty clip bounds
...
BUG=skia:3074
Review URL: https://codereview.chromium.org/678303004
2014-10-30 11:44:20 -07:00
robertphillips
225a627ccb
Fix bug in aggressive layer cache purging
...
A picture may possess many layers that get placed in one plot of the atlas. In this case we can only remove the plot from the plotUsage tracking structure when all the layers belonging to the picture in that plot have been removed.
Review URL: https://codereview.chromium.org/654463004
2014-10-30 11:39:19 -07:00
djsollen
a3a706fcd4
Cleanup android to ensure it can compile with clang
...
Review URL: https://codereview.chromium.org/694533002
2014-10-30 11:39:13 -07:00
reed
f037e0bf13
allow SkUserConfig.h to control NOGPU
...
BUG=skia:
Review URL: https://codereview.chromium.org/685243002
2014-10-30 11:34:15 -07:00
skia.buildbots
6374f57d77
Update SKP version
...
Automatic commit by the RecreateSKPs bot.
TBR=
Review URL: https://codereview.chromium.org/688793003
2014-10-30 11:34:04 -07:00
reed
789e327ad9
tell our grcontext to abandon its backend
...
BUG=skia:
Review URL: https://codereview.chromium.org/692803003
2014-10-30 11:29:08 -07:00
halcanary
902d4d18de
Add SkDocument::getStream() method.
...
Motivation: SkDocument_PDF can be refactored to stream all
PDF objects as SkCanvas calls are made, to save memory!
BUG=skia:3030
BUG=skia:2683
Review URL: https://codereview.chromium.org/691783002
2014-10-30 11:29:00 -07:00
robertphillips
650076027f
Revert of scale xmin and xmax for FontMetrics (patchset #1 id:1 of https://codereview.chromium.org/685153004/ )
...
Reason for revert:
Experimental revert to see if this is blocking the DEPS roll
Original issue's description:
> scale xmin and xmax for FontMetrics
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/79c276e4fd93d9c9fd57a45bc6929c48e4415b2f
TBR=mtklein@google.com ,bungeman@google.com,reed@google.com,reed@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/691033002
2014-10-30 09:59:43 -07:00
mtklein
13a8de0b51
Revert harder, removing SkTaskGroup.cpp from core temporarily.
...
Not all linkers are seeing the SkThread code is not needed.
BUG=skia:
NOTREECHECKS=true
Review URL: https://codereview.chromium.org/673903007
2014-10-30 08:19:19 -07:00
mtklein
7f36ae1314
Disable SkTaskGroup in SkMultiPictureDraw temporarily.
...
Think this should be enough to get rolling again.
NOTREECHECKS=true
Review URL: https://codereview.chromium.org/687273006
2014-10-30 07:19:11 -07:00
djsollen
f49bba8104
Use the most recent version of ADB from the SDK if necessary.
...
This removes ADB from the Skia checkout and also does some quick
checks to make sure the version of ADB used meets a minimum threshold
Review URL: https://codereview.chromium.org/692513003
2014-10-30 05:57:31 -07:00
jvanverth
b61283f9c7
Support multiple scales for dfpaths.
...
Adds miplevel as part of dfpath key, and scale factor so we know
how much to adjust to fit desired scale.
BUG=skia:2935
Review URL: https://codereview.chromium.org/687283002
2014-10-30 05:57:21 -07:00
rmistry
fec29ecce8
Increase wait time for spreadsheetdashed pageset
...
BUG=skia:3049
TBR=
NOTRY=true
Review URL: https://codereview.chromium.org/692843002
2014-10-30 05:52:26 -07:00
borenet
3e4234c416
Whitespace change to see how the Android bots behave
...
NOTRY=true
TBR=rmistry
NOTREECHECKS=true
BUG=skia:
Review URL: https://codereview.chromium.org/693483003
2014-10-30 05:52:17 -07:00
Ravi Mistry
0e50262767
Increase timeout of blogger pageset and re-enable weather pageset
...
BUG=skia:3049
2014-10-30 07:37:07 -04:00
reed
07dada770b
break transitions into separate file
...
BUG=skia:
TBR=
NOTRY=True
Review URL: https://codereview.chromium.org/692543004
2014-10-29 20:36:05 -07:00
joshualitt
7a6184fdf7
cleanup reentrance logic in CMM
...
BUG=skia:
Review URL: https://codereview.chromium.org/684223002
2014-10-29 18:29:27 -07:00
skia.buildbots
7207307620
Update SKP version
...
Automatic commit by the RecreateSKPs bot.
TBR=
Review URL: https://codereview.chromium.org/665233005
2014-10-29 16:51:53 -07:00
mtklein
ed167acb7b
Revert of Use SkTypeface::getBounds() in bounding-box calculations. (patchset #5 id:80001 of https://codereview.chromium.org/680363003/ )
...
Reason for revert:
Mac mini asserting
Original issue's description:
> Use SkTypeface::getBounds() in bounding-box calculations.
>
> This should produce tighter conservative bounding boxes for text than the
> approximation code it replaces.
>
> Recording performance is neutral on my desktop. Playback performance
> improves by up to 15% on text heavy pages, e.g.
>
> desk_pokemonwiki.skp_1 3.24ms -> 2.83ms 0.87x
> desk_baidu.skp_1 1.91ms -> 1.58ms 0.83x
>
> Committed: https://skia.googlesource.com/skia/+/bf8dc343df4fbdcb8af546eb68b640e011a33489
>
> CQ_EXTRA_TRYBOTS=client.skia:Test-Win7-ShuttleA-HD2000-x86-Debug-Trybot
>
> Committed: https://skia.googlesource.com/skia/+/c51add674dfb89b988a7fbc05f41838c203f9dcd
TBR=reed@google.com ,mtklein@chromium.org
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/690833002
2014-10-29 16:07:11 -07:00
reed
67c71203a4
use SkTaskGroup::batch
...
BUG=skia:
Review URL: https://codereview.chromium.org/688753002
2014-10-29 15:44:25 -07:00
mtklein
c51add674d
Use SkTypeface::getBounds() in bounding-box calculations.
...
This should produce tighter conservative bounding boxes for text than the
approximation code it replaces.
Recording performance is neutral on my desktop. Playback performance
improves by up to 15% on text heavy pages, e.g.
desk_pokemonwiki.skp_1 3.24ms -> 2.83ms 0.87x
desk_baidu.skp_1 1.91ms -> 1.58ms 0.83x
Committed: https://skia.googlesource.com/skia/+/bf8dc343df4fbdcb8af546eb68b640e011a33489
CQ_EXTRA_TRYBOTS=client.skia:Test-Win7-ShuttleA-HD2000-x86-Debug-Trybot
Review URL: https://codereview.chromium.org/680363003
2014-10-29 15:36:38 -07:00
Ravi Mistry
7cf0294d51
Increase timeouts of wowwiki and youtube
2014-10-29 17:39:15 -04:00
mtklein
e71cd54ed4
SkTaskGroup::batch(fn, args, N)
...
Porting QuiltTask isn't important in itself; this is mostly an API feeler.
BUG=skia:
Review URL: https://codereview.chromium.org/689673003
2014-10-29 14:17:13 -07:00
mtklein
6838d854a8
Try out SkTree in nanobench.
...
Looks like a fairly large recording speed win with no playback cost.
BUG=skia:
Review URL: https://codereview.chromium.org/653023003
2014-10-29 14:15:10 -07:00
Ravi Mistry
2c8371aea7
Moving weather pageset since it is crashing
2014-10-29 17:03:22 -04:00
robertphillips
4ab5a9048c
Discard atlas after every MultiPictureDraw::draw
...
This is intended to prevent ghosting on tiled architectures.
This CL also defers creation of the atlas (and its texture) until it is actually needed.
Committed: https://skia.googlesource.com/skia/+/6d5b5455743414ddb11d2b8c1fe9d7959f2b853d
Review URL: https://codereview.chromium.org/678403002
2014-10-29 13:56:03 -07:00
reed
79c276e4fd
scale xmin and xmax for FontMetrics
...
BUG=skia:
Review URL: https://codereview.chromium.org/685153004
2014-10-29 13:43:50 -07:00
djsollen
c96aa64246
Add a helper script to expose which version of adb the android scripts use.
...
Review URL: https://codereview.chromium.org/692633002
2014-10-29 12:59:50 -07:00
bungeman
7316b100df
Revert of scale xmin/xmax etc in fontmetrics (patchset #1 id:1 of https://codereview.chromium.org/690533004/ )
...
Reason for revert:
Breaking tests in Chromium, and not in a good way.
Original issue's description:
> scale xmin/xmax etc in fontmetrics
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/f8c2feffd68b3262f3c039ec1bd517c5f6cc9e4c
TBR=reed@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/686263002
2014-10-29 12:46:52 -07:00
bsalomon
b15b4c1ce0
Separate out GrSurfaceConfig's fields from other structs used to create GrGL* subclasses of GrSurface.
...
BUG=skia:2889
Review URL: https://codereview.chromium.org/691523002
2014-10-29 12:41:57 -07:00