Commit Graph

38486 Commits

Author SHA1 Message Date
skia-bookmaker
53079c3c11 Update markdown files
Automatic commit by the Housekeeper-Nightly-Bookmaker bot.

TBR=rmistry@google.com
NO_MERGE_BUILDS

Change-Id: Ifb4b974f27dcf346f2ead85f6142963eb5ce8140
Reviewed-on: https://skia-review.googlesource.com/c/172760
Commit-Queue: <skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com>
Reviewed-by: <skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com>
2018-11-25 04:27:28 +00:00
Cary Clark
fc93eb0171 fix textblob doc examples
TBR=reed@google.com
NOTRY=true

Bug: skia:
Change-Id: I85e3712dac621f1714cda2ecb86980ff9305c43c
Reviewed-on: https://skia-review.googlesource.com/c/172742
Reviewed-by: Cary Clark <caryclark@skia.org>
Commit-Queue: Cary Clark <caryclark@skia.org>
Auto-Submit: Cary Clark <caryclark@skia.org>
2018-11-25 03:39:15 +00:00
Mike Reed
c16abee8c5 impl gettextpath using SkFont
Bug: skia:
Change-Id: I23dce4ed9718e7ce2d6511e08ef350c9ee2e94b4
Reviewed-on: https://skia-review.googlesource.com/c/172645
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Mike Reed <reed@google.com>
2018-11-24 18:52:59 +00:00
Mike Reed
8b998b1e71 add SK_SUPPORT_LEGACY_TEXTBLOBBUILD_WITH_PAINT for google3
Bug: skia:
Change-Id: I3a7e3555718d5e585d5288b7a70a24ee39d0d327
Reviewed-on: https://skia-review.googlesource.com/c/172740
Reviewed-by: Mike Reed <reed@google.com>
2018-11-24 17:59:00 +00:00
skia-recreate-skps
28795bac45 Update go_deps asset
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I1c231eff29d5e42e1e4ace52b602863d94e6d300
Reviewed-on: https://skia-review.googlesource.com/c/172680
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2018-11-24 05:54:44 +00:00
Mike Reed
4ff4085900 start to divert legacy paint method impls to font
Bug: skia:
Change-Id: Ib972e7c0daaa71f707d3d64e62e842d2b021a1c4
Reviewed-on: https://skia-review.googlesource.com/c/172644
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2018-11-23 21:47:40 +00:00
Mike Reed
358fcad1b8 start to hide textparams on SkPaint
Bug: skia:
Change-Id: Id73c983cc71d39fe587d355e690261627fa63aee
Reviewed-on: https://skia-review.googlesource.com/c/172643
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2018-11-23 20:54:16 +00:00
recipe-roller
7593b34081 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/6c18a1afa1a7a30421775c8d6c1cfb7edb3f272a Fix git cl format --python when diff.noprefix flag is set (abenner@google.com)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: If24901d57c5e9aa34d6238507c9c415377b68951
Reviewed-on: https://skia-review.googlesource.com/c/172642
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-11-23 20:44:37 +00:00
Mike Reed
70ea9260ee don't define flag -- let clients do that
Bug: skia:
Change-Id: I01ad384ccabf2fa181eb475270fd0c3f44b5e1f0
Reviewed-on: https://skia-review.googlesource.com/c/172641
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2018-11-23 19:07:47 +00:00
Mike Reed
70914f589c Use SkFont in textblobs
Bug: skia:2664
Change-Id: I43fd6471a66320787890f620c072974ca974b236
Reviewed-on: https://skia-review.googlesource.com/c/172640
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2018-11-23 18:36:32 +00:00
skia-recreate-skps
9b61866c69 Update go_deps asset
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I3aadf24555b7250e30b23717cc88b6f1239bcf44
Reviewed-on: https://skia-review.googlesource.com/c/172620
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2018-11-23 05:44:07 +00:00
skia-autoroll
dc10465db5 Roll third_party/externals/angle2 df066e9cded2..15992bef28d8 (2 commits)
df066e9cde..15992bef28


git log df066e9cded2..15992bef28d8 --date=short --no-merges --format='%ad %ae %s'
2018-11-23 jiajia.qin@intel.com Update deqp31 test expectations
2018-11-22 syoussefi@chromium.org Vulkan: Internal Compute support


Created with:
  gclient setdep -r third_party/externals/angle2@15992bef28d8

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=csmartdalton@google.com

Change-Id: I4c88b516d926b4776f5893749ee13248cd61e108
Reviewed-on: https://skia-review.googlesource.com/c/172602
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2018-11-23 03:40:33 +00:00
skia-autoroll
d992373f21 Roll third_party/externals/swiftshader 46988abef6c8..8d2cf7525167 (2 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/46988abef6c8..8d2cf7525167


git log 46988abef6c8..8d2cf7525167 --date=short --no-merges --format='%ad %ae %s'
2018-11-23 capn@google.com Fix unaligned access undefined behavior.
2018-11-23 capn@google.com Fix undefined behavior in OFFSET().


Created with:
  gclient setdep -r third_party/externals/swiftshader@8d2cf7525167

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=csmartdalton@google.com

Change-Id: I2911b1dc6080261f375524b07eae64947e4ccd0b
Reviewed-on: https://skia-review.googlesource.com/c/172601
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2018-11-23 02:21:32 +00:00
skia-autoroll
1c0ea2893e Roll third_party/externals/swiftshader 18a84258b13d..46988abef6c8 (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/18a84258b13d..46988abef6c8


git log 18a84258b13d..46988abef6c8 --date=short --no-merges --format='%ad %ae %s'
2018-11-22 sugoi@google.com Removed SwiftShader's custom LogicalOperation enum


Created with:
  gclient setdep -r third_party/externals/swiftshader@46988abef6c8

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=csmartdalton@google.com

Change-Id: If1f6058e304f59bc194931c889ecc265877ba3b3
Reviewed-on: https://skia-review.googlesource.com/c/172600
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2018-11-22 22:22:04 +00:00
skia-autoroll
4a3f1fe4ee Roll third_party/externals/angle2 efe061bd4f9d..df066e9cded2 (1 commits)
efe061bd4f..df066e9cde


git log efe061bd4f9d..df066e9cded2 --date=short --no-merges --format='%ad %ae %s'
2018-11-22 syoussefi@chromium.org Vulkan: Remove vk::ShaderType


Created with:
  gclient setdep -r third_party/externals/angle2@df066e9cded2

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=csmartdalton@google.com

Change-Id: I2df059c03ae7efed464d888be5c4e8abcdb101c8
Reviewed-on: https://skia-review.googlesource.com/c/172580
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2018-11-22 18:34:09 +00:00
skia-autoroll
2a7215287d Roll third_party/externals/angle2 dc65c5bd8452..efe061bd4f9d (2 commits)
dc65c5bd84..efe061bd4f


git log dc65c5bd8452..efe061bd4f9d --date=short --no-merges --format='%ad %ae %s'
2018-11-22 jie.a.chen@intel.com Optimize HLSL zero initializer
2018-11-22 jmadill@chromium.org Don't use gl::Error in validation.


Created with:
  gclient setdep -r third_party/externals/angle2@efe061bd4f9d

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=csmartdalton@google.com

Change-Id: I260fa6bafe252c77c28883ddf134535258f5e92f
Reviewed-on: https://skia-review.googlesource.com/c/172547
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2018-11-22 09:52:11 +00:00
skia-bookmaker
724d5dd8a3 Update markdown files
Automatic commit by the Housekeeper-Nightly-Bookmaker bot.

TBR=rmistry@google.com
NO_MERGE_BUILDS

Change-Id: I018eedf6cb28518656d1578f71f1f2d60a1fbdd7
Reviewed-on: https://skia-review.googlesource.com/c/172561
Commit-Queue: <skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com>
Reviewed-by: <skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com>
2018-11-22 06:03:05 +00:00
skia-recreate-skps
c64a2ec654 Update go_deps asset
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I68e4d259bc79bed7b75a0100f986e1ea95a4d103
Reviewed-on: https://skia-review.googlesource.com/c/172560
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2018-11-22 05:56:33 +00:00
skia-autoroll
4bff78e57c Roll third_party/externals/angle2 6aab06e0e5d4..dc65c5bd8452 (2 commits)
6aab06e0e5..dc65c5bd84


git log 6aab06e0e5d4..dc65c5bd8452 --date=short --no-merges --format='%ad %ae %s'
2018-11-21 jmadill@chromium.org Vulkan: Cache pipelines with Shader Programs.
2018-11-21 courtneygo@google.com Revert "Fix AndroidManifest package name"


Created with:
  gclient setdep -r third_party/externals/angle2@dc65c5bd8452

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=csmartdalton@google.com

Change-Id: I738bfe66b41d516cd8404d98d6f6555f191e5548
Reviewed-on: https://skia-review.googlesource.com/c/172545
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2018-11-22 01:01:16 +00:00
recipe-roller
d98f75ea8d Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/20068b80c82fb44c9e871f18ee82e1c032c000af [recipe_modules/archive] Update archive to zip entire root by default. (iannucci@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib4e425729c054990245b1a32a7cbf022324cc50d
Reviewed-on: https://skia-review.googlesource.com/c/172523
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
2018-11-22 01:01:06 +00:00
skia-autoroll
cce480a1a6 Roll third_party/externals/swiftshader dcb803a7af64..18a84258b13d (3 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/dcb803a7af64..18a84258b13d


git log dcb803a7af64..18a84258b13d --date=short --no-merges --format='%ad %ae %s'
2018-11-21 sugoi@google.com Placeholder object for VkPipelineCache
2018-11-21 sugoi@google.com Initial implementation of CommandPool
2018-11-21 sugoi@google.com Vulkan Sampler implementation


Created with:
  gclient setdep -r third_party/externals/swiftshader@18a84258b13d

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=csmartdalton@google.com

Change-Id: I471dc116b053a47e378c2981774e699fe41bdb9f
Reviewed-on: https://skia-review.googlesource.com/c/172544
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2018-11-21 23:20:47 +00:00
Florin Malita
f7d6ac1f0d [sksg] Expose SkFont::Edging in TextNode
(instead of SkPaint flags)

TBR=
Change-Id: I31566f29d7922b26898234c357d8d249ebc1e094
Reviewed-on: https://skia-review.googlesource.com/c/172504
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2018-11-21 22:48:00 +00:00
skia-autoroll
690c8cd086 Roll third_party/externals/swiftshader e2ecf37519d2..dcb803a7af64 (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/e2ecf37519d2..dcb803a7af64


git log e2ecf37519d2..dcb803a7af64 --date=short --no-merges --format='%ad %ae %s'
2018-11-21 sugoi@google.com Removed SwiftShader's custom Depth/Stencil comparison enums


Created with:
  gclient setdep -r third_party/externals/swiftshader@dcb803a7af64

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=csmartdalton@google.com

Change-Id: I388bc43f68e00ec666ceacb836f1bdc077c55f2c
Reviewed-on: https://skia-review.googlesource.com/c/172542
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2018-11-21 22:18:36 +00:00
Florin Malita
baa01d18ce Allow null typefaces in SkFont::textToGlyphs()
(fallout from https://skia-review.googlesource.com/c/skia/+/172482)

SkPaint::textToGlyphs() handles null typefaces gracefully, as do the
drawing methods.

Update SkFont::textToGlyphs() to also use the default TF as a fallback.

Change-Id: I9fc0712beef7a81a3fa6b3b2dd05ed75ac81f0a1
Reviewed-on: https://skia-review.googlesource.com/c/172505
Commit-Queue: Florin Malita <fmalita@chromium.org>
Reviewed-by: Mike Reed <reed@google.com>
2018-11-21 22:04:35 +00:00
Brian Osman
975197ce8f Fix sampling location for dashed circle in p3_ovals
I was sampling near the edge of the stroke, not the middle of it,
so some configs were picking up antialiased pixels.

Bug: skia:
Change-Id: I46314ba0bafe056505037deaa8dd32f4f68119f6
Reviewed-on: https://skia-review.googlesource.com/c/172503
Auto-Submit: Brian Osman <brianosman@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2018-11-21 21:17:04 +00:00
skia-autoroll
94436bb4f5 Roll third_party/externals/swiftshader b16f9897a868..e2ecf37519d2 (2 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/b16f9897a868..e2ecf37519d2


git log b16f9897a868..e2ecf37519d2 --date=short --no-merges --format='%ad %ae %s'
2018-11-21 sugoi@google.com Add support for all vulkan formats in Surface::bytes()
2018-11-21 sugoi@google.com Replaced sw::Format with VkFormat


Created with:
  gclient setdep -r third_party/externals/swiftshader@e2ecf37519d2

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=csmartdalton@google.com

Change-Id: I5edb46d6be6cb7d913822c9d31ab20b83bb4d861
Reviewed-on: https://skia-review.googlesource.com/c/172541
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2018-11-21 21:01:09 +00:00
Mike Reed
2ed7820970 use SkFont in a lot of places
Bug: skia:
Change-Id: I86df3f650eb5bb0219b3251ef5f8e95403838bba
Reviewed-on: https://skia-review.googlesource.com/c/172482
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2018-11-21 20:44:03 +00:00
recipe-roller
3065b5223d Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/d66dad7fc2c3caad80c0117ae0ee625d7367a14a [vpython] Re-roll to pick up user differentiation of cached envs (iannucci@chromium.org)
recipe_engine:
  https://crrev.com/4118c738aa691c9c2b69f8b69359a9ba4fece9d7 [buildbucket] Document gitiles_commit (nodir@google.com)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I1a0ca58bd5c1e1be183dc6ff17aaf079d5fb3ef0
Reviewed-on: https://skia-review.googlesource.com/c/172501
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-11-21 20:27:59 +00:00
Brian Osman
e3caf2dfa1 Use GrVertexColor in various oval ops
p3_ovals GM exercises four different oval ops. Before, they all drew
wrong in extended range GPU configs. Now, they all draw correctly.

Bug: skia:
Change-Id: I4ea803b6325bfd20e9361880b1822cc6f0441cea
Reviewed-on: https://skia-review.googlesource.com/c/172480
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2018-11-21 20:26:29 +00:00
Brian Salomon
a6dddeaac9 Disable sampler objects when using ES2 shading language on ES3 contexts.
Bug: https://github.com/flutter/flutter/issues/24402
Bug: https://github.com/flutter/flutter/issues/24289
Bug: https://github.com/flutter/flutter/issues/24391
Bug: https://github.com/flutter/flutter/issues/24517
Bug: https://github.com/flutter/flutter/issues/23900

Change-Id: I15aa8241f0c4d4b25f00aed9f6fabbe73ecf89ce
Reviewed-on: https://skia-review.googlesource.com/c/172405
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2018-11-21 20:19:35 +00:00
Ben Wagner
95dec69511 Upgrade Windows in Skolo.
Change-Id: Ic6613e5d922f3addd31030c28540797238451a75
Reviewed-on: https://skia-review.googlesource.com/c/172404
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2018-11-21 19:57:43 +00:00
Cary Clark
e9c5a15993 fix bookmaker
Mark experimental method in SkCanvas as "Experimental" in its
comment. Maybe it should be enough to name the routine experimental_...
but for now bookmaker requires the comment to say that as well.

Change the TextIntercept examples to #NoExample.

TBR=reed@google.com,bsalomon@google.com

Docs-Preview: https://skia.org/?cl=172402
Bug: skia:
Change-Id: Id74b59e141d5002a8b6118ca28cb9c62a36e2f02
Reviewed-on: https://skia-review.googlesource.com/c/172402
Reviewed-by: Cary Clark <caryclark@skia.org>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Cary Clark <caryclark@skia.org>
2018-11-21 19:15:59 +00:00
Brian Salomon
ea02708e07 Add SK_API to SkCanvas::ImageSetEntry to fix Chrome roll
Change-Id: I9c73ff0ca6badb9c357f75c6054286d5a787a324
Reviewed-on: https://skia-review.googlesource.com/c/172403
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Auto-Submit: Brian Salomon <bsalomon@google.com>
2018-11-21 18:29:33 +00:00
Mike Klein
e5b08df792 move NEON matrixProcs into matrixProcs.cpp
This is basically a no-op, just me doing a little bookkeeping to get
src/opts fully cleaned up.  As usual, I want to do more refactoring
after moving this around, as another CL probably.

Cq-Include-Trybots: luci.chromium.try:linux-blink-rel
Change-Id: I789611f90b8a86c88e34e95024109a7599463406
Reviewed-on: https://skia-review.googlesource.com/c/172421
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2018-11-21 16:32:37 +00:00
skia-autoroll
0dfceb7eb4 Roll third_party/externals/angle2 836674c28b1e..6aab06e0e5d4 (1 commits)
836674c28b..6aab06e0e5


git log 836674c28b1e..6aab06e0e5d4 --date=short --no-merges --format='%ad %ae %s'
2018-11-21 geofflang@chromium.org Don't allow unary operators on void types.


Created with:
  gclient setdep -r third_party/externals/angle2@6aab06e0e5d4

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=csmartdalton@google.com

Change-Id: I657ecb01744189882cd1a7b527a45c8984478008
Reviewed-on: https://skia-review.googlesource.com/c/172380
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2018-11-21 16:04:32 +00:00
Mike Reed
45f8266e79 add flag to flutter
Bug: skia:
Change-Id: If55cd90b7ddd176348ceee178ffbc369a14a631e
Reviewed-on: https://skia-review.googlesource.com/c/172401
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Mike Reed <reed@google.com>
2018-11-21 15:49:24 +00:00
Brian Salomon
1da5cade3e Make experimental_drawImageSet support per-quad alpha.
The V0 version of this will use the product of the "global" and per-quad
alpha.

A new V1 version is added that does not take a global alpha.

The V0 version will be removed once SkiaRenderer no longer uses it.


Bug: skia:8563
Change-Id: Iace3dff6c4f1fd1a5c6c30eb8226f4815c58e0ed
Reviewed-on: https://skia-review.googlesource.com/c/172146
Commit-Queue: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Auto-Submit: Brian Salomon <bsalomon@google.com>
2018-11-21 14:50:41 +00:00
Mike Reed
114bde830b Revert "Revert "add rect-parameter to makeImageSnapshot""
This reverts commit 1e28e5d79e.

Bug: skia:
Change-Id: I71c246885721c71de540e9079ecf7323234c8871
Reviewed-on: https://skia-review.googlesource.com/c/172302
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2018-11-21 14:46:06 +00:00
Brian Osman
2aaae01145 Revert "Prefer GrAAConvexPathRenderer over ccpr"
This reverts commit c00e470547.

Reason for revert: Appears to fix flakiness on NUC5PPYH-Vulkan

Original change's description:
> Prefer GrAAConvexPathRenderer over ccpr
>
> Even though ccpr can be faster than the convex renderer for small
> paths, there is value in a simpler, more consistent approach. The
> convex renderer is single-pass, doesn't deal with caching, and is
> unaffected by the less favorable flush pattern in Chrome. We can
> address the regressions from this CL by optimizing single-pass convex
> path rendering, rather than trying to use ccpr more.
>
> Bug: chromium:860021
> Change-Id: I44ceefa43cdad7fb25c620faed8b525901fb1f0c
> Reviewed-on: https://skia-review.googlesource.com/c/171525
> Reviewed-by: Chris Dalton <csmartdalton@google.com>
> Reviewed-by: Brian Salomon <bsalomon@google.com>
> Commit-Queue: Chris Dalton <csmartdalton@google.com>

TBR=bsalomon@google.com,csmartdalton@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:860021
Change-Id: Iccbb663b885cbc3c31b41f70cee36633d8177ecb
Reviewed-on: https://skia-review.googlesource.com/c/172144
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Reviewed-by: Chris Dalton <csmartdalton@google.com>
2018-11-21 14:14:36 +00:00
Mike Reed
9a370396f1 default behavior for onNewImageSnapshot
Bug: skia:
Change-Id: Ibfd546c4e9cf5c2bdd853cfe3b344fb1ef7b9d91
Reviewed-on: https://skia-review.googlesource.com/c/172303
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2018-11-21 13:35:35 +00:00
Mike Reed
1e28e5d79e Revert "add rect-parameter to makeImageSnapshot"
This reverts commit e195d1c22e.

Reason for revert: broke android subclass (illegal)

Original change's description:
> add rect-parameter to makeImageSnapshot
> 
> Bug: skia:
> Change-Id: I56044fb1f21b959993d69fc587f95e3dbf30c371
> Reviewed-on: https://skia-review.googlesource.com/c/171905
> Commit-Queue: Mike Reed <reed@google.com>
> Auto-Submit: Mike Reed <reed@google.com>
> Reviewed-by: Brian Salomon <bsalomon@google.com>

TBR=djsollen@google.com,egdaniel@google.com,jvanverth@google.com,bsalomon@google.com,reed@google.com

Change-Id: Ied294732b332192e251a845a5cb6349a670c25b0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/c/172301
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2018-11-21 13:13:37 +00:00
Mike Klein
302809f47e streamline some of the _matrixProcs
- We're always tiling the same way in X and Y,
    so fold that through in a few ways.
  - Simplify the interface between _matrixProcs.cpp and _matrix.h.

Cq-Include-Trybots: luci.chromium.try:linux-blink-rel
Change-Id: If306b4506b960bfe8156d0f3f5d28f14ccf4b40a
Reviewed-on: https://skia-review.googlesource.com/c/172023
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2018-11-21 12:47:00 +00:00
skia-recreate-skps
0f995fbb48 Update go_deps asset
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I8df06bdd33f743f1d7b893fdc021314c088f5f41
Reviewed-on: https://skia-review.googlesource.com/c/172240
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2018-11-21 05:57:00 +00:00
Mike Reed
e195d1c22e add rect-parameter to makeImageSnapshot
Bug: skia:
Change-Id: I56044fb1f21b959993d69fc587f95e3dbf30c371
Reviewed-on: https://skia-review.googlesource.com/c/171905
Commit-Queue: Mike Reed <reed@google.com>
Auto-Submit: Mike Reed <reed@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2018-11-21 02:58:28 +00:00
Ravi Mistry
ef3f9bef86 Revert "Reland "Temporarily remove Android compile bot from CQ""
This reverts commit bbb4bd3cef.

Reason for revert: Working again

Original change's description:
> Reland "Temporarily remove Android compile bot from CQ"
> 
> This reverts commit a63cf8e80a.
> 
> Reason for revert: Syncing from repo is timing out
> 
> Original change's description:
> > Revert "Temporarily remove Android compile bot from CQ"
> > 
> > This reverts commit f7376330d1.
> > 
> > Reason for revert: Bot is working again
> > 
> > Original change's description:
> > > Temporarily remove Android compile bot from CQ
> > > 
> > > This is to coordinate landing https://skia-review.googlesource.com/c/skia/+/171231
> > > 
> > > NoTry: true
> > > Bug: skia:
> > > Change-Id: I35994d3b8626308e5e3f2bd63141c42c9b9bfde8
> > > Reviewed-on: https://skia-review.googlesource.com/c/171720
> > > Reviewed-by: Ravi Mistry <rmistry@google.com>
> > > Commit-Queue: Ravi Mistry <rmistry@google.com>
> > 
> > TBR=rmistry@google.com,scroggo@google.com
> > 
> > Change-Id: I0a3266fd1b4dd0566bf7e7f297d453d855d76567
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: skia:
> > Reviewed-on: https://skia-review.googlesource.com/c/171961
> > Reviewed-by: Ravi Mistry <rmistry@google.com>
> > Commit-Queue: Ravi Mistry <rmistry@google.com>
> 
> TBR=rmistry@google.com,scroggo@google.com
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: skia:
> Change-Id: I205e707064a14920a40da68d4bfa4fae17df4904
> Reviewed-on: https://skia-review.googlesource.com/c/172202
> Reviewed-by: Ravi Mistry <rmistry@google.com>
> Commit-Queue: Ravi Mistry <rmistry@google.com>

TBR=rmistry@google.com,scroggo@google.com

Change-Id: I76a2cd17146b2e50358b85e27ffa2ff0b8fbb13b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/c/172223
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2018-11-21 02:44:39 +00:00
recipe-roller
b135c9c37c Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/0a264d861b56446cf6715e69741d2a3e61628ced git cl: remove Rietveld import and things it depends on. (tandrii@chromium.org)
  https://crrev.com/a185e2e3c83d805d3306a3f1fe9258ae2e75f231 git cl: remove Rietveld implementation entirely. (tandrii@chromium.org)
  https://crrev.com/a85a4b01ee72af77de3a7245af1ffe81bac26acc Don't fetch flash when fetching android_internal. (reland) (jbudorick@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia7ea42d66e84b798416ab3a16e54cc3a2a064afa
Reviewed-on: https://skia-review.googlesource.com/c/172150
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-11-21 01:38:04 +00:00
recipe-roller
f65d0c5af6 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/f491306841e4858116e27f8e035138ff8fc71a85 [vpython] Roll to pick up user differentiation of cached envs. (iannucci@chromium.org)
  https://crrev.com/dc3adea9e12f2ef1314dbdba853b81fc1e7517a2 Revert "[vpython] Roll to pick up user differentiation of cached envs." (vadimsh@chromium.org)
  https://crrev.com/dd5e09a1c31785b67ceae41e21eb7b7ced0cac87 git cl: get rid of Rietveld's upload.py import. (tandrii@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ic9bd0469b271d1d740cac514557e15be13852771
Reviewed-on: https://skia-review.googlesource.com/c/172149
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
2018-11-21 01:03:38 +00:00
skia-autoroll
b39cc5ca67 Roll third_party/externals/angle2 0e604f9f1107..836674c28b1e (4 commits)
0e604f9f11..836674c28b


git log 0e604f9f1107..836674c28b1e --date=short --no-merges --format='%ad %ae %s'
2018-11-20 geofflang@chromium.org Expose GL_CHROMIUM_compressed_texture_etc on top of ES drivers.
2018-11-20 geofflang@chromium.org Skip SetUp and TearDown in VulkanCommandBufferPerfTest if its flaky.
2018-11-20 geofflang@chromium.org Fix typo in OWNERS file email address.
2018-11-20 jmadill@chromium.org Use xxHash for faster hash map lookups.


Created with:
  gclient setdep -r third_party/externals/angle2@836674c28b1e

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=csmartdalton@google.com

Change-Id: Iba22e7296662dd986d31d4f5a32fb95281e1496f
Reviewed-on: https://skia-review.googlesource.com/c/172196
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2018-11-21 01:03:37 +00:00
recipe-roller
9d571deccf Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/61e9778154390ab10658548dc19dfa400e131d8d Revert "Don't fetch flash when fetching android_internal." (jbudorick@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ic1a0fd7d1850bc21afac0ba4ecc373f8b251033d
Reviewed-on: https://skia-review.googlesource.com/c/172148
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
2018-11-20 22:58:15 +00:00
Ravi Mistry
bbb4bd3cef Reland "Temporarily remove Android compile bot from CQ"
This reverts commit a63cf8e80a.

Reason for revert: Syncing from repo is timing out

Original change's description:
> Revert "Temporarily remove Android compile bot from CQ"
> 
> This reverts commit f7376330d1.
> 
> Reason for revert: Bot is working again
> 
> Original change's description:
> > Temporarily remove Android compile bot from CQ
> > 
> > This is to coordinate landing https://skia-review.googlesource.com/c/skia/+/171231
> > 
> > NoTry: true
> > Bug: skia:
> > Change-Id: I35994d3b8626308e5e3f2bd63141c42c9b9bfde8
> > Reviewed-on: https://skia-review.googlesource.com/c/171720
> > Reviewed-by: Ravi Mistry <rmistry@google.com>
> > Commit-Queue: Ravi Mistry <rmistry@google.com>
> 
> TBR=rmistry@google.com,scroggo@google.com
> 
> Change-Id: I0a3266fd1b4dd0566bf7e7f297d453d855d76567
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: skia:
> Reviewed-on: https://skia-review.googlesource.com/c/171961
> Reviewed-by: Ravi Mistry <rmistry@google.com>
> Commit-Queue: Ravi Mistry <rmistry@google.com>

TBR=rmistry@google.com,scroggo@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: skia:
Change-Id: I205e707064a14920a40da68d4bfa4fae17df4904
Reviewed-on: https://skia-review.googlesource.com/c/172202
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2018-11-20 22:26:56 +00:00