Commit Graph

32964 Commits

Author SHA1 Message Date
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
8a0fb003c2 Roll skia/third_party/externals/skcms/ 2f0bbab5e..3b6adcfa3 (3 commits)
https://skia.googlesource.com/skcms/+log/2f0bbab5e928..3b6adcfa3a75

$ git log 2f0bbab5e..3b6adcfa3 --date=short --no-merges --format='%ad %ae %s'
2018-02-22 brianosman First pass of A2B API
2018-02-22 brianosman Use SVG transform so the raw SVG *is* the fixed point
2018-02-22 mtklein argv[1] -> filename

Created with:
  roll-dep skia/third_party/externals/skcms


The AutoRoll server is located here: https://skcms-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=djsollen@google.com

Change-Id: I20861fb3fd2fd8649fd25b11b517a43faf6c5715
Reviewed-on: https://skia-review.googlesource.com/109540
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-02-22 21:10:49 +00:00
Chris Dalton
2612baecd8 ccpr: Prefer atlas sizes under 4k on ARM
Bug: skia:
Change-Id: Ib5afb84647efe2e64a3ec2f9da422b39228431e9
Reviewed-on: https://skia-review.googlesource.com/108871
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2018-02-22 21:06:05 +00:00
Mike Klein
ee77da2c0b set -Wno-implicit-fallthrough on GCC too
Bug: skia:7643

Change-Id: Ieeca5414f51c7c113c54b47578ec840fc7d684e0
Reviewed-on: https://skia-review.googlesource.com/109520
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2018-02-22 21:05:45 +00:00
Brian Salomon
020dbe7917 Don't assert that GLSL shader compilation succeeded in Chrome
Bug: chromium:82186
Change-Id: Ie4ef3b766117b9693702917203d2bb87e1ddbe7d
Reviewed-on: https://skia-review.googlesource.com/109482
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
2018-02-22 20:25:35 +00:00
Mike Reed
242135a402 move some RRect methods into priv
also, return radii by value instead of reference, in possible prep for changing underlying representation

Bug: skia:7649
Change-Id: Iff42a49c53cc48171fc63462be366cc3500b2273
Reviewed-on: https://skia-review.googlesource.com/109385
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2018-02-22 19:09:10 +00:00
angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
2c03492621 Roll skia/third_party/externals/angle2/ 24842908c..1dce1bd38 (1 commit)
24842908c4..1dce1bd38e

$ git log 24842908c..1dce1bd38 --date=short --no-merges --format='%ad %ae %s'
2017-12-06 yizhou.jiang Add test case to catch depth stencil buffer bug on Intel windows

Created with:
  roll-dep skia/third_party/externals/angle2
BUG=782317


The AutoRoll server is located here: https://angle-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE
TBR=djsollen@google.com

Change-Id: I0c9a3ed235de7956a76cb4aaaa0e25a696283426
Reviewed-on: https://skia-review.googlesource.com/109344
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-02-22 18:00:39 +00:00
Eric Boren
86a1146852 Add bot which builds without DEPS
Bug: skia:7646
Change-Id: Iddf55940230c99fea9d838a1b03a8c3bb476262e
Reviewed-on: https://skia-review.googlesource.com/109360
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2018-02-22 17:47:56 +00:00
Mike Reed
85fdbe2b5c detect bad radius in cornerpatheffect
Bug: skia:
Change-Id: I88b0be68e3099bcf6df608ded0e875c7a60bb5d6
Reviewed-on: https://skia-review.googlesource.com/109381
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2018-02-22 17:47:55 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
5e11edf4c0 Roll skia/third_party/externals/skcms/ 422746635..2f0bbab5e (1 commit)
https://skia.googlesource.com/skcms/+log/4227466359eb..2f0bbab5e928

$ git log 422746635..2f0bbab5e --date=short --no-merges --format='%ad %ae %s'
2018-02-22 brianosman Add -s option to iccdump to write SVG of TRC curves

Created with:
  roll-dep skia/third_party/externals/skcms


The AutoRoll server is located here: https://skcms-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=djsollen@google.com

Change-Id: I1b5fc913cddd4a1c32caafe9c7043562b4de5e1a
Reviewed-on: https://skia-review.googlesource.com/109342
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-02-22 17:42:52 +00:00
Herb Derby
f5041623dd Small cleanup of SkPaint
Change-Id: I79d4e5bace8898c184d8fc80d9e45d39b63b5fe5
Reviewed-on: https://skia-review.googlesource.com/109386
Commit-Queue: Herb Derby <herb@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Mike Klein <mtklein@chromium.org>
2018-02-22 17:42:50 +00:00
Mike Klein
085bc52363 write -isystem paths relative to the build root
The default makes these system-absolute paths,
which confuses fiddle's overlay builds.

Now we should see things like,

  -isystem ../third_party/externals/jsoncpp/include

where we previously had,

  -isystem /Users/mtklein/skia/third_party/externals/jsoncpp/include

Change-Id: I7b161a550fdb95b06e17c372cd5bec3015e3c8b7
Reviewed-on: https://skia-review.googlesource.com/109382
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2018-02-22 16:06:32 +00:00
Mike Reed
61e30b2e81 add checks for enough data in path deserialization
Bug: oss-fuzz:6501
Change-Id: Ie77d57268947be2cc56f846ce21f154e0d469112
Reviewed-on: https://skia-review.googlesource.com/109320
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2018-02-22 14:48:44 +00:00
Stephan Altmueller
85834d1265 Remove SkQP bot from master
Bug: skia:
Change-Id: I0415690911a52059eaaf7f32c81b7a4c66117d5b
Reviewed-on: https://skia-review.googlesource.com/109162
Commit-Queue: Stephan Altmueller <stephana@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2018-02-22 12:58:47 +00:00
angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
6ede412188 Roll skia/third_party/externals/angle2/ df4b63164..24842908c (1 commit)
df4b631648..24842908c4

$ git log df4b63164..24842908c --date=short --no-merges --format='%ad %ae %s'
2018-02-02 fjhenigman New test for vertex attribute arrangements.

Created with:
  roll-dep skia/third_party/externals/angle2


The AutoRoll server is located here: https://angle-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE
TBR=djsollen@google.com

Change-Id: I2d6c69a6db5a0f4b404526143173609175aaa364
Reviewed-on: https://skia-review.googlesource.com/109266
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-02-22 08:34:07 +00:00
angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
aa58935285 Roll skia/third_party/externals/angle2/ e5fe7aad8..df4b63164 (46 commits)
e5fe7aad84..df4b631648

$ git log e5fe7aad8..df4b63164 --date=short --no-merges --format='%ad %ae %s'
2018-01-18 fjhenigman Vulkan: Add unmap in BufferVk::getIndexRange.
2018-02-21 jmadill Fix missing include files visible to GN.
2018-02-20 jmadill Vulkan: Add CommandGraph class.
2018-02-20 jmadill Add gl::RenderbufferState shared state helper.
2018-02-02 geofflang D3D11: Downsample when copying to emulated 16-bit texture formats.
2018-02-20 jmadill Add empty file to prevent git clean from deleting the tools folder.
2018-02-14 geofflang StateManagerGL: Use dirty bits for VAO bindings.
2018-02-16 cwallez Expand the EGLIOSurfaceClientBufferTests
2018-02-16 oetuaho Add a constexpr constructor for TFunction
2018-02-16 oetuaho Avoid redundant symbol lookup when parsing functions
2018-02-16 jmadill Don't no-op draw calls for zero count in validation.
2018-02-15 jmadill Vulkan: Implement basic Renderbuffer attachments.
2018-02-16 oetuaho Simplify built-in function node initialization
2017-01-05 fjhenigman Vulkan: vertex attributes in client memory.
2018-02-15 thakis Mark third-party code in ANGLE as no_chromium_code.
2018-02-15 jmadill Add missing is_fuchsia to system_utils selection.
2018-02-15 jmadill Vulkan: Add depth/stencil surfaces.
2018-02-15 oetuaho Clean up dead insertion of unmangled symbols
2018-02-12 thakis Enable -Wimplicit-fallthrough for ANGLE.
2018-02-14 lfy GLES1: macOS: Add rpath to libGLESv1_CM.dylib
2018-02-09 shinchiro Fix mingw compile.
2018-02-08 lfy GLES1: Mat4 transform library
2018-02-14 ynovikov Fix standalone Linux build
2017-11-07 geofflang StateManagerGL: Use dirty bits for framebuffer bindings.
2018-02-14 jmadill Vulkan: Cache clear color in ContextVk.
2018-02-14 jmadill Vulkan: Pass RendererVk to Allocate helpers.
2018-02-14 jmadill Vulkan: Implement basic Renderbuffer creation.
2018-02-14 lucferron AngleWrangle: Suppress newly introduced flakyness
2018-02-08 lucferron Vulkan: Autogen mandatory texture caps
2017-09-21 geofflang D3D: Implement robust resource init for Surfaces.
2018-02-14 jmadill Revert "Vulkan: Add glslang validator to build."
2018-02-13 yunchao.he Code refactoring for end2end tests.
2018-02-09 lucferron Vulkan: Add culling rasterization states tests and invert front face
2018-02-07 lucferron Vulkan: Texture caps map
2018-02-13 oetuaho Store invariant varying names as ImmutableString
2018-02-08 oetuaho Don't search for nonexistent brackets in InitializeVariables
2018-02-12 tobine Put Vulkan mock ICD json file in separate dir
2018-01-29 oetuaho Add a constexpr constructor for TVariable
2018-02-12 geofflang Remove usage of ANGLE_FALLTHROUGH in EmulatePrecision.cpp
2018-02-12 jmadill Add test for scissored clear.
2018-02-08 brandon1.jones Enable Multisample Sources in copyImageInternal For D3D11
2018-02-12 jmadill Vulkan: Add glslang validator to build.
2018-02-02 jiawei.shao ES31: Add link validation on geometry shader itself
2018-02-12 geofflang Revert "GLES1: Link against angle_util_static instead of angle_util."
2018-02-02 jie.a.chen Vulkan: Prepend layer path to VK_LAYER_PATH
2018-02-11 yunchao.he Clean up end2end tests for Intel OSX.

Created with:
  roll-dep skia/third_party/externals/angle2
BUG=810767


The AutoRoll server is located here: https://angle-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE
TBR=djsollen@google.com

Change-Id: I23133c2b60746b8cf251eba611ae84f56bd3247c
Reviewed-on: https://skia-review.googlesource.com/109103
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-02-21 23:48:07 +00:00
Mike Reed
529cb2cd75 lowp impl for decal stages
Bug: skia:
Change-Id: If6481d202bf22a95f1dea0c5bf7d84698b63869a
Reviewed-on: https://skia-review.googlesource.com/109241
Commit-Queue: Mike Reed <reed@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Mike Klein <mtklein@chromium.org>
2018-02-21 22:23:07 +00:00
Derek Sollenberger
2bafb796e5 Fix Angle autoroller by adding missing platform specific files.
Change-Id: Ib1b3c760b8769fb0e342b69ec7954e2a30d74599
Reviewed-on: https://skia-review.googlesource.com/109200
Commit-Queue: Derek Sollenberger <djsollen@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
2018-02-21 22:18:07 +00:00
Robert Phillips
59ddc6d5ee Revert "Separate creation time & flush time behavior in GrDrawOpAtlas"
This reverts commit 056c1a821a.

Reason for revert: GM issues

Original change's description:
> Separate creation time & flush time behavior in GrDrawOpAtlas
> 
> This CL clarifies what is going on in the GrDrawOpAtlas and GrAtlasGlyphCache.
> 
> For the GrDrawOpAtlas:
>   At creation time all the allowed pages are created (with their backing GrTextureProxies) but they aren't instantiated.
> 
>   The GrDrawOpAtlas::instantiate call is called in preFlushCB and allocates any pages known to be needed at the start of flush
> 
>   GrDrawOpAtlas::addToAtlas is called at flush time and, if a new page is activated, will instantiated it at that time.
> 
>   During compaction, an unused page will be deInstantiated but its Plots and backing GrTextureProxy will remain alive.
> 
> The GrAtlasGlyphCache reflects the changes to the GrDrawOpAtlas
>   It now carries a GrProxyProvider for when it needs to create an atlas
>   It passes in a GrResourceProvider* at flush time to allow instantiation.
> 
>   It does not, yet, allocate that GrDrawOpAtlases it might ever require.
> 
> Change-Id: I54909b7a3ba4bec2db5f1218f6a2a3a1636f66d6
> Reviewed-on: https://skia-review.googlesource.com/108520
> Commit-Queue: Robert Phillips <robertphillips@google.com>
> Reviewed-by: Jim Van Verth <jvanverth@google.com>

TBR=jvanverth@google.com,bsalomon@google.com,robertphillips@google.com

Change-Id: I36eafe46209380f533aa84e831d1c9d18844b6be
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/109280
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2018-02-21 21:56:47 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
7630dcd794 Roll skia/third_party/externals/skcms/ a08b368a6..422746635 (4 commits)
https://skia.googlesource.com/skcms/+log/a08b368a683d..4227466359eb

$ git log a08b368a6..422746635 --date=short --no-merges --format='%ad %ae %s'
2018-02-21 brianosman Pre-parse the TRC curves into skcms_ICCProfile
2018-02-21 mtklein restrict skcms-Win to Win 2016
2018-02-21 mtklein get Clang and GCC into the debugbreak game
2018-02-21 brianosman Use __debugbreak when a test expectation fails on Windows

Created with:
  roll-dep skia/third_party/externals/skcms


The AutoRoll server is located here: https://skcms-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=djsollen@google.com

Change-Id: Ibb297a94e48fbe5e21ec5c162411329d89c5a927
Reviewed-on: https://skia-review.googlesource.com/109116
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-02-21 21:35:07 +00:00
Mike Reed
267ecccfed change path serialization version to 4
New format should be much simpler:
- only store public data (e.g. points, verbs, filltype)
- deserialize just uses public APIs

Refactor reading code to manage different (older) versions, to make
it clear (hopefully) what we can delete when we can abandon version
3 support.

Bug: skia:
Change-Id: I30465f891cba3f044ae1cb2c13c04f04fdc9da78
Reviewed-on: https://skia-review.googlesource.com/109160
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Reed <reed@google.com>
2018-02-21 21:22:37 +00:00
Hal Canary
528b446889 SkQP/Doc: new APKs
No-Try: true
Change-Id: I4b71afc1c2629d3aca4f6c0b6bd1fdebc9d954be
Reviewed-on: https://skia-review.googlesource.com/109167
Reviewed-by: Hal Canary <halcanary@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
2018-02-21 21:15:36 +00:00
Hal Canary
f637cc01f8 SkQP: run a single test
PLEASE NOTE:  Instructions on running `am instrument` for the
SkQP APK have changed.

To run a single test, see the section "Running a single test"
in `tools/skqp/README.md`.

No-Try: true
Change-Id: I0a2cbc47755929d6c6a927a3591ff98046779c77
Reviewed-on: https://skia-review.googlesource.com/108780
Reviewed-by: Derek Sollenberger <djsollen@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
2018-02-21 20:49:56 +00:00
Mike Klein
cdcadf7a29 remove fetch-gn dependency on buildtools
This makes it possible to fetch GN without syncing DEPS.

To roll GN now, just update the three hashes in bin/fetch-gn.

buildtools is still a dependency of fetch-clang-format.

Bug: skia:7634

Change-Id: Ida6b516cfb0b306da73550875ab1ff97c9da6a64
Reviewed-on: https://skia-review.googlesource.com/107882
Reviewed-by: Hal Canary <halcanary@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2018-02-21 20:42:26 +00:00
Mike Klein
138bd155ed use -isystem for headers from third_party
This supresses warnings from code in those headers,
e.g. warnings about switch case fallthrough in SDL_memset4(),
defined inline in SDL_stdinc.h.

Change-Id: I5341a67d4949b28ec5ffa6b7ae433748406e99db
Reviewed-on: https://skia-review.googlesource.com/109140
Reviewed-by: Hal Canary <halcanary@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2018-02-21 20:40:36 +00:00
Peng Huang
df285ce3be Fix the link error for component build
Bug: skia:
Change-Id: I670eeee09547edb46db498a9439c5d6066c6fe55
Reviewed-on: https://skia-review.googlesource.com/109106
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2018-02-21 19:49:16 +00:00
Robert Phillips
056c1a821a Separate creation time & flush time behavior in GrDrawOpAtlas
This CL clarifies what is going on in the GrDrawOpAtlas and GrAtlasGlyphCache.

For the GrDrawOpAtlas:
  At creation time all the allowed pages are created (with their backing GrTextureProxies) but they aren't instantiated.

  The GrDrawOpAtlas::instantiate call is called in preFlushCB and allocates any pages known to be needed at the start of flush

  GrDrawOpAtlas::addToAtlas is called at flush time and, if a new page is activated, will instantiated it at that time.

  During compaction, an unused page will be deInstantiated but its Plots and backing GrTextureProxy will remain alive.

The GrAtlasGlyphCache reflects the changes to the GrDrawOpAtlas
  It now carries a GrProxyProvider for when it needs to create an atlas
  It passes in a GrResourceProvider* at flush time to allow instantiation.

  It does not, yet, allocate that GrDrawOpAtlases it might ever require.

Change-Id: I54909b7a3ba4bec2db5f1218f6a2a3a1636f66d6
Reviewed-on: https://skia-review.googlesource.com/108520
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Jim Van Verth <jvanverth@google.com>
2018-02-21 19:46:56 +00:00
Chris Dalton
9ce9507a7f Fix touch coordinate mapping in Windows
Coordinates were not previously being mapped correctly from screen
coordinates to window coordinates.

Bug: skia:
Change-Id: Ie56ac3b42273aede6f97ee6f83ac9766020510ea
Reviewed-on: https://skia-review.googlesource.com/109109
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2018-02-21 19:38:36 +00:00
Robert Phillips
e4fda6c70d Pull non-substantive changes out of omnibus CL
These come from: https://skia-review.googlesource.com/c/skia/+/108001 (Fission GrAtlasGlyphCache in two)

Bug: skia:
Change-Id: Ife15cad018f9ddedec578fcd6aa07da00a77196e
Reviewed-on: https://skia-review.googlesource.com/109026
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2018-02-21 18:43:26 +00:00
Robert Phillips
038c608a86 Remove back pointer to GrAtlasGlyphCache from GrAtlasTextStrike
This is calved off from https://skia-review.googlesource.com/c/skia/+/108001 (Fission GrAtlasGlyphCache in two)

In the DDL world, the GrAtlasTextStrikes can outlive their generating GrAtlasGlyphCache.

Change-Id: I52b01d3934b0651a58a59b12dcc4c98ffbb891a9
Reviewed-on: https://skia-review.googlesource.com/109061
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2018-02-21 18:35:16 +00:00
Mike Klein
955b3d5580 tweak surface_image_unity on 32-bit bots
The allocations implied by the larger sizes can exhaust the 32-bit
virtual address space, even if we don't touch the bytes to page them in.

Add a 1<<18 test case to make sure we always test something outside
16-bit sizes, even on 32-bit bots.

Bug: skia:7614

Change-Id: I6bae930e89bd969931f478a8896f07451f7af595
Reviewed-on: https://skia-review.googlesource.com/108602
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2018-02-21 18:33:36 +00:00
Florin Malita
83286a0df2 Don't consume mouse events in SkottieSlide
We want to togle inval display on click, but if we always consume the
event we disable pan/zoom in viewer.

TBR=

Change-Id: I1f785883252c4f4a09fd35d4a05485849bf7e8ef
Reviewed-on: https://skia-review.googlesource.com/109084
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2018-02-21 18:25:26 +00:00
Greg Daniel
0a7aa14bf3 Add checks for failed SkImageInfo2GrPixelConfig calls
Bug: skia:7645
Change-Id: I32b9326fb43490ef6a7a99527243b68d89184ae1
Reviewed-on: https://skia-review.googlesource.com/109083
Commit-Queue: Greg Daniel <egdaniel@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2018-02-21 18:22:47 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
32f72e25bd Roll skia/third_party/externals/skcms/ c01187370..a08b368a6 (1 commit)
https://skia.googlesource.com/skcms/+log/c011873700a6..a08b368a683d

$ git log c01187370..a08b368a6 --date=short --no-merges --format='%ad %ae %s'
2018-02-21 mtklein the more complex linear transfer function is fine now

Created with:
  roll-dep skia/third_party/externals/skcms


The AutoRoll server is located here: https://skcms-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=djsollen@google.com

Change-Id: Ibef014efcd4dfa26e5a4a23c729b28ec60aca667
Reviewed-on: https://skia-review.googlesource.com/109043
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-02-21 18:12:07 +00:00
Brian Osman
c35d7eab7b Don't use LOD bias on OES external textures
Change-Id: Id366b644576c6e4763c0c081b6a6b40f4e930df7
Reviewed-on: https://skia-review.googlesource.com/109024
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2018-02-21 17:54:38 +00:00
Greg Daniel
f87651e7b8 Update createWrappedRenderTargetProxy with BackendTex to use lazy proxies
Bug: skia:
Change-Id: I5a5519aebe544cb5ef62e9847c3fa4e218f24aea
Reviewed-on: https://skia-review.googlesource.com/108561
Commit-Queue: Greg Daniel <egdaniel@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2018-02-21 17:13:32 +00:00
Kevin Lubick
2388866c8d Check for null colorFilter in FuzzCanvas
Follow up to https://skia-review.googlesource.com/c/skia/+/108300

Bug: skia:
Change-Id: I1b8b6ff71c71388660e09b3a7e8c77a40b1a1d12
Reviewed-on: https://skia-review.googlesource.com/108960
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2018-02-21 17:13:12 +00:00
Jim Van Verth
5d32b83102 Add isFinite() bounds check for drawPoints
Bug: 811095
Change-Id: I09a55622a19ebfc9430d7676eb8764c074f1bcb7
Reviewed-on: https://skia-review.googlesource.com/109022
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
2018-02-21 16:43:02 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
835e26526f Roll skia/third_party/externals/skcms/ 481c6e1bc..c01187370 (1 commit)
https://skia.googlesource.com/skcms/+log/481c6e1bcfef..c011873700a6

$ git log 481c6e1bc..c01187370 --date=short --no-merges --format='%ad %ae %s'
2018-02-20 mtklein add a 2.4 gamma guess

Created with:
  roll-dep skia/third_party/externals/skcms


The AutoRoll server is located here: https://skcms-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=djsollen@google.com

Change-Id: Ib9e2dd72ae8a7799617817c6e99288f3024626f4
Reviewed-on: https://skia-review.googlesource.com/109001
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-02-21 14:48:42 +00:00
Cary Clark
bd8b25a7b4 writePixels should notify GPU that pixels have changed
R=reed@google.com,robertphillips@google.com
Bug: skia:7644
Change-Id: I469c537a649e4d8d05a78cedb26caa3057d824c1
Reviewed-on: https://skia-review.googlesource.com/108961
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Cary Clark <caryclark@google.com>
2018-02-21 13:58:22 +00:00
Yuqian Li
aefcccb5d8 Enable DAA in the init-once phase of threaded backends
Bug: skia:
Change-Id: Idb856fe12f0f9fa1014e7d15ef40bd7b456634d6
Reviewed-on: https://skia-review.googlesource.com/107540
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Yuqian Li <liyuqian@google.com>
2018-02-21 09:28:04 +00:00
Update Docs
9fd8eb6fec Update markdown files
Automatic commit by the Housekeeper-Nightly-Bookmaker bot.

TBR=update-docs@skia.org
NO_MERGE_BUILDS

Change-Id: I59daa665c267b712415211a60120431b265891ef
Reviewed-on: https://skia-review.googlesource.com/108940
Commit-Queue: Update Docs <update-docs@skia.org>
Reviewed-by: Update Docs <update-docs@skia.org>
2018-02-21 06:20:34 +00:00
Ben Wagner
483c772cfd Add nativeFonts flag to Viewer.
This moves DMFontMgr and several related files which are tightly related
to fonts into tools/fonts, moves some flags around to prevent
duplication, and adds the nativeFonts handling to Viewer.

Change-Id: Id1bdad708a6b74319ac5ac9adfe21025db4ca0b2
Reviewed-on: https://skia-review.googlesource.com/108904
Commit-Queue: Ben Wagner <bungeman@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
2018-02-21 03:31:14 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
14b7375aa6 Roll skia/third_party/externals/skcms/ fa14d14de..481c6e1bc (1 commit)
https://skia.googlesource.com/skcms/+log/fa14d14dea7d..481c6e1bcfef

$ git log fa14d14de..481c6e1bc --date=short --no-merges --format='%ad %ae %s'
2018-02-20 brianosman Add all unique profiles from Skia's test images

Created with:
  roll-dep skia/third_party/externals/skcms


The AutoRoll server is located here: https://skcms-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=djsollen@google.com

Change-Id: Ia64d9e33096ca19a134e34ababdfb7fb0d518b26
Reviewed-on: https://skia-review.googlesource.com/108866
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-02-20 22:42:05 +00:00
Florin Malita
60d3bfcef5 [skottie] Show inval rects on mouse click in SkottieSlide
Also fix a SlideDir sizing bug.

TBR=

Change-Id: Iee61bb6665dc56ddd6fc062a686a9c0ef87dea92
Reviewed-on: https://skia-review.googlesource.com/108902
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2018-02-20 22:12:43 +00:00
Mike Reed
cbb85a7275 remove deprecated method
Bug: skia:
Change-Id: Icd5c3b83c97f5039a530f87a3a813e4d9e9f8833
Reviewed-on: https://skia-review.googlesource.com/108662
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Mike Reed <reed@google.com>
2018-02-20 21:41:44 +00:00
Robert Phillips
f3690dd416 Change signature of GrAtlasGlyphCache::getProxies
Split out of https://skia-review.googlesource.com/c/skia/+/108001 (Fission GrAtlasGlyphCache in two)

TBR=bsalomon@google.com
Change-Id: I573730fdeddf178915eb5f5b8cf59a3ab29e0654
Reviewed-on: https://skia-review.googlesource.com/108441
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2018-02-20 21:16:53 +00:00
Jim Van Verth
a8c55fa4fe Pad atlas uploads to 4-byte boundaries
Change-Id: I678358c176e318d89892ced5c76cd2662774a7d6
Reviewed-on: https://skia-review.googlesource.com/108566
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
2018-02-20 21:06:13 +00:00
Chris Dalton
2d18f41858 Resurrect pathfinder in viewer and rename to "bisect"
Bug: skia:
Change-Id: If8d2f46b8f27fefc3a0f983eb649654e0fb4afcb
Reviewed-on: https://skia-review.googlesource.com/108685
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2018-02-20 20:44:33 +00:00
Ben Wagner
5423f1f0c5 Correct font metrics, bitmap glyph metrics and underline.
Correct ScaleFontMetrics to scale all of the metrics. Also update the
test fonts, since they were created with the previously unscaled
metrics.

Fix the ascent, descent, and underline position for bitmap glyphs with
FreeType.

Change-Id: I8c2f6e9d6a7e86b0bb08dc619f62ffcce4ad2df2
Reviewed-on: https://skia-review.googlesource.com/108600
Commit-Queue: Ben Wagner <bungeman@google.com>
Reviewed-by: Hal Canary <halcanary@google.com>
2018-02-20 20:40:23 +00:00
Cary Clark
ee78dbe529 update path docs online
No-Try: true
Docs-Preview: https://skia.org/?cl=108840
Bug: skia:6898
Change-Id: I9ce1e68c37e65218f6ad447b0aa915581f06ae0e
Reviewed-on: https://skia-review.googlesource.com/108840
Commit-Queue: Cary Clark <caryclark@skia.org>
Reviewed-by: Cary Clark <caryclark@skia.org>
2018-02-20 20:15:13 +00:00