Commit Graph

42096 Commits

Author SHA1 Message Date
recipe-roller
a25993a246 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/67c48200732195aa9a9a1d13b895d43ac68692d8 [git-cl] Fix crash in "git cl upload" (borenet@google.com)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I065f42447120f600787b3916c1ebb583a7969121
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/217113
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2019-05-30 17:30:28 +00:00
Michael Ludwig
4a0cf5071f Remove old GrFillRectOp factories
Also renames MakeGeneric() back to Make() and updates tests

Change-Id: I493c40d84ef1a075bddca72939f46a81bea5dea7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/215091
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2019-05-30 17:26:28 +00:00
Robert Phillips
6fc7e2142b Clean update ETC1 data utilities
Change-Id: I03d5d86c617f2f9cca5c1198d242ce0fbb5b2f14
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/217120
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2019-05-30 17:08:08 +00:00
Florin Malita
0fe004c14c [skottie] Shaper: fission glyphs into separate fragments when needed
In the presence of animated text properties, we want the Shaper result
glyphs to be split into separate fragments.

Add a Shaper flag to request this mode, and upate the logic to emit
one fragment per glyph, when active.  Otherwise fall back to the
current/consolidated blob mode.

Change-Id: If7440e5fa1ae2f8855984d3ae4d6852b10b2316c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216879
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2019-05-30 17:05:00 +00:00
Robert Phillips
f62e575bab Use GrVkImage utilities in GrVkGpu::createTestingOnlyVkImage
An attempt to share more code. Pulled out of:

https://skia-review.googlesource.com/c/skia/+/216610 (Implement color-based backend texture creation for Vulkan)

Change-Id: Ie109cfc00fe47b7060be51d4c23f1b8f7db2328c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216875
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2019-05-30 16:56:18 +00:00
Hal Canary
3a0590ec1a SkPDF: implement kDecal image shader TileMode
Change-Id: Iccdfaed4b47f95e4a134d8732264599a8179d187
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216876
Commit-Queue: Hal Canary <halcanary@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
2019-05-30 16:33:08 +00:00
Hal Canary
fcea9a9161 SkPDF: MakeShader uses Color4f
Also some minor refactoring in make_image_shader().

Change-Id: I6061ebeb8c297045b1a276160fe18cc6ae54bde7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216867
Commit-Queue: Hal Canary <halcanary@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
Auto-Submit: Hal Canary <halcanary@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
2019-05-30 14:52:29 +00:00
Ben Wagner
bd8c724fd4 Correct shaper assert around iterator fonts.
The assert here was intended to catch the case where a font run iterator
produced a font without specifying a typeface. This should never happen.
However, it is currently fine for the user to pass in a font without
specifying a typeface, which really means they don't care.

Change-Id: Ib63430142b9a05b4f2f8603e7a56a0ac09fa219f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216874
Commit-Queue: Ben Wagner <bungeman@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2019-05-30 14:47:58 +00:00
Mike Reed
5093e23de6 support assets for skottie2movie
Change-Id: Icb66c9cf4eb2db72997b566fe863dab21d2824ef
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216871
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Mike Reed <reed@google.com>
2019-05-30 14:37:29 +00:00
Herb Derby
b3043e4d70 Collapse the SkTextInterceptsIter into base class
Reorganize the glyph Intercepts code to allow bulk operation.
This is just reorganizing and inlining existing code.

+ Shorten some long lines.

Change-Id: I1a01b50d94386279d3a8715a78266ee8a27547b5
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216606
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2019-05-30 13:57:38 +00:00
Brian Osman
3e29f1dd63 Interpreter: Elide dup/pop around stores
This centralizes the logic for popping unwanted expression
results into writeExpression (controlled by 'discard').
Then, it extends a few other functions to also take that
discard parameter, and skip the work that was being done to
leave the expression result on the stack - and thus saving
the need for the pop. Those functions that may (or may not)
honor the discard request return the new value.

Produces much cleaner code for assignments (and ++).

Change-Id: I62bc62df823efda2af77c55f4eee32403496a4ee
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/215837
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2019-05-30 13:42:38 +00:00
Ben Wagner
e8db325168 Add trivial implemenations of shaper run iterators.
Change-Id: I71f9cf2971cdb44ae2d189e29afc2ab330750dcb
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216780
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2019-05-30 13:19:28 +00:00
Ravi Mistry
cf01a5ccd9 Add new G3 compile try bot
NoTry: true
Bug: skia:9021
Change-Id: Ifbba8d23fefc383d0dec9e14e08cdf42e67b3e57
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216642
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2019-05-30 13:10:08 +00:00
Ravi Mistry
783d607073 Add recipe for triggering and waiting for G3 compile tasks
NoTry: true
Bug: skia:9021
Change-Id: I20448aebccaa9e408f8942bf05641183aadd9fc8
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216641
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2019-05-30 12:51:48 +00:00
Ravi Mistry
4bcdb6b9aa Script to trigger and wait for G3 compile tasks
Tested success case with:
python trigger_wait_g3_task.py --issue 190200 --patchset 14

Tested failure case with:
python trigger_wait_g3_task.py --issue 94900 --patchset 4

Tested merge conflict with:
python trigger_wait_g3_task.py --issue 209802 --patchset 1

Tested unauthorized case with:
python trigger_wait_g3_task.py --issue 216568 --patchset 5


NoTry: true
Bug: skia:9021
Change-Id: I7d1438f460e176c8ef61de704a7b326f77d7b503
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216640
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2019-05-30 12:09:38 +00:00
Mike Reed
69aaee0ff9 Revert "Compare pixels for TypefaceWithNoPaths test"
This reverts commit 405735228f.

Reason for revert: failing on android bots

Original change's description:
> Compare pixels for TypefaceWithNoPaths test
> 
> Change-Id: I786b741462ca2b68b43e5f3443671c4a7e2f801f
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216614
> Reviewed-by: Khushal Sagar <khushalsagar@chromium.org>
> Commit-Queue: Herb Derby <herb@google.com>

TBR=herb@google.com,khushalsagar@chromium.org

Change-Id: Ib958c1b6c8893e100743d827aa50d5273d2a4cd6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216861
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2019-05-30 11:40:59 +00:00
Heather Miller
655ee0f015 Update Skia milestone to 77
Change-Id: I997f82ec6d61b896b332c9cd0c731500a99a38f9
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216860
Reviewed-by: Heather Miller <hcm@google.com>
Commit-Queue: Heather Miller <hcm@google.com>
Auto-Submit: Heather Miller <hcm@google.com>
2019-05-30 11:15:58 +00:00
skia-autoroll
2f0f5fb37d Roll third_party/externals/angle2 ded5f903261a..172e5d373fad (11 commits)
ded5f90326..172e5d373f


git log ded5f903261a..172e5d373fad --date=short --no-merges --format='%ad %ae %s'
2019-05-29 syoussefi@chromium.org Vulkan: Implement universal stencil resolve
2019-05-29 spang@chromium.org Vulkan: Submit semaphores from glWaitSemaphoreEXT & glSignalSemaphoreEXT
2019-05-29 syoussefi@chromium.org Vulkan: fix buffer copy barriers
2019-05-29 jonahr@google.com Add EGL_ANGLE_workaround_control extension.
2019-05-29 jmadill@chromium.org Update Windows AMD suppression.
2019-05-29 spang@chromium.org Vulkan: Support submitting multiple semaphores
2019-05-29 spang@chromium.org Vulkan: Reuse flushImpl() from finishImpl()
2019-05-29 syoussefi@chromium.org Vulkan: Implement multisampled framebuffers
2019-05-29 geofflang@chromium.org Vulkan: Rename getSubmitFence to getNextSubmitFence.
2019-05-29 aleino@nvidia.com Use D3D11 GetDimensions driver workaround for 3D textures
2019-05-29 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src 6c7db9c63098..f051812343eb (3 commits)


Created with:
  gclient setdep -r third_party/externals/angle2@172e5d373fad

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=kjlubick@google.com

Change-Id: Ia9013c001348feefd70facf0675b38e9fbfdff8e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216823
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-05-30 05:44:01 +00:00
skia-autoroll
2d25d871d3 Roll ../src b3e0873d64ad..97d3c9084977 (529 commits)
b3e0873d64..97d3c90849


Created with:
  gclient setdep -r ../src@97d3c90849

The AutoRoll server is located here: https://autoroll.skia.org/r/chromium-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Release-All-CommandBuffer;skia.primary:Test-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Debug-All-CommandBuffer
TBR=kjlubick@google.com

Change-Id: Ia6ca7c4936fb00546f2d0377f9be941269c6b357
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216824
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-05-30 04:54:10 +00:00
skia-autoroll
859f7108a5 Roll third_party/externals/swiftshader ca8e3d7c153e..37bc82ac64f5 (11 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/ca8e3d7c153e..37bc82ac64f5


git log ca8e3d7c153e..37bc82ac64f5 --date=short --no-merges --format='%ad %ae %s'
2019-05-29 chrisforbes@google.com Enable arm32 build for pastel
2019-05-29 chrisforbes@google.com Various additional fixes for Android build
2019-05-29 chrisforbes@google.com Adjust llvm7 file list to include passes required for arm target
2019-05-29 hliatis@google.com Fire VkFence in vkAcquireImageANDROID
2019-05-29 hliatis@google.com Fix memory leak in vkDestroyImage
2019-05-29 srisser@google.com Fix buffer overflow on Mac
2019-05-29 capn@google.com Fix initializing bits after bitfields
2019-05-29 samans@chromium.org Fix build failure
2019-05-29 samans@chromium.org Fix alignment of VkWrapper
2019-05-29 srisser@google.com Fix Mac builds when using llvm.
2019-05-29 swiftshader.regress@gmail.com Regres: Update test lists @ ca8e3d7c


Created with:
  gclient setdep -r third_party/externals/swiftshader@37bc82ac64f5

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=kjlubick@google.com

Change-Id: Ib4552c4dba31c2e1670f391070e2260822f97dba
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216822
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-05-30 04:32:50 +00:00
recipe-roller
56543311ae Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/77e19d35dc361460fab352eafc1255c820131644 Roll led to latest version. (iannucci@chromium.org)
  https://crrev.com/9779b146cdfec9abb6bb7ad1a7e8d21916a3dfd1 git-cl: Use modern environment variable name to trigger tracing (jrn@google.com)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I7a28a87cf10375c5cf70d30bcd76a855e6e6c564
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216767
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2019-05-29 23:48:56 +00:00
Florin Malita
eca7315109 [skottie] Add a Shaper line buffer
Instead of committing glyphs directly to SkTextBlob buffers, accumulate
data for a full line before passing to the builder.

For now this doesn't have any effect (other than making a data copy),
but the intermediate buffer will be used for

  a) post-shaping adjustments (justification, tracking?)
  b) multi-blob/fragmented shape results

Change-Id: I45796ef2fd491a14322c32672137ac90138f36ef
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216686
Commit-Queue: Florin Malita <fmalita@chromium.org>
Reviewed-by: Ben Wagner <bungeman@google.com>
2019-05-29 22:10:05 +00:00
Brian Osman
5bdf525b9c Fix divide by zero in interpreter test
Change-Id: I43f8663b70aaa7c0a006f61b1194475fc11e0846
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216692
Commit-Queue: Brian Osman <brianosman@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
Auto-Submit: Brian Osman <brianosman@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
2019-05-29 21:30:06 +00:00
recipe-roller
bc7e403e6d Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/57101cd8c0028985759fb381f064ee77b3e0adbc Refactor new_step_stream to take only the essential data. (iannucci@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ieb23022986b238b0d8b951aeaf913ba9ccd6a21d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216690
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2019-05-29 21:28:10 +00:00
recipe-roller
063b5d7b9e Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/55b0c542ede5a3ed4e93c0c844559ea74790e5ea cq: expose api.cq.props_for_child_build property. (tandrii@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ied7ebcd8ac958f91d99593eaee2d6761dcf921dd
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216685
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2019-05-29 21:00:03 +00:00
Greg Daniel
b3f82dddfc Reland "Remove call to copy in GrcontextPriv read/write pixel calls."
This reverts commit 1013ecfb34.

Reason for revert: relanding with fix

Original change's description:
> Revert "Remove call to copy in GrcontextPriv read/write pixel calls."
>
> This reverts commit d0d66fb8be.
>
> Reason for revert: crashing on readpixels on some android bots
>
> Original change's description:
> > Remove call to copy in GrcontextPriv read/write pixel calls.
> >
> > Instead we just directly do all those copies as draws.
> >
> > Change-Id: I0cd9dfc6f96e35fbbc9c153a28a08eebf1d7b77f
> > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216356
> > Commit-Queue: Greg Daniel <egdaniel@google.com>
> > Reviewed-by: Brian Salomon <bsalomon@google.com>
> > Reviewed-by: Robert Phillips <robertphillips@google.com>
>
> TBR=egdaniel@google.com,bsalomon@google.com,robertphillips@google.com
>
> Change-Id: I2b39564e0b20cf83e21744c91ee8ddb9d988ab22
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216608
> Reviewed-by: Greg Daniel <egdaniel@google.com>
> Commit-Queue: Greg Daniel <egdaniel@google.com>

TBR=egdaniel@google.com,bsalomon@google.com,robertphillips@google.com

Change-Id: Ic5a8d453efbfe38cd6cb1a95c504b10ef8a9cf22
No-Presubmit: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216615
Commit-Queue: Greg Daniel <egdaniel@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
2019-05-29 20:32:32 +00:00
Brian Osman
909231c8de Interpreter: Matrix/Vector multiplication
Change-Id: I3dc5e5be1cf12c581cce3854d0db7e73db6e1fd9
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216681
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
2019-05-29 20:32:31 +00:00
Brian Osman
1e855b22b7 Interpreter: Support component-wise ops for matrices
The linear algebra cases are more complex, coming in separate CL.

Change-Id: I5bbc25a126b61eee6f5b9775ab142e103c00f837
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216612
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2019-05-29 20:24:02 +00:00
recipe-roller
21399d0407 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/edb73a793557dcbdfe6854f27d90d3d488fa04ec Make nested parent steps have strict scope. (iannucci@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I6e3e6923511c17206e48dcf9689779b231e905e1
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216678
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2019-05-29 20:21:51 +00:00
Mike Reed
210a28a8cf rm dead code
Change-Id: I2829d94451ce0278b44b98ca0195d04124b669fb
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216682
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
Auto-Submit: Mike Reed <reed@google.com>
2019-05-29 20:09:04 +00:00
recipe-roller
9f01b30841 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/96104d42dad1ff62acc4aa58540286690ea4a34a [cipd] Update lucicfg 1.7.7 => 1.7.8. (vadimsh@chromium.org)
recipe_engine:
  https://crrev.com/8b16a36e64065fb9a59237d9cbeb1b4123910e8f json: api.json.loads as test_api.json.loads. (tandrii@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia8588c328c3af183b091d7b2163c8b6cade11c8f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216617
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2019-05-29 19:50:31 +00:00
Herb Derby
405735228f Compare pixels for TypefaceWithNoPaths test
Change-Id: I786b741462ca2b68b43e5f3443671c4a7e2f801f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216614
Reviewed-by: Khushal Sagar <khushalsagar@chromium.org>
Commit-Queue: Herb Derby <herb@google.com>
2019-05-29 19:37:51 +00:00
Michael Ludwig
aa1b6b36a4 Make stencilRect() in GrRTCPriv more flexible.
All GrFillRectOps in core code go through a GrRTC call.

Also adds a utility constructor for non-AA rects since this simplifies clears
and tests/GMs that called GrFillRectOp directly. This helps preserve
readability without forcing them to go through the full rect drawing pipeline.

Change-Id: I6694c1aded3b89d773a897c483f7f2a51b06e6e8
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/215089
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2019-05-29 19:30:31 +00:00
Brian Osman
7df8fff2a3 Avoid SkTMax in sksl
Change-Id: Id549b9a398b7fe52b08b89c0d50db79953434ba5
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216616
Auto-Submit: Brian Osman <brianosman@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2019-05-29 19:02:21 +00:00
Robert Phillips
e3bd673fbf Use GrGLGpu::createTextureImpl from w/in GrGLGpu::createBackendTexture
In general we want to have one way to create textures which is shared by the two use cases (i.e., Skia proper and explicit allocation API).
This brings the two paths (i.e., createBackendTexture and onCreateTexture) into closer alignment.

Change-Id: I176a6ebdc6e8634d3aaa59d440b2099df2bd6eff
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216613
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2019-05-29 18:56:31 +00:00
Mike Reed
f97e8e961b simplify api to make encoder, use swscale for faster rgb->yuv
Change-Id: I19ea48667aa843e1166231fe8d2622af91cce972
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216611
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
2019-05-29 17:59:18 +00:00
Brian Osman
16e6fd53a1 Interpreter: Fix vector/matrix equality and inequality
Need to compare all elements, then fold the result to a single bool.

Change-Id: I0ebfaa9d518f29a782701246ada247cb55c01c2e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216607
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2019-05-29 17:42:58 +00:00
Brian Salomon
a86fc7a63b Specialize GrBicubicEffet for 1d kernel.
This saves texture reads when we need to scale in x or y but not both
when doing an async rescale and read.

Change-Id: I9e3550585875a1b42db7a2a7bb8bfacf3e840a01
Bug: skia:8962
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216520
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2019-05-29 17:38:16 +00:00
Greg Daniel
1013ecfb34 Revert "Remove call to copy in GrcontextPriv read/write pixel calls."
This reverts commit d0d66fb8be.

Reason for revert: crashing on readpixels on some android bots

Original change's description:
> Remove call to copy in GrcontextPriv read/write pixel calls.
> 
> Instead we just directly do all those copies as draws.
> 
> Change-Id: I0cd9dfc6f96e35fbbc9c153a28a08eebf1d7b77f
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216356
> Commit-Queue: Greg Daniel <egdaniel@google.com>
> Reviewed-by: Brian Salomon <bsalomon@google.com>
> Reviewed-by: Robert Phillips <robertphillips@google.com>

TBR=egdaniel@google.com,bsalomon@google.com,robertphillips@google.com

Change-Id: I2b39564e0b20cf83e21744c91ee8ddb9d988ab22
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216608
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2019-05-29 16:17:34 +00:00
Stephen White
8a3c059796 GrTessellator: fix event creation for dead boundary edges.
In some cases, an overlap boundary edge can be nulled out by the creation
of a skeleton edge. In that case, we should avoid trying to create
parallel edge events from that dead edge.

This required making the tessellator verb maximum verb count modifiable
at runtime for testing, since the test case has more than 10 vertices.

Also added more logging.

BUG: 966696
Change-Id: I429735999f6297655311485bc68d732b1c48bfce
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216284
Commit-Queue: Stephen White <senorblanco@chromium.org>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2019-05-29 15:51:25 +00:00
Greg Daniel
d0d66fb8be Remove call to copy in GrcontextPriv read/write pixel calls.
Instead we just directly do all those copies as draws.

Change-Id: I0cd9dfc6f96e35fbbc9c153a28a08eebf1d7b77f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216356
Commit-Queue: Greg Daniel <egdaniel@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2019-05-29 15:13:25 +00:00
Brian Osman
29e013deb4 Interpreter: Fix construction of Matrices
Per GLSL, constructing a matrix from a scalar produces a matrix
with the scalar value along the diagonal, and zero elsewhere.
Constructing a matrix from another matrix copies the overlapping
values, and fills in the remainder with the identity matrix.

Doing either of these with existing opcodes was going to be quite
verbose and tricky, so I just made new opcodes.

I've also got some (currently disabled) test cases for other
matrix behavior, all of which fail in various ways today.

Change-Id: Ia86a183395f1ac7e2f23ee1d6bb4af461f5ba93a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/215823
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2019-05-29 13:03:02 +00:00
Brian Salomon
c7e9f78d10 Change async rescale and read GM to test diff number of x/y bicubic steps
Change-Id: I18db9602aa7d158aebd9549f393740229057b92b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216500
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2019-05-29 12:37:31 +00:00
Herb Derby
bfa8767bb2 Move source space fallback strike calculations to SkStrikeSpecStorage
This will move the cache to source ration onto the SkStrikeSpecStorage
instead of passing it along as an extra parameter.

Change-Id: Ie19665c8cd8f02798f9ea75d421a4c9337eb1f37
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216358
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2019-05-29 12:36:02 +00:00
skia-autoroll
633db4db76 Roll third_party/externals/angle2 3fe06eb3aaaf..ded5f903261a (12 commits)
3fe06eb3aa..ded5f90326


git log 3fe06eb3aaaf..ded5f903261a --date=short --no-merges --format='%ad %ae %s'
2019-05-28 geofflang@chromium.org Vulkan: Make the Vulkan renderer thread safe.
2019-05-28 geofflang@chromium.org Vulkan: Use atomics in SerialFactory.
2019-05-28 jmadill@chromium.org D3D11: Suppress failing Texture test on AMD.
2019-05-28 geofflang@chromium.org Vulkan: Move command graph and garbage to ContextVk.
2019-05-28 jonahr@google.com Addition of dEQP "KHR" test variants to generate_stats
2019-05-28 geofflang@chromium.org GL: Allow BlitGL to copy from external textures.
2019-05-28 geofflang@chromium.org D3D: Use the ProgramD3D::GetExecutableTask context for loading program binaries
2019-05-28 syoussefi@chromium.org Vulkan: Have a cubemap as 2D-array view handy
2019-05-28 jonahr@google.com Cleanup Features headers.
2019-05-28 aleino@nvidia.com Use D3D11 GetDimensions driver workaround for 2D array textures
2019-05-28 aleino@nvidia.com Test D3D11 GetDimensions driver workaround for textureProjOffset
2019-05-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src 42abaa099aab..6c7db9c63098 (3 commits)


Created with:
  gclient setdep -r third_party/externals/angle2@ded5f903261a

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=kjlubick@google.com

Change-Id: Ic6e1d6e41c7d87eeaa1c31ee560a544d7c0a3129
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216562
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-05-29 06:06:02 +00:00
recipe-roller
2b650797a9 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/2ee83757a109f65cd4e831b257385a258f99c9d5 [autoninja] use custom status in non-windows too (tikuta@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I671e6f5d709d3699fb05fca25c07d2f8e5d0b5cb
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216569
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2019-05-29 05:39:21 +00:00
skia-autoroll
bdb2d67a91 Roll ../src a4545bae034e..b3e0873d64ad (467 commits)
a4545bae03..b3e0873d64


Created with:
  gclient setdep -r ../src@b3e0873d64

The AutoRoll server is located here: https://autoroll.skia.org/r/chromium-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Release-All-CommandBuffer;skia.primary:Test-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Debug-All-CommandBuffer
TBR=kjlubick@google.com

Change-Id: I901fad2d92f444842e104652f06c9e43a5789e20
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216563
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-05-29 05:17:31 +00:00
skia-autoroll
00365de163 Roll third_party/externals/swiftshader 710fcd517ea4..ca8e3d7c153e (23 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/710fcd517ea4..ca8e3d7c153e


git log 710fcd517ea4..ca8e3d7c153e --date=short --no-merges --format='%ad %ae %s'
2019-05-28 bclayton@google.com Reactor: Fix printing of small integer values.
2019-05-28 bclayton@google.com SpirvShader: Correctly handle phi values in the loop merge
2019-05-28 bclayton@google.com SpirvShader: Simplify the logic around the generation of the inner loop.
2019-05-28 bclayton@google.com LLVMReactor: Mutex calls to llvm::orc::IRCompileLayer.
2019-05-28 bclayton@google.com Reactor: Add UInt4 constructors taking UInt
2019-05-28 bclayton@google.com Reactor: Fix all memory leaks with rr::DebugInfo.
2019-05-28 chrisforbes@google.com Fix accidentally considering Workgroup to be explicit layout
2019-05-28 bclayton@google.com Reactor: Add swizzle op for UInt4.
2019-05-28 capn@google.com Support images with linear tiling for transfers
2019-05-28 capn@google.com Implement Y′CbCr conversion
2019-05-28 capn@google.com Fix single-plane views of YCbCr formats
2019-05-28 capn@google.com Refactor writing texture level descriptor info
2019-05-28 capn@google.com Take the plane/aspect into account when copying/blitting
2019-05-28 capn@google.com Implement VkSamplerYcbcrConversion object
2019-05-28 capn@google.com Claim support for YCbCr 3- and 2-plane 420 format
2019-05-28 capn@google.com Allow additional info to be passed to object's Create functions
2019-05-28 capn@google.com Add 8-bit YCbCr 420 format info
2019-05-28 capn@google.com Refactor obtaining format aspect info
2019-05-28 capn@google.com Implement OpImageGather
2019-05-28 capn@google.com Refactor texel names
2019-05-28 capn@google.com Fix taking the sampling instruction type into account
2019-05-28 capn@google.com Fix interpolating z when using FragCoord builtin
2019-05-28 swiftshader.regress@gmail.com Regres: Update test lists @ 710fcd51


Created with:
  gclient setdep -r third_party/externals/swiftshader@ca8e3d7c153e

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=kjlubick@google.com

Change-Id: I452dcc6f9eedb321519f7f0f3b5ebd6ed60eb96a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216561
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-05-29 04:56:51 +00:00
Herb Derby
25b63f91b3 Remove getGlyphIDAdvance() from SkStrike's API
Change-Id: Id9648dfc44ec7bc7f37a281236ff5fc756f6e646
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/215610
Commit-Queue: Herb Derby <herb@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2019-05-29 03:25:21 +00:00
recipe-roller
c573ec8ab2 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/d90d37f751848195850d2af1a300d9c95dd2a2b8 Remove unused name_prefix complexity. (iannucci@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I05692518a156e8b4110d650cd661cead3e83c4bb
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216494
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2019-05-29 01:53:31 +00:00