Commit Graph

13550 Commits

Author SHA1 Message Date
halcanary
86cfff0a4d valgrind suppression for zlib Flate Test
NOTREECHECKS=true
NOTRY=true
R=bsalomon@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/477733002
2014-08-14 13:08:45 -07:00
bsalomon
87c35adbda Remove aarects benchmark. Redundant with rotated_rects* bench and *much* slower.
NOTREECHECKS=true
R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/469373003
2014-08-14 13:03:58 -07:00
bsalomon
a7f79b47fa remove internal repeat count from gradient benches
NOTREECHECKS=true
R=mtklein@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/476923002
2014-08-14 12:24:46 -07:00
Brian Salomon
f878e3cb3c Rebaseline and remove tests from ignored-tests.txt
BUG=skia:

Review URL: https://codereview.chromium.org/475013002
2014-08-14 13:51:16 -04:00
mtklein
60c7707958 Guard ANGLE and MESA instead of defining them as native when unsupported.
Since we've added "angle" to the default list of configs we've been running
kNative_GLContextType tests twice in DM, once for the real native, once for
angle.  This pointlessly doubles the GPU critical path in DM.  Whoops.

NOTREECHECKS=true

BUG=skia:
R=bsalomon@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/471063002
2014-08-14 10:36:55 -07:00
epoger
9f1ae465c8 rebaseline_server: show Pending Approval tab if viewing SKP expectations vs actuals
BUG=skia:1918
NOTREECHECKS=true
NOTRY=true
R=stephana@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/473973002
2014-08-14 09:55:36 -07:00
bsalomon
776d355147 Make null gpu context threadsafe(r) and make sure buffer objects are destroyed.
NOTREECHECKS=true
R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/470993002
2014-08-14 08:13:27 -07:00
epoger
b492c6ff30 add --descriptions flag to render_pictures tool
Needed because right now, when you look at the full set of SKP results in
rebaseline_server, you can't tell which renderMode (or builder) generated each
one.

BUG=skia:2833
R=borenet@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/466153006
2014-08-14 07:32:50 -07:00
krajcevski
e1c78ae553 Rebaseline R11 and ASTC bitmap GMs
TBR=robertphillips@google.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/471723002
2014-08-14 07:24:53 -07:00
epoger
5c4b137592 rebaseline_server: include setA/setB descriptions in output JSON
This is needed for rebaselining using the shared rebaseline_server instance:
by telling the client which git revision was used to fetch expectations, we
allow the client to pass that back along with new baselines (so the server
knows which revision to patch).

This is also handy in that it allows the server to tell the client more about the
different result sets (which files they were generated from).

BUG=skia:1918
NOTRY=true
R=rmistry@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/474813002
2014-08-14 07:12:46 -07:00
djsollen
3b6255493e Remove SkPaintOptionsAndroid
Committed: https://skia.googlesource.com/skia/+/f32331ffdb5de0440bb337aa7cbdd6f33e9ff23b

R=reed@google.com, mtklein@google.com, tomhudson@google.com

Author: djsollen@google.com

Review URL: https://codereview.chromium.org/447873003
2014-08-14 06:29:03 -07:00
epoger
30e26cdb41 rebaseline_server UI: add link to raw JSON
patchset 3 from https://codereview.chromium.org/467843002

NOTREECHECKS=true
NOTRY=true
R=stephana@google.com
TBR=stephana

Author: epoger@google.com

Review URL: https://codereview.chromium.org/475623002
2014-08-13 19:29:49 -07:00
epoger
4c808253f4 rebaseline_server: move more code into common path for GET_live_results and GET_prefetch_results
patchset 1 from issue 467843002

BUG=skia:1918
NOTREECHECKS=true
NOTRY=true
R=stephana@google.com
TBR=stephana

Author: epoger@google.com

Review URL: https://codereview.chromium.org/465143004
2014-08-13 19:23:33 -07:00
stephana
e8d74d988a This is a bit of a hack, but will work. I have a cleaner fix ready (but still need to fix some broken tests).
BUG=skia:
NOTRY=true
R=epoger@google.com

Author: stephana@google.com

Review URL: https://codereview.chromium.org/472703002
2014-08-13 19:12:59 -07:00
Brian Salomon
81ecaa2e4c Fix typo in ignored-tests.txt
BUG=skia:

Review URL: https://codereview.chromium.org/475583002
2014-08-13 18:31:03 -04:00
bsalomon
c15e28a522 Revert of Remove SkPaintOptionsAndroid (patchset #5 of https://codereview.chromium.org/447873003/)
Reason for revert:
Breaks the Chromium build: http://108.170.220.120:10117/builders/Canary-Chrome-Ubuntu13.10-Ninja-x86_64-DRT/builds/2469/steps/BuildContentShell_1/logs/stdio

Original issue's description:
> Remove SkPaintOptionsAndroid
>
> Committed: https://skia.googlesource.com/skia/+/f32331ffdb5de0440bb337aa7cbdd6f33e9ff23b

R=reed@google.com, mtklein@google.com, tomhudson@google.com, djsollen@google.com
TBR=djsollen@google.com, mtklein@google.com, reed@google.com, tomhudson@google.com
NOTREECHECKS=true
NOTRY=true

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/473543004
2014-08-13 15:18:46 -07:00
mtklein
6cfa73a29a Start tracking the CTM while filling the BBH in SkRecordDraw.
Depends on https://codereview.chromium.org/475473002/

BUG=skia:
R=robertphillips@google.com, reed@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/468193003
2014-08-13 13:33:49 -07:00
djsollen
f32331ffdb Remove SkPaintOptionsAndroid
R=reed@google.com, mtklein@google.com, tomhudson@google.com

Author: djsollen@google.com

Review URL: https://codereview.chromium.org/447873003
2014-08-13 13:09:49 -07:00
mtklein
828ce1f34b Start filling BBH in SkRecordDraw.
This starts with a skeleton of how to calculate bounds for ops which don't have
their own bounds.  For any given Save/Restore block, we'll find the union of the
bounds of all the draws inside it (including other Save/Restore blocks), then say
those are the bounds of all non-draws in the block, including the Save and Restore.

To implement this, we keep a stack of active Save blocks.  Any time we hit a
non-drawing op ("control"), we'll add it to that Save block (implemented with a
separate stack of indices and a count of control ops in the entry on the Save
stack).  Save and SaveLayer push onto the stack, and Restore pops the stack, at
which point we can fill in the bounds for all the control ops in the block.

BUG=skia:
R=robertphillips@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/475473002
2014-08-13 12:58:45 -07:00
epoger
536e9539b4 roll common deps
NOTRY=true
R=borenet@google.com
TBR=borenet

Author: epoger@google.com

Review URL: https://codereview.chromium.org/469043003
2014-08-13 12:51:57 -07:00
krajcevski
12b3544028 Add runtime flag to turn compressed alpha masks on
R=bsalomon@google.com, robertphillips@google.com, mtklein@google.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/468293002
2014-08-13 12:06:26 -07:00
mtklein
3140576f2f Baseline Android-Reference-Unknown-Arm64
BUG=skia:
R=mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/474563002
2014-08-13 11:59:53 -07:00
tomhudson
7a4747f4f6 Update path to Android font config file
In version LMP, Android is expected to change the path to their font
configuration file (and condense several files into one), as well as
changing the format (qv http://crrev.com/446473003/). This patch tries
the new path before falling back to the old path.

The new fonts are incompatible with assumptions made by the old
SkFontConfigInterfaceAndroid, so this patch MUST NOT land until
https://crrev.com/462073002/ or the equivalent has turned on the
new SkFontManager.

BUG=chromium:400801
R=djsollen@google.com, bungeman@google.com, tomhudson@google.com

Committed: https://skia.googlesource.com/skia/+/94fa4b99e2a53e997a90c7808cc5263f1bf40c9f

Author: tomhudson@chromium.org

Review URL: https://codereview.chromium.org/458543002
2014-08-13 11:06:43 -07:00
krajcevski
69a5560ea5 Add entry point for passing options to the GrContextFactory
R=bsalomon@google.com, mtklein@google.com, robertphillips@google.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/465073002
2014-08-13 10:46:31 -07:00
robertphillips
b3f319fbb0 Add support for new drawPicture entry point to debugger
R=fmalita@google.com, fmalita@chromium.org

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/464063003
2014-08-13 10:46:24 -07:00
tomhudson
c773390eef Delete the old font management implementation based on SkFontConfigInterface, now that SkFontMgr_Android is live.
BUG=chromium:400801
R=djsollen@google.com, bungeman@google.com

Author: tomhudson@chromium.org

Review URL: https://codereview.chromium.org/445143002
2014-08-13 10:41:25 -07:00
mtklein
e556be7084 Don't leak the shader in PatchBench.
BUG=skia:
R=dandov@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/465083003
2014-08-13 10:41:16 -07:00
Brian Salomon
f411ee7178 git cl land# Enter a description of the change.
Even more tests to ignored-tests for gpu rect changes

BUG=skia:

Review URL: https://codereview.chromium.org/468223003
2014-08-13 13:37:45 -04:00
krajcevski
71614ac7c6 Add override to force bitmap rendering
R=robertphillips@google.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/462203002
2014-08-13 10:36:18 -07:00
stephana
21b342d19c This eliminates the need to copy the generated images from a temporary directory to the directory that is served by the rebaseline_server.
BUG=skia:2815, skia:2818
R=epoger@google.com

Author: stephana@google.com

Review URL: https://codereview.chromium.org/457203003
2014-08-13 10:36:06 -07:00
joshualitt
97a0d43771 Updating expectations for matrix convolution
R=bsalomon@chromium.org
BUG=skia:

Author: joshualitt@chromium.org

Review URL: https://codereview.chromium.org/464913003
2014-08-13 10:31:04 -07:00
halcanary
59598b0a9b DM: Replace --pathOpsVerbose with --veryVerbose
R=caryclark@google.com, mtklein@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/468963002
2014-08-13 10:30:57 -07:00
epoger
fb261109ec rebaseline_server: add some live-view.html links to index.html
NOTREECHECKS=true
NOTRY=true
R=stephana@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/463213002
2014-08-13 09:38:22 -07:00
epoger
785246ee38 add expectations for Test-Android-Reference-Unknown-Arm64-{Debug,Release}
BUG=skia:2828
NOTREECHECKS=true
NOTRY=true
R=mtklein@google.com
TBR=mtklein

Author: epoger@google.com

Review URL: https://codereview.chromium.org/468243002
2014-08-13 09:36:46 -07:00
halcanary
2512372b68 fix win compiler div/zero
R=bsalomon@google.com
TBR=bsalomon@google.com
NOTREECHECKS=true
NOTRY=true

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/474433002
2014-08-13 09:20:08 -07:00
Brian Salomon
a9424995ac Add additional tests to ignored-tests
BUG=skia:

Review URL: https://codereview.chromium.org/463993003
2014-08-13 12:08:01 -04:00
halcanary
fbd3576a18 Flate Test tests if compression works
-   Produce a compressable stream.
-   Assert compression ratio > 1
-   In verbose mode, print compression ratio.

R=mtklein@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/464373002
2014-08-13 08:07:38 -07:00
tomhudson
2ed49a492b Mark fallback fonts in new Android font config parser
The new Android fonts.xml format doesn't explicitly tag fallback
fonts, or separate them from system fonts by putting them in a
separate file. We're assuming that any nameless font is a fallback
font.

Adds a unit test to track that we see as many fallback fonts as
expected when parsing a file.

BUG=chromium:400801
R=bungeman@google.com, djsollen@google.com, tomhudson@google.com

Author: tomhudson@chromium.org

Review URL: https://codereview.chromium.org/468893002
2014-08-13 07:53:49 -07:00
bsalomon
c30aaa0e40 Use combined color/coverage attribute when possible in aa rect renderer.
Also restore the is_irect test to detect AA rects that are integer aligned.

R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/466873002
2014-08-13 07:15:30 -07:00
halcanary
bc677c8015 Fix Flate Test, also cleanup
-   Remove SkData double-unref to fix assert.
-   Re-enable the test with DEBUG (was disabled due to double-unref assert).
-   SkRandom instead of rand() for thread-safety.
-   General clean up of the test for readability.

Motivation: I am investigating turning on SkFlate::HaveFlate on Windows.

R=mtklein@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/464333002
2014-08-13 07:14:36 -07:00
rmistry
25f8538492 Add stephana@ to the list of Skia CQ commiters.
Note: This will take effect only after the Skia CQ is restarted

NOTRY=True
(SkipBuildbotRuns)

R=epoger@google.com

Author: rmistry@google.com

Review URL: https://codereview.chromium.org/469753002
2014-08-13 06:11:09 -07:00
rmistry
b2721f7372 Whitespace change to test the CQ commit message
(SkipBuildbotRuns)
TBR=
BUG=chromium:308792
NOTRY=true

Author: rmistry@google.com

Review URL: https://codereview.chromium.org/470603002
2014-08-13 05:36:43 -07:00
george
b62508be81 Add a parameter GR_ALWAYS_ALLOCATE_ON_HEAP to allow for only ever creating temporary buffers on the heap instead of allowing stack allocation
Unfortunately this can't be a GR_GL_* config like we'd discussed because there are SkAutoSMalloc buffers that are built outside of gl/

R=bsalomon@google.com, bsalomon
BUG=skia:

Author: george@mozilla.com

Review URL: https://codereview.chromium.org/459263003
2014-08-12 18:00:47 -07:00
dandov
cc03adb909 Proposal for the mesh gradient interface. Implemented as a grid of
patches and uses 4 private arrays to store the values of the control points and
colors. When it needs a patch at a certain position of the grid it just
builds it using the corresponding values of the array and the
grid coordinates provided. Details on implementation are documented in the corresponding classes' comments.

Also added a gm for mesh gradients.

BUG=skia:
R=egdaniel@google.com, reed@google.com

Author: dandov@google.com

Review URL: https://codereview.chromium.org/451723003
2014-08-12 17:14:57 -07:00
borenet
dc065f2c20 whitespace
BUG=skia:
TBR=bungeman

Author: borenet@google.com

Review URL: https://codereview.chromium.org/461123002
2014-08-12 13:02:26 -07:00
krajcevski
d211c547cb Turn off pedantic blit rect
R=robertphillips@google.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/460253003
2014-08-12 12:48:18 -07:00
fmalita
9f49cfdbf6 Add missing DRAW_PICTURE_MATRIX_PAINT paint offset.
Also remove explicit gPaintOffsets sizing to make the existing compile
time size check effective.

R=reed@google.com, robertphillips@google.com

Author: fmalita@chromium.org

Review URL: https://codereview.chromium.org/467683003
2014-08-12 12:24:18 -07:00
tomhudson
94fa4b99e2 Update path to Android font config file
In version LMP, Android is expected to change the path to their font
configuration file (and condense several files into one), as well as
changing the format (qv http://crrev.com/446473003/). This patch tries
the new path before falling back to the old path.

The new fonts are incompatible with assumptions made by the old
SkFontConfigInterfaceAndroid, so this patch MUST NOT land until
https://crrev.com/462073002/ or the equivalent has turned on the
new SkFontManager.

BUG=chromium:400801
R=djsollen@google.com, bungeman@google.com, tomhudson@google.com

Author: tomhudson@chromium.org

Review URL: https://codereview.chromium.org/458543002
2014-08-12 11:05:29 -07:00
tomhudson
8e69676bf5 Turn on FontMgr for Android
Minimal change for activating the SkFontMgr on Android, broken out
of http://crrev.com/445143002/.

BUG=chromium:400801
R=bungeman@google.com, djsollen@google.com, tomhudson@google.com

Author: tomhudson@chromium.org

Review URL: https://codereview.chromium.org/462073002
2014-08-12 10:55:09 -07:00
robertphillips
e94707505e Update tools for use of picture stats in GPU optimization decision
R=bsalomon@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/466733004
2014-08-12 10:12:40 -07:00