Commit Graph

35465 Commits

Author SHA1 Message Date
angle-skia-autoroll
37b7e47145 Roll third_party/externals/angle2 0265e1ec1eb7..82af620e0559 (6 commits)
0265e1ec1e..82af620e05


git log 0265e1ec1eb7..82af620e0559 --date=short --no-merges --format='%ad %ae %s'
2018-06-27 jie.a.chen@intel.com ParallelCompile: Add entry points.
2018-06-26 ynovikov@chromium.org Skip ClearTest.ChangeFramebufferAttachmentFromRGBAtoRGB on Mac
2018-06-26 geofflang@chromium.org GL: Don't print driver performance warnings.
2018-06-26 ynovikov@chromium.org Skip MaxTextureSizeTest.SpecificationTexImage on Win Intel Vulkan
2018-06-26 geofflang@chromium.org Revert "RendererGL: Limit warning output to 5 per message type."
2018-06-26 fjhenigman@chromium.org Vulkan: add SCALED vertex formats to table.


Created with:
  gclient setdep -r third_party/externals/angle2@82af620e0559

The AutoRoll server is located here: https://angle-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=jcgregorio@google.com

Change-Id: Ie343782b52e43a2bbccb4d0838022cbebb066ce3
Reviewed-on: https://skia-review.googlesource.com/137840
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-06-27 06:22:45 +00:00
skia-bookmaker
4ab7198c3a Update markdown files
Automatic commit by the Housekeeper-Nightly-Bookmaker bot.

TBR=rmistry@google.com
NO_MERGE_BUILDS

Change-Id: Id2185b2901cf3865d620e7b15d0f0dd618c3ccc9
Reviewed-on: https://skia-review.googlesource.com/137822
Commit-Queue: <skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com>
Reviewed-by: <skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com>
2018-06-27 06:05:45 +00:00
Khushal
c421ca1d6e gpu: Expose GrContextPriv::abandoned in the public API.
TBR=bsalomon@google.com

Bug: 854416
Change-Id: Iab71ca6e4724a925b0b9791267aac5ddc34f5b15
Reviewed-on: https://skia-review.googlesource.com/137692
Reviewed-by: Khusal Sagar <khushalsagar@chromium.org>
Commit-Queue: Khusal Sagar <khushalsagar@chromium.org>
2018-06-27 01:08:45 +00:00
Chris Dalton
ef12509ff2 ccpr: Add a context option to disable ccpr
TBR=bsalomon@google.com

Bug: skia:856404
Change-Id: Icc6f3d1e7ef97f1853427a3b1cdd405961e6ac26
Reviewed-on: https://skia-review.googlesource.com/137763
Reviewed-by: Chris Dalton <csmartdalton@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2018-06-27 00:48:15 +00:00
recipe-roller
9f0c0ade6a Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/a991ac69eb052dfbd460459203d4946168622385 gn: Look in src for gn binaries before trying old buildtools location (scottmg@chromium.org)
recipe_engine:
  https://crrev.com/b1546529ec629fa8ddf804916c94b6e06c44d693 Add simple `archive` module for tar + zip. (iannucci@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Iade897d995624050961ce1a204cc11aa5808b6ac
Reviewed-on: https://skia-review.googlesource.com/137800
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-06-26 23:52:45 +00:00
angle-skia-autoroll
5b201e3b0b Roll third_party/externals/angle2 5bdf8bd1cf56..0265e1ec1eb7 (26 commits)
5bdf8bd1cf..0265e1ec1e


git log 5bdf8bd1cf56..0265e1ec1eb7 --date=short --no-merges --format='%ad %ae %s'
2018-06-26 lucferron@chromium.org Ozone: Skip test failing just on GLES
2018-06-26 jmadill@chromium.org Vulkan: Fix unused sampler struct uniforms.
2018-06-26 jmadill@chromium.org Program: Sampler uniform query in front-end.
2018-06-26 fjhenigman@chromium.org Vulkan: enable some vertex data tests.
2018-06-26 tobine@google.com Move PlatformMethods constructor to header
2018-06-26 jmadill@chromium.org Vulkan: Remove expectations for passing/missing tests.
2018-06-26 jmadill@chromium.org Add kEmptyImmutableString.
2018-06-26 lucferron@chromium.org Vulkan: Edge case test and fix for alpha channel masks
2018-06-26 lucferron@chromium.org Context init should set DIRTY_BIT_DRAW_FRAMEBUFFER_BINDING
2018-06-26 geofflang@chromium.org Partially revert "WGL: Support unvirtualized contexts and unsafe multithreading."
2018-06-26 jmadill@chromium.org Vulkan: Implement nested sampler structs.
2018-06-26 jmadill@chromium.org Vulkan: Sampler structs in arrays.
2018-06-26 ianelliott@google.com Initial Android implementation of GetSystemInfo
2018-06-26 geofflang@chromium.org RendererGL: Limit warning output to 5 per message type.
2018-06-25 jiawei.shao@intel.com ES31: Support compute shader shared variables in HLSL
2018-06-22 ynovikov@chromium.org Remove FormatString for real
2018-06-22 lucferron@chromium.org Vulkan: Add drawQuad to a sampler test
2018-06-22 lucferron@chromium.org Vulkan: Cleanup InstancingTest logic and enable tests for Vulkan
2018-06-22 geofflang@chromium.org Temporarily skip MakeCurrentMultiContext test on Windows AMD OpenGL.
2018-06-22 jmadill@chromium.org Vulkan: Add RenderTargetVk::getImageForRead.
2018-06-22 jie.a.chen@intel.com ParallelCompile: Update gl.xml
2018-06-22 jmadill@chromium.org Vulkan: Fix mixed descriptor pool updates.
2018-06-22 jmadill@chromium.org Vulkan: Fix releasing Programs that are in use.
2018-06-22 jmadill@chromium.org Vulkan: Refactor DynamicDescriptorPool.
2018-06-21 geofflang@chromium.org Pass all context creation parameters to DisplayImpl::createContext.
2018-06-21 geofflang@chromium.org WGL: Support unvirtualized contexts and unsafe multithreading.


Created with:
  gclient setdep -r third_party/externals/angle2@0265e1ec1eb7

The AutoRoll server is located here: https://angle-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=jcgregorio@google.com

Change-Id: Ibf3d252a7cd83d565d061130713e2dbfed452f82
Reviewed-on: https://skia-review.googlesource.com/137741
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-06-26 21:25:44 +00:00
swiftshader-skia-autoroll
156b3ca5fd Roll third_party/externals/swiftshader 41b7748432ef..659d89e94bf9 (2 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/41b7748432ef..659d89e94bf9


git log 41b7748432ef..659d89e94bf9 --date=short --no-merges --format='%ad %ae %s'
2018-06-26 capn@google.com Support glCopyTexImage2D for float formats.
2018-06-26 capn@google.com Always create an OpenGL ES 3.0 context.


Created with:
  gclient setdep -r third_party/externals/swiftshader@659d89e94bf9

The AutoRoll server is located here: https://swiftshader-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=jcgregorio@google.com

Change-Id: I3d5cd1f5cd611679d6740dfa293cfc9653a8ed01
Reviewed-on: https://skia-review.googlesource.com/137740
Reviewed-by: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-06-26 21:24:25 +00:00
recipe-roller
41c5066fc0 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/83a57e01cd02356704fb43f08cc4fa49060795df [cipd] Bump cipd and vpython 550cea2b9a -> aacec5af4d. (vadimsh@chromium.org)
  https://crrev.com/7ccf2f0c21b30b88a462108ee2e39ed7d55b2f2f gclient: Report what dependencies were not processed. (ehmaldonado@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Icbd1b1ac621c1ec6419697e9c6b8e2edc812c189
Reviewed-on: https://skia-review.googlesource.com/137708
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
2018-06-26 21:16:45 +00:00
Ben Wagner
4f0a011bd6 Improve CMakeLists.txt auto regeneration.
Check that the re-generation could actually run ninja.

Specify the gn_deps by absolute path names.

Depend on the gn_to_cmake.py generator.

Change-Id: I5f93031d35f0b239b899fe1716fb1f6a4c67f77e
Reviewed-on: https://skia-review.googlesource.com/137397
Commit-Queue: Ben Wagner <bungeman@google.com>
Reviewed-by: Herb Derby <herb@google.com>
2018-06-26 20:33:29 +00:00
Jim Van Verth
3645bb069d Fix some shadow issues.
* Clamp path polygon points to nearest 1/16th of a pixel to help
  with floating point issues.
* Added check for multiple contour paths.
* Return empty SkVertices for certain degenerate cases to avoid
  unnecessary blurs.
* Check iteration count in SkOffsetPolygon to avoid infinite loops.
* Add new tests to verify these.

Bug: skia:
Change-Id: Ie6ad48d2504e065dcc822609d369f90c56ef3ad3
Reviewed-on: https://skia-review.googlesource.com/136701
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
2018-06-26 20:28:55 +00:00
Ben Wagner
9396bc3fc6 [Bazel] Omit new test that causes infinite loop in libjpeg-turbo.
This test was added in
https://skia-review.googlesource.com/c/skia/+/129459, but the fix is not
yet in a libjpeg-turbo release.

No-Try: true
Change-Id: Ib7dce7a022934918f9f2e3467849d3e81cbf14cd
Reviewed-on: https://skia-review.googlesource.com/137703
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Leon Scroggins <scroggo@google.com>
Commit-Queue: Leon Scroggins <scroggo@google.com>
2018-06-26 20:15:12 +00:00
Brian Osman
d47fe095cf Handle F32 in lazy image
Bug: skia:
Change-Id: Idec8259b48733830790a3957b41d204835d7be02
Reviewed-on: https://skia-review.googlesource.com/137705
Auto-Submit: Brian Osman <brianosman@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2018-06-26 19:39:05 +00:00
Brian Osman
d5161b9a62 Reland "Revert "Update GPU DM/nanobench configs for color testing""
This reverts commit c0fb3c8b9f.

Reason for revert: Had to revert dependent CL.
Original change's description:
> Revert "Revert "Update GPU DM/nanobench configs for color testing""
> 
> This reverts commit 2a284de7a5.
> 
> Re-landing without esrgb configs. Going to enable those separately,
> as they require some blacklisting.
> 
> Bug: skia:
> Change-Id: I2315849d4f5c45c2e5512f84f9f867d02ff6fe30
> Reviewed-on: https://skia-review.googlesource.com/136589
> Reviewed-by: Brian Osman <brianosman@google.com>
> Commit-Queue: Brian Osman <brianosman@google.com>

TBR=mtklein@google.com,bsalomon@google.com,brianosman@google.com

Change-Id: I942d4235c17100fd933bf9cbfe923e3ae80657b1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/137721
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2018-06-26 19:20:53 +00:00
Brian Osman
e269310a09 Revert "Temporary fix for SkImage_Lazy handling of color spaces"
This reverts commit 439b994514.

Reason for revert: Chrome tests failing.

Original change's description:
> Temporary fix for SkImage_Lazy handling of color spaces
> 
> The aim is to always decode in the generator's color space,
> with nonlinear blending. Eventually, we want to decode into
> the destination color space, but that requires changing API
> and caching flow. For now, this prevents linear premul when
> decoding, and stops decoding to formats like F16 and sBGRA.
> 
> Bug: skia:
> Change-Id: I9efd909fa6a56df2547ad5955f109e113527f815
> Reviewed-on: https://skia-review.googlesource.com/136791
> Commit-Queue: Mike Klein <mtklein@google.com>
> Reviewed-by: Mike Klein <mtklein@google.com>

TBR=mtklein@google.com,brianosman@google.com

Change-Id: Ie15c585b69e4309c090c8aafbe3c2d20191caa4d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/137720
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2018-06-26 19:19:53 +00:00
Ben Wagner
3627d2ebbb Add subpixel offset to Viewer app.
This adds a two dimensional location dragger to drag the origin across a
pixel. Also makes the perspective dragger hidden when perspective is
off. Also adds 'Z' to toggle the zoom window mouse follow.

Change-Id: Ic75d16c95848b392608770c8ed0d4db23733242f
Reviewed-on: https://skia-review.googlesource.com/137701
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2018-06-26 19:14:43 +00:00
Mike Klein
3785471ff6 basic first pass at RGBA F32 support
Draws basically the same as f16.

The existing load_f32, load_f32_dst, and store_f32 stages all had the
same bug that we'd never noticed because dy was always 0 until now.

Change-Id: Ibbd393fa1acc5df414be4cdef0f5a9d11dcccdb3
Reviewed-on: https://skia-review.googlesource.com/137585
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Brian Osman <brianosman@google.com>
Reviewed-by: Mike Reed <reed@google.com>
2018-06-26 19:02:52 +00:00
Robert Phillips
9b6125d046 Disable --gpuThreads when skpbenching DDLs
This CL requires https://skia-review.googlesource.com/c/skia/+/136175 (Add --gpuThreads support to skpbench.py (take 2))

Change-Id: Iced00d6b6184ec41efe66a71a5b4e062ce7205ee
Reviewed-on: https://skia-review.googlesource.com/136596
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2018-06-26 18:33:42 +00:00
Greg Daniel
001c67fde1 Remove Vulkan code that supported creating a GrVkRenderTarget.
We never create a pure RenderTarget. If we are creating a RT it is always
a TexRT. The only pure RTs are wrapped.

Bug: skia:
Change-Id: If95d17d244e78c986ed6c63822d4b936ff67b88a
Reviewed-on: https://skia-review.googlesource.com/137700
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2018-06-26 18:22:22 +00:00
Chris Dalton
a4f5ce0c98 skpbench: Support .svg files
Bug: skia:
Change-Id: I0337757f635c631870c02a65f8784fc190d1435e
Reviewed-on: https://skia-review.googlesource.com/137540
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2018-06-26 18:01:02 +00:00
Brian Osman
c0fb3c8b9f Revert "Revert "Update GPU DM/nanobench configs for color testing""
This reverts commit 2a284de7a5.

Re-landing without esrgb configs. Going to enable those separately,
as they require some blacklisting.

Bug: skia:
Change-Id: I2315849d4f5c45c2e5512f84f9f867d02ff6fe30
Reviewed-on: https://skia-review.googlesource.com/136589
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2018-06-26 17:51:22 +00:00
Greg Daniel
21580ba3ae Fix some static intializers in Vulkan code.
Bug: skia:
Change-Id: Ia5160376ff456874459430e51c2f57acdb1a4de1
Reviewed-on: https://skia-review.googlesource.com/137584
Reviewed-by: Brian Osman <brianosman@google.com>
Reviewed-by: Chris Blume <cblume@chromium.org>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2018-06-26 17:30:53 +00:00
Leon Scroggins III
a57488a1f5 Expose public factories for platform decoders
Bug: skia:8076

Move SkImageGeneratorCG and SkImageGeneratorWIC to include/ports/,
and make them SK_API.

Remove SkImageGeneratorCG::NewFromEncodedCG. No known clients are using
it, and it was a private API in src/. There is already a
MakeFromEncodedCG to replace it.

Similarly, switch WIC from New to Make.

Add a compile test for using them with
SetImageGeneratorFromEncodedDataFactory.

Change-Id: I897eb7a887b3736a6c614a68e38f38b6a1942cf1
Reviewed-on: https://skia-review.googlesource.com/137387
Reviewed-by: Mike Reed <reed@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Leon Scroggins <scroggo@google.com>
2018-06-26 17:30:52 +00:00
Ben Wagner
6a284b7716 Clean up includes in SkMallocPixelRef
Came across this unnecessary includes while experimenting with WASM

Change-Id: I68061c7bbd18ed5695b94b3b8de6dbb63407b8ee
Reviewed-on: https://skia-review.googlesource.com/137582
Reviewed-by: Mike Klein <mtklein@google.com>
2018-06-26 16:47:39 +00:00
Mike Klein
9c0ce41cf7 remove unused enum
Change-Id: I9e7be63fdab8b1e4bc3038d48664962deefb6749
Reviewed-on: https://skia-review.googlesource.com/137586
Commit-Queue: Mike Klein <mtklein@chromium.org>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Auto-Submit: Mike Klein <mtklein@chromium.org>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2018-06-26 16:32:52 +00:00
Brian Salomon
493489054f Refactor GrPipeline dynamic state.
Remove scissor rect from GrPipeline.

Draws can specify "fixed dynamic state" which doesn't use the dynamism at
all or can specify dynamic state arrays with an entry per GrMesh.

When we state other than scissor rects this will allow the caller to
use a mix of truly dynamic and fixed dynamic state. So a caller that
only has dynamic scissor rects doesn't need to store its remaining
unvarying state in an array.

Change-Id: I8fcc07eb600c72a26cc712b185755c2116021a8a
Reviewed-on: https://skia-review.googlesource.com/137223
Reviewed-by: Chris Dalton <csmartdalton@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2018-06-26 15:35:12 +00:00
Robert Phillips
d5506cb888 Add --gpuThreads support to skpbench.py (take 2)
Change-Id: Ie946ff339c4e04bb866545ad60c2ab77bae85417
Reviewed-on: https://skia-review.googlesource.com/136175
Reviewed-by: Chris Dalton <csmartdalton@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2018-06-26 15:28:12 +00:00
Leon Scroggins III
665949a3ec Update libjpeg-turbo to pre-2.0.0 (from 1.5.3)
jpeg_skip_scanlines was incorrectly incrementing an internal counter,
resulting in an infinite loop. (This only occurs for certain types of
progressive images, using certain sample sizes.)

The fix is at 26f109290d.
This is included in tip-of-tree, which is unofficially 2.0.0, so go ahead and
update to it.

Add a test based on the original bug.

Bug: b/78329453
Change-Id: I5ade9924812324d58668c26f71cd622ef93f40a7
Reviewed-on: https://skia-review.googlesource.com/129459
Commit-Queue: Leon Scroggins <scroggo@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2018-06-26 15:22:12 +00:00
Brian Osman
439b994514 Temporary fix for SkImage_Lazy handling of color spaces
The aim is to always decode in the generator's color space,
with nonlinear blending. Eventually, we want to decode into
the destination color space, but that requires changing API
and caching flow. For now, this prevents linear premul when
decoding, and stops decoding to formats like F16 and sBGRA.

Bug: skia:
Change-Id: I9efd909fa6a56df2547ad5955f109e113527f815
Reviewed-on: https://skia-review.googlesource.com/136791
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2018-06-26 15:20:42 +00:00
Mike Reed
538e1a10b7 move blurimagefilter.cpp back into effects
Bug: skia:
Change-Id: I5711a9a8fcd135344e75cb4b505bd06044414c85
Reviewed-on: https://skia-review.googlesource.com/137581
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2018-06-26 15:01:52 +00:00
Robert Phillips
c1b6066263 Fix instantiation of partially lazy proxies
Change-Id: I941333711966da109583a3a72ab3464363285b84
Reviewed-on: https://skia-review.googlesource.com/137580
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2018-06-26 14:48:12 +00:00
Greg Daniel
d4b2adeaa9 Move Vulkan DebugCallback code into tools.
Bug: skia:
Change-Id: Ib356200e86e54f9ff0ba16396874e6fd10cf0465
Reviewed-on: https://skia-review.googlesource.com/137424
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2018-06-26 13:16:32 +00:00
recipe-roller
f46710802a Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/a02505f564d2c8aa60e779669208af89affa58ec [cipd] Update cipd client and vpython 4d19637ec -> 550cea2b9. (vadimsh@chromium.org)
recipe_engine:
  https://crrev.com/359385a94a0912af40d41eccc3fc594e68ddb65e autoroller: Search for gitattributes files only in modified dirs. (ehmaldonado@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: If71d1013a19856503b813cbdfc6943a6e4afa917
Reviewed-on: https://skia-review.googlesource.com/137429
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-06-26 00:47:32 +00:00
recipe-roller
fcd480bcab Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/77094f7feabd1eb8a4ac2447e562628b453e2b77 Reland of "Wipe out shallow checkout support from bot_update." (tandrii@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I61cc272ec36c26fb3e73047d8157ffee706c3ee2
Reviewed-on: https://skia-review.googlesource.com/137427
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-06-25 23:12:32 +00:00
Herb Derby
372a44681e Fix compiler warning for MSVC
Change-Id: Id62e746732fd42bc17c02399529cbeb1d10e4476
Reviewed-on: https://skia-review.googlesource.com/137426
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2018-06-25 21:53:32 +00:00
Cary Clark
81abc43e6f explicitly include blurimagefilter include
Try explicitly adding
to fix the bookmaker nightly bot.

R=jcgregorio@google.com,caryclark@google.com

Docs-Preview: https://skia.org/?cl=137421
Bug: skia:6898
Change-Id: Iff27845e6872b885b8494e9fc236f4f05c10c301
Reviewed-on: https://skia-review.googlesource.com/137421
Reviewed-by: Cary Clark <caryclark@skia.org>
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Commit-Queue: Cary Clark <caryclark@skia.org>
Commit-Queue: Joe Gregorio <jcgregorio@google.com>
Auto-Submit: Cary Clark <caryclark@skia.org>
2018-06-25 20:53:25 +00:00
Bruce Wang
536ad2c146 Implement onMakeClone function on all subclasses of SkTypeface except
on mac.

Change-Id: I2b8777a5b54e190c37623ab798a89b4f1833ceac
Reviewed-on: https://skia-review.googlesource.com/137382
Commit-Queue: Bruce Wang <brucewang@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
2018-06-25 20:42:25 +00:00
Brian Salomon
ff168d9258 Put GrPrimitiveProcessor/GrGeometryProcessor before GrPipeline in param lists.
We were inconsistent about which order these were in. Having the processor first
will make the parameter order more logical for an upcoming change. Also, the primitive
processor comes logically before the pipeline.

Change-Id: I3968c5e4e6dff01f9c4ad311eb1795b3c7580ff5
Reviewed-on: https://skia-review.googlesource.com/137228
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2018-06-25 17:55:45 +00:00
Adrienne Walker
721e63727f Validate transformed SkPaintImageFilter rects
These can be transformed into invalid rects, so don't try to draw them.

Bug: chromium: 852048
Change-Id: I95a8b86557e550453efb0896f6d559a843f47d2a
Reviewed-on: https://skia-review.googlesource.com/135924
Commit-Queue: Adrienne Walker <enne@chromium.org>
Reviewed-by: Mike Klein <mtklein@google.com>
2018-06-25 17:52:55 +00:00
Heather Miller
73aaf259d3 update externally published milestone schedule
No-Try: true
Docs-Preview: https://skia.org/?cl=137388
Bug: skia:
Change-Id: I83e4da9722991d64190b5e6b73b87a8f9791d629
Reviewed-on: https://skia-review.googlesource.com/137388
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Commit-Queue: Heather Miller <hcm@google.com>
2018-06-25 17:09:45 +00:00
Mike Reed
bdf985c761 remove bad assert
Bug: 855854
Change-Id: Ifad8fd1f89000b206de39ef261a99292ee63b7a1
Reviewed-on: https://skia-review.googlesource.com/137383
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2018-06-25 16:17:15 +00:00
Herb Derby
ed55419d85 Use indices into the vectors shared by runs
With multiple runs, the shared vectors were moving out from
under the pointers in earlier runs.

Change-Id: I486d2e603e18ea7effc0dbdbc7c5d3c545278703
Reviewed-on: https://skia-review.googlesource.com/137222
Commit-Queue: Herb Derby <herb@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
2018-06-25 16:05:25 +00:00
Cary Clark
86d87d2e69 fix path measure fuzzes
these fixes suppress debug asserts
when the fuzzer is run

R=reed@google.com,kjlubick@google.com

Bug: skia:
Change-Id: I7b8c16fe475056213314ecb588a4368b547836b0
Reviewed-on: https://skia-review.googlesource.com/137363
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Cary Clark <caryclark@skia.org>
2018-06-25 14:41:25 +00:00
Bruce Wang
0ea256c4db Implement onMakeClone(const SkFontArguments& args) in classes: SkTypeface_Empty, SkTypeface_Stream, SkTypeface_File
Change-Id: I534cfc3439601f682d6b5a2fa023aef6b04d1653
Reviewed-on: https://skia-review.googlesource.com/137192
Commit-Queue: Ben Wagner <bungeman@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
2018-06-25 14:40:45 +00:00
Robert Phillips
6d36370c06 Add bullet proofing for preAbandonContext
With the more agressive abandonment of the GrContext state in https://skia-review.googlesource.com/c/skia/+/137121 (Fix abandonment of programs) (i.e., nulling out of the interface) it is necessary to add more guards so that we don't try calling GL methods when the context has been abandoned.

Change-Id: Ib2a3c17b9eaebd1eb84eb82a2781cf9d5a6a34a3
Reviewed-on: https://skia-review.googlesource.com/137362
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2018-06-25 13:52:55 +00:00
Greg Daniel
93ae233773 Make GrVkBackendContext no longer derive from SkRefCnt.
Also moves the helper Create functions to VkTestUtils since no clients
are using them anymore.

Bug: skia:
Change-Id: I7e8e4912e7ef6fb00a7e2a00407aed5e83211799
Reviewed-on: https://skia-review.googlesource.com/135323
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2018-06-25 13:37:45 +00:00
Cary Clark
c050a1a185 fix pathop fuzz timeout
R=caryclark@google.com

Bug:855751
Change-Id: Ieb6bae50311f62c9b03b84b2cf84f09ad2db2e46
Reviewed-on: https://skia-review.googlesource.com/137361
Reviewed-by: Cary Clark <caryclark@skia.org>
Commit-Queue: Cary Clark <caryclark@skia.org>
Auto-Submit: Cary Clark <caryclark@skia.org>
2018-06-25 13:10:45 +00:00
Chris Dalton
c4e72a4d5a ccpr: Blacklist PowerVR Rogue in GL
Bug: skia:
Change-Id: Icba3de2eabc24840ae6917e0eeaa279788397653
Reviewed-on: https://skia-review.googlesource.com/137341
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2018-06-25 13:06:46 +00:00
Robert Phillips
752e08b1ae Fix abandonment of programs
Bug: skia:8092
TBR=bsalomon@google.com
Change-Id: If9cf4ed9f8ded4b7fbb58a244ec0b179b8430ca2
Reviewed-on: https://skia-review.googlesource.com/137121
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2018-06-25 12:09:55 +00:00
Ben Wagner
900b5364d1 Fix SkPaint::getTypeface() documentation.
SkPaint::getTypeface() allows the caller to borrow a pointer to its
SkTypeface, it does not affect ownership. The existing documentation would
lead a user to beleive that getTypeface() increments the reference count,
but it does not.

TBR=reed@google.com
Change-Id: Ic1a660b026e3c4295f9f0de28abfde29c3f05524
Reviewed-on: https://skia-review.googlesource.com/137183
Reviewed-by: Cary Clark <caryclark@google.com>
Commit-Queue: Cary Clark <caryclark@google.com>
2018-06-25 11:32:25 +00:00
Chris Dalton
a2b5b6467f ccpr: Enable ccpr by default
Now that the path cache is implemented, we can use ccpr everywhere.

Modifies ccpr to not cache unless the "fAllowPathMaskCaching" context
option is enabled.

Adds a small condition to skip complicated paths with more vertices
than pixels, simply so we don't regress a couple testcases.

Updates skpbench to do three draws before starting the timer, in order
to prime the cache.

Bug: skia:
Change-Id: Ic3a0a2bdad8a22ff6431e77fa4da2b54d6bb9aba
Reviewed-on: https://skia-review.googlesource.com/137207
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2018-06-25 01:47:14 +00:00