Bug: skia:7322
Change-Id: I2b50478e85c42beacbe67a8c7eaf46a487cf6f86
Reviewed-on: https://skia-review.googlesource.com/c/172973
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
This reverts commit 6bee47b860.
Reason for revert: needs a Google3 guard.
Original change's description:
> move decal_filter_scale inline, walk decal in 32.32
>
> Walking soemtimes in 32.32 and sometimes in 16.16 is leading to small
> diffs in https://chromium-review.googlesource.com/c/chromium/src/+/1346729.
>
> I think by walking either consistently will help avoid the problems.
> Might as well walk 32.32.
>
> Cq-Include-Trybots: luci.chromium.try:linux-blink-rel
> Change-Id: I4bbe8e10655a97367d3b59d203206bc2c2cf55e8
> Reviewed-on: https://skia-review.googlesource.com/c/172941
> Auto-Submit: Mike Klein <mtklein@google.com>
> Reviewed-by: Mike Klein <mtklein@google.com>
> Commit-Queue: Mike Klein <mtklein@google.com>
TBR=mtklein@google.com,fmalita@chromium.org,reed@google.com
Change-Id: I0e1c3eb1459dd5466c7220623ba3891ab64b9ea8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Cq-Include-Trybots: luci.chromium.try:linux-blink-rel
Reviewed-on: https://skia-review.googlesource.com/c/172943
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
This is a reland of b336c39e07 with fixes to resolve layout failures.
Original change's description:
> Optimize trivial per-edge aa rect tessellation
>
> Bug: skia:
> Change-Id: I380b443216b238e13bfff7ed13526dda1380ef99
> Reviewed-on: https://skia-review.googlesource.com/c/171723
> Reviewed-by: Brian Salomon <bsalomon@google.com>
> Commit-Queue: Michael Ludwig <michaelludwig@google.com>
Bug: skia:
Change-Id: Ica9a964dd9f1962ff7c0dc194675667692542112
Reviewed-on: https://skia-review.googlesource.com/c/172964
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
Walking soemtimes in 32.32 and sometimes in 16.16 is leading to small
diffs in https://chromium-review.googlesource.com/c/chromium/src/+/1346729.
I think by walking either consistently will help avoid the problems.
Might as well walk 32.32.
Cq-Include-Trybots: luci.chromium.try:linux-blink-rel
Change-Id: I4bbe8e10655a97367d3b59d203206bc2c2cf55e8
Reviewed-on: https://skia-review.googlesource.com/c/172941
Auto-Submit: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
5552cdf032..471b8d4c73
git log 5552cdf032dd..471b8d4c7383 --date=short --no-merges --format='%ad %ae %s'
2018-11-27 jdarpinian@chromium.org WebGL, D3D: Forbid multiple TF outputs in one buffer
Created with:
gclient setdep -r third_party/externals/angle2@471b8d4c7383
The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=borenet@google.com
Change-Id: I01b0deaba9afdeeb6fcad6f82b39952aef69da89
Reviewed-on: https://skia-review.googlesource.com/c/173004
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Some of this is left in for migrating callers (see docs)
- want getWidths to just take widths (and no paint)
- want getBounds to just take bounds AND paint
- want getWidthsBounds to take it all
Bug: skia:
Change-Id: I498cd8295b90995c45237d3cf39fc097252f485e
Reviewed-on: https://skia-review.googlesource.com/c/172868
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Mike Reed <reed@google.com>
573f76b3ee..5552cdf032
git log 573f76b3eebf..5552cdf032dd --date=short --no-merges --format='%ad %ae %s'
2018-11-26 syoussefi@chromium.org Vulkan: Create buffer view for BufferHelper
2018-11-26 geofflang@chromium.org Vulkan: Implement ANGLE_translated_shader_source
2018-11-26 syoussefi@chromium.org Vulkan: Implement vk::BufferView
2018-11-26 jmadill@chromium.org Update clang-format settings.
2018-11-26 geofflang@chromium.org GL: Work around Qualcomm sRGB ReadPixels driver bug.
2018-11-26 geofflang@chromium.org GL: Implement GL_NV_fence on top of GLsync objects.
2018-11-26 matavenrath@nvidia.com Don't generate TypeInfo objects as static objects within GetTypeInfo function
Created with:
gclient setdep -r third_party/externals/angle2@5552cdf032dd
The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=borenet@google.com
Change-Id: I9678a218ac0578e9eb5e791fa270b4bb1515b640
Reviewed-on: https://skia-review.googlesource.com/c/173001
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Copy pasta caused the requested weight to be used instead of the
requested width when calculating the correct width value to request from
CoreText.
Change-Id: I1dbc093fe9c6173f7d940ced5772c092a911d9bb
Reviewed-on: https://skia-review.googlesource.com/c/172961
Commit-Queue: Herb Derby <herb@google.com>
Auto-Submit: Ben Wagner <bungeman@google.com>
Reviewed-by: Herb Derby <herb@google.com>
Octagon vertices should bloat for AA in both axes. One of the lower
left vertices was not doing this.
Bug: skia:
Change-Id: Ie7aad285244529425eb9c3dca9ff1acbb2848218
Reviewed-on: https://skia-review.googlesource.com/c/172985
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Bug: skia:
Change-Id: I4bb5e0107d06798040a37609499b4e2b48cf7e29
Reviewed-on: https://skia-review.googlesource.com/c/172962
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Bug: skia:8563
Change-Id: I4421a19979a2a1ddae4ca52871c71e9d7d1220d8
Reviewed-on: https://skia-review.googlesource.com/c/172870
Commit-Queue: Brian Osman <brianosman@google.com>
Auto-Submit: Brian Salomon <bsalomon@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
We previously had a glFlush() workaround for instanced rendering on
Skylake. However, the non-instanced approach is often faster than
instanced + glFlush(). This CL just disables instanced rendering
altogether on Skylake instead. The chip is old enough now that this
seems like a reasonable solution.
Bug: skia:8566
Change-Id: Ib82a519d8186b463b72b20203fb69d078e757aa7
Reviewed-on: https://skia-review.googlesource.com/c/172470
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Bug: skia:
Change-Id: Ie37b3fd6c8682b2d778b1dd0bc38976e6761524e
Reviewed-on: https://skia-review.googlesource.com/c/172142
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
There are now three modes: Legacy, and Color Managed 8888 or F16. Rules
about transfer functions are gone, so allow changing gamma in either
color managed mode.
To keep things much simpler, we always construct the window surface in
legacy mode, and draw offscreen whenever we're doing any color
management. This lets us avoid re-creating the window surface when
cycling modes, and avoid making re-tagged copies when pushing color
managed images to the window surface.
Bug: skia:
Change-Id: I59e9340900b047d5217eb8a9f63f20a1d638227d
Reviewed-on: https://skia-review.googlesource.com/c/172960
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Bug: oss-fuzz:11546
Change-Id: Icb08cfeb685d3992d99df8f98336093a79295ed0
Reviewed-on: https://skia-review.googlesource.com/c/172869
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Bug: skia:8560
Change-Id: I9287d8286a49d067c14a4cc560220c08d3c0c040
Reviewed-on: https://skia-review.googlesource.com/c/172865
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
This reverts commit b336c39e07.
Reason for revert: Suspected of breaking Chrome roll
Original change's description:
> Optimize trivial per-edge aa rect tessellation
>
> Bug: skia:
> Change-Id: I380b443216b238e13bfff7ed13526dda1380ef99
> Reviewed-on: https://skia-review.googlesource.com/c/171723
> Reviewed-by: Brian Salomon <bsalomon@google.com>
> Commit-Queue: Michael Ludwig <michaelludwig@google.com>
TBR=bsalomon@google.com,brianosman@google.com,michaelludwig@google.com
Change-Id: I2b229efc78c2c091b2fa620e22fd5b260dcfc1d7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/c/172871
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
MaliT604 doesn't like them for some reason, and these values can be
deduced from the other attribs anyway.
Bug: skia:8561
Change-Id: I7bdd14d41f2d1323aec8fa5562f95d31d3c42e94
Reviewed-on: https://skia-review.googlesource.com/c/172472
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Bug: skia:7322
Change-Id: I337653006783910f806560a78018e4a291e2869d
Reviewed-on: https://skia-review.googlesource.com/c/172862
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
This re-works the subpath model and does transforming
of ports in JS rather than in C++; the latter was not easy
to conform to the Canvas Spec, especially for changing
transforms in the middle of a path.
Additionally adds jpeg to the available images it can produce.
Bug: skia:
Change-Id: I5a52ec341d4060198c8680aa4d3b85a26f77b6b9
Reviewed-on: https://skia-review.googlesource.com/c/172500
Reviewed-by: Kevin Lubick <kjlubick@google.com>
15992bef28..573f76b3ee
git log 15992bef28d8..573f76b3eebf --date=short --no-merges --format='%ad %ae %s'
2018-11-26 tobine@google.com Debug: Add Systrace Markers
Created with:
gclient setdep -r third_party/externals/angle2@573f76b3eebf
The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=borenet@google.com
Change-Id: Ib21ec4724bf00861b0a3933179160b37401a0096
Reviewed-on: https://skia-review.googlesource.com/c/172880
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
This fixes a crash in skiaserve when running in GPU mode.
Remove GR_AUDIT_TRAIL_OP_RESULT_NEW. This macro doesn't do anything and
is non-trivial to know when to call if a new op gets chained.
Change-Id: Ic2a9c09e3d15541a566534654b2393cb740fa302
Reviewed-on: https://skia-review.googlesource.com/c/172864
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
This was based on old ideas about color management. We have better
mechanisms for testing this now.
Bug: skia:
Change-Id: If59b5039f31ab0ebbdbed4205c941dd9266f67c1
Reviewed-on: https://skia-review.googlesource.com/c/172860
Commit-Queue: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Auto-Submit: Brian Osman <brianosman@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
This reverts commit 8b998b1e71.
Reason for revert: flag is now defined in google3
Original change's description:
> add SK_SUPPORT_LEGACY_TEXTBLOBBUILD_WITH_PAINT for google3
>
> Bug: skia:
> Change-Id: I3a7e3555718d5e585d5288b7a70a24ee39d0d327
> Reviewed-on: https://skia-review.googlesource.com/c/172740
> Reviewed-by: Mike Reed <reed@google.com>
TBR=reed@google.com
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: skia:
Change-Id: I27130d7c332f1a06f939280a1485a3b82dc13188
Reviewed-on: https://skia-review.googlesource.com/c/172861
Reviewed-by: Mike Reed <reed@google.com>
This should allow clients to include Skia and their vulkan files in any
order. However, it does require that when clients are building their
files that include skia with vulkan, they must have vulkan/vulkan_core.h
on their include path somewhere.
Bug: skia:
Change-Id: I969db396c92127be7c8df754926d175f38b8aafa
Reviewed-on: https://skia-review.googlesource.com/c/172147
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
More concise and (hopefully), makes the underlying logic easier to spot.
Bug: skia:
Change-Id: I8dbdcee7c761259dc586311b8c703e87555634cc
Reviewed-on: https://skia-review.googlesource.com/c/172502
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Bug: skia:
Change-Id: I380b443216b238e13bfff7ed13526dda1380ef99
Reviewed-on: https://skia-review.googlesource.com/c/171723
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
