Commit Graph

9043 Commits

Author SHA1 Message Date
scroggo@google.com
b5571b3324 Change SkImageDecoders to take an SkStreamRewindable.
Only affects factories, static functions that will use the factories,
and subset decoding, which all require rewinding. The decoders
themselves continue to take an SkStream. This is merely documentation
stating which functions will possibly rewind the passed in SkStream.

This is part of the general change to coordinate SkStreams with
Android's streams, which don't necessarily support rewinding in all
cases.

Update callers to use SkStreamRewindable.

BUG=skia:1572
R=bungeman@google.com, reed@google.com

Review URL: https://codereview.chromium.org/23477009

git-svn-id: http://skia.googlecode.com/svn/trunk@11460 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-25 21:34:24 +00:00
scroggo@google.com
228f2b8887 Print a better error message.
Use format_message to print the proper error message in JPEG decoder.

R=mtklein@google.com

Review URL: https://codereview.chromium.org/24461002

git-svn-id: http://skia.googlecode.com/svn/trunk@11459 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-25 21:27:31 +00:00
scroggo@google.com
a934899867 Use the default resync_to_restart in jpeg.
Our version requires rewinding the stream, which is not always
supported. Instead, depend on jpeg's default version.

R=djsollen@google.com

Review URL: https://codereview.chromium.org/23464068

git-svn-id: http://skia.googlecode.com/svn/trunk@11458 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-25 21:17:41 +00:00
commit-bot@chromium.org
4382330a15 Replace GR_*_BUILD by their SK_BUILD_FOR_* equivalents.
BUG=None
TEST=None, no functional changes.
R=bsalomon@google.com, robertphillips@google.com

Author: tfarina@chromium.org

Review URL: https://chromiumcodereview.appspot.com/24253009

git-svn-id: http://skia.googlecode.com/svn/trunk@11457 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-25 20:57:51 +00:00
bensong@google.com
7d9a21bb36 Deletes bench_expectations.txt and change comments to refer to the new per-bot expectation files.
Review URL: https://codereview.chromium.org/23830009

git-svn-id: http://skia.googlecode.com/svn/trunk@11456 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-25 20:51:16 +00:00
bungeman@google.com
b8d9d5bd29 Refactor PathTest.cpp test_isNestedRects and test_isRect.
The existing implementations make it difficult to add new tests
and rely on non-local side effects.

R=bsalomon@google.com

Review URL: https://codereview.chromium.org/24502004

git-svn-id: http://skia.googlecode.com/svn/trunk@11455 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-25 18:21:39 +00:00
rmistry@google.com
592c535c9e Whitespace change to trigger rebuilds.
git-svn-id: http://skia.googlecode.com/svn/trunk@11452 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-25 01:01:30 +00:00
djsollen@google.com
39a7c7035b Use different unique identifier for a fallback family.
BUG=chromium:266412
R=mtklein@google.com, reed@google.com

Review URL: https://codereview.chromium.org/24288002

git-svn-id: http://skia.googlecode.com/svn/trunk@11451 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-24 20:08:47 +00:00
reed@google.com
dfc740393e remove obsolete USE_CACHE_HASH
BUG=

Review URL: https://codereview.chromium.org/23526082

git-svn-id: http://skia.googlecode.com/svn/trunk@11450 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-24 19:59:44 +00:00
senorblanco@chromium.org
6b5fc91bd4 GalaxyNexus rebaselines for testimagefilters and imagefilterscropped. (I guess this bot was previously failing before generating GMs?)
TBR=bsalomon

Review URL: https://codereview.chromium.org/23531087

git-svn-id: http://skia.googlecode.com/svn/trunk@11449 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-24 17:51:26 +00:00
bsalomon@google.com
c5154d4177 rebase gradients[_*_perspective] tests on GN after test change.
R=epoger@google.com

Review URL: https://codereview.chromium.org/23531085

git-svn-id: http://skia.googlecode.com/svn/trunk@11445 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-24 14:17:12 +00:00
bsalomon@google.com
44a26aa12a Rebaseline gradient changes on GN due to test change.
R=epoger@google.com

Review URL: https://codereview.chromium.org/24161005

git-svn-id: http://skia.googlecode.com/svn/trunk@11441 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-23 20:00:30 +00:00
senorblanco@chromium.org
07dc7cafe4 Rebaselines -- some stragglers for morphology.
TBR=bungeman

Review URL: https://codereview.chromium.org/23688007

git-svn-id: http://skia.googlecode.com/svn/trunk@11440 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-23 17:23:21 +00:00
rmistry@google.com
d21c518651 Whitespace change to trigger rebuilds
git-svn-id: http://skia.googlecode.com/svn/trunk@11438 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-23 13:53:46 +00:00
rmistry@google.com
e36b7ee212 Whitespace change to trigger rebuilds.
git-svn-id: http://skia.googlecode.com/svn/trunk@11430 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-23 12:08:20 +00:00
robertphillips@google.com
485e1c0128 Patch SkImage.h so Chrome will compile
git-svn-id: http://skia.googlecode.com/svn/trunk@11429 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-22 21:57:03 +00:00
robertphillips@google.com
b1b6a46740 Remove SK_ENABLE_LEGACY_API_ALIASING from SkImage.h
git-svn-id: http://skia.googlecode.com/svn/trunk@11428 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-22 21:01:28 +00:00
robertphillips@google.com
c8fb998388 Revert r11423 (low hanging calloc fruit)
git-svn-id: http://skia.googlecode.com/svn/trunk@11427 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-22 20:18:07 +00:00
skia.committer@gmail.com
572a865846 Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@11426 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-21 07:01:53 +00:00
senorblanco@chromium.org
c724471fad Moar rebaselines for testimagefilters and imagefilterscropped.
TBR=bungeman

Review URL: https://codereview.chromium.org/23749010

git-svn-id: http://skia.googlecode.com/svn/trunk@11425 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-20 20:24:55 +00:00
reed@google.com
beb0c2aa32 use new globally scoped SkAlphaType
git-svn-id: http://skia.googlecode.com/svn/trunk@11424 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-20 20:05:01 +00:00
mtklein@google.com
2905ff552c low hanging calloc fruit
BUG=
R=reed@google.com

Review URL: https://codereview.chromium.org/24267014

git-svn-id: http://skia.googlecode.com/svn/trunk@11423 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-20 19:59:47 +00:00
reed@google.com
94248f85e5 add trailing quote on #error
git-svn-id: http://skia.googlecode.com/svn/trunk@11422 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-20 19:47:32 +00:00
reed@google.com
d28ba8010c promote SkImage::AlphaType to SkAlphaType
BUG=
R=bsalomon@google.com

Review URL: https://codereview.chromium.org/24130009

git-svn-id: http://skia.googlecode.com/svn/trunk@11421 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-20 19:33:52 +00:00
commit-bot@chromium.org
d2cfa7422e [PDF] clear() and drawPaint() where applying the initial transform twice.
BUG=b/10845219
R=edisonn@google.com, djsollen@google.com

Author: vandebo@chromium.org

Review URL: https://chromiumcodereview.appspot.com/24130010

git-svn-id: http://skia.googlecode.com/svn/trunk@11420 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-20 18:58:30 +00:00
bungeman@google.com
c526c71acd Map Calibri to Carlito
Chrome OS will have Carlito as a metric-compatible replacement for Calibri.

This change has to be combined with a Chrome OS change to add
Calibri and configure fontconfig accordingly.

BUG=280557
TEST=With the CrOS change, a page using Calibri will use Carlito instead of the default fallback font (Arimo in case of English UI).
R=bungeman@google.com

Review URL: https://codereview.chromium.org/23618061

git-svn-id: http://skia.googlecode.com/svn/trunk@11418 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-20 17:41:52 +00:00
bungeman@google.com
dd88eccb22 Fix slight hinting with GDI.
Sometimes GDI manages to return a different number of points for hinted
and non-hinted outlines. This change handles that case and falls back
to non-hinted. This does not re-enable slight hinting, so there should be
no observable difference in tests. There are still issues with 'D' in
some font/size combinations where 'flips' are used.


git-svn-id: http://skia.googlecode.com/svn/trunk@11417 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-20 17:25:31 +00:00
edisonn@google.com
5be72d1940 ravaseline (pdf and gradients)
BUG=

Review URL: https://codereview.chromium.org/23677013

git-svn-id: http://skia.googlecode.com/svn/trunk@11416 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-20 17:23:56 +00:00
commit-bot@chromium.org
0060159457 ARM Skia NEON patches - 21 - new NEON S32_D565_Opaque
BlitRow565: NEON version of S32_D565_Opaque

Here's a new implementation of S32_D565_Opaque in NEON. It
improves dramatically the speed compared to S32A_D565_Opaque.

Here are the benchmark results (speedup vs. existing NEON):

+-------+-----------+------------+
| count | Cortex-A9 | Cortex-A15 |
+-------+-----------+------------+
| 1     | +130%     | +139%      |
+-------+-----------+------------+
| 2     | +65,2%    | +51%       |
+-------+-----------+------------+
| 4     | -25,5%    | +10,2%     |
+-------+-----------+------------+
| 8     | +63,8%    | +32,1%     |
+-------+-----------+------------+
| 16    | +110%     | +49,2%     |
+-------+-----------+------------+
| 64    | +153%     | +123,5%    |
+-------+-----------+------------+
| 256   | +151%     | +144,7%    |
+-------+-----------+------------+
| 1024  | +272%     | +157,2%    |
+-------+-----------+------------+

Signed-off-by: Kévin PETIT <kevin.petit@arm.com>

BUG=
R=djsollen@google.com, mtklein@google.com

Author: kevin.petit.arm@gmail.com

Review URL: https://chromiumcodereview.appspot.com/22351006

git-svn-id: http://skia.googlecode.com/svn/trunk@11415 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-20 15:38:49 +00:00
mtklein@google.com
519f9677a4 Add sk_calloc. Remove SkMemory_stdlib, which seems unused.
I'm seeing basically no difference between malloc + bzero and calloc on my desktop, but on a Galaxy Nexus calloc is never slower, and significantly faster once the allocation size becomes large, both for allocation and for _reading_.

BUG=skia:1662
R=reed@google.com

Review URL: https://codereview.chromium.org/24251008

git-svn-id: http://skia.googlecode.com/svn/trunk@11414 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-20 14:31:45 +00:00
skia.committer@gmail.com
f91e3d4f54 Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@11411 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-20 07:01:33 +00:00
senorblanco@chromium.org
6932031271 Yet more testimagefilters and imagefilterscropped rebaselines.
TBR=bungeman

Review URL: https://codereview.chromium.org/24244007

git-svn-id: http://skia.googlecode.com/svn/trunk@11410 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-20 01:57:40 +00:00
commit-bot@chromium.org
c5e57bd0a3 silence the error test to be a better citizen
BUG=
R=caryclark@google.com, bsalomon@google.com, tfarina@chromium.org, mtklein@google.com

Author: humper@google.com

Review URL: https://chromiumcodereview.appspot.com/23481012

git-svn-id: http://skia.googlecode.com/svn/trunk@11409 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-19 22:11:38 +00:00
robertphillips@google.com
191eaeb916 Fix for SampleFilterFuzz compiler warning/error
git-svn-id: http://skia.googlecode.com/svn/trunk@11408 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-19 22:02:37 +00:00
senorblanco@chromium.org
c73bbf022a Revert ignore-failures changes from r11395, since the tests have been rebaselined.
TBR=epoger

Review URL: https://codereview.chromium.org/23440054

git-svn-id: http://skia.googlecode.com/svn/trunk@11407 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-19 21:25:48 +00:00
senorblanco@chromium.org
2d9731637b More testimagefilters and imagefilterscropped rebaselines.
TBR=bungeman

Review URL: https://codereview.chromium.org/23503079

git-svn-id: http://skia.googlecode.com/svn/trunk@11406 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-19 21:06:10 +00:00
mtklein@google.com
014f2c4183 Add an even more convenient way to declare tests, with example.
BUG=
R=reed@google.com

Review URL: https://codereview.chromium.org/23828008

git-svn-id: http://skia.googlecode.com/svn/trunk@11405 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-19 20:56:46 +00:00
edisonn@google.com
41c2538970 rebaseline done for gradient tests, stop ignoring the diffs
Review URL: https://codereview.chromium.org/24269009

git-svn-id: http://skia.googlecode.com/svn/trunk@11404 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-19 20:52:37 +00:00
edisonn@google.com
14b8a7867a rebaseline gradients (change the size so it does not chop the drawing)
BUG=

Review URL: https://codereview.chromium.org/23803012

git-svn-id: http://skia.googlecode.com/svn/trunk@11403 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-19 20:52:04 +00:00
edisonn@google.com
051cd1cde0 rebaseline pdf expectations (part 2)
BUG=

Review URL: https://codereview.chromium.org/24072010

git-svn-id: http://skia.googlecode.com/svn/trunk@11402 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-19 20:35:50 +00:00
senorblanco@chromium.org
e7b2f5b60a New baselines for imagefilterscropped, testimagefilters GMs.
TBR=bungeman

Review URL: https://codereview.chromium.org/23855010

git-svn-id: http://skia.googlecode.com/svn/trunk@11401 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-19 20:19:43 +00:00
sugoi@google.com
bb8148b763 Fixed warnings as error
BUG=
R=edisonn@google.com, rmistry@google.com

Review URL: https://codereview.chromium.org/24246006

git-svn-id: http://skia.googlecode.com/svn/trunk@11398 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-19 19:51:27 +00:00
edisonn@google.com
f986284bc5 rebaseline pdf expected results (caused by not writing a bad pdf object if the feature is NYI)
BUG=

Review URL: https://codereview.chromium.org/24144007

git-svn-id: http://skia.googlecode.com/svn/trunk@11397 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-19 19:19:18 +00:00
bsalomon@google.com
c12f2acca0 Rebaseline tilemodes_npot on IMG devices
git-svn-id: http://skia.googlecode.com/svn/trunk@11396 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-19 19:01:45 +00:00
commit-bot@chromium.org
22d69f9973 I'm investigating how to make the IPC transfer a bit more secure on the
skia side by adding some safety checks. This cl is about brainstorming
and proposing possible solutions for type checking at different stages.

BUG=
R=senorblanco@google.com, sugoi@google.com, scroggo@google.com, reed@android.com, senorblanco@chromium.org, mtklein@google.com, reed@google.com

Author: sugoi@chromium.org

Review URL: https://chromiumcodereview.appspot.com/22799007

git-svn-id: http://skia.googlecode.com/svn/trunk@11395 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-19 18:40:49 +00:00
djsollen@google.com
9902c38f48 Add new entry point that supports fallback font selection based on language.
BUG= chromium:287995
R=reed@google.com, wangxianzhu@chromium.org

Review URL: https://codereview.chromium.org/23819067

git-svn-id: http://skia.googlecode.com/svn/trunk@11394 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-19 18:22:30 +00:00
reed@google.com
c1a81ebec5 expand alias fontname test
BUG=
R=bungeman@google.com

Review URL: https://codereview.chromium.org/24198004

git-svn-id: http://skia.googlecode.com/svn/trunk@11393 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-19 18:06:03 +00:00
edisonn@google.com
1da3a80d46 make gradients gm view size larger, as it is choping from the pained canvas.
R=bsalomon@google.com

Review URL: https://codereview.chromium.org/23851037

git-svn-id: http://skia.googlecode.com/svn/trunk@11392 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-19 17:55:49 +00:00
epoger@google.com
1e5b86986b Whitespace change to trigger buildbots
git-svn-id: http://skia.googlecode.com/svn/trunk@11391 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-19 17:51:14 +00:00
epoger@google.com
78b3cd2414 Add expectations/gm/ignored-tests.txt to temporarily ignore failures
BUG=skia:1600
TBR=bsalomon
(SkipBuildbotRuns)

Review URL: https://codereview.chromium.org/23531070

git-svn-id: http://skia.googlecode.com/svn/trunk@11390 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-19 17:41:41 +00:00