Commit Graph

1376 Commits

Author SHA1 Message Date
Ravi Mistry
b6bfb53627 Use the right keys in trigger_wait_ac_task.py
NoTry: true
Bug: skia:7469
Change-Id: I2a77574f35354f75e628968f943be54afa9e3bf9
Reviewed-on: https://skia-review.googlesource.com/105981
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2018-02-09 12:51:59 +00:00
Ravi Mistry
042b5e901b [Bookmaker Nightly Bot] Output the stacktrace of failing fiddles
Bug: skia:7586
Change-Id: If52cefadc657fa93d90fe11b08e3efc5aeacb634
Reviewed-on: https://skia-review.googlesource.com/105767
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2018-02-08 21:35:30 +00:00
Greg Daniel
0c269d0c8e Blacklist GM that is crashing intel vulkan bot
Bug: skia:6398
Change-Id: I9c9cfc3ac7aac98c266f554f8034ef7df482252f
Reviewed-on: https://skia-review.googlesource.com/105820
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2018-02-08 21:04:40 +00:00
Kevin Lubick
7faba0f72a Remove flaky vulkan bot from cq
NOTRY=true

Bug: skia:
Change-Id: I266c4408ccf7bd179a80bacce9a17e4241382137
Reviewed-on: https://skia-review.googlesource.com/105604
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2018-02-08 14:43:19 +00:00
Robert Phillips
0b33cc42b4 Remove nvprdit* configs
Having removed the NVPR text renderer, the nvprdit* configs are no longer interesting/useful.

Change-Id: Ic4b9d6507d3e3595723a27636cb58b5e811fb3a3
Reviewed-on: https://skia-review.googlesource.com/105563
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2018-02-08 13:57:09 +00:00
Kevin Lubick
23dd9323a2 Promote perf bots to CQ
They've been sufficiently fast for the last few days.

NOTRY=true
Bug: skia:
Change-Id: Id5df2e23bc3fd39526301432bcd625c3dca47367
Reviewed-on: https://skia-review.googlesource.com/104260
Reviewed-by: Ravi Mistry <rmistry@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2018-02-06 14:55:05 +00:00
Ravi Mistry
09355087a6 Graduate Android Framework Compile bot to be a full CQ bot
NoTry: true
Bug: skia:7469
Change-Id: Ia013af7ad23c6f4257d0b1d78d249ea76df1e3c1
Reviewed-on: https://skia-review.googlesource.com/104201
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2018-02-06 14:31:57 +00:00
Ravi Mistry
85c8b493eb Improve output of the Android Framework compile bot
NoTry: true
Bug: skia:7469
Change-Id: I8c184968c3a04c5fbf00d641de715a3f7b98e0be
Reviewed-on: https://skia-review.googlesource.com/103463
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2018-02-05 19:09:26 +00:00
Ravi Mistry
73e391db8a [Android Compile Bot] Look at the start_dir for trigger_wait_ac_task.py
Noticed this when trybots were not using changes to
trigger_wait_ac_task.py

NoTry: true
Bug: skia:7469
Change-Id: Ifac964e247bfd6862fa030fbf5176f179ef7f3c4
Reviewed-on: https://skia-review.googlesource.com/103521
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2018-02-05 18:34:46 +00:00
UpdateSKPs
d2807d5115 Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=update-skps@skia.org
NO_MERGE_BUILDS

Change-Id: I248281d0116b2842925481874b10f44be108e2eb
Reviewed-on: https://skia-review.googlesource.com/103360
Commit-Queue: update-skps <update-skps@skia.org>
Reviewed-by: update-skps <update-skps@skia.org>
2018-02-04 08:18:51 +00:00
Ben Wagner
1d8726fbed Add MacBookAir jobs.
No-Try: true
Change-Id: I99f246687b8efc45068db18a3dc72162bdef178d
Reviewed-on: https://skia-review.googlesource.com/103080
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2018-02-02 20:59:19 +00:00
Stephan Altmueller
dd3eca1fc5 [skqp] More args for skqp related scripts
- allows to choose api versions in run_testlab.go
- adds api_version and work_arounds to generate_gn_args

Bug: skia:
Change-Id: I87516b493f4d8eef3689d1722a5dd864131a44f8
Reviewed-on: https://skia-review.googlesource.com/102900
Reviewed-by: Derek Sollenberger <djsollen@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Stephan Altmueller <stephana@google.com>
2018-02-02 20:48:59 +00:00
Kevin Lubick
5ec49c0fc4 Add perf bots to CQ (experimental)
Bug: skia:
NOTRY=true
Change-Id: Ia5e7e844af57ff06fc0e5a4139cf6c62b60a19ef
Reviewed-on: https://skia-review.googlesource.com/102423
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2018-02-02 14:25:49 +00:00
Ravi Mistry
0f1abf89f0 Add Android compile bot as experimental CQ bot
NoTry: true
Bug: skia:7469
Change-Id: I91586918b0c9fe4fb3f0d1ad295d4998dc8a88c4
Reviewed-on: https://skia-review.googlesource.com/102641
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2018-02-02 13:05:32 +00:00
Ravi Mistry
5e967422e0 Add recipe and bots for android-compile.skia.org
Bug: skia:7469
Change-Id: I4a570a92d266d86fca20c9394c8d446df3c41e9b
Reviewed-on: https://skia-review.googlesource.com/102600
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2018-02-01 19:10:59 +00:00
Ravi Mistry
5f9ee7cc53 Fixes to trigger_wait_ac_task.py
Turns out I made the exact same mistake 2.5 years ago:
https://codereview.chromium.org/1373863002/

NoTry: true
Bug: skia:7469
Change-Id: Id21150db072f2e9cb8e4e4b8462cac1a085a5193
Reviewed-on: https://skia-review.googlesource.com/102481
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2018-02-01 14:43:22 +00:00
Ravi Mistry
1782376430 Add script that registers an Android compile task and waits for it to complete
It will be called from a new recipe.
This script follows the same pattern that the trigger_wait_ct_task.py used to
(https://codereview.chromium.org/1370523002).

NoTry: true
Bug: skia:7469
Change-Id: I450e415b004e7f481ca1b377d350eb64e5fa8250
Reviewed-on: https://skia-review.googlesource.com/102340
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2018-01-31 21:19:00 +00:00
Mike Klein
3a3fbf16c3 temporarily disable BadImage test on new ASAN bot
Here's the current error:

==6835==WARNING: AddressSanitizer failed to allocate 0xc0000028 bytes
==6835==AddressSanitizer's allocator is terminating the process instead of returning 0
==6835==If you don't like this behavior set allocator_may_return_null=1
==6835==AddressSanitizer CHECK failed: external/compiler-rt/lib/sanitizer_common/sanitizer_allocator.cc:221 "((0)) != (0)" (0x0, 0x0)

Looking at how sk_malloc and co all funnel into sk_malloc_flags(), and
how our local sk_malloc_flags() works, I think everything would be fine
to run this bot with allocator_may_return_null=1, but I'm not sure how
to do that.

Change-Id: I155439e17dd6353b82056de12f49de34e9538643
Reviewed-on: https://skia-review.googlesource.com/101660
Reviewed-by: Leon Scroggins <scroggo@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2018-01-30 14:44:55 +00:00
Mike Klein
ecd251bbd2 target Android M for -arm- ASAN builds
Change-Id: I8154b9a0b2fcf76fa02af0efa6b57425c6f9ac31
Reviewed-on: https://skia-review.googlesource.com/101580
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2018-01-30 00:05:11 +00:00
Mike Klein
eb72ce5c4a Add 32-bit ARMv8 bots
Our 32-bit "arm" builds can run just fine on most ARMv8 devices.  This
mode of operation is called "aarch32", as opposed to the usual mode
we're used to thinking about of running 64-bit "arm64" binaries,
"aarch64".

(Unimportant side note: there are ARMv8 chips that support only
aarch64... I think e.g. the iPhone X's CPU?  There are also ARMv8 chips
that support only aarch32, rare and usually for tiny embedded things
like a watch.  All the devices we test with support both aarch64 and
aarch32.)

(Technically what we call "arm" is more properly "T32" for Thumb2 32,
and "arm64" is "A64" for... ARM 64.  This note is even less important
than the previous one.)

Android ships 64-bit Skia on devices that support it, but Chrome still
clings to 32-bit.  So I thought it'd make sense for us to run some of
these Chrome-like builds too.  I wasn't sure which ones, so I just went
nuts and mirrored all the Nexus5x bots.  If you notice bots that seem
under your purview and you really don't care about how Chrome would work
in that mode, please mark them in the code review and I'll drop them.

Change-Id: I3e67070c669f5c459f4c0f5f46a68529a8eb9afc
Reviewed-on: https://skia-review.googlesource.com/101545
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2018-01-29 23:13:24 +00:00
Greg Daniel
a6717ce9fe Blacklist additional perf skp on win Intel Vulkan
Bug: skia:6863
Change-Id: Iafdf7cd75d287f4d1f4a639e768b3d9418544959
Reviewed-on: https://skia-review.googlesource.com/101125
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2018-01-29 16:14:51 +00:00
Kevin Lubick
03bd9ee472 Disable flaky perf benchmark
Bug: skia:7551
Change-Id: Id1e4a345849f0e596d38278e5e9d88dfa476d678
Reviewed-on: https://skia-review.googlesource.com/101127
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2018-01-29 15:54:09 +00:00
UpdateSKPs
04fce9c808 Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=update-skps@skia.org
NO_MERGE_BUILDS

Change-Id: If717b7003a20672579fa9f7ccd7b7a8253993b1e
Reviewed-on: https://skia-review.googlesource.com/100414
Reviewed-by: update-skps <update-skps@skia.org>
Commit-Queue: update-skps <update-skps@skia.org>
2018-01-28 07:50:47 +00:00
Mike Klein
c8f740168f remove obsolete DM test configs
ViaSingletonPictures simulates a load pattern that Blink no longer produces.

I don't even remember what Via2ndPic and ViaTwice are meant to test,
but I imagine they're quite obsolete.

There was a lingering reference to ViaMojo, which otherwise doesn't exist.

Bug: skia:7544

Change-Id: I033fd344314054ad66c363e5dbd0a373be188069
Reviewed-on: https://skia-review.googlesource.com/88780
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2018-01-26 20:30:40 +00:00
Ben Wagner
fb9af7dcb6 Couple small changes to speed up Goma compiles
- Use more threads
 - Avoid failures due to Goma compiler_proxy running after Swarming
   task terminates, e.g.
   https://chromium-swarm.appspot.com/task?id=3b309dfecdaa9b10

Change-Id: I8521ad0dbaead6f22a2d3a3401dfe0b2695742b9
Reviewed-on: https://skia-review.googlesource.com/99020
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2018-01-25 15:36:46 +00:00
Kevin Lubick
c2f3e8dc89 Update Chromecasts
I'm increasing capacity, might as well update them.

Bug: skia:
Change-Id: I4a535dbce1b3b586b5be82cb5b9bc0290ad7c6eb
Reviewed-on: https://skia-review.googlesource.com/99480
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2018-01-24 21:33:56 +00:00
Kevin Lubick
5d750edfdd Blacklist changed skp
Bug: skia:6687
Change-Id: I1562d7e9ded7f1be8a7ddc0c2341e54d5abbc0ae
Reviewed-on: https://skia-review.googlesource.com/97901
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2018-01-22 18:24:57 +00:00
Mike Klein
de161cb256 increase alignment of half-float pixels in F16Stages test
I think the Chorizo is now enforcing that our aligned loads are really
aligned.  If this sticks, I'll follow up with the rest of the tests
disabled on the bug.

Bug: skia:7497

Change-Id: Id392e20ead395474f716a2c32d2643c801e03a2e
Reviewed-on: https://skia-review.googlesource.com/97202
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2018-01-22 16:55:17 +00:00
UpdateSKPs
b7235a9b73 Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=update-skps@skia.org
NO_MERGE_BUILDS

Change-Id: Icf77a6498851ddba661bcfd7ec84ed53d62c8b35
Reviewed-on: https://skia-review.googlesource.com/97721
Reviewed-by: update-skps <update-skps@skia.org>
Commit-Queue: update-skps <update-skps@skia.org>
2018-01-21 08:17:10 +00:00
Greg Daniel
bd4bfa8a6e Add Android_API26 bot to CQ
Bug: skia:
Change-Id: I79bdb1ff137c488ef5d4998ffc0cc9cdc28ae9fb
Reviewed-on: https://skia-review.googlesource.com/97240
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2018-01-19 19:04:13 +00:00
Kevin Lubick
95379ebc0d Fix keys for Chromecast gold results
Bug: skia:
Change-Id: Id627a436fb9f2236d083aa5cd72128957dbfbaf9
Reviewed-on: https://skia-review.googlesource.com/95661
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Stephan Altmueller <stephana@google.com>
2018-01-17 16:41:16 +00:00
Kevin Lubick
8baaef9f54 No SRGB for Chromecasts
Bug: skia:
Change-Id: If1fc0854a42407fa6acd8d333ef49ae0b6302a81
Reviewed-on: https://skia-review.googlesource.com/95640
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2018-01-17 15:27:16 +00:00
Kevin Lubick
6ea9fdf70c Enable SRGB config on Chromecast
Also a few more blacklists to avoid shader compilation errors
in the Debug-GPU configuration.

Bug: skia:7166
Bug: skia:6687
Change-Id: I07b5adfc62e8029ece21406f0b79b32d9adf346f
Reviewed-on: https://skia-review.googlesource.com/95560
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2018-01-17 14:45:36 +00:00
Kevin Lubick
d452434d17 Upload multiple dm images at once
Use the -m file, as recommended in
https://luci-milo.appspot.com/swarming/task/3b197fbd667a1510/steps/upload_images/0/stdout

Bug: skia:
Change-Id: I58d101f58594bf221d11a787057ee7950b197f86
Reviewed-on: https://skia-review.googlesource.com/94965
Reviewed-by: Stephan Altmueller <stephana@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2018-01-17 12:29:26 +00:00
Kevin Lubick
608c35ae10 Fix Test-Chromecast from running out of memory on tests
Bug: skia:7166
Change-Id: Iefc8c6c1b72805dfe3ec8bd06d6ba6a878307582
Reviewed-on: https://skia-review.googlesource.com/93620
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
2018-01-16 21:35:48 +00:00
Stephan Altmueller
8ee7fb0083 Fix directory creation in skqp app
Bug: skia:
Change-Id: Id26832ccce7d09d3d3d640bcdd11a424f18943f7
Reviewed-on: https://skia-review.googlesource.com/92682
Reviewed-by: Hal Canary <halcanary@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
2018-01-16 21:33:39 +00:00
UpdateSKPs
3167aa0c9c Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=update-skps@skia.org
NO_MERGE_BUILDS

Change-Id: I722c00929081ea067ba7afd5fbd98b1ca16d7c40
Reviewed-on: https://skia-review.googlesource.com/94580
Commit-Queue: update-skps <update-skps@skia.org>
Reviewed-by: update-skps <update-skps@skia.org>
2018-01-14 07:43:02 +00:00
Kevin Lubick
4f0f933579 Add Android ASAN bot
It should work on 32 and 64 bit android running M or newer.

Bug: skia:
Change-Id: I7e6d4000f4fee8f2704b84b7174174dd0e68d21c
Reviewed-on: https://skia-review.googlesource.com/93700
Reviewed-by: Mike Klein <mtklein@chromium.org>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2018-01-12 19:57:33 +00:00
Eric Boren
620c0b6378 [recipes] Define variables in __init__
This may fix weird races in tests.

Bug: skia:
Change-Id: I41c36424c7b559301e915a0892590c74931ae463
Reviewed-on: https://skia-review.googlesource.com/93942
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-01-12 19:15:49 +00:00
Chris Dalton
4ff1a6b0e0 Blacklist SkImage_makeNonTextureImage on Skylake vk
Bug: skia:
Change-Id: I7394d2f392d7179777b65e77194436271efea80d
Reviewed-on: https://skia-review.googlesource.com/93760
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
2018-01-12 19:10:44 +00:00
Ben Wagner
4c39c0dc03 Revert cert dim now that all Mac builders have new cert.
Bug: chromium:799625, skia:7408
Change-Id: Ibacb40c8383559d29bfe31dcc68d40b28844853e
Reviewed-on: https://skia-review.googlesource.com/92687
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Stephan Altmueller <stephana@google.com>
2018-01-11 20:52:18 +00:00
Kevin Lubick
1c153c0fba Trying gpu scaling on Nexus 5 and 5x
We do some of this already in skpbench.

Bug: skia:
Change-Id: Ia698466e83f9b476644c126747a2f89346361d13
Reviewed-on: https://skia-review.googlesource.com/93561
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2018-01-11 19:22:36 +00:00
Mike Klein
515bda6811 support gray8 destinations on CPU
- fill in a couple switches to allow software to rasterize gray8
 - add a gray8 config to DM so we can test it
 - enable this config on some bots

Today we draw gray8 using SkRasterPipeline, loading it as {g,g,g,1}
and storing using the same fixed luma math as SkLumaColorFilter.
One day it'd be nice to use the color space's luma vector if present.

Can we support this on GPU?

Change-Id: I4ee661c8bd5f33f5db2433ffb6e1bc2483af8397
Reviewed-on: https://skia-review.googlesource.com/92681
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2018-01-09 22:19:58 +00:00
Kevin Lubick
7e6dc63945 Move 5x to proper CQ
I spot checked a few of the runs, and the both seem to be < 20m, even when
the tree is busy.

Bug: skia:
NOTRY=true
Change-Id: I1194f34365501afd5c9533332318a91c2db95194
Reviewed-on: https://skia-review.googlesource.com/92100
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2018-01-09 15:44:52 +00:00
Stephan Altmueller
c35959f3cb First version of SkQP app to run on Firebase Testlab
Adds activities to the skqp app so it can run as an Android
app (as opposed to just instrumentation tests).
A user can trigger the tests via a button.
Adds the an intent receiver so the tests can be triggered on
Firebase Testlab via the gameloop option.

It adds the run_testlab.go script to run an apk across devices
on Firebase Testlab.

Bug: skia:
Change-Id: I3ff5c37d743fa47913a916a0fa1e7db3c2cc79c7
Reviewed-on: https://skia-review.googlesource.com/89163
Commit-Queue: Stephan Altmueller <stephana@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Derek Sollenberger <djsollen@google.com>
2018-01-08 22:42:21 +00:00
Ravi Mistry
7b7d9b374d Point ct_skps.py recipe to new SKP repository
Bug: skia:7463
Change-Id: I5dd17a5ba33f867346837f006f9dc4cb775cfa04
Reviewed-on: https://skia-review.googlesource.com/91960
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2018-01-08 17:39:21 +00:00
UpdateSKPs
ca3dcd5b8d Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=update-skps@skia.org
NO_MERGE_BUILDS

Change-Id: Iefdf2ac0419398b61a6657c0bc21f98d098b0343
Reviewed-on: https://skia-review.googlesource.com/91800
Reviewed-by: update-skps <update-skps@skia.org>
Commit-Queue: update-skps <update-skps@skia.org>
2018-01-07 08:11:26 +00:00
Yuqian Li
4a577af2d8 Separate compile task from calmbench task
Bug: skia:7344
Change-Id: I019fe5e3178d13ccf3a510bdcf1c81915149def5
Reviewed-on: https://skia-review.googlesource.com/89900
Commit-Queue: Yuqian Li <liyuqian@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2018-01-05 18:13:36 +00:00
Ben Wagner
6dbff086f0 Add support for Build...ParentRevision tasks.
Bug: skia:7344
Change-Id: I458afe4abe5edff8b8ccbd5abdaf4ebbf892ee00
Reviewed-on: https://skia-review.googlesource.com/90245
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2018-01-04 17:37:54 +00:00
Ben Wagner
f990ebc272 Only uninstall if install failed.
This is a followup to https://skia-review.googlesource.com/c/skia/+/90343,
which causes task durations to increase due to copying over images, skps,
etc. on every run.

Bug: skia:7408
Change-Id: I42e829e287b7343e969159ac19c587a87ebe99e8
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/90942
Reviewed-by: Stephan Altmueller <stephana@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2018-01-04 17:16:23 +00:00