Commit Graph

40874 Commits

Author SHA1 Message Date
Nigel Tao
b8ec7f194a Remove unused setAlphaAndRequiredFrame condition
Also add some commentary.

Bug: skia:
Change-Id: I164c4004802387981b76b28adc106ac0e65fc3ce
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/196820
Reviewed-by: Derek Sollenberger <djsollen@google.com>
Reviewed-by: Leon Scroggins <scroggo@google.com>
Commit-Queue: Leon Scroggins <scroggo@google.com>
2019-03-26 13:47:22 +00:00
skia-autoroll
2870c39ed1 Roll third_party/externals/swiftshader 54ec759a7405..213a8ce6d5c2 (2 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/54ec759a7405..213a8ce6d5c2


git log 54ec759a7405..213a8ce6d5c2 --date=short --no-merges --format='%ad %ae %s'
2019-03-26 bclayton@google.com SpirvShader: Implement OpSwitch
2019-03-26 bclayton@google.com SpirvShader: Implement OpBranchConditional, OpPhi, ...


Created with:
  gclient setdep -r third_party/externals/swiftshader@213a8ce6d5c2

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=stani@google.com

Change-Id: I97d95d5ecd008558a8ad37c1bda6f25947d05fe5
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203665
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-03-26 13:22:48 +00:00
skia-autoroll
62fd6c4116 Roll third_party/externals/swiftshader c0cf68ba0ed6..54ec759a7405 (2 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/c0cf68ba0ed6..54ec759a7405


git log c0cf68ba0ed6..54ec759a7405 --date=short --no-merges --format='%ad %ae %s'
2019-03-26 sugoi@google.com Renderpass multisampling resolve
2019-03-26 sugoi@google.com Fill buffer fix


Created with:
  gclient setdep -r third_party/externals/swiftshader@54ec759a7405

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=stani@google.com

Change-Id: I5b4c70ebd3d486fcd62132eb2666ddef2961f29d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203663
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-03-26 12:30:18 +00:00
skia-autoroll
42d8ea905c Roll third_party/externals/swiftshader 7af926603c2d..c0cf68ba0ed6 (3 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/7af926603c2d..c0cf68ba0ed6


git log 7af926603c2d..c0cf68ba0ed6 --date=short --no-merges --format='%ad %ae %s'
2019-03-26 bclayton@google.com SpirvShader: Add EmitState
2019-03-26 bclayton@google.com SpirvShader: Add Intermediate::replace()
2019-03-26 bclayton@google.com SpirvShader: Add flow control info to Block.


Created with:
  gclient setdep -r third_party/externals/swiftshader@c0cf68ba0ed6

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=stani@google.com

Change-Id: Ic40588f49061b70d632ff5d33ab9eafe8bee7869
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203661
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-03-26 11:50:18 +00:00
Kevin Lubick
5509dac4cc Reland "Generate GrGLInterface and GrGlAssembleInterface* from table"
This reverts commit 573cb87a07.

Reason for revert: Marking failing validation as optional and filing bug for follow up in Chrome.

Original change's description:
> Revert "Generate GrGLInterface and GrGlAssembleInterface* from table"
> 
> This reverts commit 93b3dce89d.
> 
> Revert "Delete old assembleInterface code"
> 
> This reverts commit 7b1cf20d47.
> 
> Revert "Delete in favor of autogenerated file"
> 
> This reverts commit 0223bd01d8.
> 
> Bug: skia:8474
> NOTRY:true
> Change-Id: I23a904347f9d6cefd1710a2de056c39d52f4b178
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203463
> Reviewed-by: Stan Iliev <stani@google.com>
> Commit-Queue: Stan Iliev <stani@google.com>

TBR=kjlubick@google.com,stani@google.com

Change-Id: I85adb302eb093fe9b7a4ec2c984323c191278a43
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:8474
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203177
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2019-03-26 10:55:00 +00:00
skia-autoroll
3d00c2d823 Roll third_party/externals/swiftshader e1cf863e65c6..7af926603c2d (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/e1cf863e65c6..7af926603c2d


git log e1cf863e65c6..7af926603c2d --date=short --no-merges --format='%ad %ae %s'
2019-03-26 swiftshader.regress@gmail.com Regres: Update test lists @ 221459f4


Created with:
  gclient setdep -r third_party/externals/swiftshader@7af926603c2d

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=stani@google.com

Change-Id: I8f453f24eaf03d8ee38daabdf78d70fd0bbb28db
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203646
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-03-26 09:23:58 +00:00
skia-autoroll
d90004516a Roll third_party/externals/swiftshader 221459f4ecc9..e1cf863e65c6 (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/221459f4ecc9..e1cf863e65c6


git log 221459f4ecc9..e1cf863e65c6 --date=short --no-merges --format='%ad %ae %s'
2019-03-26 chrisforbes@google.com Support for per-instance attributes


Created with:
  gclient setdep -r third_party/externals/swiftshader@e1cf863e65c6

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=stani@google.com

Change-Id: Ifc72bfd6ab099278e36881692d144a629abbace0
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203641
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-03-26 06:53:18 +00:00
skia-recreate-skps
33211b2c7a Update go_deps asset
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I22db316d74a6d412b5ea677c51c06e6c89eab953
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203609
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2019-03-26 05:53:58 +00:00
skia-autoroll
80dd599e91 Roll ../src 40ce19f3a56f..4035f6c897d0 (377 commits)
40ce19f3a5..4035f6c897


Created with:
  gclient setdep -r ../src@4035f6c897

The AutoRoll server is located here: https://autoroll.skia.org/r/chromium-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Release-All-CommandBuffer;skia.primary:Test-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Debug-All-CommandBuffer
TBR=stani@google.com

Change-Id: I9eebab69d3c6cb31f506204bf5965a63e420aa66
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203604
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-03-26 02:08:18 +00:00
skia-autoroll
862b528307 Roll third_party/externals/angle2 9078c6a7199b..da37e7f6759d (5 commits)
9078c6a719..da37e7f675


git log 9078c6a7199b..da37e7f6759d --date=short --no-merges --format='%ad %ae %s'
2019-03-26 rafael.cintron@microsoft.com Add trailing slash to glmark2 data dep
2019-03-26 enrico.galli@intel.com ES31: Enabling skipped deqp atomic counter tests on D3D11
2019-03-25 jmadill@chromium.org Print SystemInfo after collection in ANGLE tests.
2019-03-25 jonahr@google.com Move gpu_test_expectations from third_party into ANGLE.
2019-03-25 jmadill@chromium.org Use Khronos master lists for dEQP tests.


Created with:
  gclient setdep -r third_party/externals/angle2@da37e7f6759d

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=stani@google.com

Change-Id: Ib04917080de4dcda6ab72eec3a26c1a1ce603108
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203603
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-03-26 01:55:28 +00:00
Florin Malita
a1dcaaeaa5 Make SkShaper available in Fiddle
Change-Id: I95f18c6ce898ab0438782d1b2454516fbe713451
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203178
Commit-Queue: Ben Wagner <bungeman@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
2019-03-26 00:52:47 +00:00
recipe-roller
ca07591d0d Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/5a368d4dd9c481c1c9efbc73509a5c9778d04f85 Make git cl issue handle bad arguments more gracefully. (thestig@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I119dded9141ecc9cf284279219f0ea8c4df8daec
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203346
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2019-03-25 23:55:48 +00:00
recipe-roller
ca6e8c3570 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/fef79d40aea57ae816ad46bb928c139fc05dde1a [recipe_modules/gsutil] Fix docstring and potential error in name derivation. (iannucci@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I5ee634bbdfe0b66b58534c2a3f2a03684a936647
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203344
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2019-03-25 23:15:47 +00:00
Ben Wagner
c5ee499f2c Enable fontconfig fontmgr in public.bzl.
This enables the fontconfig font manager and tests it on unix like
platforms.

Change-Id: Ic0c2ad842e5f67fe50d100752d0eb239659d58e1
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203466
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2019-03-25 20:32:31 +00:00
Ben Wagner
7415a422ac Replace SkSpan with Range in shaper reporting.
This allows for using non-contiguous input in a future api for shaper.
This change forces cleanup of error handling when doing low level
shaping, which prompts cleaning up the correct shaper code to make the
control flow more obvious.

Bug: skia:8906
Change-Id: If084e0dd88e2f3a9651551ceeff87480e87fb998
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203465
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Ben Wagner <bungeman@google.com>
2019-03-25 20:26:50 +00:00
Brian Osman
15dc59e65c Stop supporting VC8 (Visual Studio 2005) in GrConfig
Bug: skia:
Change-Id: I5d447ea40ef541682f1e855d14e07bf8e45ee89a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203392
Auto-Submit: Brian Osman <brianosman@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2019-03-25 19:24:19 +00:00
Eric Karl
3f219cb76c Ensure we don't skip image memory barriers when queue change needed
Currently if we our GrVkImage is already in the desired read-only
layout, we'll skip issuing an image memory barrier when setImageLayout
is called.

This is normally fine, but if the image is on the incorrect queue
(typically hit with EXTERNAL queue transitions), we can't skip the
barrier, as we need to transition to our internal queue.

Bug: skia:8909
Change-Id: Ic5f68454eb7c4eaf62582e8bc2531d6477eb6e60
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203183
Commit-Queue: Eric Karl <ericrk@chromium.org>
Reviewed-by: Greg Daniel <egdaniel@google.com>
2019-03-25 19:23:19 +00:00
Mike Klein
499f0ac563 spin off :trace target
Still mostly just looking at flags that don't do anything.

Change-Id: Ia5c4269b14d3cd44adfa2a52a39c3a7a14029572
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203191
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2019-03-25 19:16:34 +00:00
Brian Osman
9fec5d390a Fix doc comment error for allocN32Pixels
Bug: skia:
Change-Id: I93fb561ed0b367c0a207b26aa297b997f06acfa7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203395
Auto-Submit: Brian Osman <brianosman@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2019-03-25 19:14:49 +00:00
Leon Scroggins III
587edabd83 Only dereference imgcfg if non-null
Bug: oss-fuzz:8902
Change-Id: I2cd6fff4e27cc75f324f04888bcc36a42c912726
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203165
Auto-Submit: Leon Scroggins <scroggo@google.com>
Reviewed-by: Nigel Tao <nigeltao@google.com>
Commit-Queue: Leon Scroggins <scroggo@google.com>
2019-03-25 19:11:29 +00:00
Kevin Lubick
573cb87a07 Revert "Generate GrGLInterface and GrGlAssembleInterface* from table"
This reverts commit 93b3dce89d.

Revert "Delete old assembleInterface code"

This reverts commit 7b1cf20d47.

Revert "Delete in favor of autogenerated file"

This reverts commit 0223bd01d8.

Bug: skia:8474
NOTRY:true
Change-Id: I23a904347f9d6cefd1710a2de056c39d52f4b178
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203463
Reviewed-by: Stan Iliev <stani@google.com>
Commit-Queue: Stan Iliev <stani@google.com>
2019-03-25 19:03:29 +00:00
Brian Osman
4cd0734f4c Remove bookmaker sources and data files
We're moving in a different direction for Skia documentation. We no
longer run bookmaker on the bots, and things have already degraded such
that it can't be run. This leaves the generated markdown in place for
the last set of docs that were generated (which are still useful until
the Doxygen docs catch up).

See also: https://skia-review.googlesource.com/c/skia/+/198162

Docs-Preview: https://skia.org/?cl=203464
Bug: skia:
Change-Id: I2f967a9c17dbc1cc899947d365071ef69cfb8ad7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203464
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2019-03-25 18:56:29 +00:00
Mike Klein
171284fb1a clean up stray libpng deps
I don't know why libpng is all over the place like this,
but it really only is used by SkPngCodec, by DM, and by
a few unit tests.

Change-Id: I60908d9412cbac819c9e29154c5aba6e924f099a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203192
Auto-Submit: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2019-03-25 18:52:49 +00:00
Greg Daniel
bb792aae8c Add option to disable vsync on viewer unix.
This also fixes an issue where vulkan would crash any time we change a
display param on unix.

Bug: skia:
Change-Id: Ic6c3843e04bc77c2e9c5301ee38fcc58a409495d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203380
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2019-03-25 18:24:29 +00:00
Brian Osman
65f3344294 Clean up texture domain effect GM, wrt proxy creation
Bug: skia:
Change-Id: I114daee3b3f8ffeeec36a3355a53750604ca1038
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203389
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2019-03-25 18:16:05 +00:00
Brian Osman
f2ae6af713 Stop flooding perf with uninteresting GPU stats
We only care about two things: RT binds and shader compiles. RT binds
should be constant frame-to-frame, and shader compiles should always be
zero on frame 2, so just measure on frame 1.

Bug: skia:
Change-Id: I4defa0a6dc79413b375ec60b5024fa57e768b127
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203391
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2019-03-25 18:04:44 +00:00
Greg Daniel
a51e93c9a0 Fix up readPixels, writePixels, and copies when dealing with ycbcr textures in vulkan.
In general this makes sure we never directly read or write pixels or use one of
the vk image copy functions if we are dealing with a VkImage that requires a Ycbcr texture.

Bug: b/129037735
Change-Id: Ib3bbac8bcddb643942e08d2b2ae3381fda6758a7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203388
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2019-03-25 17:49:28 +00:00
Mike Klein
c6142d855c de-common the rest of the flags
Turns out lots of tools had two copies of many of these flags.

Some GN and .cpp file refactoring to make sure when flags are
present in a binary, they do something in that binary.

I think this finally finishes the flag refrag.

Change-Id: I01488e37ab73a5c4361786863ddb137a7f1095b1
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203420
Commit-Queue: Mike Klein <mtklein@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Auto-Submit: Mike Klein <mtklein@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2019-03-25 17:39:58 +00:00
Kevin Lubick
0223bd01d8 Delete in favor of autogenerated file
Follow up to https://skia-review.googlesource.com/c/skia/+/203386

Change-Id: I841ecfc3b7babc6c6bf9925b3bf0988f6b057dab
Bug: skia:8474
NOTRY: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203390
Reviewed-by: Stan Iliev <stani@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2019-03-25 17:32:18 +00:00
skia-autoroll
a9fa7b87f3 Roll third_party/externals/angle2 eae464dd3092..9078c6a7199b (1 commits)
eae464dd30..9078c6a719


git log eae464dd3092..9078c6a7199b --date=short --no-merges --format='%ad %ae %s'
2019-03-25 jonahr@google.com Update necessary angle_end2end_tests to check the Android device name


Created with:
  gclient setdep -r third_party/externals/angle2@9078c6a7199b

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=stani@google.com

Change-Id: Idb4590b68e7ff2d0d966a0e8e8fd61332f3348d3
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203331
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-03-25 16:58:48 +00:00
Brian Osman
dbe93221c2 Fix GM that was trying to create mip-mapped proxies without checking caps
Bug: skia:
Change-Id: Iafd6a7cc1288b7287bb5d127e542e530647d74d4
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203387
Commit-Queue: Brian Osman <brianosman@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
Auto-Submit: Brian Osman <brianosman@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2019-03-25 16:53:18 +00:00
Brian Salomon
41f9c3cde9 Avoid special shader for opaque alpha when drawing simple rectangles.
It's a wasted shader compiler and also seems to cause a rendering bug
in Windows Chrome on ANGLE.

Bug: chromium:942565
Change-Id: I56373ac596d4d1548d6c86cda7127bf12190a0ae
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203383
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2019-03-25 16:51:58 +00:00
skia-autoroll
d1630203fb Roll third_party/externals/swiftshader e24bc66dcda3..221459f4ecc9 (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/e24bc66dcda3..221459f4ecc9


git log e24bc66dcda3..221459f4ecc9 --date=short --no-merges --format='%ad %ae %s'
2019-03-25 headlessclayton@gmail.com Work around another MSVC bug with variadic macros.


Created with:
  gclient setdep -r third_party/externals/swiftshader@221459f4ecc9

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=stani@google.com

Change-Id: I98392d77c530ab11d73511a5d07a01c9189011c1
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203330
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-03-25 16:26:48 +00:00
Kevin Lubick
7b1cf20d47 Delete old assembleInterface code
Was breaking Google3 roll

if https://skia.googlesource.com/skia.git/+/93b3dce89d0cada44fd619571d55a1c83b751f70
is reverted, this should also be reverted

Change-Id: Ic065d89a8a06f1752644e7b8453f50ae3934f68c
Bug: skia:8474
NOTRY: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203386
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Stan Iliev <stani@google.com>
2019-03-25 16:08:48 +00:00
Brian Osman
42197c0bc6 Add support for 1010102 on ES2 devices with EXT_texture_type_2_10_10_10_REV
Bug: skia:8894
Change-Id: Id3dbc02894f87dcf81f65048945692e54cca38f1
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203059
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2019-03-25 15:32:18 +00:00
Ravi Mistry
e298294fc6 Add new Intel x86_64 CPU SkottieTracing bot
NoTry: true
Bug: skia:8901
Change-Id: I4bb90a37ee7afdfb3634e1b04e5a244a77d2b5ef
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/202907
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2019-03-25 15:15:04 +00:00
Michael Ludwig
2839884b79 Respect stroke width in Android rrect clip optimization
Bug: b/113636985
Change-Id: I80df664a077751e9ce5c735694e7ba283e93bcc1
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203170
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
2019-03-25 15:09:59 +00:00
Ravi Mistry
1a3c397dcc [Recipe] Add CPU bot capability to perf_skottietrace.py
Bug: skia:8901
Change-Id: I6e0f2b57987a60c1d4f2d2dc0d92df640d15e08d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/202906
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2019-03-25 15:09:58 +00:00
Kevin Lubick
93b3dce89d Generate GrGLInterface and GrGlAssembleInterface* from table
This CL creates a go program that takes a JSON file of
GPU functions and creates the assemble and validate code
based on that.

This approach will hopefully will lessen the need for
"shotgun surgery" anytime a new function/extensions is added.

Additionally, it should be easier to add a new standard
(concretely, WebGL) using this technique.

There are a few potential bugs/mismatches in the current
implementation that this has identified, for example,
Requiring GL 3.x for adding a feature, but only verifying
it is there on GL 4.x - I did not attempt to correct these
bugs in the old version, as we will hopefully be able to delete
that version and use the generated files.

Bug: skia:8474, skia:8378
Change-Id: Ie8144bbab8e03f2c815fd942fa9f7f91dedba101
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/202137
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2019-03-25 15:03:48 +00:00
Brian Osman
7dcc616279 Reland "Simplify two more clients of proxy provider (mipped vs. non-mipped)"
Adds fix for mip-mapped requests on devices with no mip support.

This reverts commit ab4c138c0e.

Bug: skia:
Change-Id: I85350ae32081253448cbd2f636ea3044eb9df453
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203057
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2019-03-25 14:46:28 +00:00
Brian Osman
ddba4e646a SkBaseDevice::drawAtlas doesn't antialias either, so remove fallback
Also, fix the trace marker name.

Bug: skia:8903
Change-Id: Ibf43efbdf73e406482ed4442639e22aec1d93e9f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203058
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2019-03-25 14:24:19 +00:00
Ravi Mistry
d37e1b0fad [Recipe Modules] Make DefaultFlavor.step signature match the other step funcs
Bug: skia:8901
Change-Id: Ibe14ed88c0cd937eae2d91eb6e90391466098a2c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203341
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2019-03-25 14:21:19 +00:00
skia-autoroll
36c5ed7a03 Roll third_party/externals/swiftshader 62f62a6efa2c..e24bc66dcda3 (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/62f62a6efa2c..e24bc66dcda3


git log 62f62a6efa2c..e24bc66dcda3 --date=short --no-merges --format='%ad %ae %s'
2019-03-25 sugoi@google.com Fixed erroneous filtering


Created with:
  gclient setdep -r third_party/externals/swiftshader@e24bc66dcda3

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=stani@google.com

Change-Id: I2070c01e14e0f88d4a6d78c3912ce49fb2acd5cc
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203325
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-03-25 14:18:59 +00:00
Ravi Mistry
2719dff87a [Recipe Modules] remove_file_on_device was in all flavors except DefaultFlavor
Bug: skia:8901
Change-Id: Idde99d943c31ae62fcd0bc3f3b8cfc0ebc07e896
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203340
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2019-03-25 13:58:49 +00:00
Kevin Lubick
cd54466473 Expose gpu cache knobs
Change-Id: I5911593812ebf6fd235c6a3fc2acfa740c7687aa
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203164
Reviewed-by: Florin Malita <fmalita@chromium.org>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2019-03-25 11:48:25 +00:00
skia-recreate-skps
554bec1fff Update go_deps asset
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I470e438a2714a389cffd148643387b43125670c0
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203114
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: Eric Boren <borenet@google.com>
2019-03-25 11:46:27 +00:00
skia-autoroll
2e2fa9e3a0 Roll third_party/externals/swiftshader e276f52bb4c9..62f62a6efa2c (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/e276f52bb4c9..62f62a6efa2c


git log e276f52bb4c9..62f62a6efa2c --date=short --no-merges --format='%ad %ae %s'
2019-03-25 swiftshader.regress@gmail.com Regres: Update test lists @ e276f52b


Created with:
  gclient setdep -r third_party/externals/swiftshader@62f62a6efa2c

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=stani@google.com

Change-Id: Iaeafc188dc82a2b3a3ff641baa56f77cb67a2647
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203313
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-03-25 08:55:24 +00:00
skia-autoroll
c9f746cfb9 Roll ../src 0a4f8d5b63f5..40ce19f3a56f (30 commits)
0a4f8d5b63..40ce19f3a5


Created with:
  gclient setdep -r ../src@40ce19f3a5

The AutoRoll server is located here: https://autoroll.skia.org/r/chromium-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Release-All-CommandBuffer;skia.primary:Test-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Debug-All-CommandBuffer
TBR=stani@google.com

Change-Id: I201269164846b6e99b5178867c39550a00814158
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203301
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-03-25 01:03:43 +00:00
recipe-roller
e9a53fe352 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/ba35c7f8ce4bc9ae93607109b89199d3d9e0af2d Fix possible use of unassigned local variable in git_cl.py (raul@tambre.ee)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I87c5ef166d6ca84ebb04ad725d1a8332ee15ca7b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203113
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2019-03-24 06:46:30 +00:00
skia-recreate-skps
d79c95e8bc Update go_deps asset
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I4b9639ea5fdfb6fbb9db787d2d02be654a7af91e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203112
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2019-03-24 05:52:00 +00:00