commit-bot@chromium.org
faa5ae456d
Turn on -Wall -Wextra on Mac, and fix all the warnings that crop up for /usr/bin/g++ and Clang 3.3.
...
BUG=
R=bungeman@google.com
Author: mtklein@google.com
Review URL: https://chromiumcodereview.appspot.com/19569012
git-svn-id: http://skia.googlecode.com/svn/trunk@10255 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-23 11:13:56 +00:00
senorblanco@chromium.org
ccf225cebb
This patch implements a crop rect for SkImageFilter. It has been implemented for SkColorFilterImageFilter and SkBlurImageFilter as examples.
...
In order to preserve the immutability of SkImageFilters, the crop rect is passed as a constructor parameter. If NULL (the default), the bounds of the input image are used, as before.
This also tightens up the boundary handling for SkImageBlurFilter on the GPU backend. Where we were previously using clamping semantics, we now respect decal semantics (so we don't oversaturate the edges). This brings the GPU and raster backends into closer alignment, but will require some new baselines for the GPU tests.
At a minimum, the following tests will need new baselines: imageblur, imagefiltersbase, imagefilterscropped, spritebitmap.
R=reed@google.com
Review URL: https://codereview.chromium.org/19775006
git-svn-id: http://skia.googlecode.com/svn/trunk@10251 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-22 20:03:22 +00:00
zachr@google.com
5b3e2b9622
move skpdiff into tools
...
R=djsollen@google.com
Review URL: https://codereview.chromium.org/19608005
git-svn-id: http://skia.googlecode.com/svn/trunk@10249 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-22 18:46:45 +00:00
vandebo@chromium.org
fc16667077
Revert "Adds SkPDFResourceDict class, refactor existing code to use it."
...
This reverts commit r10245
Review URL: https://codereview.chromium.org/19523007
git-svn-id: http://skia.googlecode.com/svn/trunk@10247 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-22 18:31:24 +00:00
commit-bot@chromium.org
3a8dfc36ae
Adds SkPDFResourceDict class, refactor existing code to use it.
...
Committed: http://code.google.com/p/skia/source/detail?r=10202
R=vandebo@chromium.org , edisonn@google.com
Author: richardlin@chromium.org
Review URL: https://chromiumcodereview.appspot.com/18977002
git-svn-id: http://skia.googlecode.com/svn/trunk@10245 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-22 18:20:52 +00:00
edisonn@google.com
ac03d91ee0
pdfviewer: All NulCanvas (does not draw operations), TrackDevice (trackes what pixels have been changed)
...
Review URL: https://codereview.chromium.org/19793006
git-svn-id: http://skia.googlecode.com/svn/trunk@10236 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-22 15:36:39 +00:00
bungeman@google.com
b8f3655d49
Update obvious deps.
...
This is a step toward targets declaring their deps in a sane fashion.
This change resolves cycles by forcing core to the root, then everything
in skia_lib pointing toward core as best possible, then everything
outside skia_lib depending on skia_lib for things in skia_lib. This
prevents double definitions where a symbol is provided by both the
skia_lib shared object and and a statically linked component of skia_lib.
R=djsollen@google.com
Review URL: https://codereview.chromium.org/19823003
git-svn-id: http://skia.googlecode.com/svn/trunk@10231 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-22 14:39:45 +00:00
djsollen@google.com
2679ff8b8d
refactor gyp to isolate freetype usage
...
R=bungeman@google.com
Review URL: https://codereview.chromium.org/19835002
git-svn-id: http://skia.googlecode.com/svn/trunk@10229 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-22 14:12:56 +00:00
zachr@google.com
904f86e6aa
Revert "migrate skpdiff to tools"
...
This reverts commit 58a7ec70ce6b4548793a2ddc37c63d3d44edbc36.
git-svn-id: http://skia.googlecode.com/svn/trunk@10226 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-22 13:29:20 +00:00
zachr@google.com
a54aaf7fba
migrate skpdiff to tools
...
R=djsollen@google.com
Review URL: https://codereview.chromium.org/19671002
git-svn-id: http://skia.googlecode.com/svn/trunk@10225 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-22 13:14:04 +00:00
skia.committer@gmail.com
1f3c73825b
Sanitizing source files in Housekeeper-Nightly
...
git-svn-id: http://skia.googlecode.com/svn/trunk@10223 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-20 07:00:58 +00:00
bungeman@google.com
899f1d854a
Revert deps changes in r10220 and r10217.
...
Need to avoid linking in .a things which are already provided by .so things.
git-svn-id: http://skia.googlecode.com/svn/trunk@10222 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-20 00:24:35 +00:00
bungeman@google.com
13388e7164
Lie about views_animated dependencies until Android situation is resolved.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@10220 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-19 23:10:37 +00:00
bungeman@google.com
2b0ab9e13a
Update obvious deps.
...
This is a step toward targets declaring their deps in a sane fashion.
This change resolves cycles by forcing core to the root,
then opts, ports, and utils depending on core, then everything else.
We will need some other change to resolve the fact that
core, opts, ports, and utils depend on each other and other targets which
depend on them. Outside of these targets, things look ok.
R=djsollen@google.com
Review URL: https://codereview.chromium.org/19823003
git-svn-id: http://skia.googlecode.com/svn/trunk@10217 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-19 22:31:23 +00:00
humper@google.com
8ac834b030
bad line in gyp fie snuck into last commit, continuing the ARM breakage
...
git-svn-id: http://skia.googlecode.com/svn/trunk@10214 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-19 21:26:15 +00:00
humper@google.com
16acf75151
use SK_ScalarPI, and fix ARM build
...
git-svn-id: http://skia.googlecode.com/svn/trunk@10212 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-19 21:12:08 +00:00
humper@google.com
138ebc3e40
The image resampling code has been transplanted from Chrome; it's incredibly fast.
...
We've tested this CL plumbed into Chrome and done benchmarking with excellent results.
This CL can land independent of any Chrome changes; it's completely internal to skia.
BUG=
R=reed@google.com
Review URL: https://codereview.chromium.org/19335002
git-svn-id: http://skia.googlecode.com/svn/trunk@10206 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-19 20:20:04 +00:00
vandebo@chromium.org
d322cf4939
Revert "Adds SkPDFResourceDict class to manage resource dicts. Refactors existing code to use this class."
...
This reverts commit r10202
Review URL: https://codereview.chromium.org/19790007
git-svn-id: http://skia.googlecode.com/svn/trunk@10205 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-19 20:13:44 +00:00
commit-bot@chromium.org
c84fb471d1
Adds SkPDFResourceDict class to manage resource dicts. Refactors existing code to use this class.
...
BUG=
R=vandebo@chromium.org , edisonn@google.com
Author: richardlin@chromium.org
Review URL: https://chromiumcodereview.appspot.com/18977002
git-svn-id: http://skia.googlecode.com/svn/trunk@10202 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-19 18:58:34 +00:00
commit-bot@chromium.org
6645cde43d
Fix build problem with reverted issue 16948011
...
BUG=
R=caryclark@google.com
Author: sglez@google.com
Review URL: https://chromiumcodereview.appspot.com/19541009
git-svn-id: http://skia.googlecode.com/svn/trunk@10201 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-19 18:54:04 +00:00
bungeman@google.com
fc70a4ae59
Remove unneeded mention of SkThread_pthread.cpp in ports.gyp.
...
This was overlooked in r10105.
git-svn-id: http://skia.googlecode.com/svn/trunk@10200 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-19 18:51:10 +00:00
robertphillips@google.com
7ac13b7198
Reverting r10173 due to compile problems
...
git-svn-id: http://skia.googlecode.com/svn/trunk@10174 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-19 00:50:48 +00:00
commit-bot@chromium.org
0abc976e33
Measurement tool for Bounding-Box-Hierarchies.
...
BUG=
R=caryclark@google.com , reed@google.com
Author: sglez@google.com
Review URL: https://chromiumcodereview.appspot.com/16948011
git-svn-id: http://skia.googlecode.com/svn/trunk@10173 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-19 00:32:39 +00:00
reed@google.com
eed6f1b76b
pull mipmap class into its own (private) header
...
BUG=
R=scroggo@google.com
Review URL: https://codereview.chromium.org/19462007
git-svn-id: http://skia.googlecode.com/svn/trunk@10161 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-18 19:53:31 +00:00
egdaniel@google.com
a308883003
Add bench for hairline paths.
...
R=bsalomon@google.com
Review URL: https://codereview.chromium.org/19238003
git-svn-id: http://skia.googlecode.com/svn/trunk@10128 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-17 19:30:41 +00:00
zachr@google.com
d658568a82
make OpenCL optional for skpdiff
...
- add CPU based different pixels metric
R=djsollen@google.com
Review URL: https://codereview.chromium.org/19374006
git-svn-id: http://skia.googlecode.com/svn/trunk@10127 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-17 19:29:19 +00:00
commit-bot@chromium.org
56799e2ee6
Add the lazy decoder from PictureFlags to SkImageDecoder
...
R=caryclark@google.com , scroggo@google.com
Author: sglez@google.com
Review URL: https://chromiumcodereview.appspot.com/19109002
git-svn-id: http://skia.googlecode.com/svn/trunk@10111 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-16 18:21:46 +00:00
bungeman@google.com
f2e7dbb09f
Split TLS implementation into its own translation unit.
...
SkTLS has it's own header separate from SkThread, and having SkThread own
the platform implementation of SkTLS is problematic with Chromium. The
simplest way to clean this up is to put the implementation in its own set
of files, where it is also more easily found.
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/19240007
git-svn-id: http://skia.googlecode.com/svn/trunk@10105 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-16 14:59:24 +00:00
tfarina@chromium.org
883fe7f8b1
Move implementation of SkFilterShader into its source file.
...
Since SkFilterShader has its own header file, makes more sense to have a
separate source file to implement it rather than placing it in a "random"
SkColorFilter.cpp file.
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/19305004
git-svn-id: http://skia.googlecode.com/svn/trunk@10101 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-16 13:05:27 +00:00
robertphillips@google.com
736dd031f1
Move gaussianBlur functionality to src\effects
...
https://codereview.chromium.org/18771004/
git-svn-id: http://skia.googlecode.com/svn/trunk@10080 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-15 15:06:54 +00:00
humper@google.com
9c96d4b5ff
fix trivial matrix computation
...
Revert "Reverted 10056-10059"
This reverts commit bab4ebcaa7270c3b866a8e10917c39b055ebd51a.
Fix broken GM test, reintroduce image scaling.
BUG=
Review URL: https://codereview.chromium.org/18721006
git-svn-id: http://skia.googlecode.com/svn/trunk@10066 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-14 01:44:59 +00:00
commit-bot@chromium.org
42dacab4e7
Make GrPaint have a variable sized array of color and coverage stages rather than a fixed size.
...
R=robertphillips@google.com , jvanverth@google.com
Author: bsalomon@google.com
Review URL: https://chromiumcodereview.appspot.com/18686007
git-svn-id: http://skia.googlecode.com/svn/trunk@10062 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-13 17:24:24 +00:00
robertphillips@google.com
d647426714
Reverted 10056-10059
...
git-svn-id: http://skia.googlecode.com/svn/trunk@10060 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-13 15:37:25 +00:00
humper@google.com
d64d8a905a
Working plumb of image scaling:
...
1) always generate mipmaps if we detect that we are downsampling.
2) pre-scale the image if we detect that we are upsampling
(currently valid for scale+translate only)
3) A few miscellaneous bug fixes related to image scaling.
Still need SSE/Neon versions of these image scalers.
BUG=
R=bsalomon@google.com , robertphillips@google.com
Review URL: https://codereview.chromium.org/18978014
git-svn-id: http://skia.googlecode.com/svn/trunk@10056 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-12 21:14:33 +00:00
bungeman@google.com
f5cc5b140c
R=mtklein@google.com
...
Review URL: https://codereview.chromium.org/18503009
git-svn-id: http://skia.googlecode.com/svn/trunk@10050 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-12 18:22:49 +00:00
skia.committer@gmail.com
ebed410ac7
Sanitizing source files in Housekeeper-Nightly
...
git-svn-id: http://skia.googlecode.com/svn/trunk@10033 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-12 07:01:14 +00:00
humper@google.com
523521c6bc
reenable the scale benchmark, and only bench actual canvas draw commands
...
instead of direct invocations of the (now private) bitmap scale method
BUG=
R=reed@google.com
Review URL: https://codereview.chromium.org/18941009
git-svn-id: http://skia.googlecode.com/svn/trunk@10027 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-11 20:28:30 +00:00
borenet@google.com
e2b9037c40
Disable soft floating point on ChromeOS
...
Should fix the Daisy build.
R=djsollen@google.com
Review URL: https://codereview.chromium.org/18812006
git-svn-id: http://skia.googlecode.com/svn/trunk@10020 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-11 18:46:30 +00:00
edisonn@google.com
d1a874aaa8
(unreviewed) sample app: fix break in pdf viewer (podofo was replaced by native parser)
...
Review URL: https://codereview.chromium.org/18507004
git-svn-id: http://skia.googlecode.com/svn/trunk@10007 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-11 14:45:20 +00:00
edisonn@google.com
f8b6b01d51
Add an option to have a PdfViewer in SampleApp. Add a parameter --pdfDir to pass the dir with pdfs. Add flag --sort to sort samples acording to title, so foo.skp follows foo.pdf and we can quickly compare diffs.
...
The option needs to be enabled manually by developer to be compiled locally, since the pdf viewer is work in progress.
R=reed@google.com
Review URL: https://codereview.chromium.org/17904006
git-svn-id: http://skia.googlecode.com/svn/trunk@10004 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-11 14:28:04 +00:00
commit-bot@chromium.org
183f7f56b8
ARM Skia NEON patches - 10 - ARM build
...
ARM-Build: make Linux arm/NEON builds possible
This factorizes the definitions common to Linux & assimilated
and Android. It also enables to do native builds on Linux for
ARM processors.
BUG=
R=djsollen@google.com , borenet@google.com
Author: kevin.petit.arm@gmail.com
Review URL: https://chromiumcodereview.appspot.com/18243007
git-svn-id: http://skia.googlecode.com/svn/trunk@9997 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-11 12:48:14 +00:00
edisonn@google.com
a5aaa7998f
pdfviewer: measure mem usage, command line flags library.
...
Review URL: https://codereview.chromium.org/18562010
git-svn-id: http://skia.googlecode.com/svn/trunk@9996 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-11 12:27:21 +00:00
edisonn@google.com
222382b30a
pdf viewer: refactor, add -w parameter to pdfviewer, add -n to remove extenassion page when there is a single page (so skdiff can be run easily) and fix a bug (SkPdfobject should not reset on destruct)
...
Review URL: https://codereview.chromium.org/18435007
git-svn-id: http://skia.googlecode.com/svn/trunk@9983 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-10 22:33:10 +00:00
edisonn@google.com
596d2e26cd
pdf viewer: fix a few warnings, and enable warning as errors
...
Review URL: https://codereview.chromium.org/18293012
git-svn-id: http://skia.googlecode.com/svn/trunk@9966 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-10 17:44:55 +00:00
edisonn@google.com
571c70b95f
Native PDF parser implementation - don't try it on pdfs that are not generated by skia, Crome Print Preview or Chrome Save As Pdf - it will crash as mising xref, pdfs with updates, and other features are not supported yer.
...
Review URL: https://codereview.chromium.org/18323019
git-svn-id: http://skia.googlecode.com/svn/trunk@9962 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-10 17:09:50 +00:00
humper@google.com
b088947f27
New bitmap filter checkin; this time with less build breakage
...
BUG=
Review URL: https://codereview.chromium.org/18942002
git-svn-id: http://skia.googlecode.com/svn/trunk@9944 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-09 21:37:14 +00:00
commit-bot@chromium.org
b686539ab5
Added GM and Bench
...
Added GM's and Bench
Added GM file nate_gradients.cpp
BUG=
R=reed@google.com , bsalomon@google.com
Author: dierk@google.com
Review URL: https://chromiumcodereview.appspot.com/18259012
git-svn-id: http://skia.googlecode.com/svn/trunk@9938 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-09 19:43:29 +00:00
humper@google.com
1a8940e558
Revert "More general image filter interface; tested implementation of standalone"
...
This reverts commit 4df3e8b079e019af5f60c13e7e6ec6589663962a.
git-svn-id: http://skia.googlecode.com/svn/trunk@9937 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-09 18:02:06 +00:00
humper@google.com
25fc6b9bfb
More general image filter interface; tested implementation of standalone
...
image scaler (not yet plumbed). High quality downsampler. Fast SSE
resampler.
BUG=
R=reed@google.com
Review URL: https://codereview.chromium.org/17381008
git-svn-id: http://skia.googlecode.com/svn/trunk@9936 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-09 17:48:15 +00:00
robertphillips@google.com
e1b75b4096
GM (and fix) for drawArc capping issue
...
https://codereview.chromium.org/18271003/
git-svn-id: http://skia.googlecode.com/svn/trunk@9928 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-09 15:03:59 +00:00