Commit Graph

1360 Commits

Author SHA1 Message Date
joshualitt
812c0283b9 rebase + ignores
NOTRY=True
TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/841873007
2015-01-13 18:54:01 -08:00
joshualitt
9b7eb11253 rebase of expectations
TBR=
NOTRY=True
BUG=skia:

Review URL: https://codereview.chromium.org/847313002
2015-01-13 17:50:27 -08:00
fmalita
c3796c7a74 Generic PDF shader fallback
Instead of ignoring unsupported shaders (and essentially filling with
solid black), convert them to bitmap shaders using on-the-fly
rasterization.

BUG=skia:3299
R=reed@google.com,halcanary@google.com

Review URL: https://codereview.chromium.org/841763005
2015-01-13 08:06:11 -08:00
robertphillips
125ee60ed3 Revert of Fix GPU clipped-AA vs. non-AA drawRect discrepancy (patchset #2 id:20001 of https://codereview.chromium.org/839883003/)
Reason for revert:
This CL introduces rendering conflicts with hairlines (i.e., the hairlines get overwritten). These conflicts are particularly visible on the following GMs (for the Ubuntu and Android gpu configs):

coloremoji & complexclip2_rrect_bw

Original issue's description:
> Fix GPU clipped-AA vs. non-AA drawRect discrepancy
>
> In the clip stack we were manually rounding out non-AA clip rects but leaving the hardening of non-AA drawRects up to the GPU. In some border cases the GPU can truncate rather than round out resulting in visual discrepancies.
>
> BUG=423834
>
> Committed: https://skia.googlesource.com/skia/+/933a03fecb65c83f81cf65d5cf9870c69aa379ff

TBR=bsalomon@google.com,jvanverth@google.com
NOTREECHECKS=true
NOTRY=true
BUG=423834

Review URL: https://codereview.chromium.org/847033002
2015-01-12 18:26:01 -08:00
robertphillips
933a03fecb Fix GPU clipped-AA vs. non-AA drawRect discrepancy
In the clip stack we were manually rounding out non-AA clip rects but leaving the hardening of non-AA drawRects up to the GPU. In some border cases the GPU can truncate rather than round out resulting in visual discrepancies.

BUG=423834

Review URL: https://codereview.chromium.org/839883003
2015-01-12 15:50:38 -08:00
reed
15bfc6ce44 rebaseline after conic change
BUG=skia:
TBR=
NOTRY=True

Review URL: https://codereview.chromium.org/840333002
2015-01-09 08:36:43 -08:00
reed
9250543c55 rebaseline NexusPlayer after conic fix
BUG=skia:
TBR=
NOTRY=True

Review URL: https://codereview.chromium.org/843063003
2015-01-09 06:36:49 -08:00
halcanary
aa6286e8ec rebaseline after crrev.com/840653002
NOTRY=true
TBR=

Review URL: https://codereview.chromium.org/838183003
2015-01-08 12:36:30 -08:00
reed
00e0814a49 rebaseline after change to GM:c_gms
BUG=skia:
TBR=
NOTRY=True

Review URL: https://codereview.chromium.org/843843002
2015-01-08 11:08:36 -08:00
reed
9558f65387 rebaseline after changing GM
BUG=skia:
TBR=
NOTRY=True

Review URL: https://codereview.chromium.org/843553003
2015-01-08 08:02:50 -08:00
reed
281ecc27ee need to rebaseline (changed) c_gms, update dox
BUG=skia:
TBR=
NOTRY=True

Review URL: https://codereview.chromium.org/844663002
2015-01-07 18:20:16 -08:00
egdaniel
c56fb00373 Rebasing more conic stuff
TBR=
NOTRY=True
NOTREECHECKS=True
BUG=skia:

Review URL: https://codereview.chromium.org/837913002
2015-01-07 07:26:40 -08:00
reed
2d7c17b0b1 rebaseline after use-conics
BUG=skia:
TBR=
NOTRY=True
NOTREECHECKS=True

Review URL: https://codereview.chromium.org/800193004
2015-01-07 07:04:09 -08:00
egdaniel
0f3dfd0085 More rebases from conic change
TBR=
NOTRY=True
NOTREECHECKS=True
BUG=skia:

Review URL: https://codereview.chromium.org/841693003
2015-01-07 06:51:02 -08:00
reed
d0949088ff rebaseline after use-conics
BUG=skia:
TBR=
NOTRY=True
NOTREECHECKS=True

Review URL: https://codereview.chromium.org/841703002
2015-01-07 06:08:50 -08:00
reed
9810cd25ce use conics for ovals and roundrects
This reverts commit e3b61eb799.

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/834303002
2015-01-06 16:26:16 -08:00
reed
b5bd9c113e rebaseline after conic fixes
BUG=skia:
TBR=
NOTRY=True

Review URL: https://codereview.chromium.org/831993004
2015-01-06 09:55:34 -08:00
reed
e3b61eb799 Revert of use conics for ovals and roundrects (patchset #1 id:1 of https://codereview.chromium.org/817283005/)
Reason for revert:
need fix in edgebuilder+aa

Original issue's description:
> use conics for ovals and roundrects
>
> adapted from https://codereview.chromium.org/831313002/
>
> BUG=skia:
> TBR=
>
> Committed: https://skia.googlesource.com/skia/+/2bf1c4d58b84c73c6421edcb25e3afb4971da200

TBR=reed@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/840573002
2015-01-06 07:17:49 -08:00
reed
e0d5a27970 Revert of add missed tests for conics (patchset #1 id:1 of https://codereview.chromium.org/835993004/)
Reason for revert:
need to fix edgebuilder+aa

Original issue's description:
> add missed tests for conics
>
> BUG=skia:
> TBR=
> NOTRY=True
> NOTREECHECKS=True
>
> Committed: https://skia.googlesource.com/skia/+/6b0f701687edcdfc4fc996aed085054912866aff

TBR=reed@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/797403003
2015-01-06 07:12:42 -08:00
reed
6b0f701687 add missed tests for conics
BUG=skia:
TBR=
NOTRY=True
NOTREECHECKS=True

Review URL: https://codereview.chromium.org/835993004
2015-01-05 21:01:40 -08:00
reed
2bf1c4d58b use conics for ovals and roundrects
adapted from https://codereview.chromium.org/831313002/

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/817283005
2015-01-05 20:15:28 -08:00
fmalita
4dd6b72b31 Rebaseline thinstrokedrects GM
BUG=skia:3278
TBR=caryclark@google.com
NOTRY=true

Review URL: https://codereview.chromium.org/836023002
2015-01-05 16:10:38 -08:00
egdaniel
8aa5b8f852 Rebase perspective gpu gm's after conic change
TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/831333002
2015-01-05 12:55:46 -08:00
fmalita
b280646beb Fix thin rect stroking.
When both edges of a thin (sub-unit) stroke fall within the same pixel, we compute the wrong coverage and also blit the same line twice.

To avoid these issues, tweak the inner/outer hulls to ensure one of the edges is always pixel-aligned.

BUG=skia:3278
R=reed@google.com

Review URL: https://codereview.chromium.org/819253003
2015-01-05 11:31:02 -08:00
joshualitt
9face9b67c removing dashcubics from ignore, may cause failures
NOTRY=True
TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/834673004
2015-01-05 08:34:28 -08:00
robertphillips
55374058b3 Rebaseline complexclip2_rect_aa & simpleaaclip_rect GMs for the S4
I believe these are left over from https://codereview.chromium.org/822483003/ (rebase)

TBR=joshualitt@google.com

Review URL: https://codereview.chromium.org/828973002
2014-12-31 11:28:29 -08:00
robertphillips
958e33e108 Rebaseline lagging K1 GMs
The Nexus9 took a break from 12/20/14 until 12/30/14. This updates the GMs for all the changes during that time. Except for the changes due to https://codereview.chromium.org/834503002/ (Update stroke path to use rect returned from isRect (to fix trailing moveTo bug)), in which a GM was changed, they are all imperceptible.

TBR=bsalomon@google.com

Review URL: https://codereview.chromium.org/831953002
2014-12-31 09:52:09 -08:00
robertphillips
72238504df Rebaselines after "Fix computation of bound in FillBounds::updateSaveBounds"
The CL in question impacted the size of the hoisted layers and thus impacted the image results for the MPD GMs (for the GPU configs).

TBR=bsalomon@google.com

Review URL: https://codereview.chromium.org/827423003
2014-12-31 09:41:22 -08:00
reed
27b7160189 ignore failure -- pdf gradients on mac-mini
BUG=skia:
TBR=
NOTRY=True

Review URL: https://codereview.chromium.org/810653004
2014-12-31 08:27:52 -08:00
reed
f0d6258012 rebaseline after GM change
BUG=skia:
TBR=
NOTRY=True

Review URL: https://codereview.chromium.org/794833003
2014-12-31 08:23:20 -08:00
joshualitt
d5e9871357 rebase
TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/822483003
2014-12-30 07:04:17 -08:00
robertphillips
944a32a09e Update stroke-fill GM baselines
TBR=bsalomon@google.com

Review URL: https://codereview.chromium.org/827243002
2014-12-30 06:06:20 -08:00
robertphillips
4f662e62cd Update stroke path to use rect returned from isRect (to fix trailing moveTo bug)
This basically recreates what was done in:

https://codereview.chromium.org/16950021/ (add rect-output parameter to isRect, allowing us to return the correct bounds even if a rectagular path has a trailing moveTo) with the addition of GM representation

BUG=skia:247770

Review URL: https://codereview.chromium.org/834503002
2014-12-29 14:06:51 -08:00
joshualitt
d27f73ef27 Remove coordchanges from drawstate
BUG=skia:

Review URL: https://codereview.chromium.org/818233002
2014-12-29 07:43:36 -08:00
reed
3442111110 mark c_gms to be rebaselined (gm updated)
BUG=skia:
TBR=
NOTRY=True

Review URL: https://codereview.chromium.org/820303002
2014-12-25 16:40:13 -08:00
jvanverth
0e9ab4e3db Add baselines for Tegra2 complexclip* GMs.
They look bad, so marked as failure-ignored and tagged with a bug #.

BUG=skia:3273
TBR=bsalomon@google.com

Review URL: https://codereview.chromium.org/800523003
2014-12-23 09:19:59 -08:00
jvanverth
dfce876ec6 Lay down baselines for complexclip_*_invert and complexclip3_*.
TBR=bsalomon@google.com

Review URL: https://codereview.chromium.org/821093007
2014-12-23 08:34:01 -08:00
joshualitt
b1c6843af9 ignoring imageblur2 on galaxy
NOTRY=True
TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/816893003
2014-12-22 18:20:31 -08:00
joshualitt
f3c770b160 rebase
TBR=
NOTRY=True
BUG=skia:

Review URL: https://codereview.chromium.org/818163002
2014-12-22 17:29:33 -08:00
joshualitt
8fc6c2d82c This CL cleans up the last remaining users of localCoordChange on paint
NOTREECHECKS=True
BUG=skia:

Review URL: https://codereview.chromium.org/817853002
2014-12-22 15:27:05 -08:00
reed
1b542da4cd initial baselines for new GMs
BUG=skia:
TBR=
NOTRY=True

Review URL: https://codereview.chromium.org/816453007
2014-12-22 13:07:36 -08:00
reed
ebc11635e4 rebaseline after gradient fix
BUG=skia:
TBR=
NOTRY=True

Review URL: https://codereview.chromium.org/821703002
2014-12-22 07:22:20 -08:00
reed
fb4aca9ce6 rebaseline after gradient fix
BUG=skia:
TBR=
NOTRY=True

Review URL: https://codereview.chromium.org/794963004
2014-12-22 06:39:42 -08:00
reed
e0489c9766 suppress testimagefilters-gpu on 10.9 for now
BUG=skia:3269
TBR=
NOTRY=True

Review URL: https://codereview.chromium.org/823603002
2014-12-22 06:30:41 -08:00
djsollen
818361b3cb remove suppression as all GMs have been rebased or were uneffected.
Review URL: https://codereview.chromium.org/807653003
2014-12-22 06:26:47 -08:00
reed
ac6692b606 rebaseline
BUG=skia:
TBR=
NOTRY=True

Review URL: https://codereview.chromium.org/816383002
2014-12-22 06:06:38 -08:00
reed
eeb4e26093 unsuppress after rebaselining
BUG=skia:
TBR=
NOTRY=True

Review URL: https://codereview.chromium.org/824703002
2014-12-22 05:52:30 -08:00
reed
5394d69a09 rebaselines for obsolete suppressions
BUG=skia:
TBR=
NOTRY=True

Review URL: https://codereview.chromium.org/822723002
2014-12-22 05:51:36 -08:00
reed
4a2a17dc83 unsuppress after rebaselining
BUG=skia:
TBR=
NOTRY=True

Review URL: https://codereview.chromium.org/824693002
2014-12-22 05:20:11 -08:00
joshualitt
f53ff623fa rebase coloremoji
NOTRY=True
TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/822553002
2014-12-20 10:30:09 -08:00