Commit Graph

56302 Commits

Author SHA1 Message Date
Chris Dalton
50516f3db8 Add a robust "isinf" workaround for tessellation
When isinf is not supported, we simply add another instanced attrib that
tells the shader exactly what type of curve it's dealing with.

Bug: chromium:1220246
Change-Id: I3496de674ce8c7df205e3c40559ae89dc29488e1
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429676
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2021-07-19 16:03:39 +00:00
Eric Boren
8f553a769b [infra] Fix RecreateSKPs after assets update
Change-Id: I13ae7034cda4291743f433406ee2e8267dd48d3e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/416576
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
2021-07-19 14:13:09 +00:00
Brian Osman
3c1c4c0d25 Standardize strings and other cleanup in bloaty_treemap.py
Follow-up from reviews.skia.org/428959

Change-Id: I3a9baaf1744dcfcea372c5a0c73af31912888c0c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429818
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2021-07-19 14:01:30 +00:00
Mike Reed
95cc53bafd Hide filterquality enum entirely
Introduce private SkLegacyFQ to allow us to continue deserializing
old content with filter-qualities, but still remove the public enum.

Need to finish removing references in clients.

Change-Id: Iacfb602ec497260e53defc4b95e297ed1ef4e69c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429476
Auto-Submit: Mike Reed <reed@google.com>
Commit-Queue: Florin Malita <fmalita@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
2021-07-19 12:34:50 +00:00
recipe-roller
230a2514d6 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
0202156442
  0202156 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 56d8faf61a03 to 175b811c1eeb

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id3c9af7172825acd539e5bcda57ce7478a0b4932
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429736
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2021-07-19 05:52:29 +00:00
skia-autoroll
1748bddbc0 Roll Chromium from a9426b211cb3 to 699b730a7601 (553 revisions)
a9426b211c..699b730a76

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-skia-autoroll
Please CC ethannicholas@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Perf-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Release-All-CommandBuffer;skia/skia.primary:Test-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Debug-All-CommandBuffer
Tbr: ethannicholas@google.com
Change-Id: Ic431824bf1041d04596346345c5f1690252cc2f1
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429717
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-07-19 05:18:38 +00:00
skia-autoroll
52d6bd4974 Roll ANGLE from 397fc145b8b3 to 4d9e1f230fa7 (17 revisions)
397fc145b8..4d9e1f230f

2021-07-19 cnorthrop@google.com More skips for GLSLTest_ES31.TypesUsedInDifferentBlockStorages
2021-07-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from ec932ff42c9b to ac347590d69b (492 revisions)
2021-07-17 timvp@google.com Call getNearestSamples() in Framebuffer::setAttachment()
2021-07-16 cnorthrop@google.com Skip GLSLTest_ES31.TypesUsedInDifferentBlockStorages AMD Linux
2021-07-16 ianelliott@google.com Two fixes to DevSetup.md
2021-07-16 geofflang@chromium.org Remove the explicit context extension.
2021-07-16 syoussefi@chromium.org Vulkan: SPIR-V Gen: Support bool in interface blocks
2021-07-16 jmadill@chromium.org Vulkan: Prefer the local vulkan loader over the system one.
2021-07-16 jmadill@chromium.org Capture/Replay tests: Enable dcheck_always_on.
2021-07-16 lunpujun@google.com Avoid recreating activity when rotating the display.
2021-07-16 jmadill@chromium.org Capture/Replay: Don't try to serialize compressed textures.
2021-07-16 jmadill@chromium.org Capture/Replay Tests: Swap before TearDown.
2021-07-16 gert.wollny@collabora.com Capture/Replay: Capture WaitSemaphore and SignalSemaphore
2021-07-16 gert.wollny@collabora.com Capture/Replay: redesign capturing of arrays passed by pointer
2021-07-16 gert.wollny@collabora.com tests: GL_NUM_BINARY_FORMATS is a ES 3.0 property
2021-07-16 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 8cd71c4b8d72 to ec932ff42c9b (494 revisions)
2021-07-16 gert.wollny@collabora.com Capture/Replay: Capture FenceNV parameters

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-skia-autoroll
Please CC ethannicholas@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE
Tbr: ethannicholas@google.com
Test: Test: MultisampledRenderToTextureTest.FramebufferCompletenessSmallSampleCount
Change-Id: I9807c9bf425e212cb18520cf45ce965025435d0b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429716
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-07-19 05:09:59 +00:00
Mike Reed
1f261da41e Stop using filterquality
Change-Id: I0fd8ace529cde3b36df72dd4d80bba18c1388b20
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429497
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2021-07-18 15:48:36 +00:00
Mike Reed
f02aa80ba9 Remove dead code (and dead subclass)
note: our min picture-version dates from 2020
Change-Id: I5b9d2e8a13afd16fe5b3ae88f9747f0da4382d29
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/428196
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2021-07-18 12:18:16 +00:00
skia-autoroll
8837c919fb Roll SK Tool from 48c8dccc29e0 to fba7eb859cc7
https://skia.googlesource.com/buildbot.git/+log/48c8dccc29e0..fba7eb859cc7

2021-07-18 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update CIPD Packages

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/sk-tool-skia
Please CC rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: rmistry@google.com
Change-Id: Icfdc1b1ffdaec4b0162ebd2f3e53921f67f2a2eb
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429516
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-07-18 06:47:55 +00:00
Herb Derby
3d49efa8e1 draw vertices: rename textures -> texCoords
Bug=skia:11822

Change-Id: I97c74658eb46704ba6d3b1ea2aa53f76eb869241
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429416
Reviewed-by: Herb Derby <herb@google.com>
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2021-07-17 21:03:33 +00:00
Mike Reed
01e6273c46 rm flutter support for filterquality
Change-Id: Ibcae9d2378d136ce15e3284f679e71b42f1ba32d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429337
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2021-07-17 14:39:38 +00:00
Mike Reed
11a20bbbf4 rm getblendmode flag for flutter
Change-Id: Id578c5dbf7f0f4274d43b3ae8a7cfb50d3563cc3
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429376
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2021-07-17 13:53:45 +00:00
Chris Dalton
7c79a871c0 Run dmsaa on ANGLE es3 bots
Bug: skia:11396
Change-Id: I4d8253e61e6458b21b4e851e0b77d220394ea65d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429040
Reviewed-by: John Stiles <johnstiles@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2021-07-17 04:18:32 +00:00
Mike Reed
c82ab0839f Stop using filterquality
Change-Id: I67d1a464618f1a54f4e3bd4e1409b1d91a90e66a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429336
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2021-07-17 03:11:32 +00:00
Mike Reed
2bdf6ed96f Stop using SkFilterQuality
Change-Id: Ief80d125eacb5922b95ab16ebc8d6b483469ada7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429097
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2021-07-17 01:55:42 +00:00
skia-autoroll
fb0440e5bc Roll SK Tool from 3bbeaa205257 to d2ac68f66d91
https://skia.googlesource.com/buildbot.git/+log/3bbeaa205257..d2ac68f66d91

2021-07-16 rmistry@google.com Add SkCQ for buildbot repo

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/sk-tool-skia
Please CC rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: rmistry@google.com
Change-Id: I1966a278963600ac7216c7e9a1598eb00798e300
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429143
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-07-17 00:19:22 +00:00
recipe-roller
fe5d07a8e4 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (depot_tools, recipe_engine) into this repository.

depot_tools:
92c396e45d
  92c396e (bryner@google.com)
      cpython3 3.8.10.chromium.20 to depot_tools bleeding edge.

recipe_engine:
3a8a334ce1
  3a8a334 (yiwzhang@google.com)
      engine: upgrade third-party library

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib006689370e25ea2ccb273762520456f95ed710b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429041
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2021-07-16 23:09:32 +00:00
Chris Dalton
528673a7ae Work around a Mac compiler bug with "!isinf()"
Bug: skia:12219
Change-Id: I877cece94305bcec0c36d94643f4ad17a811ae7a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429296
Reviewed-by: John Stiles <johnstiles@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2021-07-16 22:46:02 +00:00
John Stiles
9671d0aa31 Add checkbox to Viewer to force-enable Runtime Blends.
In a perfect world, this should always render the same, just perhaps a
bit more slowly.

Change-Id: I750ad43142d4d192be4db7396989d978025179a8
Bug: skia:12080
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429101
Commit-Queue: John Stiles <johnstiles@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2021-07-16 21:11:28 +00:00
recipe-roller
8c3adb8b1a Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (depot_tools) into this repository.

depot_tools:
a3d1aaf112
  a3d1aaf (sokcevic@google.com)
      Revert "[depot_tools] Add --fork-point when computing merge-base"

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia6095dc83dee3c1dbbde615cc1e6cf50e25b9152
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429039
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2021-07-16 19:44:02 +00:00
Chris Dalton
3b7ec0fa0f Remove unused variables
These presented as warnings while compiling on Applie silicone.

Change-Id: Icfcd2b0ad163a8bb429d81354b628ca00b0c1a8d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429137
Auto-Submit: Chris Dalton <csmartdalton@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Reviewed-by: Herb Derby <herb@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
2021-07-16 19:40:02 +00:00
John Stiles
67b1b2a105 Fix fuzzer-discovered undefined behavior with NaN.
The fuzzer passed in a point with a Y coordinate of NaN; this eventually
caused an integer overflow while attempting to calculate
`SK_MaxS32FitsInFloat << 2`. We now detect the NaN and return false.

Change-Id: I79e51190006bce5e2c42935e1075261a3e16aa6d
Bug: oss-fuzz:36198
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429099
Auto-Submit: John Stiles <johnstiles@google.com>
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
2021-07-16 19:38:42 +00:00
Jim Van Verth
3339e570a1 Metal: use ResourceProvider for MSAA creation.
Also fixes GPU sizes to use new attachment scheme.

Bug: skia:12186
Change-Id: I4259cd26ac6b41eeda3a6d8bb42e1f283ae9e4d3
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429197
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
2021-07-16 17:41:45 +00:00
recipe-roller
226a7cd7c1 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (depot_tools) into this repository.

depot_tools:
f6f3c7a46e
  f6f3c7a (johannkoenig@google.com)
      [docs] update links to developer guide

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I59d206123921e70a3612b6e596eadc25733b8d7a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429038
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2021-07-16 17:24:33 +00:00
Jim Van Verth
94fda947eb Reland "Fix directional shadows."
This is a reland of 6789b82401

Original change's description:
> Fix directional shadows.
>
> The xy offset calculation for drawShadow was not quite correct. Rather
> than normalizing the light vector and using the xy values of that as the
> base offset value, we should scale the light vector by 1/z.
>
> See https://github.com/flutter/engine/pull/27124#issuecomment-880182653
> for more detail.
>
> Bug: skia:10781
> Change-Id: Ib69a313cb96a532f8d89644e3d69f666a184e897
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/428880
> Reviewed-by: Brian Salomon <bsalomon@google.com>
> Commit-Queue: Jim Van Verth <jvanverth@google.com>

Bug: skia:10781
Change-Id: Ib58d374aa03d0144512e5ded6ccd572c74783607
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/428978
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
2021-07-16 16:49:52 +00:00
Ben Wagner
126002c27d Update minimum Linux versions
With M93 Chromium is dropping support for older Linux distributions.
The new minimum requirements are Ubuntu 18.04+, Debian 10+,
openSUSE 15.2+, or Fedora Linux 32+. Update Skia's minimum requirements
to match.

Change-Id: I280a0790d4ee4d803bc15e2e29828be692ea934e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/428983
Commit-Queue: Ben Wagner <bungeman@google.com>
Commit-Queue: Heather Miller <hcm@google.com>
Reviewed-by: Heather Miller <hcm@google.com>
2021-07-16 16:20:26 +00:00
Jorge Betancourt
5514beaf3b [androidkit] bind SkImageFilters to java shared library
SkImageFilter::image
SkImageFilter::blend
SkImageFilter::dropShadow
Change-Id: Ie8cce8a06a2f50b2b3c905097740cc10b91a6c86
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/428577
Commit-Queue: Jorge Betancourt <jmbetancourt@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
2021-07-16 16:18:55 +00:00
Ethan Nicholas
459777a1a4 Added AssertDSLObjectsReleased setting
Change-Id: Ia63f892305c2347e55560141880a0b6a124b84f6
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429196
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
Reviewed-by: John Stiles <johnstiles@google.com>
2021-07-16 16:13:35 +00:00
Chris Dalton
b22b41d55a Quit using atan(y,x) in stroke tessellation shaders
SwiftShader has a bug in atan(y,x), and it turns out we have the data
already available to compute the angle we need in a different way.

Bug: skia:12217
Bug: chromium:1229486
Bug: b/193856577
Change-Id: I9b2c5fca3b0495f034c379c79e82de75e255abc6
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429136
Auto-Submit: Chris Dalton <csmartdalton@google.com>
Reviewed-by: Justin Novosad <junov@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2021-07-16 16:04:55 +00:00
Heather Miller
44cd93f4fa update release notes
Change-Id: Ida17b9d3da4d3a6489f62d2959379747a671fbab
Docs-Preview: https://skia.org/?cl=428982
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/428982
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Reviewed-by: Heather Miller <hcm@google.com>
Commit-Queue: Heather Miller <hcm@google.com>
Auto-Submit: Heather Miller <hcm@google.com>
2021-07-16 16:03:35 +00:00
John Stiles
f2de1b8b4d Fix crash when drawing a GPU-backed surface onto raster.
We now null-check the result of recordingContext() before using it.

Thanks cqjjjzr2@gmail.com for the initial discovery and suggested fix.

Change-Id: Iafcf306f8cd9deb7147ef9c5c71a21907eedc01f
Bug: skia:12214
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429098
Commit-Queue: John Stiles <johnstiles@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2021-07-16 15:12:43 +00:00
Ethan Nicholas
b18c1e2c27 DSL ReleaseProgram retains source and reports errors better
Change-Id: Id5923e1c1404bddf7f7da7d04bd91721ab637322
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429096
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
Reviewed-by: John Stiles <johnstiles@google.com>
2021-07-16 14:45:55 +00:00
Heather Miller
d970d81ea6 update Skia milestone to 94
Change-Id: I3bd0a1b856146172ef38c6392fdd9252480ae928
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/428980
Reviewed-by: Heather Miller <hcm@google.com>
Commit-Queue: Heather Miller <hcm@google.com>
2021-07-16 14:44:15 +00:00
recipe-roller
657e375a16 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (depot_tools) into this repository.

depot_tools:
5eebf6fa78
  5eebf6f (mmoss@google.com)
      Add docstrings so gerrit_client subcommands display properly.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I09fb49a2e344e2bfedbe1a4d3f5cac5cf7249201
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429037
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2021-07-16 14:09:25 +00:00
skia-autoroll
385e0d77be Roll Chromium from 17781a5cd82e to a9426b211cb3 (504 revisions)
17781a5cd8..a9426b211c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-skia-autoroll
Please CC johnstiles@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Perf-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Release-All-CommandBuffer;skia/skia.primary:Test-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Debug-All-CommandBuffer
Tbr: johnstiles@google.com
Change-Id: I8bfb1706c4274d3b9c4c29ce0ca40bc2af4fccd9
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/428947
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-07-16 05:07:24 +00:00
skia-autoroll
2cad46c88a Roll ANGLE from db54b8dd65ed to 397fc145b8b3 (12 revisions)
db54b8dd65..397fc145b8

2021-07-16 jiajia.qin@intel.com Fix the ext-texture-norm16 with RG16 failures
2021-07-15 jonahr@google.com Enable SwANGLE on ozone headless
2021-07-15 thomasanderson@chromium.org [GLX] Allow usage of multiple visuals
2021-07-15 syoussefi@chromium.org Vulkan: SPIR-V Gen: Assignment between mismatching SPIR-V types
2021-07-15 syoussefi@chromium.org Vulkan: SPIR-V Gen: Support row-major blocks
2021-07-15 ynovikov@chromium.org Skip DrawRepeatUnalignedVboChange on Mac ARM Metal
2021-07-15 jmadill@chromium.org GL-CTS: Add option to run on D3D11 refrast.
2021-07-15 cnorthrop@google.com Vulkan: Suppress VVL errors triggered by external formats
2021-07-15 m.maiya@samsung.com Add YUV format utils and validation code
2021-07-15 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from a03f2d365426 to 7c4121a2cfd0 (1 revision)
2021-07-15 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 47358b0400b8 to 8cd71c4b8d72 (448 revisions)
2021-07-15 timvp@google.com Capture/Replay: Refactor shared context handling

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-skia-autoroll
Please CC johnstiles@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE
Tbr: johnstiles@google.com
Test: Test:
Test: Test: Manual MEC and replay of Magic Tiles 3, Candy Crush Soda Saga, Temple Run 2
Change-Id: Ia88c77c9012f51855b58dcc83a5cdc7e5267f3af
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/428948
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-07-16 05:03:34 +00:00
recipe-roller
e2a9bdfba4 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
a415797adb
  a415797 (yiwzhang@google.com)
      logging: fix logging level where more verbose indicates Debug l...

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I298b5c740659fa54ff15797874645a23935c8719
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429020
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2021-07-16 02:57:54 +00:00
recipe-roller
763be55a9e Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
37fe06bd5a
  37fe06b (yiwzhang@google.com)
      py3: encode logdog namespace when supplied as env var

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I2841284c2bec7a8e48039ac4c5b901809d7424cc
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429019
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2021-07-16 01:47:25 +00:00
Chris Dalton
24f6879422 Run dmsaa on all supported Mac and SwiftShader bots
Bug: skia:11396
Change-Id: I02b733d348c0e1fafb3d05eb14d06d15faf86b07
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429057
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2021-07-15 22:11:45 +00:00
John Stiles
55f0d7acfa Always enforce format specifiers on SkDebugf.
Change-Id: Icba60060ab4dec45c8ef1b1e2f35056626adc0a7
Bug: skia:12143, 192062380
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/428616
Commit-Queue: John Stiles <johnstiles@google.com>
Reviewed-by: Derek Sollenberger <djsollen@google.com>
2021-07-15 20:11:24 +00:00
Greg Daniel
63fd35484e Move GrGLAttachment to a factory model similar to other backends.
Bug: skia:12215
Change-Id: Ibd8d46c8e36bbde6a15f214dfc376622509dc199
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/428976
Commit-Queue: Greg Daniel <egdaniel@google.com>
Reviewed-by: Jim Van Verth <jvanverth@google.com>
2021-07-15 19:51:41 +00:00
Chris Dalton
33d24414eb Don't call GrSurfaceDrawContext::setNeedsStencil until after splits
We used to call setNeedsStencil before potential opsTask splits due to
dst reads. This caused the code to assume the stencil was getting
cleared when it actually wasn't. This CL updates the code to not call
setNeedsStencil until all splits are finished.

Bug: skia:12153
Change-Id: I3eb973b77929677b2535e461948b73e93ee29111
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/428696
Auto-Submit: Chris Dalton <csmartdalton@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2021-07-15 19:42:45 +00:00
Brian Osman
060dd70d2c Add bloaty_treemap.py, for visualizing bloaty data
There is so much more that could be done here (some ideas in TODO
comments), but this greatly streamlines the process for average
developers to navigate the code-size of skia executables.

Currently, I'm using a locally built copy of bloaty, but we should see
about using DEPS or adding a fetch-able package to eliminate even more
friction.

Change-Id: I92186c0370a1ab8d2c8edd73932547402c43612d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/428959
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2021-07-15 19:32:04 +00:00
recipe-roller
78aa969b2f Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
df371124b4
  df37112 (yiwzhang@google.com)
      py3: make a few more modules python3 compatible

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I0e1664b1781699caff7398116f98343b5f4aeba5
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429016
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2021-07-15 18:39:05 +00:00
Jim Van Verth
3c8ae888b9 Revert "Fix directional shadows."
This reverts commit 6789b82401.

Reason for revert: Failing CK test.

Original change's description:
> Fix directional shadows.
>
> The xy offset calculation for drawShadow was not quite correct. Rather
> than normalizing the light vector and using the xy values of that as the
> base offset value, we should scale the light vector by 1/z.
>
> See https://github.com/flutter/engine/pull/27124#issuecomment-880182653
> for more detail.
>
> Bug: skia:10781
> Change-Id: Ib69a313cb96a532f8d89644e3d69f666a184e897
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/428880
> Reviewed-by: Brian Salomon <bsalomon@google.com>
> Commit-Queue: Jim Van Verth <jvanverth@google.com>

TBR=jvanverth@google.com,bsalomon@google.com

Change-Id: Id22c2113fc1b62109975b83a0dcda5b1b16380a8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:10781
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/428977
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
2021-07-15 17:53:35 +00:00
Jim Van Verth
6789b82401 Fix directional shadows.
The xy offset calculation for drawShadow was not quite correct. Rather
than normalizing the light vector and using the xy values of that as the
base offset value, we should scale the light vector by 1/z.

See https://github.com/flutter/engine/pull/27124#issuecomment-880182653
for more detail.

Bug: skia:10781
Change-Id: Ib69a313cb96a532f8d89644e3d69f666a184e897
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/428880
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
2021-07-15 17:22:05 +00:00
Jim Van Verth
dfec4f98ef Metal: Add attachment support for RenderTargets and TextureRenderTargets
Bug: skia:12186
Change-Id: I8004fd44e59c0dc3b9ae3bb5fc408421c4976e30
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427756
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
2021-07-15 17:01:11 +00:00
Ethan Nicholas
a2d22b2e08 Broke DSLVar into separate subclasses
Previously, DSLVar represented local, global, and parameter variables.
This splits it into three separate subclasses.

In addition to just being a cleaner API in general, this also addresses
an issue we ran into with the upcoming DSLParser: previously, a global
DSLVar's storage was not set correctly until DeclareGlobal was called,
so an AddToSymbolTable call prior to DeclareGlobal would create the
SkSL variable with the wrong storage, causing spurious errors on
global-only modifiers. But holding off on the AddToSymbolTable tends to
break constructs like "int x = 0, y = x", so improving the API seemed
like the best way to address it.

Now that we have greater type safety around variables, we can
potentially avoid having to call AddToSymbolTable for DSLVar and
DSLGlobalVar altogether, since we know they are both supposed to end up
in the symbol table, but that isn't something I want to change in this
CL.

Change-Id: I5f390a7384ce0af6a2131d84f97fc5e5b318063f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/428576
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
2021-07-15 15:40:06 +00:00
John Stiles
0397ae4e15 Reland "Add unit test confirming Runtime Blends match native blends."
This is a reland of 0b62a05d9a

Original change's description:
> Add unit test confirming Runtime Blends match native blends.
>
> We perform the same draw operation twice--once with a `setBlendMode`
> based blend, and then once more with `setBlender` and passing SkSL which
> is equivalent to the native blend op. If this test fails, it would
> indicate that Runtime Blends aren't being applied appropriately (or
> perhaps that a GPU's built-in blending modes are cutting corners?).
>
> Change-Id: I4ca1f9ed600d9ec733687cc6de7d3e2eb6e765c9
> Bug: skia:12080
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/428318
> Auto-Submit: John Stiles <johnstiles@google.com>
> Reviewed-by: Mike Reed <reed@google.com>
> Commit-Queue: John Stiles <johnstiles@google.com>

Bug: skia:12080
Change-Id: Idf4297314b133e5bce689a25d53063bff8469fac
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/428676
Reviewed-by: John Stiles <johnstiles@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
2021-07-15 15:19:14 +00:00