Commit Graph

16726 Commits

Author SHA1 Message Date
bungeman
6f94076da5 Restore GDI text size rounding.
Add call to SkScalarRoundToScalar(). The old code calculated the scale
from the text size, but now the text size is calculated from the scale
(which is arguably the right way to think about it). However, the old
code always rounded the final resulting text size, while the new code
does not.

In the 'no hinting' case, the text size is already rounded to an integer
(so that the rest of the matrix is minimized). In the 'hinted' case, the
entire scale has been removed from the matrix, so the scale value is the
'real' residual size. The old code rounded this size, and the new code
should as well.

BUG=464784

Review URL: https://codereview.chromium.org/1014953002
2015-03-18 08:25:43 -07:00
scroggo
b267fd629b Add comment describing SkColorTable constructor.
Review URL: https://codereview.chromium.org/1011263002
2015-03-18 08:00:27 -07:00
dml
78acf96a67 Indexed PNG decoding: Ensure color table is large enough that the bit depth of the image will not allow reads beyond its end.
BUG=skia:3440
R=rmistry@google.com, scroggo@google.com

Committed: https://skia.googlesource.com/skia/+/493c1ce1cd406ef28683203146274154783452ce

Review URL: https://codereview.chromium.org/948163002
2015-03-18 06:03:30 -07:00
Ravi Mistry
8188840141 Whitespace change to test new GCE compile bot 2015-03-18 08:50:30 -04:00
mtklein
b37cb41a8b Display currently running tests as the keepalive message.
...
( 466MB   550) 31.9ms   gpu gm colorwheelnative
( 466MB   549) 50.1ms   gpu gm colorwheel
( 468MB   548) 512ms    gpu gm colortype_xfermodes
Currently running:
    unit test PathOpsRectsThreaded
    unit test PathOpsSimplifyDegeneratesThreaded
    unit test PathOpsSimplifyQuadralateralsThreaded
    gpu gm colortype

( 468MB   547) 90.8ms   gpu gm colortype
( 469MB   546) 2.03s    unit test PathOpsSimplifyDegeneratesThreaded
...

BUG=skia:

Review URL: https://codereview.chromium.org/1017903002
2015-03-18 05:27:14 -07:00
reed
0c9b1a8d05 add kGray_8_SkColorType
patch from issue 1014783003 at patchset 60001 (http://crrev.com/1014783003#ps60001)

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/1010343002
2015-03-17 17:44:07 -07:00
bsalomon
160f24ce0e Improve tracking of bound FBOs in GrGLGpu.
Committed: https://skia.googlesource.com/skia/+/d2ad8eb5801e2c8c0fa544a6a776bb46eedde2a0

Committed: https://skia.googlesource.com/skia/+/b2af2d8b83ca4774c3b3bb1e49bc72605faa9589

Committed: https://skia.googlesource.com/skia/+/0b70b86a7e9fda52ee7ebc1b9897eeaa09b9abef

Committed: https://skia.googlesource.com/skia/+/6ba6fa15261be591f33cf0e5df7134e4fc6432ac

Committed: https://skia.googlesource.com/skia/+/dc963b9264908f53650c40a97cff414101dd3e88

Review URL: https://codereview.chromium.org/949263002
2015-03-17 15:55:42 -07:00
Brian Salomon
9251d4e9c6 Use sample count for temp renderbuffer when clearing stenci
TBR=robertphillips@google.com

Review URL: https://codereview.chromium.org/1016903002
2015-03-17 16:03:19 -04:00
mtklein
e2aab90979 DM: disable image src type on Windows.
BUG=skia:

Review URL: https://codereview.chromium.org/1012183002
2015-03-17 12:52:16 -07:00
bsalomon
5cd020f27b Revert of Improve tracking of bound FBOs in GrGLGpu. (patchset #16 id:300001 of https://codereview.chromium.org/949263002/)
Reason for revert:
locally hit assert.

Original issue's description:
> Improve tracking of bound FBOs in GrGLGpu.
>
> Committed: https://skia.googlesource.com/skia/+/d2ad8eb5801e2c8c0fa544a6a776bb46eedde2a0
>
> Committed: https://skia.googlesource.com/skia/+/b2af2d8b83ca4774c3b3bb1e49bc72605faa9589
>
> Committed: https://skia.googlesource.com/skia/+/0b70b86a7e9fda52ee7ebc1b9897eeaa09b9abef
>
> Committed: https://skia.googlesource.com/skia/+/6ba6fa15261be591f33cf0e5df7134e4fc6432ac
>
> Committed: https://skia.googlesource.com/skia/+/dc963b9264908f53650c40a97cff414101dd3e88

TBR=egdaniel@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1017803002
2015-03-17 12:46:56 -07:00
bsalomon
dc963b9264 Improve tracking of bound FBOs in GrGLGpu.
Committed: https://skia.googlesource.com/skia/+/d2ad8eb5801e2c8c0fa544a6a776bb46eedde2a0

Committed: https://skia.googlesource.com/skia/+/b2af2d8b83ca4774c3b3bb1e49bc72605faa9589

Committed: https://skia.googlesource.com/skia/+/0b70b86a7e9fda52ee7ebc1b9897eeaa09b9abef

Committed: https://skia.googlesource.com/skia/+/6ba6fa15261be591f33cf0e5df7134e4fc6432ac

Review URL: https://codereview.chromium.org/949263002
2015-03-17 12:33:33 -07:00
bsalomon
9d2049db6e Add stencil-only clear bug workaround back but for all devices.
TBR=robertphillips@google.com

Review URL: https://codereview.chromium.org/1010253002
2015-03-17 12:06:19 -07:00
mtklein
eec84e324e Current RSS on linux and android too?
BUG=skia:

Review URL: https://codereview.chromium.org/1009313003
2015-03-17 10:24:49 -07:00
halcanary
5721c9b4a7 Doc: htmlify roles table to allow easier modification
TODO: make sure the table is up to date.
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1011753004

Review URL: https://codereview.chromium.org/1011753004
2015-03-17 09:56:33 -07:00
reed
706d98ef5b imagefilters always need to disable lcd
This prev CL accidentally stopped forcing (indirectly) the pixel-geometry to unknown. https://codereview.chromium.org/1010503002

BUG=467882

Review URL: https://codereview.chromium.org/1012113002
2015-03-17 08:34:38 -07:00
bungeman
d709ea8d14 Remove SkLONGLONG.
All users now define SkLONGLONG.
This fixes a long outstanding TODO now that int64_t is required.

BUG=skia:179

Review URL: https://codereview.chromium.org/1000933003
2015-03-17 07:23:39 -07:00
scroggo
cdeca44619 Revert "Indexed PNG decoding: Ensure color table is large enough that the bit depth of the image will not allow reads beyond its end."
This reverts commit 493c1ce1cd.

NOTRY=true
NOTREECHECKS=true
TBR=egdaniel@google.com,dml@google.com
BUG=skia:

Review URL: https://codereview.chromium.org/1014553003
2015-03-17 05:25:54 -07:00
Leon Scroggins III
493c1ce1cd Indexed PNG decoding: Ensure color table is large enough that the bit depth of the image will not allow reads beyond its end.
BUG=skia:3440
R=rmistry@google.com, scroggo@google.com

Review URL: https://codereview.chromium.org/948163002
2015-03-17 08:14:07 -04:00
scroggo
9552662e9f Option for SkCodec to treat dst as all zeroes.
This recreates SkImageDecoder's feature to skip writing zeroes for
SkCodec.

Review URL: https://codereview.chromium.org/980903002
2015-03-17 05:02:17 -07:00
cdalton
d0a840d4d8 Disable GL_MULTISAMPLE when it's not being used
Updates Gr to disable GL_MULTISAMPLE when drawing to an aliased render
target. This is an important step for NV_framebuffer_mixed_samples,
where just because the color buffer isn't multisampled doesn't mean
other stages in the graphics pipeline aren't. It also removes the need
for the "isLineDraw" workaround that was in GrGLGpu::flushHWAAState.

BUG=skia:

Review URL: https://codereview.chromium.org/1002013006
2015-03-16 17:19:58 -07:00
mtklein
18ef5ebf3b widen leak supression. looks like start_keepalive is sometimes inlined.
BUG=skia:

Review URL: https://codereview.chromium.org/1008873003
2015-03-16 15:06:00 -07:00
smcgruer
b83205a538 Fix build for UCLIBC platforms
malloc_usable_size does not exist in UCLIBC, so fall back to just
returning 0 for SkVarAlloc::heap_size().

BUG=skia:

Review URL: https://codereview.chromium.org/1006073003
2015-03-16 14:45:01 -07:00
bsalomon
6f7f2012ee Move GrAutoLocaleSetter to new file and fix issue with null locale
TBR=egdaniel@google.com
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/1002623004
2015-03-16 14:00:52 -07:00
reed
82b0748f1c remove dead code
BUG=skia:

Review URL: https://codereview.chromium.org/1016523002
2015-03-16 13:56:42 -07:00
reed
ee1c2bc5e4 remove unneeded flags
BUG=skia:

Review URL: https://codereview.chromium.org/1010063002
2015-03-16 13:55:48 -07:00
jvanverth
d68a550ec8 Fix up some issues introduced by https://codereview.chromium.org/1013773002/
Need to check for zero-length gradients when using the new correction.
Make sure we use the old text sizes for color emoji test in dftext GM.

BUG=skia:3540

Review URL: https://codereview.chromium.org/1009973004
2015-03-16 12:58:44 -07:00
Brian Salomon
95a4fe3737 always reset locale (not just in debug).
BUG=skia:

Review URL: https://codereview.chromium.org/1007283009
2015-03-16 15:36:44 -04:00
Brian Salomon
f33a8bf31e fix ios build wrt locale?
BUG=skia:3330

Review URL: https://codereview.chromium.org/1012773004
2015-03-16 15:05:23 -04:00
bsalomon
3318ee7d5e Use C locale for numerics when emitting shaders.
BUG=skia:3330

Review URL: https://codereview.chromium.org/1012723002
2015-03-16 11:56:29 -07:00
msarett
741143878b Revert "Revert of fix for invalid for loop syntax broke build (patchset #1 id:1 of https://codereview.chromium.org/1007373003/)"
This reverts commit d18475854c.

Revert "Revert "Implementation of image decoding for bmp files, in accordance with the new API.""

This reverts commit dfdec78a5d.

BUG=skia:

TBR=

Review URL: https://codereview.chromium.org/1016443003
2015-03-16 11:55:18 -07:00
jvanverth
354eba5cb6 Fix SDF gradient calculation for non-uniform xforms
Also adds two non-uniform test cases to the dftext GM.

BUG=skia:3540

Review URL: https://codereview.chromium.org/1013773002
2015-03-16 11:32:49 -07:00
msarett
dfdec78a5d Revert "Implementation of image decoding for bmp files, in accordance with the new API."
This reverts commit 3675874468.

BUG=skia:
NOTREECHECKS=true
NOTRY=true
TBR=

Review URL: https://codereview.chromium.org/1012873002
2015-03-16 11:07:02 -07:00
egdaniel
d18475854c Revert of fix for invalid for loop syntax broke build (patchset #1 id:1 of https://codereview.chromium.org/1007373003/)
Reason for revert:
needed to revert early patch

Original issue's description:
> fix for invalid for loop syntax broke build
> NOTREECHECKS=true
> NOTRY=true
> TBR=
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/fdc310855dbf04ffb33787f5c0d76fef90b303d4

TBR=msarett@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1015473002
2015-03-16 10:50:12 -07:00
mtklein
ffa901aa7e DM: allow SKPs to be smaller than 1000x1000
This sniffs the .skp dimensions and intersects them with our 1000x1000 viewport.

This fixes things like desk_carsvg.skp, which is only 902 pixels tall.  In 565 now,
the remaining 98 pixels draw as black, which looks funny and is confusing to triage.

No apparent affect on DM memory usage.  (We're about to map the file anyway.)

BUG=skia:

Review URL: https://codereview.chromium.org/986103002
2015-03-16 10:38:07 -07:00
reed
e7903c7397 FilterLevel -> SkFilterQuality
BUG=skia:
TBR=
NOTREECHECKS=True
NOTRY=True

Review URL: https://codereview.chromium.org/1010023002
2015-03-16 10:26:13 -07:00
reed
93a1215fe0 SkPaint::FilterLevel -> SkFilterQuality
clone (+rebase) of https://codereview.chromium.org/1009183002/

BUG=skia:
TBR=scroggo@google.com

Review URL: https://codereview.chromium.org/1014533004
2015-03-16 10:08:34 -07:00
bungeman
903dcb08b1 Add __STDC_LIMIT_MACROS to SkDraw.cpp. 2015-03-16 13:00:09 -04:00
bungeman
d095f2bf06 Test for glyphs which straddle the edge of device space.
If a glyph ends up with a left edge near the extreme right edge of
device space, the right edge may end up at the extreme left. The
current clip tests do not test for this situation and attempt to
draw the glyphs. This results in the blitters never reaching the
right edge of the glyph and so reading from other memory.

BUG=chromium:467011

Review URL: https://codereview.chromium.org/1012763002
2015-03-16 09:49:54 -07:00
msarett
fdc310855d fix for invalid for loop syntax broke build
NOTREECHECKS=true
NOTRY=true
TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/1007373003
2015-03-16 08:47:55 -07:00
msarett
3675874468 Implementation of image decoding for bmp files, in accordance with the new API.
Currently decodes to opaque and unpremul.

Tested on local test suite.

BUG=skia:3257

Review URL: https://codereview.chromium.org/947283002
2015-03-16 08:27:53 -07:00
reed
dedc2d8e8d check for null-pixelref
BUG=skia:3497

Review URL: https://codereview.chromium.org/1004313002
2015-03-16 07:28:13 -07:00
reed
3a224666df remove deprecated setFilterBitmap/isFilterBitmap
BUG=skia:

Review URL: https://codereview.chromium.org/1006213002
2015-03-16 07:24:05 -07:00
mtklein
1e237385ec Suppress keepalive thread leak in DM.
BUG=skia:

Review URL: https://codereview.chromium.org/1006143002
2015-03-16 06:59:19 -07:00
reed
19c25f18a3 move kTileModeCount out of TileMode enum
BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/1009193002
2015-03-15 14:01:21 -07:00
skia.buildbots
8c6a9778dc Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=

Review URL: https://codereview.chromium.org/1005353003
2015-03-15 01:13:36 -07:00
reed
6af1b05b24 remove legacy onCreateCompatibleDevice
needs this to land in chrome first : https://codereview.chromium.org/1013453002/

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/1006183002
2015-03-14 17:51:34 -07:00
bsalomon
1e0bf7e113 Revert of Improve tracking of bound FBOs in GrGLGpu. (patchset #12 id:220001 of https://codereview.chromium.org/949263002/)
Reason for revert:
That one needs to be reverted to fix black boxes with GPU
raster, and GPU bot failures.

BUG=466690

Original issue's description:
> Improve tracking of bound FBOs in GrGLGpu.
>
> Committed: https://skia.googlesource.com/skia/+/d2ad8eb5801e2c8c0fa544a6a776bb46eedde2a0
>
> Committed: https://skia.googlesource.com/skia/+/b2af2d8b83ca4774c3b3bb1e49bc72605faa9589
>
> Committed: https://skia.googlesource.com/skia/+/0b70b86a7e9fda52ee7ebc1b9897eeaa09b9abef
>
> Committed: https://skia.googlesource.com/skia/+/6ba6fa15261be591f33cf0e5df7134e4fc6432ac

TBR=egdaniel@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1011493002
2015-03-14 12:08:51 -07:00
ccameron
3700c9a2d3 Revert of Add terrible workaround to fix stencil clear crash on S3. (patchset #1 id:1 of https://codereview.chromium.org/1001693003/)
Reason for revert:
Needs to be reverted in order to cleanly revert
https://codereview.chromium.org/949263002

That one needs to be reverted to fix black boxes with GPU
raster, and GPU bot failures.

BUG=466690

Original issue's description:
> Add terrible workaround to fix stencil clear crash on S3.
>
> BUG=skia:3525
>
> Committed: https://skia.googlesource.com/skia/+/084340bb9bbb538baf02a11ac36e29f0d9cdc493

TBR=joshualitt@google.com,bsalomon@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:3525

Review URL: https://codereview.chromium.org/1005263002
2015-03-14 12:06:54 -07:00
reed
76033be81b Revert[6] of Change device creation to see the (optional) layer-paint
This reverts commit 173e5fe5f4.

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/1010503002
2015-03-14 10:54:31 -07:00
mtklein
de7665a6d5 Skip absurdly slow PDF tests on Valgrind bot.
Our Valgrind-with-keepalive CPU bot is still running its first run as I write
this.  It's been going ~48 hours.  'pdf gm fontmgr_iter' finished after ~19
hours.  'pdf image PANO_20121023_214540.jpg' still seems to be running.

After this, the next slowest will be '565 gm fontmgr_iter' at about 37 minutes.

TBR=borenet@google.com

BUG=skia:

Review URL: https://codereview.chromium.org/1003423002
2015-03-14 07:24:29 -07:00