Commit Graph

56297 Commits

Author SHA1 Message Date
Chris Dalton
c3176002bc Lift the tessellation atlas into its own path renderer
Creates a new path renderer, GrAtlasPathRenderer, that handles all the
atlasing. Managing the atlas in its own path renderer gives us more
control over when atlasing happens in the chain, will allow us to more
easily use the atlas in kCoverage mode, and makes the clipping code
cleaner.

Bug: skia:12258
Change-Id: Ie0b669974936c23895c8ab794e2d97206ed140f8
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/431896
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
2021-07-23 23:02:58 +00:00
John Stiles
2955c26908 Add new SampleBlender callback to SkVMCodeGenerator.
This CL doesn't actually allow the callbacks to be invoked from SkSL
yet, but the callbacks now exist and are now threaded through the
various callsites which will need them.

Change-Id: I00f43ff94de9da8d93daf2e59885eea6f87c2e3e
Bug: skia:12257
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/431696
Commit-Queue: John Stiles <johnstiles@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2021-07-23 21:05:10 +00:00
John Stiles
d9a56b9227 Remove color argument from sampleShader.
Passing a color to a shader isn't supported in SkSL anymore.

Change-Id: Ic2743e519b69fa8add4c010166032b4dab2152a7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/431938
Commit-Queue: John Stiles <johnstiles@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2021-07-23 21:04:08 +00:00
John Stiles
8050a4b3ce Separate PipelineStage's sampleChild into two callbacks.
We now have `sampleShader` and `sampleColorFilter`. This CL prepares us
for the addition of a third sampleable type, SkBlender, with a unique
signature (two colors, no coordinates).

Change-Id: I77ba9ba94a1c447d0ef10f5acb5ffe9b9395cfe1
Bug: skia:12257
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/431697
Commit-Queue: John Stiles <johnstiles@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2021-07-23 20:55:16 +00:00
Jim Van Verth
bef411b6db Metal: track GrSurfaces on command buffer.
* Adds tracking array and tracks specific uses
* Also tweaks resolve interface to allow for tracking.


Bug: skia:12253
Change-Id: I49f99fee8d939e47de2c054e031df4c848319f01
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/431456
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
2021-07-23 20:33:42 +00:00
John Stiles
137482fc22 Separate SkVM's SampleChild into two callbacks.
Previously, one callback was used and the caller needed to infer from
the passed-in index what type of effect to invoke, and which arguments
were valid.

Now, each type of effect has a separate callback with a unique
signature. (In particular, SkColorFilters lack coordinates entirely.)
In a later CL, SkBlenders will also be supported, and those will have
a different signature again, as they take two colors and no coords.

Change-Id: Ibcb39c91c35256c5339e4d2790ed0c36e434f191
Bug: skia:12257
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/431656
Reviewed-by: Brian Osman <brianosman@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2021-07-23 19:05:46 +00:00
Michael Ludwig
cfd204a785 Rename/simplify SkCanvas::resetClip() and make recordable
AndroidFramework uses both their own custom display list (which could
handle resetClip with android-side changes) AND conventional picture
recording. In order for replace op emulation to work when they have
been recorded into a picture, we need to make it virtual and supported
in SkPicture.

This also renames the API to ResetClip() from ReplaceClip() and does not
have any additional arguments. Based on AF's usage pattern, it only n
needs to reset the clip to the surface bounds or the device clip
restriction, it seems best to reduce the API as much as possible before
it's adopted.

Bug: skia:10209
Change-Id: I37adb097c84a642f4254b8c0f9d4c7fea8d9abdf
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/430897
Reviewed-by: Mike Reed <reed@google.com>
Reviewed-by: Derek Sollenberger <djsollen@google.com>
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
2021-07-23 19:05:42 +00:00
Robert Phillips
cc6e50f041 Prevent CircleOp from being tested with MSAA
Change-Id: I307322f2d5e66ef103bdeb791066d6bba11b70ff
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/431636
Reviewed-by: Chris Dalton <csmartdalton@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2021-07-23 19:05:40 +00:00
Herb Derby
ac2d053ccf add op array32 for indirect uniform access
Change-Id: I6249594a2348c7b24e4f057cce2f4e8a6a2c4409
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/431676
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2021-07-23 19:05:38 +00:00
skia-autoroll
4345e1ef42 Roll ANGLE from 0e1c90cf4f17 to 9f7a86a80874 (14 revisions)
0e1c90cf4f..9f7a86a808

2021-07-23 syoussefi@chromium.org Vulkan: SPIR-V Gen: Fix bugs with matrix ops
2021-07-23 syoussefi@chromium.org Vulkan: SPIR-V Gen: Support scalar constructors
2021-07-23 syoussefi@chromium.org Vulkan: SPIR-V Gen: Support tessellation shaders
2021-07-23 syoussefi@chromium.org Vulkan: SPIR-V Gen: Support geometry shaders
2021-07-22 timvp@google.com Cleanup license_text to remove missing license files
2021-07-22 timvp@google.com List all license files in Android.bp
2021-07-22 jmadill@chromium.org Add Chromium perf result processing script.
2021-07-22 sugoi@google.com Enable SwANGLE on all ozone platforms.
2021-07-22 cnorthrop@google.com Capture/Replay: Add textures to resource tracking
2021-07-22 jmadill@chromium.org Revert "EGL: GLES: Implement GL_EXT_protected_textures"
2021-07-22 jmadill@chromium.org Revert "Vulkan: Suppress VVL errors triggered by external formats"
2021-07-22 jmadill@chromium.org Test Runner: Remove extra quotes from histograms.
2021-07-22 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 436e27578f75 to d85297cbd31b (10 revisions)
2021-07-22 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from f8ef6fcfb849 to 208fab302a17 (1307 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-skia-autoroll
Please CC ethannicholas@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE
Tbr: ethannicholas@google.com
Test: Test: PUBG Mobile MEC
Test: Test: git clean -f -x -d -f ; m ANGLE -j50
Change-Id: I43f0f88e4c3265922c4b86eb1db2060b659070ef
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/431836
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-07-23 19:05:28 +00:00
Mike Reed
6417cfc71e Add _bilerp variant to vertices bench
... only affects when textures are also present

Change-Id: I82847c68380b6274583a48a96aef87ec1b353ada
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/432156
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2021-07-23 19:00:19 +00:00
Brian Osman
64565aed51 Skip more flaky tests in the mtltestprecompile config
Change-Id: I24f6e6570339cb071cb1a4faf916bd549835ec8b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/431936
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2021-07-23 18:21:15 +00:00
Mike Reed
d068e4154c Pass separate texs so we don't cheat in drawVerts
Cheat == take a faster path that is not normally used by real clients.
This way the bench is more representative.

Change-Id: I37644ae5d05a00f217773dddba290eac9a2a846f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/431939
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Herb Derby <herb@google.com>
2021-07-23 17:27:46 +00:00
Mike Reed
0e2fb66a50 Add flag to force high-precision RP
Change-Id: I9388458ae186f7b2a8b8534859147b9a1035276f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/432016
Reviewed-by: Brian Osman <brianosman@google.com>
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2021-07-23 16:22:23 +00:00
Chris Dalton
8854829351 Reland "Prefer the NV_framebuffer_blit extension over ANGLE"
This is a reland of 202ce887ec

Original change's description:
> Prefer the NV_framebuffer_blit extension over ANGLE
>
> The ANGLE/CHROMIUM glBlitFramebuffer requires full size blits, which
> is really bad for DMSAA. The NV extension does allow blits of
> sub-rectangles, so we prefer that one if it's available.
>
> Bug: skia:12176
> Bug: skia:12177
> Bug: skia:12234
> Bug: skia:12235
> Change-Id: I463ac631fff64ad564f294cf2f26be7410e8c356
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/430576
> Reviewed-by: Greg Daniel <egdaniel@google.com>
> Commit-Queue: Chris Dalton <csmartdalton@google.com>

Bug: skia:12176
Bug: skia:12177
Bug: skia:12234
Bug: skia:12235
Change-Id: I41d062f9894f5a81c78a37de27a288bc17812643
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/431817
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2021-07-23 16:20:36 +00:00
Kevin Lubick
747c321922 [infra] Update cmake docker image to be Debian 10
Bug: skia:12256
Change-Id: Ic5cad6d6e5e7155f0adc26fca9f1172f33ce3b3a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/431260
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2021-07-23 11:21:31 +00:00
Joe Gregorio
6940cff9c3 Revert "Roll recipe dependencies (nontrivial)."
This reverts commit 14037fff49.

Reason for revert: Is possibly killing Android bots.

Original change's description:
> Roll recipe dependencies (nontrivial).
>
> This is an automated CL created by the recipe roller. This CL rolls
> recipe changes from upstream projects (depot_tools) into this repository.
>
> Please review the expectation changes, and LGTM+CQ.
>
> depot_tools:
> 11f53d6949
>   11f53d6 (gavinmak@google.com)
>       Reland "Add python3 support to bot_update recipe module"
>
> More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
>
> R=​rmistry@google.com
>
> Recipe-Tryjob-Bypass-Reason: Autoroller
> Bugdroid-Send-Email: False
> Change-Id: Ia84a87aa1905e59b1618fe79a8abc1e61fc4cc30
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/430957
> Commit-Queue: Ravi Mistry <rmistry@google.com>
> Reviewed-by: Ravi Mistry <rmistry@google.com>

TBR=borenet@google.com,rmistry@google.com,recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com

Change-Id: I14e915b104a87bf3580fe2276b0bb8c124510564
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/431699
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
2021-07-23 00:09:40 +00:00
Joe Gregorio
795b5f133d Revert "Roll recipe dependencies (trivial)."
This reverts commit 7059704767.

Reason for revert: Is possibly killing Android bots.

Original change's description:
> Roll recipe dependencies (trivial).
>
> This is an automated CL created by the recipe roller. This CL rolls
> recipe changes from upstream projects (recipe_engine) into this repository.
>
> recipe_engine:
> c80e36cb1f~..af0b32cd5e64a71d3357047ba149a3e3c00445e1
>   c80e36c (chromium-autoroll@skia-public.iam.gserviceaccount.com)
>       Roll CAS Client from af829a9aede7 to 9555d5a16a0b
>   a3a7358 (yiwzhang@google.com)
>       py3: upgrade parameterized to 0.8.1 and use new naming feature
>   af0b32c (yiwzhang@google.com)
>       py3: make run command py3 compatible and enable simple unittest...
>
> More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
>
> R=​borenet@google.com
>
> Recipe-Tryjob-Bypass-Reason: Autoroller
> Bugdroid-Send-Email: False
> Change-Id: Ia07af3941712bd422fc6d99b0dda42d55ec12d64
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/431258
> Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
> Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

TBR=borenet@google.com,recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com

Change-Id: I7409a231510cbb3e10cacc0460bb6a269e80037f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/431698
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
2021-07-23 00:09:08 +00:00
John Stiles
8a166f3bc7 Factor out shared code for SkVM uniform setup.
Change-Id: If885973683191048bc93e62b9e64a021f330cb4b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/431497
Commit-Queue: John Stiles <johnstiles@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2021-07-22 19:26:30 +00:00
Robert Phillips
d91d2341b9 Revert "Feed all top-level GPU accessors through skgpu::BaseDevice"
This reverts commit 5de8b19504.

Reason for revert: blocking Android roll

Original change's description:
> Feed all top-level GPU accessors through skgpu::BaseDevice
>
> This pulls the GPU-specific accessors off of SkCanvas and SkDevice - moving them all to skgpu::BaseDevice and SkCanvasPriv.
>
> This will allow us to more easily change the gpu class hierarchy (esp. changing GrSurfaceDrawContext to skgpu::v1:SurfaceDrawContext) w/o churning the public API.
>
> Bug: skia:11837
> Change-Id: I4e205255706680ac58ffe40f714884c2ee7ac799
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/431036
> Reviewed-by: Brian Osman <brianosman@google.com>
> Reviewed-by: Michael Ludwig <michaelludwig@google.com>
> Commit-Queue: Robert Phillips <robertphillips@google.com>

TBR=robertphillips@google.com,brianosman@google.com,michaelludwig@google.com

Change-Id: I8a015be4edbe21d63db09d5593af13cc89df4217
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:11837
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/431538
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2021-07-22 18:56:51 +00:00
Kevin Lubick
ad858e76e3 [canvaskit] Fix gm compilation
This removes some files that were deleted in early July 2021

Change-Id: I3a79a0d58eea16b4e14a548261f1279497860275
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/431259
Reviewed-by: Brian Osman <brianosman@google.com>
2021-07-22 16:57:32 +00:00
Robert Phillips
5de8b19504 Feed all top-level GPU accessors through skgpu::BaseDevice
This pulls the GPU-specific accessors off of SkCanvas and SkDevice - moving them all to skgpu::BaseDevice and SkCanvasPriv.

This will allow us to more easily change the gpu class hierarchy (esp. changing GrSurfaceDrawContext to skgpu::v1:SurfaceDrawContext) w/o churning the public API.

Bug: skia:11837
Change-Id: I4e205255706680ac58ffe40f714884c2ee7ac799
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/431036
Reviewed-by: Brian Osman <brianosman@google.com>
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2021-07-22 16:47:30 +00:00
Kevin Lubick
391429f78b [canvaskit] Expose AsWinding
Bug: skia:11858
Change-Id: Iedbc2333779f2fac5029779bae44da48d8dd7b8f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/430956
Reviewed-by: Ben Wagner <bungeman@google.com>
2021-07-22 16:36:33 +00:00
John Stiles
8e51bad14f Add support for child effects on SkRuntimeBlender.
This will allow runtime blenders to leverage existing color filters or
shaders when computing a blend.

Change-Id: I743d5fc6d83a92cd190cb6bfd1c79789d8be2089
Bug: skia:12249
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/430658
Commit-Queue: John Stiles <johnstiles@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2021-07-22 15:09:01 +00:00
skia-autoroll
ff7a4a576f Roll SK Tool from 9a963c3542ab to 83d167c8dec8
https://skia.googlesource.com/buildbot.git/+log/9a963c3542ab..83d167c8dec8

2021-07-22 borenet@google.com [infra] Roll back Python to 3.8.10

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/sk-tool-skia
Please CC lovisolo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: lovisolo@google.com
Change-Id: I841dad5a1d3aef1d4799949730c6a107a2c716ff
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/431346
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-07-22 14:28:30 +00:00
Ravi Mistry
475f0caf85 Change format of jobs.json to include cq_config. Populate cq_config of all CQ jobs.
Bug: skia:12242
Change-Id: I2ff307abc97156ce2bb35130a33bee7a45689e7e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/430877
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2021-07-22 14:18:20 +00:00
Ravi Mistry
206380837f Update go/skia.org/infra in go.mod/go.sum
To pick up recent changes in buildbot repo for SkCQ

Updated with:
$ go get go.skia.org/infra@83d167c8de
$ go mod download
$ make -C infra/bots train

Bug: skia:12242
Change-Id: I4cca5c90ca7ba0a3180b8703256fed4983061e46
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/430879
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2021-07-22 13:55:04 +00:00
recipe-roller
7059704767 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
c80e36cb1f~..af0b32cd5e64a71d3357047ba149a3e3c00445e1
  c80e36c (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from af829a9aede7 to 9555d5a16a0b
  a3a7358 (yiwzhang@google.com)
      py3: upgrade parameterized to 0.8.1 and use new naming feature
  af0b32c (yiwzhang@google.com)
      py3: make run command py3 compatible and enable simple unittest...

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia07af3941712bd422fc6d99b0dda42d55ec12d64
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/431258
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2021-07-22 13:42:19 +00:00
Brian Osman
759989c1ca Remove obsolete "FP" unit test for runtime effects
Most of these keywords don't exist at all, or they're tested directly by
other tests (eg, 'in' isn't allowed at all).

Change-Id: I40f72678640291b09fb2da752b424735326c92f1
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/431356
Commit-Queue: Brian Osman <brianosman@google.com>
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
Auto-Submit: Brian Osman <brianosman@google.com>
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
2021-07-22 13:39:39 +00:00
Brian Osman
fb212256ca Improve tests/comments, to prepare for calling functions before definition
Bug: skia:12137
Change-Id: I609dd2578bf39a30e036ea85281886f8c4554579
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/431038
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2021-07-22 13:19:39 +00:00
recipe-roller
14037fff49 Roll recipe dependencies (nontrivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (depot_tools) into this repository.

Please review the expectation changes, and LGTM+CQ.

depot_tools:
11f53d6949
  11f53d6 (gavinmak@google.com)
      Reland "Add python3 support to bot_update recipe module"

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=rmistry@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia84a87aa1905e59b1618fe79a8abc1e61fc4cc30
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/430957
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
2021-07-22 12:50:29 +00:00
Mike Reed
aebe248575 SkFilterQuality is gone.
Bug: skia:11235
Change-Id: Iefa0156f542f217e687299f053768ee5b87f84d7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/430977
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2021-07-22 12:41:49 +00:00
Ravi Mistry
ff322968e9 Remove infra/bots/OWNERS
Change-Id: I56e8bd3ac8708e5d4a25969093775974be7d2a69
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/431178
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2021-07-22 12:08:50 +00:00
Mike Reed
64e67c346c Remove deprecated getBlendMode
Change-Id: I2254edbe05bc3fe415f546ea9e4533f52b7c5726
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/431180
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2021-07-22 10:12:19 +00:00
skia-autoroll
bc6d93397f Roll ANGLE from e9decf0c6d99 to 0e1c90cf4f17 (8 revisions)
e9decf0c6d..0e1c90cf4f

2021-07-22 syoussefi@chromium.org Translator: Validate function parameter qualifiers
2021-07-22 syoussefi@chromium.org Vulkan: SPIR-V Gen: Fix I/O block arrays
2021-07-22 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from a42815069bad to 436e27578f75 (16 revisions)
2021-07-21 timvp@google.com Capture/Replay: Update unpack state in Shared MEC
2021-07-21 capn@google.com Document the need for is_component_build = false
2021-07-21 jmadill@chromium.org Vulkan: Disable border color on SwiftShader.
2021-07-21 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 7a7993b54e62 to 915947134128 (1 revision)
2021-07-21 b.schade@samsung.com Vulkan: Add Validation checks in FramebufferTextureEXT

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-skia-autoroll
Please CC ethannicholas@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE
Tbr: ethannicholas@google.com
Test: Test: KHR-GLES32.core.geometry_shader.layered_fbo.fb_texture_argument_refers_to_buffer_texture
Test: Test: KHR-GLES32.core.geometry_shader.layered_fbo.fb_texture_invalid_level_number
Change-Id: I0f6065250547998c5440bbe153cd91e63c95debd
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/431143
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-07-22 05:35:09 +00:00
Chris Dalton
e3f2a63db7 Revert "Prefer the NV_framebuffer_blit extension over ANGLE"
This reverts commit 202ce887ec.

Reason for revert: Need to update Chrome first to give us the NV one.

Original change's description:
> Prefer the NV_framebuffer_blit extension over ANGLE
>
> The ANGLE/CHROMIUM glBlitFramebuffer requires full size blits, which
> is really bad for DMSAA. The NV extension does allow blits of
> sub-rectangles, so we prefer that one if it's available.
>
> Bug: skia:12176
> Bug: skia:12177
> Bug: skia:12234
> Bug: skia:12235
> Change-Id: I463ac631fff64ad564f294cf2f26be7410e8c356
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/430576
> Reviewed-by: Greg Daniel <egdaniel@google.com>
> Commit-Queue: Chris Dalton <csmartdalton@google.com>

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: skia:12176
Bug: skia:12177
Bug: skia:12234
Bug: skia:12235
Change-Id: Iaa9f82e1c0c935a67dd8f446d1513b2b0a98f725
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/430819
Reviewed-by: Chris Dalton <csmartdalton@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2021-07-22 04:58:39 +00:00
Chris Dalton
5e332c8afc Remove support for non-AA in the tessellation atlas
Now that multisampleDisableSupport is completely turned off, this
won't change any behavior.

Change-Id: I3fe0518aee5321c7c92ac0b4b77333e910f08ce6
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/431076
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
2021-07-22 02:34:17 +00:00
John Stiles
4d5708c464 Remove template from SkRuntimeEffectBuilder.
fChildren in the Builder is now a vector of ChildPtrs instead of a
vector of one particular type of child. This gives builder.child() the
flexibility to accept a color-filter, shader, or any other type that a
ChildPtr can hold.

Change-Id: I9e1ecf51aab1c74a9a15738bee7900b0c690ce9a
Bug: skia:11813
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/431196
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
2021-07-21 21:57:12 +00:00
Robert Phillips
7a0d3c3f12 Revise GM infrastructure to not rely on GrSurfaceDrawContext
The SDC will soon be V1-only. Remove it from the generic testing infrastructure and require each V1-specific GM to explicitly retrieve it.

Bug: skia:11837
Change-Id: I4c904b7e333333382062bde4b17a1f9f81bee6a9
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/430425
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
2021-07-21 20:59:37 +00:00
Ben Wagner
12745c8d88 Update required FreeType to 2.8.1
Drop support for FreeType older than 2.8.1. Remove dynamic loading
checks and constant definitions which are now known to exist. Update
includes to no longer require macros. Changes to take advantage of
thread safety will be done later.

Change-Id: Idf82147cad0df8315c6737e878ec6750537c7b28
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429898
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2021-07-21 20:24:16 +00:00
Nico Weber
ac747ca18f Give enums in SkImageInfo an underlying type
According to goto.google.com/chrome-includes, SkImageInfo.h is a
somewhat expensive header to include. This makes it possible to
forward-declare these enums instead.

Bug: chromium:1227131,chromium:242216
Change-Id: I4e939449a8d3dfc3fa4c43999bcaecb3249bc0c8
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/431056
Commit-Queue: Nico Weber <thakis@chromium.org>
Commit-Queue: Brian Osman <brianosman@google.com>
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Brian Osman <brianosman@google.com>
2021-07-21 19:34:36 +00:00
Jim Van Verth
ea61c472f3 Metal: Use GrMtlFramebuffer than than GrRenderTarget where possible.
Bug: skia:12186
Change-Id: Ifb08a05619f856e1299ecddab0a88a0ed132dd57
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/430636
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
2021-07-21 19:31:46 +00:00
John Stiles
b6a7319f21 Add tokens for highp/mediump/lowp.
At present, they aren't hooked up to anything. They will be made
functional in followup CLs.

Change-Id: I4bfc25eb4e19fce4c36ea0b55494bf37b2a9ee23
Bug: skia:12248
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/430637
Auto-Submit: John Stiles <johnstiles@google.com>
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
2021-07-21 15:41:20 +00:00
Herb Derby
a7a9443104 rename the VM blitter to SkVMBlitter
Change-Id: I71ae924d32dc2268cc4a3db1920c08287533f9ae
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/430697
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2021-07-21 15:32:19 +00:00
Kevin Lubick
7fc705bdd7 [canvaskit] Fix red_line.skp test
Change-Id: I7c9610faf56af21fff17d1bfd96297770defb951
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/430857
Auto-Submit: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2021-07-21 14:06:36 +00:00
Julia Lavrova
c5c9dd86b0 Text Editor based on SkText: delete and backspace
Change-Id: I1152f83af724634f06e1a767ef39bef2afe70b33
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/430656
Reviewed-by: Julia Lavrova <jlavrova@google.com>
Commit-Queue: Julia Lavrova <jlavrova@google.com>
2021-07-21 13:45:06 +00:00
Brian Osman
77046a7f0f Disallow sk_FragCoord in SkRuntimeEffect
It's still accessible internally (and by default when using
SkMakeRuntimeEffect), but we don't want clients using this.
If we can come up with a simple and consistent coordinate
model that doesn't expose implementation details, we'll
revisit this.

Change-Id: I77726830480a286541ae887f9cd9822eb10ea913
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/430422
Reviewed-by: John Stiles <johnstiles@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2021-07-21 13:36:56 +00:00
skia-autoroll
d090aa7fee Roll ANGLE from 6a86d2079fd3 to e9decf0c6d99 (13 revisions)
6a86d2079f..e9decf0c6d

2021-07-20 syoussefi@chromium.org Vulkan: SPIR-V Gen: Support framebuffer fetch
2021-07-20 syoussefi@chromium.org Translator: Validate AST consistency w.r.t function calls
2021-07-20 syoussefi@chromium.org Translator: Allow subpassLoad in AST in ESSL
2021-07-20 j.vigil@samsung.com EGL: GLES: Implement GL_EXT_protected_textures
2021-07-20 j.vigil@samsung.com EGL: implement EGL_EXT_protected_content Context
2021-07-20 syoussefi@chromium.org Vulkan: SPIR-V Gen: Support interpolateAt*
2021-07-20 jmadill@chromium.org trigger.py: Add -realm to swarming args.
2021-07-20 ivan.murashov@lge.com GCC: Remove double declaration of ContextSet
2021-07-20 jmadill@chromium.org Add -Wno-implicit-fallthrough to GLES 1 CTS.
2021-07-20 jgilbert@mozilla.com Define ANGLE_IS_64_BIT_CPU in common/platform.h.
2021-07-20 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from c6747d98397d to 7a7993b54e62 (16 revisions)
2021-07-20 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 7c4121a2cfd0 to a42815069bad (28 revisions)
2021-07-20 syoussefi@chromium.org Vulkan: SPIR-V Gen: Support built-ins with out parameters

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-skia-autoroll
Please CC ethannicholas@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE
Tbr: ethannicholas@google.com
Test: Test: angle_end2end_test --gtest_filter=EGLProtectedContentTest
Change-Id: I7a7c25a9e112c9e0eb958bd88255aaeabc8a70b6
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/430796
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-07-21 05:36:10 +00:00
skia-autoroll
4979fe5539 Roll SwiftShader from 7a7993b54e62 to 915947134128 (1 revision)
https://swiftshader.googlesource.com/SwiftShader.git/+log/7a7993b54e62..915947134128

2021-07-20 mail@eliasnaur.com Add missing dependency for LLVM 10 CMake builds

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-skia-autoroll
Please CC ethannicholas@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Test-Debian10-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
Bug: None
Tbr: ethannicholas@google.com
Change-Id: I6ef6f779a6233b46857dd931cf987a737506a7f9
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/430797
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-07-21 05:36:08 +00:00
skia-autoroll
b28d8b0464 Roll Chromium from 0169808c5c70 to aa692f23db42 (439 revisions)
0169808c5c..aa692f23db

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-skia-autoroll
Please CC ethannicholas@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Perf-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Release-All-CommandBuffer;skia/skia.primary:Test-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Debug-All-CommandBuffer
Tbr: ethannicholas@google.com
Change-Id: Ia3365ee842c9b89e3811dea20cbe39b9a22bc8f5
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/430798
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-07-21 05:36:04 +00:00