commit-bot@chromium.org
c435360f20
Fix android build issues with atomics
...
Uses inline methods for sk_atomic_inc/add/dec instead of #define.
Since those methods are declared as static in SkThread.h, they need
a definition or else the compiler generates an error. Also corrects
a typo.
BUG=skia:
R=djsollen@google.com , bungeman@google.com , bsalomon@google.com
Author: cdalton@nvidia.com
Review URL: https://codereview.chromium.org/148113010
git-svn-id: http://skia.googlecode.com/svn/trunk@13360 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-07 13:55:57 +00:00
commit-bot@chromium.org
1f1dd96336
Whitespace change to test Bugdroid II
...
(SkipBuildbotRuns)
TBR=
NOTRY=true
BUG=skia:2139
Author: rmistry@google.com
Review URL: https://codereview.chromium.org/144713009
git-svn-id: http://skia.googlecode.com/svn/trunk@13359 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-07 13:29:21 +00:00
commit-bot@chromium.org
d4d87df3c5
Whitespace change to test Bugdroid
...
(SkipBuildbotRuns)
TBR=
NOTRY=true
BUG=2139
Author: rmistry@google.com
Review URL: https://codereview.chromium.org/157393003
git-svn-id: http://skia.googlecode.com/svn/trunk@13358 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-07 13:27:59 +00:00
commit-bot@chromium.org
5e0995e4b3
Revert of Revert "Serialization of SkPictureImageFilter" ( https://codereview.chromium.org/153583007/ )
...
Reason for revert:
New SKPs with version20 are in Google Storage due to http://108.170.219.160:10117/builders/Housekeeper-Nightly-RecreateSKPs/builds/22
Original issue's description:
> Revert "Serialization of SkPictureImageFilter"
>
> This reverts commit 227321b30106e57942929eb96fa5bc22544f6c9e.
>
> Revert "Sanitizing source files in Housekeeper-Nightly"
>
> This reverts commit baf28584b7636c01355f8d8d972e06aa7fb66d77.
>
> TBR=robertphillips@google.com ,sugoi@google.com
>
> Committed: https://code.google.com/p/skia/source/detail?r=13356
R=robertphillips@google.com , sugoi@google.com , fmalita@google.com , fmalita@chromium.org
TBR=fmalita@chromium.org , fmalita@google.com , robertphillips@google.com , sugoi@google.com
NOTREECHECKS=true
NOTRY=true
Author: rmistry@google.com
Review URL: https://codereview.chromium.org/143163005
git-svn-id: http://skia.googlecode.com/svn/trunk@13357 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-07 12:20:04 +00:00
fmalita@google.com
7713c38dc0
Revert "Serialization of SkPictureImageFilter"
...
This reverts commit 227321b30106e57942929eb96fa5bc22544f6c9e.
Revert "Sanitizing source files in Housekeeper-Nightly"
This reverts commit baf28584b7636c01355f8d8d972e06aa7fb66d77.
TBR=robertphillips@google.com ,sugoi@google.com
Review URL: https://codereview.chromium.org/153583007
git-svn-id: http://skia.googlecode.com/svn/trunk@13356 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-07 05:55:39 +00:00
skia.committer@gmail.com
c5acc6c827
Sanitizing source files in Housekeeper-Nightly
...
git-svn-id: http://skia.googlecode.com/svn/trunk@13355 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-07 03:02:05 +00:00
commit-bot@chromium.org
4f6318d2e6
Serialization of SkPictureImageFilter
...
BUG=skia:
Committed: http://code.google.com/p/skia/source/detail?r=13347
R=senorblanco@google.com , reed@google.com , mtklein@google.com , sugoi@google.com , senorblanco@chromium.org , robertphillips@google.com , scroggo@google.com
Author: sugoi@chromium.org
Review URL: https://codereview.chromium.org/138063005
git-svn-id: http://skia.googlecode.com/svn/trunk@13354 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-07 02:09:50 +00:00
reed@google.com
70ac79b754
use new instead of createCompatibleDevice, since we know the subclass we want
...
BUG=skia:
R=bsalomon@google.com
Review URL: https://codereview.chromium.org/141443009
git-svn-id: http://skia.googlecode.com/svn/trunk@13353 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-06 22:03:17 +00:00
reed@google.com
ace135453d
impl getROPixels for gpu SkImage
...
BUG=skia:
R=jvanverth@google.com
Review URL: https://codereview.chromium.org/150513005
git-svn-id: http://skia.googlecode.com/svn/trunk@13352 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-06 22:00:58 +00:00
commit-bot@chromium.org
0e8c8ef8d1
Disable NEON procs for SkBlitMask_D32_A8 until we can diagnose the source of the SIGILL chrashes seen in chromium.
...
BUG=2067
R=reed@google.com , kevin.petit.arm@gmail.com , mtklein@google.com
Author: djsollen@google.com
Review URL: https://codereview.chromium.org/132393007
git-svn-id: http://skia.googlecode.com/svn/trunk@13351 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-06 21:27:40 +00:00
reed@google.com
31b3044af4
replace impl of SkLightingColorFilter with SkColorMatrixFilter
...
BUG=skia:
R=djsollen@google.com
Review URL: https://codereview.chromium.org/135123008
git-svn-id: http://skia.googlecode.com/svn/trunk@13350 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-06 20:59:47 +00:00
commit-bot@chromium.org
6f0ba479a8
rebaseline_server: add "show only"/"show all" buttons to some columns
...
BUG=skia:2143
NOTRY=True
R=bsalomon@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/156773003
git-svn-id: http://skia.googlecode.com/svn/trunk@13349 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-06 20:22:25 +00:00
robertphillips@google.com
8b4799a98b
Revert of r13347 (Serialization of SkPictureImageFilter - https://codereview.chromium.org/138063005 ) due to bump in skp file format
...
git-svn-id: http://skia.googlecode.com/svn/trunk@13348 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-06 18:47:25 +00:00
commit-bot@chromium.org
670b98ea5d
Serialization of SkPictureImageFilter
...
BUG=skia:
R=senorblanco@google.com , reed@google.com , mtklein@google.com , sugoi@google.com , senorblanco@chromium.org , robertphillips@google.com , scroggo@google.com
Author: sugoi@chromium.org
Review URL: https://codereview.chromium.org/138063005
git-svn-id: http://skia.googlecode.com/svn/trunk@13347 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-06 18:06:14 +00:00
reed@google.com
d5808bd35a
add inital gm for colorfilters
...
BUG=skia:
R=djsollen@google.com
Review URL: https://codereview.chromium.org/140393005
git-svn-id: http://skia.googlecode.com/svn/trunk@13346 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-06 16:53:25 +00:00
commit-bot@chromium.org
4736ed1a0a
Add ifdef to avoid "not defined" compiler warnings for VS checks
...
BUG=skia:2130
R=reed@google.com
Author: hcm@google.com
Review URL: https://codereview.chromium.org/153093004
git-svn-id: http://skia.googlecode.com/svn/trunk@13345 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-06 16:26:08 +00:00
commit-bot@chromium.org
8933563174
Scripts to generate Android.mk for framework Skia.
...
In order to create Android.mk, run
>> python platform_tools/android/bin/gyp_to_android.py
For the change in the Android.mk file, see
https://googleplex-android-review.git.corp.google.com/#/c/408170/
(SkipBuildbotRuns)
BUG=skia:1975
R=djsollen@google.com , epoger@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/140503007
git-svn-id: http://skia.googlecode.com/svn/trunk@13344 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-06 16:13:00 +00:00
commit-bot@chromium.org
1c188ed9fa
rebaseline_server: get "image size" working again
...
BUG=skia:2134
NOTRY=True
R=rmistry@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/155973003
git-svn-id: http://skia.googlecode.com/svn/trunk@13343 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-06 15:17:28 +00:00
robertphillips@google.com
940e3bac13
Added newline at end of MatrixClipCollapseTest.cpp
...
git-svn-id: http://skia.googlecode.com/svn/trunk@13342 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-06 14:57:20 +00:00
reed@google.com
2776e01d2c
return NULL not false for a void* failure
...
git-svn-id: http://skia.googlecode.com/svn/trunk@13341 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-06 14:30:44 +00:00
robertphillips@google.com
1f71846e5c
Add test harness for matrix/clip state collapsing
...
https://codereview.chromium.org/133003006/
git-svn-id: http://skia.googlecode.com/svn/trunk@13340 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-06 14:22:47 +00:00
reed@google.com
4f7c61583b
add ways to peer into an image to get its pixels
...
BUG=skia:
R=bsalomon@google.com , scroggo@google.com
Review URL: https://codereview.chromium.org/155763004
git-svn-id: http://skia.googlecode.com/svn/trunk@13339 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-06 14:11:56 +00:00
reed@google.com
999da9c5e4
fix refcounting in SkImage::NewRasterData
...
git-svn-id: http://skia.googlecode.com/svn/trunk@13338 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-06 13:43:07 +00:00
senorblanco@chromium.org
9d6e7e5b13
Rebaselines for stragglers (Nexus4 Debug looks like it was really stale.)
...
TBR=fmalita@chromium.org
BUG=skia:
Review URL: https://codereview.chromium.org/148253008
git-svn-id: http://skia.googlecode.com/svn/trunk@13337 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-06 13:39:48 +00:00
skia.committer@gmail.com
7cd1ccc437
Sanitizing source files in Housekeeper-Nightly
...
git-svn-id: http://skia.googlecode.com/svn/trunk@13336 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-06 03:01:46 +00:00
senorblanco@chromium.org
c01eeb30d7
Add new baselines for tests affected by https://code.google.com/p/skia/source/detail?r=13323 , namely:
...
colorfilterimagefilter
dropshadowimagefilter
imageblur
imageblur_large
imagefiltersbase
imagefilterscropped
imagefiltersgraph
imagefiltersscaled
morphology
offsetimagefilter
spritebitmap
xfermodeimagefilter
TBR=fmalita@chromium.org
Review URL: https://codereview.chromium.org/156243003
git-svn-id: http://skia.googlecode.com/svn/trunk@13335 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-06 01:04:50 +00:00
senorblanco@chromium.org
67117808ee
Fix memory leak in imagefiltersclipped GM (found by valgrind).
...
TBR=robertphillips
Review URL: https://codereview.chromium.org/146193004
git-svn-id: http://skia.googlecode.com/svn/trunk@13334 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-06 00:36:01 +00:00
senorblanco@chromium.org
e629c7bc9f
Fix SkXPSDevice
...
Make SkImageFilter parameter for SkXPSDevice::allowImageFilter const to match
the SkBitmapDevice base class.
BUG=skia:2097
R=senorblanco@chromium.org
Review URL: https://codereview.chromium.org/156213002
git-svn-id: http://skia.googlecode.com/svn/trunk@13333 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-05 23:23:39 +00:00
senorblanco@chromium.org
0937335e6b
Mid-air collision: fix constness for onFilterImage in new test.
...
TBR=fmalita
BUG=skia:
Review URL: https://codereview.chromium.org/151323003
git-svn-id: http://skia.googlecode.com/svn/trunk@13332 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-05 23:04:28 +00:00
senorblanco@chromium.org
5251e2b91a
Fix a problem with scaled filters in tiled SkPicture playback.
...
The matrix used during filter application should be up-to-date, so that
the filter parameters can be scaled by the CTM (e.g., for hiDPI).
However, tiled playback defers setting of the matrix until after the
restore() call which draws the filter, which is too late. Moving the
setMatrix() ahead of the restore() sequence fixes the problem.
TEST=ImageFilterMatrixTest
R=junov@chromium.org
Review URL: https://codereview.chromium.org/145723007
git-svn-id: http://skia.googlecode.com/svn/trunk@13331 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-05 22:36:31 +00:00
commit-bot@chromium.org
ae761f7545
Make SkImageFilter methods const.
...
SkImageFilter had some non-const methods that could all be made const.
This is a first step towards making SkImageFilter immutable.
BUG=skia:2097
R=mtklein@google.com , reed@google.com , robertphillips@google.com
Author: dominikg@chromium.org
Review URL: https://codereview.chromium.org/148883011
git-svn-id: http://skia.googlecode.com/svn/trunk@13330 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-05 22:32:02 +00:00
bsalomon@google.com
d2e88f67c9
Rebase gpu images on N4 where persp rect clip is handled by convex poly clip effect.
...
BUG=skia:2136
Review URL: https://codereview.chromium.org/156203002
git-svn-id: http://skia.googlecode.com/svn/trunk@13329 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-05 22:29:35 +00:00
reed@google.com
c2d768c0cf
pass in the real rowBytes
...
git-svn-id: http://skia.googlecode.com/svn/trunk@13328 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-05 21:02:35 +00:00
bsalomon@google.com
78bfa79ebf
More canvas-state GM rebaselines
...
BUG=skia:2051
Review URL: https://codereview.chromium.org/150573015
git-svn-id: http://skia.googlecode.com/svn/trunk@13327 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-05 20:44:56 +00:00
bsalomon@google.com
d2184d61d1
canvas-state GM rebaselines after r13320.
...
BUG=skia:2051
Review URL: https://codereview.chromium.org/138833008
git-svn-id: http://skia.googlecode.com/svn/trunk@13326 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-05 20:34:44 +00:00
commit-bot@chromium.org
ceba079e3b
rebaseline_server: add bgcolor slider for pixelDiff column
...
BUG=skia:1904
NOTRY=True
R=robertphillips@google.com , rmistry@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/143273003
git-svn-id: http://skia.googlecode.com/svn/trunk@13325 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-05 19:49:17 +00:00
commit-bot@chromium.org
c69b0d0ee5
gm self-test: stop checking stdout and stderr
...
BUG=skia:1568
NOTRY=True
R=bsalomon@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/156023002
git-svn-id: http://skia.googlecode.com/svn/trunk@13324 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-05 18:44:31 +00:00
senorblanco@chromium.org
c4b12f19a4
Implement correct clipping for image filters.
...
Image filters in Skia currently clip the size of the the offscreen
bitmap used for filtering to the device clip bounds. This means that
any pixel-moving filter (e.g., blur) has edge artifacts at the clip
boundaries. This is problematic for tiling, where a single SkPicture
is played back with a clip set to the tile boundaries.
By implementing the onFilterBounds() traversal, and using it in
saveLayer() when a filter is present, we can clip the layer to the
expanded clip rect. Note that this requires that the traversal be
performed in reverse as compared to computeFastBounds(). (It's also
done in device space, unlike computeFastBounds()).
New test imagefiltersclipped tests pixel-moving filters when clipped
by various clip rects.
New test imageblurtiled tests tiled (compositor-style) rendering of
blurred text. There should be no artifacts at the tile boundaries.
BUG=337831
R=reed@google.com
Review URL: https://codereview.chromium.org/23011012
git-svn-id: http://skia.googlecode.com/svn/trunk@13323 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-05 17:51:22 +00:00
commit-bot@chromium.org
495157b991
Fix SampleApp for devices who don't support the full OpenGL API
...
R=bsalomon@google.com , ernstm@google.com
Author: djsollen@google.com
Review URL: https://codereview.chromium.org/137223006
git-svn-id: http://skia.googlecode.com/svn/trunk@13322 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-05 16:39:41 +00:00
scroggo@google.com
d4adfa37fb
Reland "Gyp file changes for the android framework."
...
Relands https://codereview.chromium.org/153093003/ , which was reverted
with https://skia.googlesource.com/skia.git/+/eb6295044b97db05ec40625dcebc2459b2a38a98
This reverts commit 6b32be1402eb6c549d5ba1db71860e24f9de2991.
BUG=skia:1975
R=djsollen@google.com
Review URL: https://codereview.chromium.org/154053002
git-svn-id: http://skia.googlecode.com/svn/trunk@13321 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-05 16:35:12 +00:00
commit-bot@chromium.org
8a13588b6f
Stop discarding in frag shader when coverage is zero and stencil writes are enabled
...
This fixes the corruption in the NVPR images here:
http://108.170.217.252:10117/builders/Test-Win8-ShuttleA-GTX660-x86-Debug/builds/251/steps/CompareGMs/logs/stdio
caused by:
https://skia.googlesource.com/skia.git/+/65ee5f424cb4dabd453268902c00086605d77c1d
The stencil path step writes inside and outside the clip when the clip is implemented by
a coverage effect. The path cover step then doesn't write outside of the clip because the FS
discards. This leaves stencil values outside of the clip non-zero which messed up subsequent
path or clip draws to those samples.
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/154623002
git-svn-id: http://skia.googlecode.com/svn/trunk@13320 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-05 16:29:12 +00:00
reed@google.com
76f10a3bd9
remove SkCanvas::createCompatibleDevice, and add SkCanvas::newSurface
...
BUG=skia:
R=bsalomon@google.com
Review URL: https://codereview.chromium.org/154163002
git-svn-id: http://skia.googlecode.com/svn/trunk@13319 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-05 15:32:21 +00:00
robertphillips@google.com
cb6adecd4d
Clean up SkPictureRecord.cpp
...
https://codereview.chromium.org/153983007/
git-svn-id: http://skia.googlecode.com/svn/trunk@13318 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-05 14:05:38 +00:00
robertphillips@google.com
30555b4c34
Wider perf trigger range for N4 and N7 perf improvements
...
https://codereview.chromium.org/141013019/
git-svn-id: http://skia.googlecode.com/svn/trunk@13317 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-05 13:35:56 +00:00
skia.committer@gmail.com
1dab403e44
Sanitizing source files in Housekeeper-Nightly
...
git-svn-id: http://skia.googlecode.com/svn/trunk@13316 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-05 03:01:48 +00:00
commit-bot@chromium.org
076f078a5e
Add magnifier to rebaseline server.
...
NOTRY=true
BUG=skia:1917
R=epoger@google.com
Author: rmistry@google.com
Review URL: https://codereview.chromium.org/149473005
git-svn-id: http://skia.googlecode.com/svn/trunk@13315 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-04 22:45:40 +00:00
commit-bot@chromium.org
967dee32ef
Make SkFontMgr interface const.
...
COLLABORATOR=mtklein@chromium.org
BUG=skia:
R=reed@google.com , bungeman@google.com , mtklein@chromium.org
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/134643028
git-svn-id: http://skia.googlecode.com/svn/trunk@13314 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-04 22:35:01 +00:00
robertphillips@google.com
0807ede86d
Compilation fix for r13311 (Update SkPictureRecord to allow some ops to be written separately - https://codereview.chromium.org/153883002/ )
...
git-svn-id: http://skia.googlecode.com/svn/trunk@13313 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-04 20:35:55 +00:00
robertphillips@google.com
f48a90c06f
Ignore failures on GalaxyNexus and NexusS
...
https://codereview.chromium.org/154223002/
git-svn-id: http://skia.googlecode.com/svn/trunk@13312 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-04 20:26:04 +00:00
robertphillips@google.com
5a63f24558
Update SkPictureRecord to allow some ops to be written separately
...
https://codereview.chromium.org/153883002/
git-svn-id: http://skia.googlecode.com/svn/trunk@13311 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-04 20:07:50 +00:00