Commit Graph

1153 Commits

Author SHA1 Message Date
caryclark
1049f1246e Now, path ops natively intersect conics, quads, and cubics in any combination. There are still a class of cubic tests that fail and a handful of undiagnosed failures from skps and fuzz tests, but things are much better overall.
Extended tests (150M+) run to completion in release in about 6 minutes; the standard test suite exceeds 100K and finishes in a few seconds on desktops.

TBR=reed
BUG=skia:3588

Review URL: https://codereview.chromium.org/1037953004
2015-04-20 08:31:59 -07:00
joshualitt
9e36c1a930 Start canonicalizing color for all A8 textblobs
BUG=skia:

Review URL: https://codereview.chromium.org/1076593002
2015-04-14 12:17:27 -07:00
borenet
22ecae88ee Blacklist desk_wikipedia pdf on Valgrind bots
BUG=skia:3506

Review URL: https://codereview.chromium.org/1056763004
2015-04-13 13:29:26 -07:00
msarett
3c309db75b Implementing filling for SkBmpCodec
The bmp codec currently returns kIncompleteInput
when the stream is truncated, which we treat as a
partial success.  However, we neglect the fill the
remaining pixels in the image, leaving these
uninitialized.

This CL addresses this problem by initializing the
remaining pixels in the image to default values.

BUG=skia:3257

Review URL: https://codereview.chromium.org/1075243003
2015-04-10 14:36:49 -07:00
stephana
195f62d07d BUG=skia:
Review URL: https://codereview.chromium.org/1054073003
2015-04-09 07:57:54 -07:00
Mike Klein
fbcf0bd7ff expand pdf/worldjournal blacklist entry to cover the new skp too
BUG=skia:

Review URL: https://codereview.chromium.org/1070013002
2015-04-09 06:03:22 -04:00
caryclark
95bc5f3495 change isNestedRect to isNestedFillRect
R=reed@google.com, bsalomon@google.com

Let isNested(Fill)Rect return true if drawn path describes filled
rectangles.

Review URL: https://codereview.chromium.org/1073473002
2015-04-08 08:34:15 -07:00
mtklein
929f63fecc Make --undefok a little louder now that we're using it all the time.
BUG=skia:

Review URL: https://codereview.chromium.org/1073483002
2015-04-08 08:30:38 -07:00
borenet
dfaebfba42 Remove get_uploaded hashes
Replaced with an inline script in
https://codereview.chromium.org/1068503002/

BUG=skia:3521

Review URL: https://codereview.chromium.org/1062873002
2015-04-06 13:19:26 -07:00
msarett
2f273a1ed0 Adding non-deterministic images to blacklist
BUG=skia:3653

Review URL: https://codereview.chromium.org/1054593006
2015-04-06 08:38:49 -07:00
borenet
09ed480906 Add --uninterestingHashesFile to DM
The file is expected to contain a list of strings. If the hash for
any result is in this file, don't write an image for it.

BUG=skia:3521

Review URL: https://codereview.chromium.org/1059363002
2015-04-03 14:15:33 -07:00
rmistry
80bd3ae9d7 Delete no longer needed pagesets, add new pagesets and make names more readable
Deleted all pagesets mentioned in https://code.google.com/p/skia/issues/detail?id=3574#c18
Added new Wikipedia and Unicodetable pagesets from https://code.google.com/p/skia/issues/detail?id=3574#c19

BUG=skia:3574
NOTRY=true

Review URL: https://codereview.chromium.org/1053253003
2015-04-03 08:22:51 -07:00
djsollen
54416de523 Update DM to allow Src's to have optional options.
Review URL: https://codereview.chromium.org/1059513002
2015-04-03 07:24:48 -07:00
borenet
4808757d7a Remove all code related to NaCl
BUG=skia:3600
DOCS_PREVIEW= https://skia.org/?cl=1036283002

Review URL: https://codereview.chromium.org/1036283002
2015-04-02 12:16:36 -07:00
borenet
11106f196e Skip desk_baidu skp on Valgrind bot
This has been running for 16 hours:
https://uberchromegw.corp.google.com/i/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Valgrind/builds/12/

BUG=skia:3506

Review URL: https://codereview.chromium.org/1056883002
2015-04-02 07:24:03 -07:00
rmistry
2a3c8493af Turn on Chromium's top 25 page set
#crskps

BUG=skia:
BUG=skia:3574
NOTRY=true
TBR=borenet

Review URL: https://codereview.chromium.org/1045153004
2015-03-31 10:59:15 -07:00
rmistry
39383a1946 Fix cr SKPs naming
#crskps

BUG=skia:
BUG=skia:3574

NOTRY=true

TBR=borenet

Review URL: https://codereview.chromium.org/1044193003
2015-03-31 08:03:02 -07:00
rmistry
5af9a3792f Turn on key mobile sites cr page set and delete dashed desktop
#crskps
BUG=skia:3574
BUG=skia:3605

NOTRY=true

Review URL: https://codereview.chromium.org/1040233004
2015-03-31 06:22:55 -07:00
rmistry
009b069f52 Fix gs.upload_dir_contents arguments mismatch
Fixing bug introduced by https://codereview.chromium.org/737123005

BUG=skia:
NOTRY=true
TBR=borenet

Review URL: https://codereview.chromium.org/1041003003
2015-03-31 05:20:12 -07:00
rmistry
49d093cef9 Add ability to capture SKPs from Chromium's pagesets
Also added support for pagesets with multiple pages in them.

 #crskps

BUG=skia:1723
BUG=skia:3574

NOTRY=true

Review URL: https://codereview.chromium.org/1047703003
2015-03-31 05:04:29 -07:00
kkinnunen
b4ee7ea834 webpages_playback.py: Support storing to local directories
Make webpages_playback support storing to local directories as an
alternative to Google Storage.

Rename argument --dest_gsbase to --data_store=<location>. Make this parameter
accept either gs:// url or directory for local file system storage.

Rename argument --upload_to_gs to --upload.

Implement file existence check, download and upload for the file
operation.
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/737123005
2015-03-31 00:18:27 -07:00
bungeman
5c9fa2844c Add option to embed font data into executable.
Some tools would like to be built with all resources embedded.
This change makes it possible to build a font manager which
uses font data embedded into the executable.

Review URL: https://codereview.chromium.org/1015723004
2015-03-30 12:53:48 -07:00
kkinnunen
f9310fe2be webpages_playback.py: Avoid crash when retrying to capture skp
Move the .wpr files after recording, in the recording retry loop.
Previously they were moved in the skp capture retry loop.

Review URL: https://codereview.chromium.org/1033223005
2015-03-29 22:33:16 -07:00
borenet
1e37d1762c Update [dm|nanobench]_flags for CPU/GPU split
TBR=mtklein
NOTREECHECKS=true
BUG=skia:2073

Review URL: https://codereview.chromium.org/1036223002
2015-03-27 05:42:18 -07:00
caryclark
54359294a7 cumulative pathops patch
Replace the implicit curve intersection with a geometric curve intersection. The implicit intersection proved mathematically unstable and took a long time to zero in on an answer.

Use pointers instead of indices to refer to parts of curves. Indices required awkward renumbering.

Unify t and point values so that small intervals can be eliminated in one pass.

Break cubics up front to eliminate loops and cusps.

Make the Simplify and Op code more regular and eliminate arbitrary differences.

Add a builder that takes an array of paths and operators.

Delete unused code.

BUG=skia:3588
R=reed@google.com

Review URL: https://codereview.chromium.org/1037573004
2015-03-26 07:52:43 -07:00
mtklein
ce86687310 pdf skp tabl_worldjournal.skp took 5 days to run on Valgrind
#notry

BUG=skia:
NOTRY=true

Review URL: https://codereview.chromium.org/1030263003
2015-03-26 05:12:13 -07:00
mtklein
36352bf5e3 C++11 override should now be supported by all of {bots,Chrome,Android,Mozilla}
NOPRESUBMIT=true

BUG=skia:
DOCS_PREVIEW= https://skia.org/?cl=1037793002

Review URL: https://codereview.chromium.org/1037793002
2015-03-25 18:17:32 -07:00
msarett
114912d4b9 Fix android_run_skia script to allow for larger blacklist
BUG=skia:

Review URL: https://codereview.chromium.org/1011653004
2015-03-25 12:28:33 -07:00
reed
0dc4dd6dda Revert of pathops version two (patchset #16 id:150001 of https://codereview.chromium.org/1002693002/)
Reason for revert:
ASAN investigation

Original issue's description:
> pathops version two
>
> R=reed@google.com
>
> marked 'no commit' to attempt to get trybots to run
>
> TBR=reed@google.com
>
> Committed: https://skia.googlesource.com/skia/+/ccec0f958ffc71a9986d236bc2eb335cb2111119

TBR=caryclark@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1029993002
2015-03-24 13:55:33 -07:00
tomhudson
7aa846c683 Revert of Enabling ico decoding with use of png and bmp decoders (patchset #10 id:280001 of https://codereview.chromium.org/1011343003/)
Reason for revert:
Reverting on suspicion of massive bot failures - possible command line too long?

Original issue's description:
> Enabling ico decoding with use of png and bmp decoders
>
> BUG=skia:3257
>
> Committed: https://skia.googlesource.com/skia/+/15bfd075d38e4422a477e22940d06a137f66cc97

TBR=scroggo@google.com,reed@google.com,djsollen@google.com,msarett@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:3257

Review URL: https://codereview.chromium.org/1022843005
2015-03-24 13:47:41 -07:00
msarett
15bfd075d3 Enabling ico decoding with use of png and bmp decoders
BUG=skia:3257

Review URL: https://codereview.chromium.org/1011343003
2015-03-24 12:24:27 -07:00
rmistry
6776a538f9 Increase timeout of ukwsj to get more consistent SKP captures
BUG=skia:3574
TBR=borenet
NOTRY=true

Review URL: https://codereview.chromium.org/1038443002
2015-03-24 10:58:37 -07:00
caryclark
ccec0f958f pathops version two
R=reed@google.com

marked 'no commit' to attempt to get trybots to run

TBR=reed@google.com

Review URL: https://codereview.chromium.org/1002693002
2015-03-24 07:28:17 -07:00
robertphillips
3e5c2b1041 Preserve texture compression when saving a revised skp from debugger
Without this CL, saving a revised skp out the debugger can greatly expand the memory it requires.

Review URL: https://codereview.chromium.org/1020103005
2015-03-23 05:46:51 -07:00
egdaniel
9a0f629973 Only use 256x256 tiles on hd2000 nanobench bots
Initial experiments did show that the 256 tile size fixed the hd2000 win7
nanobot failures. However it did not have any effect on other bots, so this
change is to move back to the larger tile size on all bots expect for the
hd2000.

BUG=skia:

Review URL: https://codereview.chromium.org/1022083002
2015-03-20 07:03:52 -07:00
egdaniel
89c2a540a3 Blacklist certain win7 gms that are never finishing on dm
BUG=skia:

Review URL: https://codereview.chromium.org/1013483004
2015-03-19 13:09:17 -07:00
reed
3ef71e343b guarded change to SkImageGenerator to make getInfo() const
BUG=skia:

Review URL: https://codereview.chromium.org/1017293002
2015-03-19 08:31:14 -07:00
mtklein
905d01b95a temporarily stifle Math test on TSAN bot
BUG=skia:3562

Review URL: https://codereview.chromium.org/1017283002
2015-03-18 14:06:56 -07:00
mtklein
e2aab90979 DM: disable image src type on Windows.
BUG=skia:

Review URL: https://codereview.chromium.org/1012183002
2015-03-17 12:52:16 -07:00
mtklein
eec84e324e Current RSS on linux and android too?
BUG=skia:

Review URL: https://codereview.chromium.org/1009313003
2015-03-17 10:24:49 -07:00
mtklein
18ef5ebf3b widen leak supression. looks like start_keepalive is sometimes inlined.
BUG=skia:

Review URL: https://codereview.chromium.org/1008873003
2015-03-16 15:06:00 -07:00
mtklein
1e237385ec Suppress keepalive thread leak in DM.
BUG=skia:

Review URL: https://codereview.chromium.org/1006143002
2015-03-16 06:59:19 -07:00
mtklein
de7665a6d5 Skip absurdly slow PDF tests on Valgrind bot.
Our Valgrind-with-keepalive CPU bot is still running its first run as I write
this.  It's been going ~48 hours.  'pdf gm fontmgr_iter' finished after ~19
hours.  'pdf image PANO_20121023_214540.jpg' still seems to be running.

After this, the next slowest will be '565 gm fontmgr_iter' at about 37 minutes.

TBR=borenet@google.com

BUG=skia:

Review URL: https://codereview.chromium.org/1003423002
2015-03-14 07:24:29 -07:00
mtklein
d1f7f990a1 Have DM and nanobench display times in minutes when they're above 60 seconds.
Getting tired of trying to divide in my head when reading Valgrind logs.

BUG=skia:

Review URL: https://codereview.chromium.org/1004703002
2015-03-12 10:29:32 -07:00
mtklein
95553d917c DM: display current memory usage (instead of peak) when available.
Seems strictly more useful.

This implements Mac and Windows, which seemed easy.  Don't know how to do this on Linux yet.

BUG=skia:

CQ_EXTRA_TRYBOTS=client.skia:Test-Mac10.9-MacMini6.2-HD4000-x86_64-Debug-Trybot

NOTREECHECKS=true
TBR=halcanary@google.com

Review URL: https://codereview.chromium.org/990723002
2015-03-12 08:24:21 -07:00
mtklein
22712569a5 Clean up poppler code.
We're not actually using it.

BUG=skia:3362
DOCS_PREVIEW= https://skia.org/?cl=1002493002

Review URL: https://codereview.chromium.org/1002493002
2015-03-11 11:55:14 -07:00
mtklein
cc99dbc57b Skip WritePixels on GalaxyS3
TBR=bsalomon@google.com

NOTREECHECKS=true

BUG=skia:

Review URL: https://codereview.chromium.org/994343003
2015-03-11 08:43:43 -07:00
mtklein
4e2d3be035 Don't run ResourceCache unit test on NexusPlayer.
TBR=bsalomon@google.com

BUG=skia:

Review URL: https://codereview.chromium.org/992203005
2015-03-10 11:55:18 -07:00
mtklein
7e78f3d0e7 Fix bug in Valgrind flags config.
'GPU' is in 'Test-Ubuntu14-GCE-NoGPU-x86_64-Release-Valgrind_CPU' too.

This means we're building it in no-GPU mode, and running it in no-CPU mode.
At least it finishes quite quickly this way (~10 seconds).

BUG=skia:

Review URL: https://codereview.chromium.org/992203004
2015-03-10 08:03:26 -07:00
rmistry
ba98761320 Add pageset for theverge
BUG=skia:3234

TBR=robertphillips
NOTRY=true
NOPRESUBMIT=true

Review URL: https://codereview.chromium.org/994923002
2015-03-10 05:00:08 -07:00