Commit Graph

56244 Commits

Author SHA1 Message Date
Michael Ludwig
575c921357 Account for hairline mode in rect op bounds for clipping
Disables the preApply() clip check for rects that are subpixel since the
bounds will not be correct, and avoids pre-applying clips to rects if
the result would turn into a subpixel draw.

Also disables hairline mode for rects that are not fully anti-aliased,
which showed up in the fast_constraint GMs where we'd tile an image and
the bottom/right edges were actually subpixel. Since the objective of
per-edge AA is for tiling, we don't want those subpixel edges to be
outset more than the original geometry would have been in a non-tiling
case.

Bug: skia:12164, chromium:1210170
Change-Id: I3bca4fc3e63b6f86f1da1ea7a5e5873d221755f7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/426437
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2021-07-13 17:33:13 +00:00
Julia Lavrova
3a44eb92e9 Apparently, line metrics should not include newlines
(Flutter doc is wrong)
Bug: skia:12127

Change-Id: I422a870d3cf6346cf8b37834fe89c846f804e236
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/423586
Commit-Queue: Julia Lavrova <jlavrova@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
2021-07-13 17:16:23 +00:00
skia-autoroll
51eb0ca549 Roll skcms from bae5e281e80f to ba17399285ce (1 revision)
https://skia.googlesource.com/skcms.git/+log/bae5e281e80f..ba17399285ce

2021-07-13 johnstiles@google.com Fix GCC 8.3 spurious warning when disabling -Wpsabi.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skcms-skia-autoroll
Please CC johnstiles@google.com,mtklein@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux-blink-rel
Tbr: johnstiles@google.com,mtklein@google.com
Change-Id: Ie44498b3083c90675dbc545cf15582510896bbef
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427477
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-07-13 16:48:24 +00:00
John Stiles
1edb41f4b3 Replace benjaminwagner@ and mtklein@ with rmistry@ and jcgregorio@.
Change-Id: I42e5d85057483f48bd081f0a95cd12568f5baa20
No-Try: true
Docs-Preview: https://skia.org/?cl=427496
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427496
Auto-Submit: John Stiles <johnstiles@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
2021-07-13 16:24:15 +00:00
Julia Lavrova
f3ee264564 Count trailing spaces when calculating glyph position
Bug: skia:12126
Change-Id: I1431ef3e63f8f07785a39887fa4ac6f60685c549
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/423636
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Julia Lavrova <jlavrova@google.com>
2021-07-13 14:54:13 +00:00
John Stiles
7729e0a97e Add hints to slicing-constructor error messages.
This is intended to make it easier for users porting GLSL code with
slicing constructors; the error message should make it clear that a
swizzle can be used here instead.

Change-Id: Ib03276ee910dfffd6146717dbd347b058f9940d1
Bug: skia:12193
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427200
Auto-Submit: John Stiles <johnstiles@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
2021-07-13 14:12:23 +00:00
John Stiles
82bbe606ec Add static to global nullopt symbol.
This should hopefully make the code safer in C++14 by not violating
the ODR.

(bungeman@: "I think in C++14 we will in fact get multiple definitions
of this symbol, though in C++17 we won't. Maybe we should mark this as
'static' so each TU gets its own zero byte copy in C++14 but in C++17
the 'static' will also be implicitly 'static inline' and we'll only get
one?)

Change-Id: I3570421fcf2be314e1baccff0783ded4a1078666
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427037
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
2021-07-13 14:00:03 +00:00
Robert Phillips
a92913e169 Make GrAuditTrail V1-only
This CL has some rough edges since some classes that use it (e.g., GrOpsTask) aren't yet V1-only. That said, the big CL has to be broken up somehow.

Bug: skia:11837
Change-Id: I41ed9982ca4664f893e447ba23c7aec59f42c964
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/426416
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2021-07-13 13:56:53 +00:00
John Stiles
2d25d28e51 Fix typo in doc-comments.
There is no "text" parameter. There is one called "tex".

Change-Id: Id8245a8222438c60f6c7bde0638e82bdfda0aa20
Bug: skia:12168
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427338
Commit-Queue: John Stiles <johnstiles@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2021-07-13 13:48:19 +00:00
Florin Malita
46f39a0aa0 [skottie] Avoid null ptr deref in motion tile effect
If the layer shader local matrix is non-invertible, we end up with a
null layer shader and a null phase pass shader.


Bug: oss-fuzz:36099
Change-Id: I4fead885709e10b42e3e447d960151e0eb29e7d9
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427337
Commit-Queue: Florin Malita <fmalita@chromium.org>
Commit-Queue: John Stiles <johnstiles@google.com>
Auto-Submit: Florin Malita <fmalita@chromium.org>
Reviewed-by: John Stiles <johnstiles@google.com>
2021-07-13 13:21:23 +00:00
skia-autoroll
224e3e257d Roll Chromium from 697e53f421f9 to 3572711a2c6a (478 revisions)
697e53f421..3572711a2c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-skia-autoroll
Please CC johnstiles@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Perf-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Release-All-CommandBuffer;skia/skia.primary:Test-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Debug-All-CommandBuffer
Tbr: johnstiles@google.com
Change-Id: I4bd97841b1f01645779cf8ca560c6c4125000909
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427299
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-07-13 04:58:25 +00:00
skia-autoroll
56a582a02a Roll ANGLE from 04cb5e1d7d89 to a8e98a238521 (6 revisions)
04cb5e1d7d..a8e98a2385

2021-07-12 penghuang@chromium.org Fix gl::Context::unMakeCurrent crashes
2021-07-12 jonahr@google.com Metal: Populate feature list in the Metal backend.
2021-07-12 jmadill@chromium.org Vulkan: Update cube map array support check.
2021-07-12 kpiddington@apple.com Upstream Apple's direct-to-Metal backend: compile libANGLE.
2021-07-12 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 65498c15ca60 to 4716eec90fcb (3 revisions)
2021-07-12 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from e09623df2fbf to 7d1a6713a379 (478 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-skia-autoroll
Please CC johnstiles@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE
Tbr: johnstiles@google.com
Change-Id: I776fb5c9289588e25837b10f6a3b999c2d224406
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427300
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-07-13 04:57:42 +00:00
recipe-roller
3a00e3e32e Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
3ae44290a5
  3ae4429 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 32a95f3b0fe5 to 5bf9df714d52

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I30f43a001ca7852eaf9bd0e3a4d4fcaebbf621fa
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427262
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2021-07-13 03:33:24 +00:00
recipe-roller
8de415a5ab Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
ed98a674d3
  ed98a67 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from dd7c1f6328ba to 32a95f3b0fe5

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I576d511c12a4557d9876be85a5b74f4bc6d3d7b4
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427261
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2021-07-13 02:37:25 +00:00
Mike Reed
63ec43cf55 Hide deprecated filterquality
Change-Id: Ia320f07c3836a077d6feafb4a59a7c89325f9fcd
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/425057
Reviewed-by: Yegor Jbanov <yjbanov@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2021-07-13 00:45:12 +00:00
recipe-roller
9cc34b450f Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
dbf72f7d7c
  dbf72f7 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 976b8c8c5bab to 3ed367eb9b38

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Iaed0578e57d163e4f96d7618c45552237801954c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427260
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2021-07-13 00:40:45 +00:00
recipe-roller
2ef07d8f1a Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
a99dd7a5b4~..59525ad99bc67ccbf8544aface7090e263578253
  a99dd7a (yuanjunh@google.com)
      Support running different py version simulation recipe tests
  59525ad (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from a96eb9a6140c to 976b8c8c5bab

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I4408eef2177af51ae13304d3021e2344d84ac123
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427280
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2021-07-12 23:41:41 +00:00
Chris Dalton
cc29a39d42 Never disable MSAA for FillRRectOp or GrDrawAtlasPathOp
Disabling MSAA on a multisampled target seems to always be a
de-optimization. This CL updates FillRRectOp and the tessellation atlas
ops to never disable MSAA because they both know how to render correctly
with or without MSAA enabled.

This also fixes a DDL bug that existed for FillRRectOp. It was
previously not detecting MSAA targets during onPrePrepare, which would
cause it to not outset enough for MSAA in the coverage ramps.

Bug: skia:12201
Change-Id: I599fe15a4ea182ac24cff375857dc309a32f2400
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427222
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2021-07-12 22:40:14 +00:00
recipe-roller
4fd997fee7 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (depot_tools) into this repository.

depot_tools:
f6228e1583
  f6228e1 (gavinmak@google.com)
      Revert "Add python3 support to bot_update recipe module"

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id70b3b2896b41f614a5300349f9bedd3d0a21868
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427259
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2021-07-12 22:38:25 +00:00
Chris Dalton
ea46ef3a9c Move clip optimizations into GrFillRRectOp
Adds a new clipToShape() virtual on GrDrawOp and implements it with
GrFillRRectOp. GrClipStack now calls this method before attempting to
clip by any other means.

Since clips are often round rects, and a round rect/round rect
intersection can itself be round rect, this allows GrFillRRectOp to
bypass clipping entirely in many cases.

Bug: chromium:928984
Change-Id: Ic19b3f481ee489e3ca85817ba11d132172089a11
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/426297
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
2021-07-12 21:58:21 +00:00
recipe-roller
e5ab6f242c Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
3e5d69181d
  3e5d691 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from d6dd9ccd0d44 to a1d51f0e9681

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ida009ef1ca6df6e8eb7ed68926edd3985c55c4e3
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427258
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2021-07-12 21:40:44 +00:00
recipe-roller
dd984dc75c Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
0c779035e7
  0c77903 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 55568bcb4c51 to 552d4b5271ba

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I6e293d5465cb14c1a2e6f55e3553cf7ce411020f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427256
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2021-07-12 20:42:30 +00:00
John Stiles
ce7cdcd7b4 Add test for SkSL vector-slice constructors.
SkSL does not support shrinking a vector via casting. Use a swizzle
instead.

Change-Id: Ieba78a05dad9c55f44c765924e28f0c7e1667a67
Bug: skia:12193
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427198
Auto-Submit: John Stiles <johnstiles@google.com>
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
2021-07-12 20:33:44 +00:00
John Stiles
010c0ec061 Allow swizzles on Boolean scalar expressions.
Boolean vector expressions already allowed swizzles (see the
SwizzleBoolConstants.sksl test), but scalars had been inadvertently
disallowed.

Change-Id: I89e7139db50981f0ee1a9a5086b02603e57f967d
Bug: skia:12195
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427196
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
2021-07-12 20:33:10 +00:00
Mike Reed
5643e55f09 Add flag for filterquality in flutter
Change-Id: I8612d58efcfac82b7924c680fd8fa91b6d48614f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/426956
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
2021-07-12 20:09:30 +00:00
Mike Reed
bccbec3147 Remove drawImageAtCurrentFrame
Unused by flutter
Would need variants for sampling options
Easy for clients to achieve this with other APIs

Change-Id: Ia8b29f5183f5b729b62ef35e87897d5312b38da5
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427197
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2021-07-12 20:08:40 +00:00
John Stiles
7f56b41fc0 Add scalar-swizzling tests for int and bool types.
Boolean scalar-swizzling is currently not working.

Change-Id: Icd965e4b64a12311d098168f65622110d5fb3437
Bug: skia:12195
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427038
Commit-Queue: John Stiles <johnstiles@google.com>
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
2021-07-12 19:54:40 +00:00
recipe-roller
0742e6ba2d Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (depot_tools, recipe_engine) into this repository.

depot_tools:
758807c0a4~..56c8a27430fc15fcb4b7beb02238ffc7541634ed
  758807c (gavinmak@google.com)
      Add python3 support to git recipe module
  56c8a27 (gavinmak@google.com)
      Add python3 support to gclient recipe module

recipe_engine:
3cfd9f735e
  3cfd9f7 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from f3122648f9ce to 55568bcb4c51

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I6971edf0b5a8f83e3789b6e6f826b860279946fe
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427091
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2021-07-12 19:32:41 +00:00
Ethan Nicholas
59ff4e2b78 Moved swizzle error checking into Swizzle::Convert
Change-Id: Id2676ffaba1dafc4a0485d99e1c5b87b990e0861
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/426976
Reviewed-by: John Stiles <johnstiles@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
2021-07-12 18:47:40 +00:00
recipe-roller
df3edc570f Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (depot_tools) into this repository.

depot_tools:
edb6e8c51f
  edb6e8c (gavinmak@google.com)
      Add python3 support to bot_update recipe module

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia810cb873e2bf3a3cb92083270199bc9ddca385d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427098
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2021-07-12 18:35:50 +00:00
John Stiles
526b0b92c9 Use value_or in getBlendMode_or.
Support for `value_or` was recently added to skstd::optional. (Thanks
herb@!)

Change-Id: Ie343f8d06f8a26bcd111af8334757c203944b052
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427036
Auto-Submit: John Stiles <johnstiles@google.com>
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Mike Reed <reed@google.com>
2021-07-12 17:50:40 +00:00
Robert Phillips
586d61dd7a Add V1 & V2 build bots
Bug: skia:11837
Change-Id: I1c431a67f00db8f04399b9e7f34b6d466c353d37
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/426556
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2021-07-12 17:48:18 +00:00
recipe-roller
c6b08485aa Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (depot_tools) into this repository.

depot_tools:
ff5a286637
  ff5a286 (sokcevic@google.com)
      Revert "Reland "Reland "Update gsutil to use gsutil version 4.6...

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I93e4c5cba4cd1ed0b037ec4db814a42a9f179930
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427116
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2021-07-12 17:39:10 +00:00
Chris Dalton
18e2de2c38 Fix the AppleM1 skpbench bot name
Change-Id: I2bfece61c84c4746a4370411ece2fb96c11c68d3
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427077
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2021-07-12 17:27:45 +00:00
Jim Van Verth
25a29e815d Make GrMtlAttachment a little more generic.
This adds a generic Make method for GrMtlAttachment to set up for
other attachment types, and changes some method names to better match
naming elsewhere in the Metal backend.

Bug: skia:12186
Change-Id: Ibc26ceba88e5d1217bdbcdc230809377e100da8e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/426656
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
2021-07-12 16:07:48 +00:00
John Stiles
ba1b2e1798 Disable SkSLMatrixToVectorCast test on Adreno 4/5/6xx.
The `ivec4(mat2)` case appears to throw Adreno 600 for a loop.

Change-Id: If703e6ae28a2214a00e54f5816563729b6f94d8d
Bug: skia:12192
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/426957
Commit-Queue: John Stiles <johnstiles@google.com>
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
2021-07-12 15:52:51 +00:00
John Stiles
49c417621b Shore up matrix/vector conversion tests.
The tests now check bool4-mat2 conversions, which fortunately do work,
and the vector-to-matrix tests include int and bool conversions as well.

Change-Id: I971271838a93081b9258deb7c1d13b7732fb2440
Bug: skia:12067
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/426757
Commit-Queue: John Stiles <johnstiles@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
2021-07-12 15:02:51 +00:00
John Stiles
cc2d9ccf07 Support the Boolean form of mix() in the Metal/SPIR-V backends.
Unfortunately, it's not easily testable since SkSLTest doesn't support
non-ES2 intrinsics.

Change-Id: I5b11e2af55fdc6fc29f48725aa977471c738b55e
Bug: skia:11222
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/426538
Auto-Submit: John Stiles <johnstiles@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
2021-07-12 14:34:48 +00:00
Ethan Nicholas
ebc9fadf35 Fixed some fixups not being applied to DSL code
Change-Id: I11c473a7a683282d6bd4f73d2c90f23de63f8cc7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/426557
Reviewed-by: Brian Osman <brianosman@google.com>
Reviewed-by: John Stiles <johnstiles@google.com>
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
2021-07-12 14:25:38 +00:00
John Stiles
f9ad6ec852 Add support for mat2-to-ivec4 conversions in SkSL.
The fuzzer quickly discovered that the newly introduced mat2-to-vec4
conversion code did not account for integer vectors. We now handle
`ivec4(mat2)` casts properly. This required some non-trivial
restructuring of the logic, but in the vast majority of cases, the types
will match and the end result will be identical.

Change-Id: If07c2fe4b4345bd767384b1802374910f65cd3f0
Bug: oss-fuzz:35998
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/426756
Auto-Submit: John Stiles <johnstiles@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
2021-07-12 14:09:18 +00:00
John Stiles
ac69e12664 Disable SkSLMatrixToVectorCast test on Adreno 330.
I say vector-matrix conversions were a bad idea all along, and the
Adreno 330 agrees with me.

Change-Id: I5355940b38d19141ee756141882d1e45160bce75
Bug: skia:12192
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/426936
Commit-Queue: John Stiles <johnstiles@google.com>
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
2021-07-12 14:07:49 +00:00
skia-autoroll
6c2764b93c Roll Chromium from a30ee6a7dc21 to 697e53f421f9 (500 revisions)
a30ee6a7dc..697e53f421

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-skia-autoroll
Please CC johnstiles@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Perf-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Release-All-CommandBuffer;skia/skia.primary:Test-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Debug-All-CommandBuffer
Tbr: johnstiles@google.com
Change-Id: Ia1ac640ff1f73b9646845c966b7d799864af6bc8
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/426779
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-07-12 05:07:26 +00:00
skia-autoroll
f8c98a51e6 Roll SwiftShader from 65498c15ca60 to 4716eec90fcb (3 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/65498c15ca60..4716eec90fcb

2021-07-09 thakis@chromium.org Stop building with -fno-operator-names
2021-07-09 thakis@chromium.org Stop defining _WINDLL
2021-07-09 thakis@chromium.org Remove workaround for 32-bit gold ICF bug

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-skia-autoroll
Please CC johnstiles@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Test-Debian10-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
Bug: None
Tbr: johnstiles@google.com
Change-Id: Ib7f621a236b68632ed5b9d4908ac5450cb6a46c8
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/426777
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-07-12 05:03:26 +00:00
skia-autoroll
6a0ee71a4e Roll ANGLE from 17a4b6e7f6bd to 04cb5e1d7d89 (13 revisions)
17a4b6e7f6..04cb5e1d7d

2021-07-11 pkasting@chromium.org Disable -Wimplicit-int-float-conversion for gles1_conform.
2021-07-09 syoussefi@chromium.org Vulkan: SPIR-V Gen: Fix size of matrix in std140 layout
2021-07-09 angle-autoroll@skia-public.iam.gserviceaccount.com Roll VK-GL-CTS from 875c981f4c59 to 6b9a0f391fa4 (5 revisions)
2021-07-09 syoussefi@chromium.org Vulkan: SPIR-V Gen: Fix image atomic built-ins
2021-07-09 syoussefi@chromium.org Vulkan: SPIR-V Gen: Take advantage of OpConstantNull
2021-07-09 timvp@google.com Skip BlitWithDepthUserToDefault for Linux+Intel+OpenGL
2021-07-09 timvp@google.com Skip ImageTests generating VUID-vkCmdDraw-None-02699
2021-07-09 jmadill@chromium.org Trace Tests: Update retracing script.
2021-07-09 jmadill@chromium.org Enable cube map arrays on SwiftShader.
2021-07-09 syoussefi@chromium.org Vulkan: Fix flipXY for 180 degree prerotation and spec consts
2021-07-09 syoussefi@chromium.org Vulkan: (Mostly) re-unify secondary command buffer interfaces
2021-07-09 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 9534228df856 to 65498c15ca60 (11 revisions)
2021-07-09 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 8b6aa9a9bcc2 to e09623df2fbf (441 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-skia-autoroll
Please CC johnstiles@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE
Tbr: johnstiles@google.com
Change-Id: Ib5f6f9b011551ba0837f0bb3dc96f4bb6ef27a00
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/426836
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-07-12 04:51:26 +00:00
Mike Reed
c98dbc6410 Hide deprecated SkPaint::getBlendMode
Callers should use asBlendMode or getBlendMode_or

Bug: skia:12173
Change-Id: I8b62527a2ae11c9bf0c1473c4fffa53b38aa7017
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/425756
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Yegor Jbanov <yjbanov@google.com>
2021-07-11 17:14:21 +00:00
skia-autoroll
c1478d6d32 Roll SK Tool from 80b49c278b92 to 431aedb0c26d
https://skia.googlesource.com/buildbot.git/+log/80b49c278b92..431aedb0c26d

2021-07-11 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update CIPD Packages

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/sk-tool-skia
Please CC borenet@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: borenet@google.com
Change-Id: I17b5b4354f5a6d64214b10e024cced9bbb72b203
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/426738
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-07-11 06:29:20 +00:00
recipe-roller
6fd6c47ab0 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
167376464a
  1673764 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 221a480cf34b to c2b27f4aa6aa

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I59a2efba8bcb22355e5f4772dc13c02498c5bb7a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/426716
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2021-07-10 10:39:20 +00:00
recipe-roller
8e97449b3e Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
dca9d71d5c
  dca9d71 (yiwzhang@google.com)
      py3: read stdin in binary mode as a regular file

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I3247c8ba76a3bfbb8c3f7ef5985f09abc8b45a0c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/426697
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2021-07-10 03:07:32 +00:00
recipe-roller
bc81b8a8bb Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
fc00fd8eb7
  fc00fd8 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 216f4168a93b to 221a480cf34b

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I7e25501004c72b71feddfafe7700035c074c779e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/426696
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2021-07-10 02:15:09 +00:00
recipe-roller
0ae73612b0 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
39fb70d443
  39fb70d (yiwzhang@google.com)
      engine: upgrade third-party library

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ie628e79c9c5c0c15047da2ed4c769e877ccd010f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/426083
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2021-07-09 23:36:10 +00:00