AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
40,133 Commits 1 Branch 0 Tags 544 MiB
cb32415753
Commit Graph

77 Commits

Author SHA1 Message Date
Ravi Mistry
2b1d179860 Have the RecreateSKPs bot upload to partner bucket 
It will upload to a directory that specifies the day the SKPs were created on:
gs://chrome-partner-telemetry/skps/2019-02-05

Bug: skia:8738
Change-Id: Ic6b719770e16408d580e552af41c1a41c682935a
Reviewed-on: https://skia-review.googlesource.com/c/188300
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
 2019-02-06 18:35:12 +00:00
Ravi Mistry
722b21ec72 Fix spreadsheets page set for RecreateSKPs bot 
Changed the URL and recaptured it's archive.
Also added a wait just in case.

NoTry: true
Bug: skia:8699
Change-Id: I7a829dc5e5156a68f683247b2eac66e90f8f3dad
Reviewed-on: https://skia-review.googlesource.com/c/185882
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
 2019-01-23 22:43:36 +00:00
Ravi Mistry
da17f1e7df Omit "espn" from key_mobile_sites_smooth in RecreateSKPs bot 
We already have a espn page set in Skia. Removing it from the chromium page
set does not lose us coverage.

NoTry: true
Bug: skia:7917
Change-Id: Ie5456ee7f8053ad904eb858eddfe564e3781249a
Reviewed-on: https://skia-review.googlesource.com/129303
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
 2018-05-20 14:53:16 +00:00
Ravi Mistry
02faa2b992 Fix capitalization of "twitter" in RecreateSKPs bot 
Case has suddenly started to matter.

NoTry: true
Bug: skia:7917
Change-Id: I6020622bd12481a2ac291caf565632451a3c8da5
Reviewed-on: https://skia-review.googlesource.com/128480
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
 2018-05-16 15:01:54 +00:00
Ravi Mistry
1693d43f37 Skip failing pageset from key_mobile_sites_smooth 
I would normally move the Chromium failing pagesets to be a Skia pageset but we used to have twitter.com/katyperry as a pageset a while ago and decided to remove it.

NoTry: true
Bug: skia:7348
Change-Id: I005b34b33f3bd2cc5e7948e1caad222156f36216
Reviewed-on: https://skia-review.googlesource.com/110120
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
 2018-02-26 20:00:08 +00:00
Ravi Mistry
5b92ce1b24 Blacklist mail.google.com from top25_desk pageset 
This will not lose coverage because we already have mail.google.com in Skia's
page sets.

NoTry: true
Bug: skia:7421
Change-Id: Ie3d335559e736e9177c9000f41dab25581230c8b
Reviewed-on: https://skia-review.googlesource.com/86500
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
 2017-12-18 17:34:42 +00:00
Ravi Mistry
9747711d94 Telemetry no longer supports credential files so remove support 
NoTry: true
Bug: skia:7401
Change-Id: I18b2dfe92b6e998d0799ed95cd5d735706428d1c
Reviewed-on: https://skia-review.googlesource.com/84540
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
 2017-12-13 16:06:34 +00:00
Ravi Mistry
19ea45ef53 Exclude URLs only for some page sets 
Bug: skia:7348
Change-Id: Iabf4c0d0bf83a0caeeb06027e5617a18900ac5fc
Reviewed-on: https://skia-review.googlesource.com/77180
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
 2017-11-29 16:26:57 +00:00
Ravi Mistry
0f8e4dbd28 Make RecreateSKPs bot fail if capturing SKPs fails + exclude failing page sets 
Bug: skia:7348
Change-Id: I8dd6337d2efeb1aaa71ac41fcb82b9a22bbd7531
Reviewed-on: https://skia-review.googlesource.com/76220
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
 2017-11-28 17:30:27 +00:00
Ravi Mistry
698edfecef Chromium lkgr is no longer updated. Use lkcr 
Bug: skia:6916
Change-Id: I16badf80c3b34e517b8baab161150c9434f325aa
Reviewed-on: https://skia-review.googlesource.com/30100
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
 2017-08-03 12:41:36 +00:00
Ravi Mistry
0d056ba473 Update webpages_playback.py to use the new Golang impl of WPRs 
NoTry: true
Bug: skia:6901
Change-Id: I1a0dc706f9494c261c2f609df81a37cc60970fdd
Reviewed-on: https://skia-review.googlesource.com/30060
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
 2017-08-02 16:56:16 +00:00
Ravi Mistry
863ffef385 Do not move over webpage archives, they are needed for capturing SKPs 
NoTry: true
Bug: skia:6850
Change-Id: I35ac2c10ae58561ab5424033d9bb5e14b75c526f
Reviewed-on: https://skia-review.googlesource.com/24327
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
 2017-07-18 17:29:14 +00:00
borenet
27f93e00d2 RecreateSKPs: Fix another .join() issue 
BUG=skia:5843
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2429513002

Review-Url: https://codereview.chromium.org/2429513002
 2016-10-17 08:09:34 -07:00
borenet
7787463668 RecreateSKPs: Fix GoogleStorageDataStore.delete_path 
BUG=skia:5843
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2423093002

Review-Url: https://codereview.chromium.org/2423093002
 2016-10-17 05:12:10 -07:00
borenet
7535867371 More fixes for webpages_playback 
BUG=skia:5843
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2409753002

Review-Url: https://codereview.chromium.org/2409753002
 2016-10-10 13:20:49 -07:00
borenet
1cebf7b450 webpages_playback: Fix GS path with extra '/' 
BUG=skia:5843
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2409593002

Review-Url: https://codereview.chromium.org/2409593002
 2016-10-10 08:14:11 -07:00
borenet
644638c037 webpages_playback: use gsutil instead of API, no shell_utils 
BUG=skia:5843
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2406863002

Review-Url: https://codereview.chromium.org/2406863002
 2016-10-10 05:57:18 -07:00
borenet
a86952a5ef webpages_playback: use new skia-skps bucket 
BUG=skia:2969
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2393043003

Review-Url: https://codereview.chromium.org/2393043003
 2016-10-05 08:23:04 -07:00
Ravi Mistry
57d6965562 Further increase run_benchmark timeout 
Looks like the chromium page sets still hit the 10 min timeout.

BUG=skia:5700

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2342
# This code is not exercised by trybots.
NOTRY=true

Change-Id: I57aba4c1541a840d7e4e97112a6485abc20aa3c7
Reviewed-on: https://skia-review.googlesource.com/2342
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
 2016-09-08 13:13:43 +00:00
rmistry
fd7f867a05 Increase run_benchmarks timeout because the two Chromium page sets can take a while 
BUG=skia:5700
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2298453002
# Trybots do not exercise this code.
NOTRY=true
TBR=borenet

Review-Url: https://codereview.chromium.org/2298453002
 2016-08-30 11:50:23 -07:00
borenet
1413d52c53 Speculative fix for SKP partner-dir upload 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2229433002

Review-Url: https://codereview.chromium.org/2229433002
 2016-08-08 06:26:00 -07:00
borenet
2869847166 webpages_playback: Make --upload_to_partner_bucket work without --upload 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2182463002

Review-Url: https://codereview.chromium.org/2182463002
 2016-07-25 05:18:15 -07:00
borenet
85f0e63ca4 Add "skp" asset 
Don't get rid of SKP_VERSION and associated stuff just yet.

BUG=skia:5427
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2167763002
DOCS_PREVIEW= https://skia.org/?cl=2167763002

Review-Url: https://codereview.chromium.org/2167763002
 2016-07-21 10:27:00 -07:00
rmistry
afaf496910 Add catapult to RecreateSKPs bot's PYTHONPATH 
TBR=borenet
BUG=skia:5024
NOTRY=true
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1747623002

Review URL: https://codereview.chromium.org/1747623002
 2016-02-27 10:04:57 -08:00
rmistry
37ed996f2d Do not upload to trusted partner's bucket if it is a dry run 
BUG=skia:3751
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1665803002

# Trybots do not exercise this code.
NOTRY=true

Review URL: https://codereview.chromium.org/1665803002
 2016-02-03 07:08:02 -08:00
rmistry
f5e83951ad Fix delete_path in webpages_playback.py 
BUG=skia:3751
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1662673003

# Trybots do not exercise this code.
NOTRY=true

Review URL: https://codereview.chromium.org/1662673003
 2016-02-03 05:58:31 -08:00
rmistry
c33c79c97d Delete skp dir in partner bucket before uploading 
BUG=skia:3751
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1660363002

# Trybots do not exercise this code.
NOTRY=true
TBR=borenet

Review URL: https://codereview.chromium.org/1660363002
 2016-02-03 04:27:54 -08:00
rmistry
8870e94fe3 Recreate SKPs in a single directory for trusted partners. 
Context: https://bugs.chromium.org/p/skia/issues/detail?id=3751#c15

BUG=skia:3751
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1662693002

# Trybots do not run this code
NOTRY=true
TBR=borenet

Review URL: https://codereview.chromium.org/1662693002
 2016-02-02 13:55:38 -08:00
rmistry
0575c495bc Upload SKPs to chrome-partner-telemetry 
Context:
https://bugs.chromium.org/p/skia/issues/detail?id=3751#c4
and
https://bugs.chromium.org/p/skia/issues/detail?id=3751#c6

BUG=skia:3751

# Trybots do not run this code.
NOTRY=true
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1658653002

Review URL: https://codereview.chromium.org/1658653002
 2016-02-01 10:27:05 -08:00
rmistry
3922cef805 Add 2 new SKPS to the buildbot repository 
BUG=skia:4713
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1534483004
NOTRY=true

Review URL: https://codereview.chromium.org/1534483004
 2015-12-17 09:40:30 -08:00
rmistry
16857e46bb Use AddStory instead of deprecated AddUserStory 
BUG=skia:3967
TBR=nednguyen
NOTRY=true

Review URL: https://codereview.chromium.org/1212843008
 2015-06-30 09:20:17 -07:00
rmistry
8f74c160c3 Revert of Use page_set_module.PageSet instead of story.StorySet (patchset #1 id:1 of https://codereview.chromium.org/1221553003/) 
Reason for revert:
This should no longer be required due to Ned's fix in https://codereview.chromium.org/1217823005/

Original issue's description:
> Use page_set_module.PageSet instead of story.StorySet
>
> BUG=skia:3967
> NOTRY=true
> TBR=nednguyen
>
> Committed: https://skia.googlesource.com/skia/+/7b971f0152299ae9a924252a9bfd220318497bdd

TBR=nednguyen@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:3967

Review URL: https://codereview.chromium.org/1214903008
 2015-06-30 08:22:25 -07:00
rmistry
7b971f0152 Use page_set_module.PageSet instead of story.StorySet 
BUG=skia:3967
NOTRY=true
TBR=nednguyen

Review URL: https://codereview.chromium.org/1221553003
 2015-06-30 05:03:05 -07:00
rmistry
dd3b12e270 Migrate PageSets to StorySets in buildbot page sets 
BUG=skia:3967
NOTRY=true
TBR=

Review URL: https://codereview.chromium.org/1203433002
 2015-06-30 03:54:07 -07:00
rmistry
4c58e085b2 Remove separate SP enabled SKP run since it is now on by default 
Yesterday's RecreateSKPs_Canary run looks good:
http://build.chromium.org/p/client.skia.fyi/builders/Housekeeper-Nightly-RecreateSKPs_Canary/builds/143

The generated SKPs look very reasonably sized:
gs://chromium-skia-gm/playback_386/skps

BUG=skia:
NOTRY=true

Review URL: https://codereview.chromium.org/1191113002
 2015-06-18 07:52:14 -07:00
nednguyen
6bad28de52 Replace self.NavigateToPage with self.Navigate(self.url) for skia page sets 
BUG=487800

Review URL: https://codereview.chromium.org/1131113005
 2015-05-16 15:47:02 -07:00
rmistry
23c5f51371 Handpick 16 Skia page sets to create SP enabled SKPs from 
Context is in: https://code.google.com/p/skia/issues/detail?id=3763#c18

NOTRY=true
BUG=skia:3763

Review URL: https://codereview.chromium.org/1115003002
 2015-04-29 10:15:07 -07:00
rmistry
385e88cc16 Create SP enabled SKPs from only the top_25_smooth page set. 
Context is here: https://code.google.com/p/skia/issues/detail?id=3763#c14

BUG=skia:3763
NOTRY=true

Review URL: https://codereview.chromium.org/1111273003
 2015-04-29 07:26:33 -07:00
rmistry
77772f3ca3 Update RecreateSKPs bot to also generate Slimming Paint SKPs with a separate prefix. 
Will only be committed after I get the go head in skia:3763.

BUG=skia:3763
NOTRY=true

Review URL: https://codereview.chromium.org/1065503007
 2015-04-28 08:27:19 -07:00
rmistry
aa31ee78ee Add ability to specify extra browser args and a prefix for SKP names to webpages_playback.py 
BUG=skia:3763
NOTRY=true

Review URL: https://codereview.chromium.org/1066933006
 2015-04-23 12:47:33 -07:00
rmistry
80bd3ae9d7 Delete no longer needed pagesets, add new pagesets and make names more readable 
Deleted all pagesets mentioned in https://code.google.com/p/skia/issues/detail?id=3574#c18
Added new Wikipedia and Unicodetable pagesets from https://code.google.com/p/skia/issues/detail?id=3574#c19

BUG=skia:3574
NOTRY=true

Review URL: https://codereview.chromium.org/1053253003
 2015-04-03 08:22:51 -07:00
rmistry
2a3c8493af Turn on Chromium's top 25 page set 
#crskps

BUG=skia:
BUG=skia:3574
NOTRY=true
TBR=borenet

Review URL: https://codereview.chromium.org/1045153004
 2015-03-31 10:59:15 -07:00
rmistry
39383a1946 Fix cr SKPs naming 
#crskps

BUG=skia:
BUG=skia:3574

NOTRY=true

TBR=borenet

Review URL: https://codereview.chromium.org/1044193003
 2015-03-31 08:03:02 -07:00
rmistry
5af9a3792f Turn on key mobile sites cr page set and delete dashed desktop 
#crskps
BUG=skia:3574
BUG=skia:3605

NOTRY=true

Review URL: https://codereview.chromium.org/1040233004
 2015-03-31 06:22:55 -07:00
rmistry
009b069f52 Fix gs.upload_dir_contents arguments mismatch 
Fixing bug introduced by https://codereview.chromium.org/737123005

BUG=skia:
NOTRY=true
TBR=borenet

Review URL: https://codereview.chromium.org/1041003003
 2015-03-31 05:20:12 -07:00
rmistry
49d093cef9 Add ability to capture SKPs from Chromium's pagesets 
Also added support for pagesets with multiple pages in them.

 #crskps

BUG=skia:1723
BUG=skia:3574

NOTRY=true

Review URL: https://codereview.chromium.org/1047703003
 2015-03-31 05:04:29 -07:00
kkinnunen
b4ee7ea834 webpages_playback.py: Support storing to local directories 
Make webpages_playback support storing to local directories as an
alternative to Google Storage.

Rename argument --dest_gsbase to --data_store=<location>. Make this parameter
accept either gs:// url or directory for local file system storage.

Rename argument --upload_to_gs to --upload.

Implement file existence check, download and upload for the file
operation.
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/737123005
 2015-03-31 00:18:27 -07:00
kkinnunen
f9310fe2be webpages_playback.py: Avoid crash when retrying to capture skp 
Move the .wpr files after recording, in the recording retry loop.
Previously they were moved in the skp capture retry loop.

Review URL: https://codereview.chromium.org/1033223005
 2015-03-29 22:33:16 -07:00
rmistry
6776a538f9 Increase timeout of ukwsj to get more consistent SKP captures 
BUG=skia:3574
TBR=borenet
NOTRY=true

Review URL: https://codereview.chromium.org/1038443002
 2015-03-24 10:58:37 -07:00
rmistry
ba98761320 Add pageset for theverge 
BUG=skia:3234

TBR=robertphillips
NOTRY=true
NOPRESUBMIT=true

Review URL: https://codereview.chromium.org/994923002
 2015-03-10 05:00:08 -07:00