Commit Graph

9732 Commits

Author SHA1 Message Date
robertphillips@google.com
cb3b615af7 Address some more valgrind issues
R=borenet@google.com

Review URL: https://codereview.chromium.org/59713010

git-svn-id: http://skia.googlecode.com/svn/trunk@12286 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-14 14:47:56 +00:00
edisonn@google.com
983c022bff pdfviewer: ignore flanky test
Review URL: https://codereview.chromium.org/64223008

git-svn-id: http://skia.googlecode.com/svn/trunk@12285 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-14 14:43:16 +00:00
skia.committer@gmail.com
73a5d53d96 Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@12283 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-14 07:02:31 +00:00
jvanverth@google.com
94f689afde Add rrect_aa and rrect_bw to ignore list
git-svn-id: http://skia.googlecode.com/svn/trunk@12282 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-13 22:00:11 +00:00
jvanverth@google.com
ef10b71d62 Ignore failures for blurrect_outer (needs rebaselining).
git-svn-id: http://skia.googlecode.com/svn/trunk@12281 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-13 21:36:30 +00:00
edisonn@google.com
b94c7d5ae8 pdfviewer: seed expectations for Mac 10.8 native renderer
Review URL: https://codereview.chromium.org/61683010

git-svn-id: http://skia.googlecode.com/svn/trunk@12280 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-13 21:32:12 +00:00
jvanverth@google.com
38ad8f1ff4 Add missing rebaselines for rrect_clip.
git-svn-id: http://skia.googlecode.com/svn/trunk@12279 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-13 21:23:56 +00:00
jvanverth@google.com
fe11e62064 Ignore Nexus4 failures for complexclip2_path_aa_gpu.
git-svn-id: http://skia.googlecode.com/svn/trunk@12278 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-13 21:06:30 +00:00
jvanverth@google.com
6a9e0b0d11 Rebaseline and enable GMs: pathopsskpclip roundrects rrect rrect_clip samplerstress
git-svn-id: http://skia.googlecode.com/svn/trunk@12277 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-13 20:54:49 +00:00
edisonn@google.com
608c35e5c4 pdfviewer: readobject can return null, and catalog can be null
Review URL: https://codereview.chromium.org/72053002

git-svn-id: http://skia.googlecode.com/svn/trunk@12276 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-13 20:23:40 +00:00
bungeman@google.com
04306921f4 Remove backward compatibility shims from SkStream.h.
R=reed@google.com

Review URL: https://codereview.chromium.org/68773009

git-svn-id: http://skia.googlecode.com/svn/trunk@12275 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-13 19:53:46 +00:00
jvanverth@google.com
19caf6d41b Rebaseline and enable GMs: convexpaths mixed_xfermodes nested_aa ninepatch-stretch pathfill pathinterior
git-svn-id: http://skia.googlecode.com/svn/trunk@12274 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-13 19:09:48 +00:00
reed@google.com
3443fd8886 move SkImageInfo into its own header
BUG=
R=djsollen@google.com

Review URL: https://codereview.chromium.org/71813002

git-svn-id: http://skia.googlecode.com/svn/trunk@12273 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-13 19:09:13 +00:00
jvanverth@google.com
eced153aed Update expectations for complexclip2_path_*.
git-svn-id: http://skia.googlecode.com/svn/trunk@12272 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-13 17:03:44 +00:00
reed@google.com
ec3ca87d33 Revert "Revert "switch GatherPixelRefs to use SkBaseDevice instead of SkBitmapDevice""
This reverts commit ff0152ec5e2a0faf38ae1a317c5d77df08139104.

BUG=

Review URL: https://codereview.chromium.org/68203018

git-svn-id: http://skia.googlecode.com/svn/trunk@12271 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-13 16:02:18 +00:00
reed@google.com
5308c83a36 drawPosTextOnPath is now deprecated, removing all overrides and impls
BUG=
R=djsollen@google.com

Review URL: https://codereview.chromium.org/61743017

git-svn-id: http://skia.googlecode.com/svn/trunk@12270 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-13 15:22:15 +00:00
borenet@google.com
b5d887eebc Whitespace change: Updates should be fixed
Review URL: https://codereview.chromium.org/59623010

git-svn-id: http://skia.googlecode.com/svn/trunk@12269 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-13 15:04:41 +00:00
robertphillips@google.com
e293005bd4 "Fix" another crash in DeferredCanvasTest on valgrind bot
https://codereview.chromium.org/71463003/



git-svn-id: http://skia.googlecode.com/svn/trunk@12265 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-13 14:26:52 +00:00
borenet@google.com
c4330cac79 Whitespace change to trigger builds after r12262.
"Fixes for auto-detecting access to the git mirror in Update"

Review URL: https://codereview.chromium.org/59533004

git-svn-id: http://skia.googlecode.com/svn/trunk@12263 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-13 13:59:44 +00:00
skia.committer@gmail.com
44a95d768d Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@12261 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-13 07:02:17 +00:00
reed@google.com
4d16470973 Revert "switch GatherPixelRefs to use SkBaseDevice instead of SkBitmapDevice"
This reverts commit 72958c374bdb9457419beeba7de1387da3293882.

BUG=

Review URL: https://codereview.chromium.org/58933007

git-svn-id: http://skia.googlecode.com/svn/trunk@12260 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-12 22:27:30 +00:00
reed@google.com
3f4bf51edd switch GatherPixelRefs to use SkBaseDevice instead of SkBitmapDevice
BUG=
R=robertphillips@google.com, scroggo@google.com

Review URL: https://codereview.chromium.org/70473003

git-svn-id: http://skia.googlecode.com/svn/trunk@12259 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-12 22:14:08 +00:00
edisonn@google.com
04068b13e5 pdfviewer: remove sqrt from the formula computing the scale (DPI is dots per inch, not dots per square inch)
Review URL: https://codereview.chromium.org/70793003

git-svn-id: http://skia.googlecode.com/svn/trunk@12258 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-12 21:56:39 +00:00
jvanverth@google.com
21ca4339a6 Rebaseline bench expectations for tabl_theverge.skp_tile_256x256_grid.
git-svn-id: http://skia.googlecode.com/svn/trunk@12257 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-12 20:58:41 +00:00
scroggo@google.com
09a5383adc Hide implementation details: SkFrontBufferedStream
R=reed@google.com

Review URL: https://codereview.chromium.org/25581002

git-svn-id: http://skia.googlecode.com/svn/trunk@12256 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-12 20:53:05 +00:00
commit-bot@chromium.org
367028330a Ignore Windows verylargebitmap GMs for 565 and 8888
BUG=Skia:1822
R=robertphillips@google.com, reed@google.com

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/68123010

git-svn-id: http://skia.googlecode.com/svn/trunk@12255 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-12 20:43:34 +00:00
commit-bot@chromium.org
30b1aafab0 [PDF] Speculative fix for chrome crash w/ SRC xfer mode.
BUG=chromium:316546
R=edisonn@google.com, reed@google.com

Author: vandebo@chromium.org

Review URL: https://codereview.chromium.org/61153003

git-svn-id: http://skia.googlecode.com/svn/trunk@12253 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-12 19:36:14 +00:00
djsollen@google.com
efc51b79a2 fix multithread related crashes in skpdiff
BUG=skia:1798
R=mtklein@google.com, scroggo@google.com

Review URL: https://codereview.chromium.org/60833002

git-svn-id: http://skia.googlecode.com/svn/trunk@12252 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-12 18:29:17 +00:00
commit-bot@chromium.org
21a0b10d7c Remove deprecated setIsOpaque() API from SkBitmap.
Clients we care (Blink, Chromium) were updated, so we can remove this now.

BUG=None
R=bsalomon@google.com, reed@google.com

Author: tfarina@chromium.org

Review URL: https://codereview.chromium.org/66723017

git-svn-id: http://skia.googlecode.com/svn/trunk@12251 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-12 18:16:34 +00:00
commit-bot@chromium.org
23a9121961 pdfviewer: compile pdfviewer in gm, only if the flag is set (currently we compile pdfviewer, even if it is not used)
R=scroggo@google.com, jvanverth@google.com

Author: edisonn@google.com

Review URL: https://codereview.chromium.org/68533003

git-svn-id: http://skia.googlecode.com/svn/trunk@12249 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-12 17:44:28 +00:00
robertphillips@google.com
5fa42d1621 "Fix" another crash on valgrind bot
https://codereview.chromium.org/70463002/



git-svn-id: http://skia.googlecode.com/svn/trunk@12248 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-12 17:33:02 +00:00
scroggo@google.com
cac8d01eab Override drawRRect in fake SkBitmapDevices.
Recent changes to SkBitmapDevice modified ::drawRRect() to take
an optimized drawing case. Some subclasses of SkBitmapDevice were
depending on the old behavior of calling ::drawPath(). Since they
do not draw, attempting to take the drawing path can cause problems.
For these subclasses, call drawPath() in the subclass.

R=reed@google.com, robertphillips@google.com

Review URL: https://codereview.chromium.org/70443002

git-svn-id: http://skia.googlecode.com/svn/trunk@12247 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-12 17:10:02 +00:00
senorblanco@chromium.org
f14bcd25e5 Remove some now-unused #ifdefs.
R=mtklein@google.com, mtklein, reed@google.com

Review URL: https://codereview.chromium.org/68473003

git-svn-id: http://skia.googlecode.com/svn/trunk@12246 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-12 16:46:43 +00:00
reed@google.com
23be7a58d9 add colortable enum to SkImage to ease interop between it and SkBitmap::Config
BUG=
R=halcanary@google.com, scroggo@google.com

Review URL: https://codereview.chromium.org/68853003

git-svn-id: http://skia.googlecode.com/svn/trunk@12245 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-12 16:11:07 +00:00
scroggo@google.com
5401cd019b Clean up after longjmp in SkImageDecoder_libpng.
In onDecodeInit, if longjmp sends us back to setjmp, destroy the
png_struct and info_ptr before returning false. Since the
PNGAutoClean has not been created yet, we were previously
leaking resources.

R=djsollen@google.com

Review URL: https://codereview.chromium.org/68453006

git-svn-id: http://skia.googlecode.com/svn/trunk@12244 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-12 15:30:06 +00:00
scroggo@google.com
f4dcea6020 Make bench_compare executable.
(SkipBuildbotRuns)

Review URL: https://codereview.chromium.org/63153005

git-svn-id: http://skia.googlecode.com/svn/trunk@12243 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-12 15:25:31 +00:00
bungeman@google.com
9fc5c68823 Fix leak detected in FontMgrMatchGM::onDraw by Valgrind.
git-svn-id: http://skia.googlecode.com/svn/trunk@12242 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-12 15:25:29 +00:00
scroggo@google.com
940ccc819b Add a script for running pdfviewer and comparing to existing results.
For quick, local checking to see how changes to pdfviewer have changed
PDF files.

Scripts were originally written by edisonn, and updated here for checkin.

R=epoger@google.com

Review URL: https://codereview.chromium.org/62103008

git-svn-id: http://skia.googlecode.com/svn/trunk@12241 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-12 14:52:47 +00:00
scroggo@google.com
5c7be9584c Use SkPathJoin and SkBasename in Pdfviewer.
Remove redundant code.

R=edisonn@google.com

Review URL: https://codereview.chromium.org/68263003

git-svn-id: http://skia.googlecode.com/svn/trunk@12240 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-12 14:43:44 +00:00
scroggo@google.com
086364b8e6 Changes to make SkPDiff more robost.
bitmap_to_cielab now returns a boolean. Instead of asserting that the
config is 8888, copy to 8888 (and return false on failure). This allows
skpdiff to work on Index8 bitmaps (without changing the code that does
the real work). If it returns false, do not attempt to create a pmetric.

In pmetric, exit early if maxLevels is <= 2, since this would crash later
in the function (creation of an ImageL3D if maxLevels is 0, and then the
creation of an array of a negative number of entries). maxLevels is small
if the width or height of the image is small (i.e. a bitmap with width 1
has maxLevels of 0).

R=djsollen@google.com

Review URL: https://codereview.chromium.org/65253002

git-svn-id: http://skia.googlecode.com/svn/trunk@12239 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-12 14:41:20 +00:00
scroggo@google.com
feeca3c7c2 Create nonPOD before setjmp.
With PNGAutoClean created after setjmp, when longjmp is called its destructor
is never called. Create it before setjmp, ensuring that its destructor is
called.

R=mtklein@google.com

Review URL: https://codereview.chromium.org/65283002

git-svn-id: http://skia.googlecode.com/svn/trunk@12238 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-12 14:38:41 +00:00
scroggo@google.com
59c3ab637b Fix a memory leak in SkGPipeCanvas.
In cross process mode (currently unused but tested on the bots),
SkGPipeCanvas has a tangle of circular references, which prevents
it from being deleted. Break the chain of references.

R=junov@chromium.org

Review URL: https://codereview.chromium.org/69633003

git-svn-id: http://skia.googlecode.com/svn/trunk@12237 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-12 14:32:38 +00:00
robertphillips@google.com
d6bea606c6 Silence another valgrind leak
https://codereview.chromium.org/68523006/



git-svn-id: http://skia.googlecode.com/svn/trunk@12236 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-12 14:05:15 +00:00
robertphillips@google.com
3bddb38e64 Fix crash in tests on valgrind bot
https://codereview.chromium.org/63543005/



git-svn-id: http://skia.googlecode.com/svn/trunk@12234 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-12 13:51:03 +00:00
rmistry@google.com
7bce8e2339 New SVG SKPs have been added to the buildbot repo. Triggering rebuilds.
git-svn-id: http://skia.googlecode.com/svn/trunk@12233 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-12 13:49:52 +00:00
skia.committer@gmail.com
11a253b686 Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@12232 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-12 07:02:05 +00:00
robertphillips@google.com
50a7600d05 Disable Blurred RR optimization in Chrome
https://codereview.chromium.org/68773005/



git-svn-id: http://skia.googlecode.com/svn/trunk@12231 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-12 01:16:56 +00:00
edisonn@google.com
73a7ea3ae0 Implement DPI for perspective bitmaps in PDF - we save the bitmap at the resolution requested.
R=reed@google.com, vandebo@chromium.org

Review URL: https://codereview.chromium.org/54913004

git-svn-id: http://skia.googlecode.com/svn/trunk@12230 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-11 20:55:15 +00:00
jvanverth@google.com
d830d13c27 Hook in rough distance field support for fonts
R=bsalomon@google.com

Review URL: https://codereview.chromium.org/41213003

git-svn-id: http://skia.googlecode.com/svn/trunk@12229 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-11 20:54:09 +00:00
senorblanco@chromium.org
05edd02a7c Implement a speedup for Y-only blurs by transposing.
R=mtklein@google.com, mtklein, reed@google.com
BUG=

Review URL: https://codereview.chromium.org/66413007

git-svn-id: http://skia.googlecode.com/svn/trunk@12227 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-11 20:12:34 +00:00