Commit Graph

11683 Commits

Author SHA1 Message Date
commit-bot@chromium.org
cced37d2c3 Revert of fix contents of render_pictures JSON summary (https://codereview.chromium.org/259703002/)
Reason for revert:
This appears to have caused regressions such as this one: http://108.170.220.120:10117/builders/Perf-Win7-ShuttleA-HD2000-x86-Release/builds/2117/steps/CheckForRegressions/logs/stdio

Original issue's description:
> fix contents of render_pictures JSON summary
>
> BUG=skia:2043,skia:2044,skia:1942
>
> Committed: http://code.google.com/p/skia/source/detail?r=14391

R=scroggo@google.com, epoger@google.com
TBR=epoger@google.com, scroggo@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2043,skia:2044,skia:1942

Author: caryclark@google.com

Review URL: https://codereview.chromium.org/251103004

git-svn-id: http://skia.googlecode.com/svn/trunk@14399 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-28 14:07:10 +00:00
bungeman@google.com
72b7bf859d Add missing include for r14397.
git-svn-id: http://skia.googlecode.com/svn/trunk@14398 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-28 14:06:01 +00:00
bungeman@google.com
b6ad00b17f Create SkGlyphCache globals with SkOnce.
VC++ will have magic statics with VS2014, but does not currently have them.
The thread unsafe implementation was causing the DirectWrite bots to randomly
crash when running multi-threaded tests, as gGlobals could be seen as NULL.

R=mtklein@google.com

Review URL: https://codereview.chromium.org/252713002

git-svn-id: http://skia.googlecode.com/svn/trunk@14397 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-28 13:58:35 +00:00
commit-bot@chromium.org
2349a1e369 git-sync-deps - handle symbolic links to directories
NOTRY=true
R=mtklein@google.com, borenet@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/258053005

git-svn-id: http://skia.googlecode.com/svn/trunk@14396 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-28 13:39:47 +00:00
commit-bot@chromium.org
c6661975f1 Xfermode: SSE2 implementation of darken&lighten mode
With SSE2 optimization, performance of the related two benchmarks will
improve about 45% on desktop i7-3770. Here are the data:
before:
Xfermode_Lighten   8888:  cmsecs =     33.60   565:  cmsecs =     48.84
 Xfermode_Darken   8888:  cmsecs =     34.16   565:  cmsecs =     48.99
after:
Xfermode_Lighten   8888:  cmsecs =     18.71   565:  cmsecs =     25.41
 Xfermode_Darken   8888:  cmsecs =     18.39   565:  cmsecs =     25.40

BUG=skia:
R=mtklein@google.com

Author: qiankun.miao@intel.com

Review URL: https://codereview.chromium.org/234653002

git-svn-id: http://skia.googlecode.com/svn/trunk@14395 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-28 13:26:53 +00:00
commit-bot@chromium.org
4e3d760af8 roll DEPS/android/jpeg to current master.
R=djsollen@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/255953003

git-svn-id: http://skia.googlecode.com/svn/trunk@14394 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-28 13:19:40 +00:00
commit-bot@chromium.org
fe78847f12 gpuveto tool
This CL adds a command line tool to report the suitableForGpuRasterization status of a single skp file.

R=bsalomon@google.com, rmistry@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/259663004

git-svn-id: http://skia.googlecode.com/svn/trunk@14393 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-28 13:19:34 +00:00
commit-bot@chromium.org
5729387fe0 Fast path for blurred round rects -- blur a small 9patch rect on the CPU
And nonlinearly stretch the resulting texture across proxy geometry.

BUG=
R=bsalomon@google.com, reed@google.com

Author: humper@google.com

Review URL: https://codereview.chromium.org/248613004

git-svn-id: http://skia.googlecode.com/svn/trunk@14392 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-28 13:19:23 +00:00
commit-bot@chromium.org
eecdcb9e8a fix contents of render_pictures JSON summary
BUG=skia:2043,skia:2044,skia:1942
R=scroggo@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/259703002

git-svn-id: http://skia.googlecode.com/svn/trunk@14391 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-28 13:18:39 +00:00
commit-bot@chromium.org
f672cead70 teach TSAN about SkSpinlock, SkRefCnt, and SkOnce
BUG=skia:

Committed: http://code.google.com/p/skia/source/detail?r=14353

NOTRY=true
NOTREECHECKS=true

Committed: http://code.google.com/p/skia/source/detail?r=14354

R=bsalomon@google.com, bungeman@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/247813005

git-svn-id: http://skia.googlecode.com/svn/trunk@14390 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-27 19:21:51 +00:00
commit-bot@chromium.org
a537627f06 Revert of teach TSAN about SkSpinlock, SkRefCnt, and SkOnce (https://codereview.chromium.org/247813005/)
Reason for revert:
breaks blink in roll

Original issue's description:
> teach TSAN about SkSpinlock, SkRefCnt, and SkOnce
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=14353
>
> NOTRY=true
> NOTREECHECKS=true
>
> Committed: http://code.google.com/p/skia/source/detail?r=14354

R=bsalomon@google.com, bungeman@google.com, mtklein@chromium.org
TBR=bsalomon@google.com, bungeman@google.com, mtklein@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/258783005

git-svn-id: http://skia.googlecode.com/svn/trunk@14389 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-27 19:14:46 +00:00
commit-bot@chromium.org
515a020d15 Whitespace change to test new 50 GCE compile bots.
TBR=
NOTREECHECKS=True
NOTRY=True
BUG=skia:2449

Author: rmistry@google.com

Review URL: https://codereview.chromium.org/257993002

git-svn-id: http://skia.googlecode.com/svn/trunk@14388 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-27 15:19:34 +00:00
skia.committer@gmail.com
e02c5dabbb Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@14387 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-26 03:04:35 +00:00
commit-bot@chromium.org
02a5a09334 Tune bench expectation algorithm parameters.
BUG=skia:2225
NOTRY=true
NOTREECHECKS=true
R=bsalomon@google.com
TBR=bsalomon@google.com

Author: bensong@google.com

Review URL: https://codereview.chromium.org/251813003

git-svn-id: http://skia.googlecode.com/svn/trunk@14386 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-25 22:03:39 +00:00
commit-bot@chromium.org
9d3fdbeb7b rebaseline_server unittests: output tkdiff lines when actuals don't match expectations
(SkipBuildbotRuns)
NOTREECHECKS=True
NOTRY=True
R=rmistry@google.com
TBR=rmistry

Author: epoger@google.com

Review URL: https://codereview.chromium.org/252583005

git-svn-id: http://skia.googlecode.com/svn/trunk@14385 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-25 19:59:44 +00:00
fmalita@google.com
270d44567b Re-add SkPictureStateTree::Iterator::draw() SaveFlags.
This is a SkPictureStateTree-only revert of r14253.

https://codereview.chromium.org/241453003

(It introduced ChromeOS regressions and the later r14319 fix got
reverted for different reasons).

R=bsalomon@google.com

Review URL: https://codereview.chromium.org/250803006

git-svn-id: http://skia.googlecode.com/svn/trunk@14384 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-25 15:37:00 +00:00
commit-bot@chromium.org
98c4e5229c Revert of Refactor SkPictureStateTree::Iterator to avoid use of kClip_SaveFlag. (https://codereview.chromium.org/246893005/)
Reason for revert:
https://code.google.com/p/chromium/issues/detail?id=366889

Original issue's description:
> Refactor SkPictureStateTree::Iterator to avoid use of kClip_SaveFlag.
>
> The current implementation relies on soon-to-be-deprecated
> kClip_SaveFlag behavior. Updated to use default save flags
> (kMatrixClip_SaveFlag) and stop assuming that the matrix survives
> restore() calls.
>
> R=junov@chromium.org,robertphillips@chromium.org,reed@google.com
>
> Committed: http://code.google.com/p/skia/source/detail?r=14319

R=junov@chromium.org, reed@google.com, robertphillips@chromium.org, robertphillips@google.com, fmalita@chromium.org
TBR=fmalita@chromium.org, junov@chromium.org, reed@google.com, robertphillips@chromium.org, robertphillips@google.com
NOTREECHECKS=true
NOTRY=true

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/250733007

git-svn-id: http://skia.googlecode.com/svn/trunk@14383 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-25 15:13:27 +00:00
commit-bot@chromium.org
fe41b8ffff one more tsan fix
BUG=skia:2460
R=mtklein@google.com
TBR=mtklein

Author: caryclark@google.com

Review URL: https://codereview.chromium.org/255893002

git-svn-id: http://skia.googlecode.com/svn/trunk@14382 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-25 14:03:52 +00:00
commit-bot@chromium.org
830628e7ce Add TSAN suppressions.
BUG=skia:1792,skia:2459
R=bsalomon@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/259843002

git-svn-id: http://skia.googlecode.com/svn/trunk@14381 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-25 13:59:27 +00:00
commit-bot@chromium.org
8ae32b327e bench rebase test cc9dbfb
R=robertphillips@google.com
TBR=robertphillips@google.com
NOTRY=true
NOTREECHECKS=true

Author: bensong@google.com

Review URL: https://codereview.chromium.org/257893002

git-svn-id: http://skia.googlecode.com/svn/trunk@14380 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-25 13:54:53 +00:00
commit-bot@chromium.org
0bcb8ca8a8 pathops debug globals use atomic increment
R=mtklein@google.com
TBR=mtklein
BUG=skia:2460

Author: caryclark@google.com

Review URL: https://codereview.chromium.org/257773007

git-svn-id: http://skia.googlecode.com/svn/trunk@14379 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-25 13:42:21 +00:00
commit-bot@chromium.org
8cb1daaa1e fix minor skp-found bugs
remove globals from pathops_unittest

BUG=skia:2460
TBR=mtklein

Author: caryclark@google.com

Review URL: https://codereview.chromium.org/239563004

git-svn-id: http://skia.googlecode.com/svn/trunk@14378 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-25 12:59:11 +00:00
commit-bot@chromium.org
e1ba93ee01 Xfermode: SSE2 implementation of colordodge&colorburn modes
With SSE2 optimization, performance of the related benchmarks will improve
about 45% for Xfermode_ColorDodge and little for Xfermode_ColorBurn on
desktop i7-3770. The little performance improvement for
Xfermode_ColorBurn is due to the portable version may mostly go the fast
if branch while the SSE2 version do the calculation for all the three
if-else branches. Here are the data:
before:
Xfermode_ColorDodge   8888:  cmsecs =  73.71   565:  cmsecs =  82.88
 Xfermode_ColorBurn   8888:  cmsecs =  46.46   565:  cmsecs =  52.23
after:
Xfermode_ColorDodge   8888:  cmsecs =  39.70   565:  cmsecs =  47.45
 Xfermode_ColorBurn   8888:  cmsecs =  45.02   565:  cmsecs =  51.15

BUG=skia:
R=mtklein@google.com

Author: qiankun.miao@intel.com

Review URL: https://codereview.chromium.org/224823004

git-svn-id: http://skia.googlecode.com/svn/trunk@14377 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-25 09:44:53 +00:00
commit-bot@chromium.org
6419a5edb8 Xfermode: SSE2 implementation of softlight_modeproc
With SSE2 optimization, performance of Xfermode_SoftLight will improve
about 30% on desktop i7-3770. Here are the data:
before:
Xfermode_SoftLight   8888:  cmsecs = 379.44   565:  cmsecs =  387.74
after:
Xfermode_SoftLight   8888:  cmsecs = 272.29   565:  cmsecs =  284.31

BUG=skia:
R=mtklein@google.com

Author: qiankun.miao@intel.com

Review URL: https://codereview.chromium.org/236363012

git-svn-id: http://skia.googlecode.com/svn/trunk@14376 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-25 08:34:41 +00:00
commit-bot@chromium.org
05764d2f77 Xfermode: SSE2 implementation of difference_modeproc
With SSE2 optimization, performance of Xfermode_Difference will improve
about 60% on desktop i7-3770. Here are the data:
before:
Xfermode_Difference   8888:  cmsecs =  51.10   565:  cmsecs =  66.39
after:
Xfermode_Difference   8888:  cmsecs =  21.10   565:  cmsecs =  29.33

BUG=skia:
R=mtklein@google.com

Author: qiankun.miao@intel.com

Review URL: https://codereview.chromium.org/234433003

git-svn-id: http://skia.googlecode.com/svn/trunk@14375 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-25 07:41:18 +00:00
commit-bot@chromium.org
f66967243c Use EXT_direct_state_access for path matrix manipulation
Use EXT_direct_state_access for path matrix manipulation when using
NV_path_rendering extension. This makes Chromium command buffer
integration easier, since the current matrix mode does not need to be
exposed as state and fewer function calls and enums are needed.

BUG=chromium:344330
R=bsalomon@google.com

Author: kkinnunen@nvidia.com

Review URL: https://codereview.chromium.org/245963009

git-svn-id: http://skia.googlecode.com/svn/trunk@14374 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-25 06:21:30 +00:00
commit-bot@chromium.org
0ea05d8491 Xfermode: SSE2 implementation of hardlight mode
With SSE2 optimization, performance of Xfermode_HardLight will improve
about 45% on desktop i7-3770. Here are the data:
before:
Xfermode_HardLight   8888:  cmsecs =  48.43   565:  cmsecs =  63.11
after:
Xfermode_HardLight   8888:  cmsecs =  25.71   565:  cmsecs =  33.46

BUG=skia:
R=mtklein@google.com

Author: qiankun.miao@intel.com

Review URL: https://codereview.chromium.org/229003004

git-svn-id: http://skia.googlecode.com/svn/trunk@14373 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-25 05:23:51 +00:00
skia.committer@gmail.com
cc9dbfb1d2 Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@14372 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-25 03:05:58 +00:00
commit-bot@chromium.org
b004b8e22f Xfermode: SSE2 implementation of exclusion_modeproc
With SSE2 optimization, performance of Xfermode_Exclusion will improve
about 50% on desktop i7-3770. Here are the data:
before:
Xfermode_Exclusion   8888:  cmsecs =  40.17   565:  cmsecs = 55.22
after:
Xfermode_Exclusion   8888:  cmsecs =  18.53   565:  cmsecs = 26.55

BUG=skia:
R=mtklein@google.com

Author: qiankun.miao@intel.com

Review URL: https://codereview.chromium.org/233733005

git-svn-id: http://skia.googlecode.com/svn/trunk@14371 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-25 02:59:04 +00:00
commit-bot@chromium.org
7bf10152b1 Xfermode: SSE2 implementation of overlay_modeproc
With SSE2 optimization, performance of Xfermode_Overlay will improve
about 35% on desktop i7-3770. Here are the data:
before:
Xfermode_Overlay   8888:  cmsecs =     44.17   565:  cmsecs =     59.27
after:
Xfermode_Overlay   8888:  cmsecs =     28.30   565:  cmsecs =     35.84

BUG=skia:
R=mtklein@google.com

Author: qiankun.miao@intel.com

Review URL: https://codereview.chromium.org/232783002

git-svn-id: http://skia.googlecode.com/svn/trunk@14370 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-25 02:08:31 +00:00
robertphillips@google.com
b950c6fd71 Fix r14368 (First pass at GPU veto) for non-GPU builds
https://codereview.chromium.org/255733002/



git-svn-id: http://skia.googlecode.com/svn/trunk@14369 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-25 00:02:12 +00:00
commit-bot@chromium.org
e2cb12a82a First pass at GPU veto
As a short term solution this CL collects information during the recording process for use in suitableForGpuRasterization.

BUG=366495
R=bsalomon@google.com, reed@google.com, alokp@chromium.org

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/251533004

git-svn-id: http://skia.googlecode.com/svn/trunk@14368 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-24 21:53:13 +00:00
commit-bot@chromium.org
d70fa2013a Deprecate SaveFlags use in the public SkCanvas API.
Because we still have internal users for now (to support the deprecated
mode), this CL introduces an external-only variant of deprecation.

Chromium is no longer using the deprecated methods, but Android may need
to suppress SK_ATTR_EXTERNALLY_DEPRECATED warnings.

R=reed@google.com, robertphillips@google.com, scroggo@google.com, bungeman@google.com, mtklein@google.com

Author: fmalita@chromium.org

Review URL: https://codereview.chromium.org/246023008

git-svn-id: http://skia.googlecode.com/svn/trunk@14367 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-24 21:51:58 +00:00
bsalomon@google.com
0b27f2ec0f Fix int->scalar warning on windows
Review URL: https://codereview.chromium.org/257693002

git-svn-id: http://skia.googlecode.com/svn/trunk@14366 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-24 21:23:37 +00:00
commit-bot@chromium.org
04f03d1fad Add GM that exercises SkCanvas::discard()
R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/252443007

git-svn-id: http://skia.googlecode.com/svn/trunk@14365 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-24 21:03:00 +00:00
commit-bot@chromium.org
d0306a1593 Revert of Add nanosecond timer. (https://codereview.chromium.org/250243002/)
Reason for revert:
breaks EVERYTHING

Original issue's description:
> Add nanosecond timer.
>
> I've been finding it hard to get enough resolution out of our existing timers when measuring really tiny pictures.
>
> BUG=skia:2378
>
> Committed: http://code.google.com/p/skia/source/detail?r=14362

R=bsalomon@google.com, bungeman@google.com, mtklein@chromium.org
TBR=bsalomon@google.com, bungeman@google.com, mtklein@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:2378

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/258703002

git-svn-id: http://skia.googlecode.com/svn/trunk@14364 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-24 20:17:24 +00:00
bsalomon@google.com
f1c0135425 Rework ATI driver suppressions for bench valgrind
Review URL: https://codereview.chromium.org/256623003

git-svn-id: http://skia.googlecode.com/svn/trunk@14363 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-24 20:12:38 +00:00
commit-bot@chromium.org
74b43a9d4c Add nanosecond timer.
I've been finding it hard to get enough resolution out of our existing timers when measuring really tiny pictures.

BUG=skia:2378
R=bsalomon@google.com, mtklein@google.com, bungeman@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/250243002

git-svn-id: http://skia.googlecode.com/svn/trunk@14362 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-24 20:04:20 +00:00
commit-bot@chromium.org
e00ad689d0 Remove unused include.
vector is not used by this file (and this breaks the Android framework
build).

R=sugoi@google.com, bungeman@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/251483004

git-svn-id: http://skia.googlecode.com/svn/trunk@14361 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-24 19:30:16 +00:00
commit-bot@chromium.org
915b972a81 Reland "Properly set alpha type in webp decode."
Also use the newer setConfig function.

Add a test to confirm that we set the alpha type properly.

Add some images with alpha for testing. (These images are also
beneficial for the compare_unpremul test, which was previously
not meaningful on 100% opaque images.)

All of the added images are in the public domain. They were
taken from https://developers.google.com/speed/webp/gallery2:

yellow_rose:
"Free Stock Photo in High Resolution - Yellow Rose 3 - Flowers"
Image Author: Jon Sullivan
This file is in the public domain.
http://www.public-domain-photos.com/free-stock-photos-4/flowers/yellow-rose-3.jpg

baby_tux:
"baby tux for my user page"
Image Author: Fizyplankton
This file is in the public domain.
http://www.minecraftwiki.net/images/8/85/Fizyplankton.png

NOTRY=true

TBR=halcanary@google.com

BUG=skia:2388

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/252423008

git-svn-id: http://skia.googlecode.com/svn/trunk@14360 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-24 18:55:13 +00:00
commit-bot@chromium.org
1f64a21df9 Fix build: these asserts are always now true, which GCC warns about
R=mtklein@google.com
TBR=reed
NOTRY=true
NOTREECHECKS=true

BUG=skia:

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/256453007

git-svn-id: http://skia.googlecode.com/svn/trunk@14359 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-24 18:45:17 +00:00
commit-bot@chromium.org
44566e2a15 Fix android_gdbserver script to work with changes from a137675.
Also stop assuming ANDROID_ARCH one of x86 or arm.

NOTRY=true
R=mtklein@google.com, djsollen@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/256413006

git-svn-id: http://skia.googlecode.com/svn/trunk@14358 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-24 18:36:36 +00:00
commit-bot@chromium.org
b45bd1f7fd fix int/size_t warnings in pipe
BUG=skia:
R=scroggo@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/256443002

git-svn-id: http://skia.googlecode.com/svn/trunk@14357 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-24 18:17:30 +00:00
commit-bot@chromium.org
7eb529fb72 simplify tools/xsan_build now that make runs ninja
BUG=skia:
R=borenet@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/257613004

git-svn-id: http://skia.googlecode.com/svn/trunk@14356 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-24 18:16:13 +00:00
commit-bot@chromium.org
76a3b2abd0 Remove support for inheriting the paint color from SkColorShader
BUG=skia:2453
R=reed@google.com, mtklein@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/248033003

git-svn-id: http://skia.googlecode.com/svn/trunk@14355 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-24 16:54:46 +00:00
commit-bot@chromium.org
6d4e90a2d4 teach TSAN about SkSpinlock, SkRefCnt, and SkOnce
BUG=skia:

Committed: http://code.google.com/p/skia/source/detail?r=14353

NOTRY=true
NOTREECHECKS=true
R=bsalomon@google.com, bungeman@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/247813005

git-svn-id: http://skia.googlecode.com/svn/trunk@14354 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-24 15:40:46 +00:00
commit-bot@chromium.org
1d24eb20e7 teach TSAN about SkSpinlock, SkRefCnt, and SkOnce
BUG=skia:
R=bsalomon@google.com, bungeman@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/247813005

git-svn-id: http://skia.googlecode.com/svn/trunk@14353 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-24 15:33:54 +00:00
commit-bot@chromium.org
f0ae5e471b Proof of adoption in SkRecord::replace.
It used to be an unenforced requirement that callers take ownership of
the command which was replaced when calling SkRecord::replace.  Now we
can enforce it, by splitting replace into two modes:
  - T* replace(i): always destroys the existing command for you
  - T* replace(i, proofOfAdoption): proofOfAdoption is checked to make
    sure the caller has adopted the existing command before replacing it.

BUG=skia:2378
R=fmalita@chromium.org, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/248053008

git-svn-id: http://skia.googlecode.com/svn/trunk@14352 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-24 15:33:48 +00:00
commit-bot@chromium.org
732bd66ac2 Rearrange SkRecord public API to fit better with cc/resources/picture
BUG=skia:2378
R=reed@google.com, danakj@chromium.org, enne@chromium.org, mtklein@google.com, robertphillips@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/248033002

git-svn-id: http://skia.googlecode.com/svn/trunk@14351 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-24 15:22:55 +00:00
commit-bot@chromium.org
e20f7cf995 android scripts respect SKIA_OUT, if already set.
R=scroggo@google.com, djsollen@google.com, mtklein@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/250303002

git-svn-id: http://skia.googlecode.com/svn/trunk@14350 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-24 15:16:32 +00:00