Commit Graph

33557 Commits

Author SHA1 Message Date
Derek Sollenberger
cf6da8c0f2 Dump additional details about the gpu resources.
GpuResources now dump optional string values that describe the type and
category of the resource.  The type provides a description of the kind
of resource it is (e.g. texture, buffer object, stencil, etc.) and the
category describes what the resource is currently tasked to do (e.g.
path masks, images, scratch, etc.)

This CL also refactors the dump logic in an attempt to consolidate
duplicated code into GrGpuResources.cpp.

Bug: b/74435803
Change-Id: I83cae825f41e6450a21398ab3ecea349c7c61c15
Reviewed-on: https://skia-review.googlesource.com/115989
Commit-Queue: Derek Sollenberger <djsollen@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2018-03-29 18:08:15 +00:00
Hal Canary
9c6f6a5276 SkPDF: type3: more descriptor values
Also: add fXHeight to SkAdvancedTypefaceMetrics.h

Change-Id: I28314cf93ca9808216ee34c202a0fa9fc2ffe301
Reviewed-on: https://skia-review.googlesource.com/117155
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
2018-03-29 18:03:56 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
5059790121 Roll skia/third_party/externals/skcms/ 3f0009288..115e2853e (2 commits)
https://skia.googlesource.com/skcms/+log/3f0009288bba..115e2853ebd7

$ git log 3f0009288..115e2853e --date=short --no-merges --format='%ad %ae %s'
2018-03-29 mtklein add smoke test for skcms_Transform() changes
2018-03-29 brianosman Directly pick a sensible initial G for nonlinear regression

Created with:
  roll-dep skia/third_party/externals/skcms
BUG=skia:


The AutoRoll server is located here: https://skcms-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mtklein@google.com

Change-Id: Ia1d12e03846adcd11f539f00de868217a87f12f2
Reviewed-on: https://skia-review.googlesource.com/117151
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-03-29 17:29:45 +00:00
Ben Wagner
3746ac21df Remove path ranges from gpu.
These appear to have been added to handle glyph paths with nvpr and no
longer appear to be used.

Change-Id: Id75e2e85ab837a5808e7641873d217c844cd827c
Reviewed-on: https://skia-review.googlesource.com/117103
Reviewed-by: Chris Dalton <csmartdalton@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2018-03-29 17:18:05 +00:00
Hal Canary
c3bc425bd4 SkDynamicMemoryWStream: clean up, asserts, etc.
BUG=chromium:825476
Change-Id: Ied7d5e8313781821acc778d784ecade46b93ca22
Reviewed-on: https://skia-review.googlesource.com/116860
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
2018-03-29 15:46:45 +00:00
Stephen White
20010e80b6 Reland "GrTessellator: hang fix."
This is a reland of 050c86768a

Original change's description:
> GrTessellator: hang fix.
> 
> Some edges are not coincident with their own endpoints (because floating
> point). If this happens for an edge which is a right-enclosing-edge
> during the Bentley-Ottman simplify() pass, we end up an infinite loop
> attempting to split the edge, since the edge is never to the right of its
> endpoint.
> 
> The easiest fix is to simply remove the right-enclosing-edge splitting
> code. This code was originally added before we had proper
> active-edge-list rewinding, and should no longer be necessary.
> 
> BUG=802896
> 
> Change-Id: Id9f2942b73f01152af8c0088e8c6b1389891d827
> Reviewed-on: https://skia-review.googlesource.com/116920
> Reviewed-by: Robert Phillips <robertphillips@google.com>
> Commit-Queue: Stephen White <senorblanco@chromium.org>

Bug: 802896
Change-Id: I3e48346a8a358ae7d481299a586003e817a519ca
Reviewed-on: https://skia-review.googlesource.com/117121
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2018-03-29 14:28:55 +00:00
angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
16c5d1b022 Roll skia/third_party/externals/angle2/ a3b220f36..96310cdad (1 commit)
a3b220f36f..96310cdad3

$ git log a3b220f36..96310cdad --date=short --no-merges --format='%ad %ae %s'
2018-03-28 lfy GLES1: glClientActiveTexture

Created with:
  roll-dep skia/third_party/externals/angle2


The AutoRoll server is located here: https://angle-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE
TBR=mtklein@google.com

Change-Id: I808a111c9eb77060a94a9931b0b2e5c556149166
Reviewed-on: https://skia-review.googlesource.com/117143
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-03-29 14:12:45 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
1aae96aaae Roll skia/third_party/externals/skcms/ 5678b9d6a..3f0009288 (1 commit)
https://skia.googlesource.com/skcms/+log/5678b9d6a10d..3f0009288bba

$ git log 5678b9d6a..3f0009288 --date=short --no-merges --format='%ad %ae %s'
2018-03-29 mtklein check table_entries in read_table_extents()

Created with:
  roll-dep skia/third_party/externals/skcms


The AutoRoll server is located here: https://skcms-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mtklein@google.com

Change-Id: I8adf032dc9c368dc00519565811d9e58e147e33b
Reviewed-on: https://skia-review.googlesource.com/117141
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-03-29 13:53:25 +00:00
Kaloyan Donev
560d283295 Fixing build with SK_IGNORE_TO_STRING defined.
Change-Id: Id7238e427e490338d1f610255774c2069cfd4879
Reviewed-on: https://skia-review.googlesource.com/117060
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2018-03-29 13:42:45 +00:00
Ethan Nicholas
23463004df fixed type mismatches in SkSL comparison operators
Bug: skia:
Change-Id: I8f05088c561a80549264f7a65cb8161bbe7d8f4c
Reviewed-on: https://skia-review.googlesource.com/116982
Reviewed-by: Chris Dalton <csmartdalton@google.com>
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
2018-03-29 13:41:25 +00:00
Chris Dalton
0090ef6a83 Don't use gl_FragCoord on legacy Tegra hardware
Bug: skia:7413
Bug: skia:7757
Change-Id: I588c49409fd630f4c15546d8be64fb46c87db3c3
Reviewed-on: https://skia-review.googlesource.com/117007
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2018-03-29 13:23:35 +00:00
Mike Klein
f2590303b7 Revert "GrTessellator: hang fix."
This reverts commit 050c86768a.

Reason for revert: layout test diff in Chrome roll?

Original change's description:
> GrTessellator: hang fix.
> 
> Some edges are not coincident with their own endpoints (because floating
> point). If this happens for an edge which is a right-enclosing-edge
> during the Bentley-Ottman simplify() pass, we end up an infinite loop
> attempting to split the edge, since the edge is never to the right of its
> endpoint.
> 
> The easiest fix is to simply remove the right-enclosing-edge splitting
> code. This code was originally added before we had proper
> active-edge-list rewinding, and should no longer be necessary.
> 
> BUG=802896
> 
> Change-Id: Id9f2942b73f01152af8c0088e8c6b1389891d827
> Reviewed-on: https://skia-review.googlesource.com/116920
> Reviewed-by: Robert Phillips <robertphillips@google.com>
> Commit-Queue: Stephen White <senorblanco@chromium.org>

TBR=robertphillips@google.com,senorblanco@chromium.org

Change-Id: Icb928db6c052a21c6d327da9492cb991f769186f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 802896
Reviewed-on: https://skia-review.googlesource.com/117120
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2018-03-29 13:21:16 +00:00
angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
702a7dfc91 Roll skia/third_party/externals/angle2/ 78c5eb2ab..a3b220f36 (7 commits)
78c5eb2ab3..a3b220f36f

$ git log 78c5eb2ab..a3b220f36 --date=short --no-merges --format='%ad %ae %s'
2018-03-06 tobine Vulkan: Adding null driver as device option
2018-03-27 lucferron Vulkan: Enable depth render state dEQP tests
2018-03-27 fjhenigman Return gl::Error from VertexArray::syncState().
2018-03-21 oetuaho Use a specialized hash function for mangled names
2018-03-26 geofflang Add a FixedVector class to have "variable" size vectors on the stack.
2018-03-27 geofflang GL: Check framebuffer completeness before running blit shaders.
2018-03-23 oetuaho Remove createAssign: only called once

Created with:
  roll-dep skia/third_party/externals/angle2


The AutoRoll server is located here: https://angle-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE
TBR=mtklein@google.com

Change-Id: I99e77f67c65d3b49ea6037b0974a1c7ee3319727
Reviewed-on: https://skia-review.googlesource.com/117012
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-03-29 01:04:44 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
3b593d184a Roll skia/third_party/externals/skcms/ ed6a9bd48..5678b9d6a (1 commit)
https://skia.googlesource.com/skcms/+log/ed6a9bd48726..5678b9d6a10d

$ git log ed6a9bd48..5678b9d6a --date=short --no-merges --format='%ad %ae %s'
2018-03-28 brianosman Approximate A2B tables without double precision linear fit

Created with:
  roll-dep skia/third_party/externals/skcms
BUG=skia:


The AutoRoll server is located here: https://skcms-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mtklein@google.com

Change-Id: I00fa54fc5266b16767b2e9d2294af16dd803a260
Reviewed-on: https://skia-review.googlesource.com/117008
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-03-28 23:43:44 +00:00
Yuqian Li
755778cda0 Update trans limit after zoom changes in viewer
Previously, the trans limit assumes that only touch gesture can
change the zoom level. That's not true on desktops so we need this
fix. Otherwise, we won't be able to translate when we zoomed in.

Bug: skia:
Change-Id: I5901600a0044639a47514ab76b7e1914f04137a2
Reviewed-on: https://skia-review.googlesource.com/116987
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Yuqian Li <liyuqian@google.com>
2018-03-28 20:51:44 +00:00
Ravi Mistry
470d829731 Whitespace change
NoTry: true
Bug: skia:
Change-Id: I6dc0ba66aca94f7f99cb851dda6503c0cb9c302b
Reviewed-on: https://skia-review.googlesource.com/114407
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2018-03-28 20:43:34 +00:00
Ben Wagner
97182cc8f6 Add color fonts.
BUG=skia:7624

Change-Id: I68a6bb4c6fa541ffad565d970438d93ff1bd8ed6
Reviewed-on: https://skia-review.googlesource.com/109521
Commit-Queue: Ben Wagner <bungeman@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Reviewed-by: Herb Derby <herb@google.com>
Reviewed-on: https://skia-review.googlesource.com/116541
Reviewed-on: https://skia-review.googlesource.com/116984
Reviewed-by: Ben Wagner <bungeman@google.com>
2018-03-28 20:14:44 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
a11bfe5a21 Roll skia/third_party/externals/skcms/ 59fdb4e14..ed6a9bd48 (2 commits)
https://skia.googlesource.com/skcms/+log/59fdb4e14c97..ed6a9bd48726

$ git log 59fdb4e14..ed6a9bd48 --date=short --no-merges --format='%ad %ae %s'
2018-03-28 brianosman Allow anonymous struct/union in MSVC
2018-03-28 mtklein remove -ffp-contract mentions

Created with:
  roll-dep skia/third_party/externals/skcms
BUG=skia:


The AutoRoll server is located here: https://skcms-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mtklein@google.com

Change-Id: Ieabe5c8f257a4a52118698e3ccd8d4fcade21451
Reviewed-on: https://skia-review.googlesource.com/117000
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-03-28 20:14:24 +00:00
Stephen White
050c86768a GrTessellator: hang fix.
Some edges are not coincident with their own endpoints (because floating
point). If this happens for an edge which is a right-enclosing-edge
during the Bentley-Ottman simplify() pass, we end up an infinite loop
attempting to split the edge, since the edge is never to the right of its
endpoint.

The easiest fix is to simply remove the right-enclosing-edge splitting
code. This code was originally added before we had proper
active-edge-list rewinding, and should no longer be necessary.

BUG=802896

Change-Id: Id9f2942b73f01152af8c0088e8c6b1389891d827
Reviewed-on: https://skia-review.googlesource.com/116920
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Stephen White <senorblanco@chromium.org>
2018-03-28 19:55:34 +00:00
Robert Phillips
6eba063b63 Add new GrResourceCache::purgeUnlockedResources variant
TBR=bsalomon@google.com
Change-Id: I05bef1f8a271474db878a046cc1f6ac7b60a15f1
Reviewed-on: https://skia-review.googlesource.com/116801
Reviewed-by: Greg Daniel <egdaniel@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2018-03-28 18:56:14 +00:00
Ben Wagner
aa5da735fa Check that paint is not null in OveridePaintFilterCanvas.
SkCanvas::drawPicture may provide nullptr for a paint.

BUG=skia:7756

Change-Id: I46651f7e8f0d859a7e75206d93ed1f3b3c0a4bac
Reviewed-on: https://skia-review.googlesource.com/116902
Reviewed-by: Yuqian Li <liyuqian@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2018-03-28 18:02:24 +00:00
Robert Phillips
e47f0a0f16 Remove old method of drawing DDL SKPs from DM (in favor of ViaDDL method)
Change-Id: I6bb270d9df1c76b9d2e384abde603cdda91c9bb6
Reviewed-on: https://skia-review.googlesource.com/116550
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2018-03-28 17:21:24 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
282f9daa82 Roll skia/third_party/externals/skcms/ 680ab5a31..59fdb4e14 (3 commits)
https://skia.googlesource.com/skcms/+log/680ab5a31cd2..59fdb4e14c97

$ git log 680ab5a31..59fdb4e14 --date=short --no-merges --format='%ad %ae %s'
2018-03-28 mtklein pack skcms_Curve a bit more, to 32 bytes
2018-03-28 mtklein no need to ship 1D/2D clut stages
2018-03-28 mtklein pack skcms_Curve a bit

Created with:
  roll-dep skia/third_party/externals/skcms


The AutoRoll server is located here: https://skcms-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mtklein@google.com

Change-Id: I5d6b133f50895611f8f39fc547b70b316957cc95
Reviewed-on: https://skia-review.googlesource.com/116882
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-03-28 16:40:44 +00:00
angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
a9713340c7 Roll skia/third_party/externals/angle2/ c7575da54..78c5eb2ab (1 commit)
c7575da546..78c5eb2ab3

$ git log c7575da54..78c5eb2ab --date=short --no-merges --format='%ad %ae %s'
2018-03-28 geofflang Skip RobustResourceInitTestES3.MaskedStencilClearBuffer on Intel Mac.

Created with:
  roll-dep skia/third_party/externals/angle2


The AutoRoll server is located here: https://angle-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE
TBR=mtklein@google.com

Change-Id: Ifa8887bc3e2f6a98cdac06b6e13c0ee4de607820
Reviewed-on: https://skia-review.googlesource.com/116845
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-03-28 16:28:24 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
ce92cb612d Roll skia/third_party/externals/skcms/ fc0d0c4c7..680ab5a31 (1 commit)
https://skia.googlesource.com/skcms/+log/fc0d0c4c7f9c..680ab5a31cd2

$ git log fc0d0c4c7..680ab5a31 --date=short --no-merges --format='%ad %ae %s'
2018-03-28 mtklein trim profile fields we ignore

Created with:
  roll-dep skia/third_party/externals/skcms


The AutoRoll server is located here: https://skcms-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mtklein@google.com

Change-Id: I665e43e89a4823c975469a6585ec744c766c1f91
Reviewed-on: https://skia-review.googlesource.com/116844
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-03-28 16:09:24 +00:00
Ben Wagner
3aa8bfe0d5 Roll FreeType.
Change-Id: I3fe4e27e70270f4dc31610f98741c63b3574cf96
Reviewed-on: https://skia-review.googlesource.com/116628
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Mike Klein <mtklein@chromium.org>
2018-03-28 16:06:34 +00:00
Hal Canary
a567e3315b SkPDF: Accept non-monotonic text cluster indices
BUG=skia:7055
Change-Id: Ic1540a15118dbe99db5bcff26dd1235adac5468a
Reviewed-on: https://skia-review.googlesource.com/116725
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Hal Canary <halcanary@google.com>
2018-03-28 15:29:24 +00:00
Chris Dalton
a466228a61 Delete GPU alpha clip masks
The cost of switching render targets on each draw to make a custom
clip is enormous. There are virtually no circumstances where this will
outperform our cached, multi-threaded software mask generator. The
tried-and-true approach to clipping on-GPU is with analytic FPs. And
now that we support CCPR clip FPs, there ulitmately should be very few
clip stacks that even require a mask as long as they don't use
deprecated SkClipOps.

Bug: skia:
Change-Id: I79c5558c93c1b99179f1e933d029f69b14ad1ce3
Reviewed-on: https://skia-review.googlesource.com/116724
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2018-03-28 15:01:04 +00:00
Jim Van Verth
41964ed46e Rename SkInsetConvexPolygon to SkOffsetPolygon.
Prep for adding new offset routines.

Change-Id: I261c22d9998e5ae4567b697c5f20a31f20777ac1
Reviewed-on: https://skia-review.googlesource.com/116800
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
2018-03-28 14:49:14 +00:00
Robert Phillips
3a9710b1e4 Add handling for allocation failure in GrTextureOpList
I believe this is what has been causing the intermittent TSAN crash

Change-Id: Ie7170a3eb0495cebe8b1398a00f98ad099f78944
Reviewed-on: https://skia-review.googlesource.com/116629
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2018-03-28 14:25:54 +00:00
angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
6cf20044d8 Roll skia/third_party/externals/angle2/ e858cb1db..c7575da54 (1 commit)
e858cb1db3..c7575da546

$ git log e858cb1db..c7575da54 --date=short --no-merges --format='%ad %ae %s'
2018-03-27 fjhenigman Skip ReuploadingClearsTexture test on Mac.

Created with:
  roll-dep skia/third_party/externals/angle2


The AutoRoll server is located here: https://angle-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE
TBR=mtklein@google.com

Change-Id: I269e6e7ef638646fe1921ce36ea0998f1b2846aa
Reviewed-on: https://skia-review.googlesource.com/116760
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-03-28 07:09:44 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
13e3ddd069 Roll skia/third_party/externals/skcms/ 80ac04dc4..fc0d0c4c7 (1 commit)
https://skia.googlesource.com/skcms/+log/80ac04dc4706..fc0d0c4c7f9c

$ git log 80ac04dc4..fc0d0c4c7 --date=short --no-merges --format='%ad %ae %s'
2018-03-27 mtklein force inline where feasible

Created with:
  roll-dep skia/third_party/externals/skcms


The AutoRoll server is located here: https://skcms-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mtklein@google.com

Change-Id: I46629965c100feba21f18404437bf12badf07aa5
Reviewed-on: https://skia-review.googlesource.com/116730
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-03-27 23:06:24 +00:00
angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
d7ee596a17 Roll skia/third_party/externals/angle2/ 15c7d0a64..e858cb1db (12 commits)
15c7d0a649..e858cb1db3

$ git log 15c7d0a64..e858cb1db --date=short --no-merges --format='%ad %ae %s'
2018-03-27 jmadill Split VAO dirty bits to speed iteration.
2018-03-27 courtneygo Update license and readme for use downstream
2018-03-22 lucferron dEQP: Enable depth/stencil backbuffer.
2018-03-27 fjhenigman Vulkan: flush StreamingBuffer before unmap.
2018-03-21 lucferron Vulkan: Reallocate only the right uniform descriptor set when needed
2018-03-21 lfy GLES1: glAlphaFunc
2018-03-15 lucferron Vulkan: Dynamic update of uniforms
2018-03-27 lucferron Revert "Vulkan: Enable depth and stencil dEQP tests"
2018-03-27 jmadill Buffer11: Refactor Subject/Observer pattern.
2018-03-27 jmadill D3D11: Add primitive type dirty bits.
2018-03-16 jiajia.qin ES31: Add DispatchCompute perf tests
2018-03-21 jiawei.shao Use packed enums on shader types in ANGLE renderer

Created with:
  roll-dep skia/third_party/externals/angle2


The AutoRoll server is located here: https://angle-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE
TBR=mtklein@google.com

Change-Id: I0659b33b9361e42222755feebd0785d1e230702c
Reviewed-on: https://skia-review.googlesource.com/116727
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-03-27 22:31:23 +00:00
Herb Derby
39e45df22d Various cleanup to remote_demo
Integrate SkRemoteGlyphCacheRenderer into SkStrikeServer
Add a Timer.
Remove unused code.

BUG=skia:7515

Change-Id: Idffb477af71cbcc4035df190e29e8910b61aa6e5
Reviewed-on: https://skia-review.googlesource.com/116485
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2018-03-27 21:51:44 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
d24c325452 Roll skia/third_party/externals/skcms/ 6793c6ab0..80ac04dc4 (2 commits)
https://skia.googlesource.com/skcms/+log/6793c6ab038e..80ac04dc4706

$ git log 6793c6ab0..80ac04dc4 --date=short --no-merges --format='%ad %ae %s'
2018-03-27 mtklein split gather functions
2018-03-27 brianosman Include XYZ encoding factor in the mAB matrix if PCS is XYZ

Created with:
  roll-dep skia/third_party/externals/skcms


The AutoRoll server is located here: https://skcms-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mtklein@google.com

Change-Id: Ie13faa897fed25352bcc290bb903251ee46ca2eb
Reviewed-on: https://skia-review.googlesource.com/116723
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-03-27 21:41:24 +00:00
Robert Phillips
b7fafba851 Reland "Switch bots to use ViaDDL (i.e., ddl-gl) instead of old --ddl flag"
This reverts commit 7a11abd4f0.

Reason for revert: Fixes have landed

Original change's description:
> Revert "Switch bots to use ViaDDL (i.e., ddl-gl) instead of old --ddl flag"
> 
> This reverts commit d234c9e6b9.
> 
> Reason for revert: GM/TSAN unhappiness
> 
> Original change's description:
> > Switch bots to use ViaDDL (i.e., ddl-gl) instead of old --ddl flag
> > 
> > Change-Id: I9c5f27bacf7d9fa7a9ac123379e2556913810cba
> > Reviewed-on: https://skia-review.googlesource.com/116464
> > Reviewed-by: Eric Boren <borenet@google.com>
> > Commit-Queue: Robert Phillips <robertphillips@google.com>
> 
> TBR=borenet@google.com,robertphillips@google.com
> 
> Change-Id: I95388ee582bdd9561b8ebf24250f58b361657b7c
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://skia-review.googlesource.com/116621
> Reviewed-by: Robert Phillips <robertphillips@google.com>
> Commit-Queue: Robert Phillips <robertphillips@google.com>

TBR=borenet@google.com,robertphillips@google.com

Change-Id: Idcd8cc2337657131fb9b1785bec44afefacda634
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/116681
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2018-03-27 20:49:34 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
f42e548d91 Roll skia/third_party/externals/skcms/ aa8c0f3d2..6793c6ab0 (1 commit)
https://skia.googlesource.com/skcms/+log/aa8c0f3d24e7..6793c6ab038e

$ git log aa8c0f3d2..6793c6ab0 --date=short --no-merges --format='%ad %ae %s'
2018-03-27 mtklein prefer A2B0 over A2B1

Created with:
  roll-dep skia/third_party/externals/skcms


The AutoRoll server is located here: https://skcms-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mtklein@google.com

Change-Id: I61343efbfb8ea936d49ee5d0cecdfd1a9f7de5a4
Reviewed-on: https://skia-review.googlesource.com/116700
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-03-27 19:50:23 +00:00
Ethan Nicholas
26a9aad63b initial SkSLJIT checkin
Docs-Preview: https://skia.org/?cl=112204
Bug: skia:
Change-Id: I10042a0200db00bd8ff8078467c409b1cf191f50
Reviewed-on: https://skia-review.googlesource.com/112204
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
2018-03-27 18:39:13 +00:00
Ben Wagner
3560b58de3 Revert "Add color fonts."
This reverts commit d3b933f3e0.

Reason for revert: we're not mirroring experimental/ everywhere.

Original change's description:
> Add color fonts.
> 
> BUG=skia:7624
> 
> Change-Id: I1d0974282adce2fd7b13a003309e63593b6e1a9c
> Reviewed-on: https://skia-review.googlesource.com/109521
> Commit-Queue: Ben Wagner <bungeman@google.com>
> Reviewed-by: Mike Klein <mtklein@google.com>
> Reviewed-by: Herb Derby <herb@google.com>
> Reviewed-on: https://skia-review.googlesource.com/116541

TBR=mtklein@google.com,bungeman@google.com,herb@google.com

Change-Id: Ic2d763244cbce663a23eb53321ac45201c466501
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:7624
Reviewed-on: https://skia-review.googlesource.com/116680
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2018-03-27 18:16:04 +00:00
Mike Klein
83ee463c31 exclude SkColorSpaceXform_skcms.cpp from Google3
We're globbing it up right now, but can't build without skcms.h.

Change-Id: I2a9b29b7a91a0c8cccc73b1e20f64c1f6181eabd
Reviewed-on: https://skia-review.googlesource.com/116623
Reviewed-by: Brian Osman <brianosman@google.com>
2018-03-27 17:25:23 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
68a1515c08 Roll skia/third_party/externals/skcms/ 07da72a48..aa8c0f3d2 (1 commit)
https://skia.googlesource.com/skcms/+log/07da72a48a72..aa8c0f3d24e7

$ git log 07da72a48..aa8c0f3d2 --date=short --no-merges --format='%ad %ae %s'
2018-03-27 mtklein gather directly into vectors

Created with:
  roll-dep skia/third_party/externals/skcms


The AutoRoll server is located here: https://skcms-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mtklein@google.com

Change-Id: I270fc88a3879d021460f23c44a9d561539884635
Reviewed-on: https://skia-review.googlesource.com/116660
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-03-27 17:17:24 +00:00
Ben Wagner
d3b933f3e0 Add color fonts.
BUG=skia:7624

Change-Id: I1d0974282adce2fd7b13a003309e63593b6e1a9c
Reviewed-on: https://skia-review.googlesource.com/109521
Commit-Queue: Ben Wagner <bungeman@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Reviewed-by: Herb Derby <herb@google.com>
Reviewed-on: https://skia-review.googlesource.com/116541
2018-03-27 16:49:14 +00:00
Ben Wagner
6ce482aed4 Remove include/svg from public.bzl includes.
It's strange to include it since public.bzl currently excludes all of
the source files that define the symbols declared in the headers in this
directory.

This also fixes the two files which needed to put some of these includes
behind the SK_XML macro. The public.bzl never defines the SK_XML macro,
so there is no need to ever have the include/svg directory on the
include path, even for DM.

Change-Id: I6cc18908aa16cfc914ed9b7ab174d03a0a242aa4
Reviewed-on: https://skia-review.googlesource.com/116547
Commit-Queue: Ben Wagner <bungeman@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2018-03-27 16:36:29 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
f80c8ecdaa Roll skia/third_party/externals/skcms/ 7e5292bb2..07da72a48 (1 commit)
https://skia.googlesource.com/skcms/+log/7e5292bb229e..07da72a48a72

$ git log 7e5292bb2..07da72a48 --date=short --no-merges --format='%ad %ae %s'
2018-03-27 mtklein Don't use toXZYD50 matrix for A2B sources.

Created with:
  roll-dep skia/third_party/externals/skcms


The AutoRoll server is located here: https://skcms-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mtklein@google.com

Change-Id: I472d3f3047dbf566c67f81f5ff7afc53397ac5c7
Reviewed-on: https://skia-review.googlesource.com/116615
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-03-27 16:35:44 +00:00
Brian Osman
5d7e1cf98f Remove duplicate entry for SkTDPQueue.h in gni
This was causing the generated MSVC project to not load, leading to
confusing behavior in the IDE.

Change-Id: I7ec8f1391c0c3b53e7b5c473571a062e6406b358
Reviewed-on: https://skia-review.googlesource.com/116467
Commit-Queue: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2018-03-27 16:31:24 +00:00
Mike Klein
b412f5bd06 cache SkMatrix44 type in makeColorSpin()
This helps prevent races on getType() later, e.g.
https://luci-milo.appspot.com/swarming/task/3c80715df637a810/steps/symbolized_dm/0/stdout

Change-Id: I3dbc9f6bf2fddff9ca416b0001bfd5da123e6b25
Reviewed-on: https://skia-review.googlesource.com/116466
Commit-Queue: Mike Klein <mtklein@chromium.org>
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2018-03-27 16:29:14 +00:00
Robert Phillips
cc47335ded Fix flushing of context in ViaDDL
Change-Id: I9f84f4081861e2789b45787405e0f1a5aa87824d
Reviewed-on: https://skia-review.googlesource.com/116546
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2018-03-27 16:02:44 +00:00
Chris Dalton
8dfc70f7e2 ccpr: Various cleanups
Renames GrCCCoverageProcessor::RenderPass to PrimitiveType and handles
corners as subpasses instead. Various touchups to coverage processors
now that the overhaul is complete. This change should be strictly a
refactor.

Bug: skia:
Change-Id: I52852463330d5ec71fae7e19fadccd9ede8b2c16
Reviewed-on: https://skia-review.googlesource.com/116169
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2018-03-27 15:38:34 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
9b685238f6 Roll skia/third_party/externals/skcms/ 286108ae1..7e5292bb2 (1 commit)
https://skia.googlesource.com/skcms/+log/286108ae15ae..7e5292bb229e

$ git log 286108ae1..7e5292bb2 --date=short --no-merges --format='%ad %ae %s'
2018-03-27 mtklein invert inverse-CMYK to CMYK

Created with:
  roll-dep skia/third_party/externals/skcms


The AutoRoll server is located here: https://skcms-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mtklein@google.com

Change-Id: Id6e7de8b155973447ff1fc582530c416f7c6a3d5
Reviewed-on: https://skia-review.googlesource.com/116609
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-03-27 14:56:24 +00:00
Brian Osman
052ef69570 Pin color type when a cross-context image is constructed
Fixes issues with gray images that may be incorrectly re-interpreted as
alpha when re-wrapped. (https://github.com/flutter/flutter/issues/15600)

Change-Id: I4a78466073e14d212108d168eed0b2df1bc92ffe
Reviewed-on: https://skia-review.googlesource.com/116484
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
2018-03-27 14:45:14 +00:00