commit-bot@chromium.org
cf7be95b19
Remove the call to getFontMetrics from SkBBoxRecord
...
R=reed@google.com , caryclark@google.com
Author: sglez@google.com
Review URL: https://chromiumcodereview.appspot.com/23001007
git-svn-id: http://skia.googlecode.com/svn/trunk@10876 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-22 17:19:52 +00:00
edisonn@google.com
73613c16e1
pdfviewer: if the resources are missing, exit (right now inheritance is not implemented)
...
Review URL: https://codereview.chromium.org/23125015
git-svn-id: http://skia.googlecode.com/svn/trunk@10875 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-22 15:48:35 +00:00
mtklein@google.com
330313a8a8
My clang now doesn't complain about !"foo".
...
BUG=
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/22875037
git-svn-id: http://skia.googlecode.com/svn/trunk@10874 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-22 15:37:26 +00:00
edisonn@google.com
f68aed3381
pdfviewer: when q start, and an operator is called, it should not be able to see operands before q. nest/unnest are similar with pop/push - simulates a stack of stacks, in a single stack
...
Review URL: https://codereview.chromium.org/23033022
git-svn-id: http://skia.googlecode.com/svn/trunk@10873 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-22 15:37:21 +00:00
edisonn@google.com
bd2f30132e
pdfviewer: add macros to automatically check number and type of parameters
...
Review URL: https://codereview.chromium.org/23038021
git-svn-id: http://skia.googlecode.com/svn/trunk@10872 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-22 14:18:04 +00:00
skia.committer@gmail.com
37c18e4e38
Sanitizing source files in Housekeeper-Nightly
...
git-svn-id: http://skia.googlecode.com/svn/trunk@10871 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-22 07:01:59 +00:00
commit-bot@chromium.org
e324cc69be
Restyle SkPDFImageShader and support tiling bitmaps outside clip bounds
...
BUG=chromium:99458
R=edisonn@google.com , vandebo@chromium.org
Author: richardlin@chromium.org
Review URL: https://chromiumcodereview.appspot.com/22884013
git-svn-id: http://skia.googlecode.com/svn/trunk@10870 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-21 23:10:45 +00:00
bungeman@google.com
42a7829543
Better error reporting when dynamic loading fails with DirectWrite.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@10869 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-21 22:41:05 +00:00
bsalomon@google.com
7344385b70
Fix android doubly defined empty string due to static lib and shared lib thing.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@10868 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-21 20:50:50 +00:00
commit-bot@chromium.org
78a1078f17
Create new target to hold gpu test code, enable direct testing of GrEffects in GM.
...
R=robertphillips@google.com , jvanverth@google.com , egdaniel@google.com
Author: bsalomon@google.com
Review URL: https://chromiumcodereview.appspot.com/23352003
git-svn-id: http://skia.googlecode.com/svn/trunk@10866 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-21 19:27:48 +00:00
mtklein@google.com
05f85ade78
expectations for radial_gradient2
...
BUG=
Review URL: https://codereview.chromium.org/23144005
git-svn-id: http://skia.googlecode.com/svn/trunk@10865 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-21 19:18:47 +00:00
vandebo@chromium.org
8fc3766c58
Update expectations for Mac PDF
...
R=epoger@google.com , vandebo@chromium.org
Review URL: https://codereview.chromium.org/22865029
git-svn-id: http://skia.googlecode.com/svn/trunk@10863 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-21 18:04:09 +00:00
borenet@google.com
47ae4b0d54
Add skia_clang_build gyp define, add -Wstring-conversion flag
...
If you want the warning, you have to specify skia_clang_build=1
R=djsollen@google.com
Review URL: https://codereview.chromium.org/23038014
git-svn-id: http://skia.googlecode.com/svn/trunk@10861 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-21 18:02:50 +00:00
epoger@google.com
c192aa4937
Update references to buildbot globals deprecated by r10856
...
R=borenet@google.com
Review URL: https://codereview.chromium.org/23011035
git-svn-id: http://skia.googlecode.com/svn/trunk@10860 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-21 17:35:59 +00:00
robertphillips@google.com
fef422415b
Add new baselines for arcofzorro GM
...
git-svn-id: http://skia.googlecode.com/svn/trunk@10859 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-21 17:29:37 +00:00
robertphillips@google.com
957236657f
Adding new baselines for blurquickreject GM
...
git-svn-id: http://skia.googlecode.com/svn/trunk@10858 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-21 17:21:16 +00:00
bungeman@google.com
5c1d88dca0
Add an empty typeface as a default-default.
...
R=reed@google.com
Review URL: https://codereview.chromium.org/22861017
git-svn-id: http://skia.googlecode.com/svn/trunk@10857 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-21 17:20:57 +00:00
robertphillips@google.com
ab17a4fa1f
Add new "bleed" GM baselines
...
git-svn-id: http://skia.googlecode.com/svn/trunk@10855 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-21 16:53:52 +00:00
edisonn@google.com
cf2cfa174c
pdfviewer: code cleanup - add licence on files, make replace __DEFINE__foo with foo_DEFINED to match skia project
...
Review URL: https://codereview.chromium.org/23361009
git-svn-id: http://skia.googlecode.com/svn/trunk@10854 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-21 16:31:37 +00:00
robertphillips@google.com
3c3c46238d
Bleed cleanup (remove nocolorbleed GM & enable bleed in game bench)
...
https://codereview.chromium.org/23264014/
git-svn-id: http://skia.googlecode.com/svn/trunk@10853 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-21 16:30:39 +00:00
bungeman@google.com
418ee43f42
Implement SkEmptyFontMgr::onLegacyCreateTypeface and make pure virtual.
...
R=reed@google.com
Review URL: https://codereview.chromium.org/22849025
git-svn-id: http://skia.googlecode.com/svn/trunk@10852 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-21 16:28:26 +00:00
bungeman@google.com
bfc6cc4b6c
allow both GDI and DW fontmgrs at the same time
...
BUG=
R=bungeman@google.com
Committed: https://code.google.com/p/skia/source/detail?r=10718
Committed: https://code.google.com/p/skia/source/detail?r=10788
Review URL: https://codereview.chromium.org/23058002
git-svn-id: http://skia.googlecode.com/svn/trunk@10851 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-21 15:20:43 +00:00
scroggo@google.com
dbf9f884c3
Avoid getLength in ico decoder.
...
Only call getLength() if hasLength() returned true. Otherwise, copy the
stream into an SkDynamicMemoryWStream and copy it into alloc'ed space.
Share common code between bmp and ico.
BUG=https://b.corp.google.com/issue?id=8432093
R=djsollen@google.com
Review URL: https://codereview.chromium.org/23330002
git-svn-id: http://skia.googlecode.com/svn/trunk@10850 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-21 15:01:48 +00:00
scroggo@google.com
2fd740ffba
Make BMP decoder not depend on call to getLength.
...
If the decoder does not have a length, use an SkDynamicMemoryStream
to copy it to contiguous memory, to be passed to BmpDecoderHelper.
BUG=https://b.corp.google.com/issue?id=8432093
R=djsollen@google.com
Review URL: https://codereview.chromium.org/22877020
git-svn-id: http://skia.googlecode.com/svn/trunk@10849 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-21 14:59:03 +00:00
scroggo@google.com
3c8730a84e
Remove dependency on getLength from webp decoder.
...
In webp_parse_header, continue reading until end of stream is reached,
or we have read WEBP_VP8_HEADER_SIZE bytes. Do not check to see if the
stream was too short, since it may not have a way to report its length,
and WEBP_VP8_HEADER_SIZE is padded slightly. Instead, depend on
WebPGetFeatures to report that the stream did not have enough data.
In webp_idecode, only check length if it is available.
BUG=https://b.corp.google.com/issue?id=8432093
R=djsollen@google.com , vikasa@google.com
Review URL: https://codereview.chromium.org/22841005
git-svn-id: http://skia.googlecode.com/svn/trunk@10848 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-21 14:56:09 +00:00
bungeman@google.com
af9296e1e9
Update DirectWrite code so that it is loadable on XP.
...
This change delay loads GetUserDefaultLocaleName since it is available
in Vista+.
R=reed@google.com
Review URL: https://codereview.chromium.org/23380002
git-svn-id: http://skia.googlecode.com/svn/trunk@10847 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-21 14:53:59 +00:00
robertphillips@google.com
9e02527eee
Adding new baseline image for Nexus7 fontscaler GM
...
git-svn-id: http://skia.googlecode.com/svn/trunk@10846 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-21 14:08:47 +00:00
commit-bot@chromium.org
7a434a2868
Recognize that ES3 supports texture storage. Add workaround for apparent Adreno bug.
...
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://chromiumcodereview.appspot.com/22856006
git-svn-id: http://skia.googlecode.com/svn/trunk@10845 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-21 14:01:56 +00:00
robertphillips@google.com
9241e33ca9
Chromium staging for SkDevice refactoring
...
https://codereview.chromium.org/23332009/
git-svn-id: http://skia.googlecode.com/svn/trunk@10844 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-21 13:54:44 +00:00
robertphillips@google.com
eecbe50173
Nexus 7 Performance trigger rebaselines
...
git-svn-id: http://skia.googlecode.com/svn/trunk@10843 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-21 12:08:18 +00:00
skia.committer@gmail.com
b74bdf0249
Sanitizing source files in Housekeeper-Nightly
...
git-svn-id: http://skia.googlecode.com/svn/trunk@10842 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-21 07:01:29 +00:00
vandebo@chromium.org
0dcbece326
Support multiple PDF rendering backends in the GM
...
R=epoger@google.com , vandebo@chromium.org
Review URL: https://codereview.chromium.org/21669004
git-svn-id: http://skia.googlecode.com/svn/trunk@10841 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-20 23:08:40 +00:00
robertphillips@google.com
147c4f3e0c
Chromium's clang bots do not like the SkASSERT(!"foo") construct
...
git-svn-id: http://skia.googlecode.com/svn/trunk@10840 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-20 21:41:15 +00:00
commit-bot@chromium.org
941df4fb5b
Add validation check that linewidth func is present (we already call it on ES).
...
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://chromiumcodereview.appspot.com/22842008
git-svn-id: http://skia.googlecode.com/svn/trunk@10839 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-20 20:54:08 +00:00
djsollen@google.com
2b343cc255
create a macro for testing if skcolor and skpmcolor have same shift values
...
R=reed@google.com
Review URL: https://codereview.chromium.org/22799015
git-svn-id: http://skia.googlecode.com/svn/trunk@10838 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-20 20:28:03 +00:00
commit-bot@chromium.org
6364b5edc3
Use ES3 texture swizzling.
...
R=jvanverth@google.com
Author: bsalomon@google.com
Review URL: https://chromiumcodereview.appspot.com/23128009
git-svn-id: http://skia.googlecode.com/svn/trunk@10837 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-20 20:22:52 +00:00
commit-bot@chromium.org
9504575438
Add perf benchmarks and more unit tests for matrix inversion
...
R=jvanverth@google.com , reed@google.com
Author: shawnsingh@chromium.org
Review URL: https://chromiumcodereview.appspot.com/22886010
git-svn-id: http://skia.googlecode.com/svn/trunk@10836 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-20 20:15:24 +00:00
robertphillips@google.com
9b051a375b
Revert r10830 (Split SkDevice out of SkRasterDevice) until we can get Chromium ready.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@10835 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-20 20:06:40 +00:00
edisonn@google.com
8cee797901
pdfviewer: check in pdfapi classes
...
Review URL: https://codereview.chromium.org/22900010
git-svn-id: http://skia.googlecode.com/svn/trunk@10834 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-20 18:56:49 +00:00
commit-bot@chromium.org
327c081e4b
Add libpoppler for PDF rendering, take 2
...
R=vandebo@chromium.org , edisonn@google.com
Author: richardlin@chromium.org
Review URL: https://chromiumcodereview.appspot.com/23301009
git-svn-id: http://skia.googlecode.com/svn/trunk@10833 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-20 18:57:01 +00:00
commit-bot@chromium.org
139484095f
Move gpu conic calculations to GrPathUtils
...
BUG=
R=bsalomon@google.com , jvanverth@google.com
Author: egdaniel@google.com
Review URL: https://chromiumcodereview.appspot.com/22865023
git-svn-id: http://skia.googlecode.com/svn/trunk@10832 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-20 17:55:43 +00:00
djsollen@google.com
9615fed005
Add a GM to test the clipping of canvas layers.
...
R=tomhudson@google.com
Review URL: https://codereview.chromium.org/22815012
git-svn-id: http://skia.googlecode.com/svn/trunk@10831 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-20 17:54:33 +00:00
robertphillips@google.com
3055b70018
Split SkDevice out of SkBitmapDevice
...
https://codereview.chromium.org/22978012/
git-svn-id: http://skia.googlecode.com/svn/trunk@10830 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-20 17:49:04 +00:00
edisonn@google.com
4eaa6647e7
pdfviewer: remove text for pdf spec, in preparation to check-in only the PDF API.
...
Review URL: https://codereview.chromium.org/22865024
git-svn-id: http://skia.googlecode.com/svn/trunk@10829 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-20 17:33:08 +00:00
vandebo@chromium.org
54c538e9a5
Revert "The CL adds libpoppler to DEPS and adds a libpoppler-cpp gyp target for Linux, Windows, and Mac. This does not currently change the GM tool to use poppler - that will be a refactor job in a separate CL."
...
This reverts commit r10823
TBR=richardlin@chromium.org
Review URL: https://codereview.chromium.org/23190020
git-svn-id: http://skia.googlecode.com/svn/trunk@10828 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-20 17:06:22 +00:00
mtklein@google.com
ba0ca99b83
CHECK -> SKTDYNAMICHASH_CHECK, to avoid collision with CHECK in Chrome logging.
...
BUG=
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/23172014
git-svn-id: http://skia.googlecode.com/svn/trunk@10827 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-20 17:03:02 +00:00
robertphillips@google.com
2cc0b47a9b
Third (and hopefully final) change to support bleed flag in Ganesh
...
https://codereview.chromium.org/23172013/
git-svn-id: http://skia.googlecode.com/svn/trunk@10826 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-20 16:51:20 +00:00
mtklein@google.com
9e3074e968
use SkTDynamicHash in picture recording
...
cleaned up SkPictureFlat.h quite a bit while working on this.
bench --match picture_record_ shows some improvement:
compare.sh bench --match picture_record_ --repeat 100
master -> usehash
N=3 p=0.001000 (corrected to 0.000333)
sig? rel. speed bench
y 1.0x picture_record_dictionaries
y 1.5x picture_record_recurring_paint_dictionary
y 3.8x picture_record_unique_paint_dictionary
Overall relative speed: 1.9x
bench_pictures --record is pretty much neutral:
compare.sh bench_pictures -r ../skp --mode record --repeat 30
master -> usehash
N=63 p=0.001000 (corrected to 0.000016)
sig? rel. speed bench
n 0.9x desk_pokemonwiki.skp
y 0.9x desk_googlespreadsheet.skp
y 0.9x tabl_pravda.skp
y 1.0x desk_googlespreadsheetdashed.skp
n 1.0x tabl_onlinewsj.skp
n 1.0x tabl_nytimes.skp
n 1.0x desk_googlehome.skp
y 1.0x desk_techcrunch.skp
n 1.0x tabl_slashdot.skp
n 1.0x tabl_techmeme.skp
n 1.0x desk_googleplus.skp
n 1.0x desk_sfgate.skp
n 1.0x tabl_transformice.skp
n 1.0x desk_espn.skp
n 1.0x desk_baidu.skp
n 1.0x tabl_worldjournal.skp
n 1.0x desk_chalkboard.skp
n 1.0x tabl_frantzen.skp
n 1.0x desk_gws.skp
n 1.0x tabl_androidpolice.skp
n 1.0x desk_linkedin.skp
n 1.0x mobi_wikipedia.skp
n 1.0x desk_wowwiki.skp
n 1.0x desk_css3gradients.skp
n 1.0x desk_gmailthread.skp
n 1.0x desk_yahoogames.skp
n 1.0x desk_facebook.skp
n 1.0x desk_wordpress.skp
n 1.0x tabl_vnexpress.skp
n 1.0x desk_br337.skp
n 1.0x tabl_engadget.skp
n 1.0x tabl_theverge.skp
n 1.0x desk_amazon.skp
n 1.0x desk_ebay.skp
n 1.0x tabl_hsfi.skp
n 1.0x tabl_sahadan.skp
n 1.0x desk_weather.skp
n 1.0x tabl_digg.skp
n 1.0x desk_youtubetvbrowse.skp
n 1.0x tabl_culturalsolutions.skp
n 1.0x tabl_ukwsj.skp
n 1.0x desk_youtube.skp
n 1.0x tabl_googlecalendar.skp
y 1.0x desk_yahooanswers.skp
n 1.0x desk_blogger.skp
n 1.0x desk_yahoonews.skp
y 1.0x desk_yahoosports.skp
y 1.0x tabl_mercurynews.skp
n 1.0x desk_youtubetvvideo.skp
y 1.0x tabl_gspro.skp
y 1.1x tabl_googleblog.skp
y 1.1x tabl_cnet.skp
y 1.1x tabl_mlb.skp
y 1.1x tabl_cuteoverload.skp
y 1.1x desk_booking.skp
y 1.1x tabl_deviantart.skp
y 1.1x desk_twitter.skp
y 1.1x tabl_cnn.skp
y 1.1x tabl_gamedeksiam.skp
y 1.1x tabl_gmail.skp
y 1.1x tabl_nofolo.skp
y 1.1x tabl_mozilla.skp
y 1.1x desk_pinterest.skp
Overall relative speed: 1.0x
(I'd take this to mean that the microbenches are probably drifting away from relevance.)
BUG=
R=reed@google.com
Review URL: https://codereview.chromium.org/21564008
git-svn-id: http://skia.googlecode.com/svn/trunk@10825 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-20 16:48:47 +00:00
commit-bot@chromium.org
85e9db0347
The CL adds libpoppler to DEPS and adds a libpoppler-cpp gyp target for Linux, Windows, and Mac. This does not currently change the GM tool to use poppler - that will be a refactor job in a separate CL.
...
Several third-party libraries are pulled in, and platform-specific headers are included under third_party/(library name). Chromium style READMEs containing a description of the library, as well as a LICENSE file are also included in that directory. (is there a Skia-specific style for these?)
R=vandebo@chromium.org , edisonn@google.com , djsollen@chromium.org , bungeman@chromium.org , open-source-third-party-reviews@google.com , thestig@chromium.org
Author: richardlin@chromium.org
Review URL: https://chromiumcodereview.appspot.com/20220002
git-svn-id: http://skia.googlecode.com/svn/trunk@10823 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-20 16:34:34 +00:00
commit-bot@chromium.org
edd18989ac
Tweak Matrix44 test so it'll pass on ChromeOS
...
BUG=
R=robertphillips@google.com
Author: jvanverth@google.com
Review URL: https://chromiumcodereview.appspot.com/23093008
git-svn-id: http://skia.googlecode.com/svn/trunk@10822 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-20 16:28:42 +00:00