Bug: chromium:895362
Change-Id: I2c5648ac064b20ba37482efcc0dfcc96f528416d
Reviewed-on: https://skia-review.googlesource.com/c/163250
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Clean up all the onMakeColorSpace implementations a bit.
Bug: skia:
Change-Id: I31f32fa711a3af38bd697886379b23cc703cf864
Reviewed-on: https://skia-review.googlesource.com/c/162030
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
This reverts commit 0c583af06d.
Reason for revert: DDL is failing
Original change's description:
> Widen internal API to support more complex YUV formats
>
> Bug: skia:7901
> Change-Id: I46fec08711b8b483cf58ccae733e4dc2a9689231
> Reviewed-on: https://skia-review.googlesource.com/c/162280
> Commit-Queue: Jim Van Verth <jvanverth@google.com>
> Reviewed-by: Brian Salomon <bsalomon@google.com>
TBR=egdaniel@google.com,jvanverth@google.com,bsalomon@google.com
Change-Id: Ibe3dd7abbce4a3b6afe74c565198dadc61a9f439
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:7901
Reviewed-on: https://skia-review.googlesource.com/c/163257
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Now that picture backed images always play back their contents to a
tagged surface, we can always construct them with either the destination
surface color space or the xform canvas color space, and get the same
results. To ensure that they always behave sensibly, fallback to sRGB if
neither color space is present.
With those changes, the caching and setup can be much simpler: the
source of the color space is irrelevant. Also, switch to using our new
hash data, rather than the suspicious caching based on pointers.
Finally, now that we enforce a color space on all of these generators,
the back-door factory can go away, along with the header.
PS: Fix a spelling error.
Bug: skia:
Change-Id: I40fd2d35f2b3e6f8a1657d47f57127adacb80a80
Reviewed-on: https://skia-review.googlesource.com/c/163249
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Bug: skia:7901
Change-Id: I46fec08711b8b483cf58ccae733e4dc2a9689231
Reviewed-on: https://skia-review.googlesource.com/c/162280
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Same deal as before, just swap_rb where needed.
The change to SkWebpCodec could probably land independently if we want.
Change-Id: Idd53ab76232cb95eb2f41cd65c6903fa7c5b01d6
Reviewed-on: https://skia-review.googlesource.com/c/163440
Commit-Queue: Brian Osman <brianosman@google.com>
Auto-Submit: Mike Klein <mtklein@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Especially on the very first load of the wasm binary,
this has been seen to sometimes timeout.
Bug: skia:
Change-Id: I9321eb1e2f70751a1dbbaee3c1e54d38f5bea450
Reviewed-on: https://skia-review.googlesource.com/c/163247
Reviewed-by: Kevin Lubick <kjlubick@google.com>
This reverts commit 03eba9cb1d.
Reason for revert: Chrome is settled down
Original change's description:
> Revert "Remove SK_LEGACY_XFORM_CANVAS_IN_PICTURE_IMAGES"
>
> This reverts commit af119e58dc.
>
> Reason for revert: Chrome reverted the CL that removed this - somehow things haven't exploded, but I'm putting this back for now.
>
> Original change's description:
> > Remove SK_LEGACY_XFORM_CANVAS_IN_PICTURE_IMAGES
> >
> > Chrome no longer uses this.
> >
> > Bug: skia:
> > Change-Id: I245c592a040cd113e9bd3ddd1e582d27070baee1
> > Reviewed-on: https://skia-review.googlesource.com/c/162740
> > Auto-Submit: Brian Osman <brianosman@google.com>
> > Commit-Queue: Mike Reed <reed@google.com>
> > Reviewed-by: Mike Reed <reed@google.com>
>
> TBR=mtklein@google.com,brianosman@google.com,reed@google.com
>
> Change-Id: I681a17763815d6e16e8797789a006d72b84b4478
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: skia:
> Reviewed-on: https://skia-review.googlesource.com/c/163120
> Reviewed-by: Brian Osman <brianosman@google.com>
> Commit-Queue: Brian Osman <brianosman@google.com>
TBR=mtklein@google.com,brianosman@google.com,reed@google.com
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: skia:
Change-Id: I6519815f288f4bbd6f70552c1d941879b384a211
Reviewed-on: https://skia-review.googlesource.com/c/163248
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Removes about 120k uncompressed, 40k gzipped
Bug: skia:
Change-Id: I7e0b404f18fc3c6d4ff6b01d2c9bcd657b7d5e07
Reviewed-on: https://skia-review.googlesource.com/c/163246
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
It's the same as swap_rb -> srcover_rgba_8888.
Change-Id: I1849ecce6efd317a37c9640cc283b812cb23cd6d
Reviewed-on: https://skia-review.googlesource.com/c/163172
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
SkRasterPipeline's support for gray8 is a bit odd. Loads are done
directly, but stores are done using luminance_to_alpha and alpha stores.
Since we kind of need that idosyncratic luminance_to_alpha code anyway,
might as well commit to the gray-via-alpha strategy all the way. This
replaces three somewhat complicated stages with two simple new ones.
Change-Id: Ia63ebfb5616270055fd31a92cdfe78fb558d4051
Reviewed-on: https://skia-review.googlesource.com/c/163169
Commit-Queue: Brian Osman <brianosman@google.com>
Auto-Submit: Mike Klein <mtklein@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Adds
#Populate
as markup inside #Method, replacing
the method's description and #Param
and #Return. If present, this info
is retrieved from the include when
writing the web markdown and the
generated include.
TBR=caryclark@google.com
Docs-Preview: https://skia.org/?cl=162820
Bug: skia:
Change-Id: I5df16f227b86651d463e03ddd33849bb127891c0
Reviewed-on: https://skia-review.googlesource.com/c/162820
Commit-Queue: Cary Clark <caryclark@skia.org>
Auto-Submit: Cary Clark <caryclark@skia.org>
Reviewed-by: Cary Clark <caryclark@google.com>
Reviewed-by: Cary Clark <caryclark@skia.org>
c20ead32ad..25843dd651
git log c20ead32ad6d..25843dd65181 --date=short --no-merges --format='%ad %ae %s'
2018-10-18 ynovikov@chromium.org Align memory access in Copy32FixedTo32FVertexData
2018-10-17 jmadill@chromium.org perftests: Record trace events to JSON file.
2018-10-17 syoussefi@chromium.org Vulkan: Implement glFlush
2018-10-17 syoussefi@chromium.org Vulkan: Use a specialized macro for wrapped vulkan calls
2018-10-17 syoussefi@chromium.org Roll clang and other chromium deps
Created with:
gclient setdep -r third_party/externals/angle2@25843dd65181
The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=egdaniel@google.com
Change-Id: I638977f1411f5d2f3f8e27e942265df19f9ff7a8
Reviewed-on: https://skia-review.googlesource.com/c/163321
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
We only need to decode the source file once, not multiple times.
Bug: skia:
Change-Id: I1067eac6b7acc482f97fb1835c1c219d21cc37e9
Reviewed-on: https://skia-review.googlesource.com/c/163300
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Dropping the "r" makes it consistent with both the class name and
Benchmark::getName.
Bug: skia:
Change-Id: I17bcf699d162c678daabf92b4e39b7230428b98b
Reviewed-on: https://skia-review.googlesource.com/c/163280
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I3f41510f00211849b80ff121f5b18354174108c4
Reviewed-on: https://skia-review.googlesource.com/c/163173
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Mostly const-relax to allow moving. Also add an r-val overload for
Node attribute setters.
Change-Id: I15e5eeee95b7c2a460844fec5a5d312d59b612ca
Reviewed-on: https://skia-review.googlesource.com/c/163168
Commit-Queue: Florin Malita <fmalita@chromium.org>
Commit-Queue: Mike Klein <mtklein@google.com>
Auto-Submit: Florin Malita <fmalita@chromium.org>
Reviewed-by: Mike Klein <mtklein@google.com>
Change-Id: Iad58fccf475649246a4fc9e2dc933b9a73b786d6
Reviewed-on: https://skia-review.googlesource.com/c/163240
Commit-Queue: Hal Canary <halcanary@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
Auto-Submit: Hal Canary <halcanary@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
Bug: skia:7903
Change-Id: I91d0abee6baa8e939b9a9b90386b7d13dfe8eece
Reviewed-on: https://skia-review.googlesource.com/c/163222
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Of note, the perf results reported are not directly
comparable CPU->GPU because the GPU ones are likely
emulated (no real gpu in the Docker container on an
GCE VM).
Bug: skia:
Change-Id: I52259085f4d9e22c45b67f3e8ce1211a5c6c6d3e
Reviewed-on: https://skia-review.googlesource.com/c/163126
Reviewed-by: Kevin Lubick <kjlubick@google.com>
A fuzzer has produced one, and hit the existing 4x4 == 3x3 assert.
Bug: chromium:895763
Change-Id: Id24b982464166fe5b79ab26c1a3a0e931b76dc4c
Reviewed-on: https://skia-review.googlesource.com/c/163166
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
All of Flutter's non-test drawing is done with Ganesh,
and the few shaders that are legacy-only are not used by Flutter.
This should cut a bunch of essentially-dead code from Flutter, though
some of the Flutter test images may change because those test images are
software rasterized. Hopefully nothing should look terribly different.
Looks like this cuts ~27K from Flutter.
Change-Id: I4c8078db17fe9d24b15ed9d8c6adb528a382f02a
Reviewed-on: https://skia-review.googlesource.com/c/163165
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
This reverts commit 63bc5891e4.
Reason for revert: Chrome test has been fixed.
Original change's description:
> Revert "Remove ancient support for kUnknown_SkColorType in SkBitmapDevice"
>
> This reverts commit e3a5b1960d.
>
> Reason for revert: possibly breaking chrome roll
>
> Original change's description:
> > Remove ancient support for kUnknown_SkColorType in SkBitmapDevice
> >
> > Bug: skia:
> > Change-Id: I7559544f46b49be5ac6b38add8d1b61c010d3d6f
> > Reviewed-on: https://skia-review.googlesource.com/c/162284
> > Reviewed-by: Mike Reed <reed@google.com>
> > Commit-Queue: Brian Osman <brianosman@google.com>
>
> TBR=mtklein@google.com,brianosman@google.com,reed@google.com
>
> Change-Id: I95d502f80fc3c336484b306b50c9b5fe16f26a82
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: skia:
> Reviewed-on: https://skia-review.googlesource.com/c/163040
> Reviewed-by: Greg Daniel <egdaniel@google.com>
> Commit-Queue: Greg Daniel <egdaniel@google.com>
TBR=egdaniel@google.com,mtklein@google.com,brianosman@google.com,reed@google.com
Change-Id: I37aa32558cd75ddca8c3ba150e3b90d09033372b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/c/163127
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Current savings : 96K on intel mac
Breaks -- these subclass don't have a pipeline
- emboss
- perlinnoise
For now, shadercontext is still on -- clients must opt-out with SK_DISABLE_LEGACY_SHADERCONTEXT
Bug: skia:
Change-Id: Idd14cae4013e8de92f16b0707f8b8d43bb6d11dd
Reviewed-on: https://skia-review.googlesource.com/c/162362
Auto-Submit: Mike Reed <reed@google.com>
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
1d8a783c9d..c20ead32ad
git log 1d8a783c9db2..c20ead32ad6d --date=short --no-merges --format='%ad %ae %s'
2018-10-17 tikuta@chromium.org Remove unused lambda capture
2018-10-17 jmadill@chromium.org Vulkan: Fix deleting in-use descriptor sets.
Created with:
gclient setdep -r third_party/externals/angle2@c20ead32ad6d
The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=egdaniel@google.com
Change-Id: Ibe81a4c380c942ffe6e43edc99ad1201d8e56216
Reviewed-on: https://skia-review.googlesource.com/c/163180
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
The serialization showed up as a significant cost on profiling,
primarily because of the lock acquired for query the glyph count of a
typeface and the SkData allocation each time. Avoid this by caching the
data for each typeface.
Note that since the typeface is already cached on the client side, we
shouldn't need to resend the typeface data each time. But serializing a
typeface doesn't guarentee that it will be sent, because of which we
can not make any assumptions about client state after serialize is
called.
Bug: 894200
Change-Id: I45e43e297d817826646ab08bd4937b2625603858
Reviewed-on: https://skia-review.googlesource.com/c/162841
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Khusal Sagar <khushalsagar@chromium.org>
Auto-Submit: Khusal Sagar <khushalsagar@chromium.org>
Change-Id: I2f08a3d26f411ef34d964a8f324696e97e8970ed
Reviewed-on: https://skia-review.googlesource.com/c/163162
Commit-Queue: Herb Derby <herb@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Auto-Submit: Herb Derby <herb@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Bug: skia:
Change-Id: If7f5eaf19fd268613ac883b268b424ca84b9be00
Reviewed-on: https://skia-review.googlesource.com/c/162660
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
public before private
some c++14 constexprification
remove unused functions
Change-Id: Idb49c476020c7fe9be624fc21c1371e99bf22bb1
Reviewed-on: https://skia-review.googlesource.com/c/162821
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
