commit-bot@chromium.org
8c294900f3
Add DPI stettings to SkDocument::CreatePDF(). Tests will be added in a future cl, once DPI will be used in SkPDFDevice
...
R=reed@google.com , bungeman@google.com , vandebo@chromium.org
Author: edisonn@google.com
Review URL: https://codereview.chromium.org/32233003
git-svn-id: http://skia.googlecode.com/svn/trunk@11886 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-21 17:14:37 +00:00
senorblanco@chromium.org
9f51d16b54
Second round of matrixconvolution rebaselines.
...
TBR=robertphillips
BUG=
Review URL: https://codereview.chromium.org/33103002
git-svn-id: http://skia.googlecode.com/svn/trunk@11885 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-21 17:04:11 +00:00
commit-bot@chromium.org
4b7d673089
More clang warning fixes.
...
Mostly unused functions and variables removed.
BUG=None
TEST=ninja -C out/Debug most
ninja -C out/Release most
R=bsalomon@google.com , caryclark@google.com , robertphillips@google.com
Author: tfarina@chromium.org
Review URL: https://codereview.chromium.org/27933002
git-svn-id: http://skia.googlecode.com/svn/trunk@11884 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-21 16:41:00 +00:00
commit-bot@chromium.org
f642f8cf90
Magnifier gpu path fix
...
The y axis was inverted for the offset, which should have been computed on the other side of the magnifying rectangle.
BUG=
R=bsalomon@google.com , senorblanco@google.com , senorblanco@chromium.org
Author: sugoi@chromium.org
Review URL: https://codereview.chromium.org/28273005
git-svn-id: http://skia.googlecode.com/svn/trunk@11883 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-21 15:59:26 +00:00
senorblanco@chromium.org
718f5e2b7c
First round of matrixconvolution rebaselines.
...
TBR=robertphillips
Review URL: https://codereview.chromium.org/32823002
git-svn-id: http://skia.googlecode.com/svn/trunk@11882 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-21 15:41:55 +00:00
commit-bot@chromium.org
8e919add40
Fix GrProgramsTest to not generate tests with too many TexCoord references
...
Make GrProgramsTest check how many texture coordinate sets are
available and select random effects up until the amount runs out.
Otherwise, following effect sequence would fail the shader compilation
when Skia is compiled with nv_path_rendering on (eg. when fixed
function codepath is used):
* Stage 0: TextureDomain (1 texcoord)
* Stage 1: Convolution (1 texcoord)
* Stage 2: Bitmap Alpha Threshold (2 texcoords)
* Stage 3: DisplacementMap (2 texcoords)
* Stage 4: Config Conversion (1 texcoords)
* Stage 5: Two-Point Conical Gradient (2 texcoords)
This would use more texture coordinate sets than 8, which is fairly
common amount currently.
R=bsalomon@google.com , cdalton@nvidia.com
Author: kkinnunen@nvidia.com
Review URL: https://codereview.chromium.org/32403002
git-svn-id: http://skia.googlecode.com/svn/trunk@11881 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-21 14:48:23 +00:00
commit-bot@chromium.org
15455b2a13
Apply matrix early in draw bitmap
...
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/30593003
git-svn-id: http://skia.googlecode.com/svn/trunk@11880 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-21 14:48:17 +00:00
reed@google.com
e7e29b7815
scope ComputeIsOpaque with SkBitmap
...
BUG=
Review URL: https://codereview.chromium.org/32653002
git-svn-id: http://skia.googlecode.com/svn/trunk@11879 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-21 14:31:20 +00:00
reed@google.com
9cd697c696
change ERROR label to BAD_CONFIG -- avoid windows complaint
...
BUG=
Review URL: https://codereview.chromium.org/32623002
git-svn-id: http://skia.googlecode.com/svn/trunk@11878 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-21 14:12:13 +00:00
reed@google.com
383a697692
store SkAlphaType inside SkBitmap, on road to support unpremul
...
BUG=
R=bsalomon@google.com , scroggo@google.com
Review URL: https://codereview.chromium.org/25275004
git-svn-id: http://skia.googlecode.com/svn/trunk@11877 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-21 14:00:07 +00:00
robertphillips@google.com
c2eae47954
Reverting revert of r11862 (Constify SkFlattenable::getFactory()) or reverting r11871.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@11876 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-21 12:26:10 +00:00
robertphillips@google.com
466ea91886
A few stragglers for r1187 (Fix cubic->quad RR corner regression)
...
https://codereview.chromium.org/31333002/
git-svn-id: http://skia.googlecode.com/svn/trunk@11875 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-21 00:15:15 +00:00
robertphillips@google.com
7c4d5124d1
More rebaselines for r1187 (Fix cubic->quad RR corner regression)
...
https://codereview.chromium.org/31323002/
git-svn-id: http://skia.googlecode.com/svn/trunk@11874 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-20 23:53:11 +00:00
robertphillips@google.com
d8b0a148c5
rebaselines after r1187 (Fix cubic->quad RR corner regression)
...
https://codereview.chromium.org/31313002/
git-svn-id: http://skia.googlecode.com/svn/trunk@11873 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-20 23:06:40 +00:00
senorblanco@chromium.org
2a4223c783
Fix for cropped matrix convolution for BottomLeft render targets.
...
R=bsalomon@google.com
Review URL: https://codereview.chromium.org/31083002
git-svn-id: http://skia.googlecode.com/svn/trunk@11872 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-20 20:21:19 +00:00
robertphillips@google.com
b5e391025e
Reverted due to Chromium compilation failures. Please see:
...
https://codereview.chromium.org/30973002/
git-svn-id: http://skia.googlecode.com/svn/trunk@11871 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-20 13:34:21 +00:00
robertphillips@google.com
123671901a
Fix cubic->quad RR corner regression
...
https://codereview.chromium.org/29673002/
git-svn-id: http://skia.googlecode.com/svn/trunk@11870 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-20 13:11:16 +00:00
skia.committer@gmail.com
b3c2da312f
Sanitizing source files in Housekeeper-Nightly
...
git-svn-id: http://skia.googlecode.com/svn/trunk@11869 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-19 07:02:35 +00:00
vandebo@chromium.org
1c87672883
Revert "[PDF] Add unpremultiply support and a GM (try3)."
...
This is crashing in some configurations, can now repro.
This reverts commit 12add177d0ab7bbac97f5093c9382924d88bde8c.
Review URL: https://codereview.chromium.org/29903002
git-svn-id: http://skia.googlecode.com/svn/trunk@11868 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-18 21:04:51 +00:00
mtklein@google.com
a7a9f37a31
DM: add --writePath
...
For fun, make the output prettier, hiding ", N failures" unless there is one.
BUG=
R=bsalomon@google.com
Review URL: https://codereview.chromium.org/29293003
git-svn-id: http://skia.googlecode.com/svn/trunk@11867 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-18 20:52:44 +00:00
vandebo@chromium.org
59fd223870
[PDF] Add unpremultiply support and a GM (try3).
...
This is a resubmit of https://codereview.chromium.org/22831039 which was
reverted because it causes issues on Windows.
BUG=chromium:175548
R=edisonn@google.com
Review URL: https://codereview.chromium.org/29193003
git-svn-id: http://skia.googlecode.com/svn/trunk@11866 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-18 20:18:29 +00:00
vandebo@chromium.org
dc37e20647
Revert "PDF: support perspective in simple shaders. (this version does not work well with tilling)"
...
Accidentally committed the wrong git branch.
This reverts commit 76839c65670df8a863041a82a4b61502e78af043.
Review URL: https://codereview.chromium.org/29743002
git-svn-id: http://skia.googlecode.com/svn/trunk@11865 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-18 20:16:34 +00:00
vandebo@chromium.org
eb5992c6cc
PDF: support perspective in simple shaders. (this version does not work well with tilling)
...
Review URL: https://codereview.chromium.org/26389006
git-svn-id: http://skia.googlecode.com/svn/trunk@11864 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-18 20:14:08 +00:00
senorblanco@chromium.org
7938bae14a
Implement crop rect support for SkMatrixConvolutionImageFilter.
...
R=bsalomon@google.com
Review URL: https://codereview.chromium.org/27471002
git-svn-id: http://skia.googlecode.com/svn/trunk@11863 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-18 20:08:14 +00:00
commit-bot@chromium.org
575604d4c2
Constify SkFlattenable::getFactory().
...
This allows us to also constify the argument of
SkFlattenableWriteBuffer::writeFlattenable() - which I've recently found
myself const-casting for no apparent good reason.
R=bungeman@google.com , mtklein@google.com , reed@google.com
Author: fmalita@chromium.org
Review URL: https://codereview.chromium.org/29143005
git-svn-id: http://skia.googlecode.com/svn/trunk@11862 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-18 19:37:55 +00:00
epoger@google.com
cce4e09a5c
Revert r11860, which was supposed to just be a whitespace change (argh)
...
(SkipBuildbotRuns)
Review URL: https://codereview.chromium.org/29603002
git-svn-id: http://skia.googlecode.com/svn/trunk@11861 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-18 18:36:25 +00:00
epoger@google.com
94041c6d8b
Whitespace change to trigger buildbots after https://code.google.com/p/skia/source/detail?r=11859
...
git-svn-id: http://skia.googlecode.com/svn/trunk@11860 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-18 18:33:03 +00:00
vandebo@chromium.org
ce60c1fc5d
Revert "[PDF] Add unpremultiply support and a GM."
...
This reverts commit f746273b8ba282f548a6eaffb45b11b6f468aa8e.
Review URL: https://codereview.chromium.org/29343002
git-svn-id: http://skia.googlecode.com/svn/trunk@11858 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-18 16:10:03 +00:00
vandebo@chromium.org
c4d17716cd
[PDF] Add unpremultiply support and a GM.
...
This is a resubmit of https://codereview.chromium.org/22831039 which was
reverted because it causes issues on Windows.
BUG=chromium:175548
R=edisonn@google.com
Review URL: https://codereview.chromium.org/27518003
git-svn-id: http://skia.googlecode.com/svn/trunk@11857 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-18 15:53:03 +00:00
bsalomon@google.com
de7de5638f
rebaseline gpu complex clip tests
...
Review URL: https://codereview.chromium.org/29303002
git-svn-id: http://skia.googlecode.com/svn/trunk@11856 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-18 15:47:28 +00:00
epoger@google.com
f711f320a3
GM: add --ignoreFailuresFile as an alternative to --ignoreTests
...
(moved from old review at https://codereview.chromium.org/27752002/ )
This will allow the user to specify the tests to ignore failure on as a file,
rather than listing them out in the command line (and thus busting the
line length limit on Android).
BUG=skia:1730
R=scroggo@google.com
Review URL: https://codereview.chromium.org/29203002
git-svn-id: http://skia.googlecode.com/svn/trunk@11855 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-18 14:55:47 +00:00
commit-bot@chromium.org
6ee68583f8
SkThreadPool: allow for Runnables that add other Runnables to the pool.
...
There's a scenario that we're currently not allowing for, but I'd really like to use in DM:
1) client calls add(SomeRunnable*) several times
2) client calls wait()
3) any of the runnables added by the client _themselves_ call add(SomeOtherRunnable*)
4-inf) maybe those SomeOtherRunnables too call add(SomeCrazyThirdRunnable*), etc.
Right now in this scenario we'll assert in debug mode in step 3) when we call
add() and we're waiting to stop, and do strange unspecified things in release
mode.
The old threadpool had basically two states: running, and waiting to stop. If
a thread saw we were waiting to stop and the queue was empty, that thread shut
down. This wasn't accounting for any work that other threads might be doing;
potentially they were about to add to the queue.
So now we have three states: running, waiting, and halting. When the client
calls wait() (or the destructor triggers), we move into waiting. When a thread
notices we're _really_ done, that is, have an empty queue and there are no
active threads, we move into halting. The halting state actually triggers the
threads to stop, which wait() is patiently join()ing on.
BUG=
R=bungeman@google.com , bsalomon@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/26389005
git-svn-id: http://skia.googlecode.com/svn/trunk@11852 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-18 14:19:19 +00:00
skia.committer@gmail.com
f84ad8f7fc
Sanitizing source files in Housekeeper-Nightly
...
git-svn-id: http://skia.googlecode.com/svn/trunk@11850 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-18 07:01:59 +00:00
senorblanco@chromium.org
1aa68723b8
Make SkImageFilter::asNewEffect() (and all derived-class overrides) protected.
...
R=bsalomon@google.com , bsalomon
Review URL: https://codereview.chromium.org/26937006
git-svn-id: http://skia.googlecode.com/svn/trunk@11847 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-17 19:35:09 +00:00
robertphillips@google.com
32bbcf828d
Add texture filtering override to debugger
...
https://codereview.chromium.org/27716003/
git-svn-id: http://skia.googlecode.com/svn/trunk@11846 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-17 17:56:10 +00:00
robertphillips@google.com
c2cc1dbe81
Revert r11842 (call drawRect to try GrAARectRenderer if the path is a rect - https://codereview.chromium.org/23484007 ) due to changes to the following GM images:
...
inverse_paths
pathopsinverse
git-svn-id: http://skia.googlecode.com/svn/trunk@11845 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-17 17:34:20 +00:00
commit-bot@chromium.org
4256d2494e
Add support for GL_CHROMIUM_renderbuffer_format_BGRA8888
...
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/27525006
git-svn-id: http://skia.googlecode.com/svn/trunk@11844 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-17 16:29:41 +00:00
commit-bot@chromium.org
cd7992ba55
ARM Skia NEON patches - 30 - Xfermode: NEON modeprocs
...
Xfermode: NEON implementation of SIMD procs
This patch contains a NEON implementation for a number of Xfermodes.
It provides a big speedup on Xfermode benchmarks (currently up to 3x
with gcc4.7 but up to 10x when gcc produces optimal code for it).
Signed-off-by: Kévin PETIT <kevin.petit@arm.com>
BUG=
Committed: http://code.google.com/p/skia/source/detail?r=11777
Committed: http://code.google.com/p/skia/source/detail?r=11813
R=djsollen@google.com , mtklein@google.com , reed@google.com , robertphillips@google.com
Author: kevin.petit.arm@gmail.com
Review URL: https://codereview.chromium.org/26627004
git-svn-id: http://skia.googlecode.com/svn/trunk@11843 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-17 16:29:34 +00:00
commit-bot@chromium.org
521a46750d
If the path is a rect, call drawRect to raster the geometry in SkCanvas::drawPath to get better performance.
...
R=bsalomon@google.com , robertphillips@google.com , reed@google.com
Author: yunchao.he@intel.com
Review URL: https://codereview.chromium.org/23484007
git-svn-id: http://skia.googlecode.com/svn/trunk@11842 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-17 16:29:21 +00:00
robertphillips@google.com
627f66283b
Disable r11835 (Replace cubic round rect corners with quads) due to performance regression
...
git-svn-id: http://skia.googlecode.com/svn/trunk@11841 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-17 16:29:25 +00:00
robertphillips@google.com
e0d7277b59
Revert 11839 (rebaseline images after r11835) due to performance regression in 11835
...
git-svn-id: http://skia.googlecode.com/svn/trunk@11840 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-17 16:28:11 +00:00
robertphillips@google.com
01c51b76bf
rebaseline images after r11835
...
https://codereview.chromium.org/27722002/
git-svn-id: http://skia.googlecode.com/svn/trunk@11839 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-17 15:23:26 +00:00
robertphillips@google.com
3f1588482f
Added nested_bw to suppression list
...
git-svn-id: http://skia.googlecode.com/svn/trunk@11838 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-17 13:17:04 +00:00
mtklein@google.com
e4b500b0bc
rebaseline stragglers from repeated radial gradient tweak
...
BUG=
Review URL: https://codereview.chromium.org/27700002
git-svn-id: http://skia.googlecode.com/svn/trunk@11837 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-17 12:34:54 +00:00
robertphillips@google.com
6b1b248bbe
Fix typo in ignored-tests file
...
git-svn-id: http://skia.googlecode.com/svn/trunk@11836 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-17 12:27:55 +00:00
robertphillips@google.com
1cc385b7a4
Replace cubic round rect corners with quads
...
https://codereview.chromium.org/26372006/
git-svn-id: http://skia.googlecode.com/svn/trunk@11835 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-17 12:17:27 +00:00
skia.committer@gmail.com
4677acc759
Sanitizing source files in Housekeeper-Nightly
...
git-svn-id: http://skia.googlecode.com/svn/trunk@11834 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-17 07:02:33 +00:00
robertphillips@google.com
dfe0f43e11
Reverting r11813 (ARM Skia NEON patches - 30 - Xfermode: NEON modeprocs - https://codereview.chromium.org/26627004 ) due to Chromium compilation faliures.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@11833 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-17 00:09:17 +00:00
bsalomon@google.com
3ae71b6b2e
Initial baselines for skbug1719
...
Review URL: https://codereview.chromium.org/27212004
git-svn-id: http://skia.googlecode.com/svn/trunk@11832 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-16 21:27:18 +00:00
mtklein@google.com
6065d36bb8
tools/rebaseline.py --tests xfermodes3 drawbitmaprect scaled_tilemode_gradient tilemode_gradient
...
BUG=
Review URL: https://codereview.chromium.org/26233006
git-svn-id: http://skia.googlecode.com/svn/trunk@11831 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-16 21:23:18 +00:00