Commit Graph

15503 Commits

Author SHA1 Message Date
scroggo
6005e9b86f Update expectations for Test-Mac10.9-MacMini6.2-HD4000-x86_64-Debug
TBR=borenet

Review URL: https://codereview.chromium.org/797273004
2014-12-12 11:13:35 -08:00
egdaniel
bd17ac55dd Remove gms from ignore-tests.
TBR=

BUG=skia:

Review URL: https://codereview.chromium.org/800033002
2014-12-12 11:01:29 -08:00
borenet
16291189ce Blindly check in GM and skimage expectations for new bots
BUG=skia:

Review URL: https://codereview.chromium.org/798053002
2014-12-12 09:50:23 -08:00
caryclark
8dd31cf69e Extract cubic classification from gpu into geometry
Move code from the GPU path utilities into geometry so that
path ops can share.

Review URL: https://codereview.chromium.org/787763007
2014-12-12 09:11:24 -08:00
scroggo
09acfc8d1f Pass gyp_source_dir to generate_tool.
When generating the tool makefiles, which also calls
android_framework_gyp, we also need to pass the gyp directory.

TBR=borenet
NOTRY=True
NOTREECHECKS=True

BUG=skia:3233

Review URL: https://codereview.chromium.org/804473005
2014-12-12 09:01:56 -08:00
skia.buildbots
e1157ab9ec Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=

Review URL: https://codereview.chromium.org/797983002
2014-12-12 08:56:53 -08:00
jvanverth
acfe744943 Update some Galaxy S4 expectations.
TBR=djsollen@google.com

Review URL: https://codereview.chromium.org/804493002
2014-12-12 08:56:48 -08:00
jvanverth
49921b1cdb Ignore some expectations for Nexus 10.
BUG=skia:3205
TBR=bsalomon@google.com

Review URL: https://codereview.chromium.org/800483004
2014-12-12 08:51:46 -08:00
bsalomon
ef3fcd877a More win64 warning fixes
Review URL: https://codereview.chromium.org/798723002
2014-12-12 08:51:39 -08:00
bsalomon
81a6c3cc75 Roll ANGLE
BUG=skia:3192

Review URL: https://codereview.chromium.org/788373002
2014-12-12 08:46:38 -08:00
mtklein
f0f1411343 Cull pushCull and popCull from Skia.
These calls are unused and going away.  Waiting on crrev.com/796083002.

BUG=skia:

Review URL: https://codereview.chromium.org/794263002
2014-12-12 08:46:25 -08:00
mtklein
59dba146fe SkRecord: increase min block to 512B, remove max.
When we added the 64K allocation cap, the bots showed we took a perf hit
on some large .skps like desk_pokemonwiki.skp, despite not seeing a local
effect.  I'm still not seeing that locally, but I'd like to try removing the cap on
the bots to see what happens.  For big monolithic pictures, really packing into
memory tightly is probably not as important as it is for tiny ones.

Similarly, we're probably being too cautious about making tiny allocations.
Today we start at 16 bytes, which isn't really enough to record anything.
Even the smallest picture, say,
    save
        clipRect
        drawRect
    restore
requires ~200 bytes, so we might as well move our minimum block size up
near there.

I don't know if 16 bytes is too small to start for GrTextStrikes, so I've left the
behavior the same (though the max is still gone).

Local recording performance is neutral-to-positive:
             tabl_deviantart.skp	 126us ->  129us	1.02x
                tabl_nytimes.skp	 110us ->  112us	1.02x
           tabl_cuteoverload.skp	 521us ->  530us	1.02x
             desk_mobilenews.skp	 673us ->  682us	1.01x
             desk_chalkboard.skp	 843us ->  854us	1.01x
                 desk_sfgate.skp	 528us ->  535us	1.01x
            desk_silkfinance.skp	68.2us ->   69us	1.01x
                desk_youtube.skp	 623us ->  629us	1.01x
                desk_blogger.skp	 472us ->  475us	1.01x
     desk_jsfiddlehumperclip.skp	42.2us -> 42.5us	1.01x
                   desk_espn.skp	 255us ->  256us	1.01x
                   desk_ebay.skp	 174us ->  174us	1x
                desk_twitter.skp	 454us ->  455us	1x
                 tabl_pravda.skp	 200us ->  201us	1x
              desk_wordpress.skp	 782us ->  784us	1x
               desk_samoasvg.skp	 762us ->  761us	1x
                tabl_mozilla.skp	1.58ms -> 1.58ms	1x
               tabl_slashdot.skp	 107us ->  107us	1x
               tabl_techmeme.skp	 102us ->  102us	0.99x
            tabl_gamedeksiam.skp	 729us ->  724us	0.99x
                 tabl_nofolo.skp	65.3us -> 64.7us	0.99x
            desk_gmailthread.skp	 339us ->  336us	0.99x
                tabl_sahadan.skp	  91us ->   90us	0.99x
           desk_yahooanswers.skp	 144us ->  142us	0.99x
                   tabl_cnet.skp	 143us ->  141us	0.99x
             tabl_googleblog.skp	 206us ->  203us	0.99x
                    tabl_cnn.skp	 160us ->  158us	0.99x
               tabl_frantzen.skp	50.5us -> 49.6us	0.98x
               desk_linkedin.skp	 328us ->  323us	0.98x
                   tabl_digg.skp	 790us ->  769us	0.97x
         desk_jsfiddlebigcar.skp	40.6us -> 39.5us	0.97x
                 desk_mapsvg.skp	1.57ms -> 1.52ms	0.97x
                  tabl_gmail.skp	19.4us -> 18.6us	0.96x
                   tabl_hsfi.skp	9.81us -> 9.11us	0.93x

BUG=skia:

Review URL: https://codereview.chromium.org/793033002
2014-12-12 08:41:24 -08:00
joshualitt
e832b958e0 valgrind static uninit fix
TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/800873002
2014-12-12 08:41:16 -08:00
scroggo
2932276444 Add some debugging information to gyp_to_android.
Temporary, to help diagnose skbug.com/3233

TBR=borenet
NOTRY=True
NOTREECHECKS=True
BUG=skia:3233

Review URL: https://codereview.chromium.org/802703002
2014-12-12 07:51:37 -08:00
jvanverth
a60b2ead80 Fix float and half float support on mobile.
It's unclear what params should be used for half float alpha
rendertargets, so they are disabled for the moment.

Review URL: https://codereview.chromium.org/799593002
2014-12-12 05:58:06 -08:00
kkinnunen
b5f4961b30 Fix GpuLayerCacheTest compile error
Fix GpuLayerCacheTest compile error:
GpuLayerCacheTest.cpp:120:34: error: comparison between signed and
unsigned integer expressions [-Werror=sign-compare]

gcc --version
gcc (Ubuntu/Linaro 4.6.4-1ubuntu1~12.04) 4.6.4

Review URL: https://codereview.chromium.org/794003003
2014-12-12 05:29:12 -08:00
reed
891372c3b5 use SkScalar instead of float
BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/796803005
2014-12-11 20:19:58 -08:00
joshualitt
3326972872 adding some flaky gms to ignore
TBR=
NOTRY=True
BUG=skia:

Review URL: https://codereview.chromium.org/789963005
2014-12-11 18:44:22 -08:00
joshualitt
dfc2e34e74 rebase and remove ignores
NOTRY=True
TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/788193005
2014-12-11 17:26:44 -08:00
joshualitt
56995b5cc0 Remove GP from drawstate, revision of invariant output for GP
BUG=skia:

Committed: https://skia.googlesource.com/skia/+/c6bc58eded89b0c0a36b8e20e193c200f297a0da

Review URL: https://codereview.chromium.org/791743003
2014-12-11 15:44:02 -08:00
junov
5756aff409 Adding a custom data field to GrGpuResource
Motivation: allow Blink to track pre-existing mailbox names for
textures that are recycled by the ganesh scratch texture pool.

BUG=440462
TBR=bsalomon@google.com

Review URL: https://codereview.chromium.org/796163002
2014-12-11 14:59:32 -08:00
skia.buildbots
8d6e2e308f Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=

Review URL: https://codereview.chromium.org/799653002
2014-12-11 14:42:58 -08:00
joshualitt
b089874c4d one more ignore for hairlines
TBR=
NOTRY=True
BUG=skia:

Review URL: https://codereview.chromium.org/795293002
2014-12-11 14:27:54 -08:00
bsalomon
ccb328d52a Fix some win64 warnings.
Review URL: https://codereview.chromium.org/795223002
2014-12-11 13:31:06 -08:00
rmistry
e556089dd1 Increase timeout on sfgate pageset
TBR=scroggo
NOTRY=true
BUG=skia:3196

Review URL: https://codereview.chromium.org/800563002
2014-12-11 13:23:28 -08:00
egdaniel
c230414861 Create xfer processor backend.
This includes:
-Having an actual XP stage at the end of the gl pipeline.
-All Blending work is handled by XP until actually setting GL blend states
-GLPrograms test to test XP

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/4dffc940c430eec66d4707490eace19c9b3f7904

Review URL: https://codereview.chromium.org/764643004
2014-12-11 13:15:14 -08:00
robertphillips
8c508b4413 Update GM to permit correctness testing of MPD on the GMs
Review URL: https://codereview.chromium.org/794273003
2014-12-11 13:10:23 -08:00
joshualitt
5f975d0fec new hairlines gm unstable on hd2000
NOTRY=True
TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/800543002
2014-12-11 13:10:05 -08:00
scroggo
60936c732b Add parameter to specify gyp dir to gyp_to_android.
NOTRY=true
NOTREECHECKS=True
BUG=skia:3233

Review URL: https://codereview.chromium.org/800573002
2014-12-11 13:05:14 -08:00
mtklein
f55c314bfa Enforce thread-safety of bitmaps in pictures via the type.
No runtime difference here, but it makes it impossible to forget to make
a shallow copy; you can't get at the full bitmap without it.

NOTREECHECKS=true

BUG=skia:

Review URL: https://codereview.chromium.org/799603002
2014-12-11 12:43:04 -08:00
mtklein
1a4900e8be Force embedding full font when serializing pictures.
We can't do this unconditionally or pipe will become stupidly slow.

DM's serialize mode fails subtly on Mac when we force embedding, so I've
#ifdef'd that away.  Other platforms look fine.

BUG=skia:

Review URL: https://codereview.chromium.org/796523002
2014-12-11 11:06:00 -08:00
scroggo
895c43b28b Replace EncodeBitmap with an interface.
Gives more flexibility to the caller to decide whether to use the
encoded data returned by refEncodedData().

Provides an implementation that supports the old version of
SkPicture::serialize().

TODO: Update Chrome, so we can remove SK_LEGACY_ENCODE_BITMAP entirely

BUG=skia:3190

Review URL: https://codereview.chromium.org/784643002
2014-12-11 10:53:58 -08:00
junov
436293a330 Making GrGpuResource::release public for special case in Blink
BUG=440462

Review URL: https://codereview.chromium.org/739383006
2014-12-11 10:32:32 -08:00
rmistry
2f37ae17ea Remove action_runner steps for worldjournal pageset to prevent crashes
BUG=skia:3196
NOTRY=true

Review URL: https://codereview.chromium.org/795173002
2014-12-11 10:24:27 -08:00
joshualitt
6fdb065666 hmm one more hairlines 'straggler' might be flipflopping
TBR=
NOTRY=
BUG=skia:

Review URL: https://codereview.chromium.org/798533005
2014-12-11 10:02:30 -08:00
joshualitt
14677cf353 straggler hairline
NOTRY=True
TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/796893002
2014-12-11 08:58:37 -08:00
fmalita
0de8010432 Poppler rebaseline for clipped-bitmap-shaders-clamp
Follow-up for https://codereview.chromium.org/787043006.

TBR=scroggo@google.com

Review URL: https://codereview.chromium.org/798533003
2014-12-11 08:20:38 -08:00
robertphillips
7b9e8a4b6a Apply the layer's image filter to the hoisted image
Exposing SkSurface_Gpu makes me sad and I would welcome alternatives.

This change is desireable since it greatly decreases the render target swaps.

Review URL: https://codereview.chromium.org/792923002
2014-12-11 08:20:31 -08:00
joshualitt
b511dfe326 rebase cpu hairlines
NOTRY=True
NOTREECHECKS=True
TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/793393002
2014-12-11 07:37:48 -08:00
reed
7bc0b42567 update test after I added a clip call, making the count odd
BUG=skia:
TBR=
NOTREECHECKS=True
NOTRY=True

Review URL: https://codereview.chromium.org/797633002
2014-12-11 07:30:58 -08:00
reed
2ff1fcede1 Defer saves() until they're needed
patch from issue 759443006 at patchset 40001 (http://crrev.com/759443006#ps40001)

BUG=skia:

Review URL: https://codereview.chromium.org/767333002
2014-12-11 07:07:38 -08:00
joshualitt
8da8e9d751 rebase hairlines
TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/795133002
2014-12-11 06:53:34 -08:00
joshualitt
f364b61dd8 Really fix valgrind issue
TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/795123002
2014-12-11 06:52:01 -08:00
scroggo
0ac8c786a5 More rebaselines.
TBR=robertphillips
BUG=skia:

Review URL: https://codereview.chromium.org/793353002
2014-12-11 06:22:32 -08:00
scroggo
dfc3a635f3 Mark nexus10 images as flaky.
TBR=robertphillips
BUG=skia:3226

Review URL: https://codereview.chromium.org/785323003
2014-12-11 06:21:50 -08:00
bungeman
90d354e448 Additional rebaselines for 3490263287.
TBR=bungeman1

Review URL: https://codereview.chromium.org/794863004
2014-12-11 03:37:37 -05:00
bungeman
3490263287 Replace use of deprecated CG methods.
OSX10.9 and iOS7.0 deprecated CGContextShowGlyphsAtPoint so a new API
should be used. OSX10.7 and iOS4.2 replace CGContextShowGlyphsAtPoint with
CTFontDrawGlyphs. OSX10.5 and iOS2.0 have CGContextShowGlyphsAtPositions
which works similarly to CTFontDrawGlyphs and has not yet been deprecated.
This change allows the use of CTFontDrawGlyphs when it is available,
falling back to CGContextShowGlyphsAtPositions when it isn't.

Review URL: https://codereview.chromium.org/770383002
2014-12-10 21:43:28 -08:00
joshualitt
294738268d Revert of Create xfer processor backend. (patchset #6 id:100001 of https://codereview.chromium.org/764643004/)
Reason for revert:
CL breaks windows DM

Original issue's description:
> Create xfer processor backend.
>
> This includes:
> -Having an actual XP stage at the end of the gl pipeline.
> -All Blending work is handled by XP until actually setting GL blend states
> -GLPrograms test to test XP
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/4dffc940c430eec66d4707490eace19c9b3f7904

TBR=bsalomon@google.com,joshualitt@chromium.org,egdaniel@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/789343002
2014-12-10 15:03:01 -08:00
joshualitt
5f9ba17a02 Revert of Add more ignore gm's for recent Xfer Processor CL (patchset #1 id:1 of https://codereview.chromium.org/786083004/)
Reason for revert:
Preventing revert of cl breaking windows DM

Original issue's description:
> Add more ignore gm's for recent Xfer Processor CL
>
> TBR=bsalomon@google.com
> NOTRY=true
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/125251133a62a07225b7119ab3ac90153ba4c58a

TBR=bsalomon@google.com,egdaniel@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/794883002
2014-12-10 14:57:56 -08:00
joshualitt
06f019fc0f Revert of Fix to set correct output type when blending when we've read dst (patchset #4 id:60001 of https://codereview.chromium.org/791143002/)
Reason for revert:
Breaks DM on windows

Original issue's description:
> Fix to set correct output type when blending when we've read dst
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/733fc2054044377e914559fa4f46db66ab7d9cea

TBR=bsalomon@google.com,egdaniel@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/795783002
2014-12-10 14:57:50 -08:00