Commit Graph

6162 Commits

Author SHA1 Message Date
junov@chromium.org
94f20dc89a Fixing crash in cloning empty SkPicture object
BUG=https://code.google.com/p/chromium/issues/detail?id=172062
TEST=Pictures unit test, test_clone_empty
Review URL: https://codereview.appspot.com/7223048

git-svn-id: http://skia.googlecode.com/svn/trunk@7430 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-28 21:04:44 +00:00
robertphillips@google.com
68f670fa72 Fix assert
https://codereview.appspot.com/7234050/



git-svn-id: http://skia.googlecode.com/svn/trunk@7428 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-28 20:55:42 +00:00
reed@google.com
75847199c2 fix build
Review URL: https://codereview.appspot.com/7229052

git-svn-id: http://skia.googlecode.com/svn/trunk@7426 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-28 20:53:22 +00:00
reed@google.com
b941bb3465 REBASELINE: enable setline fix for scan converter, with SK_IGNORE_SETLINE_FIX build guard.
Review URL: https://codereview.appspot.com/7225056

git-svn-id: http://skia.googlecode.com/svn/trunk@7425 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-28 20:43:09 +00:00
scroggo@google.com
08085f808b Change the method for timing individual tiles in bench_pictures.
When timing individual tiles in bench_pictures, keep a timer running
across all repeats, and then take the average. The former method of
timing each iteration separately runs into precision errors on some
platforms.

Running on my Mac Pro with OSX 10.8, the cmsecs for the new method
and the old method are roughly the same when checking the CPU time.
When checking the wall time, the old method often gives me 0ms,
while the new method gives me a larger value. I don't think this
can be entirely attributed to rounding though, since on occasion I
see the old method showing a short time period (.05 - .15ms) while
the new method shows .15ms higher (which is in range for the
difference I'm seeing for other tiles where the old method reports
0ms).

Some other changes:
PictureRenderer::resetState now takes a boolean parameter. If called
with false, it will only do a flush, while if called with true, it
will also call finish.

resetState is now called with true everywhere except in between
iterations of drawing the same tile (when timing individual tiles).

render_pictures_main no longer calls resetState directly, since it
already calls end, which calls resetState.

BUG=http://code.google.com/p/skia/issues/detail?id=1066

Review URL: https://codereview.appspot.com/7101060

git-svn-id: http://skia.googlecode.com/svn/trunk@7424 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-28 20:40:24 +00:00
jvanverth@google.com
cc78238f0b Move vertex layout definitions from GrDrawTarget to GrDrawState.
This is the first step in revising vertex layouts so that the currently
installed GrEffects determine the current vertex layout.

https://codereview.appspot.com/7235051/


git-svn-id: http://skia.googlecode.com/svn/trunk@7423 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-28 20:39:48 +00:00
robertphillips@google.com
4991b8f234 Added toString to SkDrawLooper-derived classes
https://codereview.appspot.com/7195054/



git-svn-id: http://skia.googlecode.com/svn/trunk@7422 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-28 20:21:59 +00:00
caryclark@google.com
85ec74ca54 shape ops work in progress
good checkpoint: nearly all tests pass solidly here

git-svn-id: http://skia.googlecode.com/svn/trunk@7420 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-28 19:25:51 +00:00
robertphillips@google.com
e219baf747 Add data() to all QString::toASCII Qt calls to help out Linux compiler
https://codereview.appspot.com/7232052/



git-svn-id: http://skia.googlecode.com/svn/trunk@7419 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-28 19:25:43 +00:00
robertphillips@google.com
ff6e6bade3 Add command line options to debugger
https://codereview.appspot.com/7221048/



git-svn-id: http://skia.googlecode.com/svn/trunk@7418 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-28 17:43:26 +00:00
reed@google.com
b6399a79b2 add (disabled) test for big dashing
git-svn-id: http://skia.googlecode.com/svn/trunk@7417 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-28 16:57:29 +00:00
senorblanco@chromium.org
22943cd588 Fix debug build. Unreviewed.
git-svn-id: http://skia.googlecode.com/svn/trunk@7416 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-28 16:48:51 +00:00
bsalomon@google.com
cabe00eace Fix build break after r7411 when GR_STATIC_RECT_VB is enabled.
Review URL: https://codereview.appspot.com/7220051

git-svn-id: http://skia.googlecode.com/svn/trunk@7415 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-28 16:46:55 +00:00
senorblanco@chromium.org
ef5dbe1cd9 Add an origin flag for backend (external) textures. Some textures in WebKit have a topdown orientation, and skia needs to be notified of this, so that they are not drawn upside-down.
Review URL: https://codereview.appspot.com/7200048

git-svn-id: http://skia.googlecode.com/svn/trunk@7414 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-28 16:42:38 +00:00
bsalomon@google.com
02ddc8b85a Make a bunch of virtuals in GrDrawTarget and GrGpu private. Subclasses shouldn't call them directly.
R=robertphillips@google.com
Review URL: https://codereview.appspot.com/7228048

git-svn-id: http://skia.googlecode.com/svn/trunk@7413 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-28 15:35:28 +00:00
bsalomon@google.com
9e040aed72 Remove unnecessary ptr derefs int r7411 (deref result is not used).
git-svn-id: http://skia.googlecode.com/svn/trunk@7412 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-28 14:31:19 +00:00
bsalomon@google.com
adc6536fe5 Remove getter of writable GrEffectStage from GrDrawState.
Upcoming changes will require GrDrawState to know things about the set of installed effects. Thus all setting of effects must go through a GrDrawState function (setEffect()). This change accomplishes that.
Review URL: https://codereview.appspot.com/7214045

git-svn-id: http://skia.googlecode.com/svn/trunk@7411 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-28 14:26:09 +00:00
mike@reedtribe.org
093455c116 add missing parameter to overridden onFindClickHandler
git-svn-id: http://skia.googlecode.com/svn/trunk@7410 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-28 02:21:27 +00:00
rmistry@google.com
27b6899b6a Rebaselined webpage image GMs for ['base-shuttle_ubuntu12_ati5770'] on Google Storage.
git-svn-id: http://skia.googlecode.com/svn/trunk@7409 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-27 17:17:19 +00:00
rmistry@google.com
42b8870069 Rebaselined webpage image GMs for ['base-shuttle_ubuntu12_ati5770'] on Google Storage.
git-svn-id: http://skia.googlecode.com/svn/trunk@7408 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-27 00:10:39 +00:00
rmistry@google.com
cc08c41aed Rebaselined webpage image GMs for ['base-shuttle-win7-intel-float'] on Google Storage.
git-svn-id: http://skia.googlecode.com/svn/trunk@7407 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-26 17:51:52 +00:00
skia.committer@gmail.com
e16efc1882 Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@7406 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-26 07:06:02 +00:00
rmistry@google.com
4899712109 Test for (SkipBuildbotRuns) II
git-svn-id: http://skia.googlecode.com/svn/trunk@7405 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-25 22:06:14 +00:00
rmistry@google.com
37eccd72c7 Test for (SkipBuildbotRuns)
git-svn-id: http://skia.googlecode.com/svn/trunk@7404 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-25 21:41:12 +00:00
borenet@google.com
a5d621f2ce Manually parse arguments in submit_try
Argparse not supported with Python < 2.7.
Review URL: https://codereview.appspot.com/7206054

git-svn-id: http://skia.googlecode.com/svn/trunk@7403 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-25 20:55:35 +00:00
rmistry@google.com
ae6cb737dd Whitespace change to test (SkipBuildbotRuns)
git-svn-id: http://skia.googlecode.com/svn/trunk@7402 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-25 20:25:30 +00:00
vandebo@chromium.org
4e1cc6ac45 [PDF] Handle invalid glyph IDs on drawText methods.
Review URL: https://codereview.appspot.com/7179053

git-svn-id: http://skia.googlecode.com/svn/trunk@7401 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-25 19:27:23 +00:00
bsalomon@google.com
6d5d08f14f Fix nextRangeU(0, MAX_UINT) div by zero.
R=reed@google.com
Review URL: https://codereview.appspot.com/7201058

git-svn-id: http://skia.googlecode.com/svn/trunk@7400 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-25 19:19:20 +00:00
rmistry@google.com
713276b143 Presubmit should check that source files end in atleast one newline
Review URL: https://codereview.appspot.com/7193063

git-svn-id: http://skia.googlecode.com/svn/trunk@7399 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-25 18:27:34 +00:00
rmistry@google.com
647ca8bc89 Leave one and only one newline at the end of source files
Review URL: https://codereview.appspot.com/7216043

git-svn-id: http://skia.googlecode.com/svn/trunk@7398 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-25 18:26:58 +00:00
bungeman@google.com
bbec4e6be2 Avoid O(n) stack space usage in qsort.
git-svn-id: http://skia.googlecode.com/svn/trunk@7397 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-25 18:25:17 +00:00
reed@google.com
a53dcce4b4 reduce array size in debug builds for sortbench. This avoids a stack-overflow
due to (1) SkTQSort's bad behavior on repeated-keys, and (2) windows-debug doesn't
implement tail-recursion.

Not an issue, since we don't care about perf in our debug builds anyway.



git-svn-id: http://skia.googlecode.com/svn/trunk@7396 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-25 17:49:49 +00:00
bsalomon@google.com
3bc7200240 Move random from core to utils
Review URL: https://codereview.appspot.com/7193064

git-svn-id: http://skia.googlecode.com/svn/trunk@7395 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-25 17:49:03 +00:00
rmistry@google.com
6548cecb43 Whitespace change to test (SkipBuildbotRuns) locally
git-svn-id: http://skia.googlecode.com/svn/trunk@7394 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-25 15:28:23 +00:00
bsalomon@google.com
32cf29eed5 Only clear the part of the texture used by the device (duh!)
R=robertphillips@google.com
Review URL: https://codereview.appspot.com/7205055

git-svn-id: http://skia.googlecode.com/svn/trunk@7393 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-25 15:03:18 +00:00
reed@google.com
70375529cc doh: use *srcPtr instead of src (which is now obsolete) when we check for specialLine
git-svn-id: http://skia.googlecode.com/svn/trunk@7392 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-25 14:52:11 +00:00
robertphillips@google.com
d760073266 Hid large dashed line optimization behind compiler flag
https://codereview.appspot.com/7133078/



git-svn-id: http://skia.googlecode.com/svn/trunk@7391 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-25 14:47:48 +00:00
rmistry@google.com
ae97795901 Whitespace change to trigger rebuilds
git-svn-id: http://skia.googlecode.com/svn/trunk@7390 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-25 13:30:20 +00:00
rmistry@google.com
5170db22cd Whitespace change to trigger rebuilds
git-svn-id: http://skia.googlecode.com/svn/trunk@7388 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-25 13:09:15 +00:00
rmistry@google.com
9272086dbe Triggering rebuilds after r7386
git-svn-id: http://skia.googlecode.com/svn/trunk@7387 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-25 12:16:34 +00:00
skia.committer@gmail.com
4024f32d99 Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@7385 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-25 07:06:46 +00:00
rmistry@google.com
e8625ac205 Rebaselined webpage image GMs for ['base-shuttle-win7-intel-float'] on Google Storage.
git-svn-id: http://skia.googlecode.com/svn/trunk@7384 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-25 04:54:41 +00:00
bungeman@google.com
82c2fec824 Remove ConcaveToTriangles.
git-svn-id: http://skia.googlecode.com/svn/trunk@7383 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-24 22:31:01 +00:00
bungeman@google.com
59ed91079c Bottom-up heapsort.
https://codereview.appspot.com/7199050/


git-svn-id: http://skia.googlecode.com/svn/trunk@7382 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-24 22:18:56 +00:00
reed@google.com
58c0aaaf1b fix missing-case-statement warning
git-svn-id: http://skia.googlecode.com/svn/trunk@7381 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-24 22:09:06 +00:00
caryclark@google.com
9f60291c53 shape ops work in progress
first 100,000 random cubic/cubic intersections working

git-svn-id: http://skia.googlecode.com/svn/trunk@7380 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-24 21:47:16 +00:00
borenet@google.com
6c55b513bf Modify submit_try to work on windows
Review URL: https://codereview.appspot.com/7199053

git-svn-id: http://skia.googlecode.com/svn/trunk@7379 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-24 21:38:51 +00:00
reed@google.com
4bbdeac58c add optional cull-rect to patheffects, so they can do less work if their results
lie outside of the current clip-bounds (the cull rect).
Review URL: https://codereview.appspot.com/7206044

git-svn-id: http://skia.googlecode.com/svn/trunk@7378 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-24 21:03:11 +00:00
bsalomon@google.com
82502e2e39 Fix SampleApp ANGLE mode.
Review URL: https://codereview.appspot.com/7206052

git-svn-id: http://skia.googlecode.com/svn/trunk@7377 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-24 20:47:18 +00:00
bsalomon@google.com
c5fae9e1ed Fix spelling error.
git-svn-id: http://skia.googlecode.com/svn/trunk@7376 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-24 19:00:02 +00:00