AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
17,088 Commits 1 Branch 0 Tags 544 MiB
d96fd0c073
Commit Graph

17088 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
tfarina
d96fd0c073 Update {virtual,override} to follow C++11 style in src/pipe. 
The Google style guide states that only one of {virtual,override,final}
should be used for each declaration, since override implies virtual and
final implies both virtual and override.

The entries were found using the following command line:

$ find src/pipe -iname "*.h" -or -iname "*.cpp" | xargs pcregrep -M
"[^\n/]+virtual\ [^;{]+\ [a-zA-Z0-9_]+\([^;{]+\ override[ \n]*[;{]"

The regex was a courtesy of nick@chromium.org

BUG=None
R=mtklein@google.com

Review URL: https://codereview.chromium.org/1104863003
 2015-04-24 13:12:44 -07:00
msarett
9d9725c892 Do not crash nanobench in debug mode 
Instead print an error message

BUG=skia:

Review URL: https://codereview.chromium.org/1102083002
 2015-04-24 11:41:55 -07:00
robertphillips
91df6c273a Fix some lingering typos 
Review URL: https://codereview.chromium.org/1101293003
 2015-04-24 11:10:51 -07:00
bsalomon
c9aec1ee9b Revert of Remove validation exceptions in GrGLInterface. These are all now set by Chromium. (patchset #1 id:1 of https://codereview.chromium.org/1100413003/) 
Reason for revert:
Crashing bots

Original issue's description:
> Remove validation exceptions in GrGLInterface. These are all now set by Chromium.
>
> Committed: https://skia.googlesource.com/skia/+/42d9f35a8daf7f24ba542ba3783ec46fd965ef2f

TBR=joshualitt@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1093323005
 2015-04-24 11:08:25 -07:00
joshualitt
9b8e79eca2 simple fix for preabandon valgrind error 
TBR=bsalomon@google.com
BUG=skia:

Review URL: https://codereview.chromium.org/1106663003
 2015-04-24 09:57:12 -07:00
caryclark
08bc8488fa fix multiple intersection logic 
When three or more curves intersect at the same point, ensure that
each curve records the intersections of the others. This fixes a
number of cubic tests.

TBR=reed@google.com
BUG=skia:3588

Review URL: https://codereview.chromium.org/1105943002
 2015-04-24 09:08:57 -07:00
joshualitt
e062db9cc6 fix for using too much memory in GrBatchAtlas 
BUG=skia:

Review URL: https://codereview.chromium.org/1105913002
 2015-04-24 08:33:21 -07:00
bsalomon
42d9f35a8d Remove validation exceptions in GrGLInterface. These are all now set by Chromium. 
Review URL: https://codereview.chromium.org/1100413003
 2015-04-24 07:38:43 -07:00
rmistry
aa31ee78ee Add ability to specify extra browser args and a prefix for SKP names to webpages_playback.py 
BUG=skia:3763
NOTRY=true

Review URL: https://codereview.chromium.org/1066933006
 2015-04-23 12:47:33 -07:00
borenet
e1d7e0f0a5 Blacklist desk_unicodetable SKP on Nexus Player 
It's getting us killed for OOM.

BUG=skia:3240

Review URL: https://codereview.chromium.org/1104693002
 2015-04-23 12:44:31 -07:00
bsalomon
92888e71e0 Remove validation of blend barrier until Chrome can provide this function 
BUG=chromium:480534
TBR=egdaniel@google.com

Review URL: https://codereview.chromium.org/1101143002
 2015-04-23 12:25:51 -07:00
reed
3d9005c028 add GM to show bad banding in raster for radial gradients 
BUG=427508
TBR=

Review URL: https://codereview.chromium.org/1061753009
 2015-04-23 10:30:27 -07:00
cdalton
f4f2b44222 Add onGetBlendInfo to GrXferProcessor 
Adds an onGetBlendInfo method for GrXferProcessor subclasses to
override instead of overriding getBlendInfo directly. This gives the
base class a chance to initialize the struct with default values
before passing it on. As the BlendInfo struct grows, this will keep
things simple and less error prone.

BUG=skia:
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1049143002
 2015-04-23 09:40:23 -07:00
caryclark
03b03cad01 working on initial winding for cubics 
Path ops works well for all tests except for cubics.
Isolate failures caused by cubics, and do a better job of computing
the initial winding for cubics.

TBR=reed@google.com
BUG=skia:3588

Review URL: https://codereview.chromium.org/1096923003
 2015-04-23 09:13:37 -07:00
msarett
4b17fa353e Ensure that we create a NULL codec for images with zero dimensions 
BUG=skia:3534
BUG=skia:3257

Review URL: https://codereview.chromium.org/1091043003
 2015-04-23 08:53:39 -07:00
joshualitt
4314e08868 small fix for perf regression in GrAtlasTextContext.cpp 
BUG=skia:

Review URL: https://codereview.chromium.org/1080673005
 2015-04-23 08:03:35 -07:00
mtklein
743be194ed use acquire/release in SkEventTracer.cpp 
BUG=chromium:437044

Review URL: https://codereview.chromium.org/1091283006
 2015-04-22 20:30:12 -07:00
joshualitt
473ffa179a Remove unnecessary viewmatrix compare in GrAtlasTextContext 
BUG=skia:

Review URL: https://codereview.chromium.org/1088903009
 2015-04-22 18:23:16 -07:00
reed
8f76cb905a new GM to test clipping cubics 
BUG=skia:3716
TBR=caryclark@google.com

Review URL: https://codereview.chromium.org/1096433009
 2015-04-22 17:38:23 -07:00
fmalita
632e92fc3f [SkPDFDevice] Enable pathops-based inverse fills 
Keeping the old compile guard for clipping only.

BUG=skia:3749
R=halcanary@google.com,caryclark@google.com,reed@google.com

Review URL: https://codereview.chromium.org/1099953002
 2015-04-22 15:02:04 -07:00
senorblanco
31d36b0871 Remove MSAA check from Ganesh veto (dashed paths are no longer slow). 
R=egdaniel@google.com
BUG=skia:

Review URL: https://codereview.chromium.org/1098753004
 2015-04-22 14:33:35 -07:00
egdaniel
cf614fd48e Move function to be static instead of anonymous namespace 
TBR=bsalomon@google.com, jvanverth@google.com

BUG=skia:

Review URL: https://codereview.chromium.org/1057363004
 2015-04-22 13:58:58 -07:00
joshualitt
97202d2821 Fix for segfault on destruction of BitmapTextBlob 
BUG=skia:

Review URL: https://codereview.chromium.org/1065773005
 2015-04-22 13:47:02 -07:00
senorblanco
2b4bb07492 Improve the curve tessellation subdivision of the path renderers. 
The stencil-and-cover and tessellating path renderers currently
tessellate curves to linear segments to within one screen space pixel.
This is fairly poor accuracy, as can be seen from the strokecircle GM:
there are noticeable rotating bumps on the circles.

Improving the tolerance to 0.25 pixel eliminates the bumps, and
approximates the 16x supersampling of the raster path.
This does have a performance hit: 3-6% on desktop on
the IE chalkboard demo, ~1% on Nexus 7 2013.

Note: this will require rebaselining a number of GPU and  MSAA images
in Skia, but nothing in Chrome (yet).

BUG=skia:3731

Review URL: https://codereview.chromium.org/1072273007
 2015-04-22 13:45:18 -07:00
egdaniel
b0e1be207f Refactor createTexture and onCreateTexture 
BUG=skia:

Review URL: https://codereview.chromium.org/1102663002
 2015-04-22 13:27:40 -07:00
joshualitt
b30938ba7f Revert of enable TextBlob / Batch (patchset #1 id:1 of https://codereview.chromium.org/1077813004/) 
Reason for revert:
seg fault

Original issue's description:
> enable TextBlob / Batch
>
> TBR=bsalomon@google.com
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/b75f8100ace48e74319ccf43d82deaac446784b2

TBR=bsalomon@google.com,joshualitt@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1096433007
 2015-04-22 11:38:58 -07:00
bsalomon
c6534a28a6 Make pixel_snap GMs incur less platform-specific variation 
Review URL: https://codereview.chromium.org/1080393009
 2015-04-22 11:34:46 -07:00
joshualitt
12c20e40a4 Fix for GrAtlasTextContext memory leak 
BUG=skia:

Review URL: https://codereview.chromium.org/1072193009
 2015-04-22 11:24:20 -07:00
rmistry
8892277d0b Rewrite and move Cluster Telemetry documentation to skia.org 
BUG=skia:3754
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1074943003

Review URL: https://codereview.chromium.org/1074943003
 2015-04-22 11:03:12 -07:00
cdalton
bae6f6c3ec Add tokens and entry points for KHR_blend_equation_advanced 
Also adds glBlendEquation, which the extension interacts with, to the
core of GrGLInterface. Validation of this function is temporarily
disabled until Chrome hooks it up.

BUG=skia:

Review URL: https://codereview.chromium.org/1039693004
 2015-04-22 10:39:03 -07:00
bsalomon
87cbcf3f86 Add GM to test non-AA pixel snapping for points, lines, rects. 
Review URL: https://codereview.chromium.org/1070213003
 2015-04-22 08:51:38 -07:00
joshualitt
b75f8100ac enable TextBlob / Batch 
TBR=bsalomon@google.com
BUG=skia:

Review URL: https://codereview.chromium.org/1077813004
 2015-04-22 05:19:54 -07:00
mtklein
98b8485a4c O(1) SkPictureUtils::ApproxBytesUsed() 
Chrome wants to call this more often, and it's quite slow today.

Seems like this could be clearer if SkPictureUtils::ApproxBytesUsed() were SkPicture::approxBytesUsed().

BUG=chromium:471873

Review URL: https://codereview.chromium.org/1090943004
 2015-04-21 15:24:00 -07:00
mtklein
5ae0e2b563 Default to arm_v7_neon. 
This aliases all devices we know have NEON over to that too.

BUG=skia:

Review URL: https://codereview.chromium.org/1095953007
 2015-04-21 14:25:34 -07:00
tomhudson
2575f317d3 Revert of Add tokens and entry points for KHR_blend_equation_advanced (patchset #3 id:40001 of https://codereview.chromium.org/1039693004/) 
Reason for revert:
We're getting repeated crashes since this CL landed when we try to evaluate a roll into Chrome on our bots. (https://uberchromegw.corp.google.com/i/client.skia/builders/Linux%20Tests/builds/1902)

Our initial reflex is to put a #if 0 around this code (just like the immediately following lines 334-338 in GrGLInterface.cpp), but the error isn't what the GPU team expected to see if that was all we needed, so we're reverting now and asking you to resubmit tomorrow after running more thorough tests.

Original issue's description:
> Add tokens and entry points for KHR_blend_equation_advanced
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/8e578859f80b46a63144add215955221017d3609

TBR=markkilgard@gmail.com,bsalomon@google.com,cdalton@nvidia.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1101593002
 2015-04-21 14:16:53 -07:00
joshualitt
a7c6389ebf fix some small bugs with GrAtlasTextContext 
BUG=skia:

Review URL: https://codereview.chromium.org/1098093003
 2015-04-21 13:24:37 -07:00
cdalton
8e578859f8 Add tokens and entry points for KHR_blend_equation_advanced 
BUG=skia:

Review URL: https://codereview.chromium.org/1039693004
 2015-04-21 12:34:09 -07:00
mtklein
d8afd50b5a Android's Clang toolchain can't assemble the JPEG's .S files. 
Only affecting Build-Mac10.8-Clang-Arm7-Debug-Android.

BUG=skia:

Review URL: https://codereview.chromium.org/1093423003
 2015-04-21 12:07:38 -07:00
cdalton
fd4167ddf1 Import glTextureBarrier 
BUG=skia:

Review URL: https://codereview.chromium.org/1090163002
 2015-04-21 11:45:56 -07:00
mtklein
d557462f1f Skip msaa4 on Tegra 2 and 3. 
This will fix the N7 and Xoom bots.

TBR=borenet@google.com

BUG=skia:

Review URL: https://codereview.chromium.org/1099943002
 2015-04-21 11:25:47 -07:00
senorblanco
42a2c1d231 Revert "One more ASAN fix." 
This reverts commit 409fd66a5a.

We don't expect to pass this test until the ASAN bots are
correctly configured, and can run GPU tests.

BUG=skia:
TBR=robertphillips@google.com

Review URL: https://codereview.chromium.org/1080393003
 2015-04-21 11:13:17 -07:00
mtklein
05641a5582 DM: failure to canary a sink is now fatal. 
This requires we remove NVPR from the default set of configs, as we only find
out at runtime that it's not available.  All the other defaults will either be
compiled in and supported, or not compiled in and non-fatally skipped as
unknown configs.

BUG=skia:

Review URL: https://codereview.chromium.org/1100773003
 2015-04-21 10:49:14 -07:00
mtklein
fca5c88873 Ask for NVPR only when we expect it to be available. 
BUG=skia:

Review URL: https://codereview.chromium.org/1099023003
 2015-04-21 10:34:47 -07:00
Greg Humphreys
1bdc9351ec typo in sherrifing docs 
BUG=skia:
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1097353002

Review URL: https://codereview.chromium.org/1097353002
 2015-04-21 10:28:44 -07:00
tomhudson
d7c677104a Support HWUI rename of DisplayListRenderer 
R=djsollen@google.com,ccraik@google.com

Review URL: https://codereview.chromium.org/1086083004
 2015-04-21 10:09:07 -07:00
joshualitt
010db5346e Some simple optimizations for improving GrAtlasTextContext perf 
BUG=skia:

Review URL: https://codereview.chromium.org/1093083003
 2015-04-21 10:07:26 -07:00
senorblanco
409fd66a5a One more ASAN fix. 
Don't fail the GL validation check if the GL context fails to create.

TBR=robertphillips@google.com
BUG=skia:

Review URL: https://codereview.chromium.org/1096113003
 2015-04-21 09:43:08 -07:00
joshualitt
64c99cc90e Add support for rotating / scaling / translating gpu cached distance field textblobs 
BUG=skia:

Review URL: https://codereview.chromium.org/1092283002
 2015-04-21 09:43:03 -07:00
mtklein
59bcfaed66 Split default and user-supplied event tracers. 
Chrome's got a test scenario where setting the user-supplied tracer is racing with a concurrent use of the default tracer.

BUG=chromium:437044

No public API changes.
TBR=reed@google.com

Review URL: https://codereview.chromium.org/1099123002
 2015-04-21 09:38:03 -07:00
joshualitt
ae32c102e7 Store pointers to GrGlyph directly in BitmapTextBlob. This patch improves performance by avoiding hashmap lookups under normal use 
BUG=skia:

Review URL: https://codereview.chromium.org/1087203004
 2015-04-21 09:37:57 -07:00