Bug: skia:7562
Change-Id: I56e0991999644c02890008123b25f141aed0b70e
Reviewed-on: https://skia-review.googlesource.com/107520
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Change-Id: Ib637360e2f09cd2851771595590203da6195a314
Reviewed-on: https://skia-review.googlesource.com/107600
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Change-Id: Icc3f3cc144d6d3d2ee467822436df94559d6ff37
Reviewed-on: https://skia-review.googlesource.com/107580
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
This reverts commit e1c2945b5f.
Reason for revert: no crashes since
Original change's description:
> serialize NexusPlayer bots
>
> Temporarily serialize the NexusPlayer Test bots to help diagnose
> skia:7614.
>
> Bug: skia:7614
>
> Change-Id: I190327070f27e53d8344820f2215bad00f12e1ab
> Reviewed-on: https://skia-review.googlesource.com/106621
> Reviewed-by: Mike Klein <mtklein@chromium.org>
> Commit-Queue: Mike Klein <mtklein@chromium.org>
TBR=mtklein@chromium.org,caryclark@google.com
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: skia:7614
Change-Id: I1c7508c3f9a171d14cad1b77506d98772ef4ef60
Reviewed-on: https://skia-review.googlesource.com/107620
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
These cuts reduce the number of files by 2/3 and the size by 1/3
There's not too much more that could be trimmed - now the size
is dominated by the specially compiled LLVM/Clang binaries
Bug: skia:7186
Change-Id: Ie88fb6f2277eafbefac0f676daaca809dcb53f62
Reviewed-on: https://skia-review.googlesource.com/107061
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Previously, we needed vulkan-1.dll from the Vulkan runtime because some
drivers did not include the Vulkan loader. Now, all drivers include this
DLL and using the version from assets causes problems for newer Intel
drivers.
Bug: skia:7490
Change-Id: I7bd37fb0d2c88a4753f354ab2bc88761562ced2f
Reviewed-on: https://skia-review.googlesource.com/107060
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
I will use this in skcms-Win bots.
Change-Id: Id2e253a73e562181649f17908e5d587cc0d098d6
Reviewed-on: https://skia-review.googlesource.com/106973
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Bug: skia:
Change-Id: I55bb57a7f199d0f57531523f1fedfec2bf49502c
Reviewed-on: https://skia-review.googlesource.com/106802
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Stephan Altmueller <stephana@google.com>
This is a hack to get around the fact that we can't update the normal
version of depot_tools we receive through recipe deps, since we are not
yet using kitchen (See skia:7050).
Bug: skia:7609
Change-Id: I7d39e1e5db716960b2df2c8e3d4325c4b20c774e
Reviewed-on: https://skia-review.googlesource.com/106720
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
Temporarily serialize the NexusPlayer Test bots to help diagnose
skia:7614.
Bug: skia:7614
Change-Id: I190327070f27e53d8344820f2215bad00f12e1ab
Reviewed-on: https://skia-review.googlesource.com/106621
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
No-Try: true
Change-Id: Ia55bb4bf1e4de5167ed181f4dfcde9210e7a447c
Reviewed-on: https://skia-review.googlesource.com/106024
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Bug: skia:7586
Change-Id: If52cefadc657fa93d90fe11b08e3efc5aeacb634
Reviewed-on: https://skia-review.googlesource.com/105767
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
Having removed the NVPR text renderer, the nvprdit* configs are no longer interesting/useful.
Change-Id: Ic4b9d6507d3e3595723a27636cb58b5e811fb3a3
Reviewed-on: https://skia-review.googlesource.com/105563
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
They've been sufficiently fast for the last few days.
NOTRY=true
Bug: skia:
Change-Id: Id5df2e23bc3fd39526301432bcd625c3dca47367
Reviewed-on: https://skia-review.googlesource.com/104260
Reviewed-by: Ravi Mistry <rmistry@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Noticed this when trybots were not using changes to
trigger_wait_ac_task.py
NoTry: true
Bug: skia:7469
Change-Id: Ifac964e247bfd6862fa030fbf5176f179ef7f3c4
Reviewed-on: https://skia-review.googlesource.com/103521
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
- allows to choose api versions in run_testlab.go
- adds api_version and work_arounds to generate_gn_args
Bug: skia:
Change-Id: I87516b493f4d8eef3689d1722a5dd864131a44f8
Reviewed-on: https://skia-review.googlesource.com/102900
Reviewed-by: Derek Sollenberger <djsollen@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Stephan Altmueller <stephana@google.com>
Bug: skia:
NOTRY=true
Change-Id: Ia5e7e844af57ff06fc0e5a4139cf6c62b60a19ef
Reviewed-on: https://skia-review.googlesource.com/102423
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Bug: skia:7469
Change-Id: I4a570a92d266d86fca20c9394c8d446df3c41e9b
Reviewed-on: https://skia-review.googlesource.com/102600
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
It will be called from a new recipe.
This script follows the same pattern that the trigger_wait_ct_task.py used to
(https://codereview.chromium.org/1370523002).
NoTry: true
Bug: skia:7469
Change-Id: I450e415b004e7f481ca1b377d350eb64e5fa8250
Reviewed-on: https://skia-review.googlesource.com/102340
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Here's the current error:
==6835==WARNING: AddressSanitizer failed to allocate 0xc0000028 bytes
==6835==AddressSanitizer's allocator is terminating the process instead of returning 0
==6835==If you don't like this behavior set allocator_may_return_null=1
==6835==AddressSanitizer CHECK failed: external/compiler-rt/lib/sanitizer_common/sanitizer_allocator.cc:221 "((0)) != (0)" (0x0, 0x0)
Looking at how sk_malloc and co all funnel into sk_malloc_flags(), and
how our local sk_malloc_flags() works, I think everything would be fine
to run this bot with allocator_may_return_null=1, but I'm not sure how
to do that.
Change-Id: I155439e17dd6353b82056de12f49de34e9538643
Reviewed-on: https://skia-review.googlesource.com/101660
Reviewed-by: Leon Scroggins <scroggo@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Change-Id: I8154b9a0b2fcf76fa02af0efa6b57425c6f9ac31
Reviewed-on: https://skia-review.googlesource.com/101580
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Our 32-bit "arm" builds can run just fine on most ARMv8 devices. This
mode of operation is called "aarch32", as opposed to the usual mode
we're used to thinking about of running 64-bit "arm64" binaries,
"aarch64".
(Unimportant side note: there are ARMv8 chips that support only
aarch64... I think e.g. the iPhone X's CPU? There are also ARMv8 chips
that support only aarch32, rare and usually for tiny embedded things
like a watch. All the devices we test with support both aarch64 and
aarch32.)
(Technically what we call "arm" is more properly "T32" for Thumb2 32,
and "arm64" is "A64" for... ARM 64. This note is even less important
than the previous one.)
Android ships 64-bit Skia on devices that support it, but Chrome still
clings to 32-bit. So I thought it'd make sense for us to run some of
these Chrome-like builds too. I wasn't sure which ones, so I just went
nuts and mirrored all the Nexus5x bots. If you notice bots that seem
under your purview and you really don't care about how Chrome would work
in that mode, please mark them in the code review and I'll drop them.
Change-Id: I3e67070c669f5c459f4c0f5f46a68529a8eb9afc
Reviewed-on: https://skia-review.googlesource.com/101545
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
ViaSingletonPictures simulates a load pattern that Blink no longer produces.
I don't even remember what Via2ndPic and ViaTwice are meant to test,
but I imagine they're quite obsolete.
There was a lingering reference to ViaMojo, which otherwise doesn't exist.
Bug: skia:7544
Change-Id: I033fd344314054ad66c363e5dbd0a373be188069
Reviewed-on: https://skia-review.googlesource.com/88780
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Bug: skia:6687
Change-Id: I1562d7e9ded7f1be8a7ddc0c2341e54d5abbc0ae
Reviewed-on: https://skia-review.googlesource.com/97901
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
I think the Chorizo is now enforcing that our aligned loads are really
aligned. If this sticks, I'll follow up with the rest of the tests
disabled on the bug.
Bug: skia:7497
Change-Id: Id392e20ead395474f716a2c32d2643c801e03a2e
Reviewed-on: https://skia-review.googlesource.com/97202
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Bug: skia:
Change-Id: I79bdb1ff137c488ef5d4998ffc0cc9cdc28ae9fb
Reviewed-on: https://skia-review.googlesource.com/97240
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
