Commit Graph

13442 Commits

Author SHA1 Message Date
humper
27ff227589 make the action buttons for rebaseline server stick to the top of the window as you scroll
NOTRY=true

BUG=skia:1912
R=stephana@google.com, epoger@google.com

Author: humper@google.com

Review URL: https://codereview.chromium.org/446933002
2014-08-06 12:39:59 -07:00
krajcevski
683206a693 Revert of Initial ASTC decoder -- currently only supports 2D LDR decomrpession modes. (https://codereview.chromium.org/444433002/)
Reason for revert:
Breaking chrome.

Original issue's description:
> Initial ASTC decoder -- currently only supports 2D LDR decomrpession modes.
>
> Committed: https://skia.googlesource.com/skia/+/1840dcd2f1368279df907988a9b584ffd500de4c

R=robertphillips@google.com
TBR=robertphillips@google.com
NOTREECHECKS=true
NOTRY=true

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/444103002
2014-08-06 12:35:28 -07:00
krajcevski
1840dcd2f1 Initial ASTC decoder -- currently only supports 2D LDR decomrpession modes.
R=robertphillips@google.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/444433002
2014-08-06 12:02:52 -07:00
mtklein
3ba15ae3e1 SkPicture: try to no-op away clone().
Will actually enable this by #defining SK_PICTURE_CLONE_NOOP in Chrome's SkUserConfig.h as a separate CL after this rolls in.

BUG=skia:
R=reed@google.com, robertphillips@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/447753003
2014-08-06 11:57:00 -07:00
robertphillips
1289cfe176 Second pass at rebaselining flaky N4 performance triggers
R=bungeman@google.com
TBR=bungeman@google.com
NOTRY=true

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/444063002
2014-08-06 11:26:53 -07:00
bungeman
65fcd3de3c Implement SkFontMgr_Android::onMatchFamilyStyleCharacter.
This will allow us to replace SkGetFallbackFamilyNameForChar
and also eventually fix issues with it's reliance on names.

R=djsollen@google.com, tomhudson@google.com

Author: bungeman@google.com

Review URL: https://codereview.chromium.org/427293003
2014-08-06 11:12:20 -07:00
krajcevski
53f0959fc0 Allow custom blitters to be passed to SkDraw::drawPath
R=reed@google.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/444003004
2014-08-06 11:12:14 -07:00
halcanary
b6c8cc31dd Roll android/third_party/jpeg DEPS
BUG=skia:2791
R=djsollen@google.com
TBR=djsollen@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/449493004
2014-08-06 11:07:11 -07:00
egdaniel
776bdbde26 Create struct in GrDrawState to hold key DrawState data.
Eventually this struct will be used to easily set values for a reduced, optimized drawstate

BUG=skia:
R=bsalomon@google.com

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/448453002
2014-08-06 11:07:02 -07:00
djsollen
a6c27bc5bd Remove references to __system_property_get from Skia
BUG=392201
R=tomhudson@chromium.org, bungeman@google.com, tomhudson@google.com

Author: djsollen@google.com

Review URL: https://codereview.chromium.org/433163002
2014-08-06 11:01:58 -07:00
bsalomon
a098dd490c Fix drawVertices() on GPU when texs=colors=shaders=indices=null
R=reed@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/449433003
2014-08-06 11:01:44 -07:00
epoger
3facc7c87d rebaseline_server: add "prefetch" directive that just warms the cache without awaiting results
This will allow the buildbots to warn the production rebaseline_server: "I just
generated some new results; here's a comparison that a human might ask for
soon. Download whatever images and generate whatever diffs you would need to
provide those results."

BUG=skia:1942
NOTREECHECKS=true
NOTRY=true
R=rmistry@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/443013002
2014-08-06 10:56:51 -07:00
bsalomon
3b4d077fba Add angle config to nanobench and make angle a default config for dm and nanobench.
NOTREECHECKS=true
R=mtklein@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/441333003
2014-08-06 10:52:34 -07:00
mtklein
a7e930f640 On the bots, there's no need to link GMs into SampleApp.
We build SampleApp on the bots to make sure it's not broken, but we don't run it.  So, there's no need to link in all the GMs as samples.

This reduces the number of copies of our GMs from 4 to 3 (gm, dm, and nanobench remain).

NOTREECHECKS=true

BUG=skia:2142
R=bsalomon@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/447803002
2014-08-06 10:08:42 -07:00
reed
cdf2db90d9 parameterize tesselation params
TBR=
NOTREECHECKS=True

Author: reed@google.com

Review URL: https://codereview.chromium.org/446913002
2014-08-06 09:54:19 -07:00
mtklein
be21e3432e Bye bye bench.
NOTREECHECKS=true

BUG=skia:
R=djsollen@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/442343004
2014-08-06 08:39:38 -07:00
epoger
7909f47b42 rebaseline_server live queries: allow comparison against summary files within the Skia repo
This is a step towards providing SKP comparisons against expectations, not just
other actual results... we still need to allow the user to select
JSONKEY_EXPECTEDRESULTS vs JSONKEY_ACTUALRESULTS within the summary
files found.

BUG=skia:1942
NOTREECHECKS=true
NOTRY=true
R=rmistry@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/442203002
2014-08-06 08:37:53 -07:00
bungeman
760ba8d392 Revert "Adds a GrGLPathRendering class that wraps the NV_path_rendering"
This reverts commit 5672da0fa5.

This appears to be blocking the Skia roll by causing failures in the blink layout tests on the canvas-lost-gpu-context.html test.

The bisect for this can be seen at:

https://codereview.chromium.org/449473002/

Original issue's description:
> Adds a GrGLPathRendering class that wraps the NV_path_rendering
> extension and manages its various API versions. It also provides
> backup implementations when certain NVpr methods from later API
> versions are not present on the current system.
>
> Committed: https://skia.googlesource.com/skia/+/5672da0fa54f31c9727568e9dd5fe82c6e1585bc
2014-08-06 11:15:50 -04:00
bungeman
af13c7c50e Revert "Calculate rough approximations for nvpr path sizes"
This reverts commit 61bff70972.

This is built on 5672da0fa5
which is causing blink test failures on canvas-lost-gpu-context.html.
2014-08-06 11:14:31 -04:00
Robert Phillips
4297a51326 Add ASTC resource files
Review URL: https://codereview.chromium.org/442363003
2014-08-06 10:50:53 -04:00
mtklein
bcd278dfd2 DM: expand peak RAM usage to Mac and Android too.
BUG=skia:

NOTREECHECKS=true
R=halcanary@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/445963002
2014-08-06 07:46:30 -07:00
reed
147476da9e fix hittest in Patch sample
TBR=
BUG=skia:

Author: reed@google.com

Review URL: https://codereview.chromium.org/441373002
2014-08-06 07:00:27 -07:00
djsollen
1b27704eba Remove ALL font fallback logic from Skia.
R=reed@google.com, bungeman@google.com, caryclark@google.com

Author: djsollen@google.com

Review URL: https://codereview.chromium.org/434623002
2014-08-06 06:58:06 -07:00
mtklein
847092c88b SkThreadPool and co. are not public.
BUG=skia:
R=reed@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/444583006
2014-08-06 06:55:12 -07:00
borenet
70f25c1a3f Remove Mac 10.8 x86 Perf expectations
This is one of the problems with the way the RecreateSKPs bot determines which trybots to run: Rather than use a hard-coded list, it figures out which bots have perf expectations and then runs those bots to generate new expectations.  This is problematic when we remove a bot because we have to remove its expectations as well.  This is really not that different from maintaining a hard-coded list...

NOTRY=true
BUG=skia:
R=bensong@google.com, rmistry@google.com

Author: borenet@google.com

Review URL: https://codereview.chromium.org/443093002
2014-08-06 06:04:00 -07:00
robertphillips
753faf49ed Rebaseline flaky N4 & N7 performance triggers
R=bungeman@google.com
TBR=bungeman@google.com
NOTRY=true

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/440423002
2014-08-06 05:16:29 -07:00
senorblanco
a6d7b6ed6d Greenify bench bot Perf-Android-Nexus10-MaliT604-Arm7-Release at build 2563
R=bsalomon@google.com
TBR=bsalomon@google.com

Bypassing trybots:
NOTRY=true

Author: senorblanco@chromium.org

Review URL: https://codereview.chromium.org/442083003
2014-08-05 14:27:27 -07:00
senorblanco
858ba82bf5 Greenify bench bot Perf-Android-GalaxyNexus-SGX540-Arm7-Release at build 1811
R=bsalomon@google.com
TBR=bsalomon@google.com

Bypassing trybots:
NOTRY=true

Author: senorblanco@chromium.org

Review URL: https://codereview.chromium.org/443743002
2014-08-05 14:26:28 -07:00
krajcevski
40a1e11ebe Add support for all compressed formats in KTX file format
R=robertphillips@google.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/440783004
2014-08-05 14:13:36 -07:00
tomhudson
07544757c9 Parses sample code provided by Android project. Attempts to keep FontFamily data structures produced consistent with expectations of previous versions of Skia.
R=bungeman@google.com, djsollen@google.com, tomhudson@google.com

Author: tomhudson@chromium.org

Review URL: https://codereview.chromium.org/446473003
2014-08-05 13:35:02 -07:00
ch.dumez
43f9d3edf8 Expose SkColorTable class
Expose SkColorTable class as it is used in SkBitmap::allocPixels(SkColorTable*)
API, which is already exposed.

R=reed@google.com, ben@chromium.org

Author: ch.dumez@samsung.com

Review URL: https://codereview.chromium.org/418173011
2014-08-05 12:20:19 -07:00
senorblanco
888a250f4b Greenify bench bot Perf-Ubuntu12-ShuttleA-GTX660-x86-Release at build 1551
R=bensong@google.com, bensong@chromium.org

Bypassing trybots:
NOTRY=true
BUG=2794

Author: senorblanco@chromium.org

Review URL: https://codereview.chromium.org/442903002
2014-08-05 12:05:03 -07:00
tomhudson
816b4fb97c Fix bad gypi
Must not depend directly on ports; depend on skialib!

R=bungeman@google.com

Author: tomhudson@chromium.org

Review URL: https://codereview.chromium.org/442883002
2014-08-05 12:01:09 -07:00
cdalton
61bff70972 Calculate rough approximations for nvpr path sizes
Calculates a rough approximation of the actual value for gpuMemorySize
in GrGLPath and GrGLPathRange, instead of assuming every path is the
same fixed size.

BUG=skia:
R=bsalomon@google.com, markkilgard@gmail.com

Author: cdalton@nvidia.com

Review URL: https://codereview.chromium.org/442603002
2014-08-05 10:58:19 -07:00
epoger
0b7127635d teach rebaseline_server to generate diffs of rendered SKPs
Creates a new live-view.html page, served by the rebaseline_server, that will display diffs between two sets of rendered SKP images.

BUG=skia:1942
NOTRY=true
R=rmistry@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/424263005
2014-08-05 10:07:22 -07:00
bsalomon
8f72733994 Move functions from GrDrawState.h to GrDrawState.cpp and delete unused functions.
R=egdaniel@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/427713005
2014-08-05 07:50:08 -07:00
krajcevski
e90c900ed7 Add ETC1 format to SkTextureCompressor
R=robertphillips@google.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/432143002
2014-08-05 07:37:27 -07:00
bsalomon
72336ed7e1 Don't compare constant color and coverage between GrDrawStates when they are provided by vertex attributes.
R=egdaniel@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/439273007
2014-08-05 07:35:56 -07:00
mtklein
36ea6c81c2 For some reason, starting tests before gms makes DM run much faster.
Must be getting the path ops tests going early helps?

On my desktop,
Release: 50s -> 24s
Debug: 62s -> 40s

BUG=skia:
R=bsalomon@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/435423003
2014-08-05 07:19:46 -07:00
bsalomon
838f62db0a Replace op== with CombineIfPossible in GrDrawState.
R=egdaniel@google.com, robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/439853002
2014-08-05 07:15:57 -07:00
rmistry
7d4f40a9d1 Test new CQ bot
TBR=

(SkipBuildbotRuns)

BUG=skia:

Author: rmistry@google.com

Review URL: https://codereview.chromium.org/441833004
2014-08-05 06:55:14 -07:00
tomhudson
f79673bbae Test and generalize font configuration parser
Add a basic unit test for the Android font configuration parser.
Add a check for the new LMP file format; on detection, switch to a new
(as-yet unwritten) parser.

R=bungeman@google.com, djsollen@google.com, tomhudson@google.com

Author: tomhudson@chromium.org

Review URL: https://codereview.chromium.org/439813002
2014-08-05 06:36:14 -07:00
mtklein
8f961b373b Revert of whitespace change to force a build (https://codereview.chromium.org/432183002/)
Reason for revert:
force

Original issue's description:
> whitespace change to force a build
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/490d49c5dcc4b2242c9b25f082b23ec5e842c4e7

R=mtklein@chromium.org
TBR=mtklein@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/442603005
2014-08-05 03:51:04 -07:00
mtklein
4e212e8da7 Print max memory usage on Linux.
This is meant to help debug http://skbug.com/2793

BUG=skia:2793
R=halcanary@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/433403005
2014-08-04 14:10:19 -07:00
mtklein
2069e22003 Fix calibration loop failure condition.
With the old logic, if the last attempt succeeded, we'd say we failed.

We also print two lines for loop calibration failures.  Quiet that down.

BUG=skia:
R=djsollen@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/431503004
2014-08-04 13:57:39 -07:00
mtklein
8f394d4791 disable all warnings from nanomsg
They're annoying.

BUG=skia:
R=mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/437323002
2014-08-04 13:11:19 -07:00
egdaniel
6d7f5faeb3 Enable gpu Debug markers if tracing category skia.gpu is enabled
BUG=skia:
R=bsalomon@google.com

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/438023004
2014-08-04 12:54:39 -07:00
mtklein
ad82ed67df Force linking as C++ library.
BUG=skia:
R=bungeman@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/420183004
2014-08-04 12:51:20 -07:00
cdalton
5672da0fa5 Adds a GrGLPathRendering class that wraps the NV_path_rendering
extension and manages its various API versions. It also provides
backup implementations when certain NVpr methods from later API
versions are not present on the current system.

R=bsalomon@google.com, kkinnunen@nvidia.com, markkilgard@gmail.com

Author: cdalton@nvidia.com

Review URL: https://codereview.chromium.org/437473002
2014-08-04 11:19:11 -07:00
mtklein
bce540ca8f Don't call out -lstdc++ -lm explicitly.
BUG=skia:
R=bungeman@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/440643004
2014-08-04 11:10:16 -07:00