reed@google.com
e354397dd9
use SkIntToScalar(10) instead of 10 for parameters (for scalar==fixed)
...
git-svn-id: http://skia.googlecode.com/svn/trunk@3002 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-01-10 18:59:22 +00:00
reed@google.com
3e71a88762
add gm for reverseAddPath
...
git-svn-id: http://skia.googlecode.com/svn/trunk@3001 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-01-10 18:44:37 +00:00
djsollen@google.com
8688e5b7d1
Exclude BGRA readPixel tests on Android until bug 438 is resolved.
...
Review URL: http://codereview.appspot.com/5522053
git-svn-id: http://skia.googlecode.com/svn/trunk@2987 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-01-09 13:02:20 +00:00
mike@reedtribe.org
c52b1927c2
add unittest for sk_memset16 and sk_memset32
...
git-svn-id: http://skia.googlecode.com/svn/trunk@2985 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-01-07 03:49:13 +00:00
bsalomon@google.com
cadbcb8e53
Towards enabling -Werror in skia on Linux
...
Review URL: http://codereview.appspot.com/5516044/
git-svn-id: http://skia.googlecode.com/svn/trunk@2983 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-01-06 19:22:11 +00:00
schenney@chromium.org
6630d8d8ea
Add the ability to iterate through a path without modification. This change is
...
required by WebKit SVG in order to correctly draw markers and endcaps.
BUG=415
TEST=TestPath in the unit tests
Review URL: http://codereview.appspot.com/5505097
git-svn-id: http://skia.googlecode.com/svn/trunk@2962 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-01-04 21:05:51 +00:00
vandebo@chromium.org
9ad3599a3a
Fix ToUnicode generation bug.
...
Code from arthurhsu@chromium.org Original CL: http://codereview.appspot.com/5492061/
BUG=Chromium:104062
Review URL: http://codereview.appspot.com/5498064
git-svn-id: http://skia.googlecode.com/svn/trunk@2944 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-01-03 18:35:39 +00:00
reed@google.com
21e0bc2045
add move-close-move and move-close-move-close to the "empty" paths to test
...
git-svn-id: http://skia.googlecode.com/svn/trunk@2921 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-12-21 20:26:01 +00:00
reed@google.com
ee068aae55
add unittest for invariants for empty paths, still need to think about
...
hairlines in those cases
git-svn-id: http://skia.googlecode.com/svn/trunk@2919 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-12-21 19:36:21 +00:00
reed@google.com
419f43348a
add SkUnichar_IsVariationSelector()
...
git-svn-id: http://skia.googlecode.com/svn/trunk@2915 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-12-21 15:21:32 +00:00
schenney@chromium.org
6c31d9d9b4
Fixing PathTest. It was always broken in the convexity test code due
...
to a failure to correctly use SkScalar.
git-svn-id: http://skia.googlecode.com/svn/trunk@2904 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-12-20 16:33:30 +00:00
schenney@chromium.org
3287949868
Fixing the build for FIXED tests. PathTest was incorrect using "1" instead of "SK_Scalar1".
...
git-svn-id: http://skia.googlecode.com/svn/trunk@2902 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-12-20 15:33:11 +00:00
schenney@chromium.org
4da06ab335
Modifying SkPath to store all verbs provided by the user, and to give
...
correct results for all stroke and fill modes even on the various types
of degenerate paths.
The goals of this patch include:
1. Have Skia store all of the verbs implied by path construction methods, even
if those define degenerate paths. The SVG implementation in WebKit, which is
backed by Skia, needs to know about all elements of the path, even degenerate
ones, for the correct drawing of markers and line caps. For example, in SVG you
should be able to draw a scatter plot by specifying a marker for vertices and
then giving a sequence of moveTo commands. Skia will not store the moveTos,
requiring a different storage mechanism.
2. Assuming 1, maintain the current Skia behavior. That is, make Skia robust to
degenerate paths.
3. Fix an existing bug in Skia where a degenerate moveTo-lineTo pair spits out
warnings from rasterization and produces incorrect results in inverse-fill
renderings.
4. Adds extensive testing for degenerate paths and path rendering in general.
To meet these goals, the patch I am proposing will result in minor additional
storage for degenerate paths (a few bytes per degenerate path, only if the user
defines such paths). There is also some additional overhead in the iteration
code, with the path now cleaned to remove degenerate segments as part of the
iteration process. I suspect this will also fix issues with computing normal
vectors to degenerate segments. Benchmarking suggests that this change may
result in slightly (< 1%) slower path drawing due to the checks for
degeneracy. This overhead could be removed (in fact, a significant speedup
could occur) if the results of iterating to clean up the path were cached.
This would cost memory, of course, and quite a bit of it.
BUG=398
TEST=tests/PathTest.cpp
gm/cubicpaths.cpp
gm/degeneratesegments.cpp
gm/movepaths.cpp
gm/linepaths.cpp
gm/quadpaths.cpp
Review URL: http://codereview.appspot.com/5482051
git-svn-id: http://skia.googlecode.com/svn/trunk@2901 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-12-20 15:14:18 +00:00
reed@google.com
7c2029367c
add canvas::isDrawingToLayer(), as a fast query for chrome; faster than
...
setting up a drawiter and counting the layers.
git-svn-id: http://skia.googlecode.com/svn/trunk@2875 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-12-14 18:48:05 +00:00
junov@chromium.org
b6e161937b
Adding isOpaque method to skia shader classes
...
REVIEW=http://codereview.appspot.com/5451102/
TEST=unit test ShaderOpacity
git-svn-id: http://skia.googlecode.com/svn/trunk@2840 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-12-09 15:48:03 +00:00
reed@google.com
5ae777dcad
rename sk_float_isNaN to sk_float_isnan to match related functions
...
add sk_float_isinf returning non-zero if the argument is +/- infinity
git-svn-id: http://skia.googlecode.com/svn/trunk@2813 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-12-06 20:18:05 +00:00
reed@google.com
1607863b60
rename hasValidCoordinates to isFinite (on SkRect) and reimplement for speed
...
git-svn-id: http://skia.googlecode.com/svn/trunk@2811 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-12-06 18:56:37 +00:00
reed@google.com
61873a59d7
add sk_float_isfinite to mask platform differences
...
git-svn-id: http://skia.googlecode.com/svn/trunk@2803 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-12-05 21:47:25 +00:00
reed@google.com
d230e3e532
add test for isFinite
...
git-svn-id: http://skia.googlecode.com/svn/trunk@2800 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-12-05 20:49:37 +00:00
djsollen@google.com
b44cd65a53
Fix Paint == comparison on Android.
...
The == operator was incorrect because of Androids use of
fGenerationID. This change moves the ID to the end of the
paint struct and omits it from the == comparison.
Review URL: http://codereview.appspot.com/5437098
git-svn-id: http://skia.googlecode.com/svn/trunk@2780 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-12-01 17:09:21 +00:00
reed@google.com
37f3ae0b9f
add unittest for save/restore
...
git-svn-id: http://skia.googlecode.com/svn/trunk@2751 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-11-28 16:06:04 +00:00
reed@google.com
a052aca410
more rgn==aaclip tests
...
git-svn-id: http://skia.googlecode.com/svn/trunk@2744 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-11-23 19:43:46 +00:00
bsalomon@google.com
31648eb1cf
Fix warnings
...
Review URL: http://codereview.appspot.com/5433054/
git-svn-id: http://skia.googlecode.com/svn/trunk@2741 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-11-23 15:01:08 +00:00
mike@reedtribe.org
95b85bd1ba
add test that aaclip.setRegion creates the same mask as the region
...
... in prep for optimizatin work on setRegion.
git-svn-id: http://skia.googlecode.com/svn/trunk@2739 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-11-23 03:12:58 +00:00
reed@google.com
3d60812865
don't quickReject bitmaps if there is a looper or other possible bounds-modifier
...
add unittest for the above change
git-svn-id: http://skia.googlecode.com/svn/trunk@2722 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-11-21 15:16:16 +00:00
mike@reedtribe.org
3565f0fd25
add test for IsMode
...
git-svn-id: http://skia.googlecode.com/svn/trunk@2704 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-11-17 02:27:26 +00:00
reed@google.com
b03db4a366
fix signed/unsigned warning (use size_t in conjunction with SK_ARRAY_COUNT)
...
git-svn-id: http://skia.googlecode.com/svn/trunk@2702 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-11-16 21:36:27 +00:00
reed@google.com
3563c9ee52
fix autobounds dude to call a custom version of rect.join that doesn't ignore
...
empty rects (since path.bounds must be the bounds of its control-pts, including
empty subcontours)
git-svn-id: http://skia.googlecode.com/svn/trunk@2679 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-11-14 19:34:57 +00:00
bsalomon@google.com
1dcf506a1a
Remove GrGpuGLFixed subclass and ES1 support
...
Review URL: http://codereview.appspot.com/5376094/
git-svn-id: http://skia.googlecode.com/svn/trunk@2678 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-11-14 19:29:53 +00:00
reed@google.com
ffdb018dae
add test for bounds (disabled as it fails)
...
git-svn-id: http://skia.googlecode.com/svn/trunk@2677 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-11-14 19:29:14 +00:00
bsalomon@google.com
74b98715a3
Do writepixels alpha-premul using gpu
...
Review URL: http://codereview.appspot.com/5373064/
git-svn-id: http://skia.googlecode.com/svn/trunk@2668 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-11-11 19:46:16 +00:00
vandebo@chromium.org
beb7fe1869
[PDF] Optimize W-array generation with respect to subsetted fonts and add test.
...
Testing framework originally from http://codereview.appspot.com/4916044
Review URL: http://codereview.appspot.com/5379041
git-svn-id: http://skia.googlecode.com/svn/trunk@2667 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-11-11 19:38:54 +00:00
bsalomon@google.com
bbce8b29bd
Turn off WritePixelsTest in fixed pt build (GPU device known not to work, no plan to fix)
...
git-svn-id: http://skia.googlecode.com/svn/trunk@2663 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-11-10 21:20:37 +00:00
bsalomon@google.com
d58a1cd00b
Add config8888 support to writePixels
...
Review URL: http://codereview.appspot.com/5374052/
git-svn-id: http://skia.googlecode.com/svn/trunk@2662 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-11-10 20:57:43 +00:00
bsalomon@google.com
a2092aab4b
Fix return value in read pixels unit test
...
git-svn-id: http://skia.googlecode.com/svn/trunk@2656 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-11-10 15:10:24 +00:00
tomhudson@google.com
f74ad8c91a
Removes warnings generated by gcc and clang.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@2651 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-11-09 22:15:08 +00:00
reed@google.com
8d7e39c835
add experimental test for blending math (disabled for now)
...
git-svn-id: http://skia.googlecode.com/svn/trunk@2648 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-11-09 17:12:08 +00:00
bsalomon@google.com
c436499622
[GPU] Add explicit byte order and PM vs. UPM 8888 configs
...
Review URL: http://codereview.appspot.com/5347042/
git-svn-id: http://skia.googlecode.com/svn/trunk@2618 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-11-07 15:54:49 +00:00
bsalomon@google.com
6850eab42b
Override 32BPP format in SkCanvas::readPixels
...
Review URL: http://codereview.appspot.com/5330073/
git-svn-id: http://skia.googlecode.com/svn/trunk@2600 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-11-03 20:29:47 +00:00
bsalomon@google.com
c69809745e
Recommit r2584 with gpu pass of the new ReadPixels test disabled in fixed pt (gpu code doesn't work in general in fixed pt).
...
git-svn-id: http://skia.googlecode.com/svn/trunk@2586 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-11-02 19:57:21 +00:00
bsalomon@google.com
ace7bd5623
Revert r2584 (new test fails in fixed pt builds)
...
git-svn-id: http://skia.googlecode.com/svn/trunk@2585 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-11-02 19:39:51 +00:00
bsalomon@google.com
1a8ddf0a35
Changes the SkCanvas::readPixels API. Allows caller to read into prealloced bitmap pixels. Changes how clipping to device bounds is handled.
...
Review URL: http://codereview.appspot.com/5307077/
git-svn-id: http://skia.googlecode.com/svn/trunk@2584 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-11-02 19:34:16 +00:00
reed@google.com
ab77aafa8c
remove tests for copyPixelsFrom (it is not gone)
...
git-svn-id: http://skia.googlecode.com/svn/trunk@2580 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-11-01 16:03:35 +00:00
bsalomon@google.com
74913722bf
Add NULL GL context implementation. Use in bench (-nullgl) and SampleApp (backspace key)
...
Review URL: http://codereview.appspot.com/5303080/
git-svn-id: http://skia.googlecode.com/svn/trunk@2545 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-10-27 20:44:19 +00:00
reed@google.com
c904191995
now we trim the aaclip after building it, to ensure that it has tight bounds
...
around its (rle compressed) image.
git-svn-id: http://skia.googlecode.com/svn/trunk@2542 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-10-27 16:58:46 +00:00
tomhudson@google.com
83a444602e
Remove warnings (trailing \, signed vs unsigned, parenthesization).
...
Convert some tabs into spaces.
git-svn-id: http://skia.googlecode.com/svn/trunk@2541 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-10-27 15:27:51 +00:00
reed@google.com
d8676d2fd2
add test for rgn-ops. some disable for now as they don't work (yet)
...
git-svn-id: http://skia.googlecode.com/svn/trunk@2537 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-10-26 18:01:25 +00:00
reed@google.com
91d449ebf8
add header to document debug-vs-release, fixed-vs-float
...
git-svn-id: http://skia.googlecode.com/svn/trunk@2536 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-10-26 15:25:18 +00:00
reed@google.com
12e1525306
fix new test to work in fixed-point
...
git-svn-id: http://skia.googlecode.com/svn/trunk@2535 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-10-26 15:19:36 +00:00
reed@google.com
209c41511e
add initial unittests for aaclip. Fix case where BuilderBlitter skipped the top
...
few scanlines (of its bounds) and therefore didn't know to trim its bounds back
down. This can happen when the path's bounds are larger than the curve's bounds
(i.e. the control points are outside of the tight-bounds of the shape.)
git-svn-id: http://skia.googlecode.com/svn/trunk@2534 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-10-26 15:03:48 +00:00