Commit Graph

40933 Commits

Author SHA1 Message Date
recipe-roller
edf562397e Roll recipe dependencies (nontrivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


Please review the expectation changes, and LGTM+CQ.


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/80e1d4b24dded35128a888c2de959ccd0dd8d140 Remove step exit code from test expectations. (iannucci@chromium.org)
  https://crrev.com/5c579aefde72744956934c8805273cd43f53cd1d Move StepConfig and friends to their own module, engine_step. (iannucci@chromium.org)


R=kjlubick@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Idcb76229ca11e137b200f5712617008d34490d3a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/204286
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2019-03-28 13:15:52 +00:00
Daniel Bratell
78a282f49b Add an include guard to SkottieShaper.h
SkottieShaper.h was not protected against multiple inclusions in the
same translation unit.

Change-Id: Ie1f5acbcab82b9b1c37868739fb4322c471886cf
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/204421
Auto-Submit: bratell <bratell@opera.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2019-03-28 13:05:02 +00:00
skia-autoroll
e51181387f Roll third_party/externals/angle2 208af3ebda25..e810ad90799c (10 commits)
208af3ebda..e810ad9079


git log 208af3ebda25..e810ad90799c --date=short --no-merges --format='%ad %ae %s'
2019-03-28 syoussefi@chromium.org Vulkan: dump summary of commands in digraph
2019-03-28 syoussefi@chromium.org Vulkan: roll Vulkan repos to v1.1.102
2019-03-28 syoussefi@chromium.org Vulkan: remove dependency to inheritedQueries
2019-03-28 jie.a.chen@intel.com ParallelCompile: Enable worker on GL backend
2019-03-28 syoussefi@chromium.org Vulkan: Fix subpass declaration for depth/stencil-only FBOs
2019-03-28 syoussefi@chromium.org Vulkan: Correct RenderTargetVk extents to image mip
2019-03-28 tobine@google.com Vulkan:Refactor SecondaryCommandBuffers
2019-03-28 jdarpinian@chromium.org Sampler state overrides texture state if set
2019-03-28 jmadill@chromium.org Fix deleting a buffer not updating VAO validation.
2019-03-28 jonahr@google.com Remove EGLThreadTest to fix angle_end2end_tests failures on Android.


Created with:
  gclient setdep -r third_party/externals/angle2@e810ad90799c

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=stani@google.com

Change-Id: I2b12db558e4d042a60feed130140a02188999aa8
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/204407
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-03-28 10:51:32 +00:00
skia-autoroll
4ddc9c3a80 Roll third_party/externals/swiftshader 57e05b8be2d9..94f195b18776 (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/57e05b8be2d9..94f195b18776


git log 57e05b8be2d9..94f195b18776 --date=short --no-merges --format='%ad %ae %s'
2019-03-28 swiftshader.regress@gmail.com Regres: Update test lists @ 179c9324


Created with:
  gclient setdep -r third_party/externals/swiftshader@94f195b18776

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=stani@google.com

Change-Id: Ifa0b04e86077ac83ab38fe5c2307923a7ec99813
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/204404
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-03-28 09:34:02 +00:00
skia-recreate-skps
3240800a94 Update go_deps asset
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I3f319309e13a443b1bf8f217923ae29c6df4f979
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/204291
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2019-03-28 05:46:12 +00:00
skia-autoroll
0b19d73c4b Roll third_party/externals/swiftshader 179c932426b3..57e05b8be2d9 (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/179c932426b3..57e05b8be2d9


git log 179c932426b3..57e05b8be2d9 --date=short --no-merges --format='%ad %ae %s'
2019-03-28 chrisforbes@google.com Add support for OpMatrixTimesScalar


Created with:
  gclient setdep -r third_party/externals/swiftshader@57e05b8be2d9

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=stani@google.com

Change-Id: Ie303434da6321e94e54ae76487264f1ada3dd5cc
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/204386
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-03-28 05:44:21 +00:00
skia-autoroll
01a065884b Roll ../src 83d44af5c208..eb8d3bc0b607 (520 commits)
83d44af5c2..eb8d3bc0b6


Created with:
  gclient setdep -r ../src@eb8d3bc0b6

The AutoRoll server is located here: https://autoroll.skia.org/r/chromium-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Release-All-CommandBuffer;skia.primary:Test-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Debug-All-CommandBuffer
TBR=stani@google.com

Change-Id: Id26c85f821b41e7c2a096c76a1d80611adebbdba
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/204383
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-03-28 04:32:31 +00:00
skia-autoroll
e4c67058dd Roll third_party/externals/angle2 c240abe4ef2c..208af3ebda25 (3 commits)
c240abe4ef..208af3ebda


git log c240abe4ef2c..208af3ebda25 --date=short --no-merges --format='%ad %ae %s'
2019-03-27 timvp@google.com Update TexImage2D Parameter Checking
2019-03-27 jmadill@chromium.org Add suppressions for Mac dEQP [Part 2].
2019-03-27 jmadill@chromium.org Add suppressions for Mac dEQP. [Part 1]


Created with:
  gclient setdep -r third_party/externals/angle2@208af3ebda25

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=stani@google.com

Change-Id: Idd36328eca3be864b87083bf4c9cfbe42e68b8ed
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/204290
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-03-28 01:59:21 +00:00
skia-autoroll
8d2c19554e Roll third_party/externals/swiftshader 4c9f4a97ffe3..179c932426b3 (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/4c9f4a97ffe3..179c932426b3


git log 4c9f4a97ffe3..179c932426b3 --date=short --no-merges --format='%ad %ae %s'
2019-03-27 astrachan@google.com Handle NULL 'value' to eglGetSyncAttribKHR()


Created with:
  gclient setdep -r third_party/externals/swiftshader@179c932426b3

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=stani@google.com

Change-Id: I106efbc7b4bdbedf3857613929fa31688c7ffda4
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/204282
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-03-27 21:34:30 +00:00
Chris Dalton
0dffbab55a Add MSAA and non-aa modes to GrFillRRect Op
Adds a non-aa mode and an MSAA mode that uses the sample mask. Also
adds a new cap to decide whether we prefer this new sample mask Op for
large round rects, or whether it's faster to just continue drawing
them as paths like before.

Bug: skia:
Change-Id: Ic344ace26e7889c312c3040ad345b4d9a717f96d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/204135
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2019-03-27 21:25:20 +00:00
Greg Daniel
d0794cccd0 Add support for vsync on android viewer.
Bug: skia:
Change-Id: Idcb3e3b0a67c2da65c99c597686cb55961142a38
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/204263
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2019-03-27 20:57:01 +00:00
Mike Reed
a3bfb5de4b add bgra8 bgra8s and 8888s to explicitly control swizzle and srgb-ness in gpu[] configs
Bug: skia:
Change-Id: I2f029b334ce900c5c4844ddecd9d022f51a21334
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/202705
Reviewed-by: Brian Osman <brianosman@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2019-03-27 20:46:01 +00:00
Mike Klein
6253d90de8 add .svg sources to fm
Change-Id: Ic364059cb277773a5d5f8011be2b68b757e889f2
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/204280
Commit-Queue: Mike Klein <mtklein@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Auto-Submit: Mike Klein <mtklein@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2019-03-27 20:42:50 +00:00
Brian Osman
a7ef3a0fed Allow Mock GrBackendTextures to masquerade as GL
Change-Id: I13be29dfdc6d3750ca996ad3a03c75befceadc5f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/204221
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2019-03-27 20:27:50 +00:00
Mike Klein
c245bd9077 add --backend pdf to fm
Change-Id: I6ad822d606ecdf9a71a3626ebc3b19d524dbaf72
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/204138
Reviewed-by: Brian Osman <brianosman@google.com>
2019-03-27 20:08:57 +00:00
Greg Daniel
a8cee7afe1 Add vsync toggle for windows viewer.
Change-Id: I1a223c96fbffc24a3a9263304768c2d7946a7a9e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/204260
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2019-03-27 19:59:25 +00:00
Mike Klein
9b46209867 add --backend skp to fm
And move --backend first among the backend flags.

Change-Id: I853ede2a8218f046c968ace2ce8c5e277421e225
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/204133
Auto-Submit: Mike Klein <mtklein@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2019-03-27 19:55:28 +00:00
skia-autoroll
d72d4c6600 Roll third_party/externals/swiftshader e43cda5f76de..4c9f4a97ffe3 (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/e43cda5f76de..4c9f4a97ffe3


git log e43cda5f76de..4c9f4a97ffe3 --date=short --no-merges --format='%ad %ae %s'
2019-03-27 chrisforbes@google.com Remove asserts blocking pipeline derivatives


Created with:
  gclient setdep -r third_party/externals/swiftshader@4c9f4a97ffe3

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=stani@google.com

Change-Id: I708519637151ef88938a20beeb4c262347c96c2e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/204137
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-03-27 19:54:19 +00:00
Mike Klein
299ea7b860 buildifier public.bzl
Change-Id: I1f7ff758801be30e377d08684b15af22daafde66
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/204134
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2019-03-27 19:00:04 +00:00
Mike Klein
99ccc0ca87 lazy svg parsing in TestSVGTypeface
Do you know why the mutex was there around render() in the first place?

Change-Id: I3ff4bcf510c5f9a61fa002b7eff0eb3d47dc2f45
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/204128
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2019-03-27 17:27:18 +00:00
Mike Klein
7f95c293d7 split up skia_srcs() in public.bzl
This will let us smoothly switch over from using skia_srcs()
to using base_srcs() and gl_srcs(), listing things we need
from src/ports (and src/utils/mac/*.cpp) in BUILD instead.

Change-Id: I85dabd0dd620e1dcbcf4883ea8cfba3c111ce319
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/204126
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2019-03-27 17:23:48 +00:00
skia-autoroll
6eb72c1cbf Roll third_party/externals/angle2 518c679da109..c240abe4ef2c (1 commits)
518c679da1..c240abe4ef


git log 518c679da109..c240abe4ef2c --date=short --no-merges --format='%ad %ae %s'
2019-03-27 jmadill@chromium.org D3D11: Broaden suppression for atomic counter tests.


Created with:
  gclient setdep -r third_party/externals/angle2@c240abe4ef2c

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=stani@google.com

Change-Id: I87161c445bcc315a989a8a611ad5a62f8e0ad5e0
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/204180
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-03-27 17:07:58 +00:00
Brian Salomon
b68fc3d768 Disable texture storage on Android over command buffer.
I was unable to reproduce any of the regressions so just doing a blanket
disable on Android/command buffer.

Skia perf results show a mix of big perf wins and losses for Radeon GPUs,
particularly on ANGLE and even more so with ANGLE+msaa. Minor wins for other desktop GPUs.
Specifically on Android there was a mix of smaller wins and losses on NexusPlayer
as well as some big wins. Minor wins on NVIDIA Shield. No change in texture upload stats.

Bug: chromium:945506
Change-Id: Ief0d546d5bf6e6e10d7dfcceb2a0bbae82719467
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/204140
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2019-03-27 16:54:21 +00:00
Mike Klein
b61e25b766 update DM_SRCS to build tools/HashAndEncode
Change-Id: Iab2ea4dfbff466f96f3f54d5150e12a8eb673518
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/204125
Auto-Submit: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2019-03-27 16:25:58 +00:00
skia-autoroll
576eb87a2d Roll third_party/externals/swiftshader df5b28fdb45c..e43cda5f76de (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/df5b28fdb45c..e43cda5f76de


git log df5b28fdb45c..e43cda5f76de --date=short --no-merges --format='%ad %ae %s'
2019-03-27 capn@google.com Add GLES unit tests to Kokoro Windows CI


Created with:
  gclient setdep -r third_party/externals/swiftshader@e43cda5f76de

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=stani@google.com

Change-Id: I4c178182d7fd6dd70922e36266a6a2f80b2cb01c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/204121
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-03-27 14:11:58 +00:00
Michael Ludwig
cf677782eb Fix paint filter quality in draw_image_set GM
Outer SkPaint paint variable was shadowed by inner, so the
experimental_DrawEdgeAAImageSet calls always used nearest-neighbor
filtering.

Change-Id: I0a44ba9056c553c58559cf503d33df6b7f9e7019
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203803
Auto-Submit: Michael Ludwig <michaelludwig@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
2019-03-27 14:08:28 +00:00
Adrienne Walker
0f82797f37 Add a function to compute texture sizes
This lets memory traces agree on how big textures are.

Bug: chromium:944846
Change-Id: I5ea8cb5e1331b4ad8d6f59f656c6e61d44290489
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203727
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Auto-Submit: Adrienne Walker <enne@chromium.org>
2019-03-27 14:05:28 +00:00
Mike Klein
735c7ba320 FM, a dumber new testing tool
FM's a bit like DM, and a bit like the old GM tool, maybe closer to GM.

FM always does one serial run through of a list of GM, image, or .skp
sources (-s/--sources) into one drawing configuration, set at a high
level with -b/--backend, fine-tuned by flags like --ct, --at, --gamut,
--samples, etc.

FM prints all available GMs when run with no arguments, part of
how it integrates well with external parallelization like xargs:

   out/fm | time xargs -n4 -P32 out/fm -b cpu ... -s
   out/fm | time xargs -n32 -P8 out/fm -b gl ... -s
   ls *.skp | xargs ... out/fm ... -s
   ...

TODO later:
   vector backends: --backend pdf, svg, xps, skp
   --source *.svg, *.json (Skottie)
   Create/update a dm.json file

Change-Id: Idacbd2785deaf6f1d33674c66c4d984fa91dbd85
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203520
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2019-03-27 14:00:58 +00:00
Ravi Mistry
0a8b259a72 Fix RecreateSKPs bot page sets III
* skia_nytimes_mobile looks the same as skia_nytimes_desktop so deleting it.
* Was unsuccessful in making skia_sfgate_desktop work so deleting it.
* Increasing wait time in capitalvolkswagen seems to help SKP be more complete.
* Increasing wait time in booking does not seem to inc # of images but increasing it anyway.

NoTry: true
Bug: skia:8653
Change-Id: I9c05ffa679652a4b3962967f8376df525e7649fb
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203821
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2019-03-27 13:31:28 +00:00
Robert Phillips
3bf3d4a8b7 Minor cleanup of GrResourceAllocator
This also adds a useful debug print out (of the end-of-opList array)

Change-Id: Ia678b6e8d143ca4f851984fb5026c2ec4f998384
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/202706
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2019-03-27 13:20:48 +00:00
Florin Malita
0ed4c37634 [skottie] Fix handling of hidden shapes and layers
TBR=reed@google.com

Bug: skia:8923
Change-Id: I5bd1d4f2ef62ebd95cfae0fe3665960b07ed4ae1
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/204082
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2019-03-27 13:17:48 +00:00
Robert Phillips
c476e5da4f Fix bug in GrResourceAllocator's intermediate flushing (take 2)
Without the missing increment of fCurOpListIndex in the intermediate flush case, the drawing manager could end up re-executing an entire opList.

TBR=bsalomon@google.com
Bug: 942538
Change-Id: I8298c02071e87a343ec03d809959d06049071d93
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203726
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2019-03-27 10:59:57 +00:00
skia-autoroll
003e9f14f6 Roll third_party/externals/swiftshader e747b3c3c9d9..df5b28fdb45c (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/e747b3c3c9d9..df5b28fdb45c


git log e747b3c3c9d9..df5b28fdb45c --date=short --no-merges --format='%ad %ae %s'
2019-03-27 swiftshader.regress@gmail.com Regres: Update test lists @ e747b3c3


Created with:
  gclient setdep -r third_party/externals/swiftshader@df5b28fdb45c

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=stani@google.com

Change-Id: I5c899b3f5f2af51d38d4a4185033d06b2fbd6b4e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203936
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-03-27 08:06:16 +00:00
skia-recreate-skps
d1c271bd39 Update go_deps asset
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: Ie374938f7e908d3f987dcf3eca721e3156389c26
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203673
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2019-03-27 05:58:16 +00:00
skia-recreate-skps
726eb052e3 Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=rmistry@google.com
NO_MERGE_BUILDS

Change-Id: Ie1bbad6e84eb6094462419649d7e05f29192c52e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203672
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2019-03-27 05:26:24 +00:00
skia-recreate-skps
022c8317d0 Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=rmistry@google.com
NO_MERGE_BUILDS

Change-Id: I4c9f607e38bdbcc3ad9bb365b79a90cabfcb59f7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203671
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2019-03-27 04:21:54 +00:00
skia-autoroll
cec20280b3 Roll third_party/externals/angle2 a47e2a23ab4c..518c679da109 (3 commits)
a47e2a23ab..518c679da1


git log a47e2a23ab4c..518c679da109 --date=short --no-merges --format='%ad %ae %s'
2019-03-26 jonahr@google.com Clean up test_expectations to merge with angle style/convention.
2019-03-26 syoussefi@chromium.org Fix OOM in TextureUpload perf test
2019-03-26 syoussefi@chromium.org Disable GPU perf tracking on D3D


Created with:
  gclient setdep -r third_party/externals/angle2@518c679da109

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=stani@google.com

Change-Id: Ibe1a5edcefad98422b41b84738e8c8bdb5508fbf
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203928
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-03-27 03:46:24 +00:00
skia-autoroll
62c6a38710 Roll ../src 4035f6c897d0..83d44af5c208 (535 commits)
4035f6c897..83d44af5c2


Created with:
  gclient setdep -r ../src@83d44af5c2

The AutoRoll server is located here: https://autoroll.skia.org/r/chromium-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Release-All-CommandBuffer;skia.primary:Test-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Debug-All-CommandBuffer
TBR=stani@google.com

Change-Id: Iff9fa07f26b7276abe97042b64345556438aafaa
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203926
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-03-27 03:12:44 +00:00
recipe-roller
5223343210 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/b37679d2f44240b461114360ae38e0d974f44119 Add more post process expectation annotations. (erikchen@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I834c14862660268da9a5f24c1fb46fed4c5d954c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203805
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2019-03-27 01:04:14 +00:00
Chris Dalton
bf341ae88c Revert "Add MSAA and non-aa modes to GrFillRRect Op"
This reverts commit 16a8e99a37.

Reason for revert: Amd/Radeon bugs and quality concerns

Original change's description:
> Add MSAA and non-aa modes to GrFillRRect Op
> 
> Adds a non-aa mode and an MSAA mode that uses the sample mask. Also
> adds a new cap to decide whether we prefer this new sample mask Op for
> large round rects, or whether it's faster to just continue drawing
> them as paths like before.
> 
> Bug: skia:
> Change-Id: Iea7d9a78766f67c196a02cb833c84a0ac3f1bbac
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/202921
> Reviewed-by: Brian Salomon <bsalomon@google.com>
> Commit-Queue: Chris Dalton <csmartdalton@google.com>

TBR=bsalomon@google.com,brianosman@google.com,csmartdalton@google.com,ethannicholas@google.com

Change-Id: If2c3293bdd8c19307e243d83c44fd328446fded7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203961
Reviewed-by: Chris Dalton <csmartdalton@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2019-03-27 00:28:37 +00:00
skia-autoroll
2b7cca4cd8 Roll third_party/externals/swiftshader cc6473f7d80d..e747b3c3c9d9 (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/cc6473f7d80d..e747b3c3c9d9


git log cc6473f7d80d..e747b3c3c9d9 --date=short --no-merges --format='%ad %ae %s'
2019-03-26 bclayton@google.com SpirvShader: Implement loops


Created with:
  gclient setdep -r third_party/externals/swiftshader@e747b3c3c9d9

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=stani@google.com

Change-Id: I689c677e1e37706f340a73070f8de609cf61e877
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203901
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-03-26 22:47:52 +00:00
Ravi Mistry
45d5f70213 Fix RecreateSKPs bot page sets II
Both mobile SKPs of ebay/sfgate are not useful. We already have a desktop version of ebay. Create one for sfgate.

NoTry: true
Bug: skia:8653
Change-Id: I535c352d46d34500c2a8bdda12d406c58e16fd55
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203804
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2019-03-26 20:50:32 +00:00
Chris Dalton
16a8e99a37 Add MSAA and non-aa modes to GrFillRRect Op
Adds a non-aa mode and an MSAA mode that uses the sample mask. Also
adds a new cap to decide whether we prefer this new sample mask Op for
large round rects, or whether it's faster to just continue drawing
them as paths like before.

Bug: skia:
Change-Id: Iea7d9a78766f67c196a02cb833c84a0ac3f1bbac
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/202921
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2019-03-26 20:39:02 +00:00
Florin Malita
f4e8733947 [skottie] Relocate text shaping utils to separate compilation unit
Introduce AE-specific text shaping abstractions, and move the existing
implementation to a separate CU.

Change-Id: I8533ed8d9c59af6d82b3f1ca66a6e1d50a3c33c5
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203706
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2019-03-26 20:34:02 +00:00
Mike Klein
3e0141ab70 quiet down SkFontHost_FreeType debug logs
These seem like ad-hoc debugging aids,
not something that needs to print in all Debug builds?
Maybe even should just be deleted?

Change-Id: I240d85b004ccddac134312d369231015d8234fdf
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203698
Auto-Submit: Mike Klein <mtklein@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
2019-03-26 20:23:52 +00:00
Jim Van Verth
ce9a7af967 Fix BGRA GL texture format on iOS
Bug: skia:
Change-Id: Ifb800bb4fccfc330017a80046e5054432f2a2617
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/201002
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
2019-03-26 20:05:42 +00:00
Michael Ludwig
926fb89d7b Remove old experimental SkiaRenderer APIs
Change-Id: I21bd0155bf28420c10caf43af29748def510643c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203171
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
2019-03-26 19:59:03 +00:00
skia-autoroll
c007fec97e Roll third_party/externals/swiftshader 213a8ce6d5c2..cc6473f7d80d (4 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/213a8ce6d5c2..cc6473f7d80d


git log 213a8ce6d5c2..cc6473f7d80d --date=short --no-merges --format='%ad %ae %s'
2019-03-26 capn@google.com Regenerate Windows LLVM configs
2019-03-26 capn@google.com Regenerate Linux LLVM configs
2019-03-26 capn@google.com Add Windows support to LLVM config generation script
2019-03-26 capn@google.com Disable LLVM_ENABLE_THREADS in config generation script


Created with:
  gclient setdep -r third_party/externals/swiftshader@cc6473f7d80d

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=stani@google.com

Change-Id: I7289767c25e2b2962f1b91d304585d161034fb46
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203785
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-03-26 19:37:52 +00:00
skia-autoroll
ebaf89afe9 Roll third_party/externals/angle2 da37e7f6759d..a47e2a23ab4c (2 commits)
da37e7f675..a47e2a23ab


git log da37e7f6759d..a47e2a23ab4c --date=short --no-merges --format='%ad %ae %s'
2019-03-26 syoussefi@chromium.org Add instructions for use with RenderDoc + Android
2019-03-26 ynovikov@chromium.org Suppress dEQP-GLES31.functional.atomic_counter.* on Win7 NVIDIA D3D11


Created with:
  gclient setdep -r third_party/externals/angle2@a47e2a23ab4c

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=stani@google.com

Change-Id: I8a83af5adae9e966711c888510dc4626938f44ff
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203782
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-03-26 18:47:52 +00:00
recipe-roller
b23aee3431 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/a4f9a8b3ac3195aab9c10e1dfa15a46edc4fb190 Convert newline characters in step_text to html breaks. (gbeaty@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ibdc5c1df0efdcdb45965593ea19e6a3cd9d72350
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203800
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2019-03-26 18:33:32 +00:00