Commit Graph

33372 Commits

Author SHA1 Message Date
Ben Wagner
f20710e00c [recipes] Add asset_version utility function.
Bug: skia:7720
Change-Id: I044ca5281354b21c9deffa408ad7ec20c51d2e2e
Reviewed-on: https://skia-review.googlesource.com/115122
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2018-03-20 14:02:03 +00:00
Joe Gregorio
0060c3394c [lottiecap] Moved over from buildbot repo.
Command line application to build a 5x5 filmstrip
from a Lottie file in Chrome headless and then export
that filmstrip in a 1000x1000 PNG.

Bug: skia:
Change-Id: I38decac363f2d592fddc28b3f4ca9450c5851ac6
Reviewed-on: https://skia-review.googlesource.com/115100
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2018-03-20 13:25:23 +00:00
angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
ec77963bf3 Roll skia/third_party/externals/angle2/ 3761dc7bf..daedf4d23 (3 commits)
3761dc7bf6..daedf4d234

$ git log 3761dc7bf..daedf4d23 --date=short --no-merges --format='%ad %ae %s'
2018-03-16 lucferron Vulkan: Add a DynamicDescriptorPool class.
2018-03-15 oetuaho Clean up switch/case pruning code
2018-03-16 lucferron Vulkan: Add 2 features to StreamingBuffer

Created with:
  roll-dep skia/third_party/externals/angle2


The AutoRoll server is located here: https://angle-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE
TBR=jvanverth@google.com

Change-Id: I39af6ac4fae88ae8a88b5777f825e8b217103cf1
Reviewed-on: https://skia-review.googlesource.com/115170
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-03-19 22:56:25 +00:00
Yuqian Li
ec46871a0c Make consistent isRadiusIncreasing decision
This should not affect anything for now. But it may prevent some future
problems where someone accidentally changed isRadiusIncreasing implementation,
and getting confused by the unexpected shading behavior.

Bug: skia:
Change-Id: I45e83f4bc9eefbdc1ad1c196a43444e24c782711
Reviewed-on: https://skia-review.googlesource.com/115162
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Yuqian Li <liyuqian@google.com>
2018-03-19 22:46:46 +00:00
Cary Clark
3b68882918 remove imageinfo flatten altogether
If SkImageInfo flatten and unflatten aren't referenced outside
of one test, perhaps they can be removed altogether.

R=reed@google.com

Bug: skia:6898
Change-Id: Ia6f82b66d4496a628ad95c386d1865793f3e31a9
Reviewed-on: https://skia-review.googlesource.com/115074
Commit-Queue: Cary Clark <caryclark@skia.org>
Reviewed-by: Mike Reed <reed@google.com>
2018-03-19 21:28:46 +00:00
Brian Salomon
19eaf2dbe7 Revert "Revert "New read pixels implementation that is simpler but does all conversions on CPU.""
This reverts commit be5947c2f3.

Bug: skia:
Change-Id: I06dc15b31042d7827511d0ac2a7f4262c3f09622
Reviewed-on: https://skia-review.googlesource.com/115079
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2018-03-19 21:17:15 +00:00
Brian Salomon
56dc04bdc1 Remove deprecated versions of YUV texture SkImage factories
Bug: skia:6718
Change-Id: I856b64192e1b797f60b833dd58014e058ea351b3
Reviewed-on: https://skia-review.googlesource.com/115124
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2018-03-19 21:04:55 +00:00
Eric Karl
af7700265b Allow SkTraceMemoryDump to exclude wrapped objects
Allow SkTraceMemoryDump to exclude wrapped objects from dumps. This
helps avoid duplicate dumping when Skia is wrapping an external object
which is already dumped externally.

Bug: 795358
Change-Id: Icbda96b564c81b958d40f74693280ac7d5ba7332
Reviewed-on: https://skia-review.googlesource.com/114681
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Eric Karl <ericrk@chromium.org>
2018-03-19 20:37:25 +00:00
Heather Miller
72040d9d70 Fix go syntax for Debian compile
Bug: skia:7688
Change-Id: I5b4f9b3aba7d696d09c1c2f0634c8c866e5ba99d
Reviewed-on: https://skia-review.googlesource.com/115077
Reviewed-by: Mike Klein <mtklein@google.com>
Reviewed-by: Stephan Altmueller <stephana@google.com>
Commit-Queue: Heather Miller <hcm@google.com>
2018-03-19 20:26:46 +00:00
Brian Salomon
53706774a7 Remove SkSurface::MakeFromBackendTexture variant that doesn't take SkColorType
Bug: skia:6718
Change-Id: I8289c54ca9a5f89d10dc0b0dfe750d4fd1da0b64
Reviewed-on: https://skia-review.googlesource.com/115102
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2018-03-19 20:12:05 +00:00
Ethan Nicholas
371e29c69e fix switch fallthrough warning
Bug: skia:
Change-Id: Ia2e25545319d54c3258b76c050b46a73c292c791
Reviewed-on: https://skia-review.googlesource.com/115085
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
2018-03-19 19:02:46 +00:00
Yuqian Li
650dd901e1 Fix concentric 2pt conical gradient in GPU where r1 < r0
Bug: skia:7683
Change-Id: I6608e72fa695c855af6a6a447885c4889b09fc1d
Reviewed-on: https://skia-review.googlesource.com/115042
Commit-Queue: Yuqian Li <liyuqian@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
2018-03-19 18:50:46 +00:00
Brian Salomon
cb88470d82 Remove SkSurface::MakeFromBackendTextureAsRenderTarget variant that doesn't take SkColorType
Bug: skia:6718
Change-Id: I3fabe2050394bfbd8ad2fa600d07323838308ae5
Reviewed-on: https://skia-review.googlesource.com/115087
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2018-03-19 18:43:25 +00:00
Brian Salomon
be5947c2f3 Revert "New read pixels implementation that is simpler but does all conversions on CPU."
This reverts commit c9a642edf2.

Reason for revert: 1010102 gms broke

Original change's description:
> New read pixels implementation that is simpler but does all conversions on CPU.
> 
> Change-Id: Ia548cd24a8544b35a233311706faf48de353b7cf
> Reviewed-on: https://skia-review.googlesource.com/109902
> Commit-Queue: Brian Salomon <bsalomon@google.com>
> Reviewed-by: Robert Phillips <robertphillips@google.com>

TBR=bsalomon@google.com,robertphillips@google.com,brianosman@google.com

Change-Id: I7724a6eef79885ba2a32c1ac871e5b2a9a3c0c12
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/115140
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2018-03-19 18:42:36 +00:00
Brian Salomon
c9a642edf2 New read pixels implementation that is simpler but does all conversions on CPU.
Change-Id: Ia548cd24a8544b35a233311706faf48de353b7cf
Reviewed-on: https://skia-review.googlesource.com/109902
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2018-03-19 17:19:45 +00:00
Mike Reed
8430eace0b handle divide by zero in paint
Bug: oss-fuzz:7003
Change-Id: Ie3266292ca94a28cc7023ed5255895d25f0d4dc8
Reviewed-on: https://skia-review.googlesource.com/115041
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-03-19 16:53:25 +00:00
Herb Derby
c683dd12fe Remove a ctor from SkAutoGlyphCache; removal continues.
This change SkAutoGlyphCache with one remaining ctor, then
it's time to remove SkAutoGlyphCacheNoGamma, which is used
but Android.

Change-Id: I0f75ccb4139700d0b678492173f50ac0580d20cd
Reviewed-on: https://skia-review.googlesource.com/115007
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2018-03-19 16:23:35 +00:00
Greg Daniel
2b41784855 Make sure we set stencil layout when doing copy as draw
Bug: skia:
Change-Id: Ifa52e97d36a7008b670a1b69f1cd45df5c090f91
Reviewed-on: https://skia-review.googlesource.com/115008
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2018-03-19 15:41:45 +00:00
Robert Phillips
96b6d537c2 Fix GrTextureStripAtlasManager cleanup order bug
Bug: 820703
Change-Id: I6f1a895ceb213d38361bc03a472cf2a48e4720a5
Reviewed-on: https://skia-review.googlesource.com/115001
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2018-03-19 15:36:26 +00:00
Kaloyan Donev
f7466bd84a Support x86 build with VS 2015
Pass extra assembler flags to the asm tool in msvc toolchain

My first commit so added my name to the AUTHORS file.

Change-Id: I19529a901be6d9c00df3c0880003be3363475c6e
Reviewed-on: https://skia-review.googlesource.com/114740
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2018-03-19 15:20:35 +00:00
Kevin Lubick
a3ecaf5fcf [skpbench] Use android's perf settings for Pixel C
These are a bit more conservative, but will hopefully come with improved
stability like https://skia-review.googlesource.com/c/skia/+/111740 did.

If this works, we can push the envelope by using the slightly
more aggressive settings found at
https://android.googlesource.com/platform/platform_testing/+/master/scripts/perf-setup/dragon-setup.sh

Bug: skia:7238
Change-Id: Ia0e24c7fc9bcc2fd44dcd0a57dde481ad8c55f7d
Reviewed-on: https://skia-review.googlesource.com/114283
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2018-03-19 14:22:55 +00:00
Kevin Lubick
e3d3f65396 Avoid bad alloc in SkReadBuffer
The fuzzer enjoyed tripping over this.

Bug: skia:
Change-Id: Ia7f4821404936266c77462232d7a64591580c2e0
Reviewed-on: https://skia-review.googlesource.com/114983
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2018-03-19 14:17:15 +00:00
angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
2f974d4c9f Roll skia/third_party/externals/angle2/ dfebe9b2d..3761dc7bf (1 commit)
dfebe9b2d5..3761dc7bf6

$ git log dfebe9b2d..3761dc7bf --date=short --no-merges --format='%ad %ae %s'
2018-03-19 jmadill Fix infra.cq to point to new Linux configs.

Created with:
  roll-dep skia/third_party/externals/angle2


The AutoRoll server is located here: https://angle-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE
TBR=jvanverth@google.com

Change-Id: Ib0cef782d52a3de94632d931f180611fdbfb7d8b
Reviewed-on: https://skia-review.googlesource.com/114982
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-03-19 14:11:25 +00:00
Cary Clark
0949beeaf4 fix op fuzz
fixes the current four fuzzer fails by rewriting
asserts as function exits. Passes all extended
pathops testing.

To run the extended tests:
./out/debug/pathops_unittest -V -x
./out/release/pathops_unittest -V -x

R=kjlubick@google.com

Docs-Preview: https://skia.org/?cl=114962
Bug: skia:
Change-Id: I05bd368a87b38b1121403cf93b21caf76c2e7d7e
Reviewed-on: https://skia-review.googlesource.com/114962
Commit-Queue: Cary Clark <caryclark@skia.org>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-03-19 14:06:25 +00:00
Ethan Nicholas
8d2ba44c9c SPIR-V output now always includes DescriptorSet for uniforms
Bug: skia:
Change-Id: I6a31d6ec51d59340ef738c2bc4a8a88a261bef14
Reviewed-on: https://skia-review.googlesource.com/114865
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
2018-03-19 13:49:55 +00:00
Cary Clark
89b1456b55 detect deprecated methods
If a method in an include is marked deprecated, make sure that
the documentation is marked deprecated.

It's OK for the documentation to mark something deprecated that
is not marked as such in the includes since the documentation may
be ahead of the includes.

Fix a couple of mistakes found around deprecated methods.

Docs-Preview: https://skia.org/?cl=114184
TBR=caryclark@google.com
Bug: skia:6898
Change-Id: I2bb4c293d7bf28e5d12f9ae01b7be49ce48b9ee4
Reviewed-on: https://skia-review.googlesource.com/114184
Commit-Queue: Cary Clark <caryclark@skia.org>
Reviewed-by: Cary Clark <caryclark@skia.org>
2018-03-19 13:30:16 +00:00
Cary Clark
a7d661a681 fix fuzz
if built path is empty, don't add a zero-length line
(when start and end of interval are equal)

R=kjlubick@google.com

Docs-Preview: https://skia.org/?cl=114940
Bug: skia:
Change-Id: I018eaec4d31daf3e3820641127b63d047e4ee007
Reviewed-on: https://skia-review.googlesource.com/114940
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Cary Clark <caryclark@skia.org>
2018-03-19 13:25:25 +00:00
Eric Boren
ccbe400174 [recipes] Band-aid on top of a hack: pin depot_tools
Bug: skia:7050
Change-Id: I53b141bf76ab4773909df968f69ba04dc29e0dc9
Reviewed-on: https://skia-review.googlesource.com/114960
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-03-19 12:43:45 +00:00
Robert Phillips
fe0253f8bb Alter GrSurface/GrSurfaceProxy flags to prepare for GrTexture/GrTextureProxy -specific flags
This CL:
  moves GrRenderTarget::fFlags to GrSurface::fSurfaceFlags
  adds a GrInternalSurfaceFlags type and uses it for GrSurfaceProxy::fSurfaceFlags

  The goal of this is to provide a location where GrTexture/GrTextureProxy-specific flags
(i.e., isExternal & isRectangle) can be stored.

Change-Id: I8df7b79036a6853dd378ff6cf10d4b37c60dd511
Reviewed-on: https://skia-review.googlesource.com/114796
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2018-03-19 12:21:05 +00:00
Update Docs
4410d7ff75 Update markdown files
Automatic commit by the Housekeeper-Nightly-Bookmaker bot.

TBR=update-docs@skia.org
NO_MERGE_BUILDS

Change-Id: If3f0b1d4079a9f3278ef695c36a7629840fff564
Reviewed-on: https://skia-review.googlesource.com/114922
Commit-Queue: Update Docs <update-docs@skia.org>
Reviewed-by: Update Docs <update-docs@skia.org>
2018-03-19 06:29:55 +00:00
Cary Clark
a7b84c5a50 fix fiddle example
TBR=caryclark@google.com

Bug: skia:6898
Change-Id: I7afde5c236fa087d623519b1a121bfbd3d70bd5e
Reviewed-on: https://skia-review.googlesource.com/114920
Reviewed-by: Cary Clark <caryclark@skia.org>
Commit-Queue: Cary Clark <caryclark@skia.org>
2018-03-18 16:12:24 +00:00
Greg Daniel
38c3d93810 Don't emit empty command buffers in vulkan
This may just cause use to do unneed loading and storing of memory.

Bug: skia:
Change-Id: I3f23d91df95f6e79b834fbb595ad9e9fb4371f9a
Reviewed-on: https://skia-review.googlesource.com/114793
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2018-03-17 11:35:00 +00:00
angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
876dd31483 Roll skia/third_party/externals/angle2/ 1c08cbb39..dfebe9b2d (4 commits)
1c08cbb398..dfebe9b2d5

$ git log 1c08cbb39..dfebe9b2d --date=short --no-merges --format='%ad %ae %s'
2018-03-14 jmadill D3D11: Add dirty bits for Transform Feedback.
2018-03-14 jmadill Vulkan: Enable SimpleVertexShader.
2018-03-16 jmadill Vulkan: Implement depth range correction.
2018-03-14 jmadill Remove HasIndexRange.

Created with:
  roll-dep skia/third_party/externals/angle2


The AutoRoll server is located here: https://angle-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE
TBR=stephana@google.com

Change-Id: I896a161b718b1fcf79729bcf513e60c8a3ea330f
Reviewed-on: https://skia-review.googlesource.com/114880
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-03-17 00:03:40 +00:00
Stan Iliev
0a86820f2f Revert "fix nextContour bug"
This reverts commit 473f69276f.

Reason for revert: a CTS test PathMeasureTest.android.graphics.cts.PathMeasureTest.testNextContour is failing

Original change's description:
> fix nextContour bug
> 
> Calling nextContour() needs to ensure that we've already measured the "current" one.
> 
> Bug: skia:
> Change-Id: I501c26d0b068028d67103888f06ec89125a5407a
> Reviewed-on: https://skia-review.googlesource.com/114692
> Reviewed-by: Cary Clark <caryclark@google.com>
> Commit-Queue: Mike Reed <reed@google.com>

TBR=caryclark@google.com,reed@google.com

Change-Id: I7f1e08651dfe73c02158b209dc28af2b174e246f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/114823
Reviewed-by: Stan Iliev <stani@google.com>
Commit-Queue: Stan Iliev <stani@google.com>
2018-03-16 21:01:16 +00:00
Greg Daniel
55fa647596 Correctly discard or load RT when doing copies as draws in Vulkan
This fixes all the copy as draw issues we've had with certain devices and
the cap is no longer needed.

Bug: skia:
Change-Id: Id0b750849c4c920beae2d8cb3eda5f402018f194
Reviewed-on: https://skia-review.googlesource.com/114860
Commit-Queue: Greg Daniel <egdaniel@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2018-03-16 20:54:26 +00:00
Ben Wagner
041e7ced7c Add GT610 Debug ANGLE jobs.
Bug: skia:7312
Change-Id: Ib84b57c8ca029e94da8897de5b7d400a394bf87c
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/74140
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2018-03-16 20:43:16 +00:00
Herb Derby
76d69b44bb Apply filterTextFlags so the fonts are the same.
In order to apply filterTextFlags correctly, teach
TrackLayerDevice how to process save and restore layers.

At this point, I don't see any other traffic than the
cache warming traffic.

This code has a performance between 82% and 105% of just
drawing the picture.

BUG=skia:7515

Change-Id: I44736be46884f18b6d120d4b5ca582f34dbdff0f
Reviewed-on: https://skia-review.googlesource.com/114641
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2018-03-16 20:28:36 +00:00
Greg Daniel
7278d68cac Add DoneProc to Promise Images
This proc will notify the client when we will no longer call fulfill on
their promise image so that can delete any meta data they needed to store
to be able to complete the fulfill requests.

Bug: skia:
Change-Id: Ife1e6845f221c31ce1ae2c0d2ba5e4c8f0203b74
Reviewed-on: https://skia-review.googlesource.com/114092
Commit-Queue: Greg Daniel <egdaniel@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2018-03-16 19:27:46 +00:00
Mike Reed
7ba427ef40 handle bad xform in drawTextRSXform
Bug: oss-fuzz:6955
Change-Id: Ide1f57459a611980a86afea577eb4c2425e49e63
Reviewed-on: https://skia-review.googlesource.com/114782
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2018-03-16 19:03:16 +00:00
Mike Reed
b5319d5e13 fix overflow in rgnbuilder
Bug: oss-fuzz:6956
Change-Id: I244e49d458eb78e0c6200fc3c147f0f67823f97f
Reviewed-on: https://skia-review.googlesource.com/114780
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2018-03-16 19:02:06 +00:00
Ravi Mistry
310a2d9280 Revert "Remove Android Framework bot from CQ while server is being upgraded"
This reverts commit 2ab6f7e580.

Reason for revert: Server back with more cores

Original change's description:
> Remove Android Framework bot from CQ while server is being upgraded
> 
> NoTry: true
> Bug: skia:7716
> Change-Id: I67695c5f45ac5b9c57d0599ba2ab2e825fa75e4b
> Reviewed-on: https://skia-review.googlesource.com/114788
> Reviewed-by: Ravi Mistry <rmistry@google.com>
> Reviewed-by: Ben Wagner <benjaminwagner@google.com>
> Commit-Queue: Ravi Mistry <rmistry@google.com>
> Commit-Queue: Ben Wagner <benjaminwagner@google.com>

TBR=benjaminwagner@google.com,rmistry@google.com

Change-Id: I01626d9a4de98a27a350b053cb1aa7612d71d136
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:7716
Reviewed-on: https://skia-review.googlesource.com/114820
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2018-03-16 18:40:36 +00:00
Cary Clark
681287eb67 more imageinfo text and warnings and cleanup
more imageinfo text

rewrote many examples to fix newly exposed compiler warnings

marked a couple of YUV method bodies as deprecated

also cleaned up line endings to use the linux style

R=bsalomon@google.com
TBR=caryclark@google.com
Docs-Preview: https://skia.org/?cl=112302
Bug: skia:6898
Change-Id: I89626a27353aa84526f9b9475d927bd0e9d8f0d5
Reviewed-on: https://skia-review.googlesource.com/112302
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Cary Clark <caryclark@google.com>
2018-03-16 18:11:35 +00:00
Greg Daniel
a3c68df565 Make sure we do a render pass load if we copied to a surface before hand
Bug: skia:
Change-Id: I4858e0774956f6283122bf71c84f3c6161e1d349
Reviewed-on: https://skia-review.googlesource.com/114790
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2018-03-16 18:10:25 +00:00
Ethan Nicholas
16c1196ea6 fix SkSL SPIR-V geometry shaders' entry point declaration
Bug: skia:
Change-Id: I5cd5a35fe1a554b127548a7809c106de70df0be7
Reviewed-on: https://skia-review.googlesource.com/114785
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
2018-03-16 17:54:05 +00:00
Ravi Mistry
2ab6f7e580 Remove Android Framework bot from CQ while server is being upgraded
NoTry: true
Bug: skia:7716
Change-Id: I67695c5f45ac5b9c57d0599ba2ab2e825fa75e4b
Reviewed-on: https://skia-review.googlesource.com/114788
Reviewed-by: Ravi Mistry <rmistry@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2018-03-16 17:21:51 +00:00
Ethan Nicholas
6c94271f55 we now complain if an SkSL program tries to override the default output
Bug: skia:
Change-Id: I387ddc3aac0712eb6c0a6ea39e48e5f3d809bc48
Reviewed-on: https://skia-review.googlesource.com/114691
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
2018-03-16 16:44:11 +00:00
Greg Daniel
ea022cd714 Fix vulkan layout barriers when we are doing in line uploads.
Bug: skia:
Change-Id: I0842a4eebba8cfa8310d0680941d59f1e363e574
Reviewed-on: https://skia-review.googlesource.com/114760
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2018-03-16 15:54:01 +00:00
angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
8b858526fa Roll skia/third_party/externals/angle2/ 5ae6ee457..1c08cbb39 (1 commit)
5ae6ee4578..1c08cbb398

$ git log 5ae6ee457..1c08cbb39 --date=short --no-merges --format='%ad %ae %s'
2018-03-15 jiawei.shao Clean up link validations on interface blocks

Created with:
  roll-dep skia/third_party/externals/angle2


The AutoRoll server is located here: https://angle-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE
TBR=stephana@google.com

Change-Id: Ic7da673d0bda6d4c013112c2f7b39c73611cadc6
Reviewed-on: https://skia-review.googlesource.com/114694
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-03-16 15:22:11 +00:00
Mike Reed
473f69276f fix nextContour bug
Calling nextContour() needs to ensure that we've already measured the "current" one.

Bug: skia:
Change-Id: I501c26d0b068028d67103888f06ec89125a5407a
Reviewed-on: https://skia-review.googlesource.com/114692
Reviewed-by: Cary Clark <caryclark@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2018-03-16 15:11:31 +00:00
Greg Daniel
e464160f69 Fix Vulkan Copy as draw shader
Bug: skia:7663
Change-Id: I745900ccc56c697e4abb982e921d99bc28502b33
Reviewed-on: https://skia-review.googlesource.com/114687
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2018-03-16 13:36:51 +00:00