AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
23,324 Commits 1 Branch 0 Tags 544 MiB
f5b675efbe
Commit Graph

23324 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
vjiaoblack
95302da19d Creating framework for drawShadowedPicture 
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2146073003

Committed: https://skia.googlesource.com/skia/+/0ae097d116f4332be02a135ffc99c162473dee6a
Review-Url: https://codereview.chromium.org/2146073003
 2016-07-21 10:25:54 -07:00
caryclark
b5dc4051f7 add pathops debugging to fuzz 
Add optional debugging routines for use in gdb.

R=kjlubick
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2171773002

Review-Url: https://codereview.chromium.org/2171773002
 2016-07-21 09:41:14 -07:00
lsalzman
f41ae2f973 limit the number of points in SkDashPathEffect::asPoints 
If the length of a line path is sufficiently long relative to the dash
interval, it is possible to cause SkDashPathEffect::asPoints to produce
so many points that it overflows the amount that can fit in an int type,
or otherwise produce non-finite values, i.e. path from (0,0) to (0,9e15)
with a dash interval of 1.

This fixes that by capping the amount of points to a sane limit - in this
case, 1mil, since that limit is also used in utils/SkDashPath.cpp and has
precedent.

Downstream Firefox bug report: https://bugzilla.mozilla.org/show_bug.cgi?id=1287515

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2165013002

Review-Url: https://codereview.chromium.org/2165013002
 2016-07-21 09:37:59 -07:00
robertphillips
f292a0c862 Remove SkGrPixelRef 
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2167173002

Review-Url: https://codereview.chromium.org/2167173002
 2016-07-21 09:35:07 -07:00
egdaniel
725266a9b1 Add vulkan compile bot to CQ 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2166353003

Review-Url: https://codereview.chromium.org/2166353003
 2016-07-21 09:29:01 -07:00
vjiaoblack
33d325890e Revert of Creating framework for drawShadowedPicture (patchset #14 id:260001 of https://codereview.chromium.org/2146073003/ ) 
Reason for revert:
Decided to re-wait for a final LGTM.

Already found a bug in variable naming to fix.

Original issue's description:
> Creating framework for drawShadowedPicture
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2146073003
>
> Committed: https://skia.googlesource.com/skia/+/0ae097d116f4332be02a135ffc99c162473dee6a

TBR=reed@google.com,robertphillips@google.com,bsalomon@google.com,jvanverth@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2167223002
 2016-07-21 09:24:16 -07:00
robertphillips
5fa7f30331 Remove DrawFace enum from GrPipelineBuilder 
This gets GrPipelineBuilder.h out of the headers

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2165283002

Committed: https://skia.googlesource.com/skia/+/da152ebb032c61bb2561bbb3e9a78037ad174d34
Review-Url: https://codereview.chromium.org/2165283002
 2016-07-21 09:21:04 -07:00
vjiaoblack
0ae097d116 Creating framework for drawShadowedPicture 
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2146073003

Review-Url: https://codereview.chromium.org/2146073003
 2016-07-21 09:10:23 -07:00
robertphillips
d2b6d6486e Minor change to Ganesh path renderers 
In large part this is an attempt to get non-substantive changes out of https://codereview.chromium.org/2092893003/ (Retract PipelineBuilder some more)

All the other parameters extracted from DrawPathArgs are passed around by reference except for the userStencilSettings

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2167183002

Review-Url: https://codereview.chromium.org/2167183002
 2016-07-21 08:55:08 -07:00
caryclark
7b33bf1d2a fix builder fuzz 
Fix ASAN_heap-use-after-free crash

R=kjlubick
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2168963002

Review-Url: https://codereview.chromium.org/2168963002
 2016-07-21 08:53:32 -07:00
robertphillips
5d1676c751 Revert of Remove DrawFace enum from GrPipelineBuilder (patchset #2 id:20001 of https://codereview.chromium.org/2165283002/ ) 
Reason for revert:
No Vulkan bot in CQ :(

Original issue's description:
> Remove DrawFace enum from GrPipelineBuilder
>
> This gets GrPipelineBuilder.h out of the headers
>
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2165283002
>
> Committed: https://skia.googlesource.com/skia/+/da152ebb032c61bb2561bbb3e9a78037ad174d34

TBR=bsalomon@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2167193002
 2016-07-21 08:18:05 -07:00
bsalomon
9f071d1fa5 Update build_command_buffer.py to copy libcommand_buffer_gles2.so from the correct dir on linux 
Apparently the linux build now puts the library in chromium's output dir rather than a lib/ subdir.

TBR=borenet@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2165013003

Review-Url: https://codereview.chromium.org/2165013003
 2016-07-21 08:05:01 -07:00
robertphillips
da152ebb03 Remove DrawFace enum from GrPipelineBuilder 
This gets GrPipelineBuilder.h out of the headers

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2165283002

Review-Url: https://codereview.chromium.org/2165283002
 2016-07-21 07:58:41 -07:00
robertphillips
1f3923e4e5 Deprecate SkDevice::accessBitmap method 
Relies on https://codereview.chromium.org/2162423003/ (Add SK_SUPPORT_LEGACY_ACCESSBITMAP Skia guard) landing in Chromium first.

Calved off: https://codereview.chromium.org/2163323002/ (Add desired width & height to drawContext (as opposed to using the width & height of the RT))

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2168483003

Review-Url: https://codereview.chromium.org/2168483003
 2016-07-21 07:17:54 -07:00
brianosman
afbf71dd92 Adding color space to SkSpecialImage 
Mostly means that GPU backed special images need to be supplied (and
store) a color space object.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2163343002

Review-Url: https://codereview.chromium.org/2163343002
 2016-07-21 07:15:37 -07:00
msarett
1b93bd1e6e Refactor parsing and storage of SkGammas 
Benefits:
(1) Parses and stores gamma tags in a single allocation.
(2) Recognizes equal gamma tags to skip parsing work and
    save memory.

Non-Benefits:
(1) Not less complicated.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2117773002

Committed: https://skia.googlesource.com/skia/+/2ea944c2b710caf29d4795ac953bad14224796f7
Committed: https://skia.googlesource.com/skia/+/959ccc1f3f49e1ddeb51c32c30ac4a2d94653856
Review-Url: https://codereview.chromium.org/2117773002
 2016-07-21 07:11:26 -07:00
mtklein
9b43094bf2 Roll buildtools for latest GN binary. 
This GN binary has a JSON backend that's meant to be parsed to seed other
build configurations (e.g. CMake, Android, Google3).

You will need to re-run ./gn.py to fetch the newest binary.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2164263002

Review-Url: https://codereview.chromium.org/2164263002
 2016-07-21 06:29:01 -07:00
caryclark
1597628fa3 fix fuzzer bug 
Fix another fuzzer bug.

Some PathOps asserts only make sense if the incoming data is
well-behaved. Well-behaved tests set debugging state to
trigger these additional asserts.

Formalize this by creating macros similar to SkASSERT that
check to see if the assert should be skipped.

TBR=reed@google.com
BUG=629962
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2169863002

Review-Url: https://codereview.chromium.org/2169863002
 2016-07-21 05:48:44 -07:00
msarett
ec336deffb Trigger bots and upload images to Gold 
TBR=borenet@google.com
NOTRY=true
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2163993003

Review-Url: https://codereview.chromium.org/2163993003
 2016-07-21 05:38:49 -07:00
jcgregorio
59e3039fad docs: Add info on using blamer to the sheriffing docs. 
BUG=skia:
R=kjlubick
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2167803002
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=2167803002

Review-Url: https://codereview.chromium.org/2167803002
 2016-07-21 05:37:28 -07:00
mtklein
0c902473d6 Correct sRGB <-> linear everywhere. 
This trims the SkPM4fPriv methods down to just foolproof methods.
(Anything trying to build these itself is probably wrong.)

Things like Sk4f srgb_to_linear(Sk4f) can't really exist anymore,
at least not efficiently, so this refactor is somewhat more invasive
than you might think.  Generally this means things using to_4f() are
also making a misstep... that's gone too.

It also does not make sense to try to play games with linear floats
with 255 bias any more.  That hack can't work with real sRGB coding.

Rather than update them, I've removed a couple of L32 xfermode fast
paths.  I'd even rather drop it entirely...

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2163683002
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

Review-Url: https://codereview.chromium.org/2163683002
 2016-07-20 18:10:07 -07:00
msarett
456bf30d32 Revert of Refactor parsing and storage of SkGammas (patchset #8 id:280001 of https://codereview.chromium.org/2117773002/ ) 
Reason for revert:
Tests failing

Original issue's description:
> Refactor parsing and storage of SkGammas
>
> Benefits:
> (1) Parses and stores gamma tags in a single allocation.
> (2) Recognizes equal gamma tags to skip parsing work and
>     save memory.
>
> Non-Benefits:
> (1) Not less complicated.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2117773002
>
> Committed: https://skia.googlesource.com/skia/+/2ea944c2b710caf29d4795ac953bad14224796f7
> Committed: https://skia.googlesource.com/skia/+/959ccc1f3f49e1ddeb51c32c30ac4a2d94653856

TBR=reed@google.com,brianosman@google.com,mtklein@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review-Url: https://codereview.chromium.org/2171623002
 2016-07-20 16:14:17 -07:00
reed
ad7604b4a7 Have MakeFromImage fission the SkImage into a raster or a texture (patchset #1 id:1 of https://codereview.chromium.org/2167813002/ )" 
This reverts commit 3fb87201a1.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2164073004

TBR=robertphilips@google.com

Review-Url: https://codereview.chromium.org/2164073004
 2016-07-20 16:13:32 -07:00
reed
3fb87201a1 Revert of have MakeFromImage fission the SkImage into a raster or a texture (patchset #1 id:1 of https://codereview.chromium.org/2167813002/ ) 
Reason for revert:
broke ios build in chrome -- no_gpu?

Original issue's description:
> have MakeFromImage fission the SkImage into a raster or a texture
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2167813002
>
> Committed: https://skia.googlesource.com/skia/+/a61bfc6292edb990eae0b948648016550ef739a9

TBR=robertphillips@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review-Url: https://codereview.chromium.org/2168643003
 2016-07-20 15:38:15 -07:00
msarett
959ccc1f3f Refactor parsing and storage of SkGammas 
Benefits:
(1) Parses and stores gamma tags in a single allocation.
(2) Recognizes equal gamma tags to skip parsing work and
    save memory.

Non-Benefits:
(1) Not less complicated.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2117773002

Committed: https://skia.googlesource.com/skia/+/2ea944c2b710caf29d4795ac953bad14224796f7
Review-Url: https://codereview.chromium.org/2117773002
 2016-07-20 15:10:02 -07:00
reed
a61bfc6292 have MakeFromImage fission the SkImage into a raster or a texture 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2167813002

Review-Url: https://codereview.chromium.org/2167813002
 2016-07-20 14:22:37 -07:00
brianosman
dddbe380b0 Adding an SkColorSpace to SkImage_Gpu 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2165703003

Review-Url: https://codereview.chromium.org/2165703003
 2016-07-20 13:55:39 -07:00
caryclark
7d46f4af7d exclude unused functions when mac uses freetype (for pdf) 
R=bungeman@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2163833004

Review-Url: https://codereview.chromium.org/2163833004
 2016-07-20 13:15:51 -07:00
msarett
2aec3ffe32 Revert of Refactor parsing and storage of SkGammas (patchset #7 id:220001 of https://codereview.chromium.org/2117773002/ ) 
Reason for revert:
Broken bots.

Original issue's description:
> Refactor parsing and storage of SkGammas
>
> Benefits:
> (1) Parses and stores gamma tags in a single allocation.
> (2) Recognizes equal gamma tags to skip parsing work and
>     save memory.
>
> Non-Benefits:
> (1) Not less complicated.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2117773002
>
> Committed: https://skia.googlesource.com/skia/+/2ea944c2b710caf29d4795ac953bad14224796f7

TBR=reed@google.com,brianosman@google.com,mtklein@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review-Url: https://codereview.chromium.org/2159253005
 2016-07-20 12:58:52 -07:00
reed
cf5c846b41 remove dead methods now that we use specials exclusively for imagefilters 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2164763003

Review-Url: https://codereview.chromium.org/2164763003
 2016-07-20 12:28:40 -07:00
jvanverth
e499adf328 Use dFdx in Vulkan to address distance field issues. 
On Nexus Player and occasionally Nexus 5x we get transparent boxes around
paths. This appears to be because the dFdy call is not as accurate as
dFdx, which is the opposite of Mali 400. As Mali 400 is not supported with
Vulkan, we can go back to using dFdx in this case.

BUG=skia:5523
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2163213004

Review-Url: https://codereview.chromium.org/2163213004
 2016-07-20 12:22:14 -07:00
mtklein
566ea9b9fc Tune linear->sRGB constants to round-trip all bytes. 
I basically just ran a big 5-deep for-loop over the five constants here.
This is the first set of coefficients I found that round trips all bytes.
I suspect there are many such sets.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2162063003
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

Review-Url: https://codereview.chromium.org/2162063003
 2016-07-20 12:10:11 -07:00
msarett
2ea944c2b7 Refactor parsing and storage of SkGammas 
Benefits:
(1) Parses and stores gamma tags in a single allocation.
(2) Recognizes equal gamma tags to skip parsing work and
    save memory.

Non-Benefits:
(1) Not less complicated.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2117773002

Review-Url: https://codereview.chromium.org/2117773002
 2016-07-20 11:44:42 -07:00
reed
de996a0df7 re-disable save/restore peephole optimization 
BUG=skia:5548, 629408
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2163283002

Review-Url: https://codereview.chromium.org/2163283002
 2016-07-20 11:24:52 -07:00
dvonbeck
c526da94e4 SkLS now accepting nullptr for diffuse shader and normal source, now accurately handling alpha 
This CL's base is the CL for taking in a diffuse shader into SkLS on the API side: https://codereview.chromium.org/2064153002

BUG=skia:5502,skia:5517
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2132113002

Review-Url: https://codereview.chromium.org/2132113002
 2016-07-20 11:20:30 -07:00
kjlubick
f2944815e5 Add vulkan sdk to CIPD 
BUG=skia:5427
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2164953002

Review-Url: https://codereview.chromium.org/2164953002
 2016-07-20 10:18:49 -07:00
reed
158fabb071 re-chop if we fail on a big-bad-cubic 
BUG=629455
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2159223005

Review-Url: https://codereview.chromium.org/2159223005
 2016-07-20 10:06:59 -07:00
bungeman
1f790aaeef Improve assert reporting. 
Make SkASSERTF output readable.
Ensure the assert predicate is stringified once.
Make the abort code consistent.

TBR=reed
This doesn't change any public API, most of this should be privatized.

Review-Url: https://codereview.chromium.org/2161103002
 2016-07-20 09:49:10 -07:00
robertphillips
ea70c4bb22 Remove SkDevice::accessRenderTarget virtual 
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2167723002

Review-Url: https://codereview.chromium.org/2167723002
 2016-07-20 08:54:31 -07:00
egdaniel
c1be9bc169 Add GrVkRecycledResource subclass 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2167453003

Review-Url: https://codereview.chromium.org/2167453003
 2016-07-20 08:33:00 -07:00
fmenozzi
35a98c733f Add integer array uniforms to GL and Vulkan 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2163173005

Review-Url: https://codereview.chromium.org/2163173005
 2016-07-20 08:26:12 -07:00
bsalomon
487f8d385b Consolidate special case shape transformation logic in GrShapeTest. 
Enable all tests on all geometry types.

Add conversion of fill+miter-stroke->fill for rect geometries in GrShape.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2157013003

Review-Url: https://codereview.chromium.org/2157013003
 2016-07-20 07:15:44 -07:00
bungeman
fbbf01af04 Add iOS to platform_os_emoji. 
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2164783004

Review-Url: https://codereview.chromium.org/2164783004
 2016-07-20 07:15:16 -07:00
martina.kollarova
7b70156334 Fix context creation problems in dm 
Fixes these issues:

1. The glXCreateContextAttribsARB call seems to modify the
context_attrib parameter upon failure. Since context_attrib was static,
if it first tried to create an OpenGL 4.4 context and it failed, further
attempts to create a context with lower versions would also fail.

2. Getting an OpenGL 3.0 context was never tried.

3. Context creation for ES 3.0 was failing on my machine. Since ES 2.0
looks like the intended version from the surrounding code, I set it to
that. It could be rewritten to use a similar loop as standard OpenGL and
try from the highest version to the lowest.

BUG=skia:5403
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2147513002

Review-Url: https://codereview.chromium.org/2147513002
 2016-07-20 07:01:46 -07:00
reed
a2217ef965 use special-image for imagefilters and save/restore layer 
add special virtuals to device, in preparation for using them instead of bitmap for imagefilters

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2155933002

patch from issue 2155933002 at patchset 20001 (http://crrev.com/2155933002#ps20001)

use specialimages instead of bitmaps for imagefiltering

Review-Url: https://codereview.chromium.org/2155063002
 2016-07-20 06:04:34 -07:00
borenet
c8fcb9ce82 Add "Infra" to the builder_name_schema 
BUG=skia:4763
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2154433002

Review-Url: https://codereview.chromium.org/2154433002
 2016-07-20 05:54:50 -07:00
mtklein
53574b7236 Fix color order for 565,4444, and I8 samplers. 
10 GMs fixed on Linux/Win!

Also, don't unpremul I8 colors.  It's inconsistent with the other formats.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2166623002

Review-Url: https://codereview.chromium.org/2166623002
 2016-07-20 05:23:31 -07:00
kjlubick
e565450d0b Port FuzzPathop from chromium 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2148023002

Review-Url: https://codereview.chromium.org/2148023002
 2016-07-19 16:50:03 -07:00
reed
e51c356ae4 pre-land special methods on device 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2161233002

Review-Url: https://codereview.chromium.org/2161233002
 2016-07-19 14:33:20 -07:00
jvanverth
a3f3caccdf Stub in Mac viewer code. 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2164683002

patch from issue 2164683002 at patchset 1 (http://crrev.com/2164683002#ps1)

Review-Url: https://codereview.chromium.org/2167503002
 2016-07-19 14:17:20 -07:00