Commit Graph

14707 Commits

Author SHA1 Message Date
tfarina
f6e59b5035 Cleanup: Remove unused InstallNewHandler() function from SkGraphics.
BUG=None
TEST=None
R=bsalomon@google.com

Review URL: https://codereview.chromium.org/701813006
2014-11-05 07:20:51 -08:00
bsalomon
63b2196286 Workaround for PowerVR clear issue.
BUG=skia:

Review URL: https://codereview.chromium.org/701573002
2014-11-05 07:05:34 -08:00
bungeman
0737922ca2 Add suppression to valgrind.supp for fun:FcConfigEvaluate.
Any allocation under FcConfigValues will be 'lost'.
Update the valgrind suppression to reflect this.

Review URL: https://codereview.chromium.org/703893003
2014-11-05 06:44:11 -08:00
egdaniel
21402e3851 Bug fix for cull_line in SkDashPathEffect.
In cull_line we must also check if both points are the same. Otherwise we
fail the assert in the else "SkASSERT(dy && !dx)".

This is currently blocking the roll as it fails a webkit test.

BUG=skia:

Review URL: https://codereview.chromium.org/703783002
2014-11-05 05:02:27 -08:00
robertphillips
9f2251c73e Crop the fast path dashed lines to the cull rect
Without:

maxrss  loops   min     median  mean    max     stddev  samples         config  bench
  56M   1       13.3ms  13.6ms  13.6ms  14.2ms  2%      Ooooo.....      8888    GM_dashing5_bw
  56M   13      390us   417us   416us   459us   5%      ooooO..o.o      gpu     GM_dashing5_bw
  56M   1       13.4ms  13.9ms  14.1ms  15ms    3%      Oooo..ooOo      8888    GM_dashing5_aa
  56M   13      402us   421us   416us   425us   2%      Ooo.ooOOOO      gpu     GM_dashing5_aa

With:

  40M   1       1.53ms  1.54ms  1.54ms  1.55ms  0%      oo.O...o..      8888    GM_dashing5_bw
  40M   12      407us   412us   415us   445us   3%      ...Oo.....      gpu     GM_dashing5_bw
  40M   1       1.7ms   1.7ms   1.7ms   1.72ms  0%      o.O.......      8888    GM_dashing5_aa
  43M   13      405us   409us   409us   415us   1%      ooo.Ooo..o      gpu     GM_dashing5_aa

The GM images (including the new one) are the same with and without this CL.

BUG=428296

Review URL: https://codereview.chromium.org/699623003
2014-11-04 13:33:50 -08:00
jvanverth
0e66aaa503 DFText: fix placement of glyphs when we fall back to paths
Rendering a glyph with a path wants to place it at the (sx, sy) we get
as input to the method, but we add (dx, dy) for the clipRect check.
Hence, we need to subtract that out before we render the path.

Review URL: https://codereview.chromium.org/699283003
2014-11-04 13:32:53 -08:00
reed
7b8646669f update slides
BUG=skia:

Review URL: https://codereview.chromium.org/686853005
2014-11-04 13:24:47 -08:00
piotaixr
2bf8d09689 Revert of Override SkCanvas::drawImage() in SkDeferredCanvas and SkGPipe (patchset #8 id:140001 of https://codereview.chromium.org/613673005/)
Reason for revert:
The patch is breaking the telemetry blink build on some windows configurations

Original issue's description:
> Override SkCanvas::drawImage() in SkDeferredCanvas and SkGPipe
>
> Depend on https://codereview.chromium.org/663233002
>
> BUG=skia:2947
>
> Committed: https://skia.googlesource.com/skia/+/687732fe046c9cfec940f2d7f661cd97651d10a8
>
> Committed: https://skia.googlesource.com/skia/+/9bb7539a59ab15749fe26fecfec05330cffae684

BUG=skia:2947, 426708

Review URL: https://codereview.chromium.org/705633002
2014-11-04 13:21:41 -08:00
bungeman
e32ed6899c Additional baselines for 4b86bacb04.
The Nexus9 lacked a trybot at the time.
2014-11-04 15:28:51 -05:00
danakj
8f757f540a Add tracing to the SkCanvas drawFoo() methods to find long draw ops.
BUG=skia:3088

Review URL: https://codereview.chromium.org/702473004
2014-11-04 11:48:44 -08:00
mtklein
a30b2ee0da PictureRecordBench's benchmarks are no longer relevant with SkRecord.
BUG=skia:

Review URL: https://codereview.chromium.org/698163004
2014-11-04 11:14:48 -08:00
reed
36c9c11ed9 add more typeface methods to lua
BUG=skia:
NOTRY=True
TBR=

Review URL: https://codereview.chromium.org/697053004
2014-11-04 10:58:42 -08:00
bungeman
4b86bacb04 Allow all font weights on Android and respect overrides.
This removes the code which forces 400 and 700 weights only,
and also overrides the font weight with the configured weight.

Review URL: https://codereview.chromium.org/694533006
2014-11-04 10:54:32 -08:00
bungeman
47eda52e8f With https://chromium.googlesource.com/skia/+/43b8b36b20ae00e2d78421c4cda1f3f922983a20 blink_perf.layout regressed. It appears that the typeface cache is being missed. This is a partial revert of the Skia change which reverts the smallest amount of code to restore performance.
BUG=chromium:425566

Review URL: https://codereview.chromium.org/693213002
2014-11-04 10:27:35 -08:00
jvanverth
d86b07a8ff Fix PictureTest for new GPU veto
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/702733002
2014-11-04 08:50:16 -08:00
scroggo
ccae588932 Include SkTypes so that SK_SUPPORT_GPU is meaningful.
For the Android framework build, we get our defines from
SkUserConfig, rather than from the makefile, so we need to
include it (via SkTypes) before we can use our defines.

Fixes Android framework build.

Review URL: https://codereview.chromium.org/700893002
2014-11-04 08:11:07 -08:00
jvanverth
f7007b023d Enable distance field path rendering in Chrome.
- Add stat tracking for df-renderable paths
- Modify GPU rasterization veto to account for df-renderable paths
- Remove #define hiding df paths from Chromium and Android

BUG=skia:2935

Review URL: https://codereview.chromium.org/685113003
2014-11-04 07:59:01 -08:00
bungeman
bd1b76c40c Roll common to d7c2e2b9464.
Picks up code removal and changes to download_file.

https://skia.googlesource.com/common.git/+log/5eee100ab..d7c2e2b9464

Review URL: https://codereview.chromium.org/700763003
2014-11-04 07:55:41 -08:00
joshualitt
d1aa8ff870 removing setVertexArraySource from drawtarget
BUG=skia:

Review URL: https://codereview.chromium.org/699733002
2014-11-04 07:47:55 -08:00
scroggo
7a10fb6bea Separate JSON functions from DMWriteTask.
Add JsonWriter, which handles Json output from DM, in preparation for
adding json output for tests. This change should not affect behavior.

BUG=skia:2454

Review URL: https://codereview.chromium.org/702513003
2014-11-04 07:21:10 -08:00
robertphillips
b32f0ad891 Fix layer cache memory leak
The issue was that, with caching disabled, the layer cache code was removing layers outside of a purge (i.e., in unlock) but not correctly cleaning up the GrPictureInfo objects (as is done in purgePlot).

Review URL: https://codereview.chromium.org/703643002
2014-11-04 06:46:11 -08:00
reed
5698f91d60 remove dead SK_DISABLE_DASHING_OPTIMIZATION flag
BUG=skia:

Review URL: https://codereview.chromium.org/698003004
2014-11-04 05:17:39 -08:00
skia.buildbots
4ab22e38ca Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=

Review URL: https://codereview.chromium.org/698223002
2014-11-03 23:13:10 -08:00
reed
bb8a0ababa update slide content
BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/698563004
2014-11-03 22:32:08 -08:00
reed
1b6ab4417e add textblobs to lua
BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/688363003
2014-11-03 19:55:41 -08:00
joshualitt
2f5cb2fb95 update baselines and ignores for texture_domain
TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/697233003
2014-11-03 17:47:47 -08:00
mtklein
ecf987559b Turn SkTaskGroups back on.
Revert "Disable SkTaskGroup in SkMultiPictureDraw temporarily."
Revert "Revert harder, removing SkTaskGroup.cpp from core temporarily."

NOTREECHECKS=true

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/2100c5ed7a5e5470a04e7af7309d8bd3fc4249f7

Review URL: https://codereview.chromium.org/687263007
2014-11-03 17:41:08 -08:00
mtklein
db8d0e5bb0 Manually load CONDITION_VARIABLE methods on Windows, checking for failure (XP).
Tested by running DM on XP.  Before this patch, it fails at startup (even just out/Debug/dm --help).  Now it asserts for other reasons later on in user code, which is just fine by me.

The net effect is that SkTaskGroups will always be synchronous on XP.  That's not ideal, but a step up from crashing.

CQ_EXTRA_TRYBOTS=client.skia:Test-Win7-ShuttleA-HD2000-x86-Release-Trybot,Test-Win7-ShuttleA-HD2000-x86_64-Release-Trybot

BUG=skia:

Review URL: https://codereview.chromium.org/700683002
2014-11-03 17:25:54 -08:00
fmalita
7c11aadd82 Export (SK_API) SkSurfaceProps
R=reed@google.com

Review URL: https://codereview.chromium.org/693973003
2014-11-03 17:07:36 -08:00
tfarina
0c9acd5d2e Cleanup: Remove SimpleiOSApp xcode project file.
There is already an GYP version for it in:
https://skia.googlesource.com/skia/+/master/gyp/SimpleiOSApp.gyp

BUG=None
TEST=None
R=caryclark@google.com

Review URL: https://codereview.chromium.org/691133004
2014-11-03 15:10:49 -08:00
reed
615c593780 move SkTextBox into utils
BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/696293005
2014-11-03 14:55:40 -08:00
qiankun.miao
fb502f072f Optimize SkRect::sort()
This optimization can reduce comparison and assignments. For
geo_rect_sort benchmark, performance improved to 1.63us from 3.28us.

BUG=skia:

Review URL: https://codereview.chromium.org/695443005
2014-11-03 14:34:31 -08:00
bsalomon
87a94eb163 Rename and clarify semantics of GrContext::resolveRenderTarget.
Review URL: https://codereview.chromium.org/696293004
2014-11-03 14:28:32 -08:00
joshualitt
a702415d9e Temporary fix to remove drawrect call from GpuGL
BUG=skia:

Committed: https://skia.googlesource.com/skia/+/d4a5c2028117c100ccf44263c0118a0b4745f627

Review URL: https://codereview.chromium.org/694933002
2014-11-03 14:16:35 -08:00
jvanverth
ada68ef2dc Improve quality of distance field rendering
- Update spacing of LODs to get better results scaling up to 256
- Remove unnecessary "bolding" from dftext
- Add debug colors for dftext LODs

BUG=skia:2933,skia:2935

Review URL: https://codereview.chromium.org/703463002
2014-11-03 14:00:24 -08:00
derekf
a6ca5a002e Detect Mesa OpenGL ES
Original-Author: Henry Song <henrysong@samsung.com>

Review URL: https://codereview.chromium.org/700633002
2014-11-03 13:36:40 -08:00
bsalomon
0537f290c5 Revert changes to GrContext::resolveRenderTarget
TBR=joshualitt@google.com,egdaniel@google.com

Review URL: https://codereview.chromium.org/700483003
2014-11-03 13:32:00 -08:00
danakj
d239d42514 Add comments to SkRecordDraw to help people follow.
The calls to visit() to execute the SkRecord::Draw::operator() code path
is not clear to read, so adding some comments to help other new-comers
follow this through to the SkCanvas calls.

R=mtklein@chromium.org

Review URL: https://codereview.chromium.org/695403003
2014-11-03 12:43:30 -08:00
joshualitt
50408adfd2 Test factory uses the inorder draw buffer
BUG=skia:

Review URL: https://codereview.chromium.org/696353002
2014-11-03 12:31:15 -08:00
reed
9e233b2082 add bullets to slides
BUG=skia:
TBR=
NOTRY=True

Review URL: https://codereview.chromium.org/699723002
2014-11-03 12:18:24 -08:00
bsalomon
89c62980c1 Don't allow renderTarget==NULL to GrContext::clear() and friends.
Review URL: https://codereview.chromium.org/680413005
2014-11-03 12:08:42 -08:00
joshualitt
e672e9fca9 rebase and ignore dash cubics winnvpr
TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/691803005
2014-11-03 12:03:06 -08:00
joshualitt
0b9c015bd9 release expectations rebase
TBR=

BUG=skia:

Review URL: https://codereview.chromium.org/700613002
2014-11-03 11:36:40 -08:00
joshualitt
f002af791f rebase nvpr expectations
TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/688413004
2014-11-03 11:14:25 -08:00
bsalomon
bcaefb0622 Remove GrGLTexID
BUG=skia:2889

Review URL: https://codereview.chromium.org/695133003
2014-11-03 11:07:12 -08:00
joshualitt
882ee19a26 ignoring degenerat segments across all nvprm
TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/696373002
2014-11-03 10:51:42 -08:00
mtklein
3eeb156822 patch from issue 697743002
working

The key here was to get everything into a single library.  Our shared library build is the easiest way to do that.  Some light skimming online makes it look like perhaps cgo requires shared libraries, so that may be at play here too.

BUG=skia:

Review URL: https://codereview.chromium.org/698943002
2014-11-03 10:45:50 -08:00
egdaniel
37b4d866b1 Force input coverage to be only a byte in gpu shaders.
Prime coverage invariant output calculations with single component

BUG=skia:

Review URL: https://codereview.chromium.org/649783003
2014-11-03 10:07:07 -08:00
bsalomon
37dd331b20 Add class GrGLTextureRenderTarget for GL texture/rendertarget objects
BUG=skia:2889

Review URL: https://codereview.chromium.org/695813003
2014-11-03 08:47:23 -08:00
tfarina
89a9ecef9e Cleanup: Remove svn.py script.
We have moved on to a git world.

BUG=None
TEST=None
R=borenet@google.com

Review URL: https://codereview.chromium.org/691203002
2014-11-03 08:33:53 -08:00