Brian Osman
f750fbcb69
Simplify viewer's handling of backbuffer surface and color space
...
WindowContext still supports color spaces, but not other color
types. Any off-screen rendering is the app's responsibility.
This change also adds (working) F16 support to viewer. Note that
the previous 10-bit and FP16 support in WindowContext was broken.
There was no code to push the off-screen canvas to the window.
If you ever made it to the unreachable off-screen code path in
createSurface, it would have simply stopped drawing.
The decision to limit the window's gamut to sRGB is mostly driven
by my desire to add real-time editing of gamut. This design lets
us do that, without tearing down and rebuilding the window for
every change. An application could still supply a different gamut
via setDisplayParams and render directly to the back buffer with
proper color correction.
BUG=skia:
Change-Id: I94df35c7a42faee396009acc83683e40bb3c284d
Reviewed-on: https://skia-review.googlesource.com/8153
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Matt Sarett <msarett@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2017-02-08 17:34:05 +00:00
Jim Van Verth
d63c10225c
Minor fixes for the Linux viewer
...
BUG=skia:6091
Change-Id: Ia954c16610634e34f10bfe4273efc6677ca9563e
Reviewed-on: https://skia-review.googlesource.com/6618
Reviewed-by: Greg Daniel <egdaniel@google.com>
2017-01-05 18:51:47 +00:00
jvanverth
8c67ebe4c4
Clean up Xlib viewer
...
* Make event handling closer to GLFW's
* Fix Vulkan refreshing
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2226413002
Review-Url: https://codereview.chromium.org/2226413002
2016-08-11 07:03:04 -07:00
bsalomon
ccde4ab8e6
SW backend for viewer on Windows
...
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2182273002
Review-Url: https://codereview.chromium.org/2182273002
2016-07-27 08:50:12 -07:00
bsalomon
6c471f75b2
Add sw support to viewer on Linux.
...
This doesn't yet do anything with srgb/colorspace.
Replaces the --vulkan flag with --backend which takes 'gl', 'vk', or 'sw'.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2165813002
Review-Url: https://codereview.chromium.org/2165813002
2016-07-26 12:56:32 -07:00
bsalomon
d1bdd1fcbd
Use Windowing system-specific WindowContext factories.
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2169543002
Review-Url: https://codereview.chromium.org/2169543002
2016-07-26 12:02:51 -07:00
bsalomon
eeb4c387dd
Don't unnecessarily resize windows in sk_app on X
...
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2182163002
Review-Url: https://codereview.chromium.org/2182163002
2016-07-26 08:50:27 -07:00
liyuqian
2edb0f4a02
More accurate render time and continuous fresh
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2129613002
Review-Url: https://codereview.chromium.org/2129613002
2016-07-06 14:11:32 -07:00
jvanverth
063ece7184
Enable viewer in non-Vulkan builds
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2067023002
Committed: https://skia.googlesource.com/skia/+/746b792a9aad1230ab69158a51c49b2e5437d95b
Review-Url: https://codereview.chromium.org/2067023002
2016-06-17 09:29:14 -07:00
egdaniel
963632f686
Revert of Enable viewer in non-Vulkan builds (patchset #2 id:20001 of https://codereview.chromium.org/2067023002/ )
...
Reason for revert:
breaking compile bots
Original issue's description:
> Enable viewer in non-Vulkan builds
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2067023002
>
> Committed: https://skia.googlesource.com/skia/+/746b792a9aad1230ab69158a51c49b2e5437d95b
TBR=djsollen@google.com ,jvanverth@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review-Url: https://codereview.chromium.org/2072563002
2016-06-15 14:23:40 -07:00
jvanverth
746b792a9a
Enable viewer in non-Vulkan builds
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2067023002
Review-Url: https://codereview.chromium.org/2067023002
2016-06-15 13:44:15 -07:00
jvanverth
99eb6e2d5a
Add missing files for GL unix viewer.
...
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2023943004
Review-Url: https://codereview.chromium.org/2023943004
2016-05-31 09:39:20 -07:00
jvanverth
85f758c334
Add OpenGL support to Linux viewer
...
Also adds a command line option (--vulkan) to choose between
Vulkan and OpenGL.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2011473003
Committed: https://skia.googlesource.com/skia/+/10b3815a11c39b154ec7b74a2af43e019b50d48c
Review-Url: https://codereview.chromium.org/2011473003
2016-05-27 06:47:08 -07:00
kjlubick
0248bfd8d2
Revert of Add OpenGL support to Linux viewer (patchset #5 id:80001 of https://codereview.chromium.org/2011473003/ )
...
Reason for revert:
Build-Ubuntu-GCC-Arm7-Debug-Android_Vulkan is broken and this patch prevents the revert of the culprit
Original issue's description:
> Add OpenGL support to Linux viewer
>
> Also adds a command line option (--vulkan) to choose between
> Vulkan and OpenGL.
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2011473003
>
> Committed: https://skia.googlesource.com/skia/+/10b3815a11c39b154ec7b74a2af43e019b50d48c
TBR=egdaniel@google.com ,bsalomon@google.com,brianosman@google.com,jvanverth@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review-Url: https://codereview.chromium.org/2015213002
2016-05-27 06:20:10 -07:00
jvanverth
10b3815a11
Add OpenGL support to Linux viewer
...
Also adds a command line option (--vulkan) to choose between
Vulkan and OpenGL.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2011473003
Review-Url: https://codereview.chromium.org/2011473003
2016-05-27 05:47:00 -07:00
jvanverth
1d15596200
Add Xlib support to viewer
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=1999213002
Review-Url: https://codereview.chromium.org/1999213002
2016-05-23 13:13:36 -07:00