Commit Graph

558 Commits

Author SHA1 Message Date
Julia Lavrova
5ec1b8ff3f Adding skparagraphto public.bzl
Change-Id: Ia86963f743fc63a25b413344839f7e58e703b728
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/219861
Reviewed-by: Mike Klein <mtklein@google.com>
Reviewed-by: Herb Derby <herb@google.com>
Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2019-06-10 15:48:14 +00:00
Mike Klein
a4bb020636 add SkVMBuilders.* to DM deps in G3
Needed since https://skia-review.googlesource.com/c/skia/+/218041

Change-Id: I914c22e62d96b423041e4810a41b892789030510
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/218336
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
2019-06-04 18:42:23 +00:00
Jim Van Verth
8a9a371182 Reland "Added AutoreleasePool for managing pool memory in testing apps."
This is a reland of a36e089065

This is only active when Metal is enabled.

Original change's description:
> Added AutoreleasePool for managing pool memory in testing apps.
>
> This is only active on MacOS and iOS -- on other platforms it
> will do nothing as they have no need for autorelease pools.
>
> Bug: skia:8243
> Change-Id: Ib74968dab6e3455a72e726429832101d0d410076
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/217126
> Commit-Queue: Jim Van Verth <jvanverth@google.com>
> Reviewed-by: Brian Osman <brianosman@google.com>

Bug: skia:8243
Change-Id: I743a3dcc93b46387a6a330e855c2e8810b482544
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/217379
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
2019-05-31 15:40:01 +00:00
Mike Reed
7bf160e6d5 Revert "Revert "Experimental SkVideoDecoder, to wrap calls to ffmpeg""
fix google3 build (don't build the new gm)

This reverts commit 9cc53fa4bd.

Change-Id: I3de8aa4959f62a380f1d4aaf2b788d250775e194
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/214442
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
Auto-Submit: Mike Reed <reed@google.com>
2019-05-17 21:25:48 +00:00
Mike Klein
9509e04550 Revert "move encoders into codec_srcs"
This reverts commit 6a89611353.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> move encoders into codec_srcs
> 
> This is a stepping stone towards runtime registration.
> 
> This should work in concert with all the other CLs
> that are in the roll pipeline to get things building.
> 
> Change-Id: Id95f1e0bbea2f48f7b5fa438f4310f8db1d5b978
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/214083
> Auto-Submit: Mike Klein <mtklein@google.com>
> Reviewed-by: Mike Klein <mtklein@google.com>
> Commit-Queue: Mike Klein <mtklein@google.com>

TBR=mtklein@google.com,scroggo@google.com,brianosman@google.com

Change-Id: I4808404f0968e8a4deaf259a46e366152b7590fc
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/214100
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2019-05-15 21:57:59 +00:00
Mike Klein
9098c28d92 Revert "format public.bzl"
This reverts commit f4c2c8e31b.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> format public.bzl
> 
> Change-Id: Ie92b366e5d6e6fcb99c56e80f34e315ad1be8831
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/214093
> Reviewed-by: Mike Klein <mtklein@google.com>

TBR=mtklein@google.com

Change-Id: I66f11062ea21127e5d4c44eec932bd41f99d4f2d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/214099
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2019-05-15 21:57:31 +00:00
Mike Klein
f4c2c8e31b format public.bzl
Change-Id: Ie92b366e5d6e6fcb99c56e80f34e315ad1be8831
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/214093
Reviewed-by: Mike Klein <mtklein@google.com>
2019-05-15 20:54:00 +00:00
Mike Klein
6a89611353 move encoders into codec_srcs
This is a stepping stone towards runtime registration.

This should work in concert with all the other CLs
that are in the roll pipeline to get things building.

Change-Id: Id95f1e0bbea2f48f7b5fa438f4310f8db1d5b978
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/214083
Auto-Submit: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2019-05-15 20:40:57 +00:00
Florin Malita
ca449d5899 [skottie] Cleanup: relocate text sources
Move text-related sources to a dedicated 'text' subdirii, and drop
"Skottie" src prefix.

TBR=
Change-Id: I4f8d1633d649d371f76840405b6e567bd93f0c00
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/212724
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2019-05-08 14:36:07 +00:00
Florin Malita
1b1b657488 Fix .bzl skottie_lib_hdrs
TBR=
Change-Id: Id50b30077045477e4a6b0dfef3b9d950ac8f40f7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/212023
Reviewed-by: Florin Malita <fmalita@chromium.org>
Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2019-05-03 19:46:55 +00:00
Florin Malita
e4e9551cc8 Add explicit .bzl sources and headers lists for skottie/sksg
(to facilitate atomic repo updates)

Also remove some _INCLUDES (no longer used).

Change-Id: I9788838fb4b837b80a9ac637ab28760f9f4ccbf1
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/211994
Commit-Queue: Florin Malita <fmalita@chromium.org>
Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
2019-05-03 18:35:36 +00:00
Robert Phillips
6db27c28c6 Reduce opList splitting by default in Skia
Local Skia and DDL recording will always attempt to reduce opList splitting.
Android, Flutter, Google3 and non-DDL Chrome will not.

Note that this is a bit aggressive. Intermediate flushes based on memory usage have not yet been implemented.

The plan is to run this locally in Skia until the next Chrome branch and then enable it everywhere else (when intermediate flushes have been implemented).

OpList splitting reduction in Chrome is disabled in the following Chrome-side CL:

https://chromium-review.googlesource.com/c/chromium/src/+/1588756/ (Disable opList splitting reduction in Skia)

It is disabled in Android in:

https://googleplex-android-review.git.corp.google.com/c/platform/external/skia/+/7259923 (Update #defines to suppress Ganesh features in SkUserConfigManual.h)

It is disabled in Flutter and Google3 w/in this CL.

Change-Id: I59ff448d2c42629fab6cffccb2894d030c73431d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/211101
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
2019-05-01 15:24:08 +00:00
Brian Osman
ea236bf818 Move skcms.h to include/third_party/skcms
Add a shim to redirect until clients are updated

Change-Id: Ib43614e5620b1a24ca18187c1646a8ed1a9ee7a4
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/211003
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2019-04-29 15:02:45 +00:00
Mike Klein
f0a5369d0c cut SK_SAMPLES_FOR_X, simplify SK_?32_SHIFT
SK_SAMPLES_FOR_X doesn't do anything other than set the SK_?32_SHIFT
macros, so we can just set them instead, and further we can derive
everything we need from SK_R32_SHIFT.

Change-Id: I766d00c868da04939208353d09201f189a99c0c7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/210121
Commit-Queue: Hal Canary <halcanary@google.com>
Reviewed-by: Hal Canary <halcanary@google.com>
Auto-Submit: Mike Klein <mtklein@google.com>
2019-04-24 20:58:58 +00:00
Mike Klein
e11e5c162f AFAICT, only gm/etc1 uses third_party/etc1
The need for -Ithird_party/gif has already been
rewritten away, and we can do the same for etc1.

Change-Id: I97408652682b5ec406647108056e7a1ea6a56c29
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/210131
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2019-04-24 18:57:58 +00:00
Mike Klein
c0bd9f9fe5 rewrite includes to not need so much -Ifoo
Current strategy: everything from the top

Things to look at first are the manual changes:

   - added tools/rewrite_includes.py
   - removed -Idirectives from BUILD.gn
   - various compile.sh simplifications
   - tweak tools/embed_resources.py
   - update gn/find_headers.py to write paths from the top
   - update gn/gn_to_bp.py SkUserConfig.h layout
     so that #include "include/config/SkUserConfig.h" always
     gets the header we want.

No-Presubmit: true
Change-Id: I73a4b181654e0e38d229bc456c0d0854bae3363e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/209706
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Hal Canary <halcanary@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
2019-04-24 16:27:11 +00:00
Mike Klein
7ecad8791f add third_party/skcms to includes
This should allow us to #include "skcms.h".

Change-Id: Ie91f3af6145d78ffe0e433383a220fcb40452888
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/209780
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2019-04-23 11:18:36 +00:00
Mike Klein
3276d95876 rm src/compute
This is a stale, unused, untested snapshot.

Change-Id: I7c78c7c0f1637850724cbe8dcd99223a0ea592d2
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/209644
Commit-Queue: Mike Klein <mtklein@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Auto-Submit: Mike Klein <mtklein@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2019-04-22 17:35:53 +00:00
Mike Klein
299ea7b860 buildifier public.bzl
Change-Id: I1f7ff758801be30e377d08684b15af22daafde66
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/204134
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2019-03-27 19:00:04 +00:00
Mike Klein
7f95c293d7 split up skia_srcs() in public.bzl
This will let us smoothly switch over from using skia_srcs()
to using base_srcs() and gl_srcs(), listing things we need
from src/ports (and src/utils/mac/*.cpp) in BUILD instead.

Change-Id: I85dabd0dd620e1dcbcf4883ea8cfba3c111ce319
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/204126
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2019-03-27 17:23:48 +00:00
Mike Klein
b61e25b766 update DM_SRCS to build tools/HashAndEncode
Change-Id: Iab2ea4dfbff466f96f3f54d5150e12a8eb673518
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/204125
Auto-Submit: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2019-03-27 16:25:58 +00:00
Ben Wagner
c5ee499f2c Enable fontconfig fontmgr in public.bzl.
This enables the fontconfig font manager and tests it on unix like
platforms.

Change-Id: Ic0c2ad842e5f67fe50d100752d0eb239659d58e1
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203466
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2019-03-25 20:32:31 +00:00
Mike Klein
0498857cee fold sk_pixel_iter.h into ToolUtils
The single class in it is already in the ToolUtils namespace.

Change-Id: Iefa69690c4aa9b218784eb5edcfe7dba8721747b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/202314
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2019-03-20 18:22:15 +00:00
Mike Klein
ea3f014e2b sk_tool_utils -> ToolUtils, and git clang-format
sk_tool_utils doesn't really fit the naming convention
the rest of code under tools/ tends to use.

Change-Id: I45326a174101c6eb4b6149e9c742f658f2fd23b1
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/202313
Auto-Submit: Mike Klein <mtklein@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2019-03-20 18:05:42 +00:00
Mike Klein
0cffcbf97b de-Sk tools/font, and git clang-format
Change-Id: I0326eb9cc1e1e38b0fdc417567987a595f9021d2
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/202310
Commit-Queue: Mike Klein <mtklein@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Auto-Submit: Mike Klein <mtklein@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2019-03-20 17:36:52 +00:00
Mike Klein
88544fbe63 remove Sk prefix from CommandLineFlags
The command line flag package is tool-only, not part of Skia per se,
and does not need an Sk prefix to avoid naming conflicts.

And git clang-format.

Change-Id: Ida8477779e51750ed0475590ed2454841b23d6ea
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/202307
Auto-Submit: Mike Klein <mtklein@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2019-03-20 17:13:22 +00:00
Hal Canary
30c9eda01b SkShaper/public.bzl fix
Change-Id: Ie9a0b03cdc3e683689d8d8d078cf382adc101021
Reviewed-on: https://skia-review.googlesource.com/c/194423
Reviewed-by: Hal Canary <halcanary@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
2019-02-22 20:57:07 +00:00
Brian Osman
88cfc50bb6 Remove all references to jsoncpp (build scripts, DEPS, etc)
Bug: skia:
Change-Id: I3cec245e537eee3e6ceb0a4a52bad733c2c8746e
Reviewed-on: https://skia-review.googlesource.com/c/189842
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
2019-02-06 15:15:52 +00:00
Florin Malita
226ba98668 [skshaper] Export "primitive" sources in public.bzl
The harfbuzz backend is not usable in G3 at this point (missing
SkLoadICU header).  Making the primitive backend available to unblock
Skottie progress.

TBR=
Bug: skia:8696
Change-Id: I5aa1003f33926450f6c7512736cd71f9e1c80297
Reviewed-on: https://skia-review.googlesource.com/c/185600
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2019-01-21 17:29:33 +00:00
Florin Malita
6d415bce3a [skshaper] Build tweaks
Preps for building in Chromium & G3.

Change-Id: I4eb802f27aac7d3652c3b3ce427dcc758d6c31fe
Reviewed-on: https://skia-review.googlesource.com/c/185000
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2019-01-18 20:25:40 +00:00
Jim Van Verth
1676cb9282 Restore ETC1 compressed texture support.
Brings back GL ETC1 support and adds Vulkan support as well.

Bug: skia:8684
Change-Id: Ie65da0a3172793081f0e4072f161bfb9b14678bc
Reviewed-on: https://skia-review.googlesource.com/c/179724
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2019-01-15 19:56:28 +00:00
Sergey Ulanov
f3babcd0af Reland "Add SkFontMgr implementation for Fuchsia"
This is a reland of 309f1deddf

PS2 excludes the new file from Google3 build.

Original change's description:
> Add SkFontMgr implementation for Fuchsia
>
> The new SkFontMgr implementation will be used by Flutter and Chromium on
> Fuchsia.
>
> Change-Id: Ibd60a622282556e8557058e92fe865857f7024f9
> Reviewed-on: https://skia-review.googlesource.com/c/173800
> Reviewed-by: Ben Wagner <bungeman@google.com>
> Commit-Queue: Mike Klein <mtklein@google.com>

Change-Id: I1ea948b644dee4414b7a12a4b354f0a61a5e47ea
Reviewed-on: https://skia-review.googlesource.com/c/175431
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2018-12-07 01:47:05 +00:00
Mike Reed
1c3255dfea Revert "add SK_SUPPORT_LEGACY_TEXTBLOBBUILD_WITH_PAINT for google3"
This reverts commit 8b998b1e71.

Reason for revert: flag is now defined in google3

Original change's description:
> add SK_SUPPORT_LEGACY_TEXTBLOBBUILD_WITH_PAINT for google3
> 
> Bug: skia:
> Change-Id: I3a7e3555718d5e585d5288b7a70a24ee39d0d327
> Reviewed-on: https://skia-review.googlesource.com/c/172740
> Reviewed-by: Mike Reed <reed@google.com>

TBR=reed@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: skia:
Change-Id: I27130d7c332f1a06f939280a1485a3b82dc13188
Reviewed-on: https://skia-review.googlesource.com/c/172861
Reviewed-by: Mike Reed <reed@google.com>
2018-11-26 15:20:16 +00:00
Mike Reed
8b998b1e71 add SK_SUPPORT_LEGACY_TEXTBLOBBUILD_WITH_PAINT for google3
Bug: skia:
Change-Id: I3a7e3555718d5e585d5288b7a70a24ee39d0d327
Reviewed-on: https://skia-review.googlesource.com/c/172740
Reviewed-by: Mike Reed <reed@google.com>
2018-11-24 17:59:00 +00:00
Florin Malita
a8316554cb [skottie] Make animated image support generally available
Consolidate some helpers under skottie_utils, and update all related
tools to support animated images.

TBR=
Change-Id: If08e97143a11d9a414f3230a49ab4284c508b9d0
Reviewed-on: https://skia-review.googlesource.com/c/169342
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2018-11-10 19:52:19 +00:00
Mike Reed
0b50838beb Reland "remove guards for hinting in google3"
This reverts commit 2b5edcbe4e.

Reason for revert: moved these flags into Google3 BUILD

Original change's description:
> Revert "remove guards for hinting in google3"
> 
> This reverts commit 761f390470.
> 
> Reason for revert: more google3
> 
> Original change's description:
> > remove guards for hinting in google3
> > 
> > Bug: skia:
> > Change-Id: I99449d4688d33aec6fda56965984938050b7de3f
> > Reviewed-on: https://skia-review.googlesource.com/c/170102
> > Reviewed-by: Mike Reed <reed@google.com>
> 
> TBR=reed@google.com
> 
> Change-Id: I7482ad95a60676d1cb9cb2d52575c28c1bb5be33
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: skia:
> Reviewed-on: https://skia-review.googlesource.com/c/170106
> Reviewed-by: Mike Reed <reed@google.com>
> Commit-Queue: Mike Reed <reed@google.com>

TBR=reed@google.com

Change-Id: I6b53ea215730bd1794ad4665d01fa1b2de749173
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/c/170107
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2018-11-09 16:31:01 +00:00
Mike Reed
2b5edcbe4e Revert "remove guards for hinting in google3"
This reverts commit 761f390470.

Reason for revert: more google3

Original change's description:
> remove guards for hinting in google3
> 
> Bug: skia:
> Change-Id: I99449d4688d33aec6fda56965984938050b7de3f
> Reviewed-on: https://skia-review.googlesource.com/c/170102
> Reviewed-by: Mike Reed <reed@google.com>

TBR=reed@google.com

Change-Id: I7482ad95a60676d1cb9cb2d52575c28c1bb5be33
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/c/170106
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2018-11-09 16:24:11 +00:00
Mike Reed
761f390470 remove guards for hinting in google3
Bug: skia:
Change-Id: I99449d4688d33aec6fda56965984938050b7de3f
Reviewed-on: https://skia-review.googlesource.com/c/170102
Reviewed-by: Mike Reed <reed@google.com>
2018-11-09 14:50:57 +00:00
Mike Klein
dd650c40d1 disable unit tests in Google3
Many of them will start failing or crashing
once we set SK_DISABLE_READ_BUFFER there.

Alternatively, we could see if we can get away without
SK_DISABLE_READ_BUFFER.  It's small value compared to
the other flags.

Change-Id: I447cbd09f68afed81b4b1db8cc234abd22389d46
Reviewed-on: https://skia-review.googlesource.com/c/169762
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2018-11-08 20:19:10 +00:00
Florin Malita
dcc9d0668c [skottie] Add skottie_tool srcs/includes to public.bzl
Change-Id: I5f45a967031ff8d02ea24483807944be64ec5270
Reviewed-on: https://skia-review.googlesource.com/c/169823
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2018-11-08 20:08:03 +00:00
Mike Reed
9edbf42e75 Revert[4] "hide nested hinting enum"
This reverts commit 8e12cc6dfe.

Bug: skia:
Change-Id: Ice5e3480adad75ab77d97f7366495015f36b15a6
Reviewed-on: https://skia-review.googlesource.com/c/169520
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2018-11-08 16:33:04 +00:00
Mike Klein
54378230f8 Reland "simplify disabling effect deserialization"
This reverts commit 34d7a163a4.

Reason for revert: ok now?

Original change's description:
> Revert "simplify disabling effect deserialization"
>
> This reverts commit 5bbf790b5b.
>
> Reason for revert: flutter GN needs some love
>
> Original change's description:
> > simplify disabling effect deserialization
> >
> > Switch to a simple #define instead of conditional build targets.
> >
> > No one changes skia_enable_effects or skia_enable_effects_imagefilters,
> > so we can merge all that together back into :skia.
> >
> > Change-Id: I2985f95ee89149ddc687dc31f4c6bf35cb3a93c7
> > Reviewed-on: https://skia-review.googlesource.com/c/169220
> > Reviewed-by: Kevin Lubick <kjlubick@google.com>
> > Commit-Queue: Mike Klein <mtklein@google.com>
>
> TBR=mtklein@google.com,kjlubick@google.com
>
> Change-Id: I3b818418d303dbc6d2a926a19df64a68499f0ec3
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://skia-review.googlesource.com/c/169222
> Reviewed-by: Mike Klein <mtklein@google.com>
> Commit-Queue: Mike Klein <mtklein@google.com>

TBR=mtklein@google.com,kjlubick@google.com

Cq-Include-Trybots: skia.primary:Build-Debian9-Clang-arm-Release-Flutter_Android
Change-Id: I534346c3ef3561a871f1af6df976bfee0b48014a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/169640
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2018-11-08 14:26:52 +00:00
Mike Klein
5d58d09ae7 exclude RAW codec code from Google3 build
Disabling SK_CODEC_DECODES_RAW seems to have gone fine.

Change-Id: I81cefeb653d582872a4e25bba3d34c7ec1858db3
Reviewed-on: https://skia-review.googlesource.com/c/169680
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2018-11-08 14:13:18 +00:00
Mike Klein
34d7a163a4 Revert "simplify disabling effect deserialization"
This reverts commit 5bbf790b5b.

Reason for revert: flutter GN needs some love

Original change's description:
> simplify disabling effect deserialization
> 
> Switch to a simple #define instead of conditional build targets.
> 
> No one changes skia_enable_effects or skia_enable_effects_imagefilters,
> so we can merge all that together back into :skia.
> 
> Change-Id: I2985f95ee89149ddc687dc31f4c6bf35cb3a93c7
> Reviewed-on: https://skia-review.googlesource.com/c/169220
> Reviewed-by: Kevin Lubick <kjlubick@google.com>
> Commit-Queue: Mike Klein <mtklein@google.com>

TBR=mtklein@google.com,kjlubick@google.com

Change-Id: I3b818418d303dbc6d2a926a19df64a68499f0ec3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/169222
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2018-11-07 18:52:19 +00:00
Mike Klein
5bbf790b5b simplify disabling effect deserialization
Switch to a simple #define instead of conditional build targets.

No one changes skia_enable_effects or skia_enable_effects_imagefilters,
so we can merge all that together back into :skia.

Change-Id: I2985f95ee89149ddc687dc31f4c6bf35cb3a93c7
Reviewed-on: https://skia-review.googlesource.com/c/169220
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2018-11-07 18:20:23 +00:00
Mike Klein
b5c2cf84ca back out SK_CODEC_DECODES_RAW in Google3
This implies a pretty big code size dependency,
and I suspect we're not actually using it.

There can be some more BUILD-side cleanup after
this rolls in, I think, but this ought to be the
key to making everything else strippable dead code.

Change-Id: I30be8f4e8d83635eec80a16292200eeb9a43c778
Reviewed-on: https://skia-review.googlesource.com/c/169184
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2018-11-07 16:36:40 +00:00
Mike Klein
4991cd3441 move third_party/gif deps to codec_srcs
SkCodec is built as its own cc_library and is missing
these sources.  We've been getting away with it because
:skia is still built with alwayslink=1.

(After this CL, I think it need not be built with alwayslink=1
anymore.  We used to use SkTRegistry to hook in codecs, but
we only use that registration trick in tools now.)

Change-Id: I79dbfc0080a438ecf1ee00e532ff40cd6f45d5b3
Reviewed-on: https://skia-review.googlesource.com/c/169140
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2018-11-07 13:51:31 +00:00
Mike Reed
b435b6ce62 Revert "add flag for google3 build"
This reverts commit f9e3a13090.

Reason for revert: fix landed in google3 (I hope)

Original change's description:
> add flag for google3 build
> 
> Bug: skia:
> Change-Id: I5055404ea8790a847ed5b1003122301524fbdd3c
> Reviewed-on: https://skia-review.googlesource.com/c/165680
> Reviewed-by: Mike Reed <reed@google.com>

TBR=reed@google.com

Change-Id: I1c1e150f78e270cbcb765d0a09869e577092fd42
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/c/165682
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2018-10-27 15:38:16 +00:00
Mike Reed
f9e3a13090 add flag for google3 build
Bug: skia:
Change-Id: I5055404ea8790a847ed5b1003122301524fbdd3c
Reviewed-on: https://skia-review.googlesource.com/c/165680
Reviewed-by: Mike Reed <reed@google.com>
2018-10-27 14:34:46 +00:00
Ben Wagner
ec8c660544 Fix Bazel formatting.
No-Try: true
Change-Id: I8790bf93d3cfb29991677494e9527d4cd62aeaa9
Reviewed-on: https://skia-review.googlesource.com/c/165304
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2018-10-26 16:36:26 +00:00
Leon Scroggins III
86776076ee Reformat public.bzl
Change-Id: Ib446dd7d1d15974768f4ca64b87665f0a4e0d83e
Reviewed-on: https://skia-review.googlesource.com/c/165303
Commit-Queue: Leon Scroggins <scroggo@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Auto-Submit: Leon Scroggins <scroggo@google.com>
2018-10-26 15:22:56 +00:00
Leon Scroggins III
e93ec68a52 Reland "New GIF codec; new third_party/wuffs dep"
This reverts commit 7d1c9ec49f.

Bug: skia:8235
Change-Id: I830ba00a87e85c80f7e8583f5dfa105cd60029b2
Reviewed-on: https://skia-review.googlesource.com/c/165301
Commit-Queue: Leon Scroggins <scroggo@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Auto-Submit: Leon Scroggins <scroggo@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2018-10-26 13:53:04 +00:00
Mike Klein
0ade68cb08 we don't need two ways to disable lowp
SK_DISABLE_LOWP_RASTER_PIPELINE is a little nicer than the old define,
as when enabled we won't even build the lowp stages.

Change-Id: I51d6ca308d8efbb1fc5693d8091a1e6c6d243bf2
Reviewed-on: https://skia-review.googlesource.com/c/164628
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2018-10-24 11:25:18 +00:00
Mike Klein
b11ab578ad remove src/jumper
The distinction between SkJumper and SkRasterPipeline used
to be important, but it's no longer.  This CL moves everything
under src/jumper to the appropriate SkRasterPipeline file.

Change-Id: I1181fffafccb3dc4c4eb5f33b442c719ee370462
Reviewed-on: https://skia-review.googlesource.com/c/164627
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2018-10-24 11:15:58 +00:00
Kevin Lubick
8014c480f2 Add forgotton comma
Bug: skia:
Change-Id: Ic8d81bf343f2c37201ae60541065b7bfb615b150
Reviewed-on: https://skia-review.googlesource.com/c/163252
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-10-18 15:05:52 +00:00
Kevin Lubick
32dfdbe1af [canvaskit] Slice out SkPicture
Removes about 120k uncompressed, 40k gzipped

Bug: skia:
Change-Id: I7e0b404f18fc3c6d4ff6b01d2c9bcd657b7d5e07
Reviewed-on: https://skia-review.googlesource.com/c/163246
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2018-10-18 14:15:47 +00:00
Kevin Lubick
c921067eaa Add ignore to Bazel file
Bug: skia:
Change-Id: Ie17d02cd37e26c6f76e0003e1399a3d931b03379
Reviewed-on: https://skia-review.googlesource.com/c/162031
Reviewed-by: Mike Klein <mtklein@google.com>
2018-10-15 16:00:16 +00:00
Kevin Lubick
93faa6795b Make CCPR optional
This can reduce code size where CCPR is not supported (e.g. WebGL 1.0)

Drops 130k uncompressed, 50k compressed.

Bug: skia:
Change-Id: I8af7e681e1f3520a18e0c0d55e318dcf88206584
Reviewed-on: https://skia-review.googlesource.com/c/161041
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2018-10-10 20:20:01 +00:00
Brian Osman
5ea41fc89b Remove more SkColorSpaceXform (and friends)
- gammaencodedpremul GM was just demonstrating something that we
  understand well (and have much better testing for).
- readpixels GM was filled with workarounds for things that are no
  longer true (unpremul images, clamped F16).
- Other uses can be switched to SkConvertPixels trivially.
- Remove SkColorSpaceXformPriv and SkColorLookUpTable, all unused.
- Remove SkColorSpaceXform_skcms.cpp, no longer referenced by clients.

Bug: skia:
Change-Id: I7298bb53aa61b49ad1398ebc504d35c119fd5cf4
Reviewed-on: https://skia-review.googlesource.com/157153
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2018-09-26 22:30:05 +00:00
Hal Canary
00529a1771 SK_SUPPORT_LEGACY_DOCUMENT_FACTORY: clean up part 1/2
part 2 can follow after android patch lands.

Change-Id: If2a8135ac7384d84fd97d68933684ad8486d7471
Reviewed-on: https://skia-review.googlesource.com/156189
Auto-Submit: Hal Canary <halcanary@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
2018-09-21 19:50:40 +00:00
Mike Klein
60900b55f9 move skpipe to experimental
Nothing's using it except test tools.
I'd like to make that a bit clearer by getting it out of src.

Disabled the fuzzer.

Removed the bench so Android's building nanobench doesn't block this.

Bug: chromium:886713

Change-Id: I761f52c40171c27ff4b699409b32647e84684ec3
Reviewed-on: https://skia-review.googlesource.com/156240
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-09-21 17:20:25 +00:00
Ben Wagner
cc62b5d638 Fix bzl missing include dir.
No-Try: true
Change-Id: Ic9b22cf8859417b6f757124a12903e630af94feb
Reviewed-on: https://skia-review.googlesource.com/156003
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2018-09-20 20:30:48 +00:00
Ben Wagner
71a2e00784 Fix bzl formatting.
No-Try: true
Bug: skia:8210
Change-Id: Id1efcb23b58bfff024d04d2a9b1ed3e9dd89cba7
Reviewed-on: https://skia-review.googlesource.com/156001
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
Reviewed-by: Hal Canary <halcanary@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2018-09-20 20:10:28 +00:00
Hal Canary
23564b9249 SkDocument: Factories now located in SkPDFDocument.h and SkXPSDocument.h
Change-Id: I48e73b27e52511292c2c0bd51ef0168766f53a80
Reviewed-on: https://skia-review.googlesource.com/152780
Commit-Queue: Hal Canary <halcanary@google.com>
Reviewed-by: Mike Reed <reed@google.com>
2018-09-20 18:21:07 +00:00
Michael Ludwig
4f94ef6cbd Reland "Base Gradient FP Refactor"
This reverts commit 1ea5656a28.

Reason for revert: Fixed google3 build failure

Original change's description:
> Revert "Base Gradient FP Refactor"
> 
> This reverts commit 10f7a1e075.
> 
> Reason for revert: broke google3 roll
> Original change's description:
> > Base Gradient FP Refactor
> > 
> > --
> > 
> > Redefines how gradients will be written in the GPU back-end:
> > 
> > They are split into three fragment processor components: master, layout, and colorizer.
> > The layout FP is responsible for converting the fragment position into an interpolant value, t.
> > Each high-level gradient--such as linear, radial, etc.--are implemented solely in a layout FP.
> > The colorizer FP is responsible for converting t into a color.
> > The master FP invokes the layout, clamps t into the proper domain, and then invokes the colorizer.
> > GrGradientShader provides factory functions to create FP graphs from SkGradientShader instances.
> > This pattern is documented in gpu/gradients/README.md.
> > 
> > Goals for current CL
> > ====================
> > 
> > Outline the FP components by providing .fp implementations for the simplest gradients.
> > Defines a two-color single interval colorizer and a linear gradient layout, and the master effect.
> > A MakeLinear() factory function is provided that can convert SkGradientShaders that fit these constraints.
> > SkLinearGradient first attempts to use the new system, falling back to the original GrGradientEffect.
> > 
> > Future CLs
> > ==========
> > 
> > To keep the CL reviews manageable, additional dependent CLs will be added that gradually replace past functionality.
> > A CL for each layout will be defined.
> > CLs for the different analytic colorizer cases and the textured gradient case will be defined.
> > Once the new system supports all current layouts and colorizer capabilities, all old GPU gradient code will be removed.
> > After this clean-up, analytic colorization can hopefully be expanded to reduce the usage of textured gradients.
> > 
> > Bug: skia:
> > Change-Id: Iafe7b8b4071491a71c473babcd7bedda659150c1
> > Reviewed-on: https://skia-review.googlesource.com/148120
> > Commit-Queue: Michael Ludwig <michaelludwig@google.com>
> > Reviewed-by: Brian Salomon <bsalomon@google.com>
> 
> TBR=bsalomon@google.com,michaelludwig@google.com
> 
> Change-Id: Ib735e323795ac8874cb00b007a915786b50517a6
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: skia:
> Reviewed-on: https://skia-review.googlesource.com/153600
> Reviewed-by: Cary Clark <caryclark@google.com>
> Commit-Queue: Cary Clark <caryclark@google.com>

TBR=bsalomon@google.com,caryclark@google.com,michaelludwig@google.com

Change-Id: Ibf6ffbcb1af0dfbdac7317151aeb08f18f84c7fd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/153887
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
2018-09-12 20:20:32 +00:00
Mike Reed
52fd68762a Reland "remove legacy google3 flag"
This reverts commit 5f5dd18c28.

Reason for revert: google3 site updated

Original change's description:
> Revert "remove legacy google3 flag"
> 
> This reverts commit b8b2586dd3.
> 
> Reason for revert: broke google3
> 
> Original change's description:
> > remove legacy google3 flag
> > 
> > Bug: skia:
> > Change-Id: I9110f65e696a0c91c43954927dc05194797bf18c
> > Reviewed-on: https://skia-review.googlesource.com/152960
> > Reviewed-by: Mike Reed <reed@google.com>
> 
> TBR=reed@google.com
> 
> Change-Id: I2e0ff73c9ed340ef447de1606c618d2935fa8fae
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: skia:
> Reviewed-on: https://skia-review.googlesource.com/153002
> Reviewed-by: Mike Reed <reed@google.com>
> Commit-Queue: Mike Reed <reed@google.com>

TBR=reed@google.com

Change-Id: I07d7ded6e76012610df46e907e9303c1efd38e57
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/153120
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2018-09-10 19:00:15 +00:00
Mike Reed
5f5dd18c28 Revert "remove legacy google3 flag"
This reverts commit b8b2586dd3.

Reason for revert: broke google3

Original change's description:
> remove legacy google3 flag
> 
> Bug: skia:
> Change-Id: I9110f65e696a0c91c43954927dc05194797bf18c
> Reviewed-on: https://skia-review.googlesource.com/152960
> Reviewed-by: Mike Reed <reed@google.com>

TBR=reed@google.com

Change-Id: I2e0ff73c9ed340ef447de1606c618d2935fa8fae
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/153002
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2018-09-10 15:11:29 +00:00
Mike Reed
b8b2586dd3 remove legacy google3 flag
Bug: skia:
Change-Id: I9110f65e696a0c91c43954927dc05194797bf18c
Reviewed-on: https://skia-review.googlesource.com/152960
Reviewed-by: Mike Reed <reed@google.com>
2018-09-10 13:21:48 +00:00
Mike Reed
87ce0690b7 Revert "Revert "add flag to soften the blow of removing a legacy api for flutter""
Remember to delete the define from SkTypeface.h

This reverts commit b5f23f398d.

Bug: skia:
Change-Id: I63b2e395dac3850d352f38fdfee9ad751cdcace9
Reviewed-on: https://skia-review.googlesource.com/152590
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2018-09-07 20:58:54 +00:00
Mike Reed
a6dc5c54e6 Revert "fix g3 by adding legacy flag"
This reverts commit 2dc3129027.

Reason for revert: google3 call-sites have now been updated.

Original change's description:
> fix g3 by adding legacy flag
> 
> Bug: skia:7554
> Change-Id: I0aa766f58719b29340e5b225c74781b9884f30f6
> Reviewed-on: https://skia-review.googlesource.com/150242
> Auto-Submit: Mike Reed <reed@google.com>
> Reviewed-by: Mike Reed <reed@google.com>
> Commit-Queue: Mike Reed <reed@google.com>

TBR=stephana@google.com,reed@google.com

Change-Id: Ie23c180767bc9be56cb01b83e5df7eaa830d8d82
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:7554
Reviewed-on: https://skia-review.googlesource.com/150125
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2018-08-29 13:24:11 +00:00
Mike Reed
2dc3129027 fix g3 by adding legacy flag
Bug: skia:7554
Change-Id: I0aa766f58719b29340e5b225c74781b9884f30f6
Reviewed-on: https://skia-review.googlesource.com/150242
Auto-Submit: Mike Reed <reed@google.com>
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2018-08-28 21:10:43 +00:00
Mike Klein
9b7e99e394 also set Wno-implicit-fallthrough for Android
Change-Id: Idac532f2ac43ef2b702561635c8a6804ae89ff74
Reviewed-on: https://skia-review.googlesource.com/148809
Auto-Submit: Mike Klein <mtklein@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2018-08-22 22:01:11 +00:00
Ben Wagner
773151fec9 [Bazel] Enable GPU for Android build.
No-Try: true
Change-Id: Icaa25a6dde9d6ca1c75cba03b4250b6248f75952
Reviewed-on: https://skia-review.googlesource.com/147806
Commit-Queue: Mike Klein <mtklein@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2018-08-17 13:45:57 +00:00
Ben Wagner
b2c4ea6219 Move Views into Sample and Viewer.
What is left of the SkView system is used only by samples or viewer.
As a result, move it out of the Skia source tree and re-organize so it
is a bit easier to understand and use more shared code.

Move samplecode/ClockFaceView.cpp to samplecode/SampleTextEffects.cpp,
sice that's what's actually in it.

Move SkAnimTimer.h to tools/timer, since it's actually shared between gm
and samples.

Change-Id: I55dafd94c64e4f930ddbd19168e0f812af86c455
Reviewed-on: https://skia-review.googlesource.com/146161
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2018-08-09 15:25:32 +00:00
Brian Osman
e581aaad4d Remove picture_utils
More pointless hoop-jumping

Change-Id: I0123e0a1e27140a82ffe08ad88e0d115c060436d
Reviewed-on: https://skia-review.googlesource.com/146449
Commit-Queue: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Auto-Submit: Brian Osman <brianosman@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2018-08-09 14:14:17 +00:00
Ben Wagner
722efde79c [Bazel] Add lottie as dm source.
Depends on internal CL.

No-Try: true
Change-Id: I816e003b36799c5f188189bba6b0d0cacd933c45
Reviewed-on: https://skia-review.googlesource.com/144643
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2018-08-01 13:53:00 +00:00
Benjamin Barenblat
fd10d170ee Set -Wno-implicit-fallthrough when building for iOS
Change-Id: I281336e4b0639c25ea98402b5dd194aa21bf560f
Reviewed-on: https://skia-review.googlesource.com/144611
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2018-07-31 21:27:56 +00:00
Ben Wagner
b303a427c0 [Bazel] Reformat public.bzl with buildifier.
Bug: skia:8210
No-Try: true
Change-Id: I259fa3ee0bccdfb8999366596a0b210626ee26aa
Reviewed-on: https://skia-review.googlesource.com/144501
Commit-Queue: Mike Klein <mtklein@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2018-07-31 17:10:00 +00:00
Ben Wagner
9396bc3fc6 [Bazel] Omit new test that causes infinite loop in libjpeg-turbo.
This test was added in
https://skia-review.googlesource.com/c/skia/+/129459, but the fix is not
yet in a libjpeg-turbo release.

No-Try: true
Change-Id: Ib7dce7a022934918f9f2e3467849d3e81cbf14cd
Reviewed-on: https://skia-review.googlesource.com/137703
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Leon Scroggins <scroggo@google.com>
Commit-Queue: Leon Scroggins <scroggo@google.com>
2018-06-26 20:15:12 +00:00
Ben Wagner
37a06c063c Reland "Implement onMakeClone(const SkFontArguments& args) in class SkTypeface_fontconfig."
This reverts commit cce82d2b7c.

Reason for revert: Just add suppression.

Original change's description:
> Revert "Implement onMakeClone(const SkFontArguments& args) in class SkTypeface_fontconfig."
>
> This reverts commit 96b1ecc25d.
>
> Reason for revert: Breaking Google3, I think
>
> Original change's description:
> > Implement onMakeClone(const SkFontArguments& args) in class SkTypeface_fontconfig.
> >
> > Create FontMgrFontConfigTest.cpp file to test the above function.
> >
> > Change-Id: I7716355f702af3d6f25574305914f0b82a4147ce
> > Reviewed-on: https://skia-review.googlesource.com/137133
> > Reviewed-by: Ben Wagner <bungeman@google.com>
> > Commit-Queue: Ben Wagner <bungeman@google.com>
>
> TBR=bungeman@google.com,herb@google.com,brucewang@google.com
>
> Change-Id: I665de46d379f1b533358f0be644814aa4bfffb33
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://skia-review.googlesource.com/137240
> Reviewed-by: Kevin Lubick <kjlubick@google.com>
> Commit-Queue: Kevin Lubick <kjlubick@google.com>

TBR=bungeman@google.com,herb@google.com,kjlubick@google.com,brucewang@google.com

Change-Id: I41f0e4505ed0579a77a56212898e9a6caf6f1ed5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/137260
Commit-Queue: Ben Wagner <bungeman@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
2018-06-22 21:12:58 +00:00
Mike Klein
b056e7f77f exclude src/compute in Google3
Change-Id: I665d21166143d89e575bed0f5b485a69967c1360
Reviewed-on: https://skia-review.googlesource.com/136065
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Mike Klein <mtklein@google.com>
2018-06-20 13:46:19 +00:00
Mike Klein
53418da8c6 exclude _none_imagefilters.cpp in Google3
Change-Id: Ib7159dbba6f58c0d621492a28920f9388bde29e1
Reviewed-on: https://skia-review.googlesource.com/136064
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Mike Klein <mtklein@chromium.org>
2018-06-20 13:36:07 +00:00
Brian Osman
229f4d93c1 srgb config is gone. Stop testing it.
Should fix Google3 roll.

Change-Id: I986f442f2f36048e2322b6360a39221da2cb176b
Reviewed-on: https://skia-review.googlesource.com/133301
Commit-Queue: Brian Osman <brianosman@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Auto-Submit: Brian Osman <brianosman@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2018-06-08 13:37:11 +00:00
Mike Klein
db537605b5 exclude cgms.cpp from DM on Google3 build
Having a mix of C and C++ sources in DM makes setting build flags
tricky.  This removes the C sources.  I don't think it's important
to run these C-based GMs in Google3... I don't even really think
it's terribly important to run DM there at all.

Change-Id: I2c2653ee15981f9a63965fb8b7e483a5c5e94830
Reviewed-on: https://skia-review.googlesource.com/131441
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2018-06-01 15:31:16 +00:00
Robert Phillips
e61ba84299 Add new DDL helper files to public.bzl
Change-Id: I9243b5ed143ff7e688cd26fb8649676286a65794
Reviewed-on: https://skia-review.googlesource.com/130780
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2018-05-30 12:53:08 +00:00
Greg Daniel
0e6e651a97 Remove SK_SUPPORT_LEGACY_BACKEND_OBJECTS from public.bzl.
Bug: skia:
Change-Id: Ie8b874bfb53018c5a854eebafca41233281eaf4c
Reviewed-on: https://skia-review.googlesource.com/125753
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2018-05-03 18:14:41 +00:00
Mike Klein
1b6eb9900d disable -Wself-assign in Google3
Change-Id: I2ecacd112474f1174ff8454208bf0d3c6f4c20f4
Reviewed-on: https://skia-review.googlesource.com/121664
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-04-16 19:59:05 +00:00
Robert Phillips
ba375a8884 Add SK_SUPPORT_LEGACY_BACKEND_OBJECTS
This relies on the Chrome CL: https://chromium-review.googlesource.com/c/chromium/src/+/999796 (Add SK_SUPPORT_LEGACY_BACKEND_OBJECTS to SkUserConfig.h) landing first.

Change-Id: Ie0a2b7b84cc02e46957765a0a7d6444a5320769d
Reviewed-on: https://skia-review.googlesource.com/119140
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2018-04-12 14:56:10 +00:00
Ben Wagner
97182cc8f6 Add color fonts.
BUG=skia:7624

Change-Id: I68a6bb4c6fa541ffad565d970438d93ff1bd8ed6
Reviewed-on: https://skia-review.googlesource.com/109521
Commit-Queue: Ben Wagner <bungeman@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Reviewed-by: Herb Derby <herb@google.com>
Reviewed-on: https://skia-review.googlesource.com/116541
Reviewed-on: https://skia-review.googlesource.com/116984
Reviewed-by: Ben Wagner <bungeman@google.com>
2018-03-28 20:14:44 +00:00
Ben Wagner
3560b58de3 Revert "Add color fonts."
This reverts commit d3b933f3e0.

Reason for revert: we're not mirroring experimental/ everywhere.

Original change's description:
> Add color fonts.
> 
> BUG=skia:7624
> 
> Change-Id: I1d0974282adce2fd7b13a003309e63593b6e1a9c
> Reviewed-on: https://skia-review.googlesource.com/109521
> Commit-Queue: Ben Wagner <bungeman@google.com>
> Reviewed-by: Mike Klein <mtklein@google.com>
> Reviewed-by: Herb Derby <herb@google.com>
> Reviewed-on: https://skia-review.googlesource.com/116541

TBR=mtklein@google.com,bungeman@google.com,herb@google.com

Change-Id: Ic2d763244cbce663a23eb53321ac45201c466501
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:7624
Reviewed-on: https://skia-review.googlesource.com/116680
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2018-03-27 18:16:04 +00:00
Mike Klein
83ee463c31 exclude SkColorSpaceXform_skcms.cpp from Google3
We're globbing it up right now, but can't build without skcms.h.

Change-Id: I2a9b29b7a91a0c8cccc73b1e20f64c1f6181eabd
Reviewed-on: https://skia-review.googlesource.com/116623
Reviewed-by: Brian Osman <brianosman@google.com>
2018-03-27 17:25:23 +00:00
Ben Wagner
d3b933f3e0 Add color fonts.
BUG=skia:7624

Change-Id: I1d0974282adce2fd7b13a003309e63593b6e1a9c
Reviewed-on: https://skia-review.googlesource.com/109521
Commit-Queue: Ben Wagner <bungeman@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Reviewed-by: Herb Derby <herb@google.com>
Reviewed-on: https://skia-review.googlesource.com/116541
2018-03-27 16:49:14 +00:00
Ben Wagner
6ce482aed4 Remove include/svg from public.bzl includes.
It's strange to include it since public.bzl currently excludes all of
the source files that define the symbols declared in the headers in this
directory.

This also fixes the two files which needed to put some of these includes
behind the SK_XML macro. The public.bzl never defines the SK_XML macro,
so there is no need to ever have the include/svg directory on the
include path, even for DM.

Change-Id: I6cc18908aa16cfc914ed9b7ab174d03a0a242aa4
Reviewed-on: https://skia-review.googlesource.com/116547
Commit-Queue: Ben Wagner <bungeman@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2018-03-27 16:36:29 +00:00
Ben Wagner
e579f1e70f [Bazel] Add missing include dir.
No-Try: true
Change-Id: If27fb8532d186f96d5cf15f4099113713319693d
Reviewed-on: https://skia-review.googlesource.com/116525
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2018-03-26 22:44:34 +00:00
Ben Wagner
fb4487b06a External part of internal cl/190527962
No-Try: true
Change-Id: Ie091e44491757aa7a86db4e6b2bbf8b426182c9a
Reviewed-on: https://skia-review.googlesource.com/116442
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2018-03-26 21:48:50 +00:00
Ben Wagner
d10e0d575b Remove src/xml/*.h from DM in public.bzl.
These are already present from includeing headers in sources.

Change-Id: I7f3046596d6e4f5075c5a65e5e211de5d33415f5
Reviewed-on: https://skia-review.googlesource.com/116441
Commit-Queue: Ben Wagner <bungeman@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2018-03-26 21:35:08 +00:00
Ben Wagner
4ccf49c1bf Add the xml and svg model code to DM in public.bzl.
This also removes several include directories which no longer exist, as
well as updates comments on why the xml and svg output code are not
currently built as part of the base library.

Change-Id: I27464bb09d8dd9c03d187662badb28c3ca558008
Reviewed-on: https://skia-review.googlesource.com/116540
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2018-03-26 20:18:46 +00:00
Jim Van Verth
af78a94217 Revert "Add color fonts."
This reverts commit c912d6133c.

Reason for revert: Causing TSAN issues.

Original change's description:
> Add color fonts.
> 
> BUG=skia:7624
> 
> Change-Id: Id2b7449048591892ff802484d5e3745a7e1402bb
> Reviewed-on: https://skia-review.googlesource.com/109521
> Commit-Queue: Ben Wagner <bungeman@google.com>
> Reviewed-by: Mike Klein <mtklein@google.com>
> Reviewed-by: Herb Derby <herb@google.com>

TBR=mtklein@google.com,bungeman@google.com,herb@google.com

Change-Id: I2ccd1f00e91bb92b7059323c95da0dd3de954164
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:7624
Reviewed-on: https://skia-review.googlesource.com/116141
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
2018-03-23 14:39:51 +00:00
Ben Wagner
c912d6133c Add color fonts.
BUG=skia:7624

Change-Id: Id2b7449048591892ff802484d5e3745a7e1402bb
Reviewed-on: https://skia-review.googlesource.com/109521
Commit-Queue: Ben Wagner <bungeman@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Reviewed-by: Herb Derby <herb@google.com>
2018-03-22 20:55:05 +00:00
Mike Reed
e489c9f03d rm guard for google3
Bug: skia:
Change-Id: I86495e0fefff2dbd34e39e3a0be891bfc62ec08b
Reviewed-on: https://skia-review.googlesource.com/114581
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2018-03-15 20:18:19 +00:00
Mike Reed
1be1f8d097 hide SkBlurMaskFilter and SkBlurQuality
SK_SUPPORT_LEGACY_BLURMASKFILTER

Bug: skia:
Change-Id: Ic3e27e08e6e3cd2ffc1cd13b044e197bebc96236
Reviewed-on: https://skia-review.googlesource.com/113940
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
2018-03-14 17:27:36 +00:00
Ben Wagner
aa567aba51 Remove dm excludes from public.bzl.
Several text tests are excluded from dm, presumably because previously
there were no fonts. Now that there are, these tests pass.

Change-Id: I5cb30cc5658ab77294ac4479902c932ddf490289
Reviewed-on: https://skia-review.googlesource.com/112721
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2018-03-07 15:57:40 +00:00
Ben Wagner
5fa27116cd Add "--nonativeFonts" to public.bzl for running dm.
We don't know under what conditions dm will run or which fontmgr will be
available, so run it with its own default portable font manager.

Change-Id: I050e0b8e3d7c265ca7ef6d1b64b2fb9dc8350e82
Reviewed-on: https://skia-review.googlesource.com/112600
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2018-03-06 19:02:31 +00:00
Mike Klein
33d077dc91 prepare Google3 for the return of SkOpts_hsw.cpp
Will follow up with a Google3 CL to hook up the other side.

c.f. https://skia-review.googlesource.com/c/skia/+/110641
for why.  That CL takes care of Chromium and Android inline.

Change-Id: I0a83ced632f5f3079174a4d4b29c1ecd523d67de
Reviewed-on: https://skia-review.googlesource.com/110760
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2018-02-27 18:57:50 +00:00
Ben Wagner
483c772cfd Add nativeFonts flag to Viewer.
This moves DMFontMgr and several related files which are tightly related
to fonts into tools/fonts, moves some flags around to prevent
duplication, and adds the nativeFonts handling to Viewer.

Change-Id: Id1bdad708a6b74319ac5ac9adfe21025db4ca0b2
Reviewed-on: https://skia-review.googlesource.com/108904
Commit-Queue: Ben Wagner <bungeman@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
2018-02-21 03:31:14 +00:00
Mike Klein
5ab827c50b Reland "remove third_party/etc1"
This is a reland of 9d7a73527a.

Original change's description:
> remove third_party/etc1
> 
> Nothing seems to reference it.
> 
> Change-Id: Ib009a7dc33d31439b11588758015a07485f56eaa
> Reviewed-on: https://skia-review.googlesource.com/99861
> Reviewed-by: Mike Klein <mtklein@chromium.org>
> Commit-Queue: Mike Klein <mtklein@chromium.org>

Change-Id: I3a6428074896c7b3c80cb23db61f70d7cb0c785f
Reviewed-on: https://skia-review.googlesource.com/108460
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2018-02-20 16:52:43 +00:00
Greg Daniel
76546506d1 Remove unused SkpSkGrTest.cpp
Doesn't look like this is used or even built anymore. If we ever find a
future use for it we can add it back.

Bug: skia:
Change-Id: I736df90d984756b2dd14d95e8e5b4f3ec72ce8f7
Reviewed-on: https://skia-review.googlesource.com/105602
Reviewed-by: Cary Clark <caryclark@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2018-02-08 15:05:44 +00:00
Mike Klein
5bcef359b2 Revert "remove third_party/etc1"
This reverts commit 9d7a73527a.

Reason for revert: still used by Fiber in Google3

Original change's description:
> remove third_party/etc1
> 
> Nothing seems to reference it.
> 
> Change-Id: Ib009a7dc33d31439b11588758015a07485f56eaa
> Reviewed-on: https://skia-review.googlesource.com/99861
> Reviewed-by: Mike Klein <mtklein@chromium.org>
> Commit-Queue: Mike Klein <mtklein@chromium.org>

TBR=mtklein@chromium.org,robertphillips@google.com

Change-Id: I12b950931f0680576faefd1907a26afe22cf680f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/100460
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2018-01-26 22:41:35 +00:00
Mike Klein
9d7a73527a remove third_party/etc1
Nothing seems to reference it.

Change-Id: Ib009a7dc33d31439b11588758015a07485f56eaa
Reviewed-on: https://skia-review.googlesource.com/99861
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2018-01-26 20:15:50 +00:00
Ben Wagner
b7e8011fec [bazel] Add third_party to skia_all_hdrs
No-Try: true
Change-Id: I15d274bb7c63a3ddfd1d9143b472454cffcf0644
Reviewed-on: https://skia-review.googlesource.com/99541
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Mike Klein <mtklein@chromium.org>
2018-01-24 23:45:11 +00:00
Mike Reed
ba00d226c3 remove SK_SUPPORT_LEGACY_RECTMAKELARGEST flag
Bug: skia:
Change-Id: Ic36f1282d23f3f92b250e44685149505cad74bf2
Reviewed-on: https://skia-review.googlesource.com/93423
Reviewed-by: Mike Reed <reed@google.com>
2018-01-11 13:11:02 +00:00
Mike Reed
274218ef01 move largest apis into private
Related to https://skia-review.googlesource.com/c/skia/+/91860

Bug: skia:
Change-Id: Ia8fd981b422bbab75541b078277d2e09e1fc9d41
Reviewed-on: https://skia-review.googlesource.com/91940
Reviewed-by: Brian Salomon <bsalomon@google.com>
2018-01-08 20:42:27 +00:00
Mike Reed
1b3bd9cfc5 remove guard for new memory porting layer
Bug: skia:
Change-Id: I14f1b421bc4055ea5a7c22735b2605eb883e4f81
Reviewed-on: https://skia-review.googlesource.com/91462
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2018-01-06 21:28:54 +00:00
Mike Reed
8dc8dbc821 begin cleanup of malloc porting layer
1. Merge some of the allocators into sk_malloc_flags by redefining a flag to mean zero-init
2. Add more private helpers to simplify our call-sites (and handle some overflow mul checks)
3. The 2-param helpers rely on the saturating SkSafeMath::Mul to pass max_size_t as the request,
which should always fail.

Bug:508641
Change-Id: I322f1e6ed91113467e0fdb12c91c3dad33d890c8
Reviewed-on: https://skia-review.googlesource.com/90940
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
Reviewed-by: Stephan Altmueller <stephana@google.com>
2018-01-05 21:29:35 +00:00
Mike Reed
7b81a94b06 Revert "add flag to fix google3"
This reverts commit 3eec5f322b.

Reason for revert: google3 updated

Original change's description:
> add flag to fix google3
> 
> Bug: skia:
> Change-Id: Icbaf4737d4f8d45c969811cebc53da20b0f5d954
> Reviewed-on: https://skia-review.googlesource.com/88422
> Reviewed-by: Mike Reed <reed@google.com>

TBR=reed@google.com

Change-Id: I07f9334d0531cf18a6e76a6f9177808ba3310a09
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/88600
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2017-12-21 19:25:53 +00:00
Mike Reed
3eec5f322b add flag to fix google3
Bug: skia:
Change-Id: Icbaf4737d4f8d45c969811cebc53da20b0f5d954
Reviewed-on: https://skia-review.googlesource.com/88422
Reviewed-by: Mike Reed <reed@google.com>
2017-12-21 14:37:36 +00:00
Mike Klein
6613cc5186 GOOGLE3 -> SK_BUILD_FOR_GOOGLE3
This is more consistent with our other SK_BUILD_FOR_... macros,
and less likely to collide with other preprocessor logic.

(Luckily, this was defined in public.bzl, so we can do this
all in one CL in the Skia repo.)

Change-Id: I5f232888288c9c53fad445545d983d0fb0b4add8
Reviewed-on: https://skia-review.googlesource.com/86940
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2017-12-19 14:42:16 +00:00
Mike Reed
2e3f2e9b48 Revert "Revert "remove SK_SUPPORT_LEGACY_PDF_PIXELSERIALIZER dead code""
This reverts commit 800f5541bb.

Reason for revert: google3 updated

Original change's description:
> Revert "remove SK_SUPPORT_LEGACY_PDF_PIXELSERIALIZER dead code"
> 
> This reverts commit 7f846f273c.
> 
> Reason for revert: missed callsite in google3
> 
> Original change's description:
> > remove SK_SUPPORT_LEGACY_PDF_PIXELSERIALIZER dead code
> > 
> > Bug: skia:
> > Change-Id: Ia88f3e2fdf6d5c6e5128eaefda0d68c7042ae7a2
> > Reviewed-on: https://skia-review.googlesource.com/85500
> > Commit-Queue: Mike Reed <reed@google.com>
> > Reviewed-by: Hal Canary <halcanary@google.com>
> 
> TBR=halcanary@google.com,reed@google.com
> 
> Change-Id: I232dc24831bd8d52e9cbbc7ee58177af0617574a
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: skia:
> Reviewed-on: https://skia-review.googlesource.com/85600
> Reviewed-by: Mike Reed <reed@google.com>
> Commit-Queue: Mike Reed <reed@google.com>

TBR=halcanary@google.com,reed@google.com

Change-Id: I6ccd032caf87020cba8d515ffb25d07b87267363
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/86101
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2017-12-15 20:43:10 +00:00
Mike Reed
800f5541bb Revert "remove SK_SUPPORT_LEGACY_PDF_PIXELSERIALIZER dead code"
This reverts commit 7f846f273c.

Reason for revert: missed callsite in google3

Original change's description:
> remove SK_SUPPORT_LEGACY_PDF_PIXELSERIALIZER dead code
> 
> Bug: skia:
> Change-Id: Ia88f3e2fdf6d5c6e5128eaefda0d68c7042ae7a2
> Reviewed-on: https://skia-review.googlesource.com/85500
> Commit-Queue: Mike Reed <reed@google.com>
> Reviewed-by: Hal Canary <halcanary@google.com>

TBR=halcanary@google.com,reed@google.com

Change-Id: I232dc24831bd8d52e9cbbc7ee58177af0617574a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/85600
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2017-12-15 05:24:09 +00:00
Mike Reed
7f846f273c remove SK_SUPPORT_LEGACY_PDF_PIXELSERIALIZER dead code
Bug: skia:
Change-Id: Ia88f3e2fdf6d5c6e5128eaefda0d68c7042ae7a2
Reviewed-on: https://skia-review.googlesource.com/85500
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Hal Canary <halcanary@google.com>
2017-12-15 04:28:07 +00:00
Mike Reed
a4daf19319 Moving extra options/parameters into PDFMetadata
Bug: skia:
Change-Id: I29aa69e5765a7f8ba05b0361912d1f5276d77de3
Reviewed-on: https://skia-review.googlesource.com/84501
Reviewed-by: Hal Canary <halcanary@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2017-12-14 21:20:27 +00:00
Mike Klein
c1ff9168c7 clean up float-cast-overflow blacklist
These should be free of overflows now.

Bug: skia:7052
Change-Id: I05118fb8f565ffb0d973b6d93a8cd8d8e27f31a9
Reviewed-on: https://skia-review.googlesource.com/84561
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2017-12-13 20:09:10 +00:00
Brian Salomon
b3ce76eba7 Fix Google3 link errors(?)
Change-Id: If2d689dd34065fa5e71808170164adcb97580c75
Reviewed-on: https://skia-review.googlesource.com/83563
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2017-12-11 20:28:38 +00:00
Brian Salomon
3d6801eeee Add GrGLMakeNativeInterface factory that returns sk_sp<const GrGLInterface>.
Removes the concept of a configurable "default" interface and makes the default
always be the "native" interface.

Also removes unused functions: GrGLInterfaceAddTestDebugMarker and
GrGLInterface::NewClone.

Keeps around legacy GrGLCreateNativeInterface() until clients can be weened.

Change-Id: I4a3bdafa8cf8c68ed13318393abd55686b045ccb
Reviewed-on: https://skia-review.googlesource.com/83000
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2017-12-11 17:54:38 +00:00
Brian Salomon
f9ec4707ee Exclude tools/gpu/atlastext from public.bzl
Change-Id: I6506519860d48417d525c48e1e60a4eb6e5070d9
Reviewed-on: https://skia-review.googlesource.com/73560
Reviewed-by: Brian Salomon <bsalomon@google.com>
2017-11-19 19:47:32 +00:00
Brian Salomon
cbcb0a12ad Revert "Revert "Add Atlas Text interface for rendering SDF glyphs.""
This reverts commit 9c2202ffc2.

Bug: skia:
Change-Id: I482ddf74f8e40d3d0908c840ba5c6ff981ccefbd
Reviewed-on: https://skia-review.googlesource.com/73345
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2017-11-19 18:55:18 +00:00
Brian Salomon
f44754a42b Drop support for OSMesa in test tools and remove build bot
Change-Id: Ic85ee05fe292a36a053ca7a20ccce24a4da4fae2
Reviewed-on: https://skia-review.googlesource.com/70026
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2017-11-13 16:20:10 +00:00
Mike Klein
10d66cc3f8 move Sk{Test,Random}ScalerContext to tools
There's no need for Skia users to link this test code.

Change-Id: I9d6ef2a053d0cf5cb916aa254389ca819c48bae1
Reviewed-on: https://skia-review.googlesource.com/69922
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2017-11-10 17:02:20 +00:00
Mike Klein
97f0bc6a1a clean up cruft about --portableFonts and --resourceFonts
--portableFonts exists but does nothing.
--resourceFonts doesn't even exist.

Change-Id: I7880208de4aaa9674ba720b9e70c34c145561ac0
Reviewed-on: https://skia-review.googlesource.com/67800
Commit-Queue: Ben Wagner <bungeman@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
2017-11-06 15:09:09 +00:00
Mike Klein
03141d25cf remove SkThread, using std::thread instead
Change-Id: I871dd5eea4496e87c206b46d9eae81cb521b11ce
Reviewed-on: https://skia-review.googlesource.com/65103
Reviewed-by: Hal Canary <halcanary@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2017-10-30 16:45:29 +00:00
Mike Klein
c29bb571f7 support Clang 3.8 and -no-integrated-as
Change-Id: I7eb3ef28513858446de4392044785bd3148e7aa5
Reviewed-on: https://skia-review.googlesource.com/63262
Reviewed-by: Mike Klein <mtklein@chromium.org>
2017-10-24 15:46:07 +00:00
Ben Wagner
54b221311c Synchronize public.bzl float-cast-overflow omit list with test.py.
No-Try: true
Change-Id: If4320eae12e4967ee59a230549bbd34fca2fed94
Reviewed-on: https://skia-review.googlesource.com/60883
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-10-18 00:03:04 +00:00
Ben Wagner
9eca72b57b [Bazel] Separate OS and CPU dimensions in Skia sources.
Patching from internal cl/171888276.

No-Try: true
Change-Id: I6919769ad4e367ded394f1094944cea2b3901fd0
Reviewed-on: https://skia-review.googlesource.com/60583
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2017-10-17 15:37:12 +00:00
Mike Reed
32a6924162 remove legacy computeByteSize flag, now returns max_size_t
Bug: skia:
Change-Id: Ia2f2627ba4ea81e715f27e94d900951ba5e19f79
Reviewed-on: https://skia-review.googlesource.com/57106
Reviewed-by: Mike Reed <reed@google.com>
2017-10-09 17:33:25 +00:00
Mike Reed
7281801849 Revert "Revert "change computeByteSize to return max_size_t on overflow""
This reverts commit 384f0a7d66.

Bug: skia:
Change-Id: I392ef5c1a5172181caf81ae270befeba6e778241
Reviewed-on: https://skia-review.googlesource.com/57084
Commit-Queue: Mike Reed <reed@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
2017-10-09 16:05:34 +00:00
Mike Reed
384f0a7d66 Revert "change computeByteSize to return max_size_t on overflow"
This reverts commit 2429546272.

Reason for revert: broke running dm on google3

Original change's description:
> change computeByteSize to return max_size_t on overflow
> 
> Bug: skia:7132
> Change-Id: I41045640ee62b2c988a84370ead5034bbccc6daf
> Reviewed-on: https://skia-review.googlesource.com/56620
> Reviewed-by: Ben Wagner <bungeman@google.com>
> Commit-Queue: Mike Reed <reed@google.com>

TBR=bungeman@google.com,herb@google.com,reed@google.com

Change-Id: I5f58ec37241d2fae3ebdb7a3d6b41f9fd6d3c2ee
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:7132
Reviewed-on: https://skia-review.googlesource.com/56880
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2017-10-06 21:24:10 +00:00
Mike Reed
2429546272 change computeByteSize to return max_size_t on overflow
Bug: skia:7132
Change-Id: I41045640ee62b2c988a84370ead5034bbccc6daf
Reviewed-on: https://skia-review.googlesource.com/56620
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2017-10-06 19:36:17 +00:00
Mike Reed
de281c98ba Revert "Revert "remove guard for computeByteSize api""
This reverts commit 297e4d3f27.

Reason for revert: landed fix in google3

Original change's description:
> Revert "remove guard for computeByteSize api"
> 
> This reverts commit d72747c5c3.
> 
> Reason for revert: broke //htmlrender/webkit_headless/engine/testing:platform_web_unittests
> 
> Original change's description:
> > remove guard for computeByteSize api
> > 
> > Bug: skia:
> > Change-Id: I5c66a7c79c4e71ec82194e8d37de04a516028665
> > Reviewed-on: https://skia-review.googlesource.com/56402
> > Reviewed-by: Mike Reed <reed@google.com>
> 
> TBR=reed@google.com,reed@chromium.org
> 
> Change-Id: If721607583204df9f32e54a041ecc8b34ad1a749
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: skia:
> Reviewed-on: https://skia-review.googlesource.com/56321
> Reviewed-by: Mike Reed <reed@google.com>
> Commit-Queue: Mike Reed <reed@google.com>

TBR=reed@google.com,reed@chromium.org

Change-Id: I6d26a8623122e69af550d9a257c21943fe70b9f5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/56640
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2017-10-06 17:59:50 +00:00
Mike Reed
297e4d3f27 Revert "remove guard for computeByteSize api"
This reverts commit d72747c5c3.

Reason for revert: broke //htmlrender/webkit_headless/engine/testing:platform_web_unittests

Original change's description:
> remove guard for computeByteSize api
> 
> Bug: skia:
> Change-Id: I5c66a7c79c4e71ec82194e8d37de04a516028665
> Reviewed-on: https://skia-review.googlesource.com/56402
> Reviewed-by: Mike Reed <reed@google.com>

TBR=reed@google.com,reed@chromium.org

Change-Id: If721607583204df9f32e54a041ecc8b34ad1a749
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/56321
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2017-10-06 15:27:45 +00:00
Mike Reed
d72747c5c3 remove guard for computeByteSize api
Bug: skia:
Change-Id: I5c66a7c79c4e71ec82194e8d37de04a516028665
Reviewed-on: https://skia-review.googlesource.com/56402
Reviewed-by: Mike Reed <reed@google.com>
2017-10-06 14:28:43 +00:00
Mike Reed
f0ffb8943b Revert[4] "guard old apis for querying byte-size of a bitmap/imageinfo/pixmap"
This reverts commit 5a2e50edc5.

Bug: skia:
Change-Id: I8d28b5c07d90130e5a1653923740eaf189ecb954
Reviewed-on: https://skia-review.googlesource.com/53900
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2017-10-03 20:03:35 +00:00
Mike Reed
5a2e50edc5 Revert "Revert "Revert "guard old apis for querying byte-size of a bitmap/imageinfo/pixmap"""
This reverts commit cd284c5323.

Reason for revert:

assert fired in SkMallocPixelRef.cpp:61: fatal error: "assert(info.computeByteSize(rowBytes) == info.getSafeSize(rowBytes))"

google3 thinks it was from surface_rowbytes

Original change's description:
> Revert "Revert "guard old apis for querying byte-size of a bitmap/imageinfo/pixmap""
> 
> This reverts commit 809cbedd4b.
> 
> Bug: skia:
> Change-Id: I680d8daeeeeb15526b44c1305d8fb0c6bfa38e1d
> Reviewed-on: https://skia-review.googlesource.com/52665
> Commit-Queue: Mike Reed <reed@google.com>
> Reviewed-by: Florin Malita <fmalita@chromium.org>

TBR=fmalita@chromium.org,reed@google.com

Change-Id: I41e3f7a3f791cc8183291847e783ed8a53bc91d2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/53802
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2017-10-02 13:44:18 +00:00
Mike Reed
cd284c5323 Revert "Revert "guard old apis for querying byte-size of a bitmap/imageinfo/pixmap""
This reverts commit 809cbedd4b.

Bug: skia:
Change-Id: I680d8daeeeeb15526b44c1305d8fb0c6bfa38e1d
Reviewed-on: https://skia-review.googlesource.com/52665
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
2017-10-02 12:55:37 +00:00
Jim Van Verth
809cbedd4b Revert "guard old apis for querying byte-size of a bitmap/imageinfo/pixmap"
This reverts commit 88757dacd4.

Reason for revert: Still seems to be failing Chromium "telemetry_perf_unittests (with patch) on Android" on android_n5x_swarming_rel.

Original change's description:
> guard old apis for querying byte-size of a bitmap/imageinfo/pixmap
> 
> Now with legacy behavior for allocpixels
> 
> This was reverted, so the current CL is a "fix" on top of ...
> https://skia-review.googlesource.com/c/skia/+/50980
> 
> Related update to Chrome (in preparation for this change)
> https://chromium-review.googlesource.com/c/chromium/src/+/685719
> 
> Bug: skia:
> Change-Id: I4b370ee7e95083ab27421f008132219c9c7b86e9
> Reviewed-on: https://skia-review.googlesource.com/51341
> Reviewed-by: Florin Malita <fmalita@chromium.org>
> Commit-Queue: Mike Reed <reed@google.com>

TBR=fmalita@chromium.org,reed@google.com

Change-Id: I827a0ca1d1e3909e648fde3342cdb8601d34da8d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/52381
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
2017-09-27 23:15:07 +00:00
Mike Reed
88757dacd4 guard old apis for querying byte-size of a bitmap/imageinfo/pixmap
Now with legacy behavior for allocpixels

This was reverted, so the current CL is a "fix" on top of ...
https://skia-review.googlesource.com/c/skia/+/50980

Related update to Chrome (in preparation for this change)
https://chromium-review.googlesource.com/c/chromium/src/+/685719

Bug: skia:
Change-Id: I4b370ee7e95083ab27421f008132219c9c7b86e9
Reviewed-on: https://skia-review.googlesource.com/51341
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Mike Reed <reed@google.com>
2017-09-27 14:36:07 +00:00
Greg Daniel
f46633f8af Revert "guard old apis for querying byte-size of a bitmap/imageinfo/pixmap"
This reverts commit 98a6216b18.

Reason for revert: breaking the chrome roll. Looks like they may be writing data to create an image across all the row bytes and thus writing to unalloced data on the last row. Link to example failing bot:
 https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/539960

Original change's description:
> guard old apis for querying byte-size of a bitmap/imageinfo/pixmap
> 
> Previously we had size_t and uint64_t variations.
> 
> The new (simpler) API always..
> - returns size_t, or 0 if the calculation overflowed
> - returns the trimmed size (does not include rowBytes padding for the last row)
> 
> Bug: skia:
> Change-Id: I05173e877918327c7b207d2f7f1ab0db36892e2e
> Reviewed-on: https://skia-review.googlesource.com/50980
> Commit-Queue: Mike Reed <reed@google.com>
> Reviewed-by: Florin Malita <fmalita@chromium.org>
> Reviewed-by: Leon Scroggins <scroggo@google.com>

TBR=mtklein@google.com,herb@google.com,scroggo@google.com,fmalita@chromium.org,reed@google.com

Change-Id: I726f6ab1b36b14979ba6f37105e0a469b3f0dbc0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/51262
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2017-09-26 20:08:07 +00:00
Mike Reed
98a6216b18 guard old apis for querying byte-size of a bitmap/imageinfo/pixmap
Previously we had size_t and uint64_t variations.

The new (simpler) API always..
- returns size_t, or 0 if the calculation overflowed
- returns the trimmed size (does not include rowBytes padding for the last row)

Bug: skia:
Change-Id: I05173e877918327c7b207d2f7f1ab0db36892e2e
Reviewed-on: https://skia-review.googlesource.com/50980
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Reviewed-by: Leon Scroggins <scroggo@google.com>
2017-09-26 17:07:16 +00:00
Mike Reed
4e8dc171f6 Revert "Revert "try to remove google3 flag""
This reverts commit c86d0794ed.

Reason for revert: google3 updated

Original change's description:
> Revert "try to remove google3 flag"
> 
> This reverts commit f0317e603a.
> 
> Reason for revert: breaks headless webkit, fix on the way
> 
> Original change's description:
> > try to remove google3 flag
> > 
> > Bug: skia:
> > Change-Id: I8baaf48e366932e3a90d0db57279201025c4d2b6
> > Reviewed-on: https://skia-review.googlesource.com/48182
> > Reviewed-by: Mike Reed <reed@google.com>
> 
> TBR=mtklein@google.com,reed@google.com,reed@chromium.org
> 
> Change-Id: Ic331e8707531c970b577314db997b372356e6439
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: skia:
> Reviewed-on: https://skia-review.googlesource.com/48320
> Reviewed-by: Mike Reed <reed@google.com>
> Commit-Queue: Mike Reed <reed@google.com>

TBR=mtklein@google.com,reed@google.com,reed@chromium.org

Change-Id: I09a706b2035b6c52087b1a3f26fc2c97d17c712b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/48480
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2017-09-19 13:46:20 +00:00
Mike Reed
c86d0794ed Revert "try to remove google3 flag"
This reverts commit f0317e603a.

Reason for revert: breaks headless webkit, fix on the way

Original change's description:
> try to remove google3 flag
> 
> Bug: skia:
> Change-Id: I8baaf48e366932e3a90d0db57279201025c4d2b6
> Reviewed-on: https://skia-review.googlesource.com/48182
> Reviewed-by: Mike Reed <reed@google.com>

TBR=mtklein@google.com,reed@google.com,reed@chromium.org

Change-Id: Ic331e8707531c970b577314db997b372356e6439
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/48320
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2017-09-18 21:31:59 +00:00
Mike Reed
f0317e603a try to remove google3 flag
Bug: skia:
Change-Id: I8baaf48e366932e3a90d0db57279201025c4d2b6
Reviewed-on: https://skia-review.googlesource.com/48182
Reviewed-by: Mike Reed <reed@google.com>
2017-09-18 21:08:48 +00:00
Mike Reed
b2b28d1eba add guard for google3 for stream api change
Bug: skia:
Change-Id: I195db927d253167eaee1ab6bedb1d09cdb408c93
Reviewed-on: https://skia-review.googlesource.com/47262
Reviewed-by: Mike Reed <reed@google.com>
2017-09-15 20:18:06 +00:00
Ben Wagner
56e9d4a579 Update omitted Bazel tests.
Match based on the whole test name.

No-Try: true
Change-Id: I03c180195f5854f30e521e2772dcb7e44f1cc3b8
Reviewed-on: https://skia-review.googlesource.com/46000
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2017-09-13 00:55:50 +00:00
Ethan Nicholas
8d7f4ae16e Fix for Google3 roll failure
Bug: skia:
Change-Id: I19ba8a0fba290bd35622dfa18efdaa1cada666ee
Reviewed-on: https://skia-review.googlesource.com/43640
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
2017-09-07 15:29:01 +00:00
Ethan Nicholas
ca82a922e3 Revert "Revert "Initial checkin of SkSL lexical analyzer generator (not actually in use yet).""
This reverts commit 3ed4781ee1.

Bug: skia:
Change-Id: If0de7ca17c4da8000d3526a73b71be6ee34ce060
Reviewed-on: https://skia-review.googlesource.com/43561
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
2017-09-07 13:57:51 +00:00
Mike Klein
9d7e57d509 Revert "Revert "8-bit jumper on armv8""
This reverts commit 6d13575108.

Now with guards for "errors" like this:
    external/skia/src/jumper/SkJumper_stages_8bit.cpp:240:50: error:
    'memcpy' called with size bigger than buffer
                case 12: memcpy(&v, src, 12*sizeof(T)); break;

This code is unreachable and generally removed by Clang's optimizer
anyway... as far as I can tell the code generation diff is arbitrary.

Change-Id: I6216567caaa6166f71258bd25343a09e93892a10
Reviewed-on: https://skia-review.googlesource.com/39961
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2017-08-29 17:04:47 +00:00
Derek Sollenberger
6d13575108 Revert "8-bit jumper on armv8"
This reverts commit 08133583d5.

Reason for revert: Blocking Android Autoroller on compile error.

Original change's description:
> 8-bit jumper on armv8
> 
> The GM diffs are all minor and what you'd expect.
> 
> I did a quick performance sanity check, which also looks fine.
> 
>   $ out/ok bench rp filter:search=Modulate
>     [blendmode_rect_Modulate] 30.2ms  @0  32ms    @95 32ms    @100
>     [blendmode_mask_Modulate] 12.6ms  @0  12.6ms  @95 14.5ms  @100
>   ~~~>
>     [blendmode_rect_Modulate] 11.2ms  @0  11.7ms  @95 12.4ms  @100
>     [blendmode_mask_Modulate] 10.5ms  @0  23.6ms  @95 23.9ms  @100
> 
> This isn't even really the fastest we can make 8-bit go on ARMv8;
> it's actually much more natural to work de-interlaced there.  Lots
> of room to follow up.
> 
> Change-Id: I86b1099f6742bcb0b8b4fa153e85eaba9567cbf7
> Reviewed-on: https://skia-review.googlesource.com/39740
> Reviewed-by: Florin Malita <fmalita@chromium.org>
> Commit-Queue: Mike Klein <mtklein@chromium.org>

TBR=mtklein@chromium.org,herb@google.com,fmalita@chromium.org,reed@google.com

Change-Id: I71425d8b7fbb66be5cb50025871dd81358111da4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/39980
Reviewed-by: Derek Sollenberger <djsollen@google.com>
Commit-Queue: Derek Sollenberger <djsollen@google.com>
2017-08-29 12:38:02 +00:00
Mike Klein
08133583d5 8-bit jumper on armv8
The GM diffs are all minor and what you'd expect.

I did a quick performance sanity check, which also looks fine.

  $ out/ok bench rp filter:search=Modulate
    [blendmode_rect_Modulate] 30.2ms  @0  32ms    @95 32ms    @100
    [blendmode_mask_Modulate] 12.6ms  @0  12.6ms  @95 14.5ms  @100
  ~~~>
    [blendmode_rect_Modulate] 11.2ms  @0  11.7ms  @95 12.4ms  @100
    [blendmode_mask_Modulate] 10.5ms  @0  23.6ms  @95 23.9ms  @100

This isn't even really the fastest we can make 8-bit go on ARMv8;
it's actually much more natural to work de-interlaced there.  Lots
of room to follow up.

Change-Id: I86b1099f6742bcb0b8b4fa153e85eaba9567cbf7
Reviewed-on: https://skia-review.googlesource.com/39740
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2017-08-28 21:04:07 +00:00
Mike Reed
e01a904ff5 remove SK_SUPPORT_LEGACY_LOCAL_ROTATE_SHADER -- see what breaks
Bug: skia:
Change-Id: Ife6132240b22af836d1e548f4e970a489132dbed
Reviewed-on: https://skia-review.googlesource.com/36821
Reviewed-by: Mike Reed <reed@google.com>
2017-08-21 16:41:26 +00:00
Mike Reed
eefe9f971b use rasterpipeline if localmatrix is rotated or skewed for images
Bug: skia:
Change-Id: Ib269b5b9d79b055fe614aaacfd7e0d05d48f6085
Reviewed-on: https://skia-review.googlesource.com/33180
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Yuqian Li <liyuqian@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
2017-08-21 15:56:48 +00:00
Mike Klein
135a1b10fe upstream cr/165303354
The only interesting difference here is that I've just skipped
cd_Documents() on Google3 iOS builds rather than adding a new target to
BUILD.  We don't run the binary so it's kind of moot what directory it'd
run in.

Change-Id: I1994e0283d24bcc505fa9b2b7b58307eafa5be92
Reviewed-on: https://skia-review.googlesource.com/34742
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2017-08-15 22:00:57 +00:00
Mike Klein
5b117eafdf rename confusing lowp guard
Change-Id: I346429015e5f902b0a35663e140bb9a025c4220e
Reviewed-on: https://skia-review.googlesource.com/34680
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2017-08-15 13:19:36 +00:00
Ben Wagner
e2cbd04518 Fix DM_ARGS in public.bzl.
Broken by https://skia-review.googlesource.com/32862. It seems that
"tiles_rt" and "pic" configs were passing at one point, but have since
bit-rotted after being renamed to "tiles_rt-8888" and "pic-8888" and
thus ignored by dm.

No-Try: true
Change-Id: I00a5e5a0cc2090566809a61fa310c8ddaafdea43
Reviewed-on: https://skia-review.googlesource.com/33581
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-08-11 13:51:56 +00:00
Mike Reed
47238c79c4 remove guard for google3
Bug: skia:
Change-Id: I4e174aa05cc158ad1a5827010ceb933f73b8363b
Reviewed-on: https://skia-review.googlesource.com/33120
Reviewed-by: Mike Reed <reed@google.com>
2017-08-10 14:44:11 +00:00
Mike Reed
c94ff43cf8 add flag for google3, need to update test
Bug: skia:
Change-Id: I9e896efdf3741f02c29f17dc7dfa4dd2dcf43728
Reviewed-on: https://skia-review.googlesource.com/32403
Reviewed-by: Mike Reed <reed@google.com>
2017-08-08 23:28:38 +00:00
Mike Reed
0851d30c0b stop using SK_USE_FLOATBITS
Bug: skia:
Change-Id: Ie225e0b082b49a2978818c243a2c344a4761b297
Reviewed-on: https://skia-review.googlesource.com/31141
Reviewed-by: Mike Reed <reed@google.com>
2017-08-04 16:26:27 +00:00
Mike Klein
5910ed347a 15-bit lowp is dead, long live 8-bit lowp
Change-Id: Icc4b06094aeba3af99b534746f66286d776ef78a
Reviewed-on: https://skia-review.googlesource.com/30920
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2017-08-04 05:19:38 +00:00
Mike Klein
fba26ea9b7 exclude SkJumper_stages_8bit.cpp from Google3 build
Like _lowp.cpp, it's only meant to be compiled offline.

Change-Id: I0d4f7c1fd8fa880ffd084c1e332f6a33def6e26f
Reviewed-on: https://skia-review.googlesource.com/30262
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2017-08-03 04:56:37 +00:00
Yuqian Li
5d169ed337 Remove the temporary flag SK_NO_ANALYTIC_AA
We will then rebase the tests in Google3 before completely removing
SK_NO_ANALYTIC_AA.

Bug: skia:
Change-Id: I47ec0cde78374bd53f7cdf7c0f2f6607ca6c18c2
Reviewed-on: https://skia-review.googlesource.com/27801
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Yuqian Li <liyuqian@google.com>
2017-07-28 15:11:27 +00:00
Yuqian Li
2e2d34b612 Revert "Remove the temporary flag SK_NO_ANALYTIC_AA"
This reverts commit dbce07d803.

Reason for revert: need rebaseline in Google3

Original change's description:
> Remove the temporary flag SK_NO_ANALYTIC_AA
> 
> It seems that this temp flag lives for too long...
> 
> Bug: skia:
> Change-Id: I48b49af8b7f372abac88a8cd5440def3791e635a
> Reviewed-on: https://skia-review.googlesource.com/27662
> Reviewed-by: Cary Clark <caryclark@google.com>
> Reviewed-by: Florin Malita <fmalita@chromium.org>
> Commit-Queue: Yuqian Li <liyuqian@google.com>

TBR=caryclark@google.com,fmalita@chromium.org,liyuqian@google.com,reed@google.com

Change-Id: I35a91923f16f4e1f530fae20599240cde73438b6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/27722
Reviewed-by: Yuqian Li <liyuqian@google.com>
Commit-Queue: Yuqian Li <liyuqian@google.com>
2017-07-27 19:49:21 +00:00
Yuqian Li
dbce07d803 Remove the temporary flag SK_NO_ANALYTIC_AA
It seems that this temp flag lives for too long...

Bug: skia:
Change-Id: I48b49af8b7f372abac88a8cd5440def3791e635a
Reviewed-on: https://skia-review.googlesource.com/27662
Reviewed-by: Cary Clark <caryclark@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Yuqian Li <liyuqian@google.com>
2017-07-27 18:38:33 +00:00
Mike Reed
1cf276ec59 remove codec-api flag
Bug: skia:6888
Change-Id: I069fd71f7f058171667f25207a1e72ef3f694350
Reviewed-on: https://skia-review.googlesource.com/26885
Reviewed-by: Mike Reed <reed@google.com>
2017-07-26 15:16:44 +00:00
Mike Reed
92376017d9 add guard for google3
Bug: skia:
Change-Id: Ic09eaa9d822bf59a617c877d6c0a9d0b4eaea3da
Reviewed-on: https://skia-review.googlesource.com/26524
Reviewed-by: Mike Reed <reed@google.com>
2017-07-25 17:14:17 +00:00
Brian Salomon
40d01190ad Fix Google3 Roller?
Broken by: https://skia.googlesource.com/skia.git/+/dcbb9d90db0e07b7a3625bcdab3af11ab44c4cfe

Change-Id: I704e341580c50e61ec66cee59ece8ded7d491aeb
Reviewed-on: https://skia-review.googlesource.com/24642
Reviewed-by: Cary Clark <caryclark@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2017-07-19 17:28:24 +00:00
Mike Reed
9291b2921b remove google3 colortable flag
Bug: skia:6828
Change-Id: Id2d8b4ef2d1e1f9ca0ef610d550cde9021a3845e
Reviewed-on: https://skia-review.googlesource.com/24331
Reviewed-by: Mike Reed <reed@google.com>
2017-07-19 15:10:12 +00:00
Mike Reed
086a427b0c guard references to SkColorTable
Bug: skia:6828
Change-Id: I0c8c78e70b118f51cb59dc45675e4ddcd4776108
Reviewed-on: https://skia-review.googlesource.com/24260
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Leon Scroggins <scroggo@google.com>
2017-07-18 15:50:43 +00:00
Mike Reed
df80e39eab remove SK_SUPPORT_LEGACY_INDEX_8_COLORTYPE for google3
Bug: skia:
Change-Id: I0469f125c9eb50370ce97287017401082066fcaf
Reviewed-on: https://skia-review.googlesource.com/24141
Reviewed-by: Mike Reed <reed@google.com>
2017-07-17 20:41:24 +00:00
Mike Reed
c3c9d817f0 add guard for api change in google3
Bug: skia:
Change-Id: I2d84c546cd2bc097c809690bb423581cbd98f2a8
Reviewed-on: https://skia-review.googlesource.com/23060
Reviewed-by: Mike Reed <reed@google.com>
2017-07-13 13:24:21 +00:00
Mike Reed
cbe5e6588a Revert "add guard for recent api change"
This reverts commit 1c8bb8a4c6.

Reason for revert: google3 now updated

Original change's description:
> add guard for recent api change
> 
> Bug: skia:
> Change-Id: Ief80e0eb08d091c54cacb045d074c8564adcedba
> Reviewed-on: https://skia-review.googlesource.com/22640
> Commit-Queue: Mike Reed <reed@google.com>
> Reviewed-by: Mike Reed <reed@google.com>

TBR=benjaminwagner@google.com,reed@google.com

Change-Id: If534fa0f508b5087e3e7527f822906626fdb65c0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/23002
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2017-07-13 12:47:44 +00:00
Mike Reed
1c8bb8a4c6 add guard for recent api change
Bug: skia:
Change-Id: Ief80e0eb08d091c54cacb045d074c8564adcedba
Reviewed-on: https://skia-review.googlesource.com/22640
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Mike Reed <reed@google.com>
2017-07-12 16:45:29 +00:00
Ben Wagner
a3659deab4 Fix Google3 build after https://skia-review.googlesource.com/c/21524/
No-Try: true
Change-Id: I738c6f79d9ad3af09010e64cee28129e503672a4
Reviewed-on: https://skia-review.googlesource.com/22071
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-07-10 19:31:48 +00:00
Hal Canary
44eb6d9c5a remove SkImageEncoder_none.cpp
msarett@ realized that if all of the encoders were disabled, then it
is equivalent to SkImageEncoder.cpp.

Change-Id: Ib3d5d7d061e1a60d7081689430107fb250903d5c
Reviewed-on: https://skia-review.googlesource.com/20440
Reviewed-by: Matt Sarett <msarett@google.com>
Reviewed-by: Cary Clark <caryclark@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
2017-06-21 14:52:30 +00:00
Mike Reed
7c14d274ee Experimental change to diagnose image diffs in g3
Bug: skia:
Change-Id: I33226a0266093a98083b4c78cdaba402ce3f3929
Reviewed-on: https://skia-review.googlesource.com/19082
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2017-06-08 18:38:43 +00:00
Mike Klein
5355d87b07 more exclusion of SkImageEncoder_none.cpp
The current roll is failing due to double linking:

    multiple definition of 'SkEncodeImage(SkWStream*, SkPixmap const&, SkEncodedImageFormat, int)'
    src/images/SkImageEncoder.pic.o: previous definition here

Change-Id: I64ada3591b4c4c0cb8deada0dc796d9a0376b6a7
Reviewed-on: https://skia-review.googlesource.com/18855
Reviewed-by: Matt Sarett <msarett@google.com>
2017-06-06 19:47:03 +00:00
Matt Sarett
ba83233e68 Image encoder cleanup: speculative fix for bzl roll
Bug: skia:
Change-Id: I1e09e66e4d257eebcf959cec44b5d4f0fa876545
Reviewed-on: https://skia-review.googlesource.com/18851
Reviewed-by: Mike Klein <mtklein@google.com>
2017-06-06 18:53:08 +00:00
Neal Norwitz
ca9fb3bfe9 Add basic support for ARM so Skia can be built on Linux 4 Tegra (L4T)
which is used in the Nvidia Jetson TX2 dev kit.  It is Linux on ARM64.

Bug: skia:
Change-Id: I97b99226a8eb2b28190d3cf281d4a1a8278ae5b0
Reviewed-on: https://skia-review.googlesource.com/18884
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2017-06-06 17:31:44 +00:00
Mike Klein
330e93bac1 Exclude SkJumper_stages_lowp.cpp from G3 build.
It's not meant to be built as part of Skia,
only by build_stages.py into SkJumper_generated.S.

Change-Id: Id028c42355f99415fe2bc0710c2292ea949f6eec
Reviewed-on: https://skia-review.googlesource.com/18593
Reviewed-by: Mike Klein <mtklein@chromium.org>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2017-06-05 15:40:38 +00:00
Florin Malita
5edba45dca [Reland] Relocate shaders to own dir
Consolidate all shader impls under src/shaders/.

(reland of https://skia-review.googlesource.com/c/17927/)

Change-Id: I7918bdc1aafe842ed194412ba95b9ae53a2ec1d7
Reviewed-on: https://skia-review.googlesource.com/18146
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2017-05-30 21:01:46 +00:00
Stan Iliev
d8872be505 Revert "Relocate shaders to own dir"
This reverts commit fabe0b26d0.

Reason for revert: Last android roll failed with "external/skia/src/effects/SkGaussianEdgeShader.h:11:10: fatal error: 'SkShaderBase.h' file not found"

Original change's description:
> Relocate shaders to own dir
> 
> Consolidate all shader impls under src/shaders/.
> 
> Change-Id: I450e37541214704c1ad9e379d9d753b7cc62fac3
> Reviewed-on: https://skia-review.googlesource.com/17927
> Commit-Queue: Florin Malita <fmalita@chromium.org>
> Reviewed-by: Herb Derby <herb@google.com>
> 

TBR=mtklein@google.com,herb@google.com,fmalita@chromium.org,reed@google.com
No-Presubmit: true
No-Tree-Checks: true
No-Try: true

Change-Id: Idbb2b75053969df1dad9d8ce0217cd39189b9ddb
Reviewed-on: https://skia-review.googlesource.com/18020
Reviewed-by: Stan Iliev <stani@google.com>
Commit-Queue: Stan Iliev <stani@google.com>
2017-05-25 22:30:19 +00:00
Florin Malita
fabe0b26d0 Relocate shaders to own dir
Consolidate all shader impls under src/shaders/.

Change-Id: I450e37541214704c1ad9e379d9d753b7cc62fac3
Reviewed-on: https://skia-review.googlesource.com/17927
Commit-Queue: Florin Malita <fmalita@chromium.org>
Reviewed-by: Herb Derby <herb@google.com>
2017-05-25 20:05:08 +00:00
Matt Sarett
09e9f68625 Temporarily use default webp encode method for bzl
I suspect that this will fix the failing golden image tests.

Bug: skia:
Change-Id: I9f88206ae782e6a04817e72cdfcb3e0c4bdaa293
Reviewed-on: https://skia-review.googlesource.com/17393
Commit-Queue: Matt Sarett <msarett@google.com>
Reviewed-by: Leon Scroggins <scroggo@google.com>
2017-05-19 17:20:23 +00:00
Mike Reed
1314918f90 Revert "add guard for extra includes"
This reverts commit 037d78f841.

Reason for revert: did not help, will fix caller

Original change's description:
> add guard for extra includes
> 
> Bug: skia:
> Change-Id: Id500cb6ac6c2f4a925135a8e83ed4f2a07b73661
> Reviewed-on: https://skia-review.googlesource.com/17162
> Reviewed-by: Mike Reed <reed@google.com>
> Commit-Queue: Mike Reed <reed@google.com>
> 

TBR=reed@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Bug: skia:

Change-Id: I6d7dd1c51ca81a6c24604ff509b31c2171b26314
Reviewed-on: https://skia-review.googlesource.com/17163
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2017-05-17 11:40:03 +00:00
Mike Reed
037d78f841 add guard for extra includes
Bug: skia:
Change-Id: Id500cb6ac6c2f4a925135a8e83ed4f2a07b73661
Reviewed-on: https://skia-review.googlesource.com/17162
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2017-05-17 10:22:08 +00:00
Matt Sarett
e0e9c08a7d Delete legacy image generator flag from bzl
NOTRY=TRUE

Bug: skia:
Change-Id: Icad74e486d957d10cb3e1091525991cd910626b7
Reviewed-on: https://skia-review.googlesource.com/16717
Reviewed-by: Matt Sarett <msarett@google.com>
Commit-Queue: Matt Sarett <msarett@google.com>
2017-05-12 18:26:06 +00:00
Matt Sarett
ebb1b5c297 Add new SkImageGenerator::getPixels() API, deprecate the old
This is fairly aggressive in that it will break any client
that is currently using SkImageGenerator with kIndex8.
I'm guessing that we don't have any clients doing that.

Bug: skia:6620
Change-Id: Ifd16f5232bb3a9f759c225315c57492d917ed9ca
Reviewed-on: https://skia-review.googlesource.com/16601
Commit-Queue: Matt Sarett <msarett@google.com>
Reviewed-by: Mike Reed <reed@google.com>
2017-05-12 16:48:17 +00:00
Mike Reed
ffeb6533db remove SK_SUPPORT_DEPRECATED_CLIPOPS from g3
Bug: skia:
Change-Id: Ibcdb026a235620135153caabf888ca47317d0515
Reviewed-on: https://skia-review.googlesource.com/16429
Reviewed-by: Mike Reed <reed@google.com>
2017-05-11 01:49:56 +00:00
Mike Reed
14113bcc4e add flag to hide deprecated clipops
needs this to land first
https://codereview.chromium.org/2877493002/#

Bug: skia:3191
Change-Id: Iff5271064877c4e96353d3564464f513eaad0bb5
Reviewed-on: https://skia-review.googlesource.com/16365
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Hal Canary <halcanary@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2017-05-10 18:56:14 +00:00
Matt Sarett
d7093c2486 Add encode to bzl include paths
NOTRY=true

Bug: skia:
Change-Id: Ib37b9a0a5b3c07b0b78b389bd3003c350b49b53f
Reviewed-on: https://skia-review.googlesource.com/16232
Reviewed-by: Matt Sarett <msarett@google.com>
Commit-Queue: Matt Sarett <msarett@google.com>
2017-05-09 19:32:19 +00:00
Ben Wagner
af6522adc1 [Bazel] Omit bigrect GM for ASAN.
Added in https://skia-review.googlesource.com/c/14751/; known to fail
float-cast-overflow check but forgot to omit in that CL.

Bug: skia:4632
No-Try: true
Change-Id: Ic62e0cbc00229ab3bdde60b3e7300fc66ad7d8e1
Reviewed-on: https://skia-review.googlesource.com/15815
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Mike Klein <mtklein@chromium.org>
2017-05-08 15:46:45 +00:00
Mike Klein
452f92016b add -Wno-error=attributes for G3 Android builds
This warning is triggering spuriously on 32-bit Android opt builds.

This CL turns it off for {32,64}x{fastbuild,opt}, but I don't mind.
We can rely on our local builds' much more up to date toolchains.

Change-Id: I5210e87f540a1a425fc0abd07bb3c3986f0f78b0
Reviewed-on: https://skia-review.googlesource.com/15541
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2017-05-05 13:48:32 +00:00
Mike Reed
91b43e4fa3 remove unused etc logic
Bug: skia:
Change-Id: I913d348910db0b6ab930c4c5566ba9eb2320550e
Reviewed-on: https://skia-review.googlesource.com/15181
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2017-05-03 12:55:43 +00:00