Commit Graph

2193 Commits

Author SHA1 Message Date
Mike Klein
4d95befa5c add an SkVMBlitter bot
Switch the guard define to SK_USE_SKVM_BLITTER to match the expectations
of setting up these easy-mode-defines bots (anything starting with SK_).

Change-Id: I7dafdb31a5b2147cac8428e49d4599e50d125ab6
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/233059
Auto-Submit: Mike Klein <mtklein@google.com>
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2019-08-07 17:15:13 +00:00
Mike Klein
e6d800ac0e disable false-postive Wthread-safety-analysis
Some of these compilers seem to misdiagnose correct use of

    if (tryAcquire()) {

       release()
    }

as releasing a lock that hadn't been acquired, but newer compilers
seem just fine.  Let's just turn it off until they can be upgraded.

No bug for the Chromecast builders I can see, but here's the Macs.

Bug: skia:9194
Change-Id: I009a142d4a248dc9d9d085e033b5c7303d732c5b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/233057
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Auto-Submit: Mike Klein <mtklein@google.com>
2019-08-07 17:10:23 +00:00
Eric Boren
593290ed75 [infra] Remove flag from run_recipe.py
Change-Id: I2915bd06c96a55054e97e95e848a9ea12cdb0100
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/233036
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2019-08-07 12:31:00 +00:00
skia-recreate-skps
ced601b40b Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=rmistry@google.com
NO_MERGE_BUILDS

Change-Id: I2e49d60acdbaf8a932371b8906aa523318518bbe
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/232197
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2019-08-04 08:19:28 +00:00
Nathaniel Nifong
79342e492c Add a kind of asset for MSKPs so the skpbench bot can read them.
Bug: skia:9209
Change-Id: Ic16d33341b4fbfd3a77e5dce782b134cd855d0b2
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/230133
Commit-Queue: Nathaniel Nifong <nifong@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2019-08-01 20:29:52 +00:00
Ben Wagner
2891b87844 Set mac_sdk_min=10.13 for CommandBuffer builds
The default SDK version was changed in
https://chromium-review.googlesource.com/c/chromium/src/+/1711106, but
our bots don't have that version yet. This is causing failed rolls,
e.g. https://skia-review.googlesource.com/c/skia/+/231071.

The DEPS change was cherry-picked from
https://skia-review.googlesource.com/c/skia/+/231071.

Change-Id: Iddfa0c7cb8ef676bf6f6b2093c120afdd33513f7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/231097
Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner aka dogben <benjaminwagner@google.com>
2019-07-31 16:35:25 +00:00
Mike Reed
8eb4d74d95 remove drawlooper bots, as that code is now gone
Change-Id: I9733375d14909e0cd235804aa442c3e49737829d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/230738
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
Auto-Submit: Mike Reed <reed@google.com>
2019-07-30 13:26:29 +00:00
Ben Wagner
f9e46a0ef6 [infra] Update GalaxyS6
New devices came with an updated OS.

Change-Id: I01ae0197d15f4249ea50169a449ec738b15c48d3
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/230476
Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner aka dogben <benjaminwagner@google.com>
2019-07-29 20:52:34 +00:00
Ben Wagner
053bd450da Omit test that sometimes causes Chromebook to die
Bug: skia:7551

Change-Id: I17a93a3bacc59922a0ab29cd82f5b4c19171b11d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/230296
Commit-Queue: Eric Boren <borenet@google.com>
Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2019-07-29 15:16:36 +00:00
skia-recreate-skps
067fe02ef7 Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=rmistry@google.com
NO_MERGE_BUILDS

Change-Id: I46c001d0ade1825f7704ac4994add77e240d0b5c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/230281
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2019-07-28 08:25:36 +00:00
Mike Reed
e81dd40406 add bots to opt-in to loopers (deprecated)
Change-Id: I42f8f9b775d52bf4c8b74306f1ae9f8ddcfb863e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/229920
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2019-07-26 12:49:06 +00:00
Brian Osman
1b53191539 Windows-on-ARM testing fixes
- Blacklist the (recently crashing) GLPrograms unit test

- Only test ANGLE ES3 (not ES2) on our Windows-on-ARM bot

With recent changes, ANGLE always returns an ES3 context. They may
reverse that decision, but at the moment there is no actual difference
so the testing is redundant. For this bot in particular, each config
takes upwards of 20 minutes, so this will significantly speed up one of
our slowest bots.

Bug: skia:9275
Change-Id: I04d6e37ae176fab14d7d06c8ebf55d19f9775b53
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/229761
Reviewed-by: Eric Boren <borenet@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2019-07-26 00:13:33 +00:00
Ravi Mistry
04aa81ae66 [perf_skottiewasm_lottieweb] Start tracking timings of drawn frames and count aborted frames
Adds the following new metrics:

* aborted_frames: These are the number of frames which have "main_frame_aborted" terminations in the chosen 25 samples.

* drawn_frame_max_us / drawn_frame_min_us / drawn_frame_avg_us: These metrics are similar to the existing "frame_*_us" metrics but are calculated using only drawn frames (frames terminated with missed_frame or submitted_frame).

Bug: skia:9237
Change-Id: Ib6ed29f7ae6a1f7b6660f231aad528fe7bb6f203
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/229419
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
2019-07-25 21:28:03 +00:00
Mike Klein
e172236e7b rewrite *.gn and #includes on CheckGeneratedFiles bot
In addition to checking .fp files, this ought to make this bot now also
check that our .gn files are formatted and our #includes are consistent
with rewrite_includes.py.

Some .gn files needed formatting; you can see the failure caught on PS 4.

Cq-Include-Trybots: skia.primary:Housekeeper-PerCommit-CheckGeneratedFiles
Change-Id: Ia6669581406212c986da81f2521e4e9d8d3eadb4
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/229802
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2019-07-25 20:48:33 +00:00
Ben Wagner
3dbae945c6 Reland "[infra] Upgrade Win10 in Skolo. Use new Win dimension values."
This is a reland of ad96b1c133

Original change's description:
> [infra] Upgrade Win10 in Skolo. Use new Win dimension values.
> 
> See
> https://chromium-review.googlesource.com/c/infra/luci/luci-py/+/1660974
> for more info about the new dimension values.
> 
> Change-Id: Ie8f000553a342f2fcd65dcdeb9defe11b93ca012
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/229577
> Commit-Queue: Eric Boren <borenet@google.com>
> Reviewed-by: Eric Boren <borenet@google.com>

Change-Id: I0f138968070b1d9d6ad11d64adcb0179c11e9c8e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/229758
Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
Commit-Queue: Ben Wagner aka dogben <benjaminwagner@google.com>
2019-07-25 15:35:05 +00:00
Brian Osman
efc7205c14 Don't test MSAA on Pixel2XL Vulkan Perf bots
This bot has been hanging ever since the MSAA config was added.

Bug: skia:9274
Change-Id: I1901206d4fd79c36c9b5d068dca07c744f52a54f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/229756
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2019-07-25 13:52:35 +00:00
Ben Wagner aka dogben
0c289af0c9 Revert "[infra] Upgrade Win10 in Skolo. Use new Win dimension values."
This reverts commit ad96b1c133.

Reason for revert: Upgraded bots not ready yet

Original change's description:
> [infra] Upgrade Win10 in Skolo. Use new Win dimension values.
> 
> See
> https://chromium-review.googlesource.com/c/infra/luci/luci-py/+/1660974
> for more info about the new dimension values.
> 
> Change-Id: Ie8f000553a342f2fcd65dcdeb9defe11b93ca012
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/229577
> Commit-Queue: Eric Boren <borenet@google.com>
> Reviewed-by: Eric Boren <borenet@google.com>

TBR=borenet@google.com,benjaminwagner@google.com

Change-Id: Ida8ae884559f492797e382eb7697761fcd828ff0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/229757
Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
Commit-Queue: Ben Wagner aka dogben <benjaminwagner@google.com>
2019-07-25 13:28:44 +00:00
Eric Boren
6dc002169e [infra] Fix DEPS to use full commit hashes
Branches and tags may change out from under us or disappear entirely.
Also add a presubmit check to prevent regressing.

Change-Id: I73878907d9a72f7de7b50989919c3a7bc385abf9
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/229490
Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2019-07-25 11:45:39 +00:00
Eric Boren
68b5dbf450 [infra] gen_tasks_logic followup
Addressing comments from
https://skia-review.googlesource.com/c/skia/+/227438

Change-Id: Ia8691a8c2783197236280524b83b601972bd727b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/229491
Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2019-07-25 11:24:39 +00:00
Ben Wagner
ad96b1c133 [infra] Upgrade Win10 in Skolo. Use new Win dimension values.
See
https://chromium-review.googlesource.com/c/infra/luci/luci-py/+/1660974
for more info about the new dimension values.

Change-Id: Ie8f000553a342f2fcd65dcdeb9defe11b93ca012
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/229577
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2019-07-25 11:23:29 +00:00
Ravi Mistry
d6cb7aecf1 [perf_skottiewasm_lottieweb] Add new bots for LottieWeb_Canvas
Added new "backend" flag to lottie-web-perf.js and created a new lottie-web-canvas-perf.html file.

Bug: skia:9237
Change-Id: Ibca2f121666daf25fbbccac48fed80eb12ccedf7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/229420
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
2019-07-24 22:19:04 +00:00
Brian Osman
fb9acba203 Skip compositing_images benches on GTX660 and Nexus5x Vulkan Perf bots
They're failing since enabling MSAA configs.

Bug: skia:9271 skia:8523
Change-Id: If2e353b169519d06ce3257fd9e6bfbd2da49983a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/229392
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2019-07-24 15:51:15 +00:00
Brian Osman
829144cc76 Better bot coverage for (Vk, Mtl) x MSAA
- Stop testing Metal-MSAA on our Gen8 Mac. These GPUs are slow and buggy
  with MSAA (we already have them disabled on other backends).
- Add Metal bots with the HD615 to get testing on a Gen9 GPU. This
  should have better performance and more correct results. Also move the
  DDL tests to those machines, to get testing on a newer/faster machine.
- Add MSAA configs to Vulkan and Metal perf bots (except for old Intel).

Bug: skia:9023 skia:8243
Change-Id: I214c6c4ef7b6e1401719e62e29fd5d2ad05b6aa1
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/229379
Reviewed-by: Greg Daniel <egdaniel@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2019-07-23 19:11:44 +00:00
Ravi Mistry
ba6b0ac173 Fix G3 compile bot
Change-Id: Ib41f08ea788c22920a91acb6364abea4ec138656
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/229036
Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2019-07-22 21:09:38 +00:00
Stephen White
3e45e128eb Update to Dawn ToT.
Switch to Dawn's version of dawn_generator.gni. This depends on having
a file called build_overrides/dawn.gni. However, this will also enable
us to use the upstream Dawn BUILD.gn files more easily in the future.
This required adding it to compile.isolate, so the bots can pick it up.

Keeping up with Dawn:
Rename TextureFormat enums.
Rename dawn::BufferUsageBit::TransferDst -> CopyDst.
Removal of GLAD dependency.
SPIRV-Tools update.

Change-Id: Idcd5d1035ed106485dd2503b829e3c3b57a5688b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/228568
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Stephen White <senorblanco@chromium.org>
2019-07-22 16:20:36 +00:00
skia-recreate-skps
056bdda97a Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=rmistry@google.com
NO_MERGE_BUILDS

Change-Id: Ibb24564aa0c403efbe535389476c471b0b6a7274
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/228816
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2019-07-21 08:18:46 +00:00
Eric Boren
69c1ce1d40 [infra] Move SKQP recipe test to correct recipe
Followup from https://skia-review.googlesource.com/c/skia/+/228556

Change-Id: Iee0d2c7e095dd9e918c6801f2b3692d829f8557a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/228566
Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2019-07-19 18:48:31 +00:00
Eric Boren
6dc6cea49f [infra] swarm_recipe.isolate shouldn't need infrabots.isolate
Change-Id: I5fb08b64da127d88a32d8be35055565eb96b816d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/224257
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
2019-07-19 18:40:02 +00:00
Eric Boren
58d1f76fc0 Reland "[infra] Make most builds idempotent"
This reverts commit de71a74fc4.

Reason for revert: Reland with fixes

Original change's description:
> Revert "[infra] Make most builds idempotent"
> 
> This reverts commit 57aa178dea.
> 
> Reason for revert: Causes Build-Debian9-Clang-x86-devrel-Android_SKQP to fail
> 
> Original change's description:
> > [infra] Make most builds idempotent
> > 
> > Change-Id: I084645a46feda183747e9d7fc3b40b1aa56c5f78
> > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/211103
> > Commit-Queue: Eric Boren <borenet@google.com>
> > Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
> 
> TBR=borenet@google.com,benjaminwagner@google.com
> 
> Change-Id: I886483a01c53da2cb7816651a02b35b780ffcf67
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/228441
> Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
> Commit-Queue: Ben Wagner aka dogben <benjaminwagner@google.com>

TBR=borenet@google.com,benjaminwagner@google.com

Change-Id: Ie5462e06da06ec835eaa49778111afa063f9404a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/228556
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2019-07-19 12:11:27 +00:00
Ben Wagner aka dogben
de71a74fc4 Revert "[infra] Make most builds idempotent"
This reverts commit 57aa178dea.

Reason for revert: Causes Build-Debian9-Clang-x86-devrel-Android_SKQP to fail

Original change's description:
> [infra] Make most builds idempotent
> 
> Change-Id: I084645a46feda183747e9d7fc3b40b1aa56c5f78
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/211103
> Commit-Queue: Eric Boren <borenet@google.com>
> Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>

TBR=borenet@google.com,benjaminwagner@google.com

Change-Id: I886483a01c53da2cb7816651a02b35b780ffcf67
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/228441
Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
Commit-Queue: Ben Wagner aka dogben <benjaminwagner@google.com>
2019-07-18 21:30:22 +00:00
Eric Boren
57aa178dea [infra] Make most builds idempotent
Change-Id: I084645a46feda183747e9d7fc3b40b1aa56c5f78
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/211103
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
2019-07-18 19:32:34 +00:00
Eric Boren
06920f9b85 [infra] Split out gen_tasks logic into its own shareable package
This makes dependent repos (eg. lottie-ci) significantly less hacky.

Bug: skia:9259
Change-Id: I8a933a927608d96e59a017dd7ef8e52d1d828a4d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/227438
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
2019-07-16 13:57:36 +00:00
Jim Van Verth
31a9e8deec Enable Metal MSAA configs and ignore flaky test
Bug: skia:8243, skia:9255
Change-Id: I006d1bace2bec5ea24b0e2be560a8ff26127f503
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/227402
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
2019-07-15 17:35:12 +00:00
skia-recreate-skps
2e8393c275 Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=rmistry@google.com
NO_MERGE_BUILDS

Change-Id: Iaedc695c5fe7c7ef391edb895c1959377f2eaa39
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/227321
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2019-07-14 08:20:05 +00:00
Ravi Mistry
690e899cff [perf_skottiewasm_lottieweb] Use the new "--use_gpu" flag for GPU bots
* Also use DISPLAY=:0 for non-headless chrome via puppeeteer.
* Output gpu-gl-renderer, gpu-driver, gpu-gl-vendor from the trace file. Will be useful for debugging.

NoTry: true
Bug: skia:9237
Change-Id: Ieb70dbe540aeca89e88dbaeace3cdba1b50eb7ef
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/227156
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2019-07-12 18:31:47 +00:00
Eric Boren
c24705506f [infra] Update Windows bot version
Bug: skia:9253
Change-Id: I5055bb492fe10c35a4d593e4256874e872fc831d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/227036
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2019-07-12 12:24:24 +00:00
Ravi Mistry
649774b686 [perf_skottiewasm_lottieweb] Turn on skottie+wasm flush for a better comparison
This enables us to use the same termination checks as for lottie-web.

NoTry: true
Bug: skia:9237
Change-Id: I9d5d0c450196c3800020e12b45868c656cdcc46a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/226858
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
2019-07-11 19:58:25 +00:00
Ravi Mistry
37a4bedfc8 [perf_skottiewasm_lottieweb] Do 2 loops with 25 points each and then pick 25 from the middle
Doing this will avoid the unreliable frames at the start (setup related) and at the end (teardown related). Also:
* Increase timeouts in lottie-web-perf.js and skottie-wasm-perf.js since we are looping twice now.
* Fix bug where ret code was 0 if puppeteer test failed.

NoTry: true
Bug: skia:9237
Change-Id: I0933ecb87113b40c162712076c38fb7379b352d4
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/226836
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2019-07-11 18:23:17 +00:00
Eric Boren
620b7e9b01 [infra] No relative path for infra_tests.isolate
This should allow dependent repos to use their own version of this
isolate file.

Change-Id: I4afe08cc35da51f4bade0c4a80964dcece91bd8d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/226514
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2019-07-11 12:40:21 +00:00
Brian Salomon
4e9cde8632 Blacklist GrTestingBackendTextureUploadTest on MoltenVk.
TBR: jvanverth@google.com

Change-Id: I4c254fae30ee30bb4f84140f47cc69c9bfa1b8cd
Bug: skia:9247
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/226676
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2019-07-11 00:38:43 +00:00
Brian Osman
6b03ea0905 Remove MSVC 2015 toolchain remnants
We haven't built with 2015 in a long time (and are no
longer able to). Also, this asset doesn't exist (it is
available as V6 of win_toolchain, though).

Change-Id: I5113293e9b9d6652520029f003a29d1c52d092e6
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/226559
Reviewed-by: Hal Canary <halcanary@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2019-07-10 21:46:57 +00:00
Brian Salomon
44a84fb802 Blacklist ColorTypeBackendAllocationTest on MoltenVK
Bug: skia:9247
Change-Id: I8b4261fc81f31f56d24ae3aa84ae81c33ea2b2b4
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/226501
Auto-Submit: Brian Salomon <bsalomon@google.com>
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2019-07-10 21:13:08 +00:00
Eric Boren
51146b47db Revert "[infra] No relative path for infra_tests.isolate"
This reverts commit 5cc450b609.

Reason for revert: breaking dependent repos

Original change's description:
> [infra] No relative path for infra_tests.isolate
> 
> This should allow dependent repos to use their own version of this
> isolate file.
> 
> Change-Id: I5f20eafbd10319eef70ddb65b434269ca99d5c9f
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/226416
> Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
> Commit-Queue: Eric Boren <borenet@google.com>

TBR=borenet@google.com,benjaminwagner@google.com

Change-Id: I91d59aefa943aab371c1cdb14087309c60f29d35
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/226505
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2019-07-10 16:59:57 +00:00
Eric Boren
5cc450b609 [infra] No relative path for infra_tests.isolate
This should allow dependent repos to use their own version of this
isolate file.

Change-Id: I5f20eafbd10319eef70ddb65b434269ca99d5c9f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/226416
Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2019-07-10 16:08:41 +00:00
Eric Boren
9e416c15a4 [infra] Make infra tests idempotent
Change-Id: I1a75b211753ea5e097234dd4104d0906cfd04673
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/223916
Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2019-07-09 19:04:47 +00:00
Eric Boren
edea01deac Revert "[infra] No task deduplication"
This reverts commit 326ad9e716.

Reason for revert: This was an outage of some kind, not intentional expiration of isolates.

Original change's description:
> [infra] No task deduplication
> 
> Isolates are expiring despite the tasks which generate them being
> deduped. Hopefully this is temporary, and we can update the isolate
> server to expire based on last usage date rather than creation date.
> 
> Change-Id: I7158612cd9b28c80268c54da9af88d2048e6aad1
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/226176
> Reviewed-by: Ravi Mistry <rmistry@google.com>
> Commit-Queue: Eric Boren <borenet@google.com>

TBR=borenet@google.com,rmistry@google.com

Change-Id: I3afc8e9e89174505d87d96d45ab6c9e44937bb29
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/226219
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2019-07-09 18:32:26 +00:00
Eric Boren
326ad9e716 [infra] No task deduplication
Isolates are expiring despite the tasks which generate them being
deduped. Hopefully this is temporary, and we can update the isolate
server to expire based on last usage date rather than creation date.

Change-Id: I7158612cd9b28c80268c54da9af88d2048e6aad1
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/226176
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2019-07-09 17:20:04 +00:00
Brian Salomon
b450f3be4f Use vkCmdClearColorImage to clear backend textures
Also don't use GrPixelConfig to create the VkImage.


Bug: skia:7959
Bug: skia:6718

Change-Id: Ia13c5ed2fbe0542c060b725694eff9d566c491f0
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/226078
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2019-07-09 15:00:43 +00:00
Brian Osman
8c4ee90b6c Revert "Enable MSAA on Gen8 Intel GPUs"
This reverts commit 0bda1cc640.

Reason for revert: Performance gap is fairly large.

Original change's description:
> Enable MSAA on Gen8 Intel GPUs
> 
> Bug: skia:9225 chromium:527565
> 
> Change-Id: I7c543bce011c247cd93cad90aca15c9754678202
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225731
> Reviewed-by: Brian Salomon <bsalomon@google.com>
> Commit-Queue: Brian Osman <brianosman@google.com>

TBR=bsalomon@google.com,benjaminwagner@google.com,brianosman@google.com

Change-Id: I0e7f0bd53fbdcad0276462852021b9f3adc8ff6e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:9225 chromium:527565
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/226076
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2019-07-09 12:58:40 +00:00
Ravi Mistry
1540b3ba37 [perf_skottiewasm_lottieweb] Handle case where start TS of frame_id not added yet
NoTry: true
Bug: skia:9237
Change-Id: I37972affe2f01b4248b6dc27b146aaedb28a9de6
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225899
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2019-07-09 12:47:37 +00:00