Commit Graph

1023 Commits

Author SHA1 Message Date
Mike Klein
e6d800ac0e disable false-postive Wthread-safety-analysis
Some of these compilers seem to misdiagnose correct use of

    if (tryAcquire()) {

       release()
    }

as releasing a lock that hadn't been acquired, but newer compilers
seem just fine.  Let's just turn it off until they can be upgraded.

No bug for the Chromecast builders I can see, but here's the Macs.

Bug: skia:9194
Change-Id: I009a142d4a248dc9d9d085e033b5c7303d732c5b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/233057
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Auto-Submit: Mike Klein <mtklein@google.com>
2019-08-07 17:10:23 +00:00
Nathaniel Nifong
79342e492c Add a kind of asset for MSKPs so the skpbench bot can read them.
Bug: skia:9209
Change-Id: Ic16d33341b4fbfd3a77e5dce782b134cd855d0b2
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/230133
Commit-Queue: Nathaniel Nifong <nifong@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2019-08-01 20:29:52 +00:00
Ben Wagner
2891b87844 Set mac_sdk_min=10.13 for CommandBuffer builds
The default SDK version was changed in
https://chromium-review.googlesource.com/c/chromium/src/+/1711106, but
our bots don't have that version yet. This is causing failed rolls,
e.g. https://skia-review.googlesource.com/c/skia/+/231071.

The DEPS change was cherry-picked from
https://skia-review.googlesource.com/c/skia/+/231071.

Change-Id: Iddfa0c7cb8ef676bf6f6b2093c120afdd33513f7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/231097
Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner aka dogben <benjaminwagner@google.com>
2019-07-31 16:35:25 +00:00
Ben Wagner
053bd450da Omit test that sometimes causes Chromebook to die
Bug: skia:7551

Change-Id: I17a93a3bacc59922a0ab29cd82f5b4c19171b11d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/230296
Commit-Queue: Eric Boren <borenet@google.com>
Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2019-07-29 15:16:36 +00:00
Brian Osman
1b53191539 Windows-on-ARM testing fixes
- Blacklist the (recently crashing) GLPrograms unit test

- Only test ANGLE ES3 (not ES2) on our Windows-on-ARM bot

With recent changes, ANGLE always returns an ES3 context. They may
reverse that decision, but at the moment there is no actual difference
so the testing is redundant. For this bot in particular, each config
takes upwards of 20 minutes, so this will significantly speed up one of
our slowest bots.

Bug: skia:9275
Change-Id: I04d6e37ae176fab14d7d06c8ebf55d19f9775b53
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/229761
Reviewed-by: Eric Boren <borenet@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2019-07-26 00:13:33 +00:00
Ravi Mistry
04aa81ae66 [perf_skottiewasm_lottieweb] Start tracking timings of drawn frames and count aborted frames
Adds the following new metrics:

* aborted_frames: These are the number of frames which have "main_frame_aborted" terminations in the chosen 25 samples.

* drawn_frame_max_us / drawn_frame_min_us / drawn_frame_avg_us: These metrics are similar to the existing "frame_*_us" metrics but are calculated using only drawn frames (frames terminated with missed_frame or submitted_frame).

Bug: skia:9237
Change-Id: Ib6ed29f7ae6a1f7b6660f231aad528fe7bb6f203
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/229419
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
2019-07-25 21:28:03 +00:00
Mike Klein
e172236e7b rewrite *.gn and #includes on CheckGeneratedFiles bot
In addition to checking .fp files, this ought to make this bot now also
check that our .gn files are formatted and our #includes are consistent
with rewrite_includes.py.

Some .gn files needed formatting; you can see the failure caught on PS 4.

Cq-Include-Trybots: skia.primary:Housekeeper-PerCommit-CheckGeneratedFiles
Change-Id: Ia6669581406212c986da81f2521e4e9d8d3eadb4
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/229802
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2019-07-25 20:48:33 +00:00
Brian Osman
efc7205c14 Don't test MSAA on Pixel2XL Vulkan Perf bots
This bot has been hanging ever since the MSAA config was added.

Bug: skia:9274
Change-Id: I1901206d4fd79c36c9b5d068dca07c744f52a54f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/229756
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2019-07-25 13:52:35 +00:00
Ravi Mistry
d6cb7aecf1 [perf_skottiewasm_lottieweb] Add new bots for LottieWeb_Canvas
Added new "backend" flag to lottie-web-perf.js and created a new lottie-web-canvas-perf.html file.

Bug: skia:9237
Change-Id: Ibca2f121666daf25fbbccac48fed80eb12ccedf7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/229420
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
2019-07-24 22:19:04 +00:00
Brian Osman
fb9acba203 Skip compositing_images benches on GTX660 and Nexus5x Vulkan Perf bots
They're failing since enabling MSAA configs.

Bug: skia:9271 skia:8523
Change-Id: If2e353b169519d06ce3257fd9e6bfbd2da49983a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/229392
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2019-07-24 15:51:15 +00:00
Brian Osman
829144cc76 Better bot coverage for (Vk, Mtl) x MSAA
- Stop testing Metal-MSAA on our Gen8 Mac. These GPUs are slow and buggy
  with MSAA (we already have them disabled on other backends).
- Add Metal bots with the HD615 to get testing on a Gen9 GPU. This
  should have better performance and more correct results. Also move the
  DDL tests to those machines, to get testing on a newer/faster machine.
- Add MSAA configs to Vulkan and Metal perf bots (except for old Intel).

Bug: skia:9023 skia:8243
Change-Id: I214c6c4ef7b6e1401719e62e29fd5d2ad05b6aa1
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/229379
Reviewed-by: Greg Daniel <egdaniel@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2019-07-23 19:11:44 +00:00
Eric Boren
69c1ce1d40 [infra] Move SKQP recipe test to correct recipe
Followup from https://skia-review.googlesource.com/c/skia/+/228556

Change-Id: Iee0d2c7e095dd9e918c6801f2b3692d829f8557a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/228566
Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2019-07-19 18:48:31 +00:00
Eric Boren
58d1f76fc0 Reland "[infra] Make most builds idempotent"
This reverts commit de71a74fc4.

Reason for revert: Reland with fixes

Original change's description:
> Revert "[infra] Make most builds idempotent"
> 
> This reverts commit 57aa178dea.
> 
> Reason for revert: Causes Build-Debian9-Clang-x86-devrel-Android_SKQP to fail
> 
> Original change's description:
> > [infra] Make most builds idempotent
> > 
> > Change-Id: I084645a46feda183747e9d7fc3b40b1aa56c5f78
> > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/211103
> > Commit-Queue: Eric Boren <borenet@google.com>
> > Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
> 
> TBR=borenet@google.com,benjaminwagner@google.com
> 
> Change-Id: I886483a01c53da2cb7816651a02b35b780ffcf67
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/228441
> Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
> Commit-Queue: Ben Wagner aka dogben <benjaminwagner@google.com>

TBR=borenet@google.com,benjaminwagner@google.com

Change-Id: Ie5462e06da06ec835eaa49778111afa063f9404a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/228556
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2019-07-19 12:11:27 +00:00
Ben Wagner aka dogben
de71a74fc4 Revert "[infra] Make most builds idempotent"
This reverts commit 57aa178dea.

Reason for revert: Causes Build-Debian9-Clang-x86-devrel-Android_SKQP to fail

Original change's description:
> [infra] Make most builds idempotent
> 
> Change-Id: I084645a46feda183747e9d7fc3b40b1aa56c5f78
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/211103
> Commit-Queue: Eric Boren <borenet@google.com>
> Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>

TBR=borenet@google.com,benjaminwagner@google.com

Change-Id: I886483a01c53da2cb7816651a02b35b780ffcf67
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/228441
Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
Commit-Queue: Ben Wagner aka dogben <benjaminwagner@google.com>
2019-07-18 21:30:22 +00:00
Eric Boren
57aa178dea [infra] Make most builds idempotent
Change-Id: I084645a46feda183747e9d7fc3b40b1aa56c5f78
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/211103
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
2019-07-18 19:32:34 +00:00
Jim Van Verth
31a9e8deec Enable Metal MSAA configs and ignore flaky test
Bug: skia:8243, skia:9255
Change-Id: I006d1bace2bec5ea24b0e2be560a8ff26127f503
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/227402
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
2019-07-15 17:35:12 +00:00
Ravi Mistry
690e899cff [perf_skottiewasm_lottieweb] Use the new "--use_gpu" flag for GPU bots
* Also use DISPLAY=:0 for non-headless chrome via puppeeteer.
* Output gpu-gl-renderer, gpu-driver, gpu-gl-vendor from the trace file. Will be useful for debugging.

NoTry: true
Bug: skia:9237
Change-Id: Ieb70dbe540aeca89e88dbaeace3cdba1b50eb7ef
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/227156
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2019-07-12 18:31:47 +00:00
Ravi Mistry
649774b686 [perf_skottiewasm_lottieweb] Turn on skottie+wasm flush for a better comparison
This enables us to use the same termination checks as for lottie-web.

NoTry: true
Bug: skia:9237
Change-Id: I9d5d0c450196c3800020e12b45868c656cdcc46a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/226858
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
2019-07-11 19:58:25 +00:00
Ravi Mistry
37a4bedfc8 [perf_skottiewasm_lottieweb] Do 2 loops with 25 points each and then pick 25 from the middle
Doing this will avoid the unreliable frames at the start (setup related) and at the end (teardown related). Also:
* Increase timeouts in lottie-web-perf.js and skottie-wasm-perf.js since we are looping twice now.
* Fix bug where ret code was 0 if puppeteer test failed.

NoTry: true
Bug: skia:9237
Change-Id: I0933ecb87113b40c162712076c38fb7379b352d4
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/226836
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2019-07-11 18:23:17 +00:00
Brian Salomon
4e9cde8632 Blacklist GrTestingBackendTextureUploadTest on MoltenVk.
TBR: jvanverth@google.com

Change-Id: I4c254fae30ee30bb4f84140f47cc69c9bfa1b8cd
Bug: skia:9247
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/226676
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2019-07-11 00:38:43 +00:00
Brian Salomon
44a84fb802 Blacklist ColorTypeBackendAllocationTest on MoltenVK
Bug: skia:9247
Change-Id: I8b4261fc81f31f56d24ae3aa84ae81c33ea2b2b4
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/226501
Auto-Submit: Brian Salomon <bsalomon@google.com>
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2019-07-10 21:13:08 +00:00
Eric Boren
9e416c15a4 [infra] Make infra tests idempotent
Change-Id: I1a75b211753ea5e097234dd4104d0906cfd04673
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/223916
Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2019-07-09 19:04:47 +00:00
Brian Salomon
b450f3be4f Use vkCmdClearColorImage to clear backend textures
Also don't use GrPixelConfig to create the VkImage.


Bug: skia:7959
Bug: skia:6718

Change-Id: Ia13c5ed2fbe0542c060b725694eff9d566c491f0
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/226078
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2019-07-09 15:00:43 +00:00
Brian Osman
8c4ee90b6c Revert "Enable MSAA on Gen8 Intel GPUs"
This reverts commit 0bda1cc640.

Reason for revert: Performance gap is fairly large.

Original change's description:
> Enable MSAA on Gen8 Intel GPUs
> 
> Bug: skia:9225 chromium:527565
> 
> Change-Id: I7c543bce011c247cd93cad90aca15c9754678202
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225731
> Reviewed-by: Brian Salomon <bsalomon@google.com>
> Commit-Queue: Brian Osman <brianosman@google.com>

TBR=bsalomon@google.com,benjaminwagner@google.com,brianosman@google.com

Change-Id: I0e7f0bd53fbdcad0276462852021b9f3adc8ff6e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:9225 chromium:527565
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/226076
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2019-07-09 12:58:40 +00:00
Ravi Mistry
1540b3ba37 [perf_skottiewasm_lottieweb] Handle case where start TS of frame_id not added yet
NoTry: true
Bug: skia:9237
Change-Id: I37972affe2f01b4248b6dc27b146aaedb28a9de6
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225899
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2019-07-09 12:47:37 +00:00
Ravi Mistry
62e37f1ec5 Parse chrome traces for skottie+wasm and lottie-web for perf
Uses the following algorithm for Skottie+WASM:
* Start timer when  you see BeginImplFrameToSendBeginMainFrame
* Stop timer for main_frame_aborted
* Abandon frame_id if you see replaced_by_new_reporter_at_same_stage, did_not_produce_frame or missed_frame

Getting consistently 25 frames for all lottie-samples with the above algorithm.


Uses the following algorithm for Lottie-Web:
* Start timer when  you see BeginImplFrameToSendBeginMainFrame
* Stop timer for missed_frame or submitted_frame
* Abandon frame_id if you see replaced_by_new_reporter_at_same_stage, did_not_produce_frame or main_frame_aborted

Getting 25 sometimes but also getting other numbers like 20, 27, etc. This is probably because there are more moving parts
and it is hard to predict when Chrome is going to render frames and how many. We might not get exactly 25 here like for
Skottie+WASM, but we will use whatever the tracer gives us (we can always revisit this later).


NoTry: true
Bug: skia:9237
Change-Id: Ia4d5aaf6ac95399b80574d1579358abda4e4e2ea
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225898
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
2019-07-08 21:18:10 +00:00
Brian Osman
0bda1cc640 Enable MSAA on Gen8 Intel GPUs
Bug: skia:9225 chromium:527565

Change-Id: I7c543bce011c247cd93cad90aca15c9754678202
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225731
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2019-07-08 20:40:40 +00:00
Brian Salomon
b3b98b77b7 Reland "Disable GLPrograms test on Mac 10.1 bot"
This reverts commit ae35aff632.

Reason for revert: Looks like try bot got lucky. Bots still getting stuck in GLPrograms.

Original change's description:
> Revert "Disable GLPrograms test on Mac 10.1 bot"
> 
> This reverts commit 2a7c6d5e2a.
> 
> Bug: skia:9235
> Change-Id: Id6dc51c3254fac69665c525e73798f97a3099a17
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225539
> Reviewed-by: Jim Van Verth <jvanverth@google.com>
> Commit-Queue: Brian Salomon <bsalomon@google.com>

TBR=jvanverth@google.com,bsalomon@google.com

Change-Id: I4a7e1b35dc278d5d1c0249cd68101575fd1cf189
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:9235
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225726
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2019-07-08 16:29:45 +00:00
Leon Scroggins III
489d04b0aa Re-Enable Codec tests on Wuffs bot
Bug: skia:8235
Bug: skia:8750
Bug: skia:8762

This reverts commit 30d15e6ca0
("Blacklist Codec tests on Wuffs bot").

Change-Id: I9d8f7dcbb6333590ef3ca70997e76fac6407fcbe
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/224178
Auto-Submit: Leon Scroggins <scroggo@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Leon Scroggins <scroggo@google.com>
2019-07-08 16:02:46 +00:00
Brian Salomon
ae35aff632 Revert "Disable GLPrograms test on Mac 10.1 bot"
This reverts commit 2a7c6d5e2a.

Bug: skia:9235
Change-Id: Id6dc51c3254fac69665c525e73798f97a3099a17
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225539
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2019-07-08 15:42:46 +00:00
Kevin Lubick
11eb847a20 Update skqp's Android NDK to r20
Change-Id: Id479e8c29cff650de17ea2f58d1c3811b2dbac86
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225544
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2019-07-03 20:45:24 +00:00
Brian Salomon
2a7c6d5e2a Disable GLPrograms test on Mac 10.1 bot
Change-Id: I0795eaf6c1416f08c9c602eb15a02b27d97519f5
Bug: skia:9235
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225424
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Jim Van Verth <jvanverth@google.com>
2019-07-03 15:14:43 +00:00
Mike Klein
e3d411ec2c update path to fix Android ASAN bots
Cq-Include-Trybots: skia.primary:Test-Android-Clang-Pixel-CPU-Snapdragon821-arm-Release-All-Android_ASAN
Change-Id: I14abc54f97c083287ee98ccab1ed0f63cb9bd0e7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225483
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2019-07-03 13:15:42 +00:00
Brian Osman
22e47f985c Reland "Test MSAA on Gen9 Intel GPUs"
Updated caps to allow MSAA on newer Intel GPUs.

This reverts commit 41f937f042.

Bug: skia:9225
Change-Id: I15bdc4d4a754945fafcc4bc7d1afaa701d6f0426
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/224958
Auto-Submit: Brian Osman <brianosman@google.com>
Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2019-07-02 14:22:03 +00:00
Mike Klein
42d6d700c9 more --loops 1
Change-Id: Ie5d8eabb9db2911d41854535fb146ed53b0be8ed
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225007
Commit-Queue: Mike Klein <mtklein@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Auto-Submit: Mike Klein <mtklein@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2019-07-01 20:20:12 +00:00
Brian Osman
41f937f042 Revert "Test MSAA on Gen9 Intel GPUs"
This reverts commit e0b2dafeb6.

Reason for revert: Need to blacklist more unit tests

Original change's description:
> Test MSAA on Gen9 Intel GPUs
> 
> Change-Id: Ie5441350fc150356ffb7d6acffe1089ca1de4364
> Bug: skia:9225
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/224539
> Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
> Commit-Queue: Brian Osman <brianosman@google.com>

TBR=bsalomon@google.com,benjaminwagner@google.com,brianosman@google.com

Change-Id: I49c7a2f1132baeef80fa5296c2f2313f2bef0830
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:9225
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/224956
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2019-07-01 18:04:44 +00:00
Brian Osman
e0b2dafeb6 Test MSAA on Gen9 Intel GPUs
Change-Id: Ie5441350fc150356ffb7d6acffe1089ca1de4364
Bug: skia:9225
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/224539
Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2019-07-01 16:56:45 +00:00
Mike Klein
ac8f443f92 auto-tune nanobench in all builds
I'm kind of getting bored of having to pass --loops 0
in optimized+asserts builds.

We'd been defaulting to 1 loop in Debug and ASAN builds,
and manually setting Valgrind builds to 1 loop with 1
sample.  Remove the default so all builds auto-tune,
but set Debug and ASAN bots like Valgrind bots.

Change-Id: Ifedd98a11ea74a2c222fe59bd50b96683d12b98c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/224816
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2019-07-01 16:07:22 +00:00
Ravi Mistry
199ff68ad3 [lottie-web-perf] Use canvas renderer for lottie-web
NoTry: true
Bug: skia:9195
Change-Id: I79276468c153783aebe7fdeda288166c52a6d1bc
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/224286
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2019-06-28 00:17:36 +00:00
Chris Dalton
b3c9745911 Remove "nvpr" configs
The majority of our gm testing has been disabling nvpr, which doesn't
match our real-world behavior where we use nvpr whenever available.
This CL fixes the issue by completely removing the explicit nvpr
configs. Now if we have nvpr, you get it.

This CL also lowers the nvpr priority in the path renderer chain and
adds a "NonNVPR" job on Quadro where we can continue to test our
non-nvpr codepaths on NVIDIA.

Bug: skia:
Change-Id: I6a36f1101c8218adcaaf10cab25d2c28e70371f0
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/223828
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2019-06-26 16:53:50 +00:00
Ravi Mistry
9dbbf887ce [skottie-wasm-perf] Add retries when calling puppeteer
NoTry: true
Bug: skia:9207
Change-Id: I8ff9d2211a268a2564b5752e7a72429380f007ce
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/223936
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2019-06-26 15:17:56 +00:00
Ravi Mistry
832623902b [skottie-wasm-perf] Catch and exit with error if browser does not open
Might as well do the same in lottie-web-perf.
Also mark as infra failures to distinguish from real failures.

NoTry: true
Bug: skia:9207
Change-Id: Id1f3cc5719094d0bf0179ea1a84529c6f376e356
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/223917
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2019-06-26 14:11:20 +00:00
Eric Boren
adf18ce45a [infra] Add go_win asset, add InfraTests_Win bot
NoTry: true
Bug: skia:9188
Change-Id: Ie41f5d4c84eb6f4a3689bdb767204b0403435e2a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/221996
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
2019-06-25 12:28:50 +00:00
Eric Boren
cc84ea1d6c Roll recipe dependencies (nontrivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


Please review the expectation changes, and LGTM+CQ.


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/4b7e794e4dbf7abefd1732b76ff9539570d0be7f [file] Record written data in step presentation. (joshuaseaton@google.com)


R=kjlubick@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ic59ac87f9de5f6abe73e03feb5a94ce4b0dd35f1
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/222573
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Robbie Iannucci <iannucci@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2019-06-25 11:43:53 +00:00
Ravi Mistry
e2439cc929 Add to lottieweb blacklist
NoTry: true
Change-Id: I7dab3e189cad30d8b6edf084566b4d398bcef15e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/223137
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2019-06-24 21:39:48 +00:00
Florin Malita
81eb6323a9 [skottie] Run resources "GMs" on Lottie bots
Run the Skottie tests checked under resources/skottie/ on Lottie bots.

Bug: skia:8925
Change-Id: I240608f1cbc70440cd1a35af52f98a7ef250ec31
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/223182
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2019-06-24 16:05:46 +00:00
Ravi Mistry
641d2b6e62 Add new SkottieTracing GPU bot to match SkottieWASM and LottieWeb
NoTry: true
Bug: skia:8884
Change-Id: I38e1fc050ef3ae101ccd75567f433ca6c3c0ddf3
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/222816
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2019-06-22 12:28:38 +00:00
Eric Boren
a1d26a8077 Roll recipe dependencies (nontrivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


Please review the expectation changes, and LGTM+CQ.


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/c8f87374dfa70a48f26ce431db7b264209d8c479 Implements use of RawResult in engine.py as a recipe return value. (debrian@google.com)


R=stephana@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I82379417a3f517a2d389a6978400614dd5be088f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/221654
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Robbie Iannucci <iannucci@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2019-06-21 12:03:54 +00:00
Ravi Mistry
b2ca0067a7 [lottie-web-perf] Add LottieWeb CPU and GPU bots
* Added support for LottieWeb bots in perf_skottiewasm_lottieweb.py
* Adds a LOTTIE_WEB_BLACKLIST for lottie files that crash lottie-web as described in https://bugs.chromium.org/p/skia/issues/detail?id=9187#c4

NoTry: true
Bug: skia:9187
Change-Id: I8dbf485e7162e027cb4c4db2bf8f8e9c3ec4d966
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/222157
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2019-06-20 16:49:13 +00:00
Ravi Mistry
4918bbcbfd Rename recipe from perf_skottie_wasm to perf_skottiewasm_lottieweb
The lottieweb perf recipe will be very similar to the skottiewasm perf
recipe, so decided to eventually use the same one for both.

Bug: skia:9187
Change-Id: Id9da91c9cf79df7c01c61c7920f944bec974e9f8
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/222156
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2019-06-20 15:03:44 +00:00