Commit Graph

38902 Commits

Author SHA1 Message Date
Herbert Derby
1564069849 Convert ShoudDrawAsPath to use SkFont
Change-Id: Ied4314f7a9bf1e8dacb4a1a3de1533ea71dc02f3
Reviewed-on: https://skia-review.googlesource.com/c/176200
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2018-12-10 21:49:21 +00:00
Brian Salomon
89f2ff1931 Use texparameterf[v]
Change-Id: I96191353fd6d75c1024bf452202d3e4e681afcf6
Reviewed-on: https://skia-review.googlesource.com/c/175829
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2018-12-10 21:46:21 +00:00
recipe-roller
4616f5521d Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/95a3eec6ae5226c402ca15514f2ccc39d5b367c9 [random] Add new "random" module. (iannucci@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I24937c470bcf8e8e0e796dc836d35c8185877f76
Reviewed-on: https://skia-review.googlesource.com/c/176223
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-12-10 21:19:13 +00:00
Mike Reed
a0b54cd589 add test (and fix) for glyphsToUnichars
Bug: skia:
Change-Id: I2defcea7e9a37bdd203acc4ca97fc47a7f57cd43
Reviewed-on: https://skia-review.googlesource.com/c/176221
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2018-12-10 21:11:49 +00:00
Mike Reed
d1ca672673 use SkFont for blob TightBounds
Bug: skia:
Change-Id: I77febaf5ab15784f1600f2f885a88dc907ae8284
Reviewed-on: https://skia-review.googlesource.com/c/176180
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2018-12-10 20:38:36 +00:00
Brian Salomon
3ccaa88c50 Add SK_API to GrTexture.
Sadly, we still expose this Chrome.

Bug: chromium:911856
Change-Id: Ib266eb1a338db621385cd75dbba6e709dd01587c
Reviewed-on: https://skia-review.googlesource.com/c/175999
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
Auto-Submit: Brian Salomon <bsalomon@google.com>
2018-12-10 19:32:08 +00:00
Mike Klein
dbfd7664f2 templatize SkBitmapProcState_matrixProcs
Long standing TODO.

Basically a no-op, except adding an explicit `& 0xffff` to
extract_low_bits_repeat_mirror.  The NEON code does this, and I think it
may help some of the fuzzer bugs we have floating out there.

SkBitmapProcState_matrix_neon.h is a similar setup, up next.

Change-Id: I3109f20a8f1640975901d7e5be10b7d94c490dfb
Reviewed-on: https://skia-review.googlesource.com/c/176060
Auto-Submit: Mike Klein <mtklein@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
2018-12-10 19:14:44 +00:00
skia-autoroll
a0160896f3 Roll third_party/externals/angle2 19f2f9eb2503..153e0224da45 (1 commits)
19f2f9eb25..153e0224da


git log 19f2f9eb2503..153e0224da45 --date=short --no-merges --format='%ad %ae %s'
2018-12-10 enga@chromium.org Add gl_DrawID emulation for ESSL3 with ANGLE_multi_draw


Created with:
  gclient setdep -r third_party/externals/angle2@153e0224da45

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=ethannicholas@google.com

Change-Id: I563ce9305d5cf61ec831b39156b510a824e67c16
Reviewed-on: https://skia-review.googlesource.com/c/176038
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2018-12-10 18:42:10 +00:00
recipe-roller
a72e8d3f40 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/ec40d02c8a16c9bc03a8eddddb71979244f5f1fd buildbucket: add --response-json. (jbudorick@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ie194675aaed43e686f096653ce123b40545f3c3d
Reviewed-on: https://skia-review.googlesource.com/c/175997
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-12-10 18:32:20 +00:00
Leon Scroggins III
dad4bfcfa3 SkWuffsCodec: swizzle only the dirty rect
This should result in a little less work, since the dirty rect should be
a subset of the frame rect. More importantly, the dirty rect will be
empty until we've fully read the color table. For incomplete data, we
therefore shouldn't read an uninitialized color table.

This also lets us convert from the Wuffs palette to the Skia palette
(fColorTable) once (per frame), not once per onIncrementalDecode call.
Again, this means we do a little less work.

Bug: oss-fuzz:11780
Change-Id: I1991778ca19f0525a0fefa57448e2dd015ea38fb
Reviewed-on: https://skia-review.googlesource.com/c/175900
Commit-Queue: Leon Scroggins <scroggo@google.com>
Reviewed-by: Leon Scroggins <scroggo@google.com>
2018-12-10 18:05:47 +00:00
Leon Scroggins III
179559fe35 Fix decoding RAW images to 565
Bug: skia:8473

Follow-on to 96765960dc.

In SkRawCodec, call select_xform_format (in SkCodec.cpp, now shared
via SkCodecPriv.h) to determine the destination skcms_PixelFormat
for the color transform. This switches kRGB_565_SkColorType decodes
from skcms_PixelFormat_RGB_565 to skcms_PixelFormat_BGR_565, which
fixes some broken images in Gold.

Change-Id: I38eebc06610c7ec8898453ae7a9df7e1ed04efa6
Reviewed-on: https://skia-review.googlesource.com/c/175992
Commit-Queue: Leon Scroggins <scroggo@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Auto-Submit: Leon Scroggins <scroggo@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2018-12-10 18:04:48 +00:00
Michael Ludwig
ca91e1f6c5 End color analysis early when color becomes unknown
Bug: skia:
Change-Id: Ifce6f002336ccabf19dbaeb3fa8b40eae6acca19
Reviewed-on: https://skia-review.googlesource.com/c/175990
Commit-Queue: Brian Salomon <bsalomon@google.com>
Auto-Submit: Michael Ludwig <michaelludwig@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2018-12-10 17:51:06 +00:00
Brian Osman
6788a54afe Disable skiaserve target for Windows ARM64
Bug: skia:8569
Change-Id: I7b86dce88af01184aecbfac522bd4e684438d97f
Reviewed-on: https://skia-review.googlesource.com/c/175995
Commit-Queue: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Auto-Submit: Brian Osman <brianosman@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2018-12-10 17:28:46 +00:00
Brian Osman
22fabcae16 Disable Vulkan on Windows ARM64
Bug: skia:8569
Change-Id: I22e3a92f2b89f16414c1ca226582c1f7a5ae136c
Reviewed-on: https://skia-review.googlesource.com/c/175993
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2018-12-10 17:19:46 +00:00
Brian Osman
13b2770513 Add minimal documentation about Windows on ARM64
No-Try: true
Docs-Preview: https://skia.org/?cl=175994
Bug: skia:8569
Change-Id: I9afa9aa6b7293f751db8c43996a82aff1aafbf2d
Reviewed-on: https://skia-review.googlesource.com/c/175994
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2018-12-10 17:07:56 +00:00
Michael Ludwig
f23a152715 Reland "Add clamp to border wrap mode to gpu"
This reverts commit 8137f3c862.

Reason for revert: update GrCaps clampToBorder for iOS and Mac 10.11

Original change's description:
> Revert "Add clamp to border wrap mode to gpu"
>
> This reverts commit f49a5785f3.
>
> Reason for revert: clamp-to-border in metal not available on iOS
>
> Original change's description:
> > Add clamp to border wrap mode to gpu
> >
> > Bug: skia:
> > Change-Id: I286163cdea4fa8f7e6a876baaa11aa3dacd4f2ff
> > Reviewed-on: https://skia-review.googlesource.com/c/175244
> > Reviewed-by: Brian Salomon <bsalomon@google.com>
> > Reviewed-by: Greg Daniel <egdaniel@google.com>
> > Commit-Queue: Michael Ludwig <michaelludwig@google.com>
>
> TBR=egdaniel@google.com,bsalomon@google.com,ethannicholas@google.com,michaelludwig@google.com
>
> Change-Id: I01ef28d9c2fbf6c6dcd82d9aac193ff102d60151
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: skia:
> Reviewed-on: https://skia-review.googlesource.com/c/175988
> Reviewed-by: Michael Ludwig <michaelludwig@google.com>
> Commit-Queue: Michael Ludwig <michaelludwig@google.com>

TBR=egdaniel@google.com,bsalomon@google.com,ethannicholas@google.com,michaelludwig@google.com

Change-Id: I37467eb096fec28131587aefe340f0485fca59d4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/c/175989
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
2018-12-10 16:59:37 +00:00
Brian Salomon
be5a09332e Consolidate details of lazy proxy creation for promise image textures.
The SkSpecialImage helper is now function-local and *is* the lazy
instantiation callback rather than coordinating with one in the
promise SkImage factory functions.

Bug: skia:
Change-Id: I4883618ef440d09a9ac7959cef254e6f5a49aa55
Reviewed-on: https://skia-review.googlesource.com/c/175822
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
2018-12-10 16:11:17 +00:00
Brian Osman
0c75727f01 Disable OpenGL for Windows-on-ARM64
Bug: skia:8569
Change-Id: I4f526c8918a9a4aae4b6cd6d7c803b12e90e82ed
Reviewed-on: https://skia-review.googlesource.com/c/175984
Reviewed-by: Mike Klein <mtklein@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2018-12-10 15:59:14 +00:00
Brian Osman
b2a00250a1 Fix PATH and EXE quoting for Windows ARM64 builds
The PATH change we make is the only thing that needs Windows style
paths (and won't be fixed by GN). So, undo the other backslashes,
and fix a minor error in the placement of the quote.

Bug: skia:8569
Change-Id: I4feecaac96a4cf4d221a93e852a63f597e25e892
Reviewed-on: https://skia-review.googlesource.com/c/175825
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2018-12-10 15:54:18 +00:00
Mike Klein
926a91b595 roll clang_win
No particular reason.  Was just poking around
in here and figured we might as well roll.

Change-Id: Ib161a4b94cb4f272573047e4bd4fd8b59cee79e4
Reviewed-on: https://skia-review.googlesource.com/c/175985
Commit-Queue: Mike Klein <mtklein@google.com>
Auto-Submit: Mike Klein <mtklein@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2018-12-10 15:49:23 +00:00
Greg Daniel
858e12ca11 Remove unused GrSignalSemaphoreOp and forced flushed on semaphore insertion.
Bug: skia:
Change-Id: Iad0e6468552606d7528aaf0307948fe84f85a0d8
Reviewed-on: https://skia-review.googlesource.com/c/175256
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2018-12-10 15:49:13 +00:00
Michael Ludwig
f0b6044d6d Revert "Fix performance regresion on Mali, while preserving sk_FragCoord.w"
This reverts commit a34e6eac3c.

Reason for revert: Broken gold images on Adreno 530 and 540

Original change's description:
> Fix performance regresion on Mali, while preserving sk_FragCoord.w
> 
> Bug: skia:
> Change-Id: I9269288bbb861cd02efa7b5dfe2c9434ec39064e
> Reviewed-on: https://skia-review.googlesource.com/c/174309
> Commit-Queue: Michael Ludwig <michaelludwig@google.com>
> Reviewed-by: Brian Salomon <bsalomon@google.com>

TBR=bsalomon@google.com,michaelludwig@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: skia:
Change-Id: Id344219c101564a5fd06477895386fad2d8dfa78
Reviewed-on: https://skia-review.googlesource.com/c/175986
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
2018-12-10 15:33:17 +00:00
Cary Clark
315805e3b4 fix bookmaker nightly
Example showing glyphsToUnichars crashes fiddle;
disable it for now.

TBR=reed@google.com
NOTRY=true

Docs-Preview: https://skia.org/?cl=175987
Bug: skia:8608
Change-Id: Ic708f656db340180301b6a6959ae7347d109f830
Reviewed-on: https://skia-review.googlesource.com/c/175987
Reviewed-by: Cary Clark <caryclark@google.com>
Commit-Queue: Cary Clark <caryclark@google.com>
Auto-Submit: Cary Clark <caryclark@google.com>
2018-12-10 15:20:07 +00:00
Michael Ludwig
8137f3c862 Revert "Add clamp to border wrap mode to gpu"
This reverts commit f49a5785f3.

Reason for revert: clamp-to-border in metal not available on iOS

Original change's description:
> Add clamp to border wrap mode to gpu
> 
> Bug: skia:
> Change-Id: I286163cdea4fa8f7e6a876baaa11aa3dacd4f2ff
> Reviewed-on: https://skia-review.googlesource.com/c/175244
> Reviewed-by: Brian Salomon <bsalomon@google.com>
> Reviewed-by: Greg Daniel <egdaniel@google.com>
> Commit-Queue: Michael Ludwig <michaelludwig@google.com>

TBR=egdaniel@google.com,bsalomon@google.com,ethannicholas@google.com,michaelludwig@google.com

Change-Id: I01ef28d9c2fbf6c6dcd82d9aac193ff102d60151
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/c/175988
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
2018-12-10 15:14:48 +00:00
Greg Daniel
0a77f4352c In Vulkan don't submit CB after resolve call unless we are preparing image for I/O
Bug: skia:
Change-Id: I99c1d2ee1300f1f1757f7c44b3a839aba3091fee
Reviewed-on: https://skia-review.googlesource.com/c/175259
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2018-12-10 15:11:07 +00:00
Mike Klein
a6e0c2b19c use lld-link any time we have it
Might open up some neat options like LTO builds.
If nothing it's nice to use each whole toolchain consistently.

Move around some bonus quotes a bit.

LLD doesn't understand /DEBUG:FASTLINK.

Change-Id: I27e3c97acea6980c5bd006394aebb1e103007edd
Reviewed-on: https://skia-review.googlesource.com/c/175981
Reviewed-by: Brian Osman <brianosman@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2018-12-10 14:59:44 +00:00
Brian Salomon
0a7e58f4c9 Add glTexParameterf[v] to GrGLInterface
Change-Id: Icd1f2a84f76cedfdb9dfd358e57e0fbc6cae49cb
Reviewed-on: https://skia-review.googlesource.com/c/175828
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
Auto-Submit: Brian Salomon <bsalomon@google.com>
2018-12-10 14:50:23 +00:00
Michael Ludwig
f49a5785f3 Add clamp to border wrap mode to gpu
Bug: skia:
Change-Id: I286163cdea4fa8f7e6a876baaa11aa3dacd4f2ff
Reviewed-on: https://skia-review.googlesource.com/c/175244
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
2018-12-10 14:45:48 +00:00
Cary Clark
e954b9df38 fix bookmaker nightly
Move breakText example to SkFont_Reference.bmh

NOTRY=true
TBR=reed@google.com

Bug: skia:
Change-Id: I2876f0ecc63eb0a50d7232d2f66dae0d81e74b2a
Reviewed-on: https://skia-review.googlesource.com/c/175983
Reviewed-by: Cary Clark <caryclark@skia.org>
Commit-Queue: Cary Clark <caryclark@skia.org>
Auto-Submit: Cary Clark <caryclark@skia.org>
2018-12-10 14:28:47 +00:00
Brian Osman
f5bbf66eb4 Finish removing sample shading support
Chrome's initialization of the function pointer is gone:
https://chromium-review.googlesource.com/c/chromium/src/+/1366758

Bug: skia:
Change-Id: I025db12fbf8cfbcaee580b3494bd56e41b8fd325
Reviewed-on: https://skia-review.googlesource.com/c/175982
Commit-Queue: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Auto-Submit: Brian Osman <brianosman@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2018-12-10 14:28:19 +00:00
Mike Klein
3d8ef153f2 roll up to "msvc != x86"
Change-Id: Id77714823235b0e1d2136171605f1b904469cf98
Reviewed-on: https://skia-review.googlesource.com/c/175980
Auto-Submit: Mike Klein <mtklein@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2018-12-10 13:59:15 +00:00
Brian Salomon
42ec7d774b Link using lld-link when target_os="win" and host_os != "win"
Compile using clang-cl rather than clang-cl.exe

Change-Id: Ibc0350c6d2a38dd3dbf4efdefa85a39ce418cb0c
Reviewed-on: https://skia-review.googlesource.com/c/175830
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2018-12-10 13:40:15 +00:00
Robert Iannucci
e1c2354d08 [recipes] Manually roll recipes
This commit changes the layout of recipe_engine a bit which breaks the
autoroller.

  https://crrev.com/095f4b84e4c62983829973f51f0c46f95022806a

R=borenet@google.com, rmistry@google.com

Bug: chromium:913102
Change-Id: Ic6405fbe5ebd00e453677c5050d089e678153d00
Reviewed-on: https://skia-review.googlesource.com/c/175813
Auto-Submit: Robbie Iannucci <iannucci@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-12-10 12:54:53 +00:00
skia-recreate-skps
1a592c2a3d Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=rmistry@google.com
NO_MERGE_BUILDS

Change-Id: Iadd0efab2e11e4c2fc7e6f5bc87a2ab5f86a85d9
Reviewed-on: https://skia-review.googlesource.com/c/175926
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2018-12-09 08:44:48 +00:00
skia-recreate-skps
27d5e81234 Update go_deps asset
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: Ic1bb633ef58987c53d1e23dddb6fbe9cee5414cd
Reviewed-on: https://skia-review.googlesource.com/c/175923
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2018-12-09 06:02:19 +00:00
Mike Reed
4037a18e5d Revert "Convert bitmap device drawing to SkFont removing all LEGACY calls"
This reverts commit 85a216ce89.

Reason for revert: broke some svg layout tests?

https://ci.chromium.org/p/chromium/builders/luci.chromium.try/mac_chromium_rel_ng/203829

Original change's description:
> Convert bitmap device drawing to SkFont removing all LEGACY calls
> 
> Change-Id: I096042a63395f361f758306993cdbb2621937aef
> Reviewed-on: https://skia-review.googlesource.com/c/175840
> Reviewed-by: Mike Reed <reed@google.com>
> Commit-Queue: Herb Derby <herb@google.com>

TBR=herb@google.com,reed@google.com

Change-Id: Ia88e22d4dcbdfcba01febd7378a2f6bbda235644
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/175831
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2018-12-08 14:01:54 +00:00
skia-autoroll
955f021a4d Roll third_party/externals/angle2 7ef08391098c..19f2f9eb2503 (1 commits)
7ef0839109..19f2f9eb25


git log 7ef08391098c..19f2f9eb2503 --date=short --no-merges --format='%ad %ae %s'
2018-12-08 jiajia.qin@intel.com Mark variable to call 'length()' as statically used


Created with:
  gclient setdep -r third_party/externals/angle2@19f2f9eb2503

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=jcgregorio@google.com

Change-Id: I5b21690d9089da3a0316d0342f84d0dba3c7609c
Reviewed-on: https://skia-review.googlesource.com/c/175797
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2018-12-08 11:55:18 +00:00
skia-recreate-skps
2d8789ded9 Update go_deps asset
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: Icf0d50ef95144af2449600731fc76e0f1f07a6f5
Reviewed-on: https://skia-review.googlesource.com/c/175817
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2018-12-08 06:10:42 +00:00
skia-autoroll
4ba351951e Roll third_party/externals/angle2 0c2dc8c378bb..7ef08391098c (3 commits)
0c2dc8c378..7ef0839109


git log 0c2dc8c378bb..7ef08391098c --date=short --no-merges --format='%ad %ae %s'
2018-12-08 syoussefi@chromium.org Vulkan: add test to verify attrib default value dirty handling
2018-12-07 syoussefi@chromium.org Vulkan: unix line endings in generated shaders
2018-12-07 ianelliott@google.com A4A opt-in/out: add TestRuleProcess test and use a test fixture


Created with:
  gclient setdep -r third_party/externals/angle2@7ef08391098c

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=jcgregorio@google.com

Change-Id: I1cc5685db691bff370165f0a56a2a179446b61c6
Reviewed-on: https://skia-review.googlesource.com/c/175794
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2018-12-08 03:02:50 +00:00
skia-autoroll
1ee699d06c Roll third_party/externals/swiftshader c4bd9df2de2c..2661e8408331 (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/c4bd9df2de2c..2661e8408331


git log c4bd9df2de2c..2661e8408331 --date=short --no-merges --format='%ad %ae %s'
2018-12-07 sugoi@google.com Buffer copy


Created with:
  gclient setdep -r third_party/externals/swiftshader@2661e8408331

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=jcgregorio@google.com

Change-Id: I69c12baf0830aa95d23ea00c01c91100ba1a22f1
Reviewed-on: https://skia-review.googlesource.com/c/175791
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2018-12-08 00:02:51 +00:00
recipe-roller
61797e76c5 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/7bf15aaea60841beb1973a1b0ec19f3be3ec53b2 [remote] Remove remote subcommand. (iannucci@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I034654aec6ca45894b7eb2bda6059ffb6851aea9
Reviewed-on: https://skia-review.googlesource.com/c/175827
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-12-07 23:53:15 +00:00
skia-autoroll
27be8c6966 Roll third_party/externals/swiftshader f8374cf0e75c..c4bd9df2de2c (2 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/f8374cf0e75c..c4bd9df2de2c


git log f8374cf0e75c..c4bd9df2de2c --date=short --no-merges --format='%ad %ae %s'
2018-12-07 sugoi@google.com Implement waiting for fences as noop
2018-12-07 sugoi@google.com Implement pipeline barrier as noop


Created with:
  gclient setdep -r third_party/externals/swiftshader@c4bd9df2de2c

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=jcgregorio@google.com

Change-Id: I0c9d7dfb67932d6c50a286ce009dba0e6c22a441
Reviewed-on: https://skia-review.googlesource.com/c/175786
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2018-12-07 22:58:21 +00:00
Mike Reed
4a6a4acab2 remove uncalled onDrawText virtuals from base class
... waiting on android cl to remove overrides

Bug: skia:
Change-Id: I3375ad251fa6844cdd0511eafc6133a758a3cef6
Reviewed-on: https://skia-review.googlesource.com/c/175582
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2018-12-07 22:14:20 +00:00
Mike Reed
722dd619cb use SkFont more
Bug: skia:
Change-Id: Ic88f04cb8326fd34596d31777cf853866d329d44
Reviewed-on: https://skia-review.googlesource.com/c/175593
Commit-Queue: Florin Malita <fmalita@chromium.org>
Auto-Submit: Mike Reed <reed@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
2018-12-07 22:10:39 +00:00
Herb Derby
85a216ce89 Convert bitmap device drawing to SkFont removing all LEGACY calls
Change-Id: I096042a63395f361f758306993cdbb2621937aef
Reviewed-on: https://skia-review.googlesource.com/c/175840
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2018-12-07 22:01:49 +00:00
Brian Osman
a098265198 Fix PATH when running MSVC for ARM64 target
The ARM64 MSVC toolchain only includes some of the executables. Other
functionality is in DLLs that are located in the host (x64) toolchain
directory. Hopefully MS fixes this at some point.

Bug: skia:8569
Change-Id: I1a96c63c9bdcf656eb2d84b81636d54304766c20
Reviewed-on: https://skia-review.googlesource.com/c/175821
Commit-Queue: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2018-12-07 21:06:25 +00:00
Herb Derby
5424a5eee9 Encapsulate color into subrun
Change-Id: I0a9a7e4803348f5e24144f355eeaeb7e8857da18
Reviewed-on: https://skia-review.googlesource.com/c/171042
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2018-12-07 20:18:48 +00:00
Herb Derby
95e1760a78 Make SkGlyphRun use SkFont instead of SkPaint
Change-Id: I5f34857a21deac418eaaeb19c776b2148b7f0737
Reviewed-on: https://skia-review.googlesource.com/c/175460
Reviewed-by: Hal Canary <halcanary@google.com>
Reviewed-by: Mike Reed <reed@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Herb Derby <herb@google.com>
2018-12-07 20:13:38 +00:00
Mike Klein
ece772d8c2 remove unused Draw*Text records
Change-Id: I33852b4110fcba93b03725b9aa67787220201880
Reviewed-on: https://skia-review.googlesource.com/c/175761
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Auto-Submit: Mike Klein <mtklein@google.com>
2018-12-07 19:52:26 +00:00
Mike Reed
581d637371 micro simplification/speed-up to walk_edges
- quads (conics) are more common than cubics, so check that first
- don't need to track in_internval, so remove it

Don't expect any pixel differences

Bug: skia:
Change-Id: I6a6ce3f8a0b260da66ba27bb0b0d578fb8478cea
Reviewed-on: https://skia-review.googlesource.com/c/175590
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2018-12-07 19:44:45 +00:00