Commit Graph

44768 Commits

Author SHA1 Message Date
skia-autoroll
618d7e7feb Roll third_party/externals/swiftshader 26c6c4a5eb83..23f9c25f60ee (2 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/26c6c4a5eb83..23f9c25f60ee

git log 26c6c4a5eb83..23f9c25f60ee --date=short --no-merges --format='%ad %ae %s'
2019-10-21 sugoi@google.com Enable support for Bresenham lines
2019-10-21 sugoi@google.com Fix queries with arrays containing other structures

Created with:
  gclient setdep -r third_party/externals/swiftshader@23f9c25f60ee

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-skia-autoroll
Please CC michaelludwig@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
Bug: None
TBR=michaelludwig@google.com
Change-Id: Id59cecbb2340bf9fd03587c82fdee71c17d188af
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/249935
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-10-22 04:31:36 +00:00
recipe-roller
81e8d3b296 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/202c559cac64a2c85a7f5e2a20088766d56b9c41 depot_tools: Include httplib2 using vpython. (ehmaldonado@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I918bf2a1068bcc725cc0d4e1f0a8882b00e34356
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/249922
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2019-10-21 23:21:20 +00:00
recipe-roller
8b03a6366e Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/62b68fec1b2c0dbe0e15a5d699790c2a5204956b Pin mac_toolchain to 9a1adc55bf4a1173784da3ba2f8cb06421606748 (lindsayw@google.com)
  https://crrev.com/75c59424e3f11c3e3741d7d574ade51df369a7af [fetch] use py3 for fetch (apolito@google.com)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I22ed19cb20734dfdd4692e05f0c0d27faee16d67
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/249887
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2019-10-21 22:20:30 +00:00
Florin Malita
94e1a52686 [skottie] fix clangtidy warning
TBR=
Change-Id: I4db02978edbf7d60693b18a7c661640a4ab05bf0
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/249885
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2019-10-21 21:27:40 +00:00
Kevin Lubick
2be14d3215 [fuzzing] Add two fuzzers for SkDescriptor
One is an API fuzzer, the other is for deserializing.

Bug: skia:9548
Change-Id: I5923b8fb76f36ec09fca74d5ba82245a8ddb5938
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/249776
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2019-10-21 20:48:15 +00:00
recipe-roller
4036a6d8ac Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/ff46da8d9c614ea4ea76fba49f21bd09f155c3b5 Presubmit: Fix relative owners check (machenbach@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: If2dc7a5ddc84b0c256e6a57d08f06b911841822e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/249865
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2019-10-21 20:16:50 +00:00
Brian Salomon
4eda7108a2 Simplify sk_gpu_test::MakeTextureProxyFromData.
Make it take GrImageInfo.

Change-Id: I9ec16e9b935fbe3e829b4669f715c17873a1793a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/249813
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2019-10-21 20:04:37 +00:00
Hal Canary
c056e169ea SkPDF: simplify Producer metadata logic
Bug: skia:9552
Change-Id: Ifa199048e6d38ccb28f055b77128971411203188
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/249800
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
2019-10-21 20:01:47 +00:00
Kevin Lubick
56f569d9be [canvaskit] roll to v0.8.0
Biggest change here is to add initial support for WebGL 2.0 where possible.

Change-Id: I05657dbfeed25fc665205ceda6b35022f6a42053
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/249815
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2019-10-21 19:17:46 +00:00
recipe-roller
4f50bdda10 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/5b929a4926671f8083509b63a47204a05c03eb00 depot_tools: Clean up auth.py (ehmaldonado@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I658786e940c4cf54705146aedff71c55e24ba9dc
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/249827
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2019-10-21 18:46:08 +00:00
Mike Klein
ff011900e3 remove SkBitmapProcState::fInvKy
It's only used in asserts, and it's completely redundant with other
asserts based on fInvMatrix.

Change-Id: I150dc5b948e5703fff75bf857cabb173428b081f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/249818
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2019-10-21 18:32:29 +00:00
Stephen White
c797483a90 Dawn: fix rendering to mipmapped textures.
Use a texture view with a mipLevelCount of 1 when using a texture
as an attachment.
Dawn validation will fail if the view has more than one mip.

Change-Id: I6a3594dade9f65fa8e713d433797414c6ba8ecec
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/249423
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Stephen White <senorblanco@chromium.org>
2019-10-21 18:22:08 +00:00
Mike Klein
d4db6dad1d remove SkBitmapProcState::fInvType
It's totally redundant with fInvMatrix.getType(),
and mostly used in asserts, where the SkMatrix
methods are way easier to read than type masks.

Change-Id: I970f4ebbc1aa87a287ce965add827cdc6a3be5ff
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/249816
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Reed <reed@google.com>
2019-10-21 18:11:38 +00:00
Kevin Lubick
588e39a30e [canvaskit] Include CodeReviewSystem on JSON uploaded
Change-Id: Ie70a3a852fdae7d41ae8be4c7bb71d3cf9a5b55b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/249805
Reviewed-by: Leandro Lovisolo <lovisolo@google.com>
2019-10-21 18:03:32 +00:00
Florin Malita
cfbc4d496d [skottie] Add DataURI image support in utils/tools
BodyMovin can export inline (dataURI) images.

Change-Id: I821a2e225359f8ac37d4d2c9479d4ff5d78f924e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/249516
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2019-10-21 18:02:39 +00:00
Mike Klein
7333ed23d3 remove unused SkBitmapProcState fields
None of these are used.

Change-Id: Ia8c0eb88db747da55fd03ff1632820a521ed1842
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/249817
Auto-Submit: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2019-10-21 17:59:59 +00:00
Florin Malita
b9886864ca [skottie] Frame-index seek API (seekFrame)
Add a new seek method which takes a frame index. This provides more accurate
control when rendering of exact frames is needed.

Also surface the animation frame rate, and convert skottie_tool to use this
new mechanism (now defaulting to native animation frame rate).

Change-Id: Id870629e1747a9f70cbf4d3e770366df1299a519
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/249799
Commit-Queue: Florin Malita <fmalita@chromium.org>
Reviewed-by: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Reed <reed@google.com>
2019-10-21 17:14:36 +00:00
Jim Van Verth
549666c1b5 Metal: adjust framebuffer size by contentsScale.
If the layer has a scale factor we need to allocate a larger framebuffer.
Otherwise we'll end up drawing to a fraction of the window.

Bug: skia:9554
Change-Id: I93d1e0dc7172ed10bb99ce45524561ad841f0101
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/249803
Reviewed-by: Hal Canary <halcanary@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
2019-10-21 16:41:03 +00:00
Herb Derby
b09131f476 Use common fallback code for drawing an SkGlyphRun
This reorganizes the code so that Mask, SDFT and Paths
share calling the fallback code. It also orders the
different drawing methods from most frequent to least.

Change-Id: I1bbfc92765682c6a20d59da34734f127a6d017cb
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/249558
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2019-10-21 16:06:53 +00:00
Kevin Lubick
d3b1fe66d6 [CanvasKit] More Paragraph things
Bug: skia:9469
Change-Id: I72a4912b5b6edd2ddde077a558c2c24b68d7df64
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/249556
Reviewed-by: Julia Lavrova <jlavrova@google.com>
2019-10-21 15:27:13 +00:00
Stephen White
f0c92a0408 Dawn: don't pretend to support 565, 4444 or Gray_8 pixel configs.
Mark them as untexturable, and they'll be converted at a higher level.
Use SkRectMemcpy() for GrDawnTexture::upload().
This also fixes an issue with large texture uploads.

Change-Id: I5b7041cde324f204074193398ca9f8b5a5dbd744
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/249417
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Stephen White <senorblanco@chromium.org>
2019-10-21 14:42:31 +00:00
Michael Ludwig
b74d5548a4 Track device coordinate space as matrix
This is a required step to be able to cleanly draw image filtered
device layers with arbitrary matrices, instead of relying on
SkMatrixImageFilter to apply the transformation.

Bug: skia:9545
Change-Id: I8d84679a281538875cf4a1b73565294fb7f89c86
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/249076
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
Reviewed-by: Mike Reed <reed@google.com>
2019-10-21 14:34:11 +00:00
recipe-roller
61386966b2 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/a0aed87f71211aff48e3c06802d173cdf21328cf Revert "put goma client in depot_tools" (ukai@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id22ab447860a127a87e447c6ddf3da960b5b687e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/249756
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2019-10-21 12:23:11 +00:00
recipe-roller
c70966b350 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/77780358011f8e20c68ba10aa1282f1f9f65734f put goma client in depot_tools (ukai@google.com)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id49e4a7eb82b664356b7917238177a82a4ee482a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/249708
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2019-10-21 06:35:41 +00:00
skia-autoroll
3cae6d9a26 Roll third_party/externals/angle2 6dee176c8d7d..4a80ba25e67b (13 commits)
6dee176c8d..4a80ba25e6

git log 6dee176c8d7d..4a80ba25e67b --date=short --no-merges --format='%ad %ae %s'
2019-10-21 timvp@google.com Vulkan: Ignore VK_INCOMPLETE from vkGetPipelineCacheData
2019-10-21 jmadill@chromium.org Vulkan: Store ImageView access in the graph.
2019-10-20 jmadill@chromium.org Revert "Reland "Add more test_utils functions.""
2019-10-20 jmadill@chromium.org Reland "Add more test_utils functions."
2019-10-20 jmadill@chromium.org Vulkan: Rename format fields.
2019-10-20 jmadill@chromium.org Remove Vulkan repos from exec script whitelist.
2019-10-20 jmadill@chromium.org Revert "util: Always specify default visibility on exports."
2019-10-19 jmadill@chromium.org util: Always specify default visibility on exports.
2019-10-18 lanwei@chromium.org Revert "Add more test_utils functions."
2019-10-18 ianelliott@google.com Vulkan: Add expectations for Swiftshader dEQP failures.
2019-10-18 courtneygo@google.com Vulkan: lineloop support for DrawArrayIndirect
2019-10-18 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src a959deb00750..834ee546f93d (1 commits)
2019-10-18 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 6652f0b64287..a68a80a4dbf9 (1 commits)

Created with:
  gclient setdep -r third_party/externals/angle2@4a80ba25e67b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-skia-autoroll
Please CC michaelludwig@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE
Bug: None
TBR=michaelludwig@google.com
Change-Id: I44163089d540a4f218d9cbb15c7f73270c8a70df
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/249697
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-10-21 05:59:38 +00:00
skia-recreate-skps
f4c80c3225 Update Go deps
Change-Id: I8638e6caaecf49cbd22af9cff02847281a78bc83
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/249716
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2019-10-21 05:25:38 +00:00
skia-autoroll
554a876f7e Roll third_party/externals/swiftshader a68a80a4dbf9..26c6c4a5eb83 (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/a68a80a4dbf9..26c6c4a5eb83

git log a68a80a4dbf9..26c6c4a5eb83 --date=short --no-merges --format='%ad %ae %s'
2019-10-18 amaiorano@google.com Fix Win32SurfaceKHR resize issues

Created with:
  gclient setdep -r third_party/externals/swiftshader@26c6c4a5eb83

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-skia-autoroll
Please CC michaelludwig@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
Bug: None
TBR=michaelludwig@google.com
Change-Id: I85642e9e0eb7b68c61bdb74a9196cd4dba0bedff
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/249696
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-10-21 04:33:18 +00:00
skia-recreate-skps
d26e865f41 Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=rmistry@google.com
NO_MERGE_BUILDS

Change-Id: I8c9df362cbdc56534b6740fdc3827bf50443081e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/249676
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2019-10-20 08:44:19 +00:00
skia-recreate-skps
115d08786e Update Go deps
Change-Id: I6fbd7ad182a16613e271e4492026b0fd5630d282
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/249656
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2019-10-20 05:27:18 +00:00
skia-recreate-skps
9889d509ed Update Go deps
Change-Id: Ibc89b0e536000c7718ad0f3a1b6caf7ef097aa1a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/249593
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2019-10-19 05:26:50 +00:00
Herb Derby
c65eb34d2f Update for XCode 11 include system
With XCode 11 there is no more /usr/include directory. This
does not affect the XCode compilers, but does make goma compiler
break. This finds the system includes the same way that the iOS
builds currently do.

The gn_to_bp.py tool runs gn with target_os == mac, but host_os != mac.
In that case, the xcrun tool can not run, so make xcode_sysroot = "". This will
allow the xcode compilers to work when using the android.bp to build things.

TESTED:
builds on mac with and without goma

Change-Id: I9de6797c32760c59e62fe5ac505a3404e5eaf8e9
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/249537
Commit-Queue: Herb Derby <herb@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2019-10-18 21:38:47 +00:00
recipe-roller
85b20516e6 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/fd843fa45664e693f091e73a8ba49a00a32a3b80 Add diagnostics to git_cache. (erikchen@chromium.org)
  https://crrev.com/16af35606f4d194c292a5a7ca22b6a91472cf316 presubmit: Remove unused imports. (ehmaldonado@chromium.org)
  https://crrev.com/fcde3ba0a657dd3d5cac15ab8a1b6361e293c2fe Store up to 30000 packet log lines for git fetch. (erikchen@chromium.org)
  https://crrev.com/acf922ce48cfd1ecf88582d9dbecf14e8d1fe369 Reland "depot_tools: Stop using oauth2client" (ehmaldonado@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ife54985c3b7db31e037657559a74d2c858795792
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/249582
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2019-10-18 21:00:17 +00:00
Hal Canary
051f7d66e1 Docs: include/docs with doxygen
Change-Id: Ic9e0040d12e92ba1fe91813ed1daaf83e28316d2
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/249536
Auto-Submit: Hal Canary <halcanary@google.com>
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
2019-10-18 20:38:37 +00:00
recipe-roller
7605c89c00 Roll recipe dependencies (nontrivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


Please review the expectation changes, and LGTM+CQ.


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/b594247e39a48445ccfc7e70678f97e1de451057 Reland "depot_tools: Run recipe scripts using vpython." (ehmaldonado@chromium.org)


R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ie378193914415e50da479e1229afe85f66dbaba3
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/249292
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
2019-10-18 20:27:47 +00:00
Hal Canary
0d4f60c230 Docs: Add links to header files.
Change-Id: I5818b0dcfe58f086a25bd5a28ec2ab2d50c9985a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/201398
Commit-Queue: Joe Gregorio <jcgregorio@google.com>
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Auto-Submit: Hal Canary <halcanary@google.com>
2019-10-18 19:24:13 +00:00
Michael Ludwig
c89d1b56e5 Rename SkDevice::ctm() to localToDevice()
This helps differentiate the SkCanvas' total CTM
(canvas transform matrix), from the device-specific transform matrix
that maps draws from local to device space.

Bug: 9545
Change-Id: I67f40d9b1bc92377bf0520fbc9245f1058e179e6
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/249424
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
Reviewed-by: Mike Reed <reed@google.com>
2019-10-18 18:04:31 +00:00
Kevin Lubick
3085d9ac7d [canvaskit] Roll chrome version for testing
Also disabling failing perf test.

Change-Id: I5776a5dfba0d429ad6a9d725de26c585e61ba37b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/249427
Reviewed-by: Hal Canary <halcanary@google.com>
2019-10-18 17:37:52 +00:00
Florin Malita
814f3cc079 [skottie] Default camera for 3D layers
When 3D layers are present, we need a camera view even when no explicit
camera is present.

TBR=
Bug: skia:8914
Change-Id: I408986d516e03bc4f80c7c09103e09821704ff2f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/249420
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2019-10-18 17:20:11 +00:00
Joe Gregorio
f8813913ba [docs] - Add link to buildbot search.
No-Try: true
Docs-Preview: https://skia.org/?cl=249426
Change-Id: I75e12f90a6b52cd13b9f8fc2741d610c47293d88
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/249426
Auto-Submit: Joe Gregorio <jcgregorio@google.com>
Reviewed-by: Heather Miller <hcm@google.com>
Commit-Queue: Heather Miller <hcm@google.com>
2019-10-18 17:14:22 +00:00
Florin Malita
a3adb9ac7e [skottie] Camera does not apply to regular/2D layers
Per [1], "Cameras affect only 3D layers and 2D layers with an effect
with a Comp Camera attribute."

[1] https://helpx.adobe.com/after-effects/using/cameras-lights-points-interest.html#create_a_camera_layer_and_change_camera_settings

Bug: skia:8914
Change-Id: Ic63ac1a9bfd0913757061684f64adf3df8424246
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/249419
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2019-10-18 16:45:07 +00:00
Ben Wagner
e8960ecfbf Add SkColorData.h to gn.
Allows IDEs to find it, brings us a bit closer to getting gn check to
work.

Change-Id: I1e0c8d01f272c41c97dbbf40402b64f44a6c3c48
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/249421
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2019-10-18 14:54:41 +00:00
Jim Van Verth
cbf59e0e39 Use LazyProxy to set up Metal swapchain.
The purpose of this is to delay acquiring the next drawable in the
swapchain to avoid stalling and gain better parallel execution between
the CPU and GPU.

Change-Id: I40ef7672394fd00616de43685530d2feaf7cab2d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/249005
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
2019-10-18 14:04:41 +00:00
Stephen White
7b86d4e8a2 Dawn: allow CopySrc usage of swapchain texture.
This allows readbacks, which fixes backdrop_hintrect_clipping test.

Change-Id: I6b9002d7387b0bc79301848a2e7c70deb7b95f70
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/249418
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Stephen White <senorblanco@chromium.org>
2019-10-18 13:56:31 +00:00
Stephen White
f4b3d6b9f3 Dawn: fix single-sided stencil.
GrStencilSettings requires that single-sided stencil be accessed via
frontAndBack(), not via front() or back().

Change-Id: Ib35e6187bda05e21c164685f7b726ce4849979fe
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/249416
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Stephen White <senorblanco@chromium.org>
2019-10-18 13:00:00 +00:00
skia-autoroll
b80d31f8cb Roll third_party/externals/angle2 ed6e230ec65e..6dee176c8d7d (11 commits)
ed6e230ec6..6dee176c8d

git log ed6e230ec65e..6dee176c8d7d --date=short --no-merges --format='%ad %ae %s'
2019-10-17 tobine@google.com Vulkan:Roll vulkan layers and headers
2019-10-17 jmadill@chromium.org Add more test_utils functions.
2019-10-17 geofflang@chromium.org Fix compiler warning in NativeBufferImageSiblingAndroid.h.
2019-10-17 tobine@google.com Make invalid extension directive a CHROMEOS warning
2019-10-17 geofflang@chromium.org Fix building libpng on arm CPUs.
2019-10-17 lehoangq@gmail.com Report Metal as unavailable
2019-10-17 jmadill@chromium.org Vulkan: Move SwiftShader ICD json to root_out_dir.
2019-10-17 jmadill@chromium.org Fix broken GN "all_dependent_configs".
2019-10-17 shaobo.yan@intel.com Add "DIFF_LINES_OF_CONTEXT: 1" to fix format issue
2019-10-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 9097eeb5359b..6652f0b64287 (11 commits)
2019-10-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src 1ff0c181bb37..a959deb00750 (12 commits)

Created with:
  gclient setdep -r third_party/externals/angle2@6dee176c8d7d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-skia-autoroll
Please CC csmartdalton@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE
Bug: None
TBR=csmartdalton@google.com
Change-Id: I31cfd6244e31bcbbaea758f8c3f8d30e2a6155c6
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/249363
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-10-18 06:00:40 +00:00
skia-recreate-skps
adcf7dd059 Update Go deps
Change-Id: Icf94b0e2f401c7b1fa5f32041638867d1c82598b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/249371
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2019-10-18 05:25:20 +00:00
skia-autoroll
c5d7ee2128 Roll third_party/externals/swiftshader 6652f0b64287..a68a80a4dbf9 (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/6652f0b64287..a68a80a4dbf9

git log 6652f0b64287..a68a80a4dbf9 --date=short --no-merges --format='%ad %ae %s'
2019-10-17 sugoi@google.com Vulkan header update

Created with:
  gclient setdep -r third_party/externals/swiftshader@a68a80a4dbf9

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-skia-autoroll
Please CC csmartdalton@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
Bug: None
TBR=csmartdalton@google.com
Change-Id: I78acab6cf4cca20c3ebd18906e036a26ac5c1202
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/249362
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-10-18 04:34:10 +00:00
skia-autoroll
2ae29f7046 Roll ../src e27799abf3f0..7ca6de3adb8e (467 commits)
e27799abf3..7ca6de3adb


Created with:
  gclient setdep -r ../src@7ca6de3adb

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-skia-autoroll
Please CC csmartdalton@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Release-All-CommandBuffer;skia.primary:Test-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Debug-All-CommandBuffer
Bug: None
TBR=csmartdalton@google.com
Change-Id: I3fc3c841ba54b47e66f2b16fc6349b54c0a49007
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/249364
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-10-18 04:29:20 +00:00
Herb Derby
20eafffd2d Convert prepareForDrawing to glyph buffers
* Have prepareForDrawing leave empty glyphs in.
  This allows the SkSourceGlyphBuffer to track indexes properly.
  Rename prepareForDrawingRemoving empty to prepareForDrawing.
  This is only temporary until the new unified drawing CL is submitted.
* Make the device fallback case properly support subpixel positioning.
* Add calls to SkDrawableGlyphBuffer to handle the glyph flow of the
  prepareForDrawing system.
* Remove most of the old buffering system except for path handling.

Change-Id: I3e51c96ec041896e07dd4a8f580c207e857911f7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/249221
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2019-10-18 03:05:59 +00:00
recipe-roller
da29d70f1a Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/88d7869db09169044c1a0b2d1fbb57f11ffaee2a Reland "depot_tools: Add httplib2 to .vpython" (ehmaldonado@chromium.org)
  https://crrev.com/5abb9b7c5d0c0a5f81f4a0da741680df9b9d128c Revert "Reland "depot_tools: Add httplib2 to .vpython"" (nodir@chromium.org)
  https://crrev.com/59b06a838a4e06c43075db252921f4bd45f7f673 git-cl: Add yapfignore support to git cl format (bsheedy@chromium.org)
  https://crrev.com/2b034d469f80990a841c0770823d692c6c7b4444 Make the queue module work with both Python 2 and Python 3. (raphael.kubo.da.costa@intel.com)
  https://crrev.com/e9342a723b81999d4514f1d10aef25a5a38a592f Use assertEqual() rather than assertEquals() in Python tests. (raphael.kubo.da.costa@intel.com)
  https://crrev.com/0ca844e294d930184ce4859fff5d558b0e754c44 upload_to_google_storage_unittest.py: Make StringIO usage Python 3-compatible (raphael.kubo.da.costa@intel.com)
  https://crrev.com/377d251f10614cc178f7d56d7425d62107972def Make download_from_google_storage_unittest.py work with Python 3. (raphael.kubo.da.costa@intel.com)
  https://crrev.com/1ab0a72d103d7731b2328df730594656cd1a98fd Make upload_to_google_storage.py and tests work with Python 3. (raphael.kubo.da.costa@intel.com)
  https://crrev.com/e16ffffc28f3985c98cfc495840e93d9afa8884e Add logging to bot_update.py and gclient_scm.py (erikchen@chromium.org)
  https://crrev.com/c6512213a7b74a8363c93788a9c376ebaeb4ec6c depot_tools: Run recipe scripts using vpython. (ehmaldonado@chromium.org)
  https://crrev.com/61d3d4b0bd55ee9027a831d27210ddfcbb9531a7 Revert "depot_tools: Run recipe scripts using vpython." (machenbach@chromium.org)
  https://crrev.com/ba97f6065ed1e9336585468dd85e680cf09d5166 Trivial: Removing gendered pronouns from watchlists.py. (chrishall@google.com)
  https://crrev.com/a0568178808dbdb5646474532f559ed47b5e0a78 depot-tools: Remove support for --auth-refresh-token-json. (ehmaldonado@chromium.org)
  https://crrev.com/812ac228e3fe9950338265760d65004c8cb23749 git-cl: Add diff lines of context setting. (jmadill@chromium.org)
  https://crrev.com/55e5853e5ce49fda2589948c5a0fa6a56d4b3015 depot_tools: Stop using oauth2client (ehmaldonado@chromium.org)
  https://crrev.com/6e48505301f4144dee51e90a40ba8a32f346a266 put goma client in depot_tools (ukai@google.com)
  https://crrev.com/8076771cb14634c62b8f2eec87c2947b7682b66d Revert "put goma client in depot_tools" (ukai@chromium.org)
  https://crrev.com/989bc351863dd6cbb7e645a027a3c5e04104e44f Revert "depot_tools: Stop using oauth2client" (ehmaldonado@chromium.org)
recipe_engine:
  https://crrev.com/950046182d106b95a9686c6c9b168f53da83be57 [buildbucket] Inherit child fields from parent (olivernewman@google.com)
  https://crrev.com/b136036c0d8153d4ecd15d78c639cf18a5edc021 Revert "[buildbucket] Inherit child fields from parent" (machenbach@chromium.org)
  https://crrev.com/2e4e53bf9cdae23c725d97942ac9a99ca730e9d0 Reland "[buildbucket] Inherit child fields from parent" (olivernewman@google.com)
  https://crrev.com/713cbe54d445dcc8d9c67bce559ccc4ed82c1a54 properties: deprecate buildbot-like usage of its test_api. (tandrii@google.com)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ic7b918271d6b9ed7e708cd3ed8d95020420e5f7f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/249288
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2019-10-17 21:40:09 +00:00