Go to file
Mike Klein 024072af62 Reland "Improve degenerate 2pt conical gradient cases"
This reverts commit 95af4726bf.

Reason for revert: I think this may not have been the reason the Android roll was failing.  We've rolled, so it's a good time to try again.

Original change's description:
> Revert "Improve degenerate 2pt conical gradient cases"
> 
> This reverts commit 879dab87ab.
> 
> Reason for revert: Android roll failed.
> https://sponge.corp.google.com/target?id=93bc6b8d-9b42-4805-b204-46ae62f1b005&target=x86+CtsGraphicsTestCases&searchFor=&show=FAILED&sortBy=STATUS
> A test VectorDrawableTest.testVectorDrawableGradient fails.
> 
> Original change's description:
> > Improve degenerate 2pt conical gradient cases
> > 
> > This was originally a reland of "Fix div-by-zero loophole in gradient factory func", c34dd6c526, but:
> > 
> > The change caused blink layout tests when encountering very small or zero radii. The original patch switched the order of checking if the radii are equal and if the start radius was 0. In the case where both radii are 0, the original code created an actual radial gradient of radius 0 and the new code rejected the shader. A radial gradient with radius of 0 properly renders the last border color as a fill.
> > 
> > This made me realize that the case when the center positions and the radii are the same can be handled more correctly than just always returning an empty shader, so the fix now applies simplifications to the gradient definition depending on the tile mode and should not trigger any blink tests. I added a row to the gradient edge cases GM to make sure it degrades gracefully.
> > 
> > Original change's description:
> > > Fix div-by-zero loophole in gradient factory func
> > >
> > > Bug: oss-fuzz:10373
> > > Change-Id: I4277fb63e3186ee34feaf09ecf6aeddeb532f9c1
> > > Reviewed-on: https://skia-review.googlesource.com/c/168269
> > > Reviewed-by: Kevin Lubick <kjlubick@google.com>
> > > Commit-Queue: Michael Ludwig <michaelludwig@google.com>
> > 
> > Docs-Preview: https://skia.org/?cl=168487
> > Bug: oss-fuzz:10373
> > Change-Id: Ib0a6e7f807560a5dcf24d1c8e0146817af2d9606
> > Reviewed-on: https://skia-review.googlesource.com/c/168487
> > Reviewed-by: Mike Reed <reed@google.com>
> > Reviewed-by: Florin Malita <fmalita@chromium.org>
> > Commit-Queue: Michael Ludwig <michaelludwig@google.com>
> 
> TBR=caryclark@google.com,fmalita@chromium.org,fmalita@google.com,reed@google.com,michaelludwig@google.com
> 
> Change-Id: I91b896c4a438c02206679b327a01b47f40993965
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: oss-fuzz:10373
> Reviewed-on: https://skia-review.googlesource.com/c/170272
> Reviewed-by: Stan Iliev <stani@google.com>
> Commit-Queue: Stan Iliev <stani@google.com>

TBR=caryclark@google.com,fmalita@chromium.org,fmalita@google.com,reed@google.com,stani@google.com,michaelludwig@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: oss-fuzz:10373
Change-Id: I7577fcea9eb8a875e94723ab2cca2fcc990b82b2
Reviewed-on: https://skia-review.googlesource.com/c/170279
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2018-11-11 00:28:01 +00:00
animations first cut at a checkbox 2009-10-21 19:41:10 +00:00
bench Reland "Move remove ptr args to MakeRecAndEffects" 2018-11-09 20:01:42 +00:00
bin Add script to pull svgs to svgs/ and add to .gitignore 2018-08-31 20:02:24 +00:00
dm [skottie] Make animated image support generally available 2018-11-10 19:52:19 +00:00
docker Convert skottie's cloud build to use CanvasKit 2018-11-10 12:06:32 +00:00
docs fix bookmaker 2018-11-10 04:49:37 +00:00
example Compile with GCC 7.2.0. 2018-03-13 22:18:18 +00:00
experimental Reland "simplify disabling effect deserialization" 2018-11-08 14:26:52 +00:00
fuzz Revert "rm legacy flags for hinting enum" 2018-11-09 21:59:17 +00:00
gm Reland "Improve degenerate 2pt conical gradient cases" 2018-11-11 00:28:01 +00:00
gn Reland "Improve degenerate 2pt conical gradient cases" 2018-11-11 00:28:01 +00:00
include Reland "Improve degenerate 2pt conical gradient cases" 2018-11-11 00:28:01 +00:00
infra Update go_deps asset 2018-11-10 05:54:53 +00:00
modules [skottie] Make animated image support generally available 2018-11-10 19:52:19 +00:00
platform_tools Skottie Android demo app improvements 2018-11-07 15:41:34 +00:00
resources Test a GIF with an out of range transparent index 2018-10-12 14:20:02 +00:00
samplecode Reland "Move remove ptr args to MakeRecAndEffects" 2018-11-09 20:01:42 +00:00
site fix bookmaker 2018-11-10 04:49:37 +00:00
src Reland "Improve degenerate 2pt conical gradient cases" 2018-11-11 00:28:01 +00:00
tests add fontmetrics to SkFont 2018-11-10 13:28:04 +00:00
third_party Roll skia/third_party/skcms 26679709b32f..ee5557693416 (1 commits) 2018-11-07 14:53:31 +00:00
tools [skottie] Make animated image support generally available 2018-11-10 19:52:19 +00:00
.clang-format clean up flattenable macro cruft 2018-10-19 16:18:32 +00:00
.gitignore Add script to pull svgs to svgs/ and add to .gitignore 2018-08-31 20:02:24 +00:00
.gn Basic standalone GN configs. 2016-07-21 12:25:45 -07:00
AUTHORS Fixed SkVertices crashing on Windows DLL builds 2018-04-22 14:42:01 +00:00
BUILD.gn [skottie] Make animated image support generally available 2018-11-10 19:52:19 +00:00
codereview.settings Make uploading to Gerrit the default for Skia 2016-11-09 19:07:56 +00:00
CONTRIBUTING Fix references to https://sites.google.com/site/skiadocs/. 2015-02-03 13:12:54 -02:00
CQ_COMMITTERS Moved committer list to chrome-infra-auth and deleted it from the repo 2015-09-02 13:37:54 -07:00
DEPS Roll third_party/externals/angle2 5d2dfa46c05c..50bf0429394d (1 commits) 2018-11-09 21:31:33 +00:00
Doxyfile Make the housekeeper upload doxygen to a newer bucket 2016-10-04 13:23:57 -07:00
LICENSE BUG=skia:5602 2016-09-02 11:19:34 -07:00
OWNERS add OWNERS file 2017-12-01 19:50:19 +00:00
PRESUBMIT.py Add new autoroll service accounts to AUTHORS check bypass 2018-09-07 18:49:23 +00:00
public.bzl [skottie] Make animated image support generally available 2018-11-10 19:52:19 +00:00
README Fix references to https://sites.google.com/site/skiadocs/. 2015-02-03 13:12:54 -02:00
README.chromium Update README.chromium. 2015-06-11 13:19:24 -07:00
whitespace.txt [infra] Marker for IntelBayTrail BIOS update. 2018-09-17 16:47:35 +00:00

Skia is a complete 2D graphic library for drawing Text, Geometries, and Images.

See full details, and build instructions, at https://skia.org.