19f466d399
With the addition of the DDL program pre-compilation we need to know how it is working. This CL also fixes some threading bugs. Bug: skia:9455 Change-Id: I20da58a7f1b19685687fae1d159d4e0db8a4964d Reviewed-on: https://skia-review.googlesource.com/c/skia/+/273001 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
224 lines
7.8 KiB
C++
224 lines
7.8 KiB
C++
/*
|
|
* Copyright 2018 Google Inc.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license that can be
|
|
* found in the LICENSE file.
|
|
*/
|
|
|
|
#include "tools/DDLTileHelper.h"
|
|
|
|
#include "include/core/SkCanvas.h"
|
|
#include "include/core/SkDeferredDisplayListRecorder.h"
|
|
#include "include/core/SkPicture.h"
|
|
#include "include/core/SkSurface.h"
|
|
#include "include/core/SkSurfaceCharacterization.h"
|
|
#include "src/core/SkDeferredDisplayListPriv.h"
|
|
#include "src/core/SkTaskGroup.h"
|
|
#include "src/gpu/GrContextPriv.h"
|
|
#include "src/image/SkImage_Gpu.h"
|
|
#include "tools/DDLPromiseImageHelper.h"
|
|
|
|
void DDLTileHelper::TileData::init(int id,
|
|
sk_sp<SkSurface> dstSurface,
|
|
const SkSurfaceCharacterization& dstSurfaceCharacterization,
|
|
const SkIRect& clip) {
|
|
fID = id;
|
|
fDstSurface = dstSurface;
|
|
fClip = clip;
|
|
|
|
fCharacterization = dstSurfaceCharacterization.createResized(clip.width(), clip.height());
|
|
SkASSERT(fCharacterization.isValid());
|
|
}
|
|
|
|
DDLTileHelper::TileData::~TileData() {}
|
|
|
|
void DDLTileHelper::TileData::createTileSpecificSKP(SkData* compressedPictureData,
|
|
const DDLPromiseImageHelper& helper) {
|
|
SkASSERT(!fReconstitutedPicture);
|
|
|
|
// This is bending the DDLRecorder contract! The promise images in the SKP should be
|
|
// created by the same recorder used to create the matching DDL.
|
|
SkDeferredDisplayListRecorder recorder(fCharacterization);
|
|
|
|
fReconstitutedPicture = helper.reinflateSKP(&recorder, compressedPictureData, &fPromiseImages);
|
|
|
|
std::unique_ptr<SkDeferredDisplayList> ddl = recorder.detach();
|
|
if (ddl->priv().numRenderTasks()) {
|
|
// TODO: remove this once skbug.com/8424 is fixed. If the DDL resulting from the
|
|
// reinflation of the SKPs contains opsTasks that means some image subset operation
|
|
// created a draw.
|
|
fReconstitutedPicture.reset();
|
|
}
|
|
}
|
|
|
|
void DDLTileHelper::TileData::createDDL() {
|
|
SkASSERT(!fDisplayList);
|
|
|
|
SkDeferredDisplayListRecorder recorder(fCharacterization);
|
|
|
|
// DDL TODO: the DDLRecorder's GrContext isn't initialized until getCanvas is called.
|
|
// Maybe set it up in the ctor?
|
|
SkCanvas* subCanvas = recorder.getCanvas();
|
|
|
|
// Because we cheated in createTileSpecificSKP and used the wrong DDLRecorder, the GrContext's
|
|
// stored in fReconstitutedPicture's promise images are incorrect. Patch them with the correct
|
|
// one now.
|
|
for (int i = 0; i < fPromiseImages.count(); ++i) {
|
|
GrContext* newContext = subCanvas->getGrContext();
|
|
|
|
if (fPromiseImages[i]->isTextureBacked()) {
|
|
SkImage_GpuBase* gpuImage = (SkImage_GpuBase*) fPromiseImages[i].get();
|
|
gpuImage->resetContext(sk_ref_sp(newContext));
|
|
}
|
|
}
|
|
|
|
subCanvas->clipRect(SkRect::MakeWH(fClip.width(), fClip.height()));
|
|
subCanvas->translate(-fClip.fLeft, -fClip.fTop);
|
|
|
|
// Note: in this use case we only render a picture to the deferred canvas
|
|
// but, more generally, clients will use arbitrary draw calls.
|
|
if (fReconstitutedPicture) {
|
|
subCanvas->drawPicture(fReconstitutedPicture);
|
|
}
|
|
|
|
fDisplayList = recorder.detach();
|
|
}
|
|
|
|
void DDLTileHelper::TileData::draw(GrContext* context) {
|
|
SkASSERT(fDisplayList && !fImage);
|
|
|
|
sk_sp<SkSurface> tileSurface = SkSurface::MakeRenderTarget(context, fCharacterization,
|
|
SkBudgeted::kYes);
|
|
if (tileSurface) {
|
|
tileSurface->draw(fDisplayList.get());
|
|
|
|
fImage = tileSurface->makeImageSnapshot();
|
|
}
|
|
}
|
|
|
|
// TODO: We should create a single DDL for the composition step and just add replaying it
|
|
// as the last GPU task
|
|
void DDLTileHelper::TileData::compose() {
|
|
SkASSERT(fDstSurface && fImage);
|
|
|
|
SkCanvas* canvas = fDstSurface->getCanvas();
|
|
canvas->save();
|
|
canvas->clipRect(SkRect::Make(fClip));
|
|
canvas->drawImage(fImage, fClip.fLeft, fClip.fTop);
|
|
canvas->restore();
|
|
}
|
|
|
|
void DDLTileHelper::TileData::reset() {
|
|
// TODO: when DDLs are re-renderable we don't need to do this
|
|
fDisplayList = nullptr;
|
|
}
|
|
|
|
///////////////////////////////////////////////////////////////////////////////////////////////////
|
|
|
|
DDLTileHelper::DDLTileHelper(sk_sp<SkSurface> dstSurface,
|
|
const SkSurfaceCharacterization& dstChar,
|
|
const SkIRect& viewport,
|
|
int numDivisions)
|
|
: fNumDivisions(numDivisions) {
|
|
SkASSERT(fNumDivisions > 0);
|
|
fTiles = new TileData[this->numTiles()];
|
|
|
|
int xTileSize = viewport.width()/fNumDivisions;
|
|
int yTileSize = viewport.height()/fNumDivisions;
|
|
|
|
// Create the destination tiles
|
|
for (int y = 0, yOff = 0; y < fNumDivisions; ++y, yOff += yTileSize) {
|
|
int ySize = (y < fNumDivisions-1) ? yTileSize : viewport.height()-yOff;
|
|
|
|
for (int x = 0, xOff = 0; x < fNumDivisions; ++x, xOff += xTileSize) {
|
|
int xSize = (x < fNumDivisions-1) ? xTileSize : viewport.width()-xOff;
|
|
|
|
SkIRect clip = SkIRect::MakeXYWH(xOff, yOff, xSize, ySize);
|
|
|
|
SkASSERT(viewport.contains(clip));
|
|
|
|
fTiles[y*fNumDivisions+x].init(y*fNumDivisions+x, dstSurface, dstChar, clip);
|
|
}
|
|
}
|
|
}
|
|
|
|
void DDLTileHelper::createSKPPerTile(SkData* compressedPictureData,
|
|
const DDLPromiseImageHelper& helper) {
|
|
for (int i = 0; i < this->numTiles(); ++i) {
|
|
fTiles[i].createTileSpecificSKP(compressedPictureData, helper);
|
|
}
|
|
}
|
|
|
|
void DDLTileHelper::createDDLsInParallel() {
|
|
#if 1
|
|
SkTaskGroup().batch(this->numTiles(), [&](int i) { fTiles[i].createDDL(); });
|
|
SkTaskGroup().wait();
|
|
#else
|
|
// Use this code path to debug w/o threads
|
|
for (int i = 0; i < fTiles.count(); ++i) {
|
|
fTiles[i].createDDL();
|
|
}
|
|
#endif
|
|
}
|
|
|
|
// On the gpu thread:
|
|
// precompile any programs
|
|
// replay the DDL into a surface to make the tile image
|
|
// compose the tile image into the main canvas
|
|
static void do_gpu_stuff(GrContext* context, DDLTileHelper::TileData* tile) {
|
|
|
|
// TODO: schedule program compilation as their own tasks
|
|
SkDeferredDisplayList::ProgramIterator iter(context, tile->ddl());
|
|
for (; !iter.done(); iter.next()) {
|
|
iter.compile();
|
|
}
|
|
|
|
tile->draw(context);
|
|
|
|
// TODO: we should actually have a separate DDL that does
|
|
// the final composition draw
|
|
tile->compose();
|
|
}
|
|
|
|
// We expect to have more than one recording thread but just one gpu thread
|
|
void DDLTileHelper::kickOffThreadedWork(SkTaskGroup* recordingTaskGroup,
|
|
SkTaskGroup* gpuTaskGroup,
|
|
GrContext* gpuThreadContext) {
|
|
SkASSERT(recordingTaskGroup && gpuTaskGroup && gpuThreadContext);
|
|
|
|
for (int i = 0; i < this->numTiles(); ++i) {
|
|
TileData* tile = &fTiles[i];
|
|
|
|
// On a recording thread:
|
|
// generate the tile's DDL
|
|
// schedule gpu-thread processing of the DDL
|
|
// Note: a finer grained approach would be add a scheduling task which would evaluate
|
|
// which DDLs were ready to be rendered based on their prerequisites
|
|
recordingTaskGroup->add([tile, gpuTaskGroup, gpuThreadContext]() {
|
|
tile->createDDL();
|
|
|
|
gpuTaskGroup->add([gpuThreadContext, tile]() {
|
|
do_gpu_stuff(gpuThreadContext, tile);
|
|
});
|
|
});
|
|
}
|
|
}
|
|
|
|
void DDLTileHelper::drawAllTiles(GrContext* context) {
|
|
for (int i = 0; i < this->numTiles(); ++i) {
|
|
fTiles[i].draw(context);
|
|
}
|
|
}
|
|
|
|
void DDLTileHelper::composeAllTiles() {
|
|
for (int i = 0; i < this->numTiles(); ++i) {
|
|
fTiles[i].compose();
|
|
}
|
|
}
|
|
|
|
void DDLTileHelper::resetAllTiles() {
|
|
for (int i = 0; i < this->numTiles(); ++i) {
|
|
fTiles[i].reset();
|
|
}
|
|
}
|