279c786409
Why have two names if we can get away with one? This kills off sk_parallel_for_thread_count(), which was only used to avoid forcing a deadlock in OncePtrTest on multicore machines in singlethreaded mode... a really niche use case. Instead just don't explicitly force a race. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1552093002 Review URL: https://codereview.chromium.org/1552093002
44 lines
985 B
C++
44 lines
985 B
C++
/*
|
|
* Copyright 2015 Google Inc.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license that can be
|
|
* found in the LICENSE file.
|
|
*/
|
|
|
|
#include "Test.h"
|
|
#include "SkOncePtr.h"
|
|
#include "SkTaskGroup.h"
|
|
|
|
DEF_TEST(OncePtr, r) {
|
|
SkOncePtr<int> once;
|
|
|
|
static SkAtomic<int> calls(0);
|
|
auto create = [&] {
|
|
calls.fetch_add(1);
|
|
return new int(5);
|
|
};
|
|
|
|
SkTaskGroup().batch(sk_num_cores()*4, [&](size_t) {
|
|
int* n = once.get(create);
|
|
REPORTER_ASSERT(r, *n == 5);
|
|
});
|
|
REPORTER_ASSERT(r, calls.load() == 1);
|
|
}
|
|
|
|
/* TODO(mtklein): next CL
|
|
|
|
SK_DECLARE_STATIC_ONCE(once_noptr);
|
|
DEF_TEST(OnceNoPtr, r) {
|
|
static SkAtomic<int> calls(0);
|
|
|
|
SkAtomic<int> force_a_race(sk_num_cores());
|
|
SkTaskGroup().batch(sk_num_cores()*4, [&](size_t) {
|
|
force_a_race.fetch_add(-1);
|
|
while (force_a_race.load() > 0);
|
|
|
|
SkOnce(&once_noptr, [&] { calls.fetch_add(1); });
|
|
});
|
|
REPORTER_ASSERT(r, calls.load() == 1);
|
|
}
|
|
*/
|