Go to file
Matt Sarett 17e494070a Revert "SkColorSpaceXform bug fixes"
This reverts commit d0fdc0f234.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> SkColorSpaceXform bug fixes
> 
> (1) Clamp properly!
> 
> Finally came to this realization: clamping in the
> store functions (after gamma encoding) is ridiculous.
> It is impossible to know how to clamp premul values
> to alpha when they are already gamma encoded.
> 
> I've moved the clamp out of the store function.
> Whew, this actually makes the code look simpler.
> 
> And I expect this to fix some buggy images on Gold!
> 
> (2) Correctly handle the memcpy() case.
> 
> Looks like this only ever worked for RGBA inputs,
> never got updated when we added BGRA inputs.
> 
> This probably flew under the radar because the
> clients are smart enough to avoid performing a
> color xform altogether when the color spaces
> match.
> 
> BUG=skia:
> 
> Change-Id: I4870048105efcbecc70b4bd5f77c39537006363e
> Reviewed-on: https://skia-review.googlesource.com/5389
> Commit-Queue: Mike Klein <mtklein@chromium.org>
> Reviewed-by: Mike Klein <mtklein@chromium.org>
> 

TBR=mtklein@chromium.org,mtklein@google.com,msarett@google.com,reviews@skia.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Change-Id: Id9e4cfdaa7b30a3841e83c4cde16aa7d33acc0f2
Reviewed-on: https://skia-review.googlesource.com/5457
Commit-Queue: Matt Sarett <msarett@google.com>
Reviewed-by: Matt Sarett <msarett@google.com>
2016-12-01 20:29:20 +00:00
animations first cut at a checkbox 2009-10-21 19:41:10 +00:00
bench SkEncodeImage: no more link-time registration 2016-11-30 22:48:56 +00:00
bin Build for Android from Windows, work in progress. 2016-10-26 14:37:43 +00:00
debugger SkEncodeImage: no more link-time registration 2016-11-30 22:48:56 +00:00
dm Added CMYK support for ICC profiles. 2016-12-01 19:42:32 +00:00
example bench, samples, etc: s/SkAutoTUnref/sk_sp/ 2016-11-07 15:17:32 +00:00
experimental remove more old cmake files 2016-11-30 20:37:45 +00:00
fuzz Rename SkSL::GLSLCapsFactory to SkSL::ShaderCapsFactory 2016-11-29 21:12:45 +00:00
gm Added CMYK support for ICC profiles. 2016-12-01 19:42:32 +00:00
gn Added CMYK support for ICC profiles. 2016-12-01 19:42:32 +00:00
gyp SkEncodeImage: no more link-time registration 2016-11-30 22:48:56 +00:00
include Revert of Enable sRGB on iOS, make sRGB decode support optional (patchset #11 id:200001 of https://codereview.chromium.org/2539993002/ ) 2016-12-01 10:42:04 -08:00
infra [nobuildbot] CT bots 2016-12-01 04:40:57 +00:00
platform_tools bench, samples, etc: s/SkAutoTUnref/sk_sp/ 2016-11-07 15:17:32 +00:00
resources Fail jpeg decodes on too many progressive scans 2016-11-08 21:39:15 +00:00
samplecode SkEncodeImage: no more link-time registration 2016-11-30 22:48:56 +00:00
site Clarify documentation for CQ_INCLUDE_TRYBOTS. 2016-11-30 15:39:31 +00:00
src Revert "SkColorSpaceXform bug fixes" 2016-12-01 20:29:20 +00:00
tests Added CMYK support for ICC profiles. 2016-12-01 19:42:32 +00:00
third_party third_party/ktx: put WriteBitmapToKTX back 2016-12-01 17:45:12 +00:00
tools Revert of Enable sRGB on iOS, make sRGB decode support optional (patchset #11 id:200001 of https://codereview.chromium.org/2539993002/ ) 2016-12-01 10:42:04 -08:00
.gitignore Remove skia.conf from .gitignore 2016-10-26 14:50:09 +00:00
.gn Basic standalone GN configs. 2016-07-21 12:25:45 -07:00
AUTHORS Fix typo in GrGLCaps 2016-11-18 23:20:51 +00:00
BUILD.gn SkEncodeImage: no more link-time registration 2016-11-30 22:48:56 +00:00
codereview.settings Make uploading to Gerrit the default for Skia 2016-11-09 19:07:56 +00:00
CONTRIBUTING Fix references to https://sites.google.com/site/skiadocs/. 2015-02-03 13:12:54 -02:00
CQ_COMMITTERS Moved committer list to chrome-infra-auth and deleted it from the repo 2015-09-02 13:37:54 -07:00
DEPS Update PIEX 2016-11-28 13:55:48 +00:00
Doxyfile Make the housekeeper upload doxygen to a newer bucket 2016-10-04 13:23:57 -07:00
fix-gn-sln.py VS script: Handle variation among configurations 2016-11-21 16:35:39 +00:00
gyp_skia Make Win runtime DLLs writeable before overwriting 2016-03-18 08:33:38 -07:00
gyp_skia.py Roll gyp deps from 1765 to 1796. 2013-11-21 18:11:14 +00:00
LICENSE BUG=skia:5602 2016-09-02 11:19:34 -07:00
make.bat Fix references to https://sites.google.com/site/skiadocs/. 2015-02-03 13:12:54 -02:00
make.py GYP: remove stale skia_scalar gyp variable 2015-11-10 13:25:12 -05:00
Makefile Add visualbench as valid target to Makefile 2015-12-18 08:05:06 -08:00
OWNERS add root files from chrome 2013-08-13 19:11:15 +00:00
PRESUBMIT.py Do not use post upload hooks for 'GOLD_TRYBOT_URL' 2016-11-23 18:34:23 +00:00
public.bzl Merge changes from internal cl/140385880. 2016-11-28 22:21:34 +00:00
README Fix references to https://sites.google.com/site/skiadocs/. 2015-02-03 13:12:54 -02:00
README.chromium Update README.chromium. 2015-06-11 13:19:24 -07:00
skia.gyp Fix references to https://sites.google.com/site/skiadocs/. 2015-02-03 13:12:54 -02:00
whitespace.txt Blame this CL for GTX660 changes. 2016-11-02 22:03:53 +00:00

Skia is a complete 2D graphic library for drawing Text, Geometries, and Images.

See full details, and build instructions, at https://skia.org.