AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
1cf02a8adf
skia2/include/effects
History
commit-bot@chromium.org 4b681bc95b Fixed issues found by fuzzer 
Last week, the fuzzer found a few numerical issue with filters and I had written some fixes for them. Here are the fixes with some unit tests.

For senorblanco : So I figured out what was asserting when we'd get a 0 width "result" in SkBicubicImageFilter::onFilterImage(). Basically, if the "result" SkBitmap object calls SkBitmap::setConfig() with "width" and/or "height" set to 0, then the SkBitmap object will call SkBitmap::reset(), making the SkBitmap object's config invalid. At this point, calling SkBitmap::getAddr32() will assert, even without attempting to dereference the data pointer, because the SkBitmap's config is invalid. If height is valid, but width is 0, then this call to SkBitmap::getAddr32() happens directly in SkBicubicImageFilter::onFilterImage() a few lines lower and asserts right away.

BUG=
R=senorblanco@google.com, senorblanco@chromium.org, bsalomon@google.com

Author: sugoi@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23533042

git-svn-id: http://skia.googlecode.com/svn/trunk@11249 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-13 12:40:02 +00:00
..
Sk1DPathEffect.h add optional cull-rect to patheffects, so they can do less work if their results 2013-01-24 21:03:11 +00:00
Sk2DPathEffect.h add optional cull-rect to patheffects, so they can do less work if their results 2013-01-24 21:03:11 +00:00
SkArithmeticMode.h Provide a GPU implementation of SkArithmeticMode, using a custom GrEffect exposed via asNewEffectOrCoeff(). 2013-05-29 20:55:09 +00:00
SkAvoidXfermode.h remove dst/rendertarget support for kARGB_4444_Config 2013-06-21 18:30:53 +00:00
SkBicubicImageFilter.h Added ctm matrix to GPU path 2013-08-05 16:53:50 +00:00
SkBitmapAlphaThresholdShader.h alpha threshold bitmap shader 2013-09-06 15:31:06 +00:00
SkBitmapSource.h Export effects classes with SK_API. 2012-10-12 14:41:39 +00:00
SkBlurDrawLooper.h Blur refactoring 2013-08-27 16:14:03 +00:00
SkBlurImageFilter.h Added ctm matrix to GPU path 2013-08-05 16:53:50 +00:00
SkBlurMaskFilter.h Sanitizing source files in Housekeeper-Nightly 2013-08-28 07:01:18 +00:00
SkColorFilterImageFilter.h This patch implements a crop rect for SkImageFilter. It has been implemented for SkColorFilterImageFilter and SkBlurImageFilter as examples. 2013-07-24 22:19:24 +00:00
SkColorMatrix.h Use GrCustomStage to implement color matrix. 2012-10-17 13:36:14 +00:00
SkColorMatrixFilter.h Add printing of SkColorFilter-derived classes to debugger 2013-05-23 14:00:17 +00:00
SkComposeImageFilter.h Move SkComposeImageFilter into its own {.h, .cpp} files 2013-08-07 00:07:51 +00:00
SkCornerPathEffect.h add optional cull-rect to patheffects, so they can do less work if their results 2013-01-24 21:03:11 +00:00
SkDashPathEffect.h add optional cull-rect to patheffects, so they can do less work if their results 2013-01-24 21:03:11 +00:00
SkDiscretePathEffect.h add optional cull-rect to patheffects, so they can do less work if their results 2013-01-24 21:03:11 +00:00
SkDisplacementMapEffect.h Added ctm matrix to GPU path 2013-08-05 16:53:50 +00:00
SkDrawExtraPathEffect.h Export effects classes with SK_API. 2012-10-12 14:41:39 +00:00
SkDropShadowImageFilter.h Upstreaming DropShadowImageFilter into skia, from Blink 2013-08-07 20:00:55 +00:00
SkEmbossMaskFilter.h Blur refactoring 2013-08-27 16:14:03 +00:00
SkGradientShader.h Add flag to gradients to interpolate colors in premul space. Experimental API to encapsulate the shared parameters for all gradients into a struct. 2013-05-24 14:58:44 +00:00
SkKernel33MaskFilter.h Added toString to SkMaskFilter-derived classes 2013-03-18 17:53:38 +00:00
SkLayerDrawLooper.h Add methods to SkLayerDrawLooper to allow adding layers on top 2013-05-22 12:35:50 +00:00
SkLayerRasterizer.h change all interfaces for SkRasterizer to const, in preparation for marking it 2012-12-18 16:57:03 +00:00
SkLerpXfermode.h add SkLerpXfermode 2013-05-21 21:33:11 +00:00
SkLightingImageFilter.h Fixed issues found by fuzzer 2013-09-13 12:40:02 +00:00
SkLumaXfermode.h Add luminance mask transfer modes. 2013-08-23 13:13:12 +00:00
SkMagnifierImageFilter.h In image filters, apply the CTM and offset to the crop rect. This is necessary to compensate for both clipping applied by the compositor (communicated via the CTM) and for cropping applied in upstream image filters (communicated via the offset). This requires a few ugly conversions, since the crop rect is an SkIRect, and the ctm is an SkMatrix. 2013-08-27 21:37:01 +00:00
SkMatrixConvolutionImageFilter.h In image filters, apply the CTM and offset to the crop rect. This is necessary to compensate for both clipping applied by the compositor (communicated via the CTM) and for cropping applied in upstream image filters (communicated via the offset). This requires a few ugly conversions, since the crop rect is an SkIRect, and the ctm is an SkMatrix. 2013-08-27 21:37:01 +00:00
SkMergeImageFilter.h Pull SkMergeImageFilter out into its own file. 2012-12-04 14:18:50 +00:00
SkMorphologyImageFilter.h Added ctm matrix to GPU path 2013-08-05 16:53:50 +00:00
SkOffsetImageFilter.h Nuke SkSingleInputImageFilter. 99% of its functionality was refactored into SkImageFilterUtils in https://code.google.com/p/skia/source/detail?r=7467, so it has outlived its usefulness. 2013-02-04 22:57:21 +00:00
SkPaintFlagsDrawFilter.h change SkDrawFilter::filter to return a bool, where false means don't-draw 2012-11-26 20:26:54 +00:00
SkPerlinNoiseShader.h Adding missing SK_API identifier to class so that it's accessible in debug blink. 2013-04-25 14:54:15 +00:00
SkPixelXorXfermode.h Added toString to SkXfermode-derived classes (for debugger) 2013-01-22 14:32:09 +00:00
SkPorterDuff.h clone of https://codereview.appspot.com/7208043/ 2013-01-30 21:36:11 +00:00
SkRectShaderImageFilter.h Small adjustments to SkRectShaderImageFilter to follow up on original cl. 2013-02-21 20:26:50 +00:00
SkStippleMaskFilter.h Added toString to SkMaskFilter-derived classes 2013-03-18 17:53:38 +00:00
SkTableColorFilter.h Result of running tools/sanitize_source_files.py (which was added in https://codereview.appspot.com/6465078/) 2012-08-23 18:09:54 +00:00
SkTableMaskFilter.h Added toString to SkMaskFilter-derived classes 2013-03-18 17:53:38 +00:00
SkTestImageFilters.h Move SkComposeImageFilter into its own {.h, .cpp} files 2013-08-07 00:07:51 +00:00
SkTransparentShader.h Added print out of SkShader information to debugger 2013-01-15 20:17:47 +00:00
SkXfermodeImageFilter.h Added ctm matrix to GPU path 2013-08-05 16:53:50 +00:00